Dashboard UI audit, November 2026 #1768

Closed
opened 2026-11-02 04:15:41 +00:00 by sam · 1 comment
Owner

Tracks the findings of a full read of ui/src against ui/CLAUDE.md and the brand rules. Brand tokens, the OS-following theme, IBM Plex and the topbar mark were found correct; the findings are behaviour, accessibility and consistency.

Suggested order: silent work loss first, then error-as-empty and stale responses with one shared convention each, then keyboard and contrast.

High

  • #1728 Chat: failed answer deletes the question
  • #1729 Chat: conversation switch mid-turn misroutes the reply
  • #1730 Org policies: New policy edits the open policy
  • #1731 Workflow editor: failed draft save dropped
  • #1732 Workflows: failed reads show as empty
  • #1733 Dashboard: failed reads show as empty
  • #1734 Tasks and events: stale responses
  • #1735 Workflow step not keyboard-editable
  • #1736 Fields with no accessible name
  • #1737 Focus ring under 3:1
  • #1738 Raw startup error screen

Medium

  • #1739 Terminals dark in light theme
  • #1740 Undefined classes and variables
  • #1741 Low-contrast tabs, toggles, borders, idle text
  • #1742 Empty state while loading
  • #1743 Blank settings pages until load
  • #1744 One error presentation with Retry
  • #1745 Tasks: Load more failure, panel flashing
  • #1746 Logs: error flicker, unbounded entries
  • #1747 Alerts: state not shared
  • #1748 Chat: failures that show nothing
  • #1749 Destructive actions without confirmation
  • #1750 Table rows with link/button roles
  • #1751 No headings or nav landmark
  • #1752 Information only in hover tooltips
  • #1753 Palettes and labels not wired for AT
  • #1754 Remaining stale responses
  • #1755 Harness terminal failure and reopen
  • #1756 Smaller state bugs
  • #1757 Phone width with seeded data
  • #1758 Adopt the type scale
  • #1759 Replace hand-rolled components
  • #1760 Select for known options, server vocabularies
  • #1761 Time zone and duration formats
  • #1767 e2e checks for these failure classes

Low

  • #1762 Copy pass
  • #1763 Dead code and legacy redirects
  • #1764 Formatting
  • #1765 Small accessibility fixes
  • #1766 Token and layout polish
Tracks the findings of a full read of `ui/src` against `ui/CLAUDE.md` and the brand rules. Brand tokens, the OS-following theme, IBM Plex and the topbar mark were found correct; the findings are behaviour, accessibility and consistency. Suggested order: silent work loss first, then error-as-empty and stale responses with one shared convention each, then keyboard and contrast. **High** - [ ] #1728 Chat: failed answer deletes the question - [ ] #1729 Chat: conversation switch mid-turn misroutes the reply - [ ] #1730 Org policies: New policy edits the open policy - [ ] #1731 Workflow editor: failed draft save dropped - [ ] #1732 Workflows: failed reads show as empty - [ ] #1733 Dashboard: failed reads show as empty - [ ] #1734 Tasks and events: stale responses - [ ] #1735 Workflow step not keyboard-editable - [ ] #1736 Fields with no accessible name - [ ] #1737 Focus ring under 3:1 - [ ] #1738 Raw startup error screen **Medium** - [ ] #1739 Terminals dark in light theme - [ ] #1740 Undefined classes and variables - [ ] #1741 Low-contrast tabs, toggles, borders, idle text - [ ] #1742 Empty state while loading - [ ] #1743 Blank settings pages until load - [ ] #1744 One error presentation with Retry - [ ] #1745 Tasks: Load more failure, panel flashing - [ ] #1746 Logs: error flicker, unbounded entries - [ ] #1747 Alerts: state not shared - [ ] #1748 Chat: failures that show nothing - [ ] #1749 Destructive actions without confirmation - [ ] #1750 Table rows with link/button roles - [ ] #1751 No headings or nav landmark - [ ] #1752 Information only in hover tooltips - [ ] #1753 Palettes and labels not wired for AT - [ ] #1754 Remaining stale responses - [ ] #1755 Harness terminal failure and reopen - [ ] #1756 Smaller state bugs - [ ] #1757 Phone width with seeded data - [ ] #1758 Adopt the type scale - [ ] #1759 Replace hand-rolled components - [ ] #1760 Select for known options, server vocabularies - [ ] #1761 Time zone and duration formats - [ ] #1767 e2e checks for these failure classes **Low** - [ ] #1762 Copy pass - [ ] #1763 Dead code and legacy redirects - [ ] #1764 Formatting - [ ] #1765 Small accessibility fixes - [ ] #1766 Token and layout polish
sam added the epichigh labels 2026-11-02 04:15:41 +00:00
sam self-assigned this 2026-11-02 04:15:41 +00:00
Author
Owner

Triaged: no code change is needed for this. #1768 is a tracker, not a change. Its body is an administrative checklist: it says "Tracks the findings of a full read of ui/src", gives a suggested order, and lists 39 separately numbered issues (#1728–#1767) as unchecked boxes. It names no single behaviour to fix and selects no code path, so there is nothing here for one workflow to build. The repository's own model agrees: AGENTS.md ("Issues (Gitea)") keeps work as individual issues grouped under epic/<slug>, and ui/CLAUDE.md says to track work and follow-ups as issues rather than as task lists in Markdown.

Working the tracker directly would also be unsafe. Applying it as one task means simultaneous edits to chat, org policies, the workflow editor, dashboard, tasks/events, logs, alerts, harness, terminals and settings — the exact opposite of the "smallest complete change" rule in ui/CLAUDE.md, and unverifiable as a unit.

Part of what it asks for is already settled in the tree, so the tracker is stale as a description of current state as well as administrative:

  • The "one error presentation with Retry" it asks for (#1744, and the error-as-empty pair #1732/#1733) exists as ui/src/components/ui/read-error/ReadError.vue — a destructive Alert with an optional Retry — already consumed by ChatAskCard, HarnessPage, settings (Versions, KindGate, SystemStatus, Extensions, Services, Canary), audit (AuditPage, DenialsPage), accounts (Authentication, PersonalTokens) and OrgAccessPage.
  • The "focus ring under 3:1" item (#1737) has a declared focus floor in ui/src/style.css: :focus-visible { outline: 2px solid var(--ring); outline-offset: 2px; }.
  • #1767's failure classes and #1757's phone sweep already have browser checks: e2e/checks/loading-errors.cjs asserts a failed read does not render as "No policies yet."/"No runs yet" and that Retry recovers, and e2e/checks/phone-overflow.cjs cites #1757.

Verified by reading, not run: I did not execute pnpm test, the e2e stack, or a browser sweep, so I am not claiming the remaining checklist items pass — only that ReadError, the focus floor and those two checks exist and are wired in. The chat, org-policy, workflow-editor, task/event, logs, alerts and harness items were not each audited here.

Recommendation for the operator, as a follow-up rather than work started: close or relabel #1768 as an epic and triage its open children individually. Most of them are observable wrong behaviours, so those route to tdd (a failing reproduction first) — for example #1728 failed chat answer deleting the question, #1730 New policy editing the open policy, #1731 a dropped draft save. The few that are open design questions rather than defects — the shared error and stale-response conventions where a page has no existing precedent, and #1759/#1760 component and Select replacement — route to feasibility if their own bodies leave the shape undecided.

Triaged: no code change is needed for this. #1768 is a tracker, not a change. Its body is an administrative checklist: it says "Tracks the findings of a full read of ui/src", gives a suggested order, and lists 39 separately numbered issues (#1728–#1767) as unchecked boxes. It names no single behaviour to fix and selects no code path, so there is nothing here for one workflow to build. The repository's own model agrees: AGENTS.md ("Issues (Gitea)") keeps work as individual issues grouped under `epic/<slug>`, and ui/CLAUDE.md says to track work and follow-ups as issues rather than as task lists in Markdown. Working the tracker directly would also be unsafe. Applying it as one task means simultaneous edits to chat, org policies, the workflow editor, dashboard, tasks/events, logs, alerts, harness, terminals and settings — the exact opposite of the "smallest complete change" rule in ui/CLAUDE.md, and unverifiable as a unit. Part of what it asks for is already settled in the tree, so the tracker is stale as a description of current state as well as administrative: - The "one error presentation with Retry" it asks for (#1744, and the error-as-empty pair #1732/#1733) exists as ui/src/components/ui/read-error/ReadError.vue — a destructive Alert with an optional Retry — already consumed by ChatAskCard, HarnessPage, settings (Versions, KindGate, SystemStatus, Extensions, Services, Canary), audit (AuditPage, DenialsPage), accounts (Authentication, PersonalTokens) and OrgAccessPage. - The "focus ring under 3:1" item (#1737) has a declared focus floor in ui/src/style.css: `:focus-visible { outline: 2px solid var(--ring); outline-offset: 2px; }`. - #1767's failure classes and #1757's phone sweep already have browser checks: e2e/checks/loading-errors.cjs asserts a failed read does not render as "No policies yet."/"No runs yet" and that Retry recovers, and e2e/checks/phone-overflow.cjs cites #1757. Verified by reading, not run: I did not execute `pnpm test`, the e2e stack, or a browser sweep, so I am not claiming the remaining checklist items pass — only that ReadError, the focus floor and those two checks exist and are wired in. The chat, org-policy, workflow-editor, task/event, logs, alerts and harness items were not each audited here. Recommendation for the operator, as a follow-up rather than work started: close or relabel #1768 as an epic and triage its open children individually. Most of them are observable wrong behaviours, so those route to tdd (a failing reproduction first) — for example #1728 failed chat answer deleting the question, #1730 New policy editing the open policy, #1731 a dropped draft save. The few that are open design questions rather than defects — the shared error and stale-response conventions where a page has no existing precedent, and #1759/#1760 component and Select replacement — route to feasibility if their own bodies leave the shape undecided.
sam closed this issue 2026-11-06 22:18:12 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1768