Alerts: dismissing in the bell leaves the alert on the dashboard; failed dismiss is silent #1747

Closed
opened 2026-11-02 04:13:40 +00:00 by sam · 2 comments
Owner

ui/src/alerts/use-alerts.ts:13-55 creates its own alerts ref per call. AlertsBell.vue:16 and dashboard/LiveActivityCard.vue:52 each call it, so a dismissal in one is not seen by the other until a later alert event. A failed dismiss (:32-40) removes the alert optimistically, then the reload brings it back with no message.

Done when: alert state is shared (as captures/state.ts does), and a failed dismiss keeps the alert and says why.

`ui/src/alerts/use-alerts.ts:13-55` creates its own `alerts` ref per call. `AlertsBell.vue:16` and `dashboard/LiveActivityCard.vue:52` each call it, so a dismissal in one is not seen by the other until a later alert event. A failed dismiss (`:32-40`) removes the alert optimistically, then the reload brings it back with no message. Done when: alert state is shared (as `captures/state.ts` does), and a failed dismiss keeps the alert and says why.
sam added the mediumbug labels 2026-11-02 04:13:40 +00:00
sam self-assigned this 2026-11-02 04:13:40 +00:00
Author
Owner

Fixed in 9ca95458 and pushed. use-alerts.ts now keeps alerts/failed/dismissError at module scope with the stream wiring registered once (like captures/state.ts), so AlertsBell and LiveActivityCard share one list — a dismiss in the bell is immediately visible on the dashboard. dismiss removes the alert only after the API confirms; on failure the alert stays, the list reloads, and the bell shows 'Dismiss failed: …'. Verified: task check passed on the committed tree.

Fixed in 9ca95458 and pushed. use-alerts.ts now keeps alerts/failed/dismissError at module scope with the stream wiring registered once (like captures/state.ts), so AlertsBell and LiveActivityCard share one list — a dismiss in the bell is immediately visible on the dashboard. dismiss removes the alert only after the API confirms; on failure the alert stays, the list reloads, and the bell shows 'Dismiss failed: …'. Verified: task check passed on the committed tree.
Author
Owner

Fixed in 9ca95458 and pushed to main. Gate: task check exited 0 on the committed tree.

Fixed in 9ca95458 and pushed to main. Gate: task check exited 0 on the committed tree.
sam closed this issue 2026-11-07 06:09:31 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1747