Workflow canvas: a step cannot be opened for editing from the keyboard #1735

Closed
opened 2026-11-02 04:12:27 +00:00 by sam · 2 comments
Owner

The step card header in ui/src/workflows/StepNode.vue:118 is a div with @click and no role, tabindex or key handler. The step's actions menu (:126-136) has no Edit item; Edit exists only in the right-click canvas menu (WorkflowCanvas.vue:359, opened by mouse at :271-280).

Done when: the header is a button that toggles the step, Edit is in the step's actions menu, and both work with Tab, Enter and Space.

The step card header in `ui/src/workflows/StepNode.vue:118` is a div with `@click` and no role, tabindex or key handler. The step's actions menu (`:126-136`) has no Edit item; Edit exists only in the right-click canvas menu (`WorkflowCanvas.vue:359`, opened by mouse at `:271-280`). Done when: the header is a button that toggles the step, Edit is in the step's actions menu, and both work with Tab, Enter and Space.
sam added the highbug labels 2026-11-02 04:12:27 +00:00
sam self-assigned this 2026-11-02 04:12:27 +00:00
Author
Owner

Fixed in d90f7d48. The step card header in StepNode.vue now renders as a real button (aria-expanded included) whenever the step can toggle, so Tab/Enter/Space open it; while renaming it stays a div so the rename input isn't nested interactive content inside a button. The actions ellipsis moved to an absolute overlay at the card's top-right (same geometry, spacer kept in the header row) and the menu gained an Edit item that toggles the step, matching the right-click canvas menu. Verified: task check passed on the committed tree. A manual Tab-through of the canvas is the remaining behavioural check — not part of the gate.

Fixed in d90f7d48. The step card header in StepNode.vue now renders as a real button (aria-expanded included) whenever the step can toggle, so Tab/Enter/Space open it; while renaming it stays a div so the rename input isn't nested interactive content inside a button. The actions ellipsis moved to an absolute overlay at the card's top-right (same geometry, spacer kept in the header row) and the menu gained an Edit item that toggles the step, matching the right-click canvas menu. Verified: task check passed on the committed tree. A manual Tab-through of the canvas is the remaining behavioural check — not part of the gate.
sam closed this issue 2026-11-06 11:34:50 +00:00
Author
Owner

Fixed in d90f7d48 and pushed to main. Gate: task check exited 0 on the committed tree.

Fixed in d90f7d48 and pushed to main. Gate: task check exited 0 on the committed tree.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1735