e2e: checks that catch the UI audit's failure classes #1767

Closed
opened 2026-11-02 04:15:29 +00:00 by sam · 2 comments
Owner

The UI audit was a code read plus a mocked render, outside e2e/. The repeated failure classes it found should be caught by e2e checks so the next audit is a task e2e:check -- all run and its report:

  • Error shown as empty: with a dashboard API route forced to fail, no page shows its empty-state copy (extend loading-errors).
  • Focus contrast: Tab through each static route and fail when the focused element's outline or ring is under 3:1 against its background (extend accessibility).
  • Unnamed controls: fail on any input, textarea, select or button with no accessible name (extend accessibility).
  • Phone width: visit each static route at 390x844 with the seed and fail on horizontal scroll.

Done when: those checks exist, pass after the related fixes, and appear in the run's report.html.

The UI audit was a code read plus a mocked render, outside `e2e/`. The repeated failure classes it found should be caught by e2e checks so the next audit is a `task e2e:check -- all` run and its report: - Error shown as empty: with a dashboard API route forced to fail, no page shows its empty-state copy (extend `loading-errors`). - Focus contrast: Tab through each static route and fail when the focused element's outline or ring is under 3:1 against its background (extend `accessibility`). - Unnamed controls: fail on any input, textarea, select or button with no accessible name (extend `accessibility`). - Phone width: visit each static route at 390x844 with the seed and fail on horizontal scroll. Done when: those checks exist, pass after the related fixes, and appear in the run's `report.html`.
sam added the mediumtask labels 2026-11-02 04:15:29 +00:00
sam self-assigned this 2026-11-02 04:15:29 +00:00
Author
Owner

Fixed in 21b3591d and pushed. loading-errors.cjs now forces /api/tasks, /api/captures, /api/event-types, /api/tokens and /api/access/policies to fail and asserts each page shows its error surface (alert / 'Archie is not responding'), never its empty-state copy. accessibility.cjs gains two sweeps over every static route (shared helpers/routes.cjs): unnamed input/textarea/select/button detection via accname, and a Tab-through focus-contrast probe (ring var → outline → shadow → focus border, scored against both own and parent background, ≥3:1). phone-overflow.cjs now sweeps every static route at 390x844 for horizontal scroll. The sweeps caught real gaps, fixed in the same commit: DurationInput's amount input was unnamed and its unit select had no focus indicator; TabsContent and CodeBlockContent were focusable with outline-none and no ring. Also fixed the stale 'Sections' list selector (now the nav landmark). Verified: task check exit 0; e2e loading-errors, accessibility and phone-overflow all pass against the seeded stack; all three appear in the run's report.html.

Fixed in 21b3591d and pushed. loading-errors.cjs now forces /api/tasks, /api/captures, /api/event-types, /api/tokens and /api/access/policies to fail and asserts each page shows its error surface (alert / 'Archie is not responding'), never its empty-state copy. accessibility.cjs gains two sweeps over every static route (shared helpers/routes.cjs): unnamed input/textarea/select/button detection via accname, and a Tab-through focus-contrast probe (ring var → outline → shadow → focus border, scored against both own and parent background, ≥3:1). phone-overflow.cjs now sweeps every static route at 390x844 for horizontal scroll. The sweeps caught real gaps, fixed in the same commit: DurationInput's amount input was unnamed and its unit select had no focus indicator; TabsContent and CodeBlockContent were focusable with outline-none and no ring. Also fixed the stale 'Sections' list selector (now the nav landmark). Verified: task check exit 0; e2e loading-errors, accessibility and phone-overflow all pass against the seeded stack; all three appear in the run's report.html.
Author
Owner

Fixed in 21b3591d and pushed to main. Gate: task check exited 0 on the committed tree.

Fixed in 21b3591d and pushed to main. Gate: task check exited 0 on the committed tree.
sam closed this issue 2026-11-07 06:09:38 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1767