Remaining async views write stale responses #1754

Closed
opened 2026-11-02 04:14:32 +00:00 by sam · 2 comments
Owner

No request guard on these loads or polls, so an older response can land after a newer one:

ui/src/schedules/SchedulesPage.vue:55-68 (30 s poll), ui/src/components/command-palette/CommandPalette.vue:62-64, ui/src/skills/SkillsPage.vue:23-35, ui/src/settings/SystemReposPage.vue:71-78, ui/src/settings/ServicesCard.vue:105, ui/src/settings/SecretEnginesPage.vue:14, ui/src/captures/state.ts:64-77, ui/src/captures/event-type-state.ts:52-64, ui/src/curators/CuratorsPage.vue:62-70, ui/src/sources/use-sources.ts:24-36, ui/src/channels/ChannelsPage.vue:76-98, ui/src/mappings/state.ts:135-158, ui/src/mappings/state.ts:248-252 (preview), ui/src/bindings/DispatchLinks.vue:30-42, ui/src/workflows/workflow-history.ts:14-21.

A failed schedules poll also replaces the whole table with the error (SchedulesPage.vue:162-164).

Done when: each uses the generation guard from ui/src/logs/state.ts:86-112, and a failed poll keeps the last good rows beside an inline error.

No request guard on these loads or polls, so an older response can land after a newer one: `ui/src/schedules/SchedulesPage.vue:55-68` (30 s poll), `ui/src/components/command-palette/CommandPalette.vue:62-64`, `ui/src/skills/SkillsPage.vue:23-35`, `ui/src/settings/SystemReposPage.vue:71-78`, `ui/src/settings/ServicesCard.vue:105`, `ui/src/settings/SecretEnginesPage.vue:14`, `ui/src/captures/state.ts:64-77`, `ui/src/captures/event-type-state.ts:52-64`, `ui/src/curators/CuratorsPage.vue:62-70`, `ui/src/sources/use-sources.ts:24-36`, `ui/src/channels/ChannelsPage.vue:76-98`, `ui/src/mappings/state.ts:135-158`, `ui/src/mappings/state.ts:248-252` (preview), `ui/src/bindings/DispatchLinks.vue:30-42`, `ui/src/workflows/workflow-history.ts:14-21`. A failed schedules poll also replaces the whole table with the error (`SchedulesPage.vue:162-164`). Done when: each uses the generation guard from `ui/src/logs/state.ts:86-112`, and a failed poll keeps the last good rows beside an inline error.
sam added the mediumbug labels 2026-11-02 04:14:32 +00:00
sam self-assigned this 2026-11-02 04:14:32 +00:00
Author
Owner

Fixed in 029198ff and pushed. All 14 listed loads/polls now use the generation guard from logs/state.ts:86-112 — a response that settles after a newer request started is dropped. Additionally: a failed schedules poll keeps the last good rows with the inline error above the table (was: table replaced by the error), and failed skills/secret-engines polls keep the last good list. runPreview drops previews that belong to a superseded draft. Verified: task check passed on the committed tree.

Fixed in 029198ff and pushed. All 14 listed loads/polls now use the generation guard from logs/state.ts:86-112 — a response that settles after a newer request started is dropped. Additionally: a failed schedules poll keeps the last good rows with the inline error above the table (was: table replaced by the error), and failed skills/secret-engines polls keep the last good list. runPreview drops previews that belong to a superseded draft. Verified: task check passed on the committed tree.
Author
Owner

Fixed in 029198ff and pushed to main. Gate: task check exited 0 on the committed tree.

Fixed in 029198ff and pushed to main. Gate: task check exited 0 on the committed tree.
sam closed this issue 2026-11-07 06:09:34 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1754