Terminals are dark in light theme and use raw hex #1739

Closed
opened 2026-11-02 04:13:31 +00:00 by sam · 2 comments
Owner

ui/src/tasks/SandboxView.vue:43, 104 and ui/src/harness/SetupTerminal.vue:46-52, 115 hard-code the xterm palette (#0b0f14, #e6edf3, #264f78) and bg-[#0b0f14]. The terminal stays dark in light theme and bypasses the token set.

Done when: a terminal surface/foreground token exists for both themes in ui/src/style.css, both terminals read it (class and xterm theme), and the theme switches live.

`ui/src/tasks/SandboxView.vue:43, 104` and `ui/src/harness/SetupTerminal.vue:46-52, 115` hard-code the xterm palette (`#0b0f14`, `#e6edf3`, `#264f78`) and `bg-[#0b0f14]`. The terminal stays dark in light theme and bypasses the token set. Done when: a terminal surface/foreground token exists for both themes in `ui/src/style.css`, both terminals read it (class and xterm theme), and the theme switches live.
sam added the mediumbug labels 2026-11-02 04:13:31 +00:00
sam self-assigned this 2026-11-02 04:13:31 +00:00
Author
Owner

Fixed in cb3372ac and pushed. New --terminal-bg/--terminal-fg/--terminal-cursor/--terminal-selection tokens in both theme blocks of ui/src/style.css (dark keeps #0b0f14/#264f78; light gets #f5f4f1 paper inset with #c9d8e8 selection), bg-terminal exposed via @theme inline. Shared ui/src/lib/terminalTheme.ts reads the tokens and re-applies the xterm theme on every data-theme change (MutationObserver on <html>), so switching theme — including OS-level while set to system — repaints a live terminal. SetupTerminal.vue and SandboxView.vue use terminalTheme() and bg-terminal; no raw hex left outside the token definitions. Verified: task check exited 0 on the committed tree (go build/vet/lint/test, proto+db checks, vue-tsc typecheck, pnpm test, vite build).

Fixed in cb3372ac and pushed. New --terminal-bg/--terminal-fg/--terminal-cursor/--terminal-selection tokens in both theme blocks of ui/src/style.css (dark keeps #0b0f14/#264f78; light gets #f5f4f1 paper inset with #c9d8e8 selection), bg-terminal exposed via @theme inline. Shared ui/src/lib/terminalTheme.ts reads the tokens and re-applies the xterm theme on every data-theme change (MutationObserver on <html>), so switching theme — including OS-level while set to system — repaints a live terminal. SetupTerminal.vue and SandboxView.vue use terminalTheme() and bg-terminal; no raw hex left outside the token definitions. Verified: task check exited 0 on the committed tree (go build/vet/lint/test, proto+db checks, vue-tsc typecheck, pnpm test, vite build).
Author
Owner

Fixed in cb3372ac and pushed to main. Gate: task check exited 0 on the committed tree.

Fixed in cb3372ac and pushed to main. Gate: task check exited 0 on the committed tree.
sam closed this issue 2026-11-07 06:09:27 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1739