Harness page: setup terminal reports the wrong failure and cannot be reopened #1755

Closed
opened 2026-11-02 04:14:33 +00:00 by sam · 2 comments
Owner
  • ui/src/harness/SetupTerminal.vue:77-82: onerror sets "failed", then onclose sets "closed", so a connection that never opened says "The terminal session ended." instead of "Could not open the setup terminal."
  • ui/src/harness/HarnessPage.vue:98-101, 155-157: terminalOpen is never reset; after the session ends, only a page reload starts a new one.
  • HarnessPage.vue:112-115: the load failure has no Retry.

Done when: a failed connection says so, the terminal can be closed and reopened as a new session, and the load error has Retry.

- `ui/src/harness/SetupTerminal.vue:77-82`: `onerror` sets "failed", then `onclose` sets "closed", so a connection that never opened says "The terminal session ended." instead of "Could not open the setup terminal." - `ui/src/harness/HarnessPage.vue:98-101, 155-157`: `terminalOpen` is never reset; after the session ends, only a page reload starts a new one. - `HarnessPage.vue:112-115`: the load failure has no Retry. Done when: a failed connection says so, the terminal can be closed and reopened as a new session, and the load error has Retry.
sam added the mediumbug labels 2026-11-02 04:14:33 +00:00
sam self-assigned this 2026-11-02 04:14:33 +00:00
Author
Owner

Fixed in 0b08fc52 and pushed. onclose no longer overwrites "failed" with "closed", so a connection that never opened says "Could not open the setup terminal.". SetupTerminal now emits ended on close and HarnessPage resets terminalOpen from it (and offers a Close terminal button), so the terminal can be closed and reopened as a new session without a reload. The load failure alert has a Retry button. Verified: task check passed on the committed tree.

Fixed in 0b08fc52 and pushed. onclose no longer overwrites "failed" with "closed", so a connection that never opened says "Could not open the setup terminal.". SetupTerminal now emits ended on close and HarnessPage resets terminalOpen from it (and offers a Close terminal button), so the terminal can be closed and reopened as a new session without a reload. The load failure alert has a Retry button. Verified: task check passed on the committed tree.
Author
Owner

Fixed in 0b08fc52 and pushed to main. Gate: task check exited 0 on the committed tree.

Fixed in 0b08fc52 and pushed to main. Gate: task check exited 0 on the committed tree.
sam closed this issue 2026-11-07 06:09:35 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1755