Table rows given link or button roles lose table semantics #1750

Closed
opened 2026-11-02 04:13:43 +00:00 by sam · 2 comments
Owner

role="link" or role="button" on <tr> removes row and cell semantics and replaces the row's content as its name:

  • ui/src/components/ui/data-table/DataTable.vue:133-135 (every table with rowLink)
  • ui/src/dashboard/ActivityRow.vue:37-40
  • ui/src/dashboard/LiveActivityCard.vue:166-199 (also nests a button inside the link row)
  • ui/src/captures/CaptureRow.vue:41-51 (the name drops the identification and signature badges)

Done when: rows stay rows, and a link or button in the first cell is the focus target, with the row still clickable by mouse.

`role="link"` or `role="button"` on `<tr>` removes row and cell semantics and replaces the row's content as its name: - `ui/src/components/ui/data-table/DataTable.vue:133-135` (every table with `rowLink`) - `ui/src/dashboard/ActivityRow.vue:37-40` - `ui/src/dashboard/LiveActivityCard.vue:166-199` (also nests a button inside the link row) - `ui/src/captures/CaptureRow.vue:41-51` (the name drops the identification and signature badges) Done when: rows stay rows, and a link or button in the first cell is the focus target, with the row still clickable by mouse.
sam added the mediumbug labels 2026-11-02 04:13:43 +00:00
sam self-assigned this 2026-11-02 04:13:43 +00:00
Author
Owner

Fixed in ef623f6c and pushed. DataTable, ActivityRow, the live-activity group row and CaptureRow no longer put role/tabindex/aria-label on the — rows keep row/cell semantics and their mouse click; the first cell carries a real RouterLink (DataTable rowLink) or button with the accessible name as the keyboard focus target. The live-activity group row's disclosure and open buttons are now siblings instead of nested. Verified: task check passed; e2e audit-phone, seeded and task-diagnostics pass against the seeded stack (one audit-phone run hit a transient vite HMR error-overlay, clean on re-run and on a manual console-error probe).

Fixed in ef623f6c and pushed. DataTable, ActivityRow, the live-activity group row and CaptureRow no longer put role/tabindex/aria-label on the <tr> — rows keep row/cell semantics and their mouse click; the first cell carries a real RouterLink (DataTable rowLink) or button with the accessible name as the keyboard focus target. The live-activity group row's disclosure and open buttons are now siblings instead of nested. Verified: task check passed; e2e audit-phone, seeded and task-diagnostics pass against the seeded stack (one audit-phone run hit a transient vite HMR error-overlay, clean on re-run and on a manual console-error probe).
Author
Owner

Fixed in ef623f6c and pushed to main. Gate: task check exited 0 on the committed tree.

Fixed in ef623f6c and pushed to main. Gate: task check exited 0 on the committed tree.
sam closed this issue 2026-11-07 06:09:32 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1750