Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
0e8fcf70a0 | ||
|
|
4673b435b7 | ||
|
|
1e062fd7f0 | ||
|
|
74a3ec925c | ||
|
|
4944ec8473 | ||
|
|
204b65a0e3 | ||
|
|
cbedb8a504 | ||
|
|
a8dbab0cff | ||
|
|
789ff73fe9 | ||
|
|
5176938e95 | ||
|
|
69a1ee677d | ||
|
|
b3cf2c59a8 | ||
|
|
8ebaeb6d38 | ||
|
|
ce58768e6b | ||
|
|
d49918ae76 | ||
|
|
8cb5391035 | ||
|
|
ab9db7cfe3 | ||
|
|
3d02d1d2d9 | ||
|
|
e503263317 | ||
|
|
a012f1ad37 | ||
|
|
17b6fa7245 | ||
|
|
1d02c7e3e6 | ||
|
|
7892c927ce | ||
|
|
209f2b4adb | ||
|
|
28bb4b4483 | ||
|
|
8d73280633 | ||
|
|
c654ba7cd1 | ||
|
|
0fc8535d87 | ||
|
|
a355f13a03 | ||
|
|
cf34d03476 | ||
|
|
f9896f509d | ||
|
|
9f3ad773cd | ||
|
|
c0586e465c | ||
|
|
4fd53d3f44 | ||
|
|
a9991f6d91 | ||
|
|
e20860fcab | ||
|
|
378797ef6e | ||
|
|
f555b9171b | ||
|
|
9c20a8f2e0 | ||
|
|
84050080a7 | ||
|
|
7a6603078a | ||
|
|
07adab1eda | ||
|
|
7f2fd08840 | ||
|
|
2d55f9ead2 | ||
|
|
9431201d32 | ||
|
|
3a90225da1 | ||
|
|
68d0fe9055 | ||
|
|
0f0795e6f1 | ||
|
|
1628cbc312 | ||
|
|
b26de90e38 | ||
|
|
087ce10b86 | ||
|
|
799632339f | ||
|
|
bf73f96de5 | ||
|
|
bfebdec1bf | ||
|
|
e084c55fcc | ||
|
|
2998a2ed13 | ||
|
|
34077cb4ca | ||
|
|
4295bf6e46 | ||
|
|
955e366b9c | ||
|
|
d4d3a1ea7e | ||
|
|
2f8a91010f | ||
|
|
9f3e8285b5 | ||
|
|
add33fb3d9 | ||
|
|
0df1c41362 | ||
|
|
35a23d5ca1 | ||
|
|
0acf7981d9 | ||
|
|
abf3ae0ff9 | ||
|
|
65fbb3e1aa | ||
|
|
24c5fc86db | ||
|
|
794b818f4c | ||
|
|
57660a19b5 | ||
|
|
de6497dd14 | ||
|
|
dd8729bcf7 | ||
|
|
8c81661e01 | ||
|
|
261a50bc40 | ||
|
|
cf8868b744 | ||
|
|
dff26fe98b | ||
|
|
83cc810e94 | ||
|
|
1a26bf06b5 | ||
|
|
24df173a31 | ||
|
|
b38b3f6961 | ||
|
|
47558078ce | ||
|
|
2f6c53090e | ||
|
|
01f9b5986b | ||
|
|
d5e07333fa | ||
|
|
515c2edf2f | ||
|
|
77723baf75 | ||
|
|
b9787cebbe | ||
|
|
9e4ec516c9 | ||
|
|
add2546e54 | ||
|
|
3f494b4247 | ||
|
|
c73ff313ea | ||
|
|
886a151341 | ||
|
|
8ba067ce32 | ||
|
|
e0db40963e | ||
|
|
70322bd5fb | ||
|
|
fe30a02072 | ||
|
|
6a8481f203 | ||
|
|
22a4dcf46a | ||
|
|
6ee7321e6b | ||
|
|
1510c41254 | ||
|
|
895a04047d | ||
|
|
c9099e6f04 | ||
|
|
c76b973ea8 | ||
|
|
a8d0c82da7 | ||
|
|
d12e46dc38 | ||
|
|
e46eeb67dd | ||
|
|
3072ba595f | ||
|
|
720cd7a6f0 | ||
|
|
dfff9f6b11 | ||
|
|
ae99b47581 | ||
|
|
eeccb2e995 | ||
|
|
4efb835eed | ||
|
|
880a898ecb | ||
|
|
fba2d4ee09 | ||
|
|
666a034202 | ||
|
|
a5279bb187 | ||
|
|
c885eb5bec | ||
|
|
e45d69ef58 | ||
|
|
a2a6ab3dfb | ||
|
|
a5d747df72 | ||
|
|
2aea980a01 | ||
|
|
0e45001b2e | ||
|
|
e192308c90 | ||
|
|
06b8aeebeb | ||
|
|
cc5e0076af | ||
|
|
40d1062e08 | ||
|
|
56f2bf8a5d | ||
|
|
90399f5025 | ||
|
|
b5edf2986e | ||
|
|
1f01293f8c | ||
|
|
7efc96bf70 | ||
|
|
5b3441c553 | ||
|
|
5a3a693582 | ||
|
|
55bb4223c2 | ||
|
|
0e580dd979 | ||
|
|
9ccfc020f7 | ||
|
|
755f367ca0 | ||
|
|
153dfc094c | ||
|
|
37c6a71343 | ||
|
|
9d7b8d9814 | ||
|
|
b693065d09 | ||
|
|
3433bc7068 | ||
|
|
be541d6aee | ||
|
|
3a8879e6e9 | ||
|
|
b47e3a0b70 | ||
|
|
9a8c5722fa | ||
|
|
3b07bcb19f | ||
|
|
d82651222a | ||
|
|
647b9bcce7 | ||
|
|
2ae46582a8 | ||
|
|
38219a7035 | ||
|
|
510172480b | ||
|
|
785053c470 | ||
|
|
f27aafbd66 | ||
|
|
5b42e4cba9 | ||
|
|
1e435e9224 | ||
|
|
a4317f2660 | ||
|
|
7c011e8bf7 | ||
|
|
07d4fcb627 | ||
|
|
81f430de58 | ||
|
|
bf33ec9535 | ||
|
|
c486fe291c | ||
|
|
7d795fdd4f | ||
|
|
794c7ac8c6 | ||
|
|
d8d6d7318b | ||
|
|
e0701b18a3 | ||
|
|
9dd39c9d24 | ||
|
|
bf1a4ec6d7 | ||
|
|
0754c5e0da | ||
|
|
1936d9c353 | ||
|
|
44695b1846 | ||
|
|
35e72d81ff | ||
|
|
7e98ca254c | ||
|
|
6078dc1565 | ||
|
|
75988204d5 | ||
|
|
1a3fbe042e | ||
|
|
cb6b8618c2 | ||
|
|
0cbb65c684 | ||
|
|
e10980dc33 | ||
|
|
3360cddb5a | ||
|
|
c30844180b | ||
|
|
4ebde6b315 | ||
|
|
58150a920d | ||
|
|
5719cd51cb | ||
|
|
d0fd78e6a9 | ||
|
|
c167358118 | ||
|
|
7cf0db7e9a | ||
|
|
4d00884ea5 | ||
|
|
239cde9c2b | ||
|
|
030b4ed176 | ||
|
|
a8a118c1b8 | ||
|
|
780bc44d82 | ||
|
|
f0fe550a35 | ||
|
|
152c8b85a2 | ||
|
|
0d3ec4f127 | ||
|
|
703692ca7a | ||
|
|
8f8e732b3a | ||
|
|
61ecc14327 | ||
|
|
66167571cb | ||
|
|
aacec67c24 | ||
|
|
0adc165c4c | ||
|
|
483f50d030 | ||
|
|
27d9d7b397 | ||
|
|
eb624e53c6 | ||
|
|
9d7a7df496 | ||
|
|
c4b2bf5db7 | ||
|
|
0fe3caa175 | ||
|
|
83d57ec6a2 | ||
|
|
e762f15844 | ||
|
|
1539fdc560 | ||
|
|
0e37a0f536 | ||
|
|
de32542c00 | ||
|
|
c1673e43fb | ||
|
|
a9233755c3 | ||
|
|
7ca81dc85a | ||
|
|
457da2e97d | ||
|
|
656d21520f | ||
|
|
92eabbed17 | ||
|
|
28acf2a8db | ||
|
|
c02852d87f | ||
|
|
ab86442156 | ||
|
|
bfb909a93a | ||
|
|
894fffc63b | ||
|
|
c94be59952 | ||
|
|
04d0495f12 | ||
|
|
9ccb6e2418 | ||
|
|
cd878f3c4d | ||
|
|
b650a8c156 | ||
|
|
4241429620 | ||
|
|
cc83c9aea2 | ||
|
|
1f0cb9f318 | ||
|
|
19520a63e5 | ||
|
|
ef203ce30a | ||
|
|
ff3f80e4c1 | ||
|
|
3da407e410 | ||
|
|
4e5b91d791 | ||
|
|
12b59a046d | ||
|
|
af1b9855ab | ||
|
|
3e878464f9 | ||
|
|
216be98652 | ||
|
|
f77baecb00 | ||
|
|
394c76b4cc | ||
|
|
b6defc5f31 | ||
|
|
5e1623f82f | ||
|
|
0544fa58fc | ||
|
|
057a4a8614 | ||
|
|
2a1ed36a26 | ||
|
|
605988e0a9 | ||
|
|
06e0a87a62 | ||
|
|
1d2fcec69e | ||
|
|
f5fbec6371 | ||
|
|
a9f441042e | ||
|
|
a8a04929af | ||
|
|
1e1f51af55 | ||
|
|
3c2b1f6654 | ||
|
|
e10d862f6a | ||
|
|
721968eeff | ||
|
|
446d94681b | ||
|
|
04dedde52c | ||
|
|
a4abafe0ad | ||
|
|
6bf24d73db | ||
|
|
20b4595a95 | ||
|
|
2341c6df36 | ||
|
|
eaabc254be | ||
|
|
68a17aed91 | ||
|
|
4f01b1604d | ||
|
|
bea1c69210 | ||
|
|
7f51f1c39e | ||
|
|
3c32b63066 | ||
|
|
829fc44cbc | ||
|
|
6b4049c9f5 | ||
|
|
934ba16c72 | ||
|
|
9f1dc44673 | ||
|
|
24258e215f | ||
|
|
793eec6e51 | ||
|
|
6785750729 | ||
|
|
72fa043f47 | ||
|
|
cc7397787b | ||
|
|
cef476aca3 | ||
|
|
f50444594f | ||
|
|
275d337032 | ||
|
|
b314470281 | ||
|
|
eb3add5b89 | ||
|
|
c126d5a24a | ||
|
|
1a3e79502d | ||
|
|
fcc6a7974e | ||
|
|
f4ed542b00 | ||
|
|
d06be5ca32 | ||
|
|
8d48a08b13 | ||
|
|
f6ee43bf55 | ||
|
|
268f99051a | ||
|
|
60a09e7def | ||
|
|
bf1dc2e33e | ||
|
|
f34714ea07 | ||
|
|
c2cfba1129 | ||
|
|
cea8bfee98 | ||
|
|
2f8107d5ca | ||
|
|
a67a142139 | ||
|
|
48416af5bc | ||
|
|
cca80ac2e8 | ||
|
|
52d267683b | ||
|
|
0b00682fac | ||
|
|
d1b8bff5ce | ||
|
|
ae8f0d42ef | ||
|
|
39b61a0340 | ||
|
|
06334ca3f9 | ||
|
|
f9e97b561f | ||
|
|
d7f6f502a8 | ||
|
|
54e36ff8b7 | ||
|
|
a1c69c5b28 | ||
|
|
bf68866dca | ||
|
|
87d52938b5 | ||
|
|
90a4189db4 | ||
|
|
013fcd0919 | ||
|
|
00209ebe87 | ||
|
|
96e54e963f | ||
|
|
2f05ed81b1 | ||
|
|
822f8b63d4 | ||
|
|
e0ec9b87e6 | ||
|
|
27bad9f1fa | ||
|
|
403ace1cef | ||
|
|
761a1271a4 | ||
|
|
c5a8942976 | ||
|
|
fb0424b729 | ||
|
|
52b8b6dcca | ||
|
|
d7178250ae | ||
|
|
9b282177e0 | ||
|
|
59273c9544 | ||
|
|
86e706dff7 | ||
|
|
ad5caf88a6 | ||
|
|
a7efb9bb00 | ||
|
|
34f47a4bd0 | ||
|
|
d60fcad18f | ||
|
|
8124c5af54 | ||
|
|
bfc8d4b1b7 | ||
|
|
0b8e9ae7f1 | ||
|
|
662a5ee336 | ||
|
|
8cbbdb20b5 | ||
|
|
cadbc6d1ca | ||
|
|
64128645c2 | ||
|
|
8155cc915a | ||
|
|
150dde5a7d | ||
|
|
a65f558d35 | ||
|
|
0dff130682 | ||
|
|
2d1d4ed632 | ||
|
|
67c5447ebc | ||
|
|
db6e8d321e | ||
|
|
cbeab6afd2 | ||
|
|
ed698fced1 | ||
|
|
081ee4a8ba | ||
|
|
5de07fac0e | ||
|
|
03335f49c1 | ||
|
|
d0d759d216 | ||
|
|
67ead19dd9 | ||
|
|
f7c646163b | ||
|
|
8d05f99526 | ||
|
|
625ead95b3 | ||
|
|
0acc922d9a | ||
|
|
595956cc75 | ||
|
|
929784667b | ||
|
|
d4e254b349 | ||
|
|
89c5f8e2ad | ||
|
|
2ffe924a44 | ||
|
|
c9f677f35b | ||
|
|
d60f024e74 | ||
|
|
1fa3acdbe9 | ||
|
|
d10b070a2e | ||
|
|
b93909c5aa | ||
|
|
42a4e2465d | ||
|
|
608403c1f9 | ||
|
|
e9e52c1f1f | ||
|
|
fc5d24c9f7 | ||
|
|
0b82f1c9a5 | ||
|
|
cdc3e83740 | ||
|
|
807d1dfc15 | ||
|
|
dbaa7284a3 | ||
|
|
5734e194c9 | ||
|
|
e16ba86b30 | ||
|
|
a2650eb5e9 | ||
|
|
1686fba12b | ||
|
|
519604405a | ||
|
|
2aea3ce0dc | ||
|
|
e7b21b9e5d | ||
|
|
e992d4256e | ||
|
|
41823ab336 | ||
|
|
fe2a3a7565 | ||
|
|
36981c2024 | ||
|
|
2bcfc19837 | ||
|
|
416df69b00 | ||
|
|
6c405333b7 | ||
|
|
3f0071e27b | ||
|
|
c07c04e45a | ||
|
|
a6ab4ef538 | ||
|
|
2604cd4cf4 | ||
|
|
cc6d606de4 | ||
|
|
de47bf2398 | ||
|
|
b8f5d0fc3d | ||
|
|
64cc0a5e29 | ||
|
|
d6f33ddd11 | ||
|
|
1e669b4a9f | ||
|
|
c3175c6939 | ||
|
|
7a38d9b79f | ||
|
|
b6357c8fd4 | ||
|
|
5f5494893c | ||
|
|
2c4d8af59e | ||
|
|
ce7478664a | ||
|
|
d1cba5c1ab | ||
|
|
a83b9afdce | ||
|
|
6f0e889bcf | ||
|
|
02328c1880 | ||
|
|
ea39923248 | ||
|
|
9c5eeba281 | ||
|
|
68e6dc0229 | ||
|
|
9219252bd4 | ||
|
|
3de20cdf9e | ||
|
|
e6a5a9d3d8 | ||
|
|
e9fe50b364 | ||
|
|
257a1fbf1f | ||
|
|
e720d3dcd8 | ||
|
|
ca3b53bccd | ||
|
|
3b04ac1196 | ||
|
|
9c053def88 | ||
|
|
4c3d4f94e4 | ||
|
|
fd6b568fa4 | ||
|
|
49c44b4a03 | ||
|
|
3827561ab0 | ||
|
|
0a05a30df0 | ||
|
|
4040e42d2b | ||
|
|
2a03741929 | ||
|
|
fb49ebd268 | ||
|
|
17465f240b | ||
|
|
78833a9c2c | ||
|
|
5ca398d0d9 | ||
|
|
d42731e5ae | ||
|
|
3186184964 | ||
|
|
0c14c4b892 | ||
|
|
82dc7641fe | ||
|
|
fcc9322237 | ||
|
|
62e9e9cb28 | ||
|
|
d6e24e1f81 | ||
|
|
643d2ed665 | ||
|
|
9b581a1326 | ||
|
|
93e96b8de5 | ||
|
|
4242d94676 | ||
|
|
1358c3d759 | ||
|
|
585df0f81e | ||
|
|
a8c8dfbd7d | ||
|
|
bc215e8daa | ||
|
|
0d042b72d9 | ||
|
|
5507ded2d5 | ||
|
|
7a54db0cc6 | ||
|
|
4067949ce8 | ||
|
|
92a9eca12c | ||
|
|
30211478c2 | ||
|
|
4e9b30d712 | ||
|
|
f7bfd78d5f | ||
|
|
4f62ce5dfc | ||
|
|
845b192a89 | ||
|
|
8ba0b90861 | ||
|
|
7b86dd6cfe | ||
|
|
419334dfa2 | ||
|
|
093e677ad8 | ||
|
|
235b9c1a87 | ||
|
|
37d913c5fd | ||
|
|
8274ecbc53 | ||
|
|
2657b18be7 | ||
|
|
8c7ee60270 | ||
|
|
54ade9713a | ||
|
|
e307efe77d | ||
|
|
6143d17caf | ||
|
|
b54aa00a24 | ||
|
|
08d5df9b11 | ||
|
|
5b6572bcea | ||
|
|
606e87d11c | ||
|
|
0b24dc8ff0 | ||
|
|
e7611903a8 | ||
|
|
19e110e68c | ||
|
|
f747ff87d0 | ||
|
|
486d5574b3 | ||
|
|
71435c2bb6 | ||
|
|
9b16c0fd64 | ||
|
|
4fc06b5d7d | ||
|
|
78dd50d60b | ||
|
|
77a479e99a | ||
|
|
6bc7a85404 | ||
|
|
a7edc0a5cd | ||
|
|
1cf2742f54 | ||
|
|
0f6cb5b8a6 | ||
|
|
fca30d6445 | ||
|
|
a98ca2c8e9 | ||
|
|
22d36fef75 | ||
|
|
f74827795d | ||
|
|
ca8d189f96 | ||
|
|
2ee7043daf | ||
|
|
bbc39897de | ||
|
|
6ba43bbf21 | ||
|
|
ff77612bfd | ||
|
|
4426c0e685 | ||
|
|
9627bc411c | ||
|
|
01c98088ae | ||
|
|
86d4f62bfe | ||
|
|
6f2b55960f | ||
|
|
dce3c925c2 | ||
|
|
f7074d357f | ||
|
|
41e5ab32f9 | ||
|
|
e44b5398c7 | ||
|
|
6dcb04c7c0 | ||
|
|
d025d4c5be | ||
|
|
7555b80f31 | ||
|
|
ceed8b055a | ||
|
|
f3f3ca90f1 | ||
|
|
0bc27ea6da | ||
|
|
049bbf2a7d | ||
|
|
b5c98a0ccc | ||
|
|
c327f17c35 | ||
|
|
081e5bbfd9 | ||
|
|
b1a5954594 | ||
|
|
9639e7041e | ||
|
|
5b06f0b42a | ||
|
|
7d37750d40 | ||
|
|
7095a583b8 | ||
|
|
cb6b902f97 | ||
|
|
74aaf39be9 | ||
|
|
4690e822d8 | ||
|
|
90e222b8ec | ||
|
|
1bb52fe8c7 | ||
|
|
e3bf3b7584 | ||
|
|
6d8fe247a7 | ||
|
|
464ccf83fa | ||
|
|
067d365f84 | ||
|
|
e12aeb8493 | ||
|
|
7577ae66a7 | ||
|
|
8fea8e8686 | ||
|
|
49d7527f1c | ||
|
|
81862273c0 | ||
|
|
07d5a7a3cc | ||
|
|
bb3e7b76e8 | ||
|
|
cc33dfea54 | ||
|
|
73e718dea4 | ||
|
|
d01a3c4647 | ||
|
|
55ad93e8e3 | ||
|
|
459bbcd5fc | ||
|
|
a4d98786a1 | ||
|
|
aa24551d98 | ||
|
|
cacf25039e | ||
|
|
35dd7489dd | ||
|
|
be1b3aa6a1 | ||
|
|
065606b2a5 | ||
|
|
a22030bd65 | ||
|
|
a16a17309c | ||
|
|
0d35e753b5 | ||
|
|
c1cd5c8f5b | ||
|
|
4479f212d7 | ||
|
|
1340036546 | ||
|
|
9fd966d6b0 | ||
|
|
6e46d4dec9 | ||
|
|
f36e17796c | ||
|
|
e5105280ad | ||
|
|
9a0efa295e | ||
|
|
862b3560e1 | ||
|
|
58eac052a8 | ||
|
|
0909ebfe60 | ||
|
|
ae5e0ad835 | ||
|
|
b9c1663d64 | ||
|
|
25668c1226 | ||
|
|
d299448de1 | ||
|
|
440d2e8e46 | ||
|
|
c971348a86 | ||
|
|
21e4d47907 | ||
|
|
21f333a13e | ||
|
|
d8bec1ae06 | ||
|
|
d320a1a01a | ||
|
|
74197cd0fc | ||
|
|
be9a45ad2d | ||
|
|
e57221f34b | ||
|
|
a377da6678 | ||
|
|
30834223dc | ||
|
|
9864766804 | ||
|
|
64f863f228 | ||
|
|
89f5b70287 | ||
|
|
4f8290567b | ||
|
|
fbcb7032e5 | ||
|
|
ae552db7e0 | ||
|
|
dda12dcdba | ||
|
|
fec0ea1f4e | ||
|
|
0cabe5fd65 | ||
|
|
a383f6820f | ||
|
|
10023b8bc2 | ||
|
|
6adbdc55a9 | ||
|
|
d8d7c5a1f2 | ||
|
|
f279e3b9c0 | ||
|
|
1c03c6bc1a | ||
|
|
c1e2a14390 | ||
|
|
80b0d1f78d | ||
|
|
00e3520a1e | ||
|
|
368e33a9a5 | ||
|
|
a86be2fa49 | ||
|
|
5e6c3fa3d3 | ||
|
|
1b5ba30113 | ||
|
|
5009288729 | ||
|
|
d2b55e941a | ||
|
|
35b0a305eb | ||
|
|
651021130d | ||
|
|
0f88e08913 | ||
|
|
5687d1b04e | ||
|
|
671441ac4b | ||
|
|
8b006b35aa | ||
|
|
c367a9e606 | ||
|
|
88030e32e9 | ||
|
|
5cbc9f9d6c | ||
|
|
20929cd444 | ||
|
|
fe73025d47 | ||
|
|
4ce4b46977 | ||
|
|
f3a1ef6de1 | ||
|
|
ecc1997384 | ||
|
|
5e1c43f1c5 | ||
|
|
dfed51547c | ||
|
|
cb1cd62eea | ||
|
|
feeaa16c7b | ||
|
|
cadf248b1f | ||
|
|
f3471131ff | ||
|
|
710fbab094 | ||
|
|
038b8035ff | ||
|
|
a69f9c81c2 | ||
|
|
c6df4b4a54 | ||
|
|
c620e00396 | ||
|
|
01586f1630 | ||
|
|
d03e7fdef4 | ||
|
|
f4d20cfe0a | ||
|
|
94ca015070 | ||
|
|
7c6e7d54ad | ||
|
|
86690ef73e | ||
|
|
528d6c4be2 | ||
|
|
891970f1ad | ||
|
|
3b303b353f | ||
|
|
fda2c51f6d | ||
|
|
61dd33edce | ||
|
|
534153d50a | ||
|
|
2bc4b8db32 | ||
|
|
6046948ff0 | ||
|
|
4237b560b0 | ||
|
|
3a4af23caa | ||
|
|
288e9ea370 | ||
|
|
aa054f8109 | ||
|
|
5e82a18697 | ||
|
|
d76bf2be67 | ||
|
|
475dc7c097 | ||
|
|
19cf9ae2ab | ||
|
|
67c2dff3e1 | ||
|
|
10dd85443d | ||
|
|
53bdbd3309 | ||
|
|
5d6fbd5c30 | ||
|
|
3940487335 | ||
|
|
d6f61c2c6f | ||
|
|
ee78bfa7bc | ||
|
|
8faa0f6a30 | ||
|
|
59614cc63f | ||
|
|
40f2e13f0b | ||
|
|
a65eae2458 | ||
|
|
052e350bf1 | ||
|
|
2393ec6dae | ||
|
|
00cfd6bda0 | ||
|
|
89fc8fc7f1 | ||
|
|
fd3f661a73 | ||
|
|
cdedbaa1f5 | ||
|
|
f0c1b34882 | ||
|
|
fde21c43d4 | ||
|
|
ec38ad604d | ||
|
|
3fdffa7203 | ||
|
|
ee56852064 | ||
|
|
91691fde93 | ||
|
|
4fe53f1028 | ||
|
|
1012384b5e | ||
|
|
46033dc5b3 | ||
|
|
d4df04f549 | ||
|
|
b9f1cf2260 | ||
|
|
6e635a2741 | ||
|
|
da2589e2f4 | ||
|
|
0e6c6fc6d1 | ||
|
|
8542f0d42c | ||
|
|
1bc009b3c5 | ||
|
|
ead8e4016d | ||
|
|
630249f6d1 | ||
|
|
16b3fe6c6a | ||
|
|
1132917593 | ||
|
|
408a3dcbb7 | ||
|
|
bf36d57927 | ||
|
|
d2aa680792 | ||
|
|
ed1557c12e | ||
|
|
0e94196052 | ||
|
|
38eff78081 | ||
|
|
c26536f067 | ||
|
|
1665f78e5b | ||
|
|
d0af4832a6 | ||
|
|
6703cc77cf | ||
|
|
e95a77c2f7 |
No files matched your search
@@ -1,172 +0,0 @@
|
||||
---
|
||||
name: archie-agent-fleet
|
||||
description: >-
|
||||
Run a bounded fleet of coding agents across archie-core's backlog without
|
||||
flooding review. Load when fanning work out into parallel lanes, waves,
|
||||
worktrees or subagents on this repository; when a lane worktree dies with the
|
||||
unknown-agent error for `cp-writer`; or when deciding what every lane call must
|
||||
carry, which gate evidence to demand, and how a lane's scoped test command
|
||||
should be shaped here. Carries archie-specific fleet facts only; the method
|
||||
lives in the user-scope high-throughput-programming skill.
|
||||
---
|
||||
|
||||
# Run an agent fleet on archie-core
|
||||
|
||||
This skill carries the facts about *this repository*. It deliberately does not
|
||||
restate the process.
|
||||
|
||||
## Where the method lives
|
||||
|
||||
The how is the user-scope skill `high-throughput-programming` at
|
||||
`~/.agents/skills/high-throughput-programming/`: doctrine, pipeline shape, the
|
||||
interview that scaffolds a run, the pi-subagents ceilings and traps, `scripts/`,
|
||||
`templates/` and `references/`. Read its `INTERVIEW.md` before scaffolding a run;
|
||||
never scaffold one from memory.
|
||||
|
||||
**Precedence.** That skill is normative for method; this one is normative for
|
||||
archie's facts. If they disagree about the process, it wins. If they disagree
|
||||
about this repository — a path, an invariant, a gate — this one wins, because the
|
||||
method skill is repository-agnostic by construction.
|
||||
|
||||
Route runtime facts to `archie-run-and-operate`, toolchain facts to
|
||||
`archie-build-and-env`, and dependency/boundary rules to
|
||||
`archie-architecture-contract`.
|
||||
|
||||
## Invariants every lane call must carry
|
||||
|
||||
State these as facts to each lane, not as advice. Each one has cost a real run.
|
||||
|
||||
| Invariant | Why it matters to a lane |
|
||||
|---|---|
|
||||
| **The control plane fails closed.** A stored resource that will not validate stops `archied` starting, and nothing bypasses the control plane at boot. Resource history is the only in-band remedy, and it needs the State Store up. | A lane touching the boot path, a stored resource kind, or the recovery commands is a risk-routed lane for the operator's eyes, not a gate-and-merge lane. Evidence: `docs/architecture/safe-change-and-recovery.md` ("Database settings: degrade paths and recovery"). |
|
||||
| **`internal/webui` must not reach `internal/domain/workflow`.** Go imports are atomic: one reference relinks the whole daemon runtime into the UI binary. | `cmd/archie-ui/architecture_test.go` measures the linked binary (`go list -deps .`), not the imports, and fails on anything under `internal/domain/workflow`. `internal/domain/workflow/task` is a named `gateExceptions` entry that must stay linked — it carries only contract and view types, and a stale exception fails the test in both directions. The same test's gate also excludes `internal/app/archied` from the UI binary, so a helper needed by both the daemon and the `cmd/` binaries belongs in `internal/infrastructure/configuration` (which already owns path resolution), never in `archied`. |
|
||||
| **The task DB has one owner.** `<db_path>-tasks.sqlite` is served by the standalone `cmd/archie-state-store` process alone. No second listener, no in-process serving path in the daemon or Gateway. | `boot.openStateStore` (`internal/app/archied/state_store.go`) is the only production caller of `openProductionTaskStore`, and it takes an exclusive flock on `<db>.lock` for the process's life — a second State Store on the same file fails there rather than merely being discouraged. Offline maintenance belongs in subcommands of that binary, never a new `cmd/` entry (`docs/architecture/organisation.md#process-boundaries`). |
|
||||
| **Never commit `.beads/`.** Bead state moves through Dolt; `issues.jsonl` and `interactions.jsonl` are local-only. | A lane that stages `.beads/` pollutes its diff. Closing a bead is not commit-worthy on its own. |
|
||||
| **Generated assets are LAW.** `ui/dist/` and the schema outputs (`docs/data/generated/contracts.json`). | Incorporate them into the commit that shifted them. Never revert, regenerate away, or leave them out. |
|
||||
| **Scratch goes to `/tmp` only.** Never the working tree. | `worktree.CommitAll` stages with go-git's `AddWithOptions{All: true}` (`internal/worktree/worktree.go:502`), which does **not** honour `.gitignore`. An untracked scratch file in a lane worktree is swept onto the task branch. The task brief lives in `.git/task.json` for exactly this reason. |
|
||||
| **A config field must survive the control-plane round trip or it does nothing.** A field added to `MCPServer` (or any projected settings type) must be carried in three sites: `mcpServerSettings` and `seedTools` in `internal/app/controlplane/tool_settings.go`, and `runtimeToolConfigFrom` in `runtime_config.go`. | The control plane rebuilds the whole resource from that projection, so a field missing there is silently dropped whenever a control plane is configured: the setting parses, appears in the dashboard, and has no effect. `TestToolSettingsProjectionCarriesEveryMCPServerField` reflects over `MCPServer` and fails on an omitted field, in both directions (seed and layering) — but it covers that type only; every other mirrored type (`minimaxSettings`, ...) is still hand-mirrored. Adding the field to just `internal/config` is the `xrux`/`parallel_tool_calls` failure shape. |
|
||||
| **Dependency direction is `cmd -> app -> {domain, infrastructure}`**, with infrastructure implementing domain contracts. | A lane that needs a new edge says so before writing it. The `internal/{logging,events,eventbus,policy,taskstate}` cross-cutting packages import zero internal packages. Source: `docs/architecture/organisation.md`. |
|
||||
|
||||
## The canonical gate
|
||||
|
||||
```bash
|
||||
~/.agents/skills/high-throughput-programming/scripts/gate-evidence.sh \
|
||||
<worktree> '<scoped test cmd>' <base>
|
||||
```
|
||||
|
||||
Run it on the host, per lane. It executes the scoped tests, then a module-wide
|
||||
build (`go build ./...`) and the linter (`golangci-lint run ./...`), and emits
|
||||
JSON for the harness to use as the child's structured output.
|
||||
|
||||
The two extra checks are required, not optional. `go test ./pkg/...` compiles
|
||||
only that package, so a changed constructor signature or interface passes its own
|
||||
lane and breaks the next package to merge. That shape has bitten twice here: one
|
||||
lane changed a constructor's signature, passed its own gate, and failed three
|
||||
packages the moment it merged; formatting and lint drifted the same way, and only
|
||||
the repository gate saw it. Both failures are paid for inside the lane when the
|
||||
gate runs the build and the linter, and at merge when it does not.
|
||||
|
||||
A copy of the script under `.pi/control-plane-run/` is that run's disposable
|
||||
state and may lag the skill's version. The skill's copy is the one to trust.
|
||||
|
||||
## Shape a lane's test command like this
|
||||
|
||||
Name every package the change can reach, plus `go vet` on the same set:
|
||||
|
||||
```bash
|
||||
go test ./internal/app/controlplane/... ./internal/domain/applystatus/... -count=1 \
|
||||
&& go vet ./internal/app/controlplane/... ./internal/domain/applystatus/...
|
||||
```
|
||||
|
||||
Real examples, from the worked example's `lanes.json`:
|
||||
|
||||
| Lane surface | Scoped command |
|
||||
|---|---|
|
||||
| CLI subcommands and the State Store contract | `go test ./cmd/... ./internal/infrastructure/staterpc/... -count=1 && go vet ./cmd/...` |
|
||||
| Workflow registry and the agent worker | `go test ./internal/domain/workflow/... ./internal/app/agentworker/... -count=1 && go vet ./internal/domain/workflow/...` |
|
||||
| Config decoding and daemon boot | `go test ./internal/infrastructure/configuration/... ./internal/app/archied/... -count=1 && go vet ./internal/infrastructure/configuration/... ./internal/app/archied/...` |
|
||||
|
||||
`task check` is the *serial full gate* — fmt, proto checks, `docs:check`, vet,
|
||||
lint, build, `go test ./...`, the tools tests and the dashboard tests. The merge
|
||||
train owns it. Never run it in a lane, and never two at once: it saturates the
|
||||
host.
|
||||
|
||||
"Never two at once" includes gates you did not start. More than one agent session
|
||||
works in this checkout, so before the merge train gates, check who holds it:
|
||||
|
||||
```bash
|
||||
ps -ef | grep -E '[t]ask check|[t]ask ' | grep -v grep
|
||||
```
|
||||
|
||||
A concurrent gate is not merely slow. Both runs regenerate
|
||||
`docs/data/generated/contracts.json` and `ui/dist`, so a contended result is
|
||||
worthless in either direction — neither run's verdict tells you anything about
|
||||
the tree. Wait for the host to be quiet and bound the wait: still held after
|
||||
about twenty minutes means report the contention rather than gate anyway.
|
||||
|
||||
The train integrates **local** `main`. Nothing in the gate consults `origin`, and
|
||||
the version stamp comes from `git describe --tags` against local tags, so
|
||||
unpushed commits neither block nor invalidate a gate run — the remote can lag
|
||||
and does, since the maintainer pushes when inclined.
|
||||
|
||||
## The agent-discovery trap
|
||||
|
||||
A lane worktree is a **sibling** of the repository (`/work/apps/cp-<lane>`), not a
|
||||
directory inside it. pi discovers project-scope agents under `<cwd>/.pi/agents/`,
|
||||
so a child launched in a lane worktree does not see them and dies with
|
||||
`Unknown agent: cp-writer`.
|
||||
|
||||
Fix it once per worktree:
|
||||
|
||||
```bash
|
||||
mkdir -p /work/apps/cp-<lane>/.pi
|
||||
ln -sfn /work/apps/archie-core/.pi/agents /work/apps/cp-<lane>/.pi/agents
|
||||
```
|
||||
|
||||
`.pi/` is gitignored, so the worktree stays clean and the symlink cannot reach a
|
||||
commit. This costs an hour to rediscover.
|
||||
|
||||
## Traps worth carrying
|
||||
|
||||
- **`touch` does not invalidate a Task source.** Task hashes file *content*, so a
|
||||
stale-binary probe has to change bytes. `task build` now tracks `ui/dist/**`,
|
||||
the generated dashboard the binary embeds, which is why the merge train still
|
||||
runs `task build --force` before the gate.
|
||||
- **`GATEWAY_VERSION` and `RUNTIME_VERSION` come from `git describe`**, which no
|
||||
file checksum can invalidate: an empty commit moves the stamp while `task
|
||||
build` still reports the binary up to date, shipping the old value. Tracked as
|
||||
`archie-core-pdq2`.
|
||||
- **Untracked files in the shared checkout are other sessions'.** prdlint
|
||||
scratch (`docs/prds/rules.jsonl`), editor state, and gate-written artifacts
|
||||
appear and vanish under a lane. Never chase, add, stage or commit them: a
|
||||
merge train's scope is its own lanes' files, and nothing else.
|
||||
|
||||
## Tracker conventions
|
||||
|
||||
`bd` is the only tracker; no markdown TODO lists, no local trackers.
|
||||
|
||||
```bash
|
||||
bd show <id> # before working an item — the brief may describe a tree that has moved
|
||||
bd update <id> --claim
|
||||
bd close <id> # after the work lands, not when it commits
|
||||
```
|
||||
|
||||
Bead state moves through Dolt, never through git commits on this repository. The
|
||||
Dolt remote is pushed explicitly (`bd dolt push`) and never assumed to be in sync.
|
||||
|
||||
## Run artifacts are evidence, not documentation
|
||||
|
||||
`.pi/control-plane-run/` holds a run's scaffold, lane plan, prompts, scripts and
|
||||
gate output. It is gitignored and disposable. Treat it as run evidence only: a
|
||||
fact worth keeping goes into this skill, `docs/`, or `ARCHITECTURE.md`, not into a
|
||||
run directory the next clean deletes.
|
||||
|
||||
## Worked example
|
||||
|
||||
`references/worked-example/` is the control-plane backlog run of September 2026,
|
||||
committed verbatim: the filled orchestrator prompt, four lane briefs, three
|
||||
sub-prompts, and the three agent definitions with their project invariants
|
||||
inlined. Read it for the level of detail a good brief carries.
|
||||
|
||||
Its scripts are the snapshot's, not the current ones. The user-scope skill's
|
||||
`scripts/` and `templates/` are normative and win any disagreement.
|
||||
@@ -1,4 +0,0 @@
|
||||
interface:
|
||||
display_name: "Archie Agent Fleet"
|
||||
short_description: "Run bounded agent fleets on archie-core"
|
||||
default_prompt: "Use $archie-agent-fleet to fan work out across lanes on this repository, carrying the fleet invariants, the gate evidence it needs, and the worktree agent-discovery fix."
|
||||
@@ -1,467 +0,0 @@
|
||||
# Mission: clear the archie-core control-plane backlog with a bounded high-throughput fleet
|
||||
|
||||
> **Where this file's paths point.** This is the committed copy of a live run.
|
||||
> Paths under `.pi/control-plane-run/` (sections 6, 9, 10) name that run's own
|
||||
> disposable copies of `wave0.js`, `wave2.js`, `review.js` and
|
||||
> `gate-evidence.sh`; they are gitignored run state and may lag the skill's
|
||||
> normative versions in `~/.agents/skills/high-throughput-programming/`. The
|
||||
> skill is the one to trust. Paths under `/work/apps/archie-core` and
|
||||
> repo-relative source paths are unchanged.
|
||||
|
||||
You are the orchestrator. You do not write production code yourself. You run
|
||||
waves of subagents through the `subagent` tool, verify their work against git
|
||||
evidence rather than their reports, and land finished slices on `main`.
|
||||
|
||||
Repository: `/work/apps/archie-core`, branch `main`, working tree clean at start.
|
||||
Gate: `task check`. Tracker: `bd`. Read `CLAUDE.md` and
|
||||
`docs/architecture/organisation.md` before Wave 1.
|
||||
|
||||
---
|
||||
|
||||
## 1. Hard rules
|
||||
|
||||
1. **One top-level `subagent` call per wave.** Every child launches inside that
|
||||
call's `workflowScript`. Never open a second top-level orchestration while a
|
||||
wave is running.
|
||||
2. **Read-only fans out wide. Writers do not.** Recon and review children are
|
||||
cheap and parallel. Writer children are bounded by file overlap and by this
|
||||
machine (16 cores), not by the spawn budget.
|
||||
3. **At most one `task check` at a time, ever.** It compiles 117 Go packages,
|
||||
runs the full test suite and the Node dashboard tests, and saturates the
|
||||
machine. Writer children run package-scoped tests only. The full gate belongs
|
||||
to the merge train in Wave 4, which is strictly serial.
|
||||
4. **A worker's report is not evidence.** Accept a lane only on: the handoff
|
||||
manifest path, `git -C <worktree> status --short`, `git log --oneline`, and
|
||||
`git diff --stat` against the lane's own base. A bead marked closed with no
|
||||
commits means the work did not happen.
|
||||
5. **No suppression.** Children may not add `//nolint`, `t.Skip`, build tags that
|
||||
exclude a failing test, or delete an assertion to make a gate pass. Say this
|
||||
in every writer and fix task. A child that suppresses gets its lane reverted,
|
||||
not patched.
|
||||
6. **Formatting is law.** Adopt `task fmt` output verbatim. Never revert a
|
||||
linter or formatter diff.
|
||||
7. **Zero patch stacking.** Two failed fixes on the same logic block means the
|
||||
block gets rewritten, not patched a third time. This is a `CLAUDE.md` rule and
|
||||
it applies to children.
|
||||
8. **Do not push.** Commit gate-clean work to `main` in the captain checkout.
|
||||
Sam pushes manually and does not always announce it, so never assume a commit
|
||||
is local or remote without checking `git log origin/main..main`.
|
||||
9. **No `.beads/` commits.** Bead state moves through Dolt. Closing a bead is not
|
||||
commit-worthy on its own.
|
||||
10. **Scratch stays out of the tree.** Children write scratch to `/tmp` only.
|
||||
`.pi/` is gitignored; nothing else you create may land in a commit.
|
||||
11. **Separation of duties.** No agent merges, closes or approves its own work.
|
||||
Writers write, reviewers review, and you alone run the merge train. You do
|
||||
not write production code; if you find yourself editing a lane's files, the
|
||||
lane was scoped wrong.
|
||||
12. **Every wave ends with an adversarial review pass** before the next wave
|
||||
starts. Reviewers are read-only, parallel and cheap; a defect caught at the
|
||||
end of the wave that produced it costs one lane, and the same defect caught
|
||||
three waves later costs the tree.
|
||||
|
||||
---
|
||||
|
||||
## 2. Ground truth: do not spend agents rediscovering this
|
||||
|
||||
This came from the session that just ended. Treat it as fact.
|
||||
|
||||
- `docs/prds/runtime-control-plane.md` is Approved and is the spec. Its resource
|
||||
surface, YAML workflow definitions, identity-backed attribution and audit trail
|
||||
are already built.
|
||||
- **Restore is not its own command.** A revision carries its value, so restoring
|
||||
replays it through the ordinary replace. Do not add a rollback RPC.
|
||||
- **Dashboard writes attribute to `identity.SystemID`.** One shared bearer token,
|
||||
no per-user session. `webAudit` in `internal/webui/api_identities.go` is the
|
||||
only source. Named attribution needs a dashboard login first.
|
||||
- **`internal/webui` must not link the workflow engine.** It decodes definitions
|
||||
with the projection types in `internal/domain/workflow/task`. `cmd/archie-ui`'s
|
||||
deletion gate fails if anything reaches `internal/domain/workflow`.
|
||||
- Shipped defaults ride `ResourceDescriptor.defaults_json`. The API is fixed at
|
||||
four operations, so defaults get no REST route.
|
||||
- `archie-messaging` fails closed when the State Store is unreachable. The
|
||||
database is authoritative for channel settings. File config is not a fallback.
|
||||
- **The control plane fails closed with no way back.** A stored value that will
|
||||
not validate stops `archied` starting. Nothing bypasses the control plane at
|
||||
boot. `docs/architecture/safe-change-and-recovery.md` records this posture.
|
||||
Resource history is the only in-band remedy and needs the State Store up.
|
||||
- **`task check` will not catch a field the server stopped sending.** Optional
|
||||
chaining made a dead dashboard banner typecheck silently; `delivery-snapshot.sh`
|
||||
scanned for a symbol its composition root no longer calls. Both fixed in
|
||||
`85f0fd0b`. When a server-side field is deleted, grep the dashboard and the
|
||||
snapshot scripts by name. Add this to every review task.
|
||||
- **Reload re-reads the database layer and can fail.** `boot.runtimeConfig` is the
|
||||
one layering call; the SIGHUP callback makes the same call over the document it
|
||||
just resolved (`9af013eb`). A new database-owned layer goes in `runtimeConfig`
|
||||
and nowhere else.
|
||||
- **Apply status lives on the State Store contract, not the control plane.**
|
||||
`PutApplyStatus`/`ListApplyStatus` are administrative, keyed on
|
||||
`(process, kind)`, replaced in place, re-stamped every 30s, stale at 90s, and a
|
||||
stale record renders as "Not reporting", never as current. `applystatus.New`
|
||||
refuses a process name `Processes()` does not list.
|
||||
- Five commits are local as of 2026-09-21: `731a9a06`, `1dd0d874`, `d9dd7885`,
|
||||
`9accf112`, `d38e27fd`. `archie-core-pskb` is closed. There is no post-commit
|
||||
hook; `core.hooksPath` is `.beads/hooks` and those are beads shims.
|
||||
|
||||
---
|
||||
|
||||
## 3. The backlog
|
||||
|
||||
Seven ready beads carry the `control-plane` label. Their real shape is what
|
||||
decides the lanes, and it is not the same as their titles.
|
||||
|
||||
| Bead | Title shape | Primary surface |
|
||||
|------|-------------|-----------------|
|
||||
| `archie-core-nwa0` | check a live replacement before switching to it | live apply path + apply-status surface |
|
||||
| `archie-core-fwmp` | let plugins register workflow step types | `workflow.BuiltinStepRegistry()` and all five call sites |
|
||||
| `archie-core-8szi` | registered steps covering the deleted `.archie` gate | `internal/domain/workflow/steps.go`, needs fwmp's answer |
|
||||
| `archie-core-6zw0` | offline backup/restore/validate/rollback for `archie.db` | new `cmd/` binary + state-store infrastructure |
|
||||
| `archie-core-i3qm` | stop TOML blocking State Store startup | `internal/app/archied/control_plane.go`, bootstrap validation |
|
||||
| `archie-core-xrux` | `ApplyOverlayValues` is dead, confirm the file overlay | `internal/infrastructure/configuration/loader.go`, `apply.go` |
|
||||
| `archie-core-eju6` | end-to-end restart test for a database-backed change | test only, proves the whole loop |
|
||||
|
||||
Three couplings you already know about, and Wave 0 exists to find the rest:
|
||||
|
||||
- **fwmp is the shared shape.** It changes the registry every call site hardcodes
|
||||
(`app/agentworker/task_execution.go:319,:335`,
|
||||
`app/controlplane/workflow_definitions.go:26,:33`, `app/controlplane/client.go:41`)
|
||||
and the validating side and the executing side must resolve it identically.
|
||||
8szi has nothing to register against until fwmp lands. These two are never
|
||||
concurrent writers.
|
||||
- **xrux decides i3qm's blast radius.** xrux is an investigation with two
|
||||
opposite outcomes: either the file overlay zeroes omitted map fields, in which
|
||||
case `foldOverrides` moves there and it is a live bug, or it does not, in which
|
||||
case `apply.go`, `apply_test.go` and `Loader.ApplyOverlay` are deleted. Both
|
||||
land in the same package i3qm rewrites. One lane owns both, in that order.
|
||||
`archie-core-xrux` is a trap, not a cleanup. Read the bead before deleting
|
||||
`apply.go`.
|
||||
- **eju6 proves the others.** It goes last, against everything merged.
|
||||
|
||||
---
|
||||
|
||||
## 4. Models: resolve before Wave 0
|
||||
|
||||
Run `subagent({ action: "models" })` first and pick exact `provider/id` strings.
|
||||
Bare ids resolve only when unique. Then print the table you resolved and use it.
|
||||
|
||||
| Tier | Used by | Pick |
|
||||
|------|---------|------|
|
||||
| Fast | recon, inventory, grep-shaped probes | cheapest capable, low or medium thinking. Default `ollama/deepseek-v4.1-flash:cloud`. |
|
||||
| Strong | writers, integrator | best reasoning model authenticated here, high thinking. Prefer a `deepseek-v4-pro` class id if `models` lists one. |
|
||||
| Review | reviewers, oracle | a **different family** from the writer that produced the diff. Model diversity catches different failure modes; it does not rescue an ambiguous prompt. |
|
||||
|
||||
If a tier cannot be resolved, say so and fall back to the session default rather
|
||||
than inventing an id. Provider 429s return from that model; do not kill a rate
|
||||
limited child, it keeps its context and recovers.
|
||||
|
||||
---
|
||||
|
||||
## 5. Concurrency: the numbers that actually bind
|
||||
|
||||
Defaults in this install (`pi-subagents` 0.70.0) are not 64.
|
||||
|
||||
- `globalConcurrencyLimit` defaults to **20** concurrent children per run. Set it
|
||||
explicitly on each top-level call.
|
||||
- `maxSubagentSpawnsPerRun` defaults to **64** cumulative admissions per run
|
||||
tree, never refunded. Retries and fix passes spend it too.
|
||||
- **Each wave is its own top-level run, so each wave gets its own budget.** This
|
||||
is why the mission is split into waves rather than one giant script.
|
||||
- `runs.lanes` is capped at 32 lanes, 16 stages per lane, 64 stages total.
|
||||
|
||||
Per-wave dials:
|
||||
|
||||
| Wave | Shape | `globalConcurrencyLimit` | `maxSubagentSpawnsPerRun` |
|
||||
|------|-------|--------------------------|---------------------------|
|
||||
| 0 recon | `runs.all`, read-only | 32 | 64 |
|
||||
| 0R audit | `review.js`, angles `claims` | 16 | 24 |
|
||||
| 1 shape-first | one writer plus one probe | 2 | 8 |
|
||||
| 1R review | `review.js`, full angle set, one target | 12 | 16 |
|
||||
| 2 writer lanes | `runs.lanes`, one worktree each | 4 | 32 |
|
||||
| 2R review | `review.js`, full angle set, four targets | 24 | 48 |
|
||||
| 3 fix pass | `runs.lanes`, retained writers | 4 | 24 |
|
||||
| 4 merge train | serial, one `task check` at a time | 1 | 8 |
|
||||
| 4R post-merge | `review.js` on merged `main`, angles `boundary`, `deadfield`, `contract` | 8 | 12 |
|
||||
| 5 eju6 | one lane, then its own review | 2 | 12 |
|
||||
|
||||
Do not set a hard `toolBudget` or a tight `usageBudget` on any writer, fix
|
||||
worker, or reviewer with edit authority: the default budget blocks read and
|
||||
search tools rather than mutation tools, which leaves a half-written tree. Bound
|
||||
writers with `timeoutMs` plus `checkpointBeforeDeadlineMs` instead. Hard caps are
|
||||
fine on explicitly read-only children.
|
||||
|
||||
---
|
||||
|
||||
## 5a. The constraint is review, not generation
|
||||
|
||||
Generation is no longer the bottleneck and has not been for a while. The
|
||||
measured evidence is consistent: agent-authored changes take far longer to reach
|
||||
a first review, merge at a lower rate than human-authored ones, and raise more
|
||||
issues per change; one randomized study found experienced developers 19% slower
|
||||
with agent tooling while expecting to be faster. Feature-branch throughput rises
|
||||
while main-branch throughput falls. Adding writer lanes past what review can
|
||||
absorb does not raise throughput, it grows a queue, and queued work ages badly
|
||||
because the tree moves underneath it.
|
||||
|
||||
Act on that as follows.
|
||||
|
||||
- **WIP is capped by review, not by cores.** Four writer lanes exist because
|
||||
four is what the review pass and the merge train can absorb per cycle. Do not
|
||||
raise it to use spare concurrency.
|
||||
- **Put the judgment upstream.** Before a writer starts, its task must carry
|
||||
intent, acceptance criteria and non-goals, so verification has an external
|
||||
reference. "Does this do what it was supposed to do" is checkable; "does this
|
||||
look right" is not, and fluent output passes a read-through scan regardless of
|
||||
whether it is correct.
|
||||
- **Spend the effort on the verifier, not the prompt.** A parallel fleet is only
|
||||
as good as the check that decides whether its output is right. A better test
|
||||
is worth more than a better instruction.
|
||||
- **Every handoff carries evidence.** Intent, non-goals, files touched with a
|
||||
reason each, alternatives rejected, commands actually run with pasted output,
|
||||
the test that would fail first, and known limitations. A report that only
|
||||
describes its own diff is not evidence.
|
||||
- **Deterministic gates run before any reviewer looks.** `gate-evidence.sh` runs
|
||||
the lane's tests on the host and emits JSON that becomes the child's
|
||||
structured output, and it fails the lane on added `//nolint`, `t.Skip`, ignore
|
||||
build tags, removed tests or removed assertions. Gate gaming is cheap to
|
||||
detect and expensive to miss, so detect it mechanically rather than asking a
|
||||
reviewer to notice.
|
||||
- **Keep batches small.** Generation being cheap is a reason for smaller
|
||||
changes, not bigger ones. A lane whose diff passes roughly 400 changed lines
|
||||
gets split at a coherent boundary.
|
||||
- **Route risk, do not review uniformly.** These surfaces get Sam's eyes before
|
||||
merge, named explicitly in your report: the fail-closed boot path
|
||||
(`boot.runtimeConfig`, bootstrap validation), the State Store wire contract and
|
||||
its error sentinels, task-scoped grants and credentials, anything that writes
|
||||
or migrates `archie.db`, and the release or CI surface. Everything else merges
|
||||
on gate plus reviewer verdict, with a sample called out for him to spot-check.
|
||||
- **Watch the right numbers.** Report per wave: reviewer findings raised versus
|
||||
accepted, lanes blocked by gate versus by review, rework passes per lane, and
|
||||
wall-clock from lane start to merged. Lines written and beads closed measure
|
||||
how fast the queue fills.
|
||||
|
||||
---
|
||||
|
||||
## 6. Wave 0: recon fanout (read-only, wide)
|
||||
|
||||
One top-level call, `async: true`, `workflowScriptPath: ".pi/control-plane-run/wave0.js"`.
|
||||
|
||||
Three probes per bead, plus four cross-cutting probes: 25 children, all
|
||||
`cp-recon`, all read-only, all returning structured output. The probe text is composed inside
|
||||
`wave0.js`; do not retype it.
|
||||
|
||||
Per bead:
|
||||
|
||||
- **spec** — extract the exact PRD clauses the bead must satisfy, with line
|
||||
anchors, and the acceptance criteria the gate can actually check.
|
||||
- **blast** — trace every call site, consumer and test of the symbols the bead
|
||||
names. Return package paths and file paths, not prose.
|
||||
- **tests** — inventory the tests that already cover this surface and name the
|
||||
one test that would fail first if the change were wrong.
|
||||
|
||||
Cross-cutting:
|
||||
|
||||
- **overlap** — for all seven beads, the set of packages and files each one must
|
||||
modify, in one table.
|
||||
- **gate-cost** — time `task build` and `go test ./internal/app/controlplane/...`
|
||||
and report wall-clock, so Wave 2 timeouts are measured rather than guessed.
|
||||
- **dead-field** — grep `ui/src/` and `scripts/delivery-snapshot.sh` for every
|
||||
control-plane field name the server sends today, and flag any the server no
|
||||
longer sends. This is the failure class `task check` cannot see.
|
||||
- **contract-pairs** — find every place the validating side (State Store) and
|
||||
the executing side (archie-agent) must agree on the same vocabulary, and name
|
||||
the single test that would tie each pair together.
|
||||
|
||||
Every probe returns `structuredOutput` matching the schema in `wave0.js`. Long
|
||||
findings go to a file via `outputMode: "file-only"`; do not pull transcripts into
|
||||
your context.
|
||||
|
||||
**Do not let a recon child draw the conclusion.** A scout that measures correctly
|
||||
can still land the wrong call, and its write-up reads confident either way. Take
|
||||
their facts, make the call yourself.
|
||||
|
||||
---
|
||||
|
||||
## 7. Checkpoint A: lane plan, then stop
|
||||
|
||||
Build the conflict matrix from the `overlap` probe and the per-bead `blast`
|
||||
results. Two beads may be concurrent writers only if their file sets are
|
||||
disjoint. Directory names are not evidence of disjointness: check the imports.
|
||||
|
||||
Then report to Sam, in under 30 lines:
|
||||
|
||||
- the matrix, as bead by bead package intersections;
|
||||
- the proposed lanes, and which beads you are deliberately serializing;
|
||||
- any bead whose description no longer matches the tree, with the commit that
|
||||
moved underneath it;
|
||||
- the measured gate cost and the timeouts you derived from it;
|
||||
- anything in Wave 0 that contradicts section 2.
|
||||
|
||||
Wait for approval before Wave 1. This is the only mandatory stop.
|
||||
|
||||
---
|
||||
|
||||
## 8. Wave 1: shape-first, serial
|
||||
|
||||
Land the shared shape before anything forks against it. Five workers each adding
|
||||
a field to one struct produced eight cleanup commits on this repo in July; the
|
||||
merge cost scales with shared-file overlap, not worker count.
|
||||
|
||||
Sub-prompts for both children are in `prompts/wave1.md`.
|
||||
|
||||
1. **fwmp** alone: one `cp-writer`, `worktree: true`, red-green, gate
|
||||
`go test ./internal/domain/workflow/... ./internal/app/controlplane/... ./internal/app/agentworker/...`.
|
||||
Requirement: one contract test asserting the validating registry and the
|
||||
executing registry resolve the same step vocabulary. Two sides that each pass
|
||||
their own tests and disagree with each other is the exact failure this bead
|
||||
exists to prevent.
|
||||
2. Merge fwmp through the Wave 4 train immediately, before Wave 2 starts. Wave 2
|
||||
branches from the merged shape.
|
||||
3. **xrux investigation** runs concurrently with fwmp, because it is read-only
|
||||
until it has a verdict: one `cp-recon` writes a characterization test in a
|
||||
scratch worktree that answers the single question, does `Loader.overlayFile`
|
||||
zero omitted fields of a map-valued entry. It returns the verdict and the
|
||||
test, and nothing else. The verdict decides the i3qm lane's stages.
|
||||
|
||||
---
|
||||
|
||||
## 9. Wave 2: bounded writer lanes
|
||||
|
||||
One top-level call, `runs.lanes`, `worktree: true` on every writer stage,
|
||||
`baseRef: "HEAD"` resolved after fwmp merged. Four lanes, concurrency 4.
|
||||
|
||||
| Lane | Beads | Stages |
|
||||
|------|-------|--------|
|
||||
| `live` | nwa0 | red, green, self-gate, challenge |
|
||||
| `recovery` | 6zw0 | red, green, self-gate, challenge |
|
||||
| `steps` | 8szi | red, green, self-gate, challenge |
|
||||
| `config` | xrux then i3qm | verdict-apply, red, green, self-gate, challenge |
|
||||
|
||||
Stage contract, enforced by `wave2.js` and the `cp-writer` agent definition:
|
||||
|
||||
- **red**: write the failing table-driven test first, run it, and paste the
|
||||
failure. Verify the failure comes from an assertion, not a compile error. A
|
||||
test that cannot fail for an interesting reason is noise in the gate.
|
||||
- **green**: minimal implementation that satisfies the failing test.
|
||||
- **self-gate**: a typed `gate` pointed at
|
||||
`.pi/control-plane-run/gate-evidence.sh`, which runs the lane's package-scoped
|
||||
test command on the host and returns JSON that becomes the child's
|
||||
`structuredOutput`: branch, sha, changed files, uncommitted files, test exit
|
||||
and tail, plus the gate-gaming counters. Never `task check`. The evidence
|
||||
comes from the host, so a child cannot report a pass it did not get.
|
||||
- **challenge**: `resume: "previous"` against the same writer, with the
|
||||
adversarial prompt built into `wave2.js`'s challenge stage. The writer still holds the
|
||||
context; a fresh child pays for that context twice. Only resume a child
|
||||
`children.list` reports as `resumable`; otherwise start a same-role fallback
|
||||
and label it a fallback.
|
||||
|
||||
Each lane's writer also returns the evidence handoff in `wave2.js`: intent,
|
||||
non-goals, files with reasons, alternatives rejected, commands run with pasted
|
||||
output, the test that would fail first, and known limitations. A lane whose diff
|
||||
passes roughly 400 changed lines stops at a coherent boundary and reports what
|
||||
remains rather than growing further.
|
||||
|
||||
Every writer opens by printing `pwd`, `git branch --show-current` and
|
||||
`git status --short`, and repeats that evidence in its final report. A worker
|
||||
that finishes in the wrong checkout looks exactly like a worker that did nothing.
|
||||
|
||||
A failed stage blocks only its lane. Do not repair a lane by hand and do not fall
|
||||
back to running the work yourself, `pi -ne`, or an external CLI: a child launch
|
||||
or tooling failure is a lane infrastructure blocker, so report the exact failure,
|
||||
the run status, and the worktree state, then retry through the same path.
|
||||
|
||||
---
|
||||
|
||||
## 10. Review after every wave
|
||||
|
||||
`.pi/control-plane-run/review.js`, read-only `cp-reviewer` children on a
|
||||
different model family from the producer, one child per angle per target. The
|
||||
angles live in that script: `bead`, `invariant`, `contract`, `deadfield`,
|
||||
`boundary`, `operator`, `tests`, `gaming`, `intent`, plus `claims` for auditing
|
||||
recon findings.
|
||||
|
||||
| After | Targets | Angles |
|
||||
|-------|---------|--------|
|
||||
| Wave 0 | the recon findings themselves | `claims` |
|
||||
| Wave 1 | `cp/shape` | full set |
|
||||
| Wave 2 | the four lane branches | full set |
|
||||
| Wave 4 | merged `main` | `boundary`, `deadfield`, `contract` |
|
||||
| Wave 5 | the eju6 branch | `tests`, `operator`, `intent` |
|
||||
|
||||
The Wave 0 audit is the cheapest of these and catches the most: a recon child
|
||||
that measures correctly can still carry a wrong conclusion into your lane plan,
|
||||
and its write-up reads confident either way. Feed the audit the claims your lane
|
||||
plan is about to rest on, and check the load-bearing ones before Checkpoint A,
|
||||
not after.
|
||||
|
||||
Reviewers label findings P0/P1/P2 by evidence, not by severity language, carry
|
||||
`file:line` with a quoted proof, and end with one of `Merge verdict: BLOCK`,
|
||||
`Merge verdict: OK`, `Merge verdict: OK with notes`. Prose is never parsed for
|
||||
control flow: you decide the lane's fate from the findings.
|
||||
|
||||
Fixes go back to that lane's retained writer, batched into one pass, not one
|
||||
child per finding. Resume only a writer `children.list` reports as `resumable`;
|
||||
otherwise start a same-role fallback and label it as a fallback. A second failed
|
||||
fix on the same logic block means the lane is reverted and requeued, not patched
|
||||
again.
|
||||
|
||||
Count the pass as complete only when every angle returned. A missing angle is an
|
||||
unreviewed axis, not a clean one.
|
||||
|
||||
---
|
||||
|
||||
## 11. Wave 4: merge train, strictly serial
|
||||
|
||||
The procedure, with the exact commands, is in `prompts/wave4-merge-train.md`.
|
||||
One branch at a time, in dependency order, in the captain checkout at
|
||||
`/work/apps/archie-core`. Per branch:
|
||||
|
||||
1. `git merge-base --is-ancestor main <branch>`. A stale branch computed its
|
||||
deletions against code that has since changed; rebase or re-derive, never
|
||||
merge it as is.
|
||||
2. Apply the lane's handoff patch.
|
||||
3. `task check`, once, alone. Nothing else runs while it does.
|
||||
4. On failure: one fix pass through the lane's writer with the real output. On a
|
||||
second failure, revert the lane and requeue it; do not stack a third patch.
|
||||
5. Commit with a conventional scope (`feat(controlplane): ...`,
|
||||
`fix(config): ...`). Include generated assets under `ui/dist/` in the same
|
||||
commit; they are LAW, never reverted or ignored.
|
||||
6. `bd close <id>`. Do not stage `.beads/`.
|
||||
7. Verify it landed: `git log --oneline -1`, then
|
||||
`git branch --no-merged main`. Done has three states: no commits, committed
|
||||
and unmerged, merged. Only the third counts.
|
||||
|
||||
Your own edits get the same gate as the children's. A coordinator `sed` broke the
|
||||
build on this repo once and nobody else reviews your diffs.
|
||||
|
||||
---
|
||||
|
||||
## 12. Wave 5: eju6
|
||||
|
||||
Sub-prompt in `prompts/wave5-eju6.md`. Last, against merged `main`. One lane: an end-to-end test that drives a change
|
||||
through the API, restarts a process, and asserts the change survived. Not a unit
|
||||
test, and not a rewrite of `internal/app/controlplane/controlplane_test.go`,
|
||||
which covers seeding and catalog only. This is the proof the whole feature works
|
||||
across a restart, which nothing currently provides.
|
||||
|
||||
If it fails, that is a finding about the feature, not about the test. Report it
|
||||
and stop rather than weakening the assertion.
|
||||
|
||||
---
|
||||
|
||||
## 13. Final report
|
||||
|
||||
- Beads closed, with the commit that closed each one.
|
||||
- Beads deliberately not attempted, and why.
|
||||
- `task check` result on final `main`, quoted, not summarized.
|
||||
- Every branch still unmerged, and whether it holds work.
|
||||
- Commits now local and unpushed (`git log --oneline origin/main..main`), stated
|
||||
as fact without pushing.
|
||||
- Anything you found that contradicts `docs/prds/runtime-control-plane.md` or
|
||||
section 2 of this prompt, filed as a new bead.
|
||||
- New beads for identified debt or follow-ups, filed via `bd`.
|
||||
- The wave metrics: per wave, reviewer findings raised versus accepted, lanes
|
||||
blocked by the gate versus by review, rework passes per lane, and wall-clock
|
||||
from lane start to merged. Say which stage was the constraint in practice and
|
||||
whether it matched the prediction that review would be.
|
||||
- The risk-routed surfaces that changed and need Sam's eyes: the fail-closed
|
||||
boot path, the State Store wire contract and error sentinels, grants and
|
||||
credentials, anything touching `archie.db`, and the release or CI surface.
|
||||
@@ -1,43 +0,0 @@
|
||||
# Worked example: archie-core control plane, September 2026
|
||||
|
||||
A real run, frozen partway through, kept verbatim so the shapes can be read
|
||||
rather than re-derived. It is repository-specific on purpose: the value is in
|
||||
seeing how much project knowledge a good brief carries.
|
||||
|
||||
**Its scripts are the snapshot's, not the current ones.** This directory was
|
||||
captured mid-run, so the scripts in it predate fixes the skill's own lessons
|
||||
describe — the typed-gate boolean trap, the post-fix re-gate and re-review, the
|
||||
P2 handling, the build and lint checks in the gate.
|
||||
`~/.agents/skills/high-throughput-programming/scripts/` and
|
||||
`~/.agents/skills/high-throughput-programming/templates/` are normative; if this
|
||||
directory disagrees with them, they win. Read the briefs, the lane plan and the
|
||||
merge-train procedure here. Do not copy the scripts.
|
||||
|
||||
The method this run followed lives in the user-scope skill
|
||||
`~/.agents/skills/high-throughput-programming/`; it is normative for method. This
|
||||
repository's `archie-agent-fleet` skill is normative for facts about archie-core.
|
||||
A run in another repository uses that skill's `templates/` plus its own filled-in
|
||||
briefs — none of the archie specifics here transfer.
|
||||
|
||||
Seven tracker items, one shared shape, four lanes, a review pass after every
|
||||
wave, a serial merge train.
|
||||
|
||||
| File | Note |
|
||||
|------|------|
|
||||
| `00-orchestrator.md` | The filled orchestrator prompt. Section 2 is the project's ground truth, section 5a the review-is-the-constraint doctrine, section 10 the review cadence. |
|
||||
| `lanes.json` | Lane briefs carrying intent, traps and `file:line` premises. Read one to see the level of detail a brief needs. |
|
||||
| `prompts/wave1.md` | The shared shape, plus an investigation whose verdict gated another lane. |
|
||||
| `prompts/wave4-merge-train.md` | The serial merge procedure with the project's own hazards in it. |
|
||||
| `agents/` | The three agent definitions with project invariants inlined. |
|
||||
|
||||
No scripts are copied here. This run's `wave0.js`, `wave2.js`, `review.js` and
|
||||
`gate-evidence.sh` became `templates/recon.js`, `templates/lanes.js`,
|
||||
`templates/review.js` and `scripts/gate-evidence.sh` in the user-scope skill;
|
||||
those are normative, and this directory's stale copies were deleted so there is
|
||||
exactly one of each to keep current.
|
||||
|
||||
What this run's Wave 0 actually caught, which is the argument for recon before
|
||||
fanout: three of the seven items had premises that no longer matched the tree,
|
||||
including one whose target file did not exist under the name the item used, one
|
||||
whose anchor had moved commits earlier, and one whose scope could not reach the
|
||||
clause it cited. All three would have produced confidently wrong lanes.
|
||||
@@ -1,105 +0,0 @@
|
||||
# Control-plane backlog run: how to drive it
|
||||
|
||||
This is the committed copy of a real run. Its originals lived in
|
||||
`/work/apps/archie-core/.pi/control-plane-run/`, which is gitignored, disposable
|
||||
run state whose live copies may have moved on since. Nothing here is load
|
||||
bearing at runtime.
|
||||
|
||||
The method is not here. The pipeline shape, the concurrency ceilings, the
|
||||
pi-subagents traps, and the `scripts/` and `templates/` this file names all live
|
||||
in the user-scope skill `~/.agents/skills/high-throughput-programming/`, and that
|
||||
skill is normative for method. This copy is normative only for what the run
|
||||
looked like on this repository; the archie-specific facts themselves live in the
|
||||
parent `archie-agent-fleet` skill. A run in another repository uses that skill's
|
||||
`templates/` plus its own filled-in briefs.
|
||||
|
||||
## Files
|
||||
|
||||
| File | What it is |
|
||||
|------|------------|
|
||||
| `00-orchestrator.md` | The prompt you give pi. It owns the waves, the ceilings and the verification rules. |
|
||||
| *(the scripts)* | This run's `wave0.js`, `wave2.js`, `review.js` and `gate-evidence.sh` are **not copied here**: they live on as `templates/recon.js`, `templates/lanes.js`, `templates/review.js` and `scripts/gate-evidence.sh` under `~/.agents/skills/high-throughput-programming/`, which are normative. The snapshot's copies were stale, so they were deleted rather than duplicated. |
|
||||
| `lanes.json` | Lane definitions: worktree paths, branches, beads, scoped test commands, briefs. Fill in the model id. |
|
||||
| `prompts/wave1.md` | fwmp shape-first writer, and the xrux verdict probe. |
|
||||
| `prompts/wave4-merge-train.md` | The serial merge procedure and the landing checks. |
|
||||
| `prompts/wave5-eju6.md` | The end-to-end restart test. |
|
||||
| `agents/cp-recon.md`, `agents/cp-writer.md`, `agents/cp-reviewer.md` | Project-scope agent definitions, as the run used them from `.pi/agents/`; these committed copies sit beside this file. |
|
||||
|
||||
## Start it
|
||||
|
||||
```fish
|
||||
cd /work/apps/archie-core
|
||||
pi "$(cat .pi/control-plane-run/00-orchestrator.md)"
|
||||
```
|
||||
|
||||
The `.pi/control-plane-run/` path is the run's own state directory, not this
|
||||
copy. Interactive is the right mode here: Checkpoint A after Wave 0 is a real
|
||||
stop and wants you in the loop. `/subagents-fleet` opens the live inspector,
|
||||
`/subagents-doctor` checks the install.
|
||||
|
||||
## Before Wave 2
|
||||
|
||||
Create the durable worktrees yourself. Managed `worktree: true` children capture
|
||||
a patch and then remove the worktree, which a resumed challenge stage cannot
|
||||
edit, so the lanes use operator-created worktrees plus per-child `cwd`.
|
||||
|
||||
```fish
|
||||
for lane in live recovery steps config
|
||||
git -C /work/apps/archie-core worktree add ../cp-$lane -b cp/$lane
|
||||
end
|
||||
```
|
||||
|
||||
A lane worktree is a **sibling** of the repository, so `.pi/agents/` inside the
|
||||
repository is not discovered from it. Link it per worktree or the children fail
|
||||
with `Unknown agent: cp-writer`:
|
||||
|
||||
```fish
|
||||
for lane in live recovery steps config
|
||||
mkdir -p /work/apps/cp-$lane/.pi
|
||||
ln -sfn /work/apps/archie-core/.pi/agents /work/apps/cp-$lane/.pi/agents
|
||||
end
|
||||
```
|
||||
|
||||
Then fill `model` in `lanes.json` from what `subagent({ action: "models" })`
|
||||
resolves, and pass it as `args`.
|
||||
|
||||
## Ceilings worth knowing before you tune anything
|
||||
|
||||
This install is `pi-subagents` **0.70.0**, matching your clone except for four
|
||||
doc files. Two 0.69/0.70 features are load bearing here: typed gates
|
||||
(`gate: { command, output: "json" }` turns a host command's JSON stdout into the
|
||||
child's `structuredOutput`) and `allowedAgents`, which can stop a reviewer
|
||||
launching a writer if you want separation of duties enforced rather than
|
||||
instructed.
|
||||
|
||||
- `globalConcurrencyLimit` defaults to **20**, not 64. Set it per top-level call.
|
||||
- `maxSubagentSpawnsPerRun` defaults to **64** cumulative admissions per run
|
||||
tree, never refunded, so retries spend it. Each wave is a separate top-level
|
||||
run precisely so each gets its own budget.
|
||||
- `runs.lanes` caps at 32 lanes, 16 stages per lane, 64 stages total.
|
||||
- `gate` is rejected on a retained `resume` item, which is why the challenge
|
||||
stage runs its tests through `bash` instead.
|
||||
- A typed gate cannot be combined with `outputSchema` on the same child, so the
|
||||
writer stages carry the gate and the reviewers carry the schema.
|
||||
- Host steps have no per-step `cwd`, which is why `gate-evidence.sh` takes the
|
||||
worktree path as its first argument instead of relying on one.
|
||||
|
||||
## Why the fleet is not 64 writers
|
||||
|
||||
64 concurrent children is comfortable for read-only work and pointless for
|
||||
writers here. Two limits bite first:
|
||||
|
||||
1. **Overlap.** Merge cost scales with shared file overlap, not worker count.
|
||||
Seven beads reduce to four genuinely disjoint lanes plus one shared shape
|
||||
that has to land alone first. Five workers each adding a field to one struct
|
||||
cost eight cleanup commits on this repo in July.
|
||||
2. **The machine.** 16 cores, 117 Go packages, and `task check` also runs the
|
||||
dashboard tests. One full gate saturates the host, so the gate is serialized
|
||||
into the merge train and writers run package-scoped tests.
|
||||
|
||||
The throughput comes from recon and review: 25 recon children, then a review
|
||||
pass after every wave at up to 36 children, all read-only, all cheap, all
|
||||
genuinely parallel. The writers stay at four because that is what the
|
||||
repository's coupling and the review pass can absorb. The measured literature is
|
||||
consistent that review, not generation, is where agent-heavy pipelines stall, so
|
||||
spare concurrency goes into checking rather than into more lanes.
|
||||
@@ -1,27 +0,0 @@
|
||||
---
|
||||
name: cp-recon
|
||||
description: Read-only recon on archie-core. Traces call sites, extracts spec clauses, inventories tests. Returns citations, never conclusions.
|
||||
tools: read, grep, find, ls, bash
|
||||
excludeTools: write, edit
|
||||
acceptanceRole: read-only
|
||||
completionGuard: false
|
||||
inheritProjectContext: true
|
||||
inheritGlobalContext: false
|
||||
inheritSkills: false
|
||||
thinking: high
|
||||
systemPromptMode: replace
|
||||
---
|
||||
|
||||
You are a read-only investigator in the archie-core Go repository. You measure; you do not decide.
|
||||
|
||||
Rules:
|
||||
|
||||
- Never edit, write, stage, commit, or run anything that mutates the tree. `bash` is for `git log`, `grep`, `go list`, `bd show`, and timing commands only.
|
||||
- Every claim carries `file:line`. A claim without a citation is not a finding, it is a guess.
|
||||
- Report facts. The orchestrator draws the conclusion. Do not recommend a course of action unless you were asked for one, and never close or reopen a bead.
|
||||
- Grep first, then read only the lines that matter. Do not pull whole packages into context.
|
||||
- Directory and bead names are not evidence of coupling. Check the imports.
|
||||
- `ARCHITECTURE.md` and `CLAUDE.md` are stale by construction in this repo. The tree is the only evidence of current state; when a doc and the code disagree, report both and say which file you read.
|
||||
- If your task's premise is false, say so plainly as your first line instead of answering the question you were asked.
|
||||
|
||||
Finish with your structured output. Keep prose under 40 lines; long inventories belong in your output file.
|
||||
@@ -1,34 +0,0 @@
|
||||
---
|
||||
name: cp-reviewer
|
||||
description: Read-only adversarial reviewer for one archie-core lane and one angle. Evidence-labelled findings and a single merge verdict.
|
||||
tools: read, grep, find, ls, bash
|
||||
excludeTools: write, edit
|
||||
acceptanceRole: read-only
|
||||
completionGuard: false
|
||||
inheritProjectContext: true
|
||||
inheritGlobalContext: false
|
||||
inheritSkills: false
|
||||
thinking: high
|
||||
systemPromptMode: replace
|
||||
---
|
||||
|
||||
You review one lane of archie-core work from one angle. You did not write this code and you do not fix it.
|
||||
|
||||
Start from `git diff main..<branch>` and `git diff --stat main..<branch>`. Review the diff, never the writer's transcript: the transcript costs context and carries almost no signal.
|
||||
|
||||
What you are looking for, in order:
|
||||
|
||||
1. Behaviour the change dropped while keeping the shape. Refactors lose guards. Read every new or changed doc comment: one that describes a silent fallback is usually a confession.
|
||||
2. A claim in the diff that the code does not support.
|
||||
3. A test that restates an assignment or a constant instead of failing for an interesting reason.
|
||||
4. Two sides that must agree and have no test tying them together.
|
||||
|
||||
Rules:
|
||||
|
||||
- Read-only. Do not edit, stage, commit, or fix. Propose the fix in words.
|
||||
- Every finding carries `file:line` and a quoted proof.
|
||||
- Label by evidence, not by how bad it sounds: P0 breaks a user-reachable path or an invariant, P1 is a real defect with a bounded blast radius, P2 is worth fixing but not now.
|
||||
- "No finding" is a valid and useful answer. Do not manufacture findings to look thorough.
|
||||
- `task check` passing is not evidence of correctness: it cannot see a field the server stopped sending, because optional chaining makes a dead dashboard binding typecheck.
|
||||
|
||||
End with exactly one line: `Merge verdict: BLOCK`, `Merge verdict: OK`, or `Merge verdict: OK with notes`.
|
||||
@@ -1,38 +0,0 @@
|
||||
---
|
||||
name: cp-writer
|
||||
description: Implementation worker for archie-core lanes. Red-green TDD in an isolated worktree, package-scoped gate, no suppression.
|
||||
tools: read, write, edit, grep, find, ls, bash
|
||||
acceptanceRole: writer
|
||||
inheritProjectContext: true
|
||||
inheritGlobalContext: false
|
||||
inheritSkills: false
|
||||
thinking: high
|
||||
timeoutMs: 5400000
|
||||
systemPromptMode: replace
|
||||
---
|
||||
|
||||
You implement one lane of work in the archie-core Go repository, inside your own git worktree.
|
||||
|
||||
Open every run by printing `pwd`, `git branch --show-current` and `git status --short`, and repeat all three in your final report. A worker that finishes in the wrong checkout looks exactly like one that did nothing.
|
||||
|
||||
Method:
|
||||
|
||||
1. Read the bead with `bd show <id>`, then `CLAUDE.md` and `docs/architecture/organisation.md`.
|
||||
2. Red: write the failing table-driven test first. Run it. Paste the failure. Confirm it fails on an assertion, not a compile error. A test that cannot fail for an interesting reason is noise in the gate.
|
||||
3. Green: the minimal implementation that satisfies the test.
|
||||
4. Run your lane's scoped test command. Never run `task check`: it saturates the machine and the merge train owns it.
|
||||
5. Commit on your lane branch with a conventional-commit subject scoped by package (`feat(controlplane): ...`).
|
||||
|
||||
Hard rules:
|
||||
|
||||
- Fix invalid state at the producer, not with a defensive check at the consumer.
|
||||
- Never suppress: no `//nolint`, no `t.Skip`, no build tag that hides a failing test, no deleted assertion. If a lint is wrong, leave it failing and say why.
|
||||
- Adopt `task fmt` output verbatim. Never revert a formatter or linter diff.
|
||||
- Two failed fixes on the same logic block means you rewrite the block, not patch it a third time. Prefer a clean 20-line rewrite over a 5-line band-aid.
|
||||
- Dependency flow is `cmd -> app -> {domain, infrastructure}`, with infrastructure implementing domain contracts. Nothing in `internal/webui` may reach `internal/domain/workflow`.
|
||||
- Do not widen scope. Work not asked for is a finding to report, not work to do.
|
||||
- Do not merge, do not push, do not touch `.beads/`, do not edit the main checkout.
|
||||
- Scratch files live in `/tmp`. Never in the working tree.
|
||||
- If the bead describes a world the tree no longer has, stop and report that instead of implementing it.
|
||||
|
||||
Your final report states: the commit sha, changed files, the scoped test command and its result, what you deliberately did not do, and any residual risk.
|
||||
@@ -1,47 +0,0 @@
|
||||
{
|
||||
"model": "REPLACE_WITH_STRONG_TIER_ID",
|
||||
"timeoutMs": 5400000,
|
||||
"lanes": [
|
||||
{
|
||||
"key": "live",
|
||||
"dir": "/work/apps/cp-live",
|
||||
"branch": "cp/live",
|
||||
"beads": [
|
||||
"archie-core-nwa0"
|
||||
],
|
||||
"test": "go test ./internal/app/controlplane/... ./internal/domain/applystatus/... -count=1 && go vet ./internal/app/controlplane/... ./internal/domain/applystatus/...",
|
||||
"brief": "Wave 0 and its claims audit corrected this bead's premise, and the correction is the work. There is not one live apply path, there are two, and the PRD clause (Archie starts and checks a replacement before switching, and if the check fails the old one keeps running) applies to both. (1) workflow-execution-settings is applied on a watch (internal/app/archied/control_plane.go:94) and reports apply status at :118. (2) personas is also watched and applied live in the same process (internal/app/archied/gateway_runtime.go:37 watch, :79-86 apply) and reports NO apply status at all, so personas is the live-watched kind that widens this bead. Correction to the earlier version of this brief: workflow-definitions is not applied by a daemon watch, but do not read that as \"no watch anywhere\" -- the webui streams it at internal/webui/api_control_plane.go:139, which is a generic SSE passthrough for any kind. That is a read path, not a component-replacement path, so it does not widen nwa0. What the audit also established: the hard-coded nil at control_plane.go:118 is inert (no path in applyWorkflowExecutionSettings can fail), so do not build the bead around \"the report path cannot carry a rejection\"; that framing is wrong. Order of work: add the build-and-probe step to the live apply path, retain the previous component when the check fails, and report the failure through the apply-status surface. Decide explicitly whether personas gets the same treatment in this bead or a follow-up bead; if it is a follow-up, file the bead rather than half-wiring it. Do NOT fix the watch-reconnect defect opportunistically: it is filed separately as archie-core-yrmr, and a defect found by a review pass must not be silently repaired inside another lane. Apply status is on the State Store contract, not the control plane: PutApplyStatus/ListApplyStatus are administrative, keyed on (process, kind), replaced in place, re-stamped every 30s, stale at 90s, and a stale record renders as \"Not reporting\", never as current. applystatus.New refuses a process name Processes() does not list, deliberately: an invented name would read as a process that is not running, which the PRD blesses as legitimate, so the failure would be invisible."
|
||||
},
|
||||
{
|
||||
"key": "recovery",
|
||||
"dir": "/work/apps/cp-recovery",
|
||||
"branch": "cp/recovery",
|
||||
"beads": [
|
||||
"archie-core-6zw0"
|
||||
],
|
||||
"test": "go test ./cmd/... ./internal/infrastructure/staterpc/... -count=1 && go vet ./cmd/...",
|
||||
"brief": "DECIDED: subcommands of cmd/archie-state-store (backup, restore, validate, rollback). Not a new binary. Sam's standing rule, restated 2026-09-21 and now recorded in docs/architecture/organisation.md#process-boundaries: a cmd/ entry is a process boundary, earned only when a surface fails independently of the rest of the fleet or when that process may need to run in more than one location (HA pair, NAT traversal, separate host). Operational commands over a surface an existing binary already owns are subcommands of it. Do not reopen this. Two premise corrections from Wave 0 that change the work. First, the file is <dir>/archie.db-tasks.sqlite (cmd/archie-state-store/main.go:290-292, asserted at main_test.go:435-439), not archie.db, so a command that operates on 'archie.db' by name operates on nothing. Second, part of this already exists in shell: scripts/archie-update-install:189 takes a sqlite3 .backup of the task database and describes it as the watchdog's only route back from a forward schema migration. That makes this bead partly consolidation. The subcommand becomes the one authoritative implementation and the install script calls it, rather than a Go path and a shell path that drift apart. Changing that script is in scope for this lane; the watchdog's refusal semantics (an update that cannot back up must not start) must survive the change unchanged. The command operates on the database file directly with the State Store stopped, refuses to run against a live store, and adds no rollback RPC: a revision carries its value and restoring replays it through the ordinary replace."
|
||||
},
|
||||
{
|
||||
"key": "steps",
|
||||
"dir": "/work/apps/cp-steps",
|
||||
"branch": "cp/steps",
|
||||
"beads": [
|
||||
"archie-core-8szi"
|
||||
],
|
||||
"test": "go test ./internal/domain/workflow/... ./internal/app/agentworker/... -count=1 && go vet ./internal/domain/workflow/...",
|
||||
"brief": "internal/domain/workflow/steps.go:215 and :227 hard-error on legacy .archie/stages/*.go and .archie/gate.go and tell the operator to migrate to a registered YAML workflow step, but BuiltinStepRegistry() only exposes the six shipped workflows' own stages, so there is nothing to migrate to. Identify what the removed hooks actually did and land the equivalent as registered step types. This lane starts only after archie-core-fwmp has merged, and registers against the extension point fwmp created. Do not re-open the registry design."
|
||||
},
|
||||
{
|
||||
"key": "config",
|
||||
"dir": "/work/apps/cp-config",
|
||||
"branch": "cp/config",
|
||||
"beads": [
|
||||
"archie-core-xrux",
|
||||
"archie-core-i3qm"
|
||||
],
|
||||
"test": "go test ./internal/infrastructure/configuration/... ./internal/app/archied/... -count=1 && go vet ./internal/infrastructure/configuration/... ./internal/app/archied/...",
|
||||
"brief": "Two beads in order, one package owner. First archie-core-xrux. The verdict is already measured with evidence (Wave 0R claims audit c6) and it is ZEROES: the -config-overlay file path silently drops every field a partial map-valued entry omits, which is exactly the archie-core-e2e2 hazard, and it is user-reachable because deployments/dev.toml is the documented -config-overlay argument and sets [services.state] target/listen, while the base config.toml is where [services.state].target_token lives -- so the overlay drops the token. The red stage is a committed characterization test through the production entry point (Loader.Resolve / -config-overlay) that loads a config with a populated map-valued entry, overlays a file setting one sibling key, and asserts the omitted keys survive; it fails today. Then move apply.go's foldOverrides (apply.go:60) onto the file overlay path (loader.go:161-194, decode at :176) so it passes. Do NOT delete apply.go, apply_test.go or Loader.ApplyOverlay: the hazard they were written for is live on that path. No dotted-path field merge is wanted beyond this guard, because the control plane replaces whole documents. Then archie-core-i3qm, whose anchor and scope the audit corrected. control_plane.go:13 is a blank line (the doc comment is :14-18); the calls moved to :20 (RuntimeConfig) and :27 (configuration.Validate) in 9accf112. More importantly the PRD clause names State Store startup, and state_store.go:75-104 never calls runtimeConfig: it reaches Loader.finalize via bootstrap.go:263 (the loader.Resolve call site, not finalize itself) and loader.go:341-346, where Validate runs. Scope correction: that file-only Validate runs before loadRuntimeConfig for ALL THREE binaries (main.go:358, gateway.go:61, state_store.go:78), so it is not state-store-specific; and a value that is valid alone but invalid only after the DB merge never blocks the state store at all, because it is imported unvalidated at state_store.go:104 and fails later in the daemon's loadRuntimeConfig (control_plane.go:27). Reduce the bootstrap document to the fields the PRD lists (database path, listen addresses, credentials, TLS, encryption-key references) and stop validating the migrated surface at startup, so a stale TOML value in a database-owned field cannot fail boot. boot.runtimeConfig is the one layering call and the SIGHUP callback makes the same call: if you add a database-owned layer, add it there and nowhere else."
|
||||
}
|
||||
]
|
||||
}
|
||||
@@ -1,72 +0,0 @@
|
||||
# Wave 1 sub-prompt: shape first
|
||||
|
||||
**One child. fwmp alone.** Nothing else runs until it merges, and Wave 2 branches
|
||||
from the merged shape.
|
||||
|
||||
xrux is no longer a Wave 1 probe. Its verdict is already measured with evidence
|
||||
(Wave 0R claims audit c6) and the answer is **ZEROES**. Re-measuring buys nothing,
|
||||
so the characterization test is folded into the `config` lane's red stage, where
|
||||
it is committed and the evidence lives in the tree rather than in a transcript.
|
||||
See the `config` brief in `lanes.json`.
|
||||
|
||||
---
|
||||
|
||||
## fwmp: the shared shape (cp-writer, worktree `/work/apps/cp-shape`, branch `cp/shape`)
|
||||
|
||||
Gate: `go test ./internal/domain/workflow/... ./internal/app/controlplane/... ./internal/app/agentworker/... -count=1`
|
||||
|
||||
```text
|
||||
Bead archie-core-fwmp. Run `bd show archie-core-fwmp` first.
|
||||
|
||||
docs/prds/runtime-control-plane.md:95 says plugins can add step types. Today every
|
||||
call site hardcodes workflow.BuiltinStepRegistry():
|
||||
internal/app/agentworker/task_execution.go:319 and :335,
|
||||
internal/app/controlplane/workflow_definitions.go:26 and :33, and
|
||||
internal/app/controlplane/client.go:41. The step vocabulary is closed to the six
|
||||
shipped workflows.
|
||||
|
||||
Verified by the Wave 0 claims audit, so treat as fact and do not re-derive:
|
||||
- Those are exactly five non-test call sites, plus five test call sites.
|
||||
- BuiltinStepRegistry() is defined at internal/domain/workflow/definition.go:149 and
|
||||
is built only from legacyBuiltinWorkflows() (definition.go:181).
|
||||
- StepRegistry is a plain `map[string]StepFactory` (definition.go:32). There is no
|
||||
merge/widen function; BuiltinStepRegistry() is itself the only registration site.
|
||||
- All five production call sites pass the identical function, so nothing diverges
|
||||
today. The gap is the absence of a guard, not a live defect.
|
||||
|
||||
Deliver: a registry assembled from the plugin set, resolved identically on both
|
||||
sides.
|
||||
|
||||
The load-bearing constraint is not the extension point, it is agreement. The
|
||||
validating side is the State Store; the executing side is archie-agent. A
|
||||
definition that validates and then fails to compile at run time is the failure
|
||||
this bead exists to prevent, and it is exactly the failure two packages that each
|
||||
pass their own tests produce. No test today ties the two sides: no test file
|
||||
imports both internal/app/controlplane and internal/app/agentworker. Your change
|
||||
is not done until one test asserts that both sides resolve the same step
|
||||
vocabulary from the same plugin set. Write that test first and let it fail for the
|
||||
right reason.
|
||||
|
||||
Do NOT edit internal/domain/workflow/definition_test.go:8
|
||||
TestParseDefinitionRejectsUnsafeDefinitions. The audit established it is not an
|
||||
obstacle: its pin is name-exact ("shell" at :11, implement.prepare's own factory at
|
||||
:12), so a settings-bearing plugin step type under any other name passes it
|
||||
unchanged. Adding a step type is archie-core-8szi's lane, not this one.
|
||||
|
||||
Do NOT fix the workflow-version pin opportunistically. The audit found it is never
|
||||
persisted over gRPC and its digest guard is dead in production; that is filed as
|
||||
archie-core-zf8h and gets its own lane and Sam's eyes. Report it if you touch it,
|
||||
do not repair it here.
|
||||
|
||||
Before adding a plugin engine surface, satisfy
|
||||
ARCHITECTURE.md#plugin-engine-rule-strict.
|
||||
|
||||
This is the shape every other lane branches from, so it lands alone and it lands
|
||||
first. Do not implement any step type; archie-core-8szi does that afterwards
|
||||
against what you build. Do not widen scope to the .archie gate behaviour.
|
||||
|
||||
Working contract: print pwd, git branch --show-current and git status --short
|
||||
before editing and repeat them in your report. Red then green. Package-scoped
|
||||
tests only, never `task check`. No //nolint, no t.Skip, no deleted assertions.
|
||||
Adopt `task fmt` verbatim. Commit on cp/shape with a conventional subject.
|
||||
```
|
||||
-62
@@ -1,62 +0,0 @@
|
||||
# Wave 4: merge train
|
||||
|
||||
Serial. You run this yourself in the captain checkout at
|
||||
`/work/apps/archie-core`. No subagent owns `main`, and only one `task check`
|
||||
exists at a time.
|
||||
|
||||
Order: `cp/shape` (already merged in Wave 1), then `cp/config`, `cp/live`,
|
||||
`cp/recovery`, `cp/steps`. Config goes early because it owns the bootstrap path
|
||||
the others boot through.
|
||||
|
||||
## Per branch
|
||||
|
||||
```bash
|
||||
BR=cp/live
|
||||
|
||||
git -C /work/apps/archie-core status --short # must be clean
|
||||
git merge-base --is-ancestor main $BR && echo "stale: rebase required"
|
||||
git log --oneline main..$BR
|
||||
git diff --stat main..$BR
|
||||
```
|
||||
|
||||
A branch that predates a merge computed its deletions against code that has
|
||||
since changed. On this repo a stale branch's diff deleted 460 lines of
|
||||
`internal/config` that read as tidy relocation and would have reverted another
|
||||
lane's decomposition. Rebase it or re-derive the work. Never merge a diff whose
|
||||
deletions were computed against code that has moved.
|
||||
|
||||
Then:
|
||||
|
||||
1. `git merge --no-ff $BR` (or apply the lane's handoff patch if the lane ran in
|
||||
a managed worktree).
|
||||
2. `task build --force`, then `task check`, once, alone. Nothing else runs on this machine while it does. The force-build is required until archie-core-hhgw lands: `task build`'s sources are Go-only (Taskfile.yml:325), so a ui/dist-only change does not retrigger it and a stale embedded dashboard would ship (Wave 0R audit c10).
|
||||
3. On failure: one fix pass back to that lane's retained writer with the real
|
||||
output pasted in, not a summary. On a second failure, `git reset --hard` the
|
||||
merge, requeue the lane, and move to the next branch. Do not stack a third
|
||||
patch, and do not fix it yourself unless the fix is one line and obvious.
|
||||
4. Commit generated assets in the same commit. `ui/dist/` and schema outputs are
|
||||
LAW: never regenerated away, never reverted, never left out.
|
||||
5. `bd close <id>` for each bead the branch delivered. Do not stage `.beads/`,
|
||||
and never create a commit whose only content is beads bookkeeping.
|
||||
|
||||
## Landing check, every time
|
||||
|
||||
```bash
|
||||
git log --oneline -3
|
||||
git branch --no-merged main
|
||||
git log --oneline origin/main..main
|
||||
```
|
||||
|
||||
Done has three states: no commits, committed and unmerged, merged. Only the
|
||||
third counts. A closed bead is what a worker believed, not what landed.
|
||||
|
||||
## Your own edits
|
||||
|
||||
A coordinator `sed` rename on this repo once produced `&fakeStore{fakeStore{` in
|
||||
six places and broke the build. Your edits get the same gate as the children's,
|
||||
and nobody else reviews them.
|
||||
|
||||
## Do not push
|
||||
|
||||
Sam pushes manually and does not always announce it. Report what is unpushed as
|
||||
fact. If `git log origin/main..main` is long, say how long; do not act on it.
|
||||
@@ -1,53 +0,0 @@
|
||||
# Wave 5: eju6, the end-to-end restart test
|
||||
|
||||
One lane, one `cp-writer`, against merged `main`. This is the only bead that
|
||||
proves the feature rather than adding to it, so it runs last and alone.
|
||||
|
||||
Gate: `cd <worktree> && go test ./internal/app/controlplane/... -count=1`,
|
||||
then `task check` through the merge train as usual.
|
||||
|
||||
```text
|
||||
Bead archie-core-eju6. Run `bd show archie-core-eju6` first.
|
||||
|
||||
docs/prds/runtime-control-plane.md ("First implementation") lists an end-to-end
|
||||
restart test as a deliverable and there is none.
|
||||
internal/app/controlplane/controlplane_test.go covers seeding and catalog only.
|
||||
No test drives a change through the API, restarts a process, and asserts the
|
||||
change survived.
|
||||
|
||||
Deliver that test: a real end-to-end check, not a unit test, and not a rewrite
|
||||
of the existing file.
|
||||
|
||||
It must, in one test:
|
||||
1. write a settings change through the control-plane API, as the dashboard
|
||||
would, attributing to identity.SystemID;
|
||||
2. observe the change land in the audit trail as an ordinary edit;
|
||||
3. restart the process that consumes it;
|
||||
4. assert the process came back on the stored value, not the file value;
|
||||
5. assert the apply-status row for that process reports the version it
|
||||
applied, and that a record older than 90 seconds reads as "not reporting"
|
||||
rather than as current.
|
||||
|
||||
Facts you need and must not re-derive:
|
||||
- boot.runtimeConfig is the single layering call, and the SIGHUP reload makes
|
||||
the same call over the document it just resolved (9af013eb). A reload cannot
|
||||
revert a database-owned setting to its file value, and that is the property
|
||||
under test.
|
||||
- Execution budgets arrive on a watch, not a resource query, so boot records
|
||||
the last settings it applied and the reload re-applies them from there.
|
||||
- PutApplyStatus/ListApplyStatus are administrative on the State Store
|
||||
contract: a task-scoped grant is denied both by the deny-by-default arm of
|
||||
authorizesTaskScopedCall. Your harness needs the administrative token.
|
||||
- Rows are keyed on (process, kind) and replaced in place; every process
|
||||
re-stamps every 30 seconds.
|
||||
- The control plane fails closed: a stored value that will not validate stops
|
||||
archied starting.
|
||||
|
||||
If the test fails, that is a finding about the feature, not about the test.
|
||||
Report the failure with the output and stop. Do not weaken an assertion, do not
|
||||
add a retry loop to paper over a race, and do not mark it t.Skip.
|
||||
|
||||
If a real end-to-end restart cannot be driven in-process, say so explicitly and
|
||||
describe what harness it would need, rather than substituting a unit test that
|
||||
asserts less and claims the bead.
|
||||
```
|
||||
@@ -1,246 +0,0 @@
|
||||
---
|
||||
name: archie-architecture-contract
|
||||
description: >-
|
||||
Protect Archie's load-bearing architecture while placing, implementing, or
|
||||
reviewing behavior. Load this skill before changing daemon composition,
|
||||
domains, workflows, task lifecycle, agent execution, messaging, work intake,
|
||||
identity, memory, configuration, plugins, policies, persistence, NATS/RPC,
|
||||
containers, or process boundaries; use it when deciding where new code
|
||||
belongs, enforcing dependency direction, separating current runtime truth
|
||||
from the approved target and open migration decisions, or ensuring every
|
||||
behavior has one authoritative path. Route proof of duplication, dead-code
|
||||
disposition, production reachability, and maintainability to
|
||||
archie-technical-accountability.
|
||||
---
|
||||
|
||||
# Archie Architecture Contract
|
||||
|
||||
Treat architecture as executable safety policy. Preserve one understandable
|
||||
owner and one production path for each behavior.
|
||||
|
||||
## Read status before code
|
||||
|
||||
| Label | Meaning | Authority |
|
||||
| --- | --- | --- |
|
||||
| **CURRENT** | Behavior present in live code and production composition as of 2026-09-18. | Code, tests, and `internal/app/archied` wiring (`cmd/archied/main.go` is a thin dispatcher) |
|
||||
| **APPROVED TARGET** | Direction an implementation must approach, but which may not exist on disk. | `docs/prds/01-project-management.md` and documents whose status says approved |
|
||||
| **OPEN** | A migration or API decision no implementer may invent locally. | `docs/architecture/migration-decisions.md` and documents marked in progress or under design |
|
||||
|
||||
> **Do not implement target prose as though it describes current code.**
|
||||
> Before treating a target package as available, prove that it exists and is
|
||||
> used from a production entry point. As of 2026-09-18 `internal/domain/`,
|
||||
> `internal/eventbus/`, `internal/infrastructure/`, and `internal/app/` exist;
|
||||
> `internal/policy/` does not, and `internal/domain/{agent,identity}` remain
|
||||
> APPROVED TARGET only.
|
||||
|
||||
Resolve apparent disagreement in this order:
|
||||
|
||||
1. Read live code and production composition for CURRENT behavior.
|
||||
2. Read `docs/prds/01-project-management.md` for APPROVED TARGET ownership.
|
||||
3. Read the focused decision document for the selected behavior.
|
||||
4. Read `docs/architecture/migration-decisions.md` for OPEN work.
|
||||
5. Stop and use `archie-architecture-planning-campaign` if a required semantic
|
||||
decision remains open.
|
||||
|
||||
Route to `archie-domain-reference` for glossary and
|
||||
`archie-config-and-flags` for config enumeration.
|
||||
|
||||
Two skills this document routes to are parked outside this checkout, under
|
||||
`/work/apps/archie-skills-parked/`: `archie-technical-accountability` and
|
||||
`archie-architecture-planning-campaign`. If your session has not loaded them,
|
||||
treat each routing target as a manual escalation step rather than a live skill.
|
||||
Also: `cmd/archied/main.go` is a thin dispatcher; the wiring lives in
|
||||
`internal/app/archied/`.
|
||||
|
||||
## Know the CURRENT system
|
||||
|
||||
Do not simplify these facts into the target model:
|
||||
|
||||
| Concern | CURRENT runtime truth on 2026-09-18 | Evidence |
|
||||
| --- | --- | --- |
|
||||
| Composition | `cmd/archied/main.go` dispatches to `internal/app/archied.Run()`, which performs construction and wiring in `bootstrap.go`. | `cmd/archied/main.go`; `internal/app/archied/` |
|
||||
| Durable work | `task.Task` combines forge/chat source data, workflow position, output, retry, identity, and PR state. | `internal/domain/workflow/task/task.go`; `internal/domain/storecontract/storecontract.go` |
|
||||
| Workflow | `internal/domain/workflow` routes a `task.Task` into a `map[string]Workflow`, mutates a broad `TaskContext` through sequential stages. | `internal/domain/workflow/workflow.go` |
|
||||
| Agent-stage boundary | Versioned `agentexec.Request`/`Result` carries one autonomous stage; validation correlates task, attempt, and stage. | `internal/agentexec/protocol.go` |
|
||||
| Container handoff | `internal/taskrun` carries entire task plus `config.Repo` and `config.TaskConfig`; `internal/app/agentworker` owns routing and sequencing while its NATS adapter owns wire mechanics. | `internal/taskrun/taskrun.go`; `internal/app/agentworker/`; `internal/infrastructure/agenttransport/nats/` |
|
||||
| Git ownership | Daemon-owned worktree operations clone, commit, push, diff, and clean up. | `internal/worktree/`; `internal/domain/workflow/steps.go`; `ARCHITECTURE.md` |
|
||||
| Enforcement | Gates, read-only/protected paths, TDD inverted test gates, and diff caps are represented outside prompt prose. | `internal/gate/`; `internal/domain/workflow/{agent,tdd,steps}.go` |
|
||||
| Configuration | `internal/config.Config`, `IdentityConfig`, `Repo`, and task snapshots mix input decoding with runtime concerns. Decoding itself lives in `internal/infrastructure/configuration`. | `internal/config/config.go`; `internal/infrastructure/configuration/` |
|
||||
| Identity | Configured names and bot usernames act as process-local identity keys. There is no durable Identity domain. | `internal/daemon/daemon.go`; `internal/domain/storecontract/storecontract.go`; `internal/gateway/session.go` |
|
||||
| Messaging | `internal/gateway` contains both the `Message` struct flow and richer `MessageEvent`; channel routing and task control are mixed with conversational behavior. | `internal/gateway/{gateway,messageevent,tasks}.go`; `internal/channels/` |
|
||||
| Plugins | `plugin.Plugin` exposes only `Name` and `Version`; current loading interprets operator-installed Go files with Yaegi. | `internal/plugin/plugin.go` |
|
||||
| Processes | Agent modes include in-process, subprocess, and NATS. Optional containers add a distinct boundary with known gaps. | `internal/config/config.go`; `internal/app/archied/`; `ARCHITECTURE.md` |
|
||||
|
||||
### Interpret the current lifecycle honestly
|
||||
|
||||
Use these CURRENT status values:
|
||||
|
||||
```text
|
||||
queued, running, waiting_human, pr_open, merged,
|
||||
parked, dead, rejected, closed_wont_do
|
||||
```
|
||||
|
||||
The intended flow includes queue/claim, workflow stages, human wait/resume, PR
|
||||
reconciliation, parking/retry/exhaustion, and crash recovery. Read
|
||||
`internal/domain/workflow/task/task.go`, `internal/daemon/daemon.go`, and
|
||||
`internal/domain/workflow/workflow.go` before changing a transition.
|
||||
|
||||
`Store.Transition(ctx, taskID, from, to, detail)` now guards on `from`
|
||||
(`WHERE id=? AND status=?`, returning `store.ErrStaleTransition` on mismatch)
|
||||
and runs the status update plus the transition-history insert in one
|
||||
transaction (`internal/store/store.go`). The sentinel crosses the State Store
|
||||
gRPC boundary via `mapError`/`unmapError` in
|
||||
`internal/infrastructure/staterpc/values.go`; its canonical message string is
|
||||
part of the wire contract. Earlier non-atomic behavior is the settled fix,
|
||||
not an open design.
|
||||
|
||||
## Preserve the load-bearing invariants
|
||||
|
||||
| Invariant | Required action | Status and source |
|
||||
| --- | --- | --- |
|
||||
| The model never runs git | Keep clone, branch, commit, push, diff, and cleanup in deterministic workspace/worktree steps. | CURRENT: `ARCHITECTURE.md`; `internal/worktree/` |
|
||||
| Deterministic constraints outrank prompts | Enforce gates, protected paths, read-only stages, test protection, and change caps outside model instructions. | CURRENT: `ARCHITECTURE.md`; `internal/gate/`; `internal/domain/workflow/` |
|
||||
| Agent execution is a data boundary | Send bounded, versioned input; validate correlated output before applying it. | CURRENT foundation: `internal/agentexec/protocol.go`; `ARCHITECTURE.md` |
|
||||
| Every workflow ends explicitly | Preserve terminal outcome or visible park. Preserve crash recovery of interrupted `running` work. | CURRENT: `internal/domain/workflow/workflow.go`; `internal/store/store.go` |
|
||||
| Generic plugins stay metadata-only | Keep `plugin.Plugin` at `Name()`/`Version()`. Behavior on typed capability interface with owning `Registry`/`Manager`. | CURRENT-enforced rule: `internal/plugin/architecture_test.go` |
|
||||
| Capability engines own lifecycle | Give resource-owning engines explicit start/health/stop semantics and failure isolation. | APPROVED rule: `ARCHITECTURE.md#plugin-engine-rule-strict` |
|
||||
| Trust is explicit | Treat trusted operator-installed in-process code, repository code, out-of-process integrations, and container-isolated code as different trust classes. | APPROVED rule: `ARCHITECTURE.md#plugin-engine-rule-strict` |
|
||||
| Infrastructure stays replaceable | Keep forge, persistence, workspace, transport, container, and model details behind behavior-owned contracts. | APPROVED TARGET: `docs/architecture/dependencies-and-contracts.md` |
|
||||
| Same-repository execution serializes by default | Preserve default unless explicit scheduling policy permits concurrency. | CURRENT: `internal/config/config.go`; `internal/daemon/daemon.go` |
|
||||
|
||||
Run the mechanical plugin guard after changing any plugin or `*Engine`
|
||||
interface:
|
||||
|
||||
```bash
|
||||
go test ./internal/plugin -count=1
|
||||
```
|
||||
|
||||
## Apply the APPROVED TARGET
|
||||
|
||||
Apply ownership rules to migration plans and new seams. Not CURRENT until
|
||||
production wiring proves the cutover.
|
||||
|
||||
### Keep dependency direction inward
|
||||
|
||||
```text
|
||||
domain and shared application contracts <- infrastructure implementations
|
||||
^
|
||||
|
|
||||
application composition
|
||||
```
|
||||
|
||||
1. Put cohesive behavior, vocabulary, state, commands, events, policies,
|
||||
runtime settings, and required service interfaces with its owning domain.
|
||||
2. Make infrastructure implement domain-required interfaces and translate
|
||||
external representations.
|
||||
3. Let only `internal/app` choose concrete implementations and connect domains.
|
||||
4. Keep `cmd/*` limited to process input and invoking composition.
|
||||
5. Use an owned command, event, or approved shared contract across domains.
|
||||
6. Never let one domain mutate another domain's state or call its internals.
|
||||
|
||||
Sources: `docs/architecture/organisation.md`,
|
||||
`docs/architecture/dependencies-and-contracts.md`.
|
||||
|
||||
### Separate interaction, admission, assistance, and execution
|
||||
|
||||
```text
|
||||
channel-neutral Message -> Agent turn -> optional proposed work
|
||||
-> Work Intake -> AcceptedWorkRequest -> Workflow selects version -> WorkflowExecution
|
||||
```
|
||||
|
||||
- **Messaging** owns canonical messages, conversations, branches, channel correlation, delivery.
|
||||
- **Agent** owns persistent assistant, continuity, specialization, memory.
|
||||
- **Work Intake** owns admission, validation, routing, accepted-work-request handoff.
|
||||
- **Workflow** owns versioned definitions, steps, executions, attempts, outcomes.
|
||||
|
||||
Do not equate external issue/message with WorkflowExecution; do not let Work
|
||||
Intake create one directly.
|
||||
|
||||
Sources: `docs/architecture/migration-decisions.md`,
|
||||
`docs/architecture/agent-system.md`, `docs/architecture/messaging-and-work-intake.md`.
|
||||
|
||||
### Separate identity, Agent, conversation, and memory
|
||||
|
||||
Use immutable `IdentityID` for target attribution. Keep Identity separate from
|
||||
Agent. Four fixed memory scopes:
|
||||
|
||||
| Scope | Visibility |
|
||||
| --- | --- |
|
||||
| Global shared | Shared across Archie |
|
||||
| Agent-wide | One Agent across users; private by default |
|
||||
| User-wide | One user across authorized Agents |
|
||||
| Agent-user relationship | Exactly one Agent and one user |
|
||||
|
||||
Do not use conversation branching as a fifth memory scope.
|
||||
|
||||
Sources: `docs/architecture/identity.md`, `docs/architecture/agent-system.md`,
|
||||
`docs/architecture/migration-decisions.md`.
|
||||
|
||||
### Dissolve global runtime configuration
|
||||
|
||||
Treat `internal/config` as migration source inventory:
|
||||
|
||||
- move file/env/overlay/secret decoding to `internal/infrastructure/configuration`;
|
||||
- let each domain or plugin own typed runtime settings;
|
||||
- translate external DTOs in `internal/app`;
|
||||
- never pass complete application config into a domain;
|
||||
- classify each behavioral value as invariant, runtime setting, policy value,
|
||||
derived value, or runtime state.
|
||||
|
||||
Source: `docs/architecture/configuration.md`.
|
||||
|
||||
## Place new behavior deliberately
|
||||
|
||||
| Behavior | Target owner/location | Decision gate |
|
||||
| --- | --- | --- |
|
||||
| Persistent actor lifecycle and attribution | `internal/domain/identity` | Do not mix authentication/access policy into Identity. |
|
||||
| Persistent assistant behavior and continuity | `internal/domain/agent` | Keep model/provider replaceable; do not fold Workflow into Agent. |
|
||||
| Workflow definitions, steps, executions, attempts, outcomes | `internal/domain/workflow` | Preserve version ownership and one authoritative lifecycle. |
|
||||
| Canonical messages, conversations, branches, delivery | `internal/domain/messaging` | Keep platform IDs as external correlation. |
|
||||
| Admission and deterministic routing of proposed durable work | `internal/domain/workintake` | Emit an accepted request; do not construct execution state. |
|
||||
| Generic plugin identity/discovery/compatibility/lifecycle | `internal/domain/plugin` | Keep generic contract metadata-only. |
|
||||
| Capability-specific plugin behavior | Owning domain's typed registry/manager | Never add behavior to `plugin.Plugin`. |
|
||||
| Broker-neutral publication/subscription mechanics | `internal/eventbus` | Keep message meaning and schemas with their domain. |
|
||||
| Shared policy evaluation/evidence mechanics | No current package. `internal/policy` was the planned location; as of 2026-09-18 policy lives inside playbook bindings (`playbooks/`, `internal/domain/eda/playbook`) and `internal/gate/`. | Keep policy vocabulary, evaluators, and consequences with consuming domain. |
|
||||
| NATS, SQLite, forge, config decoding, external SDK adapters | `internal/infrastructure/<capability>` | Implement a narrow owner-defined contract; translate at boundary. |
|
||||
| Construction, cross-domain connection, startup/shutdown | `internal/app/archied` or `internal/app/agentworker` | Keep `cmd/*` thin; define health and shutdown order. |
|
||||
| Deploy assembly | `deployments/<assembly>` | Do not move application behavior into deployment files. |
|
||||
| Unreviewed memory/tools/workspace/gate/storage/web/RPC/scheduling | **OPEN** | Run `archie-architecture-planning-campaign`. |
|
||||
|
||||
## Confront known weak points
|
||||
|
||||
| Weak point on 2026-09-18 | Required response |
|
||||
| --- | --- |
|
||||
| `TaskContext` is a mutable service bag with config, services, policy, scratch state. | Design narrow step inputs and staged removal. |
|
||||
| Workflow lifecycle split across store, daemon, workflow, gateway, worker. | Trace every writer and reader before changing status. |
|
||||
| State changes and transition history were non-atomic and `from` was advisory — **settled** in `internal/store`: `Transition` guards on `status=?` and writes status plus history in one transaction. | Keep every status writer behind `Transition`; do not reintroduce a raw `UPDATE tasks SET status`. |
|
||||
| In-process and container paths put orchestration on different sides of process boundary. | Decide which path survives before extending both. |
|
||||
| Identity uses strings; task uniqueness/NATS dedup omit identity. | Don't promise multi-identity ownership until canonical IDs migrate. |
|
||||
| Container RPC uses root forge/worktree, not task owner's identity. | Known trust/correctness defect — not identity-isolated. |
|
||||
| Missing `task.json` makes `archie-agent` join shared queue. | Fail closed before treating as isolated. |
|
||||
| Subprocess uses daemon user and host access. | Not a security boundary. |
|
||||
| Gateway formerly duplicated lifecycle strings, competing message contracts. | No third contract or direct lifecycle mutation path; status constants live in `internal/domain/workflow`. |
|
||||
| Global config and `IdentityConfig` combine unrelated owners. | Don't rename global structure or add `Extra` map. |
|
||||
| Memory has fixed scope requirements but OPEN final placement/migration. | Preserve scope isolation; focused design before moving. |
|
||||
| Tests can make unused/duplicate code appear legitimate. | Prove production reachability from composition. |
|
||||
|
||||
## Control every architecture-affecting change
|
||||
|
||||
| Class | Action |
|
||||
| --- | --- |
|
||||
| Current-path repair | Stay inside current owner, preserve invariants. |
|
||||
| Migration slice | Record current/target owner, contracts, compatibility adapter, cutover, deletion criteria. |
|
||||
| New/changed architecture | Stop; run `archie-architecture-planning-campaign` until approved. |
|
||||
|
||||
Trace with evidence:
|
||||
|
||||
```bash
|
||||
rg -n '<constructor>|<interface>|<method>' cmd internal
|
||||
go list -deps ./cmd/archied | rg 'github.com/samcharles93/archie-core/internal/'
|
||||
gopls references path/to/file.go:<line>:<column>
|
||||
```
|
||||
|
||||
Use `gopls references` or another AST-aware reference query when interfaces,
|
||||
embedding, generated symbols, or same-named methods make text search ambiguous.
|
||||
Trace from `cmd/archied/main.go` into `internal/app/archied.Run()`; the wiring
|
||||
itself is in `internal/app/archied/bootstrap.go`.
|
||||
@@ -1,4 +0,0 @@
|
||||
interface:
|
||||
display_name: "Archie Architecture Contract"
|
||||
short_description: "Protect Archie load-bearing architecture decisions"
|
||||
default_prompt: "Use $archie-architecture-contract to place and review this change without violating current or target architecture."
|
||||
@@ -1,251 +0,0 @@
|
||||
---
|
||||
name: archie-build-and-env
|
||||
description: Recreate, inspect, and troubleshoot Archie Core's development, build, test, documentation, and container toolchains. Use when onboarding a checkout; diagnosing Go, Task, golangci-lint, gofumpt, Docker/Compose, NATS, GPG, cache, temporary-directory, listener, or network failures; comparing local work with repository automation; or proving which build surfaces a command actually covers. Load this before running task check in an unfamiliar or restricted environment because that gate rewrites files and omits several independent surfaces.
|
||||
---
|
||||
|
||||
# Build and verify the Archie environment
|
||||
|
||||
Recreate the environment as independently verified surfaces. Do not turn a
|
||||
passing root-module command into a claim that the tools module, documentation
|
||||
site, race detector, linter, or container images also passed.
|
||||
|
||||
All volatile observations are snapshots from **2026-09-18** (HEAD `2e1e1549`).
|
||||
|
||||
## Name the surfaces
|
||||
|
||||
| Term | Meaning here |
|
||||
|---|---|
|
||||
| Repository root | Directory containing `go.mod`, `Taskfile.yml`, and `CLAUDE.md`. |
|
||||
| Runtime module | Root Go module `github.com/samcharles93/archie-core`. |
|
||||
| Tools module | Independent nested Go module under `tools/`. |
|
||||
| Docs | Markdown under `docs/`, read directly; no build, no renderer. |
|
||||
| Cold cache | Dependency cache not yet containing required modules/packages. |
|
||||
| Restricted sandbox | May allow file reads but deny loopback listeners, container engine, or writes to default caches. |
|
||||
|
||||
No root `README*` or `CONTRIBUTING*` file exists. Begin with:
|
||||
|
||||
```bash
|
||||
sed -n '1,240p' CLAUDE.md
|
||||
sed -n '1,240p' ARCHITECTURE.md
|
||||
task --list
|
||||
```
|
||||
|
||||
## Inventory requirements before installing anything
|
||||
|
||||
```bash
|
||||
go version
|
||||
go env GOTOOLCHAIN GOVERSION GOOS GOARCH CGO_ENABLED GOTMPDIR GOCACHE GOMODCACHE
|
||||
task --version; golangci-lint version; gofumpt -version
|
||||
node --version; npm --version # UI only; docs need no Node toolchain
|
||||
docker --version; docker compose version
|
||||
git --version; gpg --version
|
||||
```
|
||||
|
||||
Classify a missing command as an environment prerequisite. Bootstrap (verified
|
||||
2026-09-19): Go ≥ 1.27.0, Task ≥ 3.x, gofumpt v0.11.0, golangci-lint 2.13.2,
|
||||
Node 24.x for the `ui/` frontend.
|
||||
|
||||
`task fmt` runs `go fix` and then `golangci-lint fmt`; `task lint` uses the
|
||||
same binary and `.golangci.yml`, so its gofumpt, goimports, and gci rules have
|
||||
one owner and the writer converges the checker. Standalone `gofumpt` remains
|
||||
only for generated protobuf contracts in `tools/proto.sh`.
|
||||
|
||||
The three Yaegi secret-engine examples carry `//go:build ignore`. goimports
|
||||
cannot type-check them and deletes a genuinely used `internal/secret` import,
|
||||
so `.golangci.yml` excludes those exact files from the formatter set. Their
|
||||
runtime loading remains covered by `internal/secret/engines_test.go`.
|
||||
|
||||
| Surface | Repository declaration | Installed snapshot | Interpretation |
|
||||
|---|---|---|---|
|
||||
| Runtime Go | `go 1.27.0` in `go.mod` | Go 1.27.0, linux/amd64 | Requires at least declared Go level. |
|
||||
| Tools Go | `go 1.27.0` in `tools/go.mod` | Same Go 1.27.0 binary | Toolchain must satisfy both modules. |
|
||||
| Task | Taskfile schema `version: "3"` | Task 3.48.0 | Installed version is environment fact. |
|
||||
| gofumpt | Generated protobuf formatting; pinned in `Dockerfile` | v0.11.0 | Not the ordinary source formatter. |
|
||||
| golangci-lint | v2 config in `.golangci.yml`; pinned in `Dockerfile` | 2.13.2 | Owns ordinary formatting and lint checks. |
|
||||
| Node | `ui/` frontend build | 26.9.0 / npm 11.19.1 | No `engines`/`packageManager` field. Docs need no Node. |
|
||||
| Containers | Compose commands in `Taskfile.yml` | Podman-backed, unusable in this sandbox | Verify CLI, Compose plugin, daemon/socket separately. |
|
||||
|
||||
## Prepare writable caches in a restricted sandbox
|
||||
|
||||
```bash
|
||||
go env GOTMPDIR GOCACHE GOMODCACHE GOPATH
|
||||
df -T /tmp
|
||||
```
|
||||
|
||||
If any default is read-only:
|
||||
|
||||
```bash
|
||||
export ARCHIE_GOTMPDIR=/tmp/archie-core-gotmp
|
||||
export ARCHIE_GOCACHE=/tmp/archie-core-gocache
|
||||
export ARCHIE_GOMODCACHE=/tmp/archie-core-gomodcache
|
||||
export ARCHIE_GOPATH=/tmp/archie-core-gopath
|
||||
export ARCHIE_LINT_CACHE=/tmp/archie-core-golangci
|
||||
mkdir -p "$ARCHIE_GOTMPDIR" "$ARCHIE_GOCACHE" "$ARCHIE_GOMODCACHE" \
|
||||
"$ARCHIE_GOPATH" "$ARCHIE_LINT_CACHE"
|
||||
```
|
||||
|
||||
Prefix Go commands:
|
||||
|
||||
```bash
|
||||
env GOTMPDIR="$ARCHIE_GOTMPDIR" GOCACHE="$ARCHIE_GOCACHE" \
|
||||
GOMODCACHE="$ARCHIE_GOMODCACHE" GOPATH="$ARCHIE_GOPATH" \
|
||||
go test ./internal/config/... -count=1
|
||||
```
|
||||
|
||||
Populate cold cache only with network authorized:
|
||||
|
||||
```bash
|
||||
env ... go mod download; env ... go -C tools mod download
|
||||
```
|
||||
|
||||
## Recreate the root Go surface
|
||||
|
||||
```bash
|
||||
test -f go.mod && test -f cmd/archied/main.go && test -f cmd/archie-agent/main.go
|
||||
go list -m
|
||||
go build -o /tmp/archie-core-archied ./cmd/archied
|
||||
go build -o /tmp/archie-core-agent ./cmd/archie-agent
|
||||
go test ./internal/config/... -count=1
|
||||
go vet ./...
|
||||
golangci-lint run ./...
|
||||
```
|
||||
|
||||
## Understand exactly what Task runs
|
||||
|
||||
| Task | Exact effect |
|
||||
|---|---|
|
||||
| `task fmt` | `go fix ./...`, then `golangci-lint fmt` — both may rewrite source. |
|
||||
| `task vet` | `go vet ./...` in the runtime module. |
|
||||
| `task lint` | `golangci-lint run ./...`. |
|
||||
| `task build` | Builds both commands into `bin/`. |
|
||||
| `task test` | `go test ./... -count=1` in the runtime module. |
|
||||
| `task check` | `fmt` + `proto:lint` + `proto:check` + `docs:check` + `vet` + `lint` + `build` + `test` + `test:tools` + `test:ui`. |
|
||||
| `task clean` | Recursively removes `bin/`; destructive. |
|
||||
| `task docker-build` | `docker compose build agent` only. |
|
||||
|
||||
`task check` is the definitive gate but omits race tests, `task vuln`, and
|
||||
`task docker-build`. Its docs step, `docs:check`, verifies committed generated
|
||||
data and never renders anything: there is still no documentation build.
|
||||
|
||||
Two of its steps check committed artifacts rather than the build, so both fail
|
||||
on work that is correct but unstaged, and both read as a broken generator:
|
||||
|
||||
- `proto:check` regenerates, then runs `git diff --exit-code -- internal/contracts`
|
||||
and rejects untracked files there. After any `.proto` edit,
|
||||
`git add internal/contracts proto` before the gate. The failure prints the
|
||||
regenerated diff, which looks like generation produced something unexpected.
|
||||
- `ui:check` compares `ui/dist` against a fresh build of `ui/src` and fails when
|
||||
they differ. `task check` never rebuilds the bundle: run `task ui` after any
|
||||
`ui/src` change and commit the result with that change.
|
||||
|
||||
Run only in an authorized writable worktree. For a read-only ordinary-source
|
||||
preview, use `golangci-lint fmt --diff`.
|
||||
|
||||
## Verify the tools module separately
|
||||
|
||||
No `go.work`. Root `go test ./...` does not enter `tools/`.
|
||||
|
||||
```text
|
||||
module github.com/samcharles93/archie-core/tools
|
||||
replace github.com/samcharles93/archie-core => ../
|
||||
```
|
||||
|
||||
```bash
|
||||
go -C tools test -mod=readonly ./... -count=1
|
||||
```
|
||||
|
||||
`-mod=readonly` is mandatory on every `go -C tools` command. The `replace`
|
||||
forces the tools build list to satisfy the root module's requirements, so a
|
||||
root dependency bump leaves tools stale, and a writable command repairs
|
||||
`tools/go.mod` and `tools/go.sum` in place, dirtying the tree with an
|
||||
unrelated diff. Pass the flag explicitly: a global `GOFLAGS=-mod=mod` in
|
||||
`go env` beats the toolchain default. A failure here means run
|
||||
`go -C tools mod tidy` and commit that on its own. `task check` runs this via
|
||||
`task test:tools`.
|
||||
|
||||
Generate documentation to temp file:
|
||||
|
||||
```bash
|
||||
go -C tools run -mod=readonly ./docsgen --repo-root .. --out /tmp/archie-core-contracts.json
|
||||
cmp --silent docs/data/generated/contracts.json /tmp/archie-core-contracts.json
|
||||
```
|
||||
|
||||
2026-09-18 run wrote 11 schemas. The committed output was stale since
|
||||
`4b340d2b` and was regenerated the same day; `cmp` now passes. `task docs:check`
|
||||
now runs inside `task check`, so this drift fails the gate instead of waiting to
|
||||
be found by hand. `docsgen all` does not exist yet.
|
||||
|
||||
Prefer the task over the raw commands:
|
||||
|
||||
```bash
|
||||
task docs:check # non-destructive; fails loudly and names the Go type
|
||||
task docs:generate # rewrites the committed artifact; review the diff
|
||||
```
|
||||
|
||||
## Documentation needs no build
|
||||
|
||||
`docs/` is Markdown read directly in the repository, an editor, or the forge's
|
||||
file view. Nothing builds, renders, or publishes it.
|
||||
|
||||
The VitePress site (`docs/.vitepress/`, `docs/package.json`, the pnpm lockfile),
|
||||
its landing page, and `.github/workflows/docs.yml` were removed on 2026-09-12 as
|
||||
an unnecessary build step. Git no longer tracks any `docs/node_modules` entries.
|
||||
|
||||
Do not `pnpm install` under `docs/`; it has no package manifest. See
|
||||
`docs/architecture/generated-documentation.md`, "Rendering and publishing".
|
||||
|
||||
Commit `4cb0577` cleaned up accidentally committed `.gotmp`; `.gotmp/` now ignored.
|
||||
|
||||
## Treat container setup as a networked, privileged surface
|
||||
|
||||
```bash
|
||||
test -e .dockerignore || echo ".dockerignore is absent"
|
||||
rg -n '^(FROM|[[:space:]]*image:)|@latest|:latest|setup_24.x' \
|
||||
Dockerfile Dockerfile.archied docker-compose.yml
|
||||
```
|
||||
|
||||
`.dockerignore` exists (421 bytes) and excludes `.git`, `.task`, `.claude`,
|
||||
`.codex`, `.crew`, `.agents`, `.references`, `bin/`, `dist/`, `docs/`,
|
||||
`node_modules/`, root-built `archied`/`archie-agent`, and local config. Both
|
||||
Dockerfiles still run `COPY . .` on top of it. Floating inputs: Go builder tags
|
||||
omit patch/digest; Ubuntu base images omit digests; agent installs multiple
|
||||
`@latest` Go tools; Node from moving `setup_24.x` channel.
|
||||
|
||||
`task docker-build` needs registry/network and functioning Compose.
|
||||
`task docker-up` starts the Compose-managed NATS service and binds ports
|
||||
4222/8222. The host daemon and its Docker-socket access are outside Compose.
|
||||
|
||||
## Separate environment failures from code failures
|
||||
|
||||
| Signature | Classify and branch |
|
||||
|---|---|
|
||||
| `go: creating work dir: mkdir /work/tmp/...: read-only file system` | Set task-specific `GOTMPDIR`. |
|
||||
| `open .../.cache/go-build/...: read-only file system` | Set writable `GOCACHE`. |
|
||||
| `open .../pkg/mod/cache/...tmp: read-only file system` | Set writable `GOMODCACHE` and `GOPATH`. |
|
||||
| `listen ...: socket: operation not permitted` | Re-run on host with loopback sockets. |
|
||||
| `Unable to start NATS Server in Go Routine` after ~10s | Test whether local listeners permitted. |
|
||||
| `cannot auto-sign commit` | Ambient `commit.gpgSign=true`; fixtures set `gpgsign=false`. |
|
||||
| `EAI_AGAIN` for `registry.npmjs.org` | Dependency retrieval failed. |
|
||||
| `Podman configuration ... read-only file system` | Container backend cannot initialize. |
|
||||
| `TestRunWrapsExternalCommand ... Run() = "\n"` | Focused code failure in `internal/skillscript`. |
|
||||
|
||||
For hermetic test diagnosis:
|
||||
|
||||
```bash
|
||||
env GIT_CONFIG_GLOBAL=/dev/null go test ./internal/worktree/... ./internal/worktreerpc/... -count=1
|
||||
```
|
||||
|
||||
## Use the complete validation matrix
|
||||
|
||||
| Evidence | Command | Current snapshot |
|
||||
|---|---|---|
|
||||
| Focused Go behavior | `go test ./pkg/... -run '^TestName$' -count=1 -v` | Use first. |
|
||||
| Root unit/integration suite | `go test ./... -count=1` | Restricted sandbox fails listener-dependent packages. |
|
||||
| Root race suite | `go test -race ./... -count=1` | Not run by `task check`. |
|
||||
| Vet | `go vet ./...` | Passed on 2026-09-18. |
|
||||
| Lint | `golangci-lint run ./...` | Not re-run on 2026-09-18; a focused `--enable-only=dupl ./internal/...` run reported 0 issues. Re-run before quoting a total. |
|
||||
| Build | `go build -o /tmp/... ./cmd/archied` and `cmd/archie-agent` | Both passed on 2026-09-18. |
|
||||
| Tools tests | `go -C tools test -mod=readonly ./... -count=1` | Passed on 2026-09-18. |
|
||||
| Generated contract parity | Temp docsgen output + `cmp --silent` | Passed for 11 schemas on 2026-09-18, after regenerating a file stale since `4b340d2b`. |
|
||||
| Container build | `task docker-build` | Not verified in restricted environment. |
|
||||
| Repository gate | `task check` | See `archie-diagnostics-and-tooling` for the dated snapshot. |
|
||||
@@ -1,4 +0,0 @@
|
||||
interface:
|
||||
display_name: "Archie Build and Environment"
|
||||
short_description: "Recreate and verify the Archie toolchain"
|
||||
default_prompt: "Use $archie-build-and-env to recreate a clean Archie development environment and verify every build surface."
|
||||
@@ -1,230 +0,0 @@
|
||||
---
|
||||
name: archie-codebase-discovery
|
||||
description: "Trace Archie behavior and blast radius through Go source, types, state, persistence, transports, consumers, tests, configuration, production composition, and target architecture. Load before changing or planning a non-trivial feature, refactor, config field, interface, persistence path, workflow, channel, plugin, or agent execution path; also load to investigate duplicate behavior, hidden dead code, constructor bypasses, package dependencies, decoded-but-unwired configuration, or uncertainty about what a symbol actually affects."
|
||||
---
|
||||
|
||||
# Discover the Archie codebase
|
||||
|
||||
Use evidence from the current checkout to explain a behavior before changing it.
|
||||
Volatile tool facts below were verified on **2026-09-18**.
|
||||
|
||||
**Composition roots**: `cmd/archied/main.go` (thin dispatcher) →
|
||||
`internal/app/archied.Run()`, and `internal/app/agentworker` (invoked by
|
||||
`cmd/archie-agent/main.go`). Do not treat `cmd/*` as the wiring site.
|
||||
**Production wiring**: a path selected by a shipped entrypoint — not a
|
||||
constructor, decoder, or passing unit test. **State owner**: component with
|
||||
authority to validate and persist a state transition.
|
||||
|
||||
## Establish a reproducible baseline
|
||||
|
||||
```sh
|
||||
go version; go env GOMOD GOWORK GOOS GOARCH
|
||||
gopls version; golangci-lint version; staticcheck -version
|
||||
```
|
||||
|
||||
As of 2026-09-18: Go 1.27.0, gopls 0.23.0, golangci-lint 2.13.2,
|
||||
staticcheck 2026.2.1. Use `gopls call_hierarchy` (no `go tool callgraph`;
|
||||
`go tool` lists only asm, cgo, compile, cover, fix, link, preprofile, vet).
|
||||
|
||||
Writable caches when defaults are read-only:
|
||||
|
||||
```sh
|
||||
export GOCACHE="${TMPDIR:-/tmp}/archie-discovery-gocache"
|
||||
export GOLANGCI_LINT_CACHE="${TMPDIR:-/tmp}/archie-discovery-lint"
|
||||
export GOTMPDIR="${TMPDIR:-/tmp}"
|
||||
export GOPROXY=off GOFLAGS=-mod=readonly
|
||||
```
|
||||
|
||||
Module boundaries (root and `tools/` are separate):
|
||||
|
||||
```sh
|
||||
find . -name go.mod -not -path './.git/*' -not -path './node_modules/*'
|
||||
go list -m -f '{{.Path}} {{.GoVersion}}'
|
||||
go -C tools list -mod=readonly -m -f '{{.Path}} {{.GoVersion}}'
|
||||
```
|
||||
|
||||
## Build the behavior trace
|
||||
|
||||
Write: behavior, observable input, expected output, state that may change, modes.
|
||||
|
||||
| Step | Find | Required evidence |
|
||||
|---:|---|---|
|
||||
| 1 | Entrypoint | `main`, handler, poller, RPC subject, or tool registration |
|
||||
| 2 | Construction | Constructor and every direct struct literal |
|
||||
| 3 | Contract | Interface, wire type, command, event, or public method crossed |
|
||||
| 4 | Implementation | All type-valid implementations, selected per mode |
|
||||
| 5 | State owner | Function validating transition, owning concurrency/transaction rules |
|
||||
| 6 | Persistence | Store adapter, schema/key/document, serialization, reload/recovery |
|
||||
| 7 | Event/transport | Publish/send and subscribe/receive, subject/framing, timeout, retry, ack |
|
||||
| 8 | Consumer | Callers and downstream readers |
|
||||
| 9 | Tests | Unit, integration, contract, architecture, production-composition |
|
||||
| 10 | Configuration | Decode, default, validation, normalization, composition-root consumption |
|
||||
| 11 | Target architecture | Current-to-target mapping in `docs/prds/`; label gaps |
|
||||
|
||||
Start at these verified anchors:
|
||||
|
||||
| Concern | Current anchor |
|
||||
|---|---|
|
||||
| Resident daemon | `cmd/archied/main.go` → `internal/app/archied.Run()` (`internal/app/archied/main.go`) → `daemon.Daemon` |
|
||||
| Sandboxed worker | `cmd/archie-agent/main.go` → `internal/app/agentworker/`; NATS boundary in `internal/infrastructure/agenttransport/nats/` |
|
||||
| Task orchestration | `internal/daemon/daemon.go`, `internal/domain/workflow/` |
|
||||
| Task contracts | `internal/domain/storecontract/storecontract.go` (`TaskStore`); `internal/store/interface.go` holds compatibility aliases only |
|
||||
| Production task persistence | `internal/store/`; `openProductionTaskStore` reached via `internal/app/archied/state_store.go` |
|
||||
| RPC split | `internal/{taskrun,natsrpc,forgerpc,worktreerpc}/` plus `internal/infrastructure/staterpc/` (gRPC State Store) |
|
||||
| Chat and channels | `internal/gateway/`, `internal/channels/` |
|
||||
| Configuration | `internal/config/`, `internal/infrastructure/configuration/`, `config.example.toml`, `deployments/*.toml` |
|
||||
| Target map | `docs/prds/01-project-management.md` and linked `docs/architecture/*.md` |
|
||||
|
||||
## Use syntax, type, and call evidence
|
||||
|
||||
### Map packages before reading files
|
||||
|
||||
```sh
|
||||
go list -f '{{.ImportPath}}|go={{join .GoFiles ","}}|tests={{join .TestGoFiles ","}}' ./internal/store
|
||||
go list -json ./internal/store
|
||||
.agents/skills/archie-codebase-discovery/scripts/package-edges.sh ./internal/...
|
||||
```
|
||||
|
||||
### Resolve symbols with gopls
|
||||
|
||||
1-indexed `file:line:column`:
|
||||
|
||||
```sh
|
||||
gopls symbols internal/domain/storecontract/storecontract.go
|
||||
gopls definition cmd/archied/main.go:27:14
|
||||
gopls references -d internal/domain/storecontract/storecontract.go:33:2
|
||||
gopls implementation internal/domain/storecontract/storecontract.go:33:2
|
||||
gopls call_hierarchy internal/domain/storecontract/storecontract.go:33:2
|
||||
go doc ./internal/domain/storecontract.TaskStore
|
||||
go test ./internal/store -list '.'
|
||||
```
|
||||
|
||||
### Generate AST candidates for construction
|
||||
|
||||
```sh
|
||||
.agents/skills/archie-codebase-discovery/scripts/scan-go-type-syntax.sh Daemon .
|
||||
.agents/skills/archie-codebase-discovery/scripts/scan-go-type-syntax.sh -tests Task .
|
||||
```
|
||||
|
||||
Confirms candidates with `gopls definition` or `gopls references`. Pass
|
||||
`-tests` to expose test-only construction.
|
||||
|
||||
## Run focused discovery recipes
|
||||
|
||||
### Find duplicate behavior paths
|
||||
|
||||
```sh
|
||||
golangci-lint run --enable-only=dupl ./internal/...
|
||||
rg -n 'Transition\(|PublishTask\(|ClaimNext\(|StatusWaitingHuman' cmd internal
|
||||
```
|
||||
|
||||
Trace each candidate to entrypoint and state owner. `dupl` finds similar syntax,
|
||||
not two different implementations of one responsibility.
|
||||
|
||||
### Find unused-but-compiled code
|
||||
|
||||
```sh
|
||||
staticcheck -checks=U1000 ./internal/...
|
||||
```
|
||||
|
||||
For every suspect: `gopls references -d`; search init, reflection/Yaegi, tags,
|
||||
RPC subjects, plugin manifests, string dispatch; check build tags/OS files;
|
||||
search both composition roots. `U1000` does not prove exported/reflection/wire
|
||||
targets are dead.
|
||||
|
||||
### Find interface implementations
|
||||
|
||||
```sh
|
||||
gopls implementation
|
||||
rg -n 'var _ .*=' --glob '*.go' cmd internal
|
||||
```
|
||||
|
||||
Trace which implementation the composition root selects for each mode.
|
||||
|
||||
### Find struct-field consumers
|
||||
|
||||
`gopls references -d` on field declaration, not common name. Trace assignments
|
||||
and reads separately. Follow `ForTask`/`ToConfig` copies. Check JSON/TOML/YAML
|
||||
tags. Compare production and `_test.go` references.
|
||||
|
||||
### Detect constructor bypasses
|
||||
|
||||
Run `scan-go-type-syntax.sh Type .`. Inspect struct literals outside owning
|
||||
package. Compare validation/defaulting in constructors with direct literals.
|
||||
Use `gopls references` on constructor and type.
|
||||
|
||||
### Prove package dependency direction
|
||||
|
||||
```sh
|
||||
.agents/skills/archie-codebase-discovery/scripts/package-edges.sh ./internal/...
|
||||
go list -deps -json <pattern>
|
||||
```
|
||||
|
||||
### Find decoded-but-unused configuration
|
||||
|
||||
Prove: `file/key → decoder → default → validation → normalization/copy →
|
||||
composition-root read → concrete component → observable behavior`.
|
||||
|
||||
```sh
|
||||
rg -n 'toml:"|yaml:"|json:"' internal/config
|
||||
rg -n 'Resolve|Overlay|Dir|finalize|ForTask|ToConfig' internal/infrastructure/configuration internal/app/archied
|
||||
gopls references -d <exact-field>
|
||||
```
|
||||
|
||||
Decoding lives in `internal/infrastructure/configuration`, not `internal/config`.
|
||||
`configuration.New(log)` returns a `Loader`; the composition root in
|
||||
`internal/app/archied/bootstrap.go` calls `Loader.Resolve` (with `Loader.Overlay`
|
||||
and `Loader.Dir` for overlay/`conf.d` inputs). There is no `config.Load` or
|
||||
`config.LoadDir`.
|
||||
|
||||
### Prove production composition
|
||||
|
||||
1. Start at `internal/app/archied/main.go` (`Run`), entered from
|
||||
`cmd/archied/main.go`.
|
||||
2. Record config condition per branch.
|
||||
3. Follow concrete construction into `daemon.Daemon` and gateway start.
|
||||
4. For container/NATS behavior, trace `cmd/archie-agent/main.go` into
|
||||
`internal/app/agentworker` and `internal/infrastructure/agenttransport/nats`.
|
||||
5. Trace both sides of every RPC/transport and error/timeout paths.
|
||||
6. Read contract/architecture tests.
|
||||
7. Confirm deploy inputs in Compose and CI.
|
||||
|
||||
### Trace SQLite persistence
|
||||
|
||||
Treat `internal/domain/storecontract` as the application contract and
|
||||
`internal/store` as the production SQLite adapter behind it.
|
||||
|
||||
```sh
|
||||
gopls implementation internal/domain/storecontract/storecontract.go:33:2
|
||||
rg -n 'CREATE TABLE|CREATE INDEX|QueryContext|ExecContext|BeginTx' internal/store
|
||||
```
|
||||
|
||||
## Reject false confidence
|
||||
|
||||
| Weak evidence | Why it fails | Required correction |
|
||||
|---|---|---|
|
||||
| One `rg` result | Misses interface dispatch, aliases, generated registration, reflection | Use gopls, AST candidates, package edges, composition |
|
||||
| Green unit test | May bypass config, lifecycle, transport | Add composition/contract/integration evidence |
|
||||
| Fake client and server agree | Both mirror same wrong framing/subject/state assumption | Compare independent spec or real boundary fixture |
|
||||
| High coverage | Does not establish ownership, maintainability, mode selection | Trace authority and production selection |
|
||||
| Constructor exists | Does not prove callers use it | Find struct literals and type-aware references |
|
||||
| Config field decodes | Does not prove executable reads it | Complete config-to-observable chain |
|
||||
| Target PRD says it | Not necessarily current code | Cite current implementation and label gap |
|
||||
|
||||
## Produce the discovery handoff
|
||||
|
||||
1. **Behavior trace:** path:line, symbol, current responsibility per traversal step.
|
||||
2. **Mode matrix:** mode/config branch → concrete implementation → state store
|
||||
→ transport → consumer.
|
||||
3. **State and authority:** owner, copies, persistence, transition rules, recovery.
|
||||
4. **Blast radius:** callers, consumers, tests, config, deploy wiring, docs,
|
||||
compatibility paths.
|
||||
5. **Duplication/deprecation ledger:** each candidate, live/dead evidence,
|
||||
replacement, objective removal gate.
|
||||
6. **Current-to-target gap:** current fact, target PRD, migration implication.
|
||||
7. **Unknowns:** exact command, output/blocker, next evidence needed.
|
||||
|
||||
Do not propose implementation until the trace answers: what entrypoint selects
|
||||
this path, which component owns state, which parallel/older path the feature
|
||||
replaces, which production modes and persisted data must remain compatible,
|
||||
which evidence would falsify current understanding.
|
||||
@@ -1,4 +0,0 @@
|
||||
interface:
|
||||
display_name: "Archie Codebase Discovery"
|
||||
short_description: "Trace Archie behavior from entrypoint to production"
|
||||
default_prompt: "Use $archie-codebase-discovery to trace this behavior through production wiring before proposing a change."
|
||||
@@ -1,36 +0,0 @@
|
||||
#!/bin/sh
|
||||
set -eu
|
||||
|
||||
if [ "$#" -gt 1 ]; then
|
||||
printf '%s\n' "usage: $0 [go-package-pattern]" >&2
|
||||
exit 2
|
||||
fi
|
||||
|
||||
command -v go >/dev/null 2>&1 || {
|
||||
printf '%s\n' "error: go is required" >&2
|
||||
exit 127
|
||||
}
|
||||
|
||||
pattern=${1:-./...}
|
||||
cache_root=${ARCHIE_DISCOVERY_CACHE:-"${TMPDIR:-/tmp}/archie-codebase-discovery"}
|
||||
mkdir -p "$cache_root/go-build" "$cache_root/tmp"
|
||||
|
||||
export GOCACHE="$cache_root/go-build"
|
||||
export GOTMPDIR="$cache_root/tmp"
|
||||
export GOPROXY=off
|
||||
export GOFLAGS=-mod=readonly
|
||||
|
||||
module_path=$(go list -m -f '{{.Path}}')
|
||||
|
||||
go list -f '{{.ImportPath}}{{range .Imports}}{{printf "\t%s" .}}{{end}}' "$pattern" |
|
||||
awk -F ' ' -v module="$module_path" '
|
||||
{
|
||||
from = $1
|
||||
for (i = 2; i <= NF; i++) {
|
||||
if ($i == module || index($i, module "/") == 1) {
|
||||
printf "%s -> %s\n", from, $i
|
||||
}
|
||||
}
|
||||
}
|
||||
' |
|
||||
LC_ALL=C sort -u
|
||||
@@ -1,176 +0,0 @@
|
||||
// Command scan-go-type-syntax reports syntax-level construction candidates for
|
||||
// a named Go type. It deliberately uses only the standard library and never
|
||||
// writes to the inspected tree.
|
||||
package main
|
||||
|
||||
import (
|
||||
"bufio"
|
||||
"flag"
|
||||
"fmt"
|
||||
"go/ast"
|
||||
"go/parser"
|
||||
"go/token"
|
||||
"io/fs"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"sort"
|
||||
"strings"
|
||||
)
|
||||
|
||||
type finding struct {
|
||||
path string
|
||||
line int
|
||||
column int
|
||||
kind string
|
||||
detail string
|
||||
}
|
||||
|
||||
func main() {
|
||||
includeTests := flag.Bool("tests", false, "include *_test.go files")
|
||||
flag.Usage = func() {
|
||||
fmt.Fprintf(flag.CommandLine.Output(), "usage: %s [-tests] TypeName [root]\n", os.Args[0])
|
||||
flag.PrintDefaults()
|
||||
}
|
||||
flag.Parse()
|
||||
if flag.NArg() < 1 || flag.NArg() > 2 {
|
||||
flag.Usage()
|
||||
os.Exit(2)
|
||||
}
|
||||
|
||||
typeName := flag.Arg(0)
|
||||
root := "."
|
||||
if flag.NArg() == 2 {
|
||||
root = flag.Arg(1)
|
||||
}
|
||||
if !token.IsIdentifier(typeName) {
|
||||
fmt.Fprintf(os.Stderr, "error: %q is not a Go identifier\n", typeName)
|
||||
os.Exit(2)
|
||||
}
|
||||
|
||||
results, err := scan(root, typeName, *includeTests)
|
||||
if err != nil {
|
||||
fmt.Fprintf(os.Stderr, "error: %v\n", err)
|
||||
os.Exit(1)
|
||||
}
|
||||
|
||||
out := bufio.NewWriter(os.Stdout)
|
||||
defer out.Flush()
|
||||
fmt.Fprintln(out, "kind\tlocation\tdetail")
|
||||
for _, result := range results {
|
||||
fmt.Fprintf(out, "%s\t%s:%d:%d\t%s\n",
|
||||
result.kind, result.path, result.line, result.column, result.detail)
|
||||
}
|
||||
}
|
||||
|
||||
func scan(root, typeName string, includeTests bool) ([]finding, error) {
|
||||
fset := token.NewFileSet()
|
||||
var results []finding
|
||||
|
||||
err := filepath.WalkDir(root, func(path string, entry fs.DirEntry, walkErr error) error {
|
||||
if walkErr != nil {
|
||||
return walkErr
|
||||
}
|
||||
if entry.IsDir() {
|
||||
if path == root {
|
||||
return nil
|
||||
}
|
||||
name := entry.Name()
|
||||
if strings.HasPrefix(name, ".") || name == "node_modules" ||
|
||||
name == "vendor" || name == "bin" {
|
||||
return filepath.SkipDir
|
||||
}
|
||||
return nil
|
||||
}
|
||||
if filepath.Ext(path) != ".go" {
|
||||
return nil
|
||||
}
|
||||
if !includeTests && strings.HasSuffix(path, "_test.go") {
|
||||
return nil
|
||||
}
|
||||
|
||||
file, err := parser.ParseFile(fset, path, nil, 0)
|
||||
if err != nil {
|
||||
return fmt.Errorf("parse %s: %w", path, err)
|
||||
}
|
||||
|
||||
ast.Inspect(file, func(node ast.Node) bool {
|
||||
switch node := node.(type) {
|
||||
case *ast.TypeSpec:
|
||||
if node.Name.Name == typeName {
|
||||
results = appendFinding(results, fset, node.Name.Pos(),
|
||||
path, "declaration", "type "+node.Name.Name)
|
||||
}
|
||||
case *ast.CompositeLit:
|
||||
if matchesType(node.Type, typeName) {
|
||||
results = appendFinding(results, fset, node.Type.Pos(),
|
||||
path, "literal", "direct composite literal of "+typeName)
|
||||
}
|
||||
case *ast.FuncDecl:
|
||||
if returnsType(node.Type.Results, typeName) {
|
||||
results = appendFinding(results, fset, node.Name.Pos(),
|
||||
path, "returns-type", "func "+node.Name.Name)
|
||||
}
|
||||
}
|
||||
return true
|
||||
})
|
||||
return nil
|
||||
})
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
sort.Slice(results, func(i, j int) bool {
|
||||
left, right := results[i], results[j]
|
||||
if left.path != right.path {
|
||||
return left.path < right.path
|
||||
}
|
||||
if left.line != right.line {
|
||||
return left.line < right.line
|
||||
}
|
||||
if left.column != right.column {
|
||||
return left.column < right.column
|
||||
}
|
||||
return left.kind < right.kind
|
||||
})
|
||||
return results, nil
|
||||
}
|
||||
|
||||
func appendFinding(results []finding, fset *token.FileSet, pos token.Pos, path, kind, detail string) []finding {
|
||||
position := fset.Position(pos)
|
||||
return append(results, finding{
|
||||
path: filepath.ToSlash(path),
|
||||
line: position.Line,
|
||||
column: position.Column,
|
||||
kind: kind,
|
||||
detail: detail,
|
||||
})
|
||||
}
|
||||
|
||||
func returnsType(fields *ast.FieldList, typeName string) bool {
|
||||
if fields == nil {
|
||||
return false
|
||||
}
|
||||
for _, field := range fields.List {
|
||||
if matchesType(field.Type, typeName) {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
func matchesType(expr ast.Expr, typeName string) bool {
|
||||
switch expr := expr.(type) {
|
||||
case *ast.Ident:
|
||||
return expr.Name == typeName
|
||||
case *ast.SelectorExpr:
|
||||
return expr.Sel.Name == typeName
|
||||
case *ast.StarExpr:
|
||||
return matchesType(expr.X, typeName)
|
||||
case *ast.IndexExpr:
|
||||
return matchesType(expr.X, typeName)
|
||||
case *ast.IndexListExpr:
|
||||
return matchesType(expr.X, typeName)
|
||||
default:
|
||||
return false
|
||||
}
|
||||
}
|
||||
@@ -1,13 +0,0 @@
|
||||
#!/bin/sh
|
||||
set -eu
|
||||
|
||||
script_dir=$(CDPATH= cd -- "$(dirname -- "$0")" && pwd)
|
||||
cache_root=${ARCHIE_DISCOVERY_CACHE:-"${TMPDIR:-/tmp}/archie-codebase-discovery"}
|
||||
mkdir -p "$cache_root/go-build" "$cache_root/tmp"
|
||||
|
||||
export GOCACHE="$cache_root/go-build"
|
||||
export GOTMPDIR="$cache_root/tmp"
|
||||
export GOPROXY=off
|
||||
export GOFLAGS=-mod=readonly
|
||||
|
||||
exec go run "$script_dir/scan-go-type-syntax.go" "$@"
|
||||
@@ -1,61 +0,0 @@
|
||||
#!/bin/sh
|
||||
set -u
|
||||
|
||||
usage() {
|
||||
printf '%s\n' "usage: $0 file.go:line:column" >&2
|
||||
exit 2
|
||||
}
|
||||
|
||||
[ "$#" -eq 1 ] || usage
|
||||
position=$1
|
||||
|
||||
command -v go >/dev/null 2>&1 || {
|
||||
printf '%s\n' "error: go is required" >&2
|
||||
exit 127
|
||||
}
|
||||
command -v gopls >/dev/null 2>&1 || {
|
||||
printf '%s\n' "error: gopls is required" >&2
|
||||
exit 127
|
||||
}
|
||||
|
||||
case "$position" in
|
||||
*.go:[1-9]*:[1-9]*) ;;
|
||||
*) usage ;;
|
||||
esac
|
||||
|
||||
cache_root=${ARCHIE_DISCOVERY_CACHE:-"${TMPDIR:-/tmp}/archie-codebase-discovery"}
|
||||
mkdir -p "$cache_root/go-build" "$cache_root/xdg" "$cache_root/tmp" || exit 1
|
||||
|
||||
export GOCACHE="$cache_root/go-build"
|
||||
export XDG_CACHE_HOME="$cache_root/xdg"
|
||||
export GOTMPDIR="$cache_root/tmp"
|
||||
export GOPROXY=off
|
||||
export GOFLAGS=-mod=readonly
|
||||
|
||||
gomod=$(go env GOMOD)
|
||||
if [ "$gomod" = "/dev/null" ] || [ -z "$gomod" ]; then
|
||||
printf '%s\n' "error: run from inside a Go module" >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
run_query() {
|
||||
label=$1
|
||||
shift
|
||||
printf '\n== %s ==\n' "$label"
|
||||
if output=$(gopls "$@" 2>&1); then
|
||||
printf '%s\n' "$output"
|
||||
return 0
|
||||
else
|
||||
printf '%s\n' "$output"
|
||||
printf '%s\n' "(query is not applicable at this position, or failed)"
|
||||
return 1
|
||||
fi
|
||||
}
|
||||
|
||||
successful=0
|
||||
run_query "definition" definition "$position" && successful=$((successful + 1))
|
||||
run_query "references (including declaration)" references -d "$position" && successful=$((successful + 1))
|
||||
run_query "implementations" implementation "$position" && successful=$((successful + 1))
|
||||
run_query "call hierarchy" call_hierarchy "$position" && successful=$((successful + 1))
|
||||
|
||||
[ "$successful" -gt 0 ]
|
||||
@@ -1,263 +0,0 @@
|
||||
---
|
||||
name: archie-config-and-flags
|
||||
description: Trace, add, rename, deprecate, or debug Archie configuration and command-line flags from external input through defaults, validation, overlays, environment and secret handling, worker snapshots, deployment passthrough, and the production consumer. Use for internal/config, config.example.toml, deployments/*.toml, docker-compose.yml, archied or archie-agent flags, multi-identity settings, mode-parity questions, and reports of a setting that parses but has no effect.
|
||||
---
|
||||
|
||||
# Trace Archie configuration and flags
|
||||
|
||||
Treat configuration as a dataflow, not as a struct inventory. Prove every
|
||||
claimed setting has an input, normalization path, composition seam, and runtime
|
||||
consumer.
|
||||
|
||||
Current evidence date: **2026-09-18** for the matrix below. Entries added later
|
||||
carry their own date inline.
|
||||
|
||||
Use these status terms exactly:
|
||||
|
||||
| Status | Meaning |
|
||||
| --- | --- |
|
||||
| **production-wired** | A real entrypoint decodes or accepts the value and a runtime consumer uses it. |
|
||||
| **partially-wired** | Some modes, scopes, or fields consume it, but parity is incomplete. |
|
||||
| **test/library-only** | An API and tests exist, but no current binary selects it. |
|
||||
| **decoded-but-unwired** | Decoding/defaulting succeeds, but no production consumer uses the effective value. |
|
||||
| **external-production-unknown** | The repository does not contain the deployed effective value. |
|
||||
|
||||
Never upgrade a status merely because decoding tests pass.
|
||||
|
||||
## Trace one setting before editing it
|
||||
|
||||
1. Find every external spelling, Go field, flag, environment name, example, and
|
||||
deployment reference.
|
||||
2. Identify the selected loader or flag set.
|
||||
3. Read `finalize` and any consumer-side defaults.
|
||||
4. Follow copies across `ForTask`, `ToConfig`, NATS messages, subprocess
|
||||
env selection, container env construction, and identity overlays.
|
||||
5. Find the production composition site and final behavior-changing read.
|
||||
6. Find tests for decoding, defaulting, invalid input, production composition,
|
||||
and mode parity.
|
||||
7. Check `config.example.toml`, `deployments/*.toml`, `docker-compose.yml`, and
|
||||
deployment environment passthrough.
|
||||
8. Assign one status from the table above.
|
||||
|
||||
```bash
|
||||
rg -n 'Resolve|Overlay|Dir|ForTask|ToConfig|flag\.' \
|
||||
internal/infrastructure/configuration internal/config internal/app/archied cmd/archie-agent
|
||||
rg -n 'FIELD_NAME|external_key|ENV_NAME' \
|
||||
--glob '*.go' --glob '*.toml' --glob '*.yml' --glob '*.yaml' .
|
||||
```
|
||||
|
||||
## Select the real input path
|
||||
|
||||
| Input path | Current behavior | Status |
|
||||
| --- | --- | --- |
|
||||
| `archied -config PATH` | Defaults to `$XDG_CONFIG_HOME/archie/config.toml`, or `$HOME/.config/archie/config.toml`; `internal/app/archied/bootstrap.go` builds `configuration.New(log)` and calls `Loader.Resolve`. | production-wired |
|
||||
| `archied -config-overlay PATH` | Resolves a file or directory overlay through the same loader. Omitted overlay fields retain base values. This is the only overlay: the dashboard runtime overlay and its SQLite store were deleted when the control plane took over settings writes. | production-wired |
|
||||
| `configuration.Loader.Dir(base, overlay)` | Supports main YAML/TOML plus feature YAML and `conf.d`; no current entrypoint calls it. | test/library-only |
|
||||
| `config.Load(path)`, `config.LoadDir(...)` | Removed. The old `internal/config` package-level helpers no longer exist; decoding is `Loader`-based. | not applicable |
|
||||
| `config.example.toml` | Load-tested example, not a deployed configuration. | test/library-only |
|
||||
| `deployments/docker-nats-stack.toml` | Complete host-daemon configuration for the Compose-managed NATS service. It is copied into the operator's config directory; Compose does not mount it. | supported-example |
|
||||
| Operator config and environment | Lives outside the repository; contents are deployment-specific. | external-production-unknown |
|
||||
|
||||
Both TOML and YAML decoding are non-strict at the field level. Add explicit
|
||||
compatibility and typo tests; never use "the file loaded" as evidence that a
|
||||
key took effect.
|
||||
|
||||
A registered service client always resolves to a non-empty target, so
|
||||
`Services.Get(name).Target != ""` proves nothing. `RegisterService` in
|
||||
`internal/config/servicespec.go` supplies the fallback (`127.0.0.1:9090` for
|
||||
the State Store, `127.0.0.1:8585` for the Gateway), which means a guard written
|
||||
as "only dial when configured" dials always, and a test that sets no target
|
||||
reaches for a real process on the developer's machine. Gate on an explicit
|
||||
flag or on the dial succeeding, and give a binary its own
|
||||
`-<service>-target` flag so tests can point it at a fake.
|
||||
|
||||
## Inventory CLI flags
|
||||
|
||||
### Public binaries
|
||||
|
||||
| Binary | Flag | Default and effect |
|
||||
| --- | --- | --- |
|
||||
| `archied` | `-config PATH` | Computed config path described above. |
|
||||
| `archied` | `-config-overlay PATH` | Empty; overlay only fields explicitly present in second TOML. |
|
||||
| `archied` | `-once` | `false`; run one poll/process cycle and exit. |
|
||||
| `archied` | `-requeue ID` | `0`; values greater than zero requeue one parked/waiting task, then exit unless `-once` also set. |
|
||||
| `archie-agent` | `-nats-url URL` | Empty; takes precedence over `NATS_URL`. Missing both is fatal. |
|
||||
| `archie-agent` | `-consumer NAME` | `archie-agent`; names the JetStream durable consumer. |
|
||||
| both | `-quickchecks N` | Incidental flag registered by `github.com/traefik/yaegi/stdlib` importing `testing/quick`; default `100`. Treat as unowned candidate defect. |
|
||||
|
||||
The standalone agent always reads its token from `NATS_TOKEN`; there is no
|
||||
token flag.
|
||||
|
||||
### Internal codesearch helper
|
||||
|
||||
`archied workspace-codesearch` bypasses daemon configuration before normal flag
|
||||
parsing:
|
||||
|
||||
| Subcommand | Required flags | Optional flags |
|
||||
| --- | --- | --- |
|
||||
| `build` | `--root`, `--index` | none |
|
||||
| `candidates` | `--index`, `--pattern` | `--literal`, `--case-sensitive` |
|
||||
|
||||
Do not expose these helper flags as daemon settings.
|
||||
|
||||
## Read the current wiring matrix
|
||||
|
||||
### Root daemon and capability settings
|
||||
|
||||
| Keys | Default, validation, and consumer | Status |
|
||||
| --- | --- | --- |
|
||||
| `work_dir`, `db_path` | Derive from `$XDG_DATA_HOME/archie`, else `$HOME/.local/share/archie`; explicit `~` paths are home-expanded. `db_path` is a prefix: tasks/events use `<db_path>-tasks.sqlite` and conversations use `<db_path>-conversations.sqlite`. | production-wired |
|
||||
| `skills_dir` | Empty falls back to `work_dir` for startup workflow registry. | partially-wired |
|
||||
| `plugin_dir` | Empty disables daemon plugin loading; configured directory loaded in `internal/app/archied`. | production-wired |
|
||||
| `poll_interval` | Default `60s`; root poll loop uses it, identities may override only interval. | production-wired |
|
||||
| `label` | No default or validation; used for `dispatch.trigger = "label"` or `"either"`. | production-wired |
|
||||
| `max_retries` | Default `3`; repository value greater than zero overrides. | production-wired |
|
||||
| `bot_user`, `bot_email` | Single-identity requires `bot_user`; email defaults by forge type. | production-wired |
|
||||
| `forge.type`, `host`, `token` | Type defaults `github`, host defaults `https://github.com`; only `github` and `gitea` validate. | production-wired |
|
||||
| `dispatch.trigger` | Default `assignee`; validates `assignee`, `label`, or `either`. | production-wired |
|
||||
| `dispatch.ack_reaction` | Default `eyes`; case-insensitive `off` normalizes to empty. | production-wired |
|
||||
| `dispatch.labels.*` | Missing keys default independently to `agent:*`. | production-wired |
|
||||
| `models.<role>` | Workflow stages read requested role then fall back to `builder`; triage judge falls back `triage` to `planner`. | production-wired |
|
||||
| `providers.<name>.class`, `api_key_env`, `base_url` | Builds ai-sdk catalog. `base_url` rejects parse errors, userinfo, query, and fragment. | production-wired |
|
||||
| `agent.mode` | Default `nats` when containers enabled, otherwise `inprocess`; validates `inprocess`, `subprocess`, or `nats`. | production-wired |
|
||||
| `agent.command`, `agent.env` | Command defaults `archie-agent`; env entries must be nonblank names without `=`. | partially-wired |
|
||||
| `budgets.max_steps`, `max_tokens`, `wall_clock`, `gate_max_failures` | No loader defaults; `Budgets` documents zero as disabling. | production-wired |
|
||||
| `diff_cap_lines` | Zero replaced by `400` in `finalize`; `StageDiffCap` treats `<= 0` as disabled. TOML zero cannot disable; negative value does. | production-wired |
|
||||
| `web.listen` | Empty becomes `127.0.0.1:8484`; literal `off` disables. No authentication. | production-wired |
|
||||
| `notify.webhook` | Empty disables; feasibility workflow POSTs human-decision notifications when set. | production-wired |
|
||||
| `nats.url`, `token_env` | Empty URL keeps SQLite path. Configured token variable must be non-empty. | production-wired |
|
||||
| `containers.*` | See dedicated table below. | production-wired |
|
||||
| `chat.*` | See channel table below. | production-wired |
|
||||
| `memory.provider`, `provider_config` | Feature YAML decodes these; `internal/app/archied` always starts built-in file provider at `work_dir/memory`. | decoded-but-unwired |
|
||||
| `tools.mcp_servers` | `internal/app/archied` registers daemon-side MCP providers. Empty transport becomes `stdio`; only `stdio` accepted. `url` decoded but unused. | partially-wired |
|
||||
| `indexing.index_dir`, `indexing.db_path` | `finalize` derives paths under `work_dir`; no entrypoint constructs `internal/indexing.Manager` (the exported `NewManager` exists but has no production caller). | decoded-but-unwired |
|
||||
| `extra` / unknown `conf.d` values | Test/library-only `Loader.Dir` stores untyped data; no core production consumer. | decoded-but-unwired |
|
||||
| `[identities.forge].intake`, `.webhook_secret`, `.webhook_addr` | 2026-09-22: these parse because `IdentityConfig` embeds `Forge` (`internal/config/config.go:573`), while every read is the root `[forge]` block (`validate.go`, `defaults.go`, `bootstrap.go`). Wiring them is the intake migration, tracked as `archie-core-1786637497036-275-8838629e`. | partially-wired |
|
||||
|
||||
**Three shapes of an unwired field.** All three read as working from the file
|
||||
alone, and only the first two are defects - so establish which shape you are
|
||||
looking at before reporting one:
|
||||
|
||||
1. **not-consumed.** Decoded and normalized, but no production consumer uses the
|
||||
effective value (`memory.provider` and `indexing.*` above; per-identity intake
|
||||
was this shape until 2026-09-22, when the configuration was made to reject it
|
||||
rather than accept it).
|
||||
2. **not-projected.** A read exists, but at a layer that does not own the
|
||||
effective copy, so editing the wrong layer does nothing. Direction matters as
|
||||
much as presence: for most `[chat.*]` keys the stored resource outranks the
|
||||
file, so writing a new file value is a no-op once a resource exists. A file
|
||||
key in that position is a **seed**, not the contract.
|
||||
3. **deliberately-not-projected.** File-only by design and therefore
|
||||
indistinguishable from a dropped field to an auditor unless the projection
|
||||
says so in a comment. `runtimeChatConfigFrom` reads
|
||||
`Telegram.UpdateCheckCommand`/`UpdateInstallCommand` from `base` rather than
|
||||
from the stored resource, on purpose. Check for that comment before filing a
|
||||
defect.
|
||||
|
||||
The default `agent.command = "archie-agent"` is not verified subprocess
|
||||
operation. `SubprocessRunner` expects one JSON invocation on stdin and one JSON
|
||||
response on stdout; `cmd/archie-agent` is a long-running NATS worker.
|
||||
|
||||
### Repository settings
|
||||
|
||||
| Keys | Effective behavior | Status |
|
||||
| --- | --- | --- |
|
||||
| `owner`, `name` | Required for every declared repo. Single-identity config with zero repos loads but polls nothing. | production-wired |
|
||||
| `base` | `BaseBranch()` maps empty to `main`, but `daemon.process` pre-clones with raw `repo.Base`. Set it explicitly. | partially-wired |
|
||||
| `gate` | Argv arrays run in order. Empty entries skipped. TDD inverts last non-empty command as repro test by convention. | production-wired |
|
||||
| `protect` | Path suffixes enforced by agent runner; not prompt-only rule. | production-wired |
|
||||
| `ecosystem`, `preflight`, `test_glob` | Resolved preflight/test-glob treats empty ecosystem as Go. Container storage receives raw ecosystem. Go/Python/Node/Rust have defaults; `custom` or unknown yields none. | partially-wired |
|
||||
| `persistent_storage` | Controls Docker-backed per-repo volume setup; no equivalent without container storage. | partially-wired |
|
||||
| `max_retries` | Values greater than zero override global; zero or negative falls back to global. | production-wired |
|
||||
| `allow_concurrent` | Root repo entries affect dispatcher. `allowConcurrentFor` does not inspect identity repo lists. | partially-wired |
|
||||
|
||||
### Container settings
|
||||
|
||||
| Key | Effective behavior |
|
||||
| --- | --- |
|
||||
| `enabled` | Requires non-empty `image`, `agent.mode = "nats"`, and non-empty `nats.url`. |
|
||||
| `image` | Required only when enabled. |
|
||||
| `max_concurrency` | Zero means no limit; used by general task dispatcher and container pool. |
|
||||
| `max_uptime` | Default `60m` only when enabled; caps container lifetime. |
|
||||
| `volume_ttl` | Default `72h` only when enabled; negative rejected. |
|
||||
| `pull_policy` | Default `missing` when enabled. Pool code recognizes `missing` and `always`; other strings silently skip pre-pull. |
|
||||
| `network` | Empty uses best-effort self-network detection. Repository overlay pins `archie-core_default`. |
|
||||
|
||||
### Channel settings
|
||||
|
||||
| Keys | Effective behavior |
|
||||
| --- | --- |
|
||||
| `chat.models` | Optional interactive catalog; empty falls back to workflow model references. |
|
||||
| `chat.telegram.token_env` | Empty disables Telegram; non-empty names env variable; empty value is fatal. |
|
||||
| `chat.telegram.allowed_user_ids` | Empty denies every sender; IDs match Telegram sender IDs, not chat IDs. |
|
||||
| `chat.telegram.update_check_command`, `update_install_command` | Argv arrays; check enables update status; install further enables approved installation. |
|
||||
| `chat.email.listen_addr`, `relay_addr` | Empty listen disables SMTP; relay configures outbound replies. |
|
||||
| `chat.webhook_addr` | Empty disables; malformed host/port falls back inside `parseListenAddr`. |
|
||||
|
||||
Telegram `/restart` re-runs same TOML overlay load, then replaces only gateway
|
||||
token and allowed-user list. Every other file setting is startup-only.
|
||||
|
||||
## Treat multi-identity as partially wired
|
||||
|
||||
`finalize` requires each identity's `name`, `bot_user`, non-empty repos, forge
|
||||
type, and `SecretRef` token. `internal/app/archied` builds an identity forge
|
||||
client and worktree manager.
|
||||
|
||||
Do not infer complete isolation:
|
||||
|
||||
- `internal/app/archied` resolves root forge client before all identity runners.
|
||||
- Identity `name`, forge, repos, poll interval, bot user, bot email have
|
||||
production reads. Identity bot email not defaulted despite comment.
|
||||
- Identity `models`, `providers`, `dispatch`, `budgets`, `notify`, and
|
||||
`diff_cap_lines` decode but workflows still receive root `Config`.
|
||||
- Identity polling reads root `dispatch`, `label`, and `bot_user`.
|
||||
- Container task snapshots and provider maps come from root config; task RPC
|
||||
servers are root-forge/root-worktree.
|
||||
- Root-only concurrency lookup ignores identity repo `allow_concurrent`.
|
||||
|
||||
Classify multi-identity changes field by field. Never label aggregate
|
||||
`IdentityConfig` production-wired.
|
||||
|
||||
## Preserve worker and secret boundaries
|
||||
|
||||
`Config.ForTask` creates a detached root snapshot: models, budgets, dispatch,
|
||||
diff cap, notification, and forge host. `TaskConfig.ToConfig` reconstructs
|
||||
only those fields. Forge tokens, provider values, NATS credential references,
|
||||
repos, and infrastructure settings do not enter `TaskConfig`.
|
||||
|
||||
At top-level `[forge]`, prefer `token = {engine = "env", key = "NAME"}`. The
|
||||
`token_env = "NAME"` form is converted only when structured reference is empty;
|
||||
structured reference wins when both appear. This compatibility rule exists
|
||||
because an earlier migration silently dropped deployed `token_env` values and
|
||||
crash-looped the daemon. `finalize` does not apply that conversion inside each
|
||||
identity: identity forges require explicit structured `token`.
|
||||
|
||||
| Source | Archied | Subprocess | Agent container / standalone worker |
|
||||
| --- | --- | --- | --- |
|
||||
| Forge `token = {engine="env", key="X"}` | Resolves `X`; empty is fatal. | Not forwarded. | Not forwarded; forge ops proxy to daemon. |
|
||||
| Provider `api_key_env = "X"` | Runtime reads `X`. | Auto-allowlists selected provider's `X`. | Daemon forwards each present provider variable under original name. |
|
||||
| `nats.token_env = "X"` | Reads `X`; empty fatal when configured. | Not agent subprocess setting. | Daemon maps to fixed `NATS_TOKEN`; worker also reads `NATS_URL`. |
|
||||
| Telegram `token_env = "X"` | Reads `X`. | Not forwarded. | Not forwarded. |
|
||||
| `agent.env = ["X"]` | Names validated. | Copies present `X` from daemon env. | Not used by container construction. |
|
||||
|
||||
`internal/app/archied` creates `secret.NewRegistry`, which registers only the
|
||||
`env` engine. Non-env `SecretRef` values are not production-wired.
|
||||
|
||||
The host supervisor or launch shell supplies daemon secrets. Compose supplies
|
||||
no `archied` environment because the daemon is not a Compose service.
|
||||
|
||||
## Follow the approved target
|
||||
|
||||
Current code puts infrastructure paths, domain policy, channel settings,
|
||||
secrets, execution settings, repository associations, and extension data in one
|
||||
mutable `config.Config`. Treat this as a current load-bearing weakness, not a
|
||||
pattern to copy.
|
||||
|
||||
`docs/architecture/configuration.md` is approved as of 2026-07-28:
|
||||
|
||||
- move file/env/secret/overlay loading to private
|
||||
`internal/infrastructure/configuration` input boundary;
|
||||
- translate inputs in `internal/app`;
|
||||
- give each domain/plugin typed owned settings and validation;
|
||||
- dissolve `internal/config` rather than rename the global model;
|
||||
- split `Repo` and `IdentityConfig` by actual capability ownership.
|
||||
@@ -1,4 +0,0 @@
|
||||
interface:
|
||||
display_name: "Archie Config and Flags"
|
||||
short_description: "Trace Archie configuration from input to runtime"
|
||||
default_prompt: "Use $archie-config-and-flags to trace this Archie setting or CLI flag from declaration through production wiring."
|
||||
@@ -1,231 +0,0 @@
|
||||
---
|
||||
name: archie-debugging-playbook
|
||||
description: Project-specific symptom-to-evidence triage for archie-core. Load this skill when Archied hangs, parks a task, loses or duplicates work, cannot reach NATS or an agent container, rejects configuration or secrets, shows stale Telegram or dashboard state, loses streamed text, fails MCP startup, reports SQLite state surprises, degrades an optional feature, or when Go tests disagree between a sandbox, editor, CI, and the host. Use it to separate environment failures from code regressions and to choose the next exact diagnostic.
|
||||
---
|
||||
|
||||
# Debug Archie from evidence
|
||||
|
||||
**current** = 2026-09-18 verified (HEAD `2e1e1549`); **fixed history** =
|
||||
regression patterns; **open** = verified gap.
|
||||
|
||||
**Composition root**: `cmd/archied/main.go` → `internal/app/archied.Run()`;
|
||||
wiring lives in `internal/app/archied/bootstrap.go`. **Core NATS
|
||||
request/reply**: direct subject + reply inbox. **JetStream**: persisted stream
|
||||
`ARCHIE_TASKS`. **State Store**: gRPC (`internal/infrastructure/staterpc`), not
|
||||
NATS.
|
||||
**Environment failure**: test/process cannot use host resource (listener, tmp,
|
||||
Docker). **Code regression**: behavior fails where prerequisites available.
|
||||
|
||||
## Run the first-ten-minutes protocol
|
||||
|
||||
Do not begin with `task check` (mutates via `gofumpt -w .`/`go fix ./...`).
|
||||
Compile, then run:
|
||||
|
||||
```bash
|
||||
GIT_CONFIG_GLOBAL=/dev/null go test ./PATH/TO/PACKAGE -run '^TestName$' -count=1 -v
|
||||
```
|
||||
|
||||
Classify: compile-only, listener failure, read-only tmp, code regression.
|
||||
- Behavioral assertion with the prerequisite available: code regression.
|
||||
|
||||
Use this symptom index:
|
||||
|
||||
| Symptom | First boundary | Go to |
|
||||
|---|---|---|
|
||||
| `Run() = "\n"` in `TestRunWrapsExternalCommand` | Skill-script test command shape | Fixed history — passes since 2026-09-16 |
|
||||
| Embedded NATS panics before a test assertion | Listener permission | Test environment |
|
||||
| `nats: no responders available for request` | Core NATS subscription | NATS request/reply |
|
||||
| Agent reply timeout | JetStream request, inbox, or worker | NATS request/reply |
|
||||
| Queue looks empty while NATS reports an error | `Client.Fetch` batch error | NATS request/reply |
|
||||
| Config test passes but daemon ignores the field | Composition/wiring | Configuration |
|
||||
| Daemon has an env var but container does not | Compose or `containerEnv` | Configuration |
|
||||
| Telegram reply hangs on the first token | Stream consumer | Streaming |
|
||||
| MCP unit tests pass but a real server hangs | Framing mirror | MCP |
|
||||
| Telegram shows old commands | Token-scoped Telegram state | Telegram |
|
||||
| Transition succeeds from the wrong state | Store semantics | SQLite/state |
|
||||
| Dashboard skips events but task state is correct | Bounded event buffers | Events |
|
||||
| Search works but never becomes indexed | Missing production wiring | Optional features |
|
||||
| Agent container cannot resolve `nats` | Docker network | Containers |
|
||||
| `agent.mode = "subprocess"` fails at protocol startup | Worker binary mismatch | Subprocess mode |
|
||||
|
||||
## Separate test-environment failures from regressions
|
||||
|
||||
```bash
|
||||
go version
|
||||
go env GOTMPDIR GOCACHE GOPATH GOMODCACHE GOENV
|
||||
```
|
||||
|
||||
Listener-dependent tests include embedded NATS, `httptest.NewServer`, and SMTP
|
||||
listeners:
|
||||
|
||||
```bash
|
||||
rg -n 'httptest\.NewServer|net\.Listen|RunRandClientPortServer|RunServer' \
|
||||
--glob '*_test.go' cmd internal
|
||||
```
|
||||
|
||||
Do not attribute go-git commit failures to GPG without checking the
|
||||
repository-local mitigation. `worktree.Manager.setIdentity` pins
|
||||
`commit.gpgsign=false`. Isolate ambient global config:
|
||||
|
||||
```bash
|
||||
GIT_CONFIG_GLOBAL=/dev/null go test ./internal/worktree -count=1
|
||||
```
|
||||
|
||||
## Confirm the skill-script regression stays fixed
|
||||
|
||||
The `TestRunWrapsExternalCommand` failure (`Run() = "\n"`) was a test bug, not
|
||||
a product bug: `exec.CommandContext(ctx, "sh", "-c", "echo", "wrapped")`
|
||||
passes `wrapped` as shell `$0`, so only `echo` ran. It failed from commit
|
||||
`308c199` and **passes as of 2026-09-16**. Re-run it to confirm the fix has not
|
||||
regressed; a failure now is a new defect, not this one.
|
||||
|
||||
```bash
|
||||
env GOTMPDIR=/tmp GOCACHE=/tmp/archie-skillscript-gocache \
|
||||
GIT_CONFIG_GLOBAL=/dev/null go test ./internal/skillscript \
|
||||
-run '^TestRunWrapsExternalCommand$' -count=1 -v
|
||||
```
|
||||
|
||||
## Triage NATS request/reply and JetStream
|
||||
|
||||
| Surface | Subject or resource | Bound/current behavior |
|
||||
|---|---|---|
|
||||
| Task discovery | `archie.task.>` in `ARCHIE_TASKS` | Work-queue retention; daemon durable `archie-daemon`; max deliver 3 |
|
||||
| Per-stage agent request | `archie.agent.<task>.request` | Reply inbox in `X-Archie-Reply`; wall-clock budget or 30m |
|
||||
| Full task handoff | `archie.taskrun.<task-id>` | Core request/reply; no-responder retry 20s every 250ms |
|
||||
| Store RPC | gRPC State Store (`internal/infrastructure/staterpc`) | Client timeout 60s (`rpcTimeout` in `internal/app/agentworker/worker.go`); task-scoped grants for Update/Transition/InsertEvent only |
|
||||
| Forge RPC | `archie.forge.*` | Error travels in a JSON envelope |
|
||||
| Worktree RPC | `archie.worktree.prepare`, `.push` | Server default handler bound 15m |
|
||||
| Discovery dedup | `Nats-Msg-Id: archie:<owner>/<repo>/<issue>` | JetStream duplicate window 2m |
|
||||
|
||||
```bash
|
||||
docker compose ps
|
||||
docker compose logs --since=10m nats
|
||||
docker compose exec -T nats wget -q -O - http://localhost:8222/healthz
|
||||
```
|
||||
|
||||
Branch on `no responders`: container startup lag if responder appears within 20s;
|
||||
inspect agent's network/environment if every task exhausts window; confirm
|
||||
`registerTaskRPCServers` if only RPC calls time out.
|
||||
|
||||
**Fixed history:** auto-detection once put task containers on default bridge;
|
||||
explicit `containers.network` plus warning logs now fence that path.
|
||||
|
||||
Check semantics: republishing same owner/repo/issue within 2m is dedup'd; reply
|
||||
inbox auto-unsubscribes after one response; `Client.Fetch` must inspect
|
||||
`batch.Error()`; an empty poll reports `eventbus.ErrNoMessage` rather than
|
||||
`(nil, nil)`.
|
||||
|
||||
```bash
|
||||
env GOTMPDIR=/tmp GOCACHE=/tmp/archie-nats-unit-gocache \
|
||||
go test ./internal/infrastructure/eventbus/nats -run 'TestPublishUniqueSuppressesDuplicateKeyOnWorkQueueStream' -count=1 -v
|
||||
env GOTMPDIR=/tmp GOCACHE=/tmp/archie-agent-unit-gocache \
|
||||
go test ./internal/agentexec -run '^TestToolSetHandler' -count=1 -v
|
||||
```
|
||||
|
||||
## Trace configuration from source to behavior
|
||||
|
||||
Trace: `cmd/archied` (`internal/app/archied/bootstrap.go`) reads
|
||||
`-config`/`-config-overlay` → `configuration.New(log)` + `Loader.Resolve`
|
||||
decodes, `finalize` defaults/validates → secrets resolve → composition root
|
||||
constructs service → Compose/subprocess/`containerEnv` propagate → consumer.
|
||||
|
||||
```bash
|
||||
rg -n 'Loader\.(Resolve|Overlay|Dir)|configuration\.' internal/app/archied internal/infrastructure/configuration
|
||||
env GOTMPDIR=/tmp GOCACHE=/tmp/archie-config-gocache \
|
||||
go test ./internal/infrastructure/configuration \
|
||||
-run 'Test(ResolveSelectsFileFormatsAndDirectories|LoadForgeTokenEnvBackwardCompat)' -count=1 -v
|
||||
```
|
||||
|
||||
The `config.Load`/`config.LoadDir` helpers are gone; decoding is
|
||||
`Loader`-based. A YAML field decoding correctly without a composition-root read
|
||||
is a wiring gap, not a parser bug.
|
||||
|
||||
For environment failures:
|
||||
- The host supervisor supplies the daemon environment; inspect its unit or
|
||||
launch environment rather than Compose.
|
||||
- `containerEnv` translates configured NATS token name into `NATS_TOKEN` and
|
||||
forwards configured provider key variables.
|
||||
- `SubprocessRunner` forwards default compatibility variables, configured
|
||||
`[agent].env` names, and only the requested provider key.
|
||||
- Top-level `[forge] token_env` is converted to an env `SecretRef` by
|
||||
`finalize`; explicit `[forge.token]` wins.
|
||||
|
||||
Do not print secret values.
|
||||
|
||||
## Diagnose streaming, MCP, and Telegram
|
||||
|
||||
### Streaming
|
||||
Must drain `stream.FullStream`, collect `core.StreamPartTextDelta`, check
|
||||
`FinishReason`. `TextStream` is best-effort. **Fixed history:** consuming
|
||||
`TextStream` while `FullStream` unread deadlocked every reply.
|
||||
|
||||
### MCP
|
||||
Stdio framing is one compact JSON-RPC object per line. Stale
|
||||
`internal/tools/mcp/types.go` comment mentions `Content-Length` — not the
|
||||
implemented contract.
|
||||
|
||||
```bash
|
||||
env GOTMPDIR=/tmp GOCACHE=/tmp/archie-mcp-gocache \
|
||||
go test ./internal/tools/mcp \
|
||||
-run 'Test(ReadMessage|WriteMessage|StdioTransportBadFraming)' -count=1 -v
|
||||
```
|
||||
|
||||
Test helper and client share the same `readMessage`/`writeMessage` — can mirror
|
||||
mistakes. With `npx`:
|
||||
|
||||
```bash
|
||||
ARCHIE_TEST_DESKTOP_COMMANDER=1 env GOTMPDIR=/tmp \
|
||||
GOCACHE=/tmp/archie-mcp-integration-gocache \
|
||||
go test ./internal/tools/provider/mcp \
|
||||
-run '^TestDesktopCommanderClientCompatibility$' -count=1 -v
|
||||
```
|
||||
|
||||
Gate: non-empty discovery with `start_process`, `interact_with_process`,
|
||||
`read_process_output`.
|
||||
|
||||
### Telegram
|
||||
Three command scopes in `internal/channels/telegram/commands.go`: default, all
|
||||
private chats, all group chats. Narrower scope shadows default; state keyed by
|
||||
bot token. Empty `allowed_user_ids` denies everyone.
|
||||
|
||||
```bash
|
||||
env GOTMPDIR=/tmp GOCACHE=/tmp/archie-telegram-gocache \
|
||||
go test ./internal/channels/telegram \
|
||||
-run 'Test(SenderAllowlistFailsClosed|IsSenderAllowed|SessionManagementCommandsArePublished)$' \
|
||||
-count=1 -v
|
||||
```
|
||||
|
||||
**Fixed history:** publishing only default left ~60 old Hermes commands visible.
|
||||
|
||||
## Diagnose state, events, containers, and optional features
|
||||
|
||||
### SQLite and transitions
|
||||
`internal/store.Store.Transition` owns task state changes and transition
|
||||
history: it guards on `from` (`WHERE id=? AND status=?`, returning
|
||||
`store.ErrStaleTransition`) and writes status plus history in one transaction.
|
||||
When state is surprising: read `TaskByID` before/after caller; trace every
|
||||
`Transition`, `Requeue`, `RecoverStale`, `Update` — and remember the daemon
|
||||
exposes these over the gRPC State Store, not NATS.
|
||||
|
||||
```bash
|
||||
env GOTMPDIR=/tmp GOCACHE=/tmp/archie-state-gocache go test ./internal/store -count=1
|
||||
```
|
||||
|
||||
### Events
|
||||
DB sink buffer 256; SSE client buffers 64. Drop counter not read in production.
|
||||
Dashboard gap can coexist with correct task state.
|
||||
|
||||
### Containers, worktrees, and subprocess mode
|
||||
Container-mode: clones on host, mounts `/data/worktree`, writes `.git/task.json`,
|
||||
dedicated `archie.taskrun.<id>` subscription. **Open:** container RPC is
|
||||
root-identity-bound; `SubprocessRunner` expects stdin JSON protocol.
|
||||
|
||||
### Optional feature degradation
|
||||
|
||||
| Feature | Current failure behavior |
|
||||
|---|---|
|
||||
| Daemon plugins | Warn and skip |
|
||||
| Invalid MCP config | Warn and continue |
|
||||
| Skill catalog | Warn, continue without tool |
|
||||
| Worktree augmentation | Log error, use startup registry |
|
||||
| Workspace indexing | **Open:** `indexing.NewManager` exists but has no production caller in `internal/app/archied` |
|
||||
@@ -1,4 +0,0 @@
|
||||
interface:
|
||||
display_name: "Archie Debugging Playbook"
|
||||
short_description: "Diagnose Archie failures from symptoms"
|
||||
default_prompt: "Use $archie-debugging-playbook to diagnose this Archie failure from symptoms and evidence."
|
||||
@@ -1,265 +0,0 @@
|
||||
---
|
||||
name: archie-diagnostics-and-tooling
|
||||
description: "Measure Archie codebase maintainability, Go package dependency shape, configuration consumption, production composition, test and delivery-gate drift, tracked-artifact hygiene, coverage, races, and runtime evidence. Load when establishing a dated baseline, finding large or complex functions, investigating duplicate or dead-path candidates, checking whether configuration reaches an entrypoint, comparing architecture before and after a refactor, or replacing an eyeballed quality claim with reproducible numbers."
|
||||
---
|
||||
|
||||
# Measure Archie instead of eyeballing it
|
||||
|
||||
Collect evidence before judging quality. Keep collection read-only, save raw
|
||||
output, state what each metric cannot prove.
|
||||
|
||||
Volatile facts and numeric snapshots below were verified on **2026-09-18**
|
||||
(HEAD `2e1e1549`).
|
||||
|
||||
Route to `archie-codebase-discovery` for semantic traces,
|
||||
`archie-config-and-flags` for config enumeration,
|
||||
`archie-debugging-playbook` for live failures.
|
||||
|
||||
## Define the measurement terms
|
||||
|
||||
- **Baseline:** dated raw output tied to a commit, toolchain, command, and
|
||||
environment.
|
||||
- **Candidate:** a machine-found item requiring semantic confirmation.
|
||||
- **Production composition:** concrete construction selected by a shipped
|
||||
entrypoint. Principal: `cmd/archied/main.go` → `internal/app/archied.Run()`.
|
||||
- **Fan-in:** number of packages in the same module that directly import a
|
||||
package.
|
||||
- **Fan-out:** number of packages in the same module that a package directly
|
||||
imports.
|
||||
- **Physical line:** a newline-delimited source line, including comments and
|
||||
blanks.
|
||||
- **Syntactic complexity:** this skill's approximation: one plus `if`, loop,
|
||||
non-default case, communication clause, `&&`, and `||` nodes.
|
||||
|
||||
## Establish a reproducible snapshot
|
||||
|
||||
```sh
|
||||
export LC_ALL=C
|
||||
export GOCACHE=/tmp/archie-diagnostics-gocache
|
||||
export GOTMPDIR=/tmp
|
||||
export XDG_CACHE_HOME=/tmp/archie-diagnostics-xdg
|
||||
export GOLANGCI_LINT_CACHE=/tmp/archie-diagnostics-lint
|
||||
export GOPROXY=off
|
||||
export GOFLAGS=-mod=readonly
|
||||
|
||||
skill=.agents/skills/archie-diagnostics-and-tooling
|
||||
stamp=$(date -u +%Y%m%dT%H%M%SZ)
|
||||
evidence_dir=/tmp/archie-diagnostics-"$stamp"
|
||||
mkdir -p "$evidence_dir"
|
||||
|
||||
git rev-parse --verify HEAD >"$evidence_dir/revision.txt"
|
||||
git status --short >>"$evidence_dir/revision.txt"
|
||||
go version >"$evidence_dir/tools.txt"
|
||||
gopls version >>"$evidence_dir/tools.txt"
|
||||
golangci-lint version >>"$evidence_dir/tools.txt"
|
||||
staticcheck -version >>"$evidence_dir/tools.txt"
|
||||
|
||||
go run "$skill/scripts/source-metrics.go" -root . >"$evidence_dir/source.tsv"
|
||||
go run "$skill/scripts/config-use-candidates.go" -root . >"$evidence_dir/config.tsv"
|
||||
"$skill/scripts/package-shape.sh" . >"$evidence_dir/packages-root.tsv"
|
||||
"$skill/scripts/package-shape.sh" tools >"$evidence_dir/packages-tools.tsv"
|
||||
"$skill/scripts/delivery-snapshot.sh" >"$evidence_dir/delivery.tsv"
|
||||
```
|
||||
|
||||
Both filesystem-walking scripts (`source-metrics.go`,
|
||||
`config-use-candidates.go`) skip `.worktrees/`, which holds live git worktrees
|
||||
nested inside the repo root. Each is a near-complete copy of the module, so
|
||||
walking them multiplies every count by the number of checkout worktrees. If a
|
||||
new nested-checkout convention appears, extend `excludedDirectory` in both;
|
||||
`.git/info/exclude` does not help, because the scripts walk the filesystem
|
||||
rather than `git ls-files`. `package-shape.sh` reads `go list`, so it is immune.
|
||||
|
||||
## Use the bundled reports
|
||||
|
||||
### Measure source shape
|
||||
|
||||
```sh
|
||||
go run "$skill/scripts/source-metrics.go" -root . -top 30
|
||||
```
|
||||
|
||||
Read its tab-separated schema:
|
||||
|
||||
| Record | Columns after record name |
|
||||
|---|---|
|
||||
| `META` | key, value |
|
||||
| `METRIC` | module, metric, integer |
|
||||
| `PACKAGE` | module, directory, production files, test files, generated files, production lines, test lines, generated lines |
|
||||
| `HOTSPOT` | module, file, declaration line, symbol, body-span lines, statement nodes, approximate syntactic complexity |
|
||||
|
||||
The defaults (80 body lines, complexity 15) mirror numeric triage points in
|
||||
`.golangci.yml`. They do **not** implement `funlen` or `cyclop`. Run configured
|
||||
linters for authoritative findings:
|
||||
|
||||
```sh
|
||||
golangci-lint run --enable-only=funlen,gocognit,gocyclo,cyclop,maintidx,nestif ./internal/...
|
||||
```
|
||||
|
||||
If a hotspot shrinks, verify that responsibility moved to a cohesive owner.
|
||||
Moving the same work into unowned helpers is not improvement.
|
||||
|
||||
### Measure package shape
|
||||
|
||||
```sh
|
||||
"$skill/scripts/package-shape.sh" . >"$evidence_dir/packages-root.tsv"
|
||||
"$skill/scripts/package-shape.sh" tools >"$evidence_dir/packages-tools.tsv"
|
||||
awk -F ' ' '$1=="PACKAGE" {print $3 "\t" $4 "\t" $2}' "$evidence_dir/packages-root.tsv" |
|
||||
sort -nr -k1,1 -k2,2 |
|
||||
sed -n '1,20p'
|
||||
```
|
||||
|
||||
Read `PACKAGE package fan_in fan_out` and `EDGE from -> to` rows. High fan-in
|
||||
signals change risk; high fan-out signals orchestration. The report contains
|
||||
only direct, intra-module imports.
|
||||
|
||||
### Find configuration-consumption candidates
|
||||
|
||||
```sh
|
||||
go run "$skill/scripts/config-use-candidates.go" -root . >"$evidence_dir/config.tsv"
|
||||
rg 'candidate-no-(selector-outside-config|entrypoint-selector)' "$evidence_dir/config.tsv"
|
||||
```
|
||||
|
||||
Read each `CONFIG_FIELD` row as path, line, Type.Field, tags, same-name
|
||||
definition count, config-package selectors, cmd selectors, other-production
|
||||
selectors, test selectors, generated selectors, candidate status. The report
|
||||
finds named fields with `toml`/`yaml`/`json` tags in `internal/config`, then
|
||||
counts selectors with the same **spelling**. It is deliberately fast and not
|
||||
type-aware.
|
||||
|
||||
Only `candidate-no-selector-outside-config` is a signal.
|
||||
`candidate-no-entrypoint-selector` fires for ~180 of 196 rows because the
|
||||
script looks for selectors only in `cmd/`, and most fields are read from the
|
||||
composition root under `internal/app/archied`. Even the signal row has false
|
||||
positives: a field consumed by **spelling** rather than by a Go selector
|
||||
(`LegacyEnabled` via the reload allowlist map, `ReloadStatus.*` via JSON
|
||||
marshalling) reports zero. Confirm each candidate by hand before calling a
|
||||
field dead.
|
||||
|
||||
For every candidate: run `gopls references -d` on the exact field identifier;
|
||||
trace decode → default → validation → normalization/copy → composition-root read
|
||||
→ concrete component → observable behavior.
|
||||
|
||||
### Measure delivery and hygiene drift
|
||||
|
||||
```sh
|
||||
"$skill/scripts/delivery-snapshot.sh" >"$evidence_dir/delivery.tsv"
|
||||
```
|
||||
|
||||
Read: `SURFACE axis scope literal_count` as literal text evidence;
|
||||
`HYGIENE metric count` as tracked-path candidates; `MODULE path` as discovered
|
||||
Go module boundaries. The snapshot compares Task, GitHub CI, and
|
||||
composition-root anchors under `internal/app/archied`.
|
||||
|
||||
Composition-root anchors must name the file that actually does the wiring.
|
||||
`cmd/archied/main.go` is a thin dispatcher that routes to
|
||||
`internal/app/archied`; anchoring on it yields a silent `0` for every row,
|
||||
which reads as "no composition root" rather than "wrong file". A zero here is
|
||||
evidence about the anchor, not about production.
|
||||
|
||||
Inspect hygiene candidates directly:
|
||||
|
||||
```sh
|
||||
git ls-files |
|
||||
rg '(^|/)(node_modules|bin|dist|\.gotmp)(/|$)|\.(exe|test|out)$'
|
||||
git ls-files -s | awk '$1=="120000" {print}'
|
||||
```
|
||||
|
||||
## Investigate duplication and hidden dead paths
|
||||
|
||||
```sh
|
||||
golangci-lint run --enable-only=dupl ./internal/...
|
||||
```
|
||||
|
||||
```sh
|
||||
staticcheck -checks=U1000 ./internal/...
|
||||
```
|
||||
|
||||
On 2026-09-18, the focused `dupl` command reported zero issues. Two code paths
|
||||
can implement the same responsibility with different syntax.
|
||||
|
||||
For every candidate: name the externally visible operation; search all
|
||||
entrypoints and modes; use `gopls call_hierarchy`, `gopls references -d`, and
|
||||
AST construction scan; check interfaces, registrations, reflection, build tags,
|
||||
OS files, and wire names; identify what a new feature supersedes; record
|
||||
production-only, test-only, compatibility, generated, and unreachable paths
|
||||
separately.
|
||||
|
||||
As of 2026-09-18, `Taskfile.yml` defines no `deadcode` task and `go tool` lists
|
||||
no dead-code analyzer.
|
||||
|
||||
## Collect test, race, coverage, and runtime evidence
|
||||
|
||||
```sh
|
||||
go test ./internal/store -count=1 -coverprofile=/tmp/archie-store.cover
|
||||
go tool cover -func=/tmp/archie-store.cover
|
||||
go test -race ./internal/store -count=1
|
||||
```
|
||||
|
||||
As of 2026-09-18, the package reported 78.6% statement coverage and passed its
|
||||
race run.
|
||||
|
||||
```sh
|
||||
docker compose logs nats >"$evidence_dir/nats.log"
|
||||
journalctl --user -u archied >"$evidence_dir/archied.log"
|
||||
curl -fsS http://localhost:8222/healthz >"$evidence_dir/nats-health.txt"
|
||||
```
|
||||
|
||||
Run only when local Compose stack is in scope.
|
||||
|
||||
## Compare before and after
|
||||
|
||||
Predict exact deltas before changing code. Collect a second snapshot with the
|
||||
same script revision, flags, environment, and toolchain:
|
||||
|
||||
```sh
|
||||
after_dir=/tmp/archie-diagnostics-after
|
||||
mkdir -p "$after_dir"
|
||||
go run "$skill/scripts/source-metrics.go" -root . >"$after_dir/source.tsv"
|
||||
go run "$skill/scripts/config-use-candidates.go" -root . >"$after_dir/config.tsv"
|
||||
"$skill/scripts/package-shape.sh" . >"$after_dir/packages-root.tsv"
|
||||
"$skill/scripts/delivery-snapshot.sh" >"$after_dir/delivery.tsv"
|
||||
|
||||
diff -u "$evidence_dir/source.tsv" "$after_dir/source.tsv"
|
||||
diff -u "$evidence_dir/config.tsv" "$after_dir/config.tsv"
|
||||
diff -u "$evidence_dir/packages-root.tsv" "$after_dir/packages-root.tsv"
|
||||
diff -u "$evidence_dir/delivery.tsv" "$after_dir/delivery.tsv"
|
||||
```
|
||||
|
||||
If output differs from prediction: confirm checkout, dirty state, script
|
||||
revision, flags, toolchain; explain each delta; branch to semantic discovery
|
||||
when a count cannot explain behavior. Reject a "better" metric that moved
|
||||
duplication, hid a path, or weakened a gate.
|
||||
|
||||
## Dated current snapshot
|
||||
|
||||
The bundled scripts measured this checkout on 2026-09-18 (HEAD `2e1e1549`).
|
||||
These are post-fix numbers: earlier runs of the same scripts reported roughly
|
||||
3x these file and line counts because they walked `.worktrees/`.
|
||||
|
||||
| Observation | Unstable value |
|
||||
|---|---:|
|
||||
| Root production/test/generated Go files | 408 / 402 / 9 |
|
||||
| Root production/test/generated physical lines | 74,752 / 95,264 / 12,774 |
|
||||
| `internal/app/archied.Run` body span / approximate complexity | 97 / 19 |
|
||||
| Root internal packages / direct internal edges | 110 / 316 |
|
||||
| Tagged config field rows | 194 |
|
||||
| Tracked paths / tracked `node_modules` paths / tracked symlinks | 1,088 / 0 / 1 |
|
||||
| `.dockerignore` present | 1 |
|
||||
|
||||
`source-metrics.go` and `git ls-files` reconcile here: 408 + 9 generated
|
||||
production files and 402 test files, plus the `tools` module's 5 / 2 / 0,
|
||||
against 422 non-test and 403 test tracked files. The single extra file is an
|
||||
untracked probe under `.local/issue-tracker/probes/`.
|
||||
|
||||
The scripts count themselves: the skill's own Go files contribute 640 of those
|
||||
production lines. Editing a bundled script therefore moves
|
||||
`production_physical_lines` on its own, so re-baseline after any script change
|
||||
rather than reading the delta as a change in the product code.
|
||||
|
||||
The delivery snapshot found no Taskfile literals for race; docs now has 6 and
|
||||
the `tools` module 7, both grown by wiring `task docs:check` into the gate;
|
||||
GitHub `go gate` 4 and container publish 3; and non-zero literals for all five
|
||||
composition-root anchors under `internal/app/archied`.
|
||||
|
||||
The focused test
|
||||
`go test ./internal/skillscript -run '^TestRunWrapsExternalCommand$' -count=1 -v`
|
||||
failed on 2026-07-28 with `Run() = "\n"` and **passes** as of 2026-09-16.
|
||||
@@ -1,4 +0,0 @@
|
||||
interface:
|
||||
display_name: "Archie Diagnostics and Tooling"
|
||||
short_description: "Measure maintainability, wiring, and delivery drift"
|
||||
default_prompt: "Use $archie-diagnostics-and-tooling to collect a dated, reproducible evidence baseline before changing Archie."
|
||||
@@ -1,283 +0,0 @@
|
||||
// Command config-use-candidates reports syntax-level selector evidence for
|
||||
// tagged fields declared by internal/config. Results are candidates, not proof
|
||||
// that a field is wired, live, or dead.
|
||||
package main
|
||||
|
||||
import (
|
||||
"flag"
|
||||
"fmt"
|
||||
"go/ast"
|
||||
"go/parser"
|
||||
"go/token"
|
||||
"io/fs"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"reflect"
|
||||
"sort"
|
||||
"strconv"
|
||||
"strings"
|
||||
)
|
||||
|
||||
type fieldDefinition struct {
|
||||
path string
|
||||
line int
|
||||
typeName string
|
||||
fieldName string
|
||||
tags string
|
||||
duplicates int
|
||||
}
|
||||
|
||||
type referenceCounts struct {
|
||||
config int
|
||||
entrypoint int
|
||||
production int
|
||||
test int
|
||||
generated int
|
||||
}
|
||||
|
||||
func main() {
|
||||
root := flag.String("root", ".", "repository root to inspect")
|
||||
flag.Parse()
|
||||
|
||||
absoluteRoot, err := filepath.Abs(*root)
|
||||
if err != nil {
|
||||
fail(2, "resolve root: %v", err)
|
||||
}
|
||||
info, err := os.Stat(absoluteRoot)
|
||||
if err != nil {
|
||||
fail(2, "inspect root: %v", err)
|
||||
}
|
||||
if !info.IsDir() {
|
||||
fail(2, "root is not a directory: %s", absoluteRoot)
|
||||
}
|
||||
|
||||
fset := token.NewFileSet()
|
||||
fields, err := readFieldDefinitions(absoluteRoot, fset)
|
||||
if err != nil {
|
||||
fail(1, "%v", err)
|
||||
}
|
||||
if len(fields) == 0 {
|
||||
fail(1, "no tagged fields found under internal/config")
|
||||
}
|
||||
|
||||
nameCounts := map[string]int{}
|
||||
for _, field := range fields {
|
||||
nameCounts[field.fieldName]++
|
||||
}
|
||||
for index := range fields {
|
||||
fields[index].duplicates = nameCounts[fields[index].fieldName]
|
||||
}
|
||||
|
||||
references := map[string]*referenceCounts{}
|
||||
for name := range nameCounts {
|
||||
references[name] = &referenceCounts{}
|
||||
}
|
||||
if err := countSelectors(absoluteRoot, fset, references); err != nil {
|
||||
fail(1, "%v", err)
|
||||
}
|
||||
|
||||
sort.Slice(fields, func(i, j int) bool {
|
||||
if fields[i].typeName != fields[j].typeName {
|
||||
return fields[i].typeName < fields[j].typeName
|
||||
}
|
||||
if fields[i].fieldName != fields[j].fieldName {
|
||||
return fields[i].fieldName < fields[j].fieldName
|
||||
}
|
||||
if fields[i].path != fields[j].path {
|
||||
return fields[i].path < fields[j].path
|
||||
}
|
||||
return fields[i].line < fields[j].line
|
||||
})
|
||||
|
||||
fmt.Println("META\tschema\tarchie-config-use-candidates/v1")
|
||||
fmt.Println("META\tmeaning\tselector-name counts are heuristic candidates; confirm exact fields with gopls references and production composition")
|
||||
for _, field := range fields {
|
||||
count := references[field.fieldName]
|
||||
status := "candidate-selector-seen-in-entrypoint"
|
||||
switch {
|
||||
case count.production == 0 && count.entrypoint == 0:
|
||||
status = "candidate-no-selector-outside-config"
|
||||
case count.entrypoint == 0:
|
||||
status = "candidate-no-entrypoint-selector"
|
||||
}
|
||||
fmt.Printf(
|
||||
"CONFIG_FIELD\t%s\t%d\t%s.%s\t%s\t%d\t%d\t%d\t%d\t%d\t%d\t%s\n",
|
||||
field.path,
|
||||
field.line,
|
||||
field.typeName,
|
||||
field.fieldName,
|
||||
field.tags,
|
||||
field.duplicates,
|
||||
count.config,
|
||||
count.entrypoint,
|
||||
count.production,
|
||||
count.test,
|
||||
count.generated,
|
||||
status,
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
func readFieldDefinitions(root string, fset *token.FileSet) ([]fieldDefinition, error) {
|
||||
configDir := filepath.Join(root, "internal", "config")
|
||||
info, err := os.Stat(configDir)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("inspect internal/config: %w", err)
|
||||
}
|
||||
if !info.IsDir() {
|
||||
return nil, fmt.Errorf("internal/config is not a directory")
|
||||
}
|
||||
|
||||
var fields []fieldDefinition
|
||||
err = filepath.WalkDir(configDir, func(path string, entry fs.DirEntry, walkErr error) error {
|
||||
if walkErr != nil {
|
||||
return walkErr
|
||||
}
|
||||
if entry.IsDir() || filepath.Ext(entry.Name()) != ".go" || strings.HasSuffix(entry.Name(), "_test.go") {
|
||||
return nil
|
||||
}
|
||||
body, err := os.ReadFile(path)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
file, err := parser.ParseFile(fset, path, body, parser.ParseComments)
|
||||
if err != nil {
|
||||
return fmt.Errorf("parse %s: %w", path, err)
|
||||
}
|
||||
relative, err := filepath.Rel(root, path)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
relative = filepath.ToSlash(relative)
|
||||
for _, declaration := range file.Decls {
|
||||
general, ok := declaration.(*ast.GenDecl)
|
||||
if !ok || general.Tok != token.TYPE {
|
||||
continue
|
||||
}
|
||||
for _, specification := range general.Specs {
|
||||
typeSpec, ok := specification.(*ast.TypeSpec)
|
||||
if !ok {
|
||||
continue
|
||||
}
|
||||
structType, ok := typeSpec.Type.(*ast.StructType)
|
||||
if !ok {
|
||||
continue
|
||||
}
|
||||
for _, field := range structType.Fields.List {
|
||||
tags, ok := configTags(field.Tag)
|
||||
if !ok {
|
||||
continue
|
||||
}
|
||||
for _, name := range field.Names {
|
||||
fields = append(fields, fieldDefinition{
|
||||
path: relative,
|
||||
line: fset.Position(name.Pos()).Line,
|
||||
typeName: typeSpec.Name.Name,
|
||||
fieldName: name.Name,
|
||||
tags: tags,
|
||||
})
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
return nil
|
||||
})
|
||||
return fields, err
|
||||
}
|
||||
|
||||
func configTags(literal *ast.BasicLit) (string, bool) {
|
||||
if literal == nil {
|
||||
return "", false
|
||||
}
|
||||
raw, err := strconv.Unquote(literal.Value)
|
||||
if err != nil {
|
||||
return "", false
|
||||
}
|
||||
tag := reflect.StructTag(raw)
|
||||
var parts []string
|
||||
for _, key := range []string{"toml", "yaml", "json"} {
|
||||
value, ok := tag.Lookup(key)
|
||||
if !ok {
|
||||
continue
|
||||
}
|
||||
parts = append(parts, key+"="+value)
|
||||
}
|
||||
return strings.Join(parts, ";"), len(parts) > 0
|
||||
}
|
||||
|
||||
func countSelectors(root string, fset *token.FileSet, references map[string]*referenceCounts) error {
|
||||
return filepath.WalkDir(root, func(path string, entry fs.DirEntry, walkErr error) error {
|
||||
if walkErr != nil {
|
||||
return walkErr
|
||||
}
|
||||
relative, err := filepath.Rel(root, path)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
relative = filepath.ToSlash(relative)
|
||||
if entry.IsDir() {
|
||||
if relative != "." && excludedDirectory(relative, entry.Name()) {
|
||||
return filepath.SkipDir
|
||||
}
|
||||
return nil
|
||||
}
|
||||
if filepath.Ext(entry.Name()) != ".go" {
|
||||
return nil
|
||||
}
|
||||
body, err := os.ReadFile(path)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
file, err := parser.ParseFile(fset, path, body, parser.ParseComments)
|
||||
if err != nil {
|
||||
return fmt.Errorf("parse %s: %w", relative, err)
|
||||
}
|
||||
generated := ast.IsGenerated(file)
|
||||
isTest := strings.HasSuffix(entry.Name(), "_test.go")
|
||||
inConfig := strings.HasPrefix(relative, "internal/config/")
|
||||
inEntrypoint := strings.HasPrefix(relative, "cmd/")
|
||||
|
||||
ast.Inspect(file, func(node ast.Node) bool {
|
||||
selector, ok := node.(*ast.SelectorExpr)
|
||||
if !ok {
|
||||
return true
|
||||
}
|
||||
count := references[selector.Sel.Name]
|
||||
if count == nil {
|
||||
return true
|
||||
}
|
||||
switch {
|
||||
case generated:
|
||||
count.generated++
|
||||
case isTest:
|
||||
count.test++
|
||||
case inConfig:
|
||||
count.config++
|
||||
case inEntrypoint:
|
||||
count.entrypoint++
|
||||
default:
|
||||
count.production++
|
||||
}
|
||||
return true
|
||||
})
|
||||
return nil
|
||||
})
|
||||
}
|
||||
|
||||
// excludedDirectory reports whether a walked directory is outside the module.
|
||||
//
|
||||
// ".worktrees" holds live git worktrees of this same repository, nested inside
|
||||
// the root. countSelectors walks the whole root, so without this every selector
|
||||
// count is multiplied by the number of checkout worktrees.
|
||||
func excludedDirectory(_, name string) bool {
|
||||
switch name {
|
||||
case ".git", ".claude", ".references", "node_modules", "vendor", ".gotmp", ".worktrees":
|
||||
return true
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
func fail(code int, format string, arguments ...any) {
|
||||
fmt.Fprintf(os.Stderr, "config-use-candidates: "+format+"\n", arguments...)
|
||||
os.Exit(code)
|
||||
}
|
||||
@@ -1,95 +0,0 @@
|
||||
#!/bin/sh
|
||||
set -eu
|
||||
|
||||
if [ "$#" -ne 0 ]; then
|
||||
printf '%s\n' "usage: delivery-snapshot.sh" >&2
|
||||
exit 2
|
||||
fi
|
||||
|
||||
for tool in git rg sed wc; do
|
||||
command -v "$tool" >/dev/null 2>&1 || {
|
||||
printf 'delivery-snapshot: %s is required\n' "$tool" >&2
|
||||
exit 127
|
||||
}
|
||||
done
|
||||
|
||||
script_dir=$(CDPATH= cd "$(dirname "$0")" && pwd)
|
||||
repo_root=$(CDPATH= cd "$script_dir/../../../.." && pwd)
|
||||
if [ ! -f "$repo_root/go.mod" ] || [ ! -f "$repo_root/Taskfile.yml" ]; then
|
||||
printf 'delivery-snapshot: expected Archie repository root at %s\n' "$repo_root" >&2
|
||||
exit 2
|
||||
fi
|
||||
|
||||
temporary=$(mktemp -d "${TMPDIR:-/tmp}/archie-delivery-snapshot.XXXXXX")
|
||||
trap 'rm -rf "$temporary"' EXIT HUP INT TERM
|
||||
cd "$repo_root"
|
||||
|
||||
printf '%s\n' "META schema archie-delivery-snapshot/v1"
|
||||
|
||||
scan_literal() {
|
||||
axis=$1
|
||||
scope=$2
|
||||
pattern=$3
|
||||
shift 3
|
||||
result="$temporary/$axis"
|
||||
if rg -n --no-heading --color never -e "$pattern" "$@" >"$result"; then
|
||||
:
|
||||
else
|
||||
status=$?
|
||||
if [ "$status" -ne 1 ]; then
|
||||
printf 'delivery-snapshot: scan failed for %s\n' "$axis" >&2
|
||||
exit "$status"
|
||||
fi
|
||||
fi
|
||||
count=$(wc -l <"$result" | sed 's/[[:space:]]//g')
|
||||
printf 'SURFACE\t%s\t%s\t%s\n' "$axis" "$scope" "$count"
|
||||
}
|
||||
|
||||
scan_literal task_format taskfile 'gofumpt[[:space:]]+-w|go fix' Taskfile.yml
|
||||
scan_literal task_vet taskfile 'go vet' Taskfile.yml
|
||||
scan_literal task_build taskfile 'go build|task:[[:space:]]+build' Taskfile.yml
|
||||
scan_literal task_test taskfile 'go test|task:[[:space:]]+test' Taskfile.yml
|
||||
scan_literal task_lint taskfile 'golangci-lint|task:[[:space:]]+lint' Taskfile.yml
|
||||
scan_literal task_race taskfile 'go test[^#\n]*-race|-race[^#\n]*go test' Taskfile.yml
|
||||
scan_literal task_tools_module taskfile 'go -C tools|cd tools|task:[[:space:]]+tools' Taskfile.yml
|
||||
scan_literal task_docs taskfile 'docsgen|docs:generate|docs:check' Taskfile.yml
|
||||
|
||||
# One CI surface: .github/workflows. The Gitea workflow was dropped in dd9bddc2
|
||||
# ("ci: build and push images to GHCR, drop the Gitea workflow"), so scanning
|
||||
# .gitea/workflows aborted the whole snapshot under `set -eu`.
|
||||
scan_literal github_go_gate github-workflows 'go test|go vet|go build|golangci-lint|task[[:space:]]+check' .github/workflows
|
||||
scan_literal github_container_publish github-workflows 'docker build|docker push|docker/build-push-action|docker login' .github/workflows
|
||||
|
||||
# Composition root. cmd/archied/main.go is now a ~30-line dispatcher that only
|
||||
# routes to internal/app/archied, so anchoring on it reported a silent zero for
|
||||
# every row below -- which reads as "no composition root" rather than "wrong
|
||||
# file". The wiring lives in internal/app/archied.
|
||||
scan_literal production_config_resolve composition-root 'configuration\.New\(' internal/app/archied
|
||||
scan_literal production_config_load composition-root 'loadConfig\(|loadRuntimeConfig\(' internal/app/archied
|
||||
scan_literal production_sqlite_store composition-root 'openProductionTaskStore\(|openStateStore\(' internal/app/archied
|
||||
scan_literal production_daemon composition-root '&daemon\.Daemon\{' internal/app/archied
|
||||
scan_literal production_rpc_servers composition-root 'registerTaskRPCServers\(' internal/app/archied
|
||||
|
||||
git ls-files >"$temporary/tracked"
|
||||
tracked_total=$(wc -l <"$temporary/tracked" | sed 's/[[:space:]]//g')
|
||||
tracked_node_modules=$(rg -c '(^|/)node_modules(/|$)' "$temporary/tracked" || true)
|
||||
tracked_artifacts=$(rg -c '(^|/)(node_modules|bin|dist|\.gotmp)(/|$)|\.(exe|test|out)$' "$temporary/tracked" || true)
|
||||
tracked_symlinks=$(git ls-files -s | awk '$1 == "120000" {count++} END {print count + 0}')
|
||||
|
||||
printf 'HYGIENE\ttracked_paths\t%s\n' "$tracked_total"
|
||||
printf 'HYGIENE\ttracked_node_modules_paths\t%s\n' "${tracked_node_modules:-0}"
|
||||
printf 'HYGIENE\ttracked_artifact_candidates\t%s\n' "${tracked_artifacts:-0}"
|
||||
printf 'HYGIENE\ttracked_symlinks\t%s\n' "$tracked_symlinks"
|
||||
if [ -f .dockerignore ]; then
|
||||
printf '%s\n' "HYGIENE dockerignore_present 1"
|
||||
else
|
||||
printf '%s\n' "HYGIENE dockerignore_present 0"
|
||||
fi
|
||||
|
||||
find . \
|
||||
\( -path './.git' -o -path './.claude' -o -path './.references' -o -name node_modules -o -name .worktrees \) -prune -o \
|
||||
-name go.mod -print |
|
||||
LC_ALL=C sort |
|
||||
while IFS= read -r module; do
|
||||
printf 'MODULE\t%s\n' "$module"
|
||||
done
|
||||
@@ -1,86 +0,0 @@
|
||||
#!/bin/sh
|
||||
set -eu
|
||||
|
||||
if [ "$#" -gt 1 ]; then
|
||||
printf '%s\n' "usage: $0 [module-directory-relative-to-repo]" >&2
|
||||
exit 2
|
||||
fi
|
||||
|
||||
command -v go >/dev/null 2>&1 || {
|
||||
printf '%s\n' "package-shape: go is required" >&2
|
||||
exit 127
|
||||
}
|
||||
command -v awk >/dev/null 2>&1 || {
|
||||
printf '%s\n' "package-shape: awk is required" >&2
|
||||
exit 127
|
||||
}
|
||||
|
||||
script_dir=$(CDPATH= cd "$(dirname "$0")" && pwd)
|
||||
repo_root=$(CDPATH= cd "$script_dir/../../../.." && pwd)
|
||||
module_relative=${1:-.}
|
||||
module_root="$repo_root/$module_relative"
|
||||
edge_helper="$repo_root/.agents/skills/archie-codebase-discovery/scripts/package-edges.sh"
|
||||
|
||||
if [ ! -f "$module_root/go.mod" ]; then
|
||||
printf 'package-shape: no go.mod at %s\n' "$module_root" >&2
|
||||
exit 2
|
||||
fi
|
||||
if [ ! -x "$edge_helper" ]; then
|
||||
printf 'package-shape: required sibling helper is missing or not executable: %s\n' "$edge_helper" >&2
|
||||
exit 2
|
||||
fi
|
||||
|
||||
temporary=$(mktemp -d "${TMPDIR:-/tmp}/archie-package-shape.XXXXXX")
|
||||
trap 'rm -rf "$temporary"' EXIT HUP INT TERM
|
||||
mkdir -p "$temporary/cache" "$temporary/build-tmp"
|
||||
|
||||
export GOCACHE="$temporary/cache"
|
||||
export GOTMPDIR="$temporary/build-tmp"
|
||||
export GOPROXY=off
|
||||
export GOFLAGS="-mod=readonly -buildvcs=false"
|
||||
export ARCHIE_DISCOVERY_CACHE="$temporary/discovery"
|
||||
|
||||
(
|
||||
cd "$module_root"
|
||||
go list ./... | LC_ALL=C sort
|
||||
) >"$temporary/packages"
|
||||
if (
|
||||
cd "$module_root"
|
||||
"$edge_helper" ./...
|
||||
) >"$temporary/edges" 2>"$temporary/edge-stderr"; then
|
||||
# The sibling helper sets its own GOFLAGS and can trigger a harmless,
|
||||
# nondeterministic temporary filename when GOMODCACHE is read-only.
|
||||
# Preserve the warning while normalizing only that filename suffix.
|
||||
sed 's/\.info[0-9][0-9]*\.tmp/.info<TEMP>.tmp/' "$temporary/edge-stderr" >&2
|
||||
else
|
||||
status=$?
|
||||
cat "$temporary/edge-stderr" >&2
|
||||
exit "$status"
|
||||
fi
|
||||
(
|
||||
cd "$module_root"
|
||||
go list -m -f '{{.Path}}'
|
||||
) >"$temporary/module"
|
||||
|
||||
module_path=$(sed -n '1p' "$temporary/module")
|
||||
printf '%s\n' "META schema archie-package-shape/v1"
|
||||
printf 'META\tmodule\t%s\n' "$module_path"
|
||||
|
||||
awk -F ' ' '
|
||||
NR == FNR {
|
||||
packages[$0] = 1
|
||||
next
|
||||
}
|
||||
{
|
||||
split($0, edge, " -> ")
|
||||
outbound[edge[1]]++
|
||||
inbound[edge[2]]++
|
||||
}
|
||||
END {
|
||||
for (packageName in packages) {
|
||||
printf "PACKAGE\t%s\t%d\t%d\n", packageName, inbound[packageName] + 0, outbound[packageName] + 0
|
||||
}
|
||||
}
|
||||
' "$temporary/packages" "$temporary/edges" | LC_ALL=C sort
|
||||
|
||||
awk '{printf "EDGE\t%s\n", $0}' "$temporary/edges"
|
||||
@@ -1,357 +0,0 @@
|
||||
// Command source-metrics emits deterministic, syntax-derived Go source metrics.
|
||||
// It never writes to the inspected tree and uses only the Go standard library.
|
||||
package main
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"flag"
|
||||
"fmt"
|
||||
"go/ast"
|
||||
"go/parser"
|
||||
"go/token"
|
||||
"io/fs"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"sort"
|
||||
"strings"
|
||||
)
|
||||
|
||||
type counts struct {
|
||||
productionFiles int
|
||||
testFiles int
|
||||
generatedFiles int
|
||||
productionLines int
|
||||
testLines int
|
||||
generatedLines int
|
||||
functions int
|
||||
methods int
|
||||
}
|
||||
|
||||
type packageCounts struct {
|
||||
module string
|
||||
path string
|
||||
productionFiles int
|
||||
testFiles int
|
||||
generatedFiles int
|
||||
productionLines int
|
||||
testLines int
|
||||
generatedLines int
|
||||
}
|
||||
|
||||
type hotspot struct {
|
||||
module string
|
||||
path string
|
||||
line int
|
||||
symbol string
|
||||
spanLines int
|
||||
statements int
|
||||
complexity int
|
||||
}
|
||||
|
||||
func main() {
|
||||
root := flag.String("root", ".", "repository root to inspect")
|
||||
top := flag.Int("top", 30, "maximum hotspot rows; zero means all")
|
||||
largeLines := flag.Int("large-lines", 80, "minimum body span for a hotspot")
|
||||
complexity := flag.Int("complexity", 15, "minimum approximate syntactic complexity for a hotspot")
|
||||
includeTests := flag.Bool("include-test-hotspots", false, "include test functions in hotspot rows")
|
||||
flag.Parse()
|
||||
|
||||
if *top < 0 || *largeLines < 1 || *complexity < 1 {
|
||||
fail(2, "top must be non-negative; thresholds must be positive")
|
||||
}
|
||||
|
||||
absoluteRoot, err := filepath.Abs(*root)
|
||||
if err != nil {
|
||||
fail(2, "resolve root: %v", err)
|
||||
}
|
||||
info, err := os.Stat(absoluteRoot)
|
||||
if err != nil {
|
||||
fail(2, "inspect root: %v", err)
|
||||
}
|
||||
if !info.IsDir() {
|
||||
fail(2, "root is not a directory: %s", absoluteRoot)
|
||||
}
|
||||
|
||||
modules := map[string]*counts{}
|
||||
packages := map[string]*packageCounts{}
|
||||
var hotspots []hotspot
|
||||
fset := token.NewFileSet()
|
||||
|
||||
err = filepath.WalkDir(absoluteRoot, func(path string, entry fs.DirEntry, walkErr error) error {
|
||||
if walkErr != nil {
|
||||
return walkErr
|
||||
}
|
||||
relative, err := filepath.Rel(absoluteRoot, path)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
relative = filepath.ToSlash(relative)
|
||||
if entry.IsDir() {
|
||||
if relative != "." && excludedDirectory(relative, entry.Name()) {
|
||||
return filepath.SkipDir
|
||||
}
|
||||
return nil
|
||||
}
|
||||
if filepath.Ext(entry.Name()) != ".go" {
|
||||
return nil
|
||||
}
|
||||
|
||||
body, err := os.ReadFile(path)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
file, err := parser.ParseFile(fset, path, body, parser.ParseComments)
|
||||
if err != nil {
|
||||
return fmt.Errorf("parse %s: %w", relative, err)
|
||||
}
|
||||
|
||||
module := moduleFor(relative)
|
||||
moduleCounts := modules[module]
|
||||
if moduleCounts == nil {
|
||||
moduleCounts = &counts{}
|
||||
modules[module] = moduleCounts
|
||||
}
|
||||
dir := filepath.ToSlash(filepath.Dir(relative))
|
||||
packageKey := module + "\x00" + dir
|
||||
pkg := packages[packageKey]
|
||||
if pkg == nil {
|
||||
pkg = &packageCounts{module: module, path: dir}
|
||||
packages[packageKey] = pkg
|
||||
}
|
||||
|
||||
lines := physicalLines(body)
|
||||
generated := ast.IsGenerated(file)
|
||||
isTest := strings.HasSuffix(entry.Name(), "_test.go")
|
||||
switch {
|
||||
case generated:
|
||||
moduleCounts.generatedFiles++
|
||||
moduleCounts.generatedLines += lines
|
||||
pkg.generatedFiles++
|
||||
pkg.generatedLines += lines
|
||||
case isTest:
|
||||
moduleCounts.testFiles++
|
||||
moduleCounts.testLines += lines
|
||||
pkg.testFiles++
|
||||
pkg.testLines += lines
|
||||
default:
|
||||
moduleCounts.productionFiles++
|
||||
moduleCounts.productionLines += lines
|
||||
pkg.productionFiles++
|
||||
pkg.productionLines += lines
|
||||
}
|
||||
|
||||
for _, declaration := range file.Decls {
|
||||
function, ok := declaration.(*ast.FuncDecl)
|
||||
if !ok || function.Body == nil {
|
||||
continue
|
||||
}
|
||||
if function.Recv == nil {
|
||||
moduleCounts.functions++
|
||||
} else {
|
||||
moduleCounts.methods++
|
||||
}
|
||||
if generated || (isTest && !*includeTests) {
|
||||
continue
|
||||
}
|
||||
|
||||
start := fset.Position(function.Body.Lbrace).Line
|
||||
end := fset.Position(function.Body.Rbrace).Line
|
||||
row := hotspot{
|
||||
module: module,
|
||||
path: relative,
|
||||
line: fset.Position(function.Pos()).Line,
|
||||
symbol: symbolName(function),
|
||||
spanLines: end - start + 1,
|
||||
statements: statementNodes(function.Body),
|
||||
complexity: syntacticComplexity(function.Body),
|
||||
}
|
||||
if row.spanLines >= *largeLines || row.complexity >= *complexity {
|
||||
hotspots = append(hotspots, row)
|
||||
}
|
||||
}
|
||||
return nil
|
||||
})
|
||||
if err != nil {
|
||||
fail(1, "%v", err)
|
||||
}
|
||||
|
||||
fmt.Println("META\tschema\tarchie-source-metrics/v1")
|
||||
fmt.Printf("META\tthresholds\tlarge_lines=%d;syntactic_complexity=%d;top=%d\n", *largeLines, *complexity, *top)
|
||||
|
||||
moduleNames := sortedKeys(modules)
|
||||
for _, module := range moduleNames {
|
||||
value := modules[module]
|
||||
emitMetric(module, "production_go_files", value.productionFiles)
|
||||
emitMetric(module, "test_go_files", value.testFiles)
|
||||
emitMetric(module, "generated_go_files", value.generatedFiles)
|
||||
emitMetric(module, "production_physical_lines", value.productionLines)
|
||||
emitMetric(module, "test_physical_lines", value.testLines)
|
||||
emitMetric(module, "generated_physical_lines", value.generatedLines)
|
||||
emitMetric(module, "functions", value.functions)
|
||||
emitMetric(module, "methods", value.methods)
|
||||
}
|
||||
|
||||
packageRows := make([]*packageCounts, 0, len(packages))
|
||||
for _, row := range packages {
|
||||
packageRows = append(packageRows, row)
|
||||
}
|
||||
sort.Slice(packageRows, func(i, j int) bool {
|
||||
if packageRows[i].module != packageRows[j].module {
|
||||
return packageRows[i].module < packageRows[j].module
|
||||
}
|
||||
return packageRows[i].path < packageRows[j].path
|
||||
})
|
||||
for _, row := range packageRows {
|
||||
fmt.Printf(
|
||||
"PACKAGE\t%s\t%s\t%d\t%d\t%d\t%d\t%d\t%d\n",
|
||||
row.module,
|
||||
row.path,
|
||||
row.productionFiles,
|
||||
row.testFiles,
|
||||
row.generatedFiles,
|
||||
row.productionLines,
|
||||
row.testLines,
|
||||
row.generatedLines,
|
||||
)
|
||||
}
|
||||
|
||||
sort.Slice(hotspots, func(i, j int) bool {
|
||||
if hotspots[i].spanLines != hotspots[j].spanLines {
|
||||
return hotspots[i].spanLines > hotspots[j].spanLines
|
||||
}
|
||||
if hotspots[i].complexity != hotspots[j].complexity {
|
||||
return hotspots[i].complexity > hotspots[j].complexity
|
||||
}
|
||||
if hotspots[i].path != hotspots[j].path {
|
||||
return hotspots[i].path < hotspots[j].path
|
||||
}
|
||||
if hotspots[i].line != hotspots[j].line {
|
||||
return hotspots[i].line < hotspots[j].line
|
||||
}
|
||||
return hotspots[i].symbol < hotspots[j].symbol
|
||||
})
|
||||
if *top > 0 && len(hotspots) > *top {
|
||||
hotspots = hotspots[:*top]
|
||||
}
|
||||
for _, row := range hotspots {
|
||||
fmt.Printf(
|
||||
"HOTSPOT\t%s\t%s\t%d\t%s\t%d\t%d\t%d\n",
|
||||
row.module,
|
||||
row.path,
|
||||
row.line,
|
||||
row.symbol,
|
||||
row.spanLines,
|
||||
row.statements,
|
||||
row.complexity,
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
// excludedDirectory reports whether a walked directory is outside the module.
|
||||
//
|
||||
// ".worktrees" holds live git worktrees of this same repository, nested inside
|
||||
// the root. Each is a near-complete copy of the module, so walking them
|
||||
// multiplies every count by the number of checkout worktrees and floods the
|
||||
// HOTSPOT and PACKAGE rows with duplicates of the same declarations.
|
||||
func excludedDirectory(_, name string) bool {
|
||||
switch name {
|
||||
case ".git", ".claude", ".references", "node_modules", "vendor", ".gotmp", ".worktrees":
|
||||
return true
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
func moduleFor(relative string) string {
|
||||
if relative == "tools" || strings.HasPrefix(relative, "tools/") {
|
||||
return "tools"
|
||||
}
|
||||
return "root"
|
||||
}
|
||||
|
||||
func physicalLines(body []byte) int {
|
||||
if len(body) == 0 {
|
||||
return 0
|
||||
}
|
||||
lines := bytes.Count(body, []byte{'\n'})
|
||||
if body[len(body)-1] != '\n' {
|
||||
lines++
|
||||
}
|
||||
return lines
|
||||
}
|
||||
|
||||
func symbolName(function *ast.FuncDecl) string {
|
||||
if function.Recv == nil || len(function.Recv.List) == 0 {
|
||||
return function.Name.Name
|
||||
}
|
||||
return receiverName(function.Recv.List[0].Type) + "." + function.Name.Name
|
||||
}
|
||||
|
||||
func receiverName(expression ast.Expr) string {
|
||||
switch value := expression.(type) {
|
||||
case *ast.Ident:
|
||||
return value.Name
|
||||
case *ast.StarExpr:
|
||||
return "*" + receiverName(value.X)
|
||||
case *ast.IndexExpr:
|
||||
return receiverName(value.X)
|
||||
case *ast.IndexListExpr:
|
||||
return receiverName(value.X)
|
||||
default:
|
||||
return "receiver"
|
||||
}
|
||||
}
|
||||
|
||||
func statementNodes(node ast.Node) int {
|
||||
count := 0
|
||||
ast.Inspect(node, func(candidate ast.Node) bool {
|
||||
statement, ok := candidate.(ast.Stmt)
|
||||
if !ok {
|
||||
return true
|
||||
}
|
||||
switch statement.(type) {
|
||||
case *ast.BlockStmt, *ast.EmptyStmt:
|
||||
default:
|
||||
count++
|
||||
}
|
||||
return true
|
||||
})
|
||||
return count
|
||||
}
|
||||
|
||||
func syntacticComplexity(node ast.Node) int {
|
||||
value := 1
|
||||
ast.Inspect(node, func(candidate ast.Node) bool {
|
||||
switch item := candidate.(type) {
|
||||
case *ast.IfStmt, *ast.ForStmt, *ast.RangeStmt, *ast.CommClause:
|
||||
value++
|
||||
case *ast.CaseClause:
|
||||
if len(item.List) > 0 {
|
||||
value++
|
||||
}
|
||||
case *ast.BinaryExpr:
|
||||
if item.Op == token.LAND || item.Op == token.LOR {
|
||||
value++
|
||||
}
|
||||
}
|
||||
return true
|
||||
})
|
||||
return value
|
||||
}
|
||||
|
||||
func sortedKeys(values map[string]*counts) []string {
|
||||
keys := make([]string, 0, len(values))
|
||||
for key := range values {
|
||||
keys = append(keys, key)
|
||||
}
|
||||
sort.Strings(keys)
|
||||
return keys
|
||||
}
|
||||
|
||||
func emitMetric(module, name string, value int) {
|
||||
fmt.Printf("METRIC\t%s\t%s\t%d\n", module, name, value)
|
||||
}
|
||||
|
||||
func fail(code int, format string, arguments ...any) {
|
||||
fmt.Fprintf(os.Stderr, "source-metrics: "+format+"\n", arguments...)
|
||||
os.Exit(code)
|
||||
}
|
||||
@@ -1,205 +0,0 @@
|
||||
---
|
||||
name: archie-docs-and-writing
|
||||
description: Maintain Archie's documentation of record and write durable architecture decisions, migration plans, parity matrices, incident and dead-end records, feature ownership and deprecation records, operational runbooks, and documentation reviews. Use when deciding where an Archie fact belongs; reconciling code with ARCHITECTURE.md, CLAUDE.md, docs/prds, docs/archive, or generated contracts; changing tools/docsgen; documenting a feature so future maintainers can find its owners, consumers, invariants, superseded paths, deletion gates, evidence, and rollback; or checking documentation authority, drift, links, copied content, and source-artifact hygiene.
|
||||
---
|
||||
|
||||
# Maintain Archie documentation
|
||||
|
||||
Write one durable record for each decision or behavior. Separate what runs now
|
||||
from what Archie has approved as its destination.
|
||||
|
||||
Route to `archie-architecture-planning-campaign` for ownership/boundary
|
||||
decisions (parked outside this checkout, under
|
||||
`/work/apps/archie-skills-parked/`),
|
||||
`archie-architecture-contract` for invariants,
|
||||
`archie-codebase-discovery` for live entry points,
|
||||
`archie-failure-archaeology` for incidents,
|
||||
`archie-config-and-flags`, `archie-build-and-env`, or `archie-run-and-operate`
|
||||
for runtime/operations facts.
|
||||
|
||||
## Use the authority vocabulary
|
||||
|
||||
Define a **record of authority** as the one canonical location whose owner may
|
||||
change a claim.
|
||||
|
||||
| State | Meaning | Permitted wording |
|
||||
|---|---|---|
|
||||
| `CURRENT` | Verified behavior in checked-out code, tests, composition, or executable config | "Currently does" |
|
||||
| `APPROVED TARGET` | Normative destination approved in architecture index | "Must become"; never "currently does" |
|
||||
| `OPEN` | Investigation, candidate, or unresolved decision | "Candidate", "unknown", or "requires decision" |
|
||||
| `HISTORICAL` | Prior design, incident, dead end, or superseded choice | "Previously did" |
|
||||
| `GENERATED` | Derivative output produced from owned source definition | "Generated from"; never hand-edit |
|
||||
| `EXTERNAL` | Fact held outside repository, such as deployed config or host state | Date, name verifier, give re-check command |
|
||||
|
||||
When `CURRENT` conflicts with `APPROVED TARGET`, preserve both and state the
|
||||
migration delta.
|
||||
|
||||
## Use the repository authority map
|
||||
|
||||
Verified on 2026-09-18:
|
||||
|
||||
| Location | Role | Discipline |
|
||||
|---|---|---|
|
||||
| Live Go code, tests, `Taskfile.yml`, executable config parsing, composition under `internal/app/` (entered from `cmd/`) | `CURRENT` execution evidence | Trace producers and consumers; tests prove only asserted behavior |
|
||||
| `CLAUDE.md` | Current contributor and safety protocol plus compact architecture orientation | Verify operational claims against code and `Taskfile.yml`; `AGENTS.md` is a symlink to it |
|
||||
| `ARCHITECTURE.md` | Useful architecture history and partial current overview | Corroborate every inventory/status claim; its "Planned" list is stale for implemented skill support |
|
||||
| `docs/prds/01-project-management.md` | Index and approved foundation for target architecture | Add or change target decisions in the focused document it names |
|
||||
| `docs/architecture/*.md` | Focused target decisions, active review procedure, migration inventory | Read each file's status |
|
||||
| `docs/architecture/migration-decisions.md` | `OPEN` migration inventory constrained by approved decisions | Close a question only after code-grounded review |
|
||||
| `docs/archive/` | `HISTORICAL` material | Mine rationale and failure evidence |
|
||||
| `CHANGELOG.md` | Release stream and packaged runtime input | One file holds every release; `internal/releaseannounce` parses version headings |
|
||||
| `tools/docsgen` | Current, partial generator in nested `tools` Go module | Treat its flags and tests—not planned PRD commands—as executable truth |
|
||||
| `docs/data/generated/contracts.json` | Current working-tree `GENERATED` output | Regenerate; never edit by hand |
|
||||
| `docs/` | Repository documentation only | Nothing builds, renders, or publishes it; Markdown is the artifact |
|
||||
|
||||
The repository root has no `README.md` or `CONTRIBUTING.md` as of 2026-09-18.
|
||||
|
||||
## Choose one destination
|
||||
|
||||
1. State the reader's question.
|
||||
2. Identify the owner of the behavior or decision.
|
||||
3. Find the existing record of authority.
|
||||
4. Extend that record or link to it. Do not make a second canonical table.
|
||||
5. If no owner exists, route the ownership decision through the architecture campaign.
|
||||
6. If the fact is generated, change the owned source definition and generator.
|
||||
7. If the fact is external, date it and name the exact observation command.
|
||||
|
||||
| Content | Destination |
|
||||
|---|---|
|
||||
| Cross-cutting approved architecture index | `docs/prds/01-project-management.md` |
|
||||
| New capability with no settled design yet (CLAUDE.md's "write a decisive doc before coding") | New `docs/prds/<capability>.md` — use the PRD template in `references/templates.md`, which folds in a multi-agent execution breakdown so the sub-issues can be picked up without re-deriving the design |
|
||||
| Focused domain or requirement decision | Matching `docs/architecture/*.md` file |
|
||||
| Unresolved migration question | `docs/architecture/migration-decisions.md` |
|
||||
| Contributor protocol that must load before work | `CLAUDE.md` |
|
||||
| Runtime/API/config reference derivable from code | Domain-owned registry/type, then `tools/docsgen` output |
|
||||
| Repository documentation prose | `docs/`, linking back to authority with repository-relative paths |
|
||||
| Shipped release behavior | Matching component changelog; keep `CHANGELOG.md` as two-component index |
|
||||
| Superseded design retained for context | `docs/archive/`, with historical status |
|
||||
| Incident or rejected approach | `archie-failure-archaeology`'s chronology |
|
||||
|
||||
Do not duplicate a package map across `CLAUDE.md`, `ARCHITECTURE.md`, a PRD, and
|
||||
the site. Name the authoritative map and link to it.
|
||||
|
||||
## Write for future change
|
||||
|
||||
Every architecture, feature, or migration record must answer:
|
||||
|
||||
- **Responsibility:** What cohesive job exists?
|
||||
- **Owner:** Which domain, application boundary, or infrastructure adapter owns
|
||||
its meaning and mutable state?
|
||||
- **Boundaries:** What is explicitly inside and outside?
|
||||
- **Consumers:** Which entry points, interfaces, commands, events, config, and
|
||||
processes depend on it?
|
||||
- **Invariants:** What must remain true, and where is each enforced?
|
||||
- **Superseded path:** Which older mechanism becomes redundant?
|
||||
- **Deletion gate:** What observable proof permits removal?
|
||||
- **Evidence:** Which symbols, tests, commands, and runtime observations support
|
||||
the record?
|
||||
- **Rollback:** How can behavior and data return safely?
|
||||
- **Unresolved questions:** What remains `OPEN`?
|
||||
|
||||
Name one owner for every mutable record. A new path is incomplete until the
|
||||
document says whether each older path remains, delegates, migrates, or is
|
||||
deleted.
|
||||
|
||||
## Cite evidence without freezing line numbers
|
||||
|
||||
Prefer: repository-relative path plus exact Go symbol, test name, config key,
|
||||
workflow job/step, or Markdown heading; a relative Markdown link to the record
|
||||
of authority; the command that re-discovers the evidence.
|
||||
|
||||
Write `internal/agentexec.Request` and `tools/docsgen.currentContractTypes`.
|
||||
Distinguish evidence strength:
|
||||
|
||||
1. Runtime composition and executable behavior.
|
||||
2. Tests that exercise the relevant production seam.
|
||||
3. Approved target decision.
|
||||
4. Comments and summaries corroborated by the first three.
|
||||
5. Historical or external notes, explicitly dated.
|
||||
|
||||
## Maintain component changelogs
|
||||
|
||||
Keep every release's notes in `CHANGELOG.md`; a release is one version, and
|
||||
the components' entries are labelled sections inside it.
|
||||
`Dockerfile.archied` copies it to `/usr/share/archie/`, and
|
||||
`internal/releaseannounce.changelogSection` parses a version heading.
|
||||
|
||||
Version-heading format is settled as of 2026-09-18: the changelog uses
|
||||
`## [1.27.0]` with no `v` prefix, `changelogSection` searches for
|
||||
`## [<version>]`, and `.github/workflows/deploy.yml` gates each release tag with
|
||||
`grep -q "^## \[$ver\]" CHANGELOG.md`. The earlier
|
||||
`vX.Y.Z`-vs-`X.Y.Z` contradiction involved `.gitea/workflows/deploy.yml`, which
|
||||
was dropped (`dd9bddc2 ci: build and push images to GHCR, drop the Gitea
|
||||
workflow`), so that question is `HISTORICAL`, not `OPEN`. The remaining guard is
|
||||
the CI shell gate plus `internal/releaseannounce`'s announcer tests
|
||||
(`TestAnnouncerReportsMissingReleaseSectionWithoutAdvancingState`); the old
|
||||
`cmd/archied.TestChangelogsTrackGatewayAndRuntimeIndependently` no longer exists.
|
||||
|
||||
## Maintain generated contracts
|
||||
|
||||
Current behavior, verified 2026-09-18:
|
||||
|
||||
- Tool path is `tools/docsgen`, not `tools/cmd/docsgen`.
|
||||
- Separate Go module replacing root module with `../`.
|
||||
- Accepts `--repo-root` and `--out`, plus a `check` subcommand that compares
|
||||
against the committed artifact without writing. No implemented `data`,
|
||||
`asyncapi`, or `all` subcommands.
|
||||
- `currentContractTypes` publishes three top-level contracts and collects
|
||||
referenced schemas into one JSON object.
|
||||
- Default output is `docs/data/generated/contracts.json`.
|
||||
|
||||
```bash
|
||||
GOTMPDIR=/tmp GOCACHE=/tmp/archie-docsgen-gocache go -C tools test -mod=readonly ./docsgen -count=1
|
||||
task docs:check # fails loudly, and names the Go type behind each mismatch
|
||||
```
|
||||
|
||||
`docsgen check` and the `docs:generate`/`docs:check` tasks are implemented, and
|
||||
`task check` runs `docs:check` — generated drift is gated. `docsgen data`,
|
||||
`docsgen asyncapi`, and `docsgen all` remain `APPROVED TARGET`.
|
||||
|
||||
The check is deliberately non-destructive: it generates into a temporary
|
||||
directory, so a failing gate never rewrites the artifact it judges. Fix a
|
||||
failure with `task docs:generate` and commit the result with the code change
|
||||
that shifted the contract surface.
|
||||
|
||||
## Store documentation as repository Markdown
|
||||
|
||||
`docs/` is Markdown read directly in the repository, an editor, or the forge's
|
||||
file view. Nothing builds, renders, or publishes it. The VitePress site, its
|
||||
package manifest and lockfile, its landing page, and
|
||||
`.github/workflows/docs.yml` were removed on 2026-09-12 as an unnecessary build
|
||||
step; the publishing surface is an open decision
|
||||
(`docs/architecture/generated-documentation.md`, "Rendering and publishing").
|
||||
|
||||
| Surface | Current state |
|
||||
|---|---|
|
||||
| Content | Markdown under `docs/`, including `docs/data/generated/contracts.json` |
|
||||
| Links | Repository-relative (`../architecture/organisation.md`); no root-absolute links |
|
||||
| Build | None. There is no site, no dev server, no link checker, no Pages deploy |
|
||||
| Nav | `docs/prds/01-project-management.md` is the index; there is no site nav |
|
||||
|
||||
Because no build validates links, check them yourself or with a one-off script —
|
||||
nothing catches a dead link for you:
|
||||
|
||||
```bash
|
||||
# every relative markdown link target that does not resolve
|
||||
grep -rhoE '\]\([^)#]+' docs --include=*.md | sed -E 's/^\]\(//' | sort -u
|
||||
```
|
||||
|
||||
### Enforce source-artifact hygiene
|
||||
|
||||
Git tracks no `node_modules` entries (verified 2026-09-12; the 237 `docs/`
|
||||
symlinks recorded on 2026-07-28 are gone) and no VitePress output. A future
|
||||
renderer must not reintroduce committed installs or build output.
|
||||
|
||||
```bash
|
||||
git ls-files | grep -c node_modules # expect 0
|
||||
ls docs/package.json docs/pnpm-lock.yaml 2>&1 # expect: No such file
|
||||
ls .github/workflows/ # expect deploy.yml only
|
||||
```
|
||||
|
||||
Historical mentions of VitePress in `docs/architecture/` are deliberate — they
|
||||
record what was removed. A grep for the word alone is not a failure signal.
|
||||
|
||||
Never stage dependency installs, renderer output, generator scratch files,
|
||||
credentials, absolute paths, wall-clock data, or machine-specific values.
|
||||
@@ -1,4 +0,0 @@
|
||||
interface:
|
||||
display_name: "Archie Docs and Writing"
|
||||
short_description: "Maintain authoritative Archie documentation"
|
||||
default_prompt: "Use $archie-docs-and-writing to write or update an authoritative Archie design, migration, incident, ownership, or operations document."
|
||||
@@ -1,485 +0,0 @@
|
||||
# Archie durable-writing templates
|
||||
|
||||
Use one template at a time. Replace every angle-bracket prompt. Remove unused
|
||||
sections. Keep facts, decisions, and open questions visibly separate.
|
||||
|
||||
## Contents
|
||||
|
||||
- [Architecture decision record](#architecture-decision-record)
|
||||
- [Migration plan and parity matrix](#migration-plan-and-parity-matrix)
|
||||
- [Incident or dead-end record](#incident-or-dead-end-record)
|
||||
- [Feature ownership and deprecation record](#feature-ownership-and-deprecation-record)
|
||||
- [Operational runbook](#operational-runbook)
|
||||
- [Documentation change review](#documentation-change-review)
|
||||
- [PRD: open capability design with multi-agent execution](#prd-open-capability-design-with-multi-agent-execution)
|
||||
|
||||
## Architecture decision record
|
||||
|
||||
````markdown
|
||||
# <Decision title>
|
||||
|
||||
**Status:** Proposed | Approved | Superseded by <link>
|
||||
**Date:** YYYY-MM-DD
|
||||
**Owner:** <domain or application boundary>
|
||||
**Record of authority:** <this document or existing focused document>
|
||||
**Change-control reference:** <issue/review identifier>
|
||||
|
||||
## Decision
|
||||
|
||||
<One unambiguous normative statement.>
|
||||
|
||||
## Problem and scope
|
||||
|
||||
<Describe the problem, the included behavior, and explicit non-goals.>
|
||||
|
||||
## Current evidence
|
||||
|
||||
| Claim | Evidence |
|
||||
|---|---|
|
||||
| <CURRENT behavior> | `<path>` — `<symbol/test/config key>` |
|
||||
|
||||
## Constraints and invariants
|
||||
|
||||
- <Invariant and where it is enforced>
|
||||
|
||||
## Consumers and boundaries
|
||||
|
||||
| Consumer | Contract used | Failure effect |
|
||||
|---|---|---|
|
||||
| <entry point/package/process> | <interface/command/event/data> | <effect> |
|
||||
|
||||
## Options considered
|
||||
|
||||
| Option | Benefits | Costs and risks | Evidence | Result |
|
||||
|---|---|---|---|---|
|
||||
| <option> | <benefit> | <cost> | <measurement/source> | Accepted / Rejected |
|
||||
|
||||
## Consequences
|
||||
|
||||
<State new responsibilities, dependency direction, state ownership, and
|
||||
operational effects.>
|
||||
|
||||
## Supersession and deletion
|
||||
|
||||
- Superseded path: `<path/symbol>` or none
|
||||
- Compatibility owner: <owner or none>
|
||||
- Deletion gate: <observable proof>
|
||||
- Architecture test: <test or OPEN>
|
||||
|
||||
## Rollback
|
||||
|
||||
<State how code, behavior, and data return safely.>
|
||||
|
||||
## Open questions
|
||||
|
||||
| Question | Owner | Evidence required | Decision deadline/gate |
|
||||
|---|---|---|---|
|
||||
| <OPEN question> | <owner> | <measurement> | <gate> |
|
||||
|
||||
## Validation
|
||||
|
||||
- `<exact command>` — expected <observable result>
|
||||
````
|
||||
|
||||
## Migration plan and parity matrix
|
||||
|
||||
````markdown
|
||||
# <Capability> migration plan
|
||||
|
||||
**Status:** Proposed | Approved | In progress | Complete
|
||||
**Date:** YYYY-MM-DD
|
||||
**Owner:** <domain>
|
||||
**Source authority:** <approved target decision>
|
||||
**Current baseline:** <code paths and runtime composition>
|
||||
|
||||
## Outcome
|
||||
|
||||
<Describe the final single authoritative path and what becomes easier to
|
||||
change.>
|
||||
|
||||
## Current-path inventory
|
||||
|
||||
| Operation | Entry point | Owner today | State/data touched | Consumers | Disposition |
|
||||
|---|---|---|---|---|---|
|
||||
| <operation> | `<path.Symbol>` | <owner/none> | <state> | <consumers> | Keep / Adapt / Merge / Delete |
|
||||
|
||||
## Parity matrix
|
||||
|
||||
| Behavior | Current evidence | Target owner/path | Required parity | Test or observation | Status |
|
||||
|---|---|---|---|---|---|
|
||||
| <behavior> | `<test/symbol/log>` | <target> | <exact result> | `<command>` | OPEN |
|
||||
|
||||
Include success, validation failure, retry, cancellation, crash recovery,
|
||||
authorization, persistence, event emission, and shutdown where applicable.
|
||||
|
||||
## Dependency and data movement
|
||||
|
||||
| From | To | Adapter/backfill | Consistency rule | Rollback |
|
||||
|---|---|---|---|---|
|
||||
| <source> | <target> | <mechanism> | <invariant> | <method> |
|
||||
|
||||
## Slices and gates
|
||||
|
||||
### Slice 1 — <small vertical outcome>
|
||||
|
||||
- Change: <bounded change>
|
||||
- Expected evidence: <number/result predicted before implementation>
|
||||
- Command: `<exact command>`
|
||||
- Pass: <observable result>
|
||||
- Branch if not: <diagnostic route>
|
||||
- Legacy path after slice: Active / Delegating / Read-only / Removable
|
||||
|
||||
<Repeat for each independently reviewable slice.>
|
||||
|
||||
## Cutover
|
||||
|
||||
1. <Prepare compatibility/data>
|
||||
2. <Change production composition>
|
||||
3. <Observe explicit health/parity signals>
|
||||
4. <Disable legacy entry>
|
||||
5. <Delete only after the deletion gate>
|
||||
|
||||
## Deletion gates
|
||||
|
||||
| Legacy path | Replacement proof | Consumer-zero proof | Data proof | Removal test |
|
||||
|---|---|---|---|---|
|
||||
| `<path.Symbol>` | <proof> | <search/inventory> | <proof> | `<command>` |
|
||||
|
||||
## Rollback and stop conditions
|
||||
|
||||
- Roll back when: <condition>
|
||||
- Restore: <code/config/data sequence>
|
||||
- Preserve for diagnosis: <artifacts>
|
||||
|
||||
## Remaining open decisions
|
||||
|
||||
| Decision | Owner | Evidence needed | Blocks |
|
||||
|---|---|---|---|
|
||||
| <OPEN> | <owner> | <evidence> | <slice/cutover> |
|
||||
````
|
||||
|
||||
## Incident or dead-end record
|
||||
|
||||
````markdown
|
||||
# <Symptom or rejected approach>
|
||||
|
||||
**Status:** Resolved | Mitigated | Rejected | Reopened
|
||||
**Observed:** YYYY-MM-DD
|
||||
**Last verified:** YYYY-MM-DD
|
||||
**Owner:** <capability>
|
||||
**Related changes:** <commit/issue/PR identifiers>
|
||||
|
||||
## Symptom and impact
|
||||
|
||||
<State the observable failure, affected path, and cost. Do not begin with the
|
||||
proposed fix.>
|
||||
|
||||
## Reproduction
|
||||
|
||||
```text
|
||||
<exact non-secret command or event sequence>
|
||||
```
|
||||
|
||||
Expected: <result>
|
||||
Observed: <result>
|
||||
|
||||
## Investigation chronology
|
||||
|
||||
| Time/order | Hypothesis | Prediction | Evidence | Result |
|
||||
|---|---|---|---|---|
|
||||
| 1 | <hypothesis> | <expected observation> | `<command/log/test>` | Confirmed / Rejected |
|
||||
|
||||
## Root cause
|
||||
|
||||
<Name the owning code path and causal mechanism. Separate cause from trigger.>
|
||||
|
||||
## Attempted or rejected fixes
|
||||
|
||||
| Fix | Why plausible | Evidence against it | Status |
|
||||
|---|---|---|---|
|
||||
| <approach> | <reason> | <test/runtime evidence> | Rejected / Reverted |
|
||||
|
||||
## Resolution and invariant
|
||||
|
||||
- Resolution: <what changed>
|
||||
- Preserved invariant: <what must not regress>
|
||||
- Regression test: `<test name/path>`
|
||||
- Operational signal: <log/metric/state>
|
||||
|
||||
## Reopen condition
|
||||
|
||||
<State the evidence that would justify revisiting the settled result.>
|
||||
````
|
||||
|
||||
## Feature ownership and deprecation record
|
||||
|
||||
````markdown
|
||||
# <Feature/capability> ownership
|
||||
|
||||
**Status:** Current | Migrating | Deprecated | Removed
|
||||
**Date:** YYYY-MM-DD
|
||||
**Behavior owner:** <domain>
|
||||
**State owner:** <domain/repository>
|
||||
**Composition owner:** <application boundary>
|
||||
|
||||
## Responsibility and non-responsibilities
|
||||
|
||||
- Owns: <cohesive behavior>
|
||||
- Does not own: <adjacent concerns>
|
||||
|
||||
## Complete path
|
||||
|
||||
| Layer | Path/symbol | Responsibility |
|
||||
|---|---|---|
|
||||
| Entry | `<path.Symbol>` | <role> |
|
||||
| Domain | `<path.Symbol>` | <role> |
|
||||
| State | `<path.Symbol>` | <role> |
|
||||
| Adapter | `<path.Symbol>` | <role> |
|
||||
| Composition | `<path.Symbol>` | <role> |
|
||||
|
||||
## Consumers
|
||||
|
||||
| Consumer | Contract | Configuration | Test evidence |
|
||||
|---|---|---|---|
|
||||
| <consumer> | <interface/event/data> | <key or none> | `<test>` |
|
||||
|
||||
## Invariants and failures
|
||||
|
||||
| Invariant | Enforcement | Failure behavior | Test |
|
||||
|---|---|---|---|
|
||||
| <invariant> | `<path.Symbol>` | <result> | `<test>` |
|
||||
|
||||
## Duplicate and superseded paths
|
||||
|
||||
| Path | Same operation? | Disposition | Deletion gate |
|
||||
|---|---|---|---|
|
||||
| `<path.Symbol>` | Yes / No, because <reason> | Keep / Delegate / Migrate / Delete | <proof> |
|
||||
|
||||
## Change checklist
|
||||
|
||||
- [ ] Trace every entry point and consumer.
|
||||
- [ ] Decide whether the feature deprecates earlier work.
|
||||
- [ ] Keep one owner for mutable state.
|
||||
- [ ] Add failure-path and architecture tests.
|
||||
- [ ] Prove the replacement before deleting the old path.
|
||||
- [ ] Update generated reference from owned definitions.
|
||||
````
|
||||
|
||||
## Operational runbook
|
||||
|
||||
````markdown
|
||||
# Operate <service/capability>
|
||||
|
||||
**Status:** Current
|
||||
**Last verified:** YYYY-MM-DD
|
||||
**Environment:** <local/staging/production>
|
||||
**Owner:** <operator/capability>
|
||||
**External sources:** <host/config/dashboard; no secrets>
|
||||
|
||||
## Purpose and safety boundary
|
||||
|
||||
<State what this runbook operates and what requires separate authorization.>
|
||||
|
||||
## Preconditions
|
||||
|
||||
- <access/tool/config precondition>
|
||||
- Secret names only; never secret values
|
||||
|
||||
## Start or change
|
||||
|
||||
1. Run `<exact command>`.
|
||||
2. Expect `<observable output/state>` within `<bounded interval>`.
|
||||
3. If `<alternate result>`, stop and route to `<diagnostic branch>`.
|
||||
|
||||
## Health and outputs
|
||||
|
||||
| Signal | Location/command | Healthy result | Unhealthy branch |
|
||||
|---|---|---|---|
|
||||
| <signal> | `<command/path>` | <result> | <action> |
|
||||
|
||||
## Rollback
|
||||
|
||||
1. <Restore previous code/config/data>
|
||||
2. Run `<health command>`.
|
||||
3. Preserve <logs/artifacts> for incident review.
|
||||
|
||||
## Known failure modes
|
||||
|
||||
| Symptom | First measurement | Likely seam | Next runbook |
|
||||
|---|---|---|---|
|
||||
| <symptom> | `<command>` | <boundary> | <sibling skill/doc> |
|
||||
|
||||
## Provenance
|
||||
|
||||
- External fact observed by <who/how> on YYYY-MM-DD.
|
||||
- Re-check: `<one-line command>`
|
||||
````
|
||||
|
||||
## Documentation change review
|
||||
|
||||
````markdown
|
||||
# Documentation review: <scope>
|
||||
|
||||
**Date:** YYYY-MM-DD
|
||||
**Reviewer:** <name/session>
|
||||
**Changed authority:** <path or none>
|
||||
|
||||
## Classification
|
||||
|
||||
| Claim/change | State | Owner | Evidence |
|
||||
|---|---|---|---|
|
||||
| <claim> | CURRENT / APPROVED TARGET / OPEN / HISTORICAL / GENERATED / EXTERNAL | <owner> | `<path.Symbol/test/command>` |
|
||||
|
||||
## Findings
|
||||
|
||||
| Severity | Location | Problem | Evidence | Required correction |
|
||||
|---|---|---|---|---|
|
||||
| Blocking / Important / Minor | <heading/path> | <problem> | <evidence> | <fix> |
|
||||
|
||||
## Authority and duplication checks
|
||||
|
||||
- [ ] One record of authority owns each claim.
|
||||
- [ ] Current and target behavior are separated.
|
||||
- [ ] Open questions remain visibly open.
|
||||
- [ ] Historical material is not used normatively.
|
||||
- [ ] Generated output was not hand-edited.
|
||||
- [ ] Symbols and headings replace durable line-number citations.
|
||||
|
||||
## Maintainability checks
|
||||
|
||||
- [ ] Responsibility, owner, boundaries, consumers, and invariants are explicit.
|
||||
- [ ] Superseded paths and deletion gates are named.
|
||||
- [ ] Evidence, rollback, and unresolved questions are actionable.
|
||||
- [ ] A zero-context engineer can locate the complete feature path.
|
||||
|
||||
## Validation evidence
|
||||
|
||||
| Command | Expected | Observed |
|
||||
|---|---|---|
|
||||
| `<exact command>` | <result> | <result> |
|
||||
|
||||
## Residual uncertainty
|
||||
|
||||
<List unverified external facts, unavailable environments, or still-open
|
||||
decisions. Never convert them into implied acceptance.>
|
||||
````
|
||||
|
||||
## PRD: open capability design with multi-agent execution
|
||||
|
||||
For `docs/prds/*.md` — CLAUDE.md's "no settled design exists" doc. The point
|
||||
of this template is that a cheaper/faster model can implement straight from
|
||||
it without re-deriving architecture: every decision the epic left open gets
|
||||
made here, not deferred again, and every file an implementer touches is
|
||||
named before any bead is picked up. `docs/prds/image-capability-contract.md`
|
||||
is the worked example this template was extracted from — read it once for
|
||||
the shape before writing a new PRD from a blank page.
|
||||
|
||||
The three failure modes this template exists to prevent:
|
||||
|
||||
- **Deferred decisions posing as scope.** "Hosted provider implementation is
|
||||
a separate bead" is not a design decision, it's a missing one. If an open
|
||||
question blocks an implementer, decide it here, in the PRD — not "this bead
|
||||
will decide it later," which is how the same question gets re-opened by
|
||||
every bead that touches it.
|
||||
- **Assumed gaps.** Before writing a section for "what's missing," grep for
|
||||
it. `image-capability-contract.md`'s delivery section exists mostly because
|
||||
the pipeline it needed already shipped for video — the section reports
|
||||
that, instead of specifying new plumbing nothing required.
|
||||
- **Task lists a model can't execute standalone.** A subtask is not "wire the
|
||||
delivery path"; it's the file, the interface it must satisfy, and the
|
||||
existing call site that already proves the pattern (`internal/tools/minimax/tool.go`,
|
||||
not "a tool like the video one").
|
||||
|
||||
````markdown
|
||||
# <Capability> capability design
|
||||
|
||||
Epic: `<bd id>` / GitHub `#<epic number>` ("<epic title>").
|
||||
|
||||
<One paragraph: what shipped already and is settled (link its section
|
||||
below), what this document newly decides, and what stays explicitly
|
||||
out of scope. If a prior narrower doc already covers part of this
|
||||
capability, say so and extend it — do not start a second document for
|
||||
the same epic.>
|
||||
|
||||
## Problem
|
||||
|
||||
<What's missing today, with the exact "grep and found nothing" evidence,
|
||||
not an assertion.>
|
||||
|
||||
## Design
|
||||
|
||||
<The settled contract/type shape. Code blocks over prose where a type
|
||||
signature says more than describing it would.>
|
||||
|
||||
## <Sub-feature N> (`#<issue>`)
|
||||
|
||||
One section per sibling bead the epic lists as separate scope. Each one:
|
||||
|
||||
- **Decision, not a deferral.** If the epic or a prior doc left this open,
|
||||
decide it here and say why in one paragraph, citing what's actually in
|
||||
the tree (a similar client already in the codebase, an existing config
|
||||
convention, an interface already proven by another feature). "Decide and
|
||||
record which at that bead's own design-doc step" is the sentence this
|
||||
template exists to stop someone from writing twice.
|
||||
- **Call site**, named exactly: `<package/file>`, the function/type it adds
|
||||
or extends, and the existing analogous call site it follows (never "a
|
||||
handler like the others" — name the actual one).
|
||||
- **Reuse check.** Grep before specifying new plumbing. State what already
|
||||
exists and what's actually new, the way a delivery pipeline already
|
||||
proven by one media type doesn't need re-inventing for a second.
|
||||
- **Error/failure mapping**, as a table, when the sub-feature crosses a
|
||||
provider/backend boundary: condition → contract error, so an implementer
|
||||
never invents a new sentinel mid-way through.
|
||||
- **Testing.** What's fakeable vs. what needs a real backend, and which
|
||||
gate (`task check` vs. a documented manual smoke command) each belongs to.
|
||||
|
||||
## Call site inventory
|
||||
|
||||
| concern | file | change |
|
||||
|---|---|---|
|
||||
| <concern> | `<path>` | done (`#<issue>`) / new (`#<issue>`) / none — already handles this |
|
||||
|
||||
Every file any sub-feature touches, old or new, in one table — so an
|
||||
implementer greps this instead of re-deriving it, and a reviewer can tell
|
||||
at a glance whether a PR touched something the design didn't name.
|
||||
|
||||
## Execution: multi-agent team breakdown
|
||||
|
||||
One row per sub-feature section above. This is what turns the design into
|
||||
something a `/council`-style review or a cheaper/faster implementer model
|
||||
can run against directly instead of needing the full design re-explained.
|
||||
|
||||
| sub-feature | issue | implementer scope | suggested council lenses | why |
|
||||
|---|---|---|---|---|
|
||||
| <name> | `#<issue>` | <the call-site inventory rows this bead owns> | `lens-<key>`, `lens-<key>` | <one clause: what that lens actually catches for this slice — e.g. lens-contract for a new provider error-mapping table, lens-operator for a backend-down failure path, lens-deletionist when the section's whole point is "don't rebuild what exists", lens-boundary for a new domain/infra split, lens-maintainer for a new user-facing state machine> |
|
||||
|
||||
Pick lenses from the five in `.claude/workflows/council.js`
|
||||
(`boundary`, `contract`, `deletionist`, `operator`, `maintainer`) by what the
|
||||
slice actually risks getting wrong, not all five by default — a
|
||||
generate-and-poll HTTP client mostly risks failure-mode gaps
|
||||
(`lens-operator`), not domain-boundary violations. Run `/council` with
|
||||
`--lenses <picked>` once the implementation is gate-clean, before opening
|
||||
the PR for human review, same as any other open-decision residue at the
|
||||
end of a session.
|
||||
|
||||
An implementer working one row needs only: this doc's matching sub-feature
|
||||
section, the call-site inventory, and the linked issue's acceptance
|
||||
criteria. It should not need the rest of the epic's history — that's the
|
||||
signal the PRD is thorough enough to hand to a faster/cheaper model.
|
||||
|
||||
## File and link the beads
|
||||
|
||||
For each sub-feature issue already filed against the epic (or newly filed
|
||||
if the epic didn't pre-file its sub-issues):
|
||||
|
||||
- Issue body links back to this doc's matching section by heading, not by
|
||||
restating the design — `bd update <id> --description` and, if the issue
|
||||
also lives on the forge, keep both current (check whether this repo's
|
||||
sync command actually propagates a description edit before trusting it
|
||||
updated both; direct edit on both sides is the fallback).
|
||||
- Issue keeps its own acceptance criteria as the authoritative "done"
|
||||
check — the PRD section is how, the issue's criteria are whether.
|
||||
- Add the suggested lenses from the Execution table as a line on the issue
|
||||
itself, so picking it up needs no round-trip back to this doc to know
|
||||
which `/council` lenses to run before it's done.
|
||||
````
|
||||
@@ -1,242 +0,0 @@
|
||||
---
|
||||
name: archie-domain-reference
|
||||
description: "Use when naming, designing, reviewing, documenting, tracing, or migrating Archie concepts such as Agent, Identity, user, Message, Conversation, work intake, WorkflowExecution, plugin engines, channels, events, policy, forge, worktrees, or gates; when current task/gateway/store vocabulary conflicts with the approved architecture; or when a feature risks crossing domain ownership boundaries. Provides project-specific current-to-target mappings, ownership rules, lifecycle language, and glossary checks. Do not use for database API mechanics, general code tracing, config enumeration, debugging, or operations."
|
||||
---
|
||||
|
||||
# Archie Domain Reference
|
||||
|
||||
Use one meaning for each noun. Keep external-system words at adapters, keep
|
||||
domain meaning with its owner, and mark migration state explicitly.
|
||||
|
||||
## Classify every statement
|
||||
|
||||
As of 2026-09-18, Archie is partway through the domain migration: some approved
|
||||
target packages now exist and are production-wired (`internal/domain/messaging`,
|
||||
`internal/domain/workflow`, `internal/domain/workintake`, `internal/app`,
|
||||
`internal/eventbus`, `internal/infrastructure`), while others remain target-only
|
||||
(`internal/domain/agent`, `internal/domain/identity`, `internal/policy`). Never
|
||||
blend the two.
|
||||
|
||||
| Label | Meaning | Evidence rule |
|
||||
| --- | --- | --- |
|
||||
| **CURRENT** | Behavior present in live code and tests | Cite defining type/function and production caller or test. |
|
||||
| **APPROVED TARGET** | Normative rule in approved foundation document | Cite exact PRD. Do not claim implemented. |
|
||||
| **OPEN/CANDIDATE** | Deferred API, owner, package, migration, or behavior | Preserve open question. |
|
||||
| **ARCHIVED** | Historical context under `docs/archive/` | Use only for archaeology. |
|
||||
|
||||
Start design notes with status sentences:
|
||||
|
||||
```text
|
||||
CURRENT: task.Task persists one mutable Stage string.
|
||||
APPROVED TARGET: WorkflowExecution records StepExecution history.
|
||||
OPEN: the exact schema and Go API for that history.
|
||||
```
|
||||
|
||||
Read status markers:
|
||||
|
||||
```bash
|
||||
sed -n '1,180p' docs/prds/01-project-management.md
|
||||
rg -n '^\*\*Status:\*\*|^## Decisions still required' docs/architecture
|
||||
```
|
||||
|
||||
## Use the canonical actor vocabulary
|
||||
|
||||
| Term | Archie meaning | State and owner |
|
||||
| --- | --- | --- |
|
||||
| **Identity** | Durable actor reference for ownership, attribution, routing, commands, events, audit. | **APPROVED TARGET:** `internal/domain/identity`. **CURRENT:** configured names and empty strings act as identifiers. |
|
||||
| **User** | Person represented as `user` kind of Identity. | **APPROVED TARGET:** Identity domain. |
|
||||
| **Agent** | Persistent assistant with acting IdentityID, specialization, instructions, capability context, memory. | **CONFIRMED TARGET:** Agent and Identity separate aggregates; `internal/domain/agent` confirmed in `migration-decisions.md`. |
|
||||
| **Model invocation** | One call through LLM provider/runtime. Replaceable execution machinery. | **CURRENT:** runtime packages. **TARGET:** infrastructure behind Agent-owned behavior. |
|
||||
| **System identity** | One permanent actor for startup, migration, supervision, rollback. | **APPROVED TARGET:** a real IdentityID. |
|
||||
|
||||
Apply: record acting Agent identity and initiating user identity separately;
|
||||
never authorize because two mutable strings match; never rename Agent when only
|
||||
model/provider/display name changes; never pool two Agents' memory.
|
||||
|
||||
```bash
|
||||
rg -n 'type IdentityConfig|type IdentityRunner|Identity string|BotUser string' internal/config internal/daemon internal/store internal/gateway
|
||||
```
|
||||
|
||||
## Use the canonical interaction vocabulary
|
||||
|
||||
| Term | Archie meaning | State and owner |
|
||||
| --- | --- | --- |
|
||||
| **Channel** | External interaction source (Telegram, email, webhook, forge). | **CURRENT:** `internal/channels` extends `gateway.Gateway`. **TARGET:** infrastructure adapter for Messaging. |
|
||||
| **Adapter** | Boundary code translating external payloads into owned contracts. | **TARGET RULE:** infrastructure implements domain-owned interfaces. |
|
||||
| **Gateway** | Current technical interface/router and package — not approved domain vocabulary. | **CURRENT ONLY:** `internal/gateway`, `internal/channels`. |
|
||||
| **ChannelBindingID** | Stable reference connecting Agent to channel binding. | **APPROVED TARGET INPUT:** part of Conversation identity. |
|
||||
| **Message** | Immutable application record with MessageID and typed content. Platform IDs are external correlations. | **CURRENT:** `internal/domain/messaging.Message`/`MessageID`; `gateway.MessageEvent` is a richer event type beside it. |
|
||||
| **Conversation** | AgentID + UserIdentityID + ChannelBindingID + ExternalConversationID + ThreadID. | **CONFIRMED TARGET, partly current:** `internal/domain/messaging.Conversation`/`ConversationID` exist; the gateway session store still lacks canonical Agent/user IDs. |
|
||||
| **Conversation branch** | Child conversation from one immutable parent message. | **CONFIRMED TARGET.** No current implementation. |
|
||||
| **Work Intake** | Admission, validation, routing boundary between interaction and durable workflow-backed work. | **CONFIRMED TARGET, current package:** `internal/domain/workintake` exists. |
|
||||
| **Accepted work request** | Channel-neutral handoff after Work Intake accepts proposed outcome. | **TARGET HANDOFF:** Agent System consumes it, selects Workflow version, creates WorkflowExecution. |
|
||||
|
||||
Do not equate an inbound Message with work. An Agent may answer, use
|
||||
capabilities, retain information, or propose work without creating a
|
||||
WorkflowExecution.
|
||||
|
||||
Target flow:
|
||||
|
||||
```text
|
||||
external payload -> channel adapter -> canonical Message and Conversation
|
||||
-> selected Agent turn -> optional proposed work -> Work Intake admission
|
||||
-> accepted work request -> Agent System selects Workflow version -> WorkflowExecution
|
||||
```
|
||||
|
||||
Do not describe current `/spawn` as this target. It directly creates a
|
||||
`task.Task` with synthetic forge issue number.
|
||||
|
||||
```bash
|
||||
rg -n 'type Message struct|type MessageEvent struct|ToLegacy|type Conversation struct|CreateTask|EnqueueChatTask|synthetic' internal/domain/messaging internal/gateway internal/store internal/app/archied
|
||||
```
|
||||
|
||||
## Use the canonical execution vocabulary
|
||||
|
||||
| Term | Archie meaning | Current representation |
|
||||
| --- | --- | --- |
|
||||
| **Workflow** | Reusable, versioned definition. | `workflow.Workflow` is named `[]Stage` without durable version model. |
|
||||
| **WorkflowExecution** | One durable execution of one Workflow version. | `task.Task` is migration baseline. |
|
||||
| **WorkflowStep** | One defined operation. | `workflow.Stage` is closest definition. |
|
||||
| **StepExecution** | Durable record of one step's execution and outcome. | Missing; `task.Task.Stage` is one mutable string. |
|
||||
| **Attempt** | Retry within same WorkflowExecution. | `task.Task.Attempt`/`RetryCount` must become explicit attempt history. |
|
||||
| **Agent step execution** | One bounded model-backed WorkflowStep invocation. | `agentexec.Request`/`Result` correlate TaskID, Attempt, Stage, protocol version. |
|
||||
|
||||
Use `WorkflowExecution` in domain contracts, architecture, generated reference.
|
||||
Retain `task` only for Task build tool, forge product nouns in adapters,
|
||||
informal prose.
|
||||
|
||||
### Interpret the current lifecycle exactly
|
||||
|
||||
**CURRENT** `task.Task` states:
|
||||
|
||||
```text
|
||||
queued -> running
|
||||
running -> waiting_human | pr_open | merged | parked | closed_wont_do
|
||||
waiting_human -> queued | closed_wont_do
|
||||
parked -> queued | dead
|
||||
pr_open -> merged | rejected
|
||||
running after crash -> queued
|
||||
```
|
||||
|
||||
Do not claim enforced. `Store.Transition` now guards on `from`
|
||||
(`WHERE id=? AND status=?` → `store.ErrStaleTransition`) and writes status plus
|
||||
history in one transaction; the sentinel crosses the State Store gRPC boundary.
|
||||
See `internal/store/store.go`.
|
||||
|
||||
```bash
|
||||
rg -n 'Status[A-Za-z]+|func \(s \*Store\) Transition|func \(s \*Store\) Requeue|RecoverStale' internal/store internal/domain/workflow internal/gateway
|
||||
```
|
||||
|
||||
## Keep memory scope separate from conversation scope
|
||||
|
||||
| Scope | Address and visibility |
|
||||
| --- | --- |
|
||||
| **Global shared** | Intentionally visible across Archie. |
|
||||
| **Agent-wide** | Owned by one Agent, private by default even across users. |
|
||||
| **User-wide** | One user across authorized Agents. |
|
||||
| **Agent-user relationship** | Addressed by both AgentID and User IdentityID. |
|
||||
|
||||
Conversation branch is not a fifth memory scope. Scope mechanics **OPEN** beyond
|
||||
these constraints.
|
||||
|
||||
Current `MemoryProvider` initializes with session ID, contains no explicit
|
||||
AgentID, User IdentityID, or scope parameter. Built-in provider separates
|
||||
`MEMORY.md` and `USER.md` under one directory — not the four-scope target model.
|
||||
|
||||
```bash
|
||||
rg -n 'type MemoryProvider|Initialize\(|type Config struct|MEMORY.md|USER.md|AgentID|IdentityID|Scope' internal/memory
|
||||
```
|
||||
|
||||
## Distinguish extension terms
|
||||
|
||||
| Term | Meaning |
|
||||
| --- | --- |
|
||||
| **Plugin** | Removable module with identity, metadata, compatibility, lifecycle. Generic `plugin.Plugin` must remain metadata-only. |
|
||||
| **Capability family** | One cohesive typed behavior owned by its domain or approved manager/registry. |
|
||||
| **Engine** | Typed, lifecycle-managed capability family with owning Registry or Manager. |
|
||||
| **Host** | Current cross-family lifecycle/manifest coordinator in `internal/plugin`. Must not become service locator. |
|
||||
|
||||
Give plugin only narrow typed registrars and explicitly supplied contracts.
|
||||
|
||||
```bash
|
||||
go test ./internal/plugin -run 'Test(EngineFamilyInspectionRejectsInvalidShapes|PluginInterfaceExists)' -count=1
|
||||
```
|
||||
|
||||
## Distinguish ownership and boundary terms
|
||||
|
||||
| Term | Archie-specific rule |
|
||||
| --- | --- |
|
||||
| **Domain** | Own one cohesive responsibility: vocabulary, state, rules, operations, commands, events, policies, runtime settings, required service contracts. |
|
||||
| **Command** | Request an action. Receiving domain owns contract and decides result. |
|
||||
| **Domain event** | Record something that happened. Publishing domain owns schema. |
|
||||
| **Event bus** | Broker-neutral delivery/lifecycle contract. `internal/eventbus` exists and is production-wired. |
|
||||
| **Observability event** | `internal/events.Event` projection input. Bounded in-process bus may drop. Not authoritative state. |
|
||||
| **Policy** | Typed rule evaluated through shared mechanics. Consuming domain owns vocabulary. |
|
||||
| **Infrastructure** | Implements domain-owned ports, translates DBs, brokers, SDKs, files, containers. |
|
||||
| **Application composition** | Chooses implementations, translates config, connects contracts, orders startup/shutdown. Current and target: `internal/app`; `cmd/*` stays process-input-only. |
|
||||
|
||||
As of 2026-09-18, `internal/domain`, `internal/eventbus`,
|
||||
`internal/infrastructure`, and `internal/app` exist; only `internal/policy`
|
||||
does not. `internal/domain/agent` and `internal/domain/identity` are still
|
||||
target-only.
|
||||
|
||||
```bash
|
||||
for p in internal/domain internal/eventbus internal/policy internal/infrastructure internal/app; do test -d "$p" && echo "$p CURRENT" || echo "$p TARGET-ONLY"; done
|
||||
```
|
||||
|
||||
## Distinguish forge, repository, workspace, gate, and agent boundaries
|
||||
|
||||
| Term | Owns | Must not own |
|
||||
| --- | --- | --- |
|
||||
| **Forge** | External code-host ops: issues, comments, labels, PRs, reactions. | Workflow lifecycle, canonical identity, work admission. |
|
||||
| **Repository** | External source repo identity and repo-specific policy. | Mutable execution workspace or WorkflowExecution identity. |
|
||||
| **Worktree/workspace** | Isolated files, branch, diff, commit, push, cleanup for one execution. | Agent/domain identity or forge issue lifecycle. |
|
||||
| **Gate** | Deterministic evidence and constraints over execution. | Prompt advice model may waive. |
|
||||
| **Agent execution boundary** | Versioned, validated data entering/leaving one unprivileged stage. | Daemon internals, forge tokens, direct git, workflow orchestration. |
|
||||
|
||||
Model never runs git directly. Worktree operations are daemon-owned.
|
||||
|
||||
## Map current names before adding or migrating behavior
|
||||
|
||||
| Current name/path | Target meaning | Migration warning |
|
||||
| --- | --- | --- |
|
||||
| `config.IdentityConfig.Name` | Canonical IdentityID plus separate bindings | Do not preserve mutable display name as ID. |
|
||||
| `config.IdentityConfig.BotUser` | Forge/Git or channel external binding | Not Conversation or Agent identity. |
|
||||
| `daemon.IdentityRunner` | Composition of identity-correlated capabilities | Currently service bundle, not Identity aggregate. |
|
||||
| `gateway.MessageEvent` | Canonical Messaging Message | Choose one immutable typed contract; `internal/domain/messaging.Message` is the target. |
|
||||
| gateway session context | Conversation metadata | Add canonical Agent/user/binding ownership. |
|
||||
| forge `Issue` or future Jira item | Channel message or external artifact | Preserve native reference in adapter. |
|
||||
| gateway `/spawn` and `TaskCreator` | Proposed/accepted work handoff | Work Intake admits; Agent System creates execution. |
|
||||
| `store.Task` | WorkflowExecution | Preserve every field intentionally; the type now lives at `internal/domain/workflow/task.Task`. |
|
||||
| `workflow.Workflow` | Versioned Workflow definition | Add identity/version ownership before parity. |
|
||||
| `workflow.Stage` | WorkflowStep definition | A definition is not execution history. |
|
||||
| mutable `Task.Stage` | Derived position plus StepExecution records | Deletion requires proven history parity. |
|
||||
| `task.Task.Attempt`, `RetryCount` | Attempt history and retry evidence | Keep worker delivery retries distinct. |
|
||||
| `workflow.TaskContext` | Execution state plus narrow step ports | Remove global config/service bag. |
|
||||
| `events.Event` and `Bus` | Projections fed by authoritative domain events | Current drops acceptable for observability, not state. |
|
||||
| `cmd/archied` wiring | `internal/app/archied` composition | Keep `cmd/*` process-input-only. |
|
||||
| NATS/RPC/store/forge/worktree | Infrastructure adapters | Process boundaries don't decide domain ownership. |
|
||||
|
||||
`migration-decisions.md` leaves memory, tools, workspaces, gates, storage,
|
||||
events, web UI, containers, RPC, release management, scheduling pending.
|
||||
|
||||
## Recognize terminology-driven bugs
|
||||
|
||||
| Incorrect shortcut | Resulting bug |
|
||||
| --- | --- |
|
||||
| "A forge issue is a Task" | Chat needs synthetic issues; uniqueness/dedup stay forge-shaped. |
|
||||
| "Agent and Identity are same config object" | Model/persona changes alter attribution; mutable string equality becomes access control. |
|
||||
| "Every Message is work" | Conversational turns forced through durable workflow lifecycle. |
|
||||
| "Accepted request is already a WorkflowExecution" | Intake bypasses version selection and constructs invalid state. |
|
||||
| "Stage is StepExecution" | Overwriting one string destroys step outcomes and audit history. |
|
||||
| "NATS retry is another Attempt" | Transport availability changes domain retry counts. |
|
||||
| "Event bus owns events" | Broker subjects become domain vocabulary; meaning drifts by consumer. |
|
||||
| "Branch is a memory scope" | Returning to parent hides/duplicates durable learning. |
|
||||
| "Engine means another generic plugin hook" | Capability ownership becomes untyped; plugins gain service-locator access. |
|
||||
| "Configuration owns the feature" | Cross-concern config becomes de facto domain. |
|
||||
|
||||
Reject in review: a second parallel model without bounded cutover; status string
|
||||
copied into consumer; mutable display name as durable ID; service bag passed
|
||||
into domain/plugin/WorkflowStep; lifecycle state written by adapter/UI/transport;
|
||||
domain importing concrete persistence/NATS/forge SDK/container/config DTO types;
|
||||
test proving only new path while old production path remains active.
|
||||
@@ -1,4 +0,0 @@
|
||||
interface:
|
||||
display_name: "Archie Domain Reference"
|
||||
short_description: "Use Archie terminology without boundary mistakes"
|
||||
default_prompt: "Use $archie-domain-reference to classify these Archie concepts and map current code terms to their approved target owners."
|
||||
@@ -1,230 +0,0 @@
|
||||
---
|
||||
name: archie-failure-archaeology
|
||||
description: "Reconstruct archie-core failures, dead ends, reversals, rejected fixes, and branch-only repairs from read-only git history and live call sites. Use when a symptom resembles a past production outage, deadlock, retry loop, protocol mismatch, configuration regression, worktree/cache fault, unsafe cleanup, linter semantic change, artifact leak, or recurring baseline repair; also use before reviving an old approach, declaring a fix reverted, or deciding whether a repair is current, settled, conditional, superseded, open, or merely a candidate."
|
||||
---
|
||||
|
||||
# Archie failure archaeology
|
||||
|
||||
Stop the project from paying twice for the same lesson. Reconstruct what
|
||||
happened from checked-out code, tests, configuration, and commit graph.
|
||||
Treat commit prose as a lead, not proof. Preserve uncertainty.
|
||||
|
||||
All volatile observations are dated **2026-09-18** (HEAD `2e1e1549`); the merge-shape
|
||||
section under Step 4 is dated **2026-09-20** (HEAD `1b0133d7`).
|
||||
|
||||
Route to `archie-debugging-playbook` for active symptoms,
|
||||
`archie-codebase-discovery` for deep caller tracing.
|
||||
|
||||
## Use the status taxonomy exactly
|
||||
|
||||
| Status | Meaning |
|
||||
|---|---|
|
||||
| `settled` (`fixed`) | The failure, cause, resolution, and live replacement are proven. |
|
||||
| `current` | The checked-out authoritative path still contains the behavior or contradiction. |
|
||||
| `open` | The defect is evidenced, but no accepted and integrated resolution. |
|
||||
| `conditional` | A fix is proven only for the named configuration, execution mode, peer, or assembly. |
|
||||
| `superseded` | A mechanism was intentionally replaced. |
|
||||
| `candidate` | A branch, proposal, or partial implementation may help but is not accepted. |
|
||||
|
||||
Never use `settled` to mean "a fix commit exists."
|
||||
|
||||
## Run the archaeology workflow
|
||||
|
||||
### 1. Freeze the observation point
|
||||
|
||||
```sh
|
||||
git rev-parse HEAD
|
||||
git status --short
|
||||
git log -1 --date=iso-strict --format='%H %ad %s'
|
||||
git branch -a --no-color --no-merged HEAD
|
||||
```
|
||||
|
||||
### 2. Name the exact symptom
|
||||
|
||||
Capture: first wrong observable result; last confirmed-good boundary; process
|
||||
mode; active config and deployment assembly; whether deterministic,
|
||||
load-dependent, or production-only.
|
||||
|
||||
### 3. Trace current behavior before history
|
||||
|
||||
```sh
|
||||
rg -n '<symptom|symbol|setting|error>' cmd internal config*.toml docker-compose.yml docs
|
||||
git log --all --date=iso-strict --format='%H %ad %s' -- <affected-paths>
|
||||
git blame -L <start>,<end> -- <live-file>
|
||||
```
|
||||
|
||||
### 4. Prove the historical transition
|
||||
|
||||
```sh
|
||||
git show --no-ext-diff --format=fuller --stat <commit>
|
||||
git show --no-ext-diff -U80 <commit> -- <affected-paths>
|
||||
.agents/skills/archie-failure-archaeology/scripts/on-main.sh <commit>
|
||||
git branch -a --contains <commit>
|
||||
```
|
||||
|
||||
#### `--is-ancestor` is blind to squash and rebase merges
|
||||
|
||||
`git merge-base --is-ancestor` answers a topology question: is this exact commit
|
||||
object an ancestor. **Squash and merge** always mints a new commit, and **Rebase
|
||||
and merge** mints new ones whenever the branch had to be replayed, so both
|
||||
orphan the SHA a branch holds. `git branch -a --contains` and
|
||||
`git branch -r --no-merged` are blind in the same way.
|
||||
|
||||
As of **2026-09-20** (`origin/main` `1b0133d7`) this repository squash-merges —
|
||||
the last fifteen merged pull requests are all squashes, so the raw check is a
|
||||
false negative for every one of them. It was sound for everything merged up to
|
||||
**2026-09-18**, which used merge commits.
|
||||
|
||||
Use `scripts/on-main.sh`, which keeps `--is-ancestor` as the offline fast path
|
||||
and otherwise asks the GitHub API, where merge state is recorded independently
|
||||
of the commit graph:
|
||||
|
||||
```sh
|
||||
.agents/skills/archie-failure-archaeology/scripts/on-main.sh <ref> [base-ref]
|
||||
```
|
||||
|
||||
`<base-ref>` defaults to `origin/main`; name `gitea/main` or `HEAD` when that is
|
||||
the trunk you mean, and `git fetch` first so the fast path is not stale.
|
||||
|
||||
| Exit | Meaning |
|
||||
|---|---|
|
||||
| `0` | Ancestor of `<base-ref>`, or recorded in a merged pull request — landed |
|
||||
| `1` | On GitHub, in no merged pull request — not landed |
|
||||
| `2` | Bad ref, no `gh`, offline, never pushed — **undetermined, not a negative** |
|
||||
|
||||
Branch on the code explicitly; `if on-main.sh <ref>; then` folds `2` into "not
|
||||
landed", which is the error this helper exists to prevent. It answers "did *this
|
||||
ref* land", not "did this work land" — a change reimplemented on another branch
|
||||
still reads `not-landed` for the original commit.
|
||||
|
||||
Read parent version when failure is semantic:
|
||||
|
||||
```sh
|
||||
git show <commit>^:<path>
|
||||
git show <commit>:<path>
|
||||
```
|
||||
|
||||
Require all six fields in an incident packet:
|
||||
|
||||
| Field | Required content |
|
||||
|---|---|
|
||||
| Symptom | Operator, user, test, or protocol observation |
|
||||
| Attempted solution | What was tried before or during the failure |
|
||||
| Root cause | The violated contract or mistaken assumption |
|
||||
| Evidence | Commit, live path, test, trace, or production observation |
|
||||
| Current status | One taxonomy value, dated when volatile |
|
||||
| Settled rule | A constraint future work must preserve |
|
||||
|
||||
### 5. Reproduce narrowly, then route
|
||||
|
||||
```sh
|
||||
env GOCACHE=/tmp/archie-archaeology-gocache GOTMPDIR=/tmp go test ./internal/<package> -run '^TestName$' -count=1 -v
|
||||
```
|
||||
|
||||
If current behavior differs from chronicle, update the packet.
|
||||
|
||||
## Match symptoms to known incidents
|
||||
|
||||
| Symptom | Start with |
|
||||
|---|---|
|
||||
| `nats: no responders available for request` only from agent containers | Container network incident |
|
||||
| Daemon crash-loops after config/schema work | SecretRef compatibility and Compose passthrough incidents |
|
||||
| Stream shows empty cursor or first token, then hangs | FullStream/TextStream incident |
|
||||
| MCP unit tests pass but real SDK server hangs | MCP framing and mirrored-peer incident |
|
||||
| Telegram shows old commands after menu update | Telegram server-side scope incident |
|
||||
| Tool discovery deadlocks, aliases mutate, or bad plugin hides rest | Tool-registry adversarial findings |
|
||||
| Hidden `<memory>` content appears at end of truncated stream | Scrubber `Flush` leak |
|
||||
| Broad lint cleanup compiles poorly while tests pass | Autofix, `nilerr`, and `308c199` incidents |
|
||||
| Reused worktree is stale, half-prepared, or coupled to expired objects | Worktree/askpass/cache history |
|
||||
| Repeated `fix: baseline gate repair` commits or parked tasks cycle | Baseline, no-op, and retry-loop incidents |
|
||||
| CI cannot resolve `/work/apps/...` | Local module replacement incident |
|
||||
| Build caches or dependency trees appear in diff | `.gotmp` and `node_modules` incidents |
|
||||
| `diff_cap_lines = 0` still behaves as 400 | Diff-cap zero contradiction |
|
||||
|
||||
## Chronicle: work intake and retry loops
|
||||
|
||||
| Incident and date | Symptom | Root cause | Evidence and status | Settled rule |
|
||||
|---|---|---|---|---|
|
||||
| Label auto-claim, 2026-07-22 | >80 labelled issues enrolled under label polling. | Label polling means eligibility, not hint. | `519882f` changed the Compose profile to `assignee`; that file was deleted (`cbb7929e`) and survives as `deployments/docker-nats-stack.toml`, which sets `trigger = "assignee"`. `internal/config/config.go` defaults to `assignee` but permits `label` and `either`. **Status:** `settled`. | Default to assignee-driven pickup. Label/either are deliberate bulk enrollment. |
|
||||
| Baseline-red park storm, 2026-07-23 onward | Task parks on gate failure that existed before its feature work. | Parking/retrying cannot change pre-existing failure; auto-repair mixes repository repair into feature scope. | `b2482af` made `StageBaselineGate` launch builder instead of parking. Nine repair commits in history. **Status:** `current` mitigation and architecture weak point. | Measure untouched baseline first. Track baseline repair as explicit change. |
|
||||
| Passed build with zero changes, 2026-07-23 | Commit-push reports "no changes," parks, retries, repeats. | "Passed with no changes" lacked terminal domain outcome. | `62c0df1` introduced no-op detection; `2bf42bd` set `Outcome`. `TestStageCommitPushClosesIssueWhenBuildNoChanges`. **Status:** `settled`. | Model no-op as explicit terminal result. |
|
||||
| Infinite parked-task retry, 2026-07-23 | Removing parked label repeatedly requeues with no terminal bound. | Retry count not durable or capped. | `a8fdb50` added persisted `retry_count`, global/per-repo `max_retries`, and `dead`. **Status:** `settled`. | Every autonomous retry needs durable attempt state, explicit bound, terminal state, and operator-visible reason. |
|
||||
|
||||
## Chronicle: runtime and peer contracts
|
||||
|
||||
| Incident and date | Symptom | Root cause | Evidence and status | Settled rule |
|
||||
|---|---|---|---|---|
|
||||
| Container network auto-detection, 2026-07-27 | Every container task returns `nats: no responders`. | `selfNetwork` inspected hostnamed container, silently fell back to default bridge. | `37cf089` records incident, adds `containers.network`; `2ac306b` pins `archie-core_default`. **Status:** `conditional`. | Make cross-container network membership explicit in deployment. |
|
||||
| SecretRef schema crash-loop, 2026-07-27 | Both identities demand `ARCHIE_GITHUB_TOKEN` despite Gitea config. | Removing old `token_env` field let TOML ignore deployed value. `1f8588d` restored precedence-compatible fallback; a later `308c199` removed the `Forge.TokenEnv` declaration while `finalize` still referenced it. | **Status: `settled`** as of 2026-09-18 — `config.Forge.TokenEnv` is declared (`internal/config/config.go`) and `configuration/defaults.go` converts it to an env `SecretRef` when the structured token is empty. | Preserve decoded compatibility until deployed files migrated and rejection of stale keys observable. |
|
||||
| Compose secret omission, 2026-07-27 | Config names valid env var, container sees it empty. | Compose forwards only listed environment entries. | `22fc0ef`, `d0624b7`. **Status:** `conditional`. | Trace every secret from config key to host value to Compose passthrough to process lookup. |
|
||||
| FullStream/TextStream deadlock, 2026-07-27 | Streamed Telegram reply renders empty cursor, typing never clears. | ai-sdk makes `FullStream` authoritative and backpressured; `TextStream` is best-effort. | `6a0bd27`. **Status:** `settled` with regression-test gap. | Drain authoritative stream through close. |
|
||||
| MCP Content-Length framing and mirrored fake, 2026-07-26 to 2026-07-27 | Internal MCP tests pass while official-SDK servers do not. | MCP stdio uses newline-delimited JSON. Test subprocess called same helpers, mirroring the same wrong protocol. | Compare `f2768eb:internal/tools/mcp/framing.go` with `dda4cde`. **Status:** `settled`. | For wire contracts, test raw canonical frames and independently implemented peer. |
|
||||
| Telegram command scopes persist by bot token, 2026-07-27 | Startup reports eight commands published, DMs show ~60 old Hermes commands. | Telegram chooses most specific scope; older scopes survive redeploys. | `cec0f3e` adds menu and deny-by-default; `576c7f5` publishes all three scopes. **Status:** `settled`. | Inventory and overwrite every relevant server-side scope. |
|
||||
| NATS fetch error looked like empty queue, 2026-07-27 | Consumer receives zero messages, treats JetStream failure as "no work." | Batch error state not checked after channel closed. | `0d09a2e` repro; `78a9145` merged through `21ceef0`. **Status:** `settled`. | Check terminal iterator/batch error state even when data channel is empty. |
|
||||
|
||||
## Chronicle: implementation and tooling traps
|
||||
|
||||
| Incident and date | Symptom | Root cause | Status |
|
||||
|---|---|---|---|
|
||||
| Tool registry passed first implementation but held eight defects, 2026-07-26 | Availability can deadlock; schemas mutate after registration; discovery stops at first bad source; literal extraction wrong. | Callbacks ran under `RLock`, copies shallow/shared, parsing partial, matching broad, discovery fail-fast. | `9f6c36c` lists all eight fixes. **Settled.** Never call extension code under registry lock. Clone nested data. Parse complete grammar. Isolate discovery failures. |
|
||||
| Memory scrubber `Flush` leak, 2026-07-26 | Stream ending inside `...secret</mem` emits buffered hidden memory to visible response. | Pending bytes did not retain whether captured inside `<memory>` block. | `b4aaaf0`. **Settled.** Test every streaming state at EOF. Flush is security boundary. |
|
||||
| Linter autofix shadowing, 2026-07-28 | 24-file "style" pass stops compiling. | `gocritic` changed `ctx, cancel = context.WithTimeout(...)` to `:=` inside conditional, shadowing context. | `9b44bac`. **Settled.** Treat autofix output as authored behavior. |
|
||||
| All eleven `nilerr` findings semantic false positives, 2026-07-28 | Mechanical "fixes" would return Go errors while tests pass, breaking model correction, chat, NATS envelopes, clean shutdown, indexing. | Linter cannot see failures carried as text, envelopes, shutdown signals, or skipped entries. | `86cfc19`. **Settled.** Review semantic channels one site at a time. |
|
||||
| Broad checkpoint hid unresolved merge conflict, 2026-07-27 | Literal conflict marker reached committed source. | Unrelated surfaces combined without whole-diff conflict scan. | `4429ae5`. **Settled.** Keep commits cohesive. |
|
||||
|
||||
### Preserve the eight tool-registry review lessons
|
||||
|
||||
| Defect fixed in `9f6c36c` | Required review question |
|
||||
|---|---|
|
||||
| `Available` evaluated `CheckFn` under `RLock` | Can a callback re-enter or block while lock is held? |
|
||||
| `Register` stored caller references | Can caller mutate registered state afterward? |
|
||||
| `Clone` copied nested schema maps/slices shallowly | Is every mutable layer detached? |
|
||||
| `stringLit` mishandled escapes/backticks | Does parsing follow Go literal semantics? |
|
||||
| `intLit` omitted negative/hex/octal/binary forms | Are all supported numeric forms handled or rejected? |
|
||||
| `Discover` aborted on first error | Can one bad extension hide healthy extensions? |
|
||||
| `isRegisterCall` matched too broadly | Is the exact receiver/call shape proven? |
|
||||
| `schemaLit` accepted only string values | Are booleans, integers, arrays, nested maps preserved? |
|
||||
|
||||
## Chronicle: worktree and repository state reversals
|
||||
|
||||
| Step and date | Symptom | Root cause | Settled rule |
|
||||
|---|---|---|---|
|
||||
| Existing worktree skipped, 2026-07-23 | `Prepare` returned when `.git` existed. | Existence did not prove freshness or completed preparation. Later replaced `.git` readiness with sentinel. | Define completed-state marker and revalidate remote/base/branch state on reuse. |
|
||||
| Sentinel outside `.git`, 2026-07-24 | `.archie-prepared` marked setup; go-git `Add(All)` doesn't honor exclude. | Orchestration metadata needs to be outside tracked worktree by construction. | Put sentinel at `.git/archie-prepared`. |
|
||||
| Askpass rewritten each call, 2026-07-24 | Token-emitting shell script rewritten for every git command. | Comment wasn't invariant; no test checked mtime. Later removed shell git and askpass entirely. | Prefer in-process credentials. |
|
||||
| Bare object cache, 2026-07-24 | `--reference-if-able --dissociate` plus TTL to accelerate clones. | go-git has no `--dissociate` equivalent; expiring cache would corrupt active worktrees. | Never accept clone acceleration making task correctness depend on expiring cache. |
|
||||
| Shell git replaced by go-git, 2026-07-28 | Port exposed host GPG inheritance, sentinel tracking, merge-base diff semantics. | RPC handlers used `context.Background`, making in-process clones unbounded. | Audit every adapter and cancellation boundary after replacing killable subprocess with in-process I/O. |
|
||||
|
||||
## Chronicle: cleanup, artifacts, and contradictory policy
|
||||
|
||||
| Incident and date | Symptom | Root cause | Status | Settled rule |
|
||||
|---|---|---|---|---|
|
||||
| Tracked `.gotmp`, 2026-07-27 | Build-cache binaries, generated `_testmain.go`, `.git-askpass` appear in commits. | Workaround path not ignored before use. | `4cb0577` removes artifacts and adds `.gotmp/` to `.gitignore`. **Settled.** | Put caches outside repo or ignore before first command. |
|
||||
| Tracked `docs/node_modules`, 2026-07-28 | Hundreds of pnpm symlink entries become repository content. | `docs/node_modules` neither ignored nor excluded from commit. | 237 entries at that time; the VitePress site was removed (`84b32694`) and `git ls-files | grep -c node_modules` is now **0**. **Settled.** | Track lockfiles, never installed trees. |
|
||||
| `308c199` cleanup regression, 2026-07-28 | `TestRunWrapsExternalCommand` returns `"\n"` instead of `"wrapped\n"`; forge compatibility removed again; dependency artifacts added. | Semantic edits classified and reviewed as cleanup. | The focused skillscript test **passes** as of 2026-09-16. **Settled.** | No commit is "cleanup" for gating purposes. |
|
||||
| `diff_cap_lines = 0` contradiction, introduced at project start | Operators set zero expecting unlimited, but decoded config becomes 400. | `finalize` converts zero to default 400; same sentinel means both "unset" and "unlimited." | **Current/open** contradiction. | Never overload zero value with both defaulting and explicit policy. |
|
||||
|
||||
## Keep unmerged work as dated candidates
|
||||
|
||||
As of **2026-09-18**, the six `fix/4x` and `feat/5x`/`feat/75` candidate
|
||||
branches recorded here on 2026-07-28 no longer exist on either remote —
|
||||
`git branch -r --no-merged HEAD` reports only `gitea/main` (and the Dolt helper
|
||||
ref). Treat their concerns as `superseded` unless a live branch re-raises one.
|
||||
|
||||
| Former candidate branch | Claimed concern |
|
||||
|---|---|
|
||||
| `origin/fix/43-loaddir-no-timeout-around-yaegi-eval-can-hang-daemon-startup` | Bound Yaegi evaluation during `LoadDir` |
|
||||
| `origin/fix/45-skillscriptrun-ignores-context-cannot-be-canceledtimed-out` | Make skill scripts cancellable |
|
||||
| `origin/fix/48-transition-ignores-from-status-guard-allowing-lost-updates` | Enforce expected source state atomically |
|
||||
| `origin/fix/52-handlesse-silently-swallows-eventssince-backlog-fetch-errors` | Surface SSE backlog query errors |
|
||||
| `origin/feat/51-no-test-coverage-for-stagestats-query` | Add `StageStats` query coverage |
|
||||
| `origin/feat/75-add-mcp-client-capabilities-to-archied-and-archie-agent` | Wire MCP through both execution modes |
|
||||
|
||||
Verify candidate state:
|
||||
|
||||
```sh
|
||||
git branch -r --no-merged HEAD
|
||||
git log -1 --date=iso-strict --format='%H %ad %s' <branch>
|
||||
git diff --stat HEAD...<branch>
|
||||
.agents/skills/archie-failure-archaeology/scripts/on-main.sh <branch> HEAD
|
||||
```
|
||||
@@ -1,4 +0,0 @@
|
||||
interface:
|
||||
display_name: "Archie Failure Archaeology"
|
||||
short_description: "Avoid repeating Archie failure history"
|
||||
default_prompt: "Use $archie-failure-archaeology to trace this symptom through Archies proven incidents before proposing a fix."
|
||||
@@ -1,113 +0,0 @@
|
||||
#!/bin/sh
|
||||
# on-main.sh -- did this ref land on the trunk, even when it was squash- or
|
||||
# rebase-merged?
|
||||
#
|
||||
# `git merge-base --is-ancestor` answers a topology question: is this exact
|
||||
# commit object an ancestor. GitHub's "Squash and merge" always mints a new
|
||||
# commit, and "Rebase and merge" mints new commits whenever the branch had to
|
||||
# be replayed, so both orphan the SHA your branch holds. The raw check then
|
||||
# reports a landed repair as never-landed, and `git branch -a --contains` is
|
||||
# blind in exactly the same way.
|
||||
#
|
||||
# This wrapper keeps `--is-ancestor` as the offline fast path and falls back to
|
||||
# the GitHub API, which records merge state independently of the commit graph.
|
||||
#
|
||||
# usage: on-main.sh [-q] <ref> [base-ref]
|
||||
#
|
||||
# <ref> commit, tag, or branch to test
|
||||
# [base-ref] trunk to test against (default: origin/main)
|
||||
# -q print nothing; report through the exit code only
|
||||
#
|
||||
# exit 0 landed on <base-ref>, by ancestry or by a merged pull request
|
||||
# exit 1 not landed: known to GitHub, but in no merged pull request
|
||||
# exit 2 undetermined: bad ref, no gh, offline, or never pushed to GitHub
|
||||
# exit 127 git is missing
|
||||
#
|
||||
# exit 2 is not a negative. Branch on the code explicitly; `if on-main.sh <ref>`
|
||||
# folds it into "not landed", which is the error this helper exists to prevent.
|
||||
|
||||
set -eu
|
||||
|
||||
quiet=0
|
||||
while [ "$#" -gt 0 ]; do
|
||||
case "$1" in
|
||||
-q | --quiet)
|
||||
quiet=1
|
||||
shift
|
||||
;;
|
||||
--)
|
||||
shift
|
||||
break
|
||||
;;
|
||||
-*)
|
||||
printf 'on-main: unknown option %s\n' "$1" >&2
|
||||
printf '%s\n' 'usage: on-main.sh [-q] <ref> [base-ref]' >&2
|
||||
exit 2
|
||||
;;
|
||||
*)
|
||||
break
|
||||
;;
|
||||
esac
|
||||
done
|
||||
|
||||
if [ "$#" -lt 1 ] || [ "$#" -gt 2 ]; then
|
||||
printf '%s\n' 'usage: on-main.sh [-q] <ref> [base-ref]' >&2
|
||||
exit 2
|
||||
fi
|
||||
|
||||
ref=$1
|
||||
base=${2:-origin/main}
|
||||
|
||||
say() {
|
||||
[ "$quiet" -eq 1 ] || printf '%s\n' "$1"
|
||||
}
|
||||
|
||||
command -v git >/dev/null 2>&1 || {
|
||||
printf '%s\n' 'on-main: git is required' >&2
|
||||
exit 127
|
||||
}
|
||||
|
||||
sha=$(git rev-parse --verify --quiet "${ref}^{commit}") || {
|
||||
say "undetermined: $ref does not resolve to a commit in this repository"
|
||||
exit 2
|
||||
}
|
||||
|
||||
git rev-parse --verify --quiet "${base}^{commit}" >/dev/null 2>&1 || {
|
||||
say "undetermined: base ref $base does not resolve; fetch it, or name the trunk explicitly"
|
||||
exit 2
|
||||
}
|
||||
|
||||
if git merge-base --is-ancestor "$sha" "$base" 2>/dev/null; then
|
||||
say "landed: $sha is an ancestor of $base (topology)"
|
||||
exit 0
|
||||
fi
|
||||
|
||||
# Not an ancestor. The SHA may still have landed if GitHub rewrote it at merge
|
||||
# time, so ask the service that recorded the merge rather than the commit graph.
|
||||
command -v gh >/dev/null 2>&1 || {
|
||||
say "undetermined: $sha is not an ancestor of $base, and gh is absent, so a squash or rebase merge cannot be ruled out"
|
||||
exit 2
|
||||
}
|
||||
|
||||
merged=$(
|
||||
gh api "repos/{owner}/{repo}/commits/$sha/pulls" \
|
||||
--jq '[.[] | select(.merged_at != null)] | length' 2>/dev/null
|
||||
) || {
|
||||
say "undetermined: $sha is not an ancestor of $base, and GitHub could not answer for it (offline, unauthenticated, or never pushed)"
|
||||
exit 2
|
||||
}
|
||||
|
||||
case "$merged" in
|
||||
'' | *[!0-9]*)
|
||||
say "undetermined: GitHub returned an unreadable answer for $sha"
|
||||
exit 2
|
||||
;;
|
||||
0)
|
||||
say "not-landed: $sha is not an ancestor of $base and belongs to no merged pull request"
|
||||
exit 1
|
||||
;;
|
||||
*)
|
||||
say "landed: $sha is not an ancestor of $base, but GitHub records it in $merged merged pull request(s) -- a squash or rebase merge rewrote the SHA"
|
||||
exit 0
|
||||
;;
|
||||
esac
|
||||
@@ -1,229 +0,0 @@
|
||||
---
|
||||
name: archie-run-and-operate
|
||||
description: "Run and observe Archie safely with a host daemon and the repository's Docker Compose NATS service. Use when starting or stopping archied, running an archie-agent NATS worker, checking readiness, following logs, locating task state/worktrees/memory/container volumes, understanding inprocess/subprocess/NATS execution, inspecting the image pipeline, or planning an operational rollback without changing architecture."
|
||||
---
|
||||
|
||||
# Run and operate Archie
|
||||
|
||||
Use this runbook to operate the implementation that exists on **2026-09-18**
|
||||
(HEAD `2e1e1549`). Treat source and tests as current; treat `docs/archive/` as
|
||||
history.
|
||||
|
||||
## Define the process shapes
|
||||
|
||||
| Term | Meaning here |
|
||||
|---|---|
|
||||
| `archied` | Resident orchestrator. Owns config, forge credentials, SQLite stores, worktrees, gateways, dashboard, optional NATS/Docker orchestration. |
|
||||
| `archie-agent` | Long-running NATS worker. Consumes per-stage `archie.agent.>` requests and full-task `archie.taskrun.>` requests. Not a stdin/stdout worker. |
|
||||
| Stage request | One autonomous workflow stage sent on `archie.agent.<task-id>.request`. |
|
||||
| Full-task handoff | A whole workflow sent on core NATS subject `archie.taskrun.<task-id>` to a task container. |
|
||||
| Work directory | `work_dir`: task clones plus memory and candidate index artifacts. |
|
||||
| State path prefix | `db_path`: the configured prefix. Task/event state uses `<db_path>-tasks.sqlite`; conversation state uses `<db_path>-conversations.sqlite`. |
|
||||
|
||||
## Apply the operational safety boundary
|
||||
|
||||
Assume every daemon start can change local and external state.
|
||||
|
||||
- Obtain explicit authority for config, forge identity, repositories, NATS
|
||||
account, Docker host, and deployment host before starting.
|
||||
- Never use production tokens for a smoke test.
|
||||
- Do not call `archied -once` as a dry run. It accepts invitations, verifies
|
||||
push access, polls the forge, enqueues/labels work, reconciles PRs, processes
|
||||
tasks, and then exits.
|
||||
- Do not expose the dashboard publicly. It has no authentication, and
|
||||
`POST /api/tasks/clear` deletes terminal task records.
|
||||
- Do not print secret values. Record environment-variable **names**, config
|
||||
checksums, image digests, and paths instead.
|
||||
- Stop with `Ctrl-C`, `SIGTERM`, or Compose. Do not use `SIGKILL` unless graceful
|
||||
shutdown has demonstrably failed.
|
||||
|
||||
There is no config-only or dry-run flag.
|
||||
|
||||
## Know the command surfaces
|
||||
|
||||
### `archied`
|
||||
|
||||
| Flag | Exact behavior |
|
||||
|---|---|
|
||||
| `-config <path>` | Load base TOML. Default: `$XDG_CONFIG_HOME/archie/config.toml`, or `~/.config/archie/config.toml`. |
|
||||
| `-config-overlay <path>` | Decode a second TOML file into the base config before defaults and validation. |
|
||||
| `-once` | Run startup plus one poll/process cycle, then exit. This changes state. |
|
||||
| `-requeue <task-id>` | Requeue a parked/waiting task, then exit unless `-once` is also set. This changes state. |
|
||||
|
||||
### `archie-agent`
|
||||
|
||||
| Flag or environment | Exact behavior |
|
||||
|---|---|
|
||||
| `-nats-url <url>` | Select NATS; falls back to `NATS_URL`. One of them is required. |
|
||||
| `-consumer <name>` | Set the durable JetStream consumer name; default `archie-agent`. |
|
||||
| `NATS_TOKEN` | Optional NATS token read directly by the worker. |
|
||||
|
||||
Both linked binaries may also display Go's `-quickchecks` flag from
|
||||
`testing/quick`; it is not an Archie operations control.
|
||||
|
||||
## Select the execution mode deliberately
|
||||
|
||||
| Config shape | What runs | Operational status on 2026-09-18 |
|
||||
|---|---|---|
|
||||
| `agent.mode = "inprocess"` and no `[nats]` | `archied` polls and claims from SQLite, runs workflow stages and model tools in-process. | **Production-wired candidate.** No process or OS isolation. |
|
||||
| `agent.mode = "subprocess"` | `archied` starts `agent.command` per stage and expects one JSON invocation on stdin, one response on stdout. | **Open/broken with default command.** `cmd/archie-agent` is a long-running NATS worker and never calls `agentexec.ServeOne`. |
|
||||
| `agent.mode = "nats"`, `[nats]`, containers disabled | `archied` runs the workflow; each autonomous stage goes to a separately started `archie-agent`. | **Implemented but operator-assembled.** Launch and supervise a worker separately. |
|
||||
| `agent.mode = "nats"`, `[nats]`, `containers.enabled = true` | `archied` publishes task discovery through JetStream, prepares a worktree, spawns one agent container, sends the whole workflow on `archie.taskrun.<id>`. | **Host daemon + Compose NATS path.** `deployments/docker-nats-stack.toml` demonstrates it. |
|
||||
|
||||
## Run a local foreground daemon
|
||||
|
||||
```bash
|
||||
task build
|
||||
task --list
|
||||
./bin/archied -h
|
||||
./bin/archie-agent -h
|
||||
```
|
||||
|
||||
Choose an explicitly approved config:
|
||||
|
||||
```bash
|
||||
ARCHIE_CONFIG=/absolute/path/to/config.toml
|
||||
test -r "$ARCHIE_CONFIG"
|
||||
./bin/archied -config "$ARCHIE_CONFIG"
|
||||
```
|
||||
|
||||
Expect JSON logs on stderr. Require: `nats connected` when `[nats]` configured;
|
||||
`workflow registry built`; `memory manager started`; `web ui listening` unless
|
||||
`web.listen = "off"`; gateway-start messages for configured channels;
|
||||
`archied running` after startup verification. Absence of `archied running` means
|
||||
startup did not complete. The daemon has no HTTP health endpoint.
|
||||
|
||||
Stop with `Ctrl-C`. The signal cancels active work, waits for dispatch
|
||||
goroutines, stops capability and memory managers, removes Archie-labelled
|
||||
containers, closes NATS, and closes the SQLite stores.
|
||||
|
||||
## Run a standalone NATS worker
|
||||
|
||||
```bash
|
||||
NATS_URL=nats://127.0.0.1:4222 ./bin/archie-agent
|
||||
```
|
||||
|
||||
Require both `nats connected` and `archie-agent ready`. Stop with `Ctrl-C`.
|
||||
Do not use this to test subprocess mode.
|
||||
|
||||
## Run the repository Compose stack
|
||||
|
||||
| Repository command | Actual scope |
|
||||
|---|---|
|
||||
| `task docker-build` | Build only the `agent` image from `Dockerfile`. |
|
||||
| `task docker-up` | Start the Compose-managed NATS service. The profiled agent entry is not started. |
|
||||
| `task docker-logs` | Follow the NATS service logs. |
|
||||
| `task docker-down` | Run `docker compose down`. Does not request volume deletion. |
|
||||
|
||||
Prefer the narrow start:
|
||||
|
||||
```bash
|
||||
docker compose up -d nats
|
||||
```
|
||||
|
||||
Read-only observations:
|
||||
|
||||
```bash
|
||||
docker compose ps
|
||||
docker compose logs --tail=200 nats
|
||||
docker compose exec -T nats wget -q -O - http://localhost:8222/healthz
|
||||
```
|
||||
|
||||
```bash
|
||||
curl -fsS http://127.0.0.1:8484/api/summary
|
||||
curl -fsS http://127.0.0.1:8484/api/tasks
|
||||
```
|
||||
|
||||
Wait for the NATS healthcheck, then start `archied` on the host. Require the
|
||||
configured host supervisor to report it running and verify the dashboard API
|
||||
as the daemon readiness gate.
|
||||
|
||||
Stop with:
|
||||
|
||||
```bash
|
||||
task docker-down
|
||||
```
|
||||
|
||||
Never add `-v` during routine shutdown. The Compose `agent` service is a
|
||||
build-profile image definition, not a long-running service. Actual task workers
|
||||
are spawned by the host `archied` process through `/var/run/docker.sock`.
|
||||
|
||||
## Locate output and durable state
|
||||
|
||||
| Output or state | Current destination |
|
||||
|---|---|
|
||||
| Daemon logs | JSON on host stderr; the configured host supervisor captures them. |
|
||||
| Agent logs | JSON on worker/container stderr. Task containers use `AutoRemove`. |
|
||||
| Tasks and events | SQLite database at `<db_path>-tasks.sqlite`; default `~/.local/share/archie/archie.db-tasks.sqlite`. |
|
||||
| Chat sessions and messages | SQLite database at `<db_path>-conversations.sqlite`. |
|
||||
| Default task worktree | `<work_dir>/<owner>-<repo>/issue-<number>`; default root `~/.local/share/archie/work`. |
|
||||
| Identity worktree | `<work_dir>/identity-<identity>/<owner>-<repo>/issue-<number>`. |
|
||||
| Container worktree | Host worktree bind-mounted read/write at `/data/worktree`; `task.json` written under `.git/` so the agent's commit cannot sweep it onto the task branch. |
|
||||
| Built-in memory | `<work_dir>/memory/MEMORY.md` and `<work_dir>/memory/USER.md`. |
|
||||
| Telegram update state | `<work_dir>/telegram-update-deferrals.json` plus hashed `release-announcements-*.json`. |
|
||||
| Codesearch candidates | Defaults derive as `<work_dir>/indexes` and `<work_dir>/workspace-indexes.db`; no `indexing.Manager` construction found in daemon composition root. |
|
||||
| Optional repository volume | `archie-repo-<owner>-<repo>` mounted at `/data/repo`. |
|
||||
| Ecosystem cache volumes | `archie-cache-go`, `archie-cache-node`, etc., mounted below `/data/cache`. No code sets tool cache env vars to those mount paths. |
|
||||
| NATS data | Compose declares `nats_data:/data`; NATS command does not set a store directory. |
|
||||
|
||||
Compose runs NATS only; `archied` and all configured state paths remain on the
|
||||
host. The host daemon talks to the local Docker socket directly and bind-mounts
|
||||
each task worktree into the agent container it creates.
|
||||
|
||||
## Understand NATS and container observation
|
||||
|
||||
The `ARCHIE_TASKS` JetStream stream uses file storage and work-queue retention
|
||||
for `archie.task.>` and `archie.agent.>`.
|
||||
|
||||
| Plane | Subjects and behavior |
|
||||
|---|---|
|
||||
| Discovery | `archie.task.bug`, `.feature`, `.bootstrap`, or `.default`; daemon durable consumer `archie-daemon`, 5-min ack wait, max 3 deliveries. |
|
||||
| Per-stage requests | `archie.agent.<id>.request`; worker durable consumer defaults to `archie-agent`, 30-min ack wait, max 3 deliveries; response address in `X-Archie-Reply`. |
|
||||
| Container task | Core NATS request/reply on `archie.taskrun.<id>`. Task container reads `/data/worktree/.git/task.json` and creates dedicated subscription; shared worker uses queue group `archie-taskrun-workers`. |
|
||||
| Privileged RPC | Store operations go to the gRPC State Store (`internal/infrastructure/staterpc`, task-scoped grants); forge and worktree operations return to `archied` over core NATS subjects in `internal/forgerpc` and `internal/worktreerpc`. |
|
||||
|
||||
Set `containers.network` explicitly. `deployments/docker-nats-stack.toml` uses
|
||||
`archie-core_default`. Auto-detection inspects the daemon container; on failure,
|
||||
workers join Docker's default bridge and cannot resolve `nats`. Initial
|
||||
`ErrNoResponders` is retried for 20s at 250ms intervals.
|
||||
|
||||
If `nats.token_env` is configured, `archied` refuses startup when that variable
|
||||
is empty. It injects the resolved value as `NATS_TOKEN` into task containers.
|
||||
It forwards only configured provider-key variables.
|
||||
|
||||
## Fence current operational limitations
|
||||
|
||||
Open limitations until code/tests prove otherwise:
|
||||
|
||||
- `subprocess` + default `archie-agent` is protocol-incompatible.
|
||||
- A deployed overlay previously using legacy `token_env` still converts: the
|
||||
structured `forge.token` secret reference wins when both are present and
|
||||
`config.Forge.TokenEnv` is otherwise converted by
|
||||
`internal/infrastructure/configuration/defaults.go`.
|
||||
- Container RPC uses root forge/worktree for every identity.
|
||||
- Container orphan recovery lacks daemon-instance label.
|
||||
- `max_uptime` only bounds `Pool.Acquire` create/start; no lifetime timer.
|
||||
- Container workflow builds `TaskContext` without event bus.
|
||||
- SSE clients drop when channel full; replay at most 200 events.
|
||||
- Dashboard unauthenticated, includes mutating clear endpoint.
|
||||
|
||||
## Understand deployment and rollback seams
|
||||
|
||||
`.github/workflows/deploy.yml` gates on the release tags, then builds/pushes
|
||||
`archied:latest` and `archie-agent:latest` plus a versioned
|
||||
`linux/amd64` distribution zip attached to a GitHub Release. It injects
|
||||
component versions into labels/metadata and runs the quality gate before the
|
||||
Docker builds. The Gitea workflow that used to be the production build path was
|
||||
dropped (`dd9bddc2`); `deployments/*.toml` are the supported profiles.
|
||||
|
||||
Before promotion: record running image IDs/digests; config checksums (no
|
||||
secrets); task counts via safe GET; establish a SQLite backup procedure.
|
||||
|
||||
No complete rollback command exists, no versioned image tags. Restoring a binary
|
||||
does not undo forge changes, task transitions, or data-format changes.
|
||||
|
||||
## Treat carina facts as unverified external state
|
||||
|
||||
Repository guidance (2026-09-18): two instances on `carina` with distinct
|
||||
`bot_user` values. No live process list, config, image digest, service manager,
|
||||
or deployment was verified. Do not invent SSH, systemd, or service commands.
|
||||
@@ -1,4 +0,0 @@
|
||||
interface:
|
||||
display_name: "Run and Operate Archie"
|
||||
short_description: "Run Archie safely and locate its operational state"
|
||||
default_prompt: "Use $archie-run-and-operate to start Archie locally, inspect its runtime state, and stop it safely."
|
||||
+5
-1
@@ -33,6 +33,7 @@ bd dolt push
|
||||
### Working with Issues
|
||||
|
||||
Issues in Beads are:
|
||||
|
||||
- **Git-native**: Stored in Dolt database with version control and branching
|
||||
- **AI-friendly**: CLI-first design works perfectly with AI coding agents
|
||||
- **Branch-aware**: Issues can follow your branch workflow
|
||||
@@ -41,16 +42,19 @@ Issues in Beads are:
|
||||
## Why Beads?
|
||||
|
||||
✨ **AI-Native Design**
|
||||
|
||||
- Built specifically for AI-assisted development workflows
|
||||
- CLI-first interface works seamlessly with AI coding agents
|
||||
- No context switching to web UIs
|
||||
|
||||
🚀 **Developer Focused**
|
||||
|
||||
- Issues live in your repo, right next to your code
|
||||
- Works offline, syncs when you push
|
||||
- Fast, lightweight, and stays out of your way
|
||||
|
||||
🔧 **Git Integration**
|
||||
|
||||
- Dolt-native sync via bd dolt push / bd dolt pull
|
||||
- Branch-aware issue tracking
|
||||
- Dolt-native three-way merge resolution
|
||||
@@ -78,4 +82,4 @@ bd create "Try out Beads"
|
||||
|
||||
---
|
||||
|
||||
*Beads: Issue tracking that moves at the speed of thought* ⚡
|
||||
_Beads: Issue tracking that moves at the speed of thought_ ⚡
|
||||
+11
-11
@@ -54,15 +54,15 @@
|
||||
# Disabled by default; enable only when an integration needs fresh .beads/issues.jsonl.
|
||||
# Use relative paths under .beads/ for JSONL import/export filenames.
|
||||
export:
|
||||
auto: false
|
||||
path: issues.jsonl
|
||||
interval: 60s
|
||||
# issues.jsonl/interactions.jsonl are .gitignore'd local-only files --
|
||||
# Dolt (synced via sync.remote) is the source of truth. Leave auto off
|
||||
# and git-add off; do not re-track these in git.
|
||||
git-add: false
|
||||
auto: false
|
||||
path: issues.jsonl
|
||||
interval: 60s
|
||||
# issues.jsonl/interactions.jsonl are .gitignore'd local-only files --
|
||||
# Dolt (synced via sync.remote) is the source of truth. Leave auto off
|
||||
# and git-add off; do not re-track these in git.
|
||||
git-add: false
|
||||
import:
|
||||
path: issues.jsonl
|
||||
path: issues.jsonl
|
||||
# Integration settings (access with 'bd config get/set')
|
||||
# Non-secret keys (stored in the database):
|
||||
# - jira.url, jira.project
|
||||
@@ -74,7 +74,7 @@ import:
|
||||
# - github.token → use GITHUB_TOKEN env var instead
|
||||
sync.remote: "git+https://github.com/samcharles93/archie-core.git"
|
||||
dolt:
|
||||
shared-server: false
|
||||
auto-commit: "on"
|
||||
shared-server: false
|
||||
auto-commit: "on"
|
||||
audit:
|
||||
enabled: true
|
||||
enabled: true
|
||||
@@ -5,4 +5,4 @@
|
||||
"dolt_database": "archie_core",
|
||||
"project_id": "e8a66150-1f5f-42d2-8653-dcf8463cef74",
|
||||
"last_bd_version": "1.2.2"
|
||||
}
|
||||
}
|
||||
+140
-40
@@ -12,14 +12,14 @@ on:
|
||||
# preceding fix, say) previously queued a full gate+build for each one,
|
||||
# several minutes apiece, with no caching -- so a burst of pushes left
|
||||
# three deploys racing in parallel for the same runner capacity. Only the
|
||||
# last one's images matter (both jobs push :latest), so cancel a
|
||||
# last one's images matter (each job pushes its image tags), so cancel a
|
||||
# superseded run rather than let it fight for resources it can't use.
|
||||
#
|
||||
# Keyed on the commit, not github.ref: `git push --follow-tags` pushes
|
||||
# main plus both archied/v* and archie/v* tags in one go, and all three
|
||||
# refs point at the same commit -- on.push matches branches and tags
|
||||
# both, so a single release push otherwise fires three redundant builds
|
||||
# of identical content that a ref-keyed group can't see as the same work.
|
||||
# Keyed on the commit, not github.ref: a release push lands main and its
|
||||
# tag in one go, both pointing at the same commit -- on.push matches
|
||||
# branches and tags both, so a single release push otherwise fires
|
||||
# redundant builds of identical content that a ref-keyed group can't see
|
||||
# as the same work.
|
||||
concurrency:
|
||||
group: deploy-${{ github.sha }}
|
||||
cancel-in-progress: true
|
||||
@@ -68,10 +68,27 @@ jobs:
|
||||
run: |
|
||||
go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.13.2
|
||||
go install mvdan.cc/gofumpt@v0.11.0
|
||||
go install github.com/go-task/task/v3/cmd/task@v3.48.0
|
||||
|
||||
- name: Install protobuf tools
|
||||
run: bash tools/proto.sh install
|
||||
|
||||
# The backup/restore tests shell out to pg_dump/pg_restore against a
|
||||
# postgres:18 testcontainer; the runner's stock client is older and
|
||||
# refuses the server version.
|
||||
- name: Install PostgreSQL 18 client
|
||||
run: |
|
||||
sudo install -d /usr/share/postgresql-common/pgdg
|
||||
sudo curl --fail --silent --show-error --location \
|
||||
https://www.postgresql.org/media/keys/ACCC4CF8.asc \
|
||||
--output /usr/share/postgresql-common/pgdg/apt.postgresql.org.asc
|
||||
. /etc/os-release
|
||||
echo "deb [signed-by=/usr/share/postgresql-common/pgdg/apt.postgresql.org.asc] https://apt.postgresql.org/pub/repos/apt ${VERSION_CODENAME}-pgdg main" \
|
||||
| sudo tee /etc/apt/sources.list.d/pgdg.list
|
||||
sudo apt-get update
|
||||
sudo apt-get install -y --no-install-recommends postgresql-client-18
|
||||
echo "/usr/lib/postgresql/18/bin" >> $GITHUB_PATH
|
||||
|
||||
- name: Ensure contract baseline ref
|
||||
run: |
|
||||
if ! git show-ref --verify --quiet refs/heads/main; then
|
||||
@@ -81,10 +98,20 @@ jobs:
|
||||
- name: Install ripgrep
|
||||
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends ripgrep
|
||||
|
||||
# Extensions run in an unprivileged user and network namespace, which
|
||||
# Ubuntu 24.04 runners forbid through AppArmor by default.
|
||||
- name: Allow unprivileged user namespaces
|
||||
run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
|
||||
|
||||
- name: Quality gate
|
||||
run: |
|
||||
go fix ./...
|
||||
golangci-lint fmt
|
||||
# The formatter sequence has one owner: task fmt, which drives go fix
|
||||
# to a fixpoint and then the configured lint formatters. This step
|
||||
# used to inline its own single `go fix ./...`, which leaves the
|
||||
# redundant loop-variable copy that copyloopvar rejects -- the hazard
|
||||
# of archie-core-wwho, surfacing here as a spurious git-diff failure
|
||||
# (archie-core-6kda).
|
||||
task fmt
|
||||
git diff --exit-code
|
||||
bash tools/proto.sh lint
|
||||
bash tools/proto.sh check
|
||||
@@ -139,11 +166,11 @@ jobs:
|
||||
echo "edit the generated notes, then: task release VERSION=<ver>"
|
||||
exit 1
|
||||
fi
|
||||
if ! git tag --points-at HEAD | grep -qE 'archie' ; then
|
||||
echo "::warning ::No release tags at HEAD, so this build publishes :latest for a commit that is not a release. It is stamped dev+<sha> and tagged sha-<sha> so it stays traceable and restorable, but it supersedes the previous release's :latest stamping until the next release is cut."
|
||||
if ! git tag --points-at HEAD | grep -qE '^(v[0-9]|archied/v|archie/v)' ; then
|
||||
echo "This commit is not a release, so the images are published as :edge and sha-<sha>; :latest keeps naming the newest release."
|
||||
fi
|
||||
|
||||
build-and-push:
|
||||
archied-image:
|
||||
needs: gate
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
@@ -176,22 +203,51 @@ jobs:
|
||||
run: |
|
||||
GATEWAY_TAG="$(git tag --points-at HEAD --list 'archied/v*' | sort -V | tail -1)"
|
||||
RUNTIME_TAG="$(git tag --points-at HEAD --list 'archie/v*' | sort -V | tail -1)"
|
||||
# One release stream: a `v*` tag covers the whole release, so it names
|
||||
# both components' versions. Legacy per-component tags still win where
|
||||
# they exist, because history is not re-tagged.
|
||||
RELEASE_TAG="$(git tag --points-at HEAD --list 'v*' | sort -V | tail -1)"
|
||||
GATEWAY_VERSION="${GATEWAY_TAG#archied/}"
|
||||
RUNTIME_VERSION="${RUNTIME_TAG#archie/}"
|
||||
# Not a bare `dev`. A literal dev tells an operator nothing about which
|
||||
# build they are running, and it is what made a release's stamping look
|
||||
# transient: the next commit to main republished :latest as `dev`. The
|
||||
# commit is appended so a main build is identifiable and is visibly not
|
||||
# a release. (On an untagged push GITHUB_SHA IS the commit — the tag
|
||||
# case is handled by the dereference above.)
|
||||
[ -n "$GATEWAY_VERSION" ] || GATEWAY_VERSION="${RELEASE_TAG#v}"
|
||||
[ -n "$RUNTIME_VERSION" ] || RUNTIME_VERSION="${RELEASE_TAG#v}"
|
||||
# `dev+<sha>` is what a build that is NOT a release reports, and it is
|
||||
# honest now that such a build no longer publishes :latest: the version
|
||||
# names the commit it came from, and the sha-<sha> tag makes it
|
||||
# restorable. Before, this same string reached :latest minutes after a
|
||||
# release and made the release's own stamping read as dev
|
||||
# (archie-core-i5nb). (On an untagged push GITHUB_SHA IS the commit —
|
||||
# the tag case is handled by the dereference above.)
|
||||
[ -n "$GATEWAY_VERSION" ] || GATEWAY_VERSION="dev+${GITHUB_SHA:0:12}"
|
||||
[ -n "$RUNTIME_VERSION" ] || RUNTIME_VERSION="dev+${GITHUB_SHA:0:12}"
|
||||
# Keep the raw tag presence separate from the version fallback:
|
||||
# gateway-only releases must not rebuild the runtime image as dev.
|
||||
# Keep the raw tag presence separate from the version fallback: a
|
||||
# LEGACY gateway-only release (archied/v* and no archie/v*) must not
|
||||
# rebuild the runtime image as dev. A one-stream `v*` release is not
|
||||
# gateway-only -- one version covers the runtime too -- so it does
|
||||
# rebuild it, and release_tag is what tells the two apart.
|
||||
echo "gateway_tag=$GATEWAY_TAG" >> "$GITHUB_OUTPUT"
|
||||
echo "runtime_tag=$RUNTIME_TAG" >> "$GITHUB_OUTPUT"
|
||||
echo "release_tag=$RELEASE_TAG" >> "$GITHUB_OUTPUT"
|
||||
echo "gateway=$GATEWAY_VERSION" >> "$GITHUB_OUTPUT"
|
||||
echo "runtime=$RUNTIME_VERSION" >> "$GITHUB_OUTPUT"
|
||||
# :latest names the newest RELEASE, so only a commit that IS one
|
||||
# publishes it. A push to main publishes :edge (mutable, newest main)
|
||||
# and sha-<sha> (immutable) instead. That is what stops a release's
|
||||
# :latest stamping from being overwritten minutes later by the next
|
||||
# ordinary commit, which left a host reporting dev and made the update
|
||||
# path unable to tell current from stale (archie-core-i5nb).
|
||||
#
|
||||
# `if` blocks rather than `[ -n "$X" ] && echo`: the latter returns
|
||||
# non-zero when the test fails, and these steps run under `set -e`.
|
||||
{
|
||||
echo "archied_tags<<EOF"
|
||||
if [ -n "$RELEASE_TAG" ]; then
|
||||
echo "ghcr.io/samcharles93/archied:latest"
|
||||
fi
|
||||
echo "ghcr.io/samcharles93/archied:edge"
|
||||
echo "ghcr.io/samcharles93/archied:sha-${{ steps.commit.outputs.sha }}"
|
||||
echo "EOF"
|
||||
} >> "$GITHUB_OUTPUT"
|
||||
|
||||
- name: Build and push archied
|
||||
uses: docker/build-push-action@v6
|
||||
@@ -199,17 +255,53 @@ jobs:
|
||||
context: .
|
||||
file: Dockerfile.archied
|
||||
push: true
|
||||
tags: |
|
||||
ghcr.io/samcharles93/archied:latest
|
||||
ghcr.io/samcharles93/archied:sha-${{ steps.commit.outputs.sha }}
|
||||
tags: ${{ steps.versions.outputs.archied_tags }}
|
||||
build-args: |
|
||||
GATEWAY_VERSION=${{ steps.versions.outputs.gateway }}
|
||||
RUNTIME_VERSION=${{ steps.versions.outputs.runtime }}
|
||||
cache-from: type=gha,scope=archied
|
||||
cache-to: type=gha,mode=max,scope=archied
|
||||
|
||||
|
||||
agent-image:
|
||||
outputs:
|
||||
agent_digest: ${{ steps.agent.outputs.digest }}
|
||||
needs: gate
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- name: Checkout
|
||||
uses: actions/checkout@v4
|
||||
with:
|
||||
fetch-depth: 0
|
||||
|
||||
# Annotated tags: dereference to the commit, as archied-image does.
|
||||
- name: Resolve the commit this ref points at
|
||||
id: commit
|
||||
run: |
|
||||
sha="$(git rev-parse "${GITHUB_REF}^{commit}")"
|
||||
echo "sha=$sha" >> "$GITHUB_OUTPUT"
|
||||
echo "short=${sha:0:12}" >> "$GITHUB_OUTPUT"
|
||||
|
||||
- name: Set up Docker Buildx
|
||||
uses: docker/setup-buildx-action@v3
|
||||
|
||||
- name: Log in to GHCR
|
||||
run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin
|
||||
|
||||
- name: Resolve runtime version
|
||||
id: versions
|
||||
run: |
|
||||
RUNTIME_TAG="$(git tag --points-at HEAD --list 'archie/v*' | sort -V | tail -1)"
|
||||
RELEASE_TAG="$(git tag --points-at HEAD --list 'v*' | sort -V | tail -1)"
|
||||
RUNTIME_VERSION="${RUNTIME_TAG#archie/}"
|
||||
[ -n "$RUNTIME_VERSION" ] || RUNTIME_VERSION="${RELEASE_TAG#v}"
|
||||
echo "runtime_tag=$RUNTIME_TAG" >> "$GITHUB_OUTPUT"
|
||||
echo "release_tag=$RELEASE_TAG" >> "$GITHUB_OUTPUT"
|
||||
echo "runtime=$RUNTIME_VERSION" >> "$GITHUB_OUTPUT"
|
||||
|
||||
- name: Build and push archie-agent
|
||||
if: steps.versions.outputs.runtime_tag != ''
|
||||
id: agent
|
||||
if: steps.versions.outputs.runtime_tag != '' || steps.versions.outputs.release_tag != ''
|
||||
uses: docker/build-push-action@v6
|
||||
with:
|
||||
context: .
|
||||
@@ -224,16 +316,12 @@ jobs:
|
||||
cache-to: type=gha,mode=max,scope=archie-agent
|
||||
|
||||
# Packages every host-run binary (archied, archie-gateway,
|
||||
# archie-state-store, archie-ui, archie-messaging, archie-playbooks) as a
|
||||
# archie-state-store, archie-ui, archie-messaging) as a
|
||||
# linux/amd64 zip for a
|
||||
# non-Docker install. Independent of build-and-push: it never touches the
|
||||
# archied/archie-agent image jobs, and a gateway-only release (no
|
||||
# archie/v* tag) still produces this zip -- it's keyed to the archied tag
|
||||
# alone. archie-agent is deliberately excluded: it only ever runs inside
|
||||
# the Docker image build-and-push already publishes, never as a host
|
||||
# binary (archie-core-8cda.4.7.1).
|
||||
# non-Docker install. It waits only for the agent image, whose digest
|
||||
# release.json pins; archie-agent itself never ships as a host binary.
|
||||
dist-zip:
|
||||
needs: gate
|
||||
needs: [gate, agent-image]
|
||||
# Not gated on github.ref. A release is pushed as main plus both tags at
|
||||
# one SHA, the concurrency group below collapses those into a single run,
|
||||
# and the survivor is whichever ref happened to start last -- for
|
||||
@@ -278,9 +366,9 @@ jobs:
|
||||
# ran on with a dead Telegram bot and no error anywhere
|
||||
# (archie-core-1c01). TestDistZipShipsEveryHostCommand fails if this
|
||||
# list and the copy list below stop matching the commands in cmd/.
|
||||
ldflags="-X github.com/samcharles93/archie-core/internal/app/archied.gatewayVersion=${{ steps.version.outputs.version }} -X github.com/samcharles93/archie-core/internal/installtype.buildType=binary -X github.com/samcharles93/archie-core/internal/buildinfo.Version=${{ steps.version.outputs.version }}"
|
||||
ldflags="-X github.com/samcharles93/archie-core/internal/installtype.buildType=binary -X github.com/samcharles93/archie-core/internal/buildinfo.Version=${{ steps.version.outputs.version }} -X github.com/samcharles93/archie-core/internal/buildinfo.Runtime=${{ steps.version.outputs.version }}"
|
||||
mkdir -p dist
|
||||
for cmd in archied archie-gateway archie-state-store archie-ui archie-messaging archie-playbooks; do
|
||||
for cmd in $(jq -r '.required_topology.units[]' release.json); do
|
||||
go build -ldflags "$ldflags" -o "dist/$cmd" "./cmd/$cmd"
|
||||
done
|
||||
|
||||
@@ -290,19 +378,28 @@ jobs:
|
||||
set -e
|
||||
name="archie-core-archied-v${{ steps.version.outputs.version }}-linux-amd64"
|
||||
mkdir -p "$name"
|
||||
cp dist/archied dist/archie-gateway dist/archie-state-store dist/archie-ui dist/archie-messaging dist/archie-playbooks "$name/"
|
||||
for cmd in $(jq -r '.required_topology.units[]' release.json); do
|
||||
cp "dist/$cmd" "$name/"
|
||||
done
|
||||
cp deployments/INSTRUCTIONS.md CHANGELOG.md "$name/"
|
||||
cp scripts/archie-update-* "$name/"
|
||||
digest='${{ needs.agent-image.outputs.agent_digest }}'
|
||||
test -n "$digest"
|
||||
jq --arg image "ghcr.io/samcharles93/archie-agent@$digest" '. + {agent_image: $image}' release.json > "$name/release.json"
|
||||
# README.md doesn't exist yet in this repo; include it once it does
|
||||
# rather than fail the release on its absence.
|
||||
[ -f README.md ] && cp README.md "$name/"
|
||||
zip -r "$name.zip" "$name"
|
||||
sha256sum "$name.zip" > SHA256SUMS
|
||||
echo "name=$name" >> "$GITHUB_OUTPUT"
|
||||
|
||||
- name: Upload distribution zip
|
||||
uses: actions/upload-artifact@v4
|
||||
with:
|
||||
name: ${{ steps.zip.outputs.name }}
|
||||
path: ${{ steps.zip.outputs.name }}.zip
|
||||
path: |
|
||||
${{ steps.zip.outputs.name }}.zip
|
||||
SHA256SUMS
|
||||
retention-days: 90
|
||||
|
||||
# A Release is what an operator can actually download from; the
|
||||
@@ -311,8 +408,8 @@ jobs:
|
||||
# zip was produced and then stranded -- the only Release on this repo
|
||||
# (archied/v1.22.0) was created by hand and carries no asset at all.
|
||||
#
|
||||
# Attached to the *archied* tag because the zip is named and versioned
|
||||
# for archied, and `--follow-tags` pushes both tags at one commit.
|
||||
# Attached to the release's v* tag, or the archied tag for a release
|
||||
# cut before the single release stream.
|
||||
# --generate-notes is deliberately not used: the changelog section is
|
||||
# the release's own reviewed prose, and the tag/changelog gate above
|
||||
# already guarantees it describes this version.
|
||||
@@ -321,7 +418,10 @@ jobs:
|
||||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
run: |
|
||||
set -e
|
||||
tag="archied/v${{ steps.version.outputs.version }}"
|
||||
tag="v${{ steps.version.outputs.version }}"
|
||||
if ! git ls-remote --exit-code --tags origin "refs/tags/$tag" >/dev/null; then
|
||||
tag="archied/v${{ steps.version.outputs.version }}"
|
||||
fi
|
||||
version="${{ steps.version.outputs.version }}"
|
||||
# The release body is this version's changelog section, not the whole
|
||||
# file: from its "## [x.y.z]" heading to the next "## [" heading.
|
||||
@@ -342,11 +442,11 @@ jobs:
|
||||
# alone, so a re-run of this job (a retried or superseded deploy)
|
||||
# cannot fail on an existing Release or duplicate the zip.
|
||||
if gh release view "$tag" >/dev/null 2>&1; then
|
||||
gh release upload "$tag" "${{ steps.zip.outputs.name }}.zip" --clobber
|
||||
gh release upload "$tag" "${{ steps.zip.outputs.name }}.zip" SHA256SUMS --clobber
|
||||
else
|
||||
gh release create "$tag" \
|
||||
--title "archied v$version" \
|
||||
--notes-file "$notes" \
|
||||
"${{ steps.zip.outputs.name }}.zip"
|
||||
"${{ steps.zip.outputs.name }}.zip" SHA256SUMS
|
||||
fi
|
||||
echo "published $tag with ${{ steps.zip.outputs.name }}.zip"
|
||||
@@ -1,48 +0,0 @@
|
||||
name: docs
|
||||
|
||||
# Verification only. Deployment happens from the Ansible control node
|
||||
# (vectislabs.automation docs_site role against nebula), so there is nothing
|
||||
# for CI to publish. What CI is for here is catching a docs change that will
|
||||
# not build before it reaches a deploy.
|
||||
on:
|
||||
push:
|
||||
branches: [main]
|
||||
paths:
|
||||
- "docs/**"
|
||||
- "mkdocs.yml"
|
||||
- ".github/workflows/docs.yml"
|
||||
pull_request:
|
||||
paths:
|
||||
- "docs/**"
|
||||
- "mkdocs.yml"
|
||||
workflow_dispatch:
|
||||
|
||||
permissions:
|
||||
contents: read
|
||||
|
||||
concurrency:
|
||||
group: docs-${{ github.ref }}
|
||||
cancel-in-progress: true
|
||||
|
||||
jobs:
|
||||
build:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v5
|
||||
|
||||
# No `cache: pip` here: this repository is Go and has no
|
||||
# requirements.txt or pyproject.toml for setup-python to hash. Asking for
|
||||
# a pip cache makes the step fail outright with "No file ... matched to
|
||||
# [**/requirements.txt or **/pyproject.toml]", so every docs-touching PR
|
||||
# failed before `mkdocs build --strict` ever ran -- which also meant the
|
||||
# strict link/config check silently stopped guarding anything.
|
||||
- uses: actions/setup-python@v6
|
||||
with:
|
||||
python-version: "3.13"
|
||||
|
||||
- run: pip install mkdocs-material
|
||||
|
||||
# --strict fails on a broken internal link or an unknown config key. A
|
||||
# docs site that silently ships dead links is worse than one that refuses
|
||||
# to ship.
|
||||
- run: mkdocs build --strict
|
||||
@@ -36,8 +36,25 @@ jobs:
|
||||
go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.13.2
|
||||
go install mvdan.cc/gofumpt@v0.11.0
|
||||
bash tools/proto.sh install
|
||||
|
||||
sudo apt-get update
|
||||
sudo apt-get install -y --no-install-recommends ripgrep
|
||||
sudo install -d /usr/share/postgresql-common/pgdg
|
||||
sudo curl --fail --silent --show-error --location \
|
||||
https://www.postgresql.org/media/keys/ACCC4CF8.asc \
|
||||
--output /usr/share/postgresql-common/pgdg/apt.postgresql.org.asc
|
||||
|
||||
. /etc/os-release
|
||||
echo "deb [signed-by=/usr/share/postgresql-common/pgdg/apt.postgresql.org.asc] https://apt.postgresql.org/pub/repos/apt ${VERSION_CODENAME}-pgdg main" \
|
||||
| sudo tee /etc/apt/sources.list.d/pgdg.list
|
||||
|
||||
sudo apt-get update
|
||||
sudo apt-get install -y --no-install-recommends postgresql-client-18
|
||||
|
||||
echo "/usr/lib/postgresql/18/bin" >> $GITHUB_PATH
|
||||
|
||||
pg_dump --version
|
||||
pg_restore --version
|
||||
|
||||
- name: Ensure contract baseline ref
|
||||
run: |
|
||||
@@ -45,6 +62,11 @@ jobs:
|
||||
git branch main origin/main
|
||||
fi
|
||||
|
||||
# Extensions run in an unprivileged user and network namespace, which
|
||||
# Ubuntu 24.04 runners forbid through AppArmor by default.
|
||||
- name: Allow unprivileged user namespaces
|
||||
run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
|
||||
|
||||
- name: Run definitive gate
|
||||
run: |
|
||||
task check
|
||||
|
||||
+3
-7
@@ -7,7 +7,6 @@
|
||||
.env
|
||||
task.json
|
||||
|
||||
.hermes-carina/
|
||||
config.production.toml
|
||||
.gotmp/
|
||||
|
||||
@@ -37,9 +36,6 @@ config.production.toml
|
||||
.beads-credential-key
|
||||
.beads/proxieddb/
|
||||
*.gate.lock*
|
||||
# Impeccable design-tool scratch/critique snapshots (usable by $impeccable polish, never committed)
|
||||
.impeccable/
|
||||
.serena/
|
||||
.beads/issues.jsonl
|
||||
.beads/interactions.jsonl
|
||||
.mcp.json
|
||||
@@ -49,10 +45,10 @@ config.production.toml
|
||||
__pycache__/
|
||||
*.pyc
|
||||
|
||||
# MkDocs build output (task docs:site)
|
||||
/site/
|
||||
|
||||
# Locally-trusted development certificates (mkcert and friends). The private
|
||||
# key is generated per machine and must never be committed.
|
||||
*.pem
|
||||
*.key
|
||||
|
||||
# Local symlink to the archipelago marketplace repo
|
||||
/archipelago
|
||||
+29
-6
@@ -29,6 +29,7 @@ linters:
|
||||
- nestif
|
||||
|
||||
# Architecture
|
||||
- depguard
|
||||
- importas
|
||||
- interfacebloat
|
||||
|
||||
@@ -61,6 +62,34 @@ linters:
|
||||
- usetesting
|
||||
|
||||
settings:
|
||||
# Each service links only its own composition: services reach each other
|
||||
# through their gRPC contracts, never another service's packages.
|
||||
depguard:
|
||||
rules:
|
||||
gateway-service:
|
||||
files: ["**/internal/app/archiegateway/**"]
|
||||
deny:
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/daemon", desc: "the daemon is another service"}
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/webui", desc: "the web UI is another service"}
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/app/archied", desc: "the daemon is another service"}
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/app/statestore", desc: "reach the State Store through its contract"}
|
||||
state-store-service:
|
||||
files: ["**/internal/app/statestore/**"]
|
||||
deny:
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/daemon", desc: "the daemon is another service"}
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/webui", desc: "the web UI is another service"}
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/gateway", desc: "the Gateway is another service"}
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/app/archied", desc: "the daemon is another service"}
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/app/archiegateway", desc: "the Gateway is another service"}
|
||||
- {pkg: "github.com/nats-io", desc: "the State Store serves gRPC only"}
|
||||
shared:
|
||||
files: ["**/internal/app/servicekit/**", "**/internal/app/chattask/**"]
|
||||
deny:
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/daemon", desc: "shared code must not pull in a service"}
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/webui", desc: "shared code must not pull in a service"}
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/app/archied", desc: "shared code must not pull in a service"}
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/app/archiegateway", desc: "shared code must not pull in a service"}
|
||||
- {pkg: "github.com/samcharles93/archie-core/internal/app/statestore", desc: "shared code must not pull in a service"}
|
||||
cyclop:
|
||||
max-complexity: 15
|
||||
dupl:
|
||||
@@ -142,12 +171,6 @@ formatters:
|
||||
custom-order: true
|
||||
exclusions:
|
||||
generated: strict
|
||||
# These Yaegi programs sit behind //go:build ignore, so a formatter cannot
|
||||
# type-check them: rewriting their imports deletes the genuinely used
|
||||
# internal/secret import and the interpreter can no longer load them.
|
||||
# Excluded from every formatter so adding one cannot reintroduce that.
|
||||
paths:
|
||||
- ^examples/secret-engines/(age|sops|vault)\.go$
|
||||
|
||||
issues:
|
||||
# 0 = report everything. The defaults (50 per linter, 3 per message)
|
||||
|
||||
@@ -0,0 +1,4 @@
|
||||
# Generated output: only its generator writes it, and the gate byte-checks it.
|
||||
docs/data/generated/
|
||||
internal/contracts/
|
||||
ui/dist/
|
||||
-436
@@ -1,436 +0,0 @@
|
||||
# archie-core Architecture
|
||||
|
||||
**archied** is a resident daemon that discovers forge work — GitHub and Gitea
|
||||
issues assigned to its bot user, carrying its label, or either (`dispatch`
|
||||
mode, per identity) — by polling (the default) or, single-identity
|
||||
deployments only, reacting to forge webhook events the instant they arrive
|
||||
(`Forge.Intake` = `webhook`/`both`, see `docs/prds/event-sources-and-
|
||||
reactions.md`), works each matched issue in an isolated worktree through a
|
||||
routed workflow, and opens pull requests for human review. A single daemon can
|
||||
serve several identities across several forges, each with its own `bot_user`,
|
||||
label, and repository set.
|
||||
|
||||
## Package Map
|
||||
|
||||
This lists the load-bearing packages, not all of them — `internal/` holds ~36.
|
||||
The domain migration is in progress (`internal/domain/`,
|
||||
`internal/infrastructure/`), so **the tree is authoritative over this table**.
|
||||
See `docs/architecture/organisation.md` for the target structure and
|
||||
`docs/architecture/migration-decisions.md` for the current position.
|
||||
|
||||
| Package | Role |
|
||||
| ---------------------------- | ------------------------------------------------------------------------- |
|
||||
| `cmd/archied/` | Binary entry: config→forge→store→runtime→workflows→daemon |
|
||||
| `cmd/archie-agent/` | Binary entry: flags, environment, signals, and agentworker invocation |
|
||||
| `internal/app/agentworker/` | Agent worker composition, lifecycle, routing, and workflow execution |
|
||||
| `internal/infrastructure/agentboot/` | Worker boot-brief filesystem decoding |
|
||||
| `internal/infrastructure/agentgit/` | Worker git safe-directory setup |
|
||||
| `internal/infrastructure/agenttransport/nats/` | Worker core-NATS full-task handoff and RPC client construction |
|
||||
| `internal/config/` | Config types only — loading lives in `infrastructure/configuration` |
|
||||
| `internal/daemon/` | Resident loop: poll, enqueue, claim, route, process, reconcile |
|
||||
| `internal/domain/workflow/` | Engine: stage lists, routing, shared steps, workflow definitions |
|
||||
| `internal/domain/workflow/task/` | Task-execution vocabulary (`Task`, statuses, mid-run `Store`, `Definition`) importable without the engine |
|
||||
| `internal/domain/messaging/` | Canonical messages plus the chat wire contracts (`ChatContract`, sessions, turns, streaming) shared by gateway, channels, webui, and archie-ui |
|
||||
| `internal/channels/status/` | Operator-facing channel lifecycle ledger (`State`/`Descriptor`/`Status`/`Manager`); the plugin contract stays in `internal/channels` |
|
||||
| `internal/app/archiemessaging/` | Messaging Service composition: Telegram/email/webhook channels, dialling the Gateway's `ChatContract` over gRPC. The daemon runs no channel and builds no `gateway.Router` |
|
||||
| `internal/domain/workintake/`| `TaskEnvelope`, routing `Kind`, label vocabulary, task subjects |
|
||||
| `internal/agentexec/` | Worker-local stage protocol and ai-sdk loop runner |
|
||||
| `internal/forge/` | Forge interface: GitHub and Gitea implementations |
|
||||
| `internal/forge/webhook/` | Optional forge webhook receiver: GitHub issue events → `workintake.TaskEnvelope`, same publish path as polling |
|
||||
| `internal/webhookguard/` | Cross-cutting inbound-webhook mechanics: HMAC verification, per-source rate limiting |
|
||||
| `internal/worktree/` | Git operations: clone, branch, commit, push, diff, cleanup |
|
||||
| `internal/store/` | Task/capture/mapping/binding SQLite implementation; producer-owned contract interfaces live in `internal/domain/storecontract` (aliases kept here) |
|
||||
| `internal/domain/storecontract/` | Producer-owned State Store read contracts consumed by webui, intake, and the gRPC adapters (state-store-contract rev. 2d) |
|
||||
| `internal/events/` | In-process event bus: publish/subscribe for observability |
|
||||
| `internal/infrastructure/` | Config loading, eventbus transport, model catalog |
|
||||
| `internal/webui/` | Shared dashboard HTTP layer served by the archie-ui process |
|
||||
| `internal/gateway/` (18.7k LOC) | Persistent-connection layer between archie and its users (Telegram, web UI, etc.); shared CommandRouter for dispatch |
|
||||
| `internal/tools/` (20.9k LOC) | Central tool subsystem: built-in tool implementations, approval, execution contract |
|
||||
| `internal/domain/memory/` | Memory engine contract: four typed scopes, CRUD + revisions, content scanner |
|
||||
| `internal/infrastructure/memory/` | Builtin memory engine + its `builtin/` markdown store |
|
||||
| `internal/secret/` | Secret reference resolution across named engines (env, vault, etc.) |
|
||||
| `internal/plugin/` | Core plugin interface: Yaegi-interpreted `.go` plugins loaded from `~/.config/archie/plugins/` and registered with the daemon's extension registry |
|
||||
| `internal/skill/` | Parses and discovers agentskills.io `SKILL.md` files |
|
||||
| `ai-sdk/runtime` | External: provider-agnostic LLM runtime |
|
||||
| `ai-sdk/agentloop` | External: gated agent loop with budgets and tool jails |
|
||||
| `ai-sdk/core` | External: tool definitions, generate options |
|
||||
|
||||
## Task Lifecycle
|
||||
|
||||
```
|
||||
queued → running(workflow:stage) → pr_open → merged | rejected
|
||||
↓
|
||||
waiting_human → (human approves) → queued(implement)
|
||||
↓
|
||||
parked
|
||||
```
|
||||
|
||||
**Crash recovery:** tasks left in `running` are re-queued on startup. Parks are
|
||||
never silent, but they no longer comment on the forge issue: the reason is
|
||||
recorded on the task as `park_reason` (cleared on requeue) and surfaced by the
|
||||
dashboard and `/api/tasks`. Retries are an explicit operator action capped by
|
||||
`max_retries`, not a label a human removes.
|
||||
|
||||
**Adversarial review:** the implement workflow runs a fresh adversarial review
|
||||
after the deterministic gates and before `pr_open` (see
|
||||
`docs/architecture/adversarial-review.md`). A surviving blocking finding — or a
|
||||
review that failed to run — parks the task with the findings as its
|
||||
`park_reason`; otherwise the PR opens with a findings section on its body.
|
||||
Opt-in per repo via `repo.review_enabled`.
|
||||
|
||||
**PR reconciliation:** the daemon polls open PRs, checks GitHub state
|
||||
(`merged`/`closed`), transitions the task, and cleans up worktrees.
|
||||
|
||||
**Provenance by origin:** a task's origin determines which enqueue path
|
||||
created it, though every origin converges on the same `tasks` table and the
|
||||
same `Route`/`Run` lifecycle above once queued. Forge-sourced tasks — whether
|
||||
discovered by polling or, single-identity only, delivered by the forge
|
||||
webhook receiver (`internal/forge/webhook`) — enqueue via the same
|
||||
`workintake.TaskEnvelope` and `PublishTask` path (see `docs/prds/event-sources-
|
||||
and-reactions.md`'s decided contract); `TaskEnvelope.IdempotencyKey` is keyed
|
||||
on `owner/repo/number`, not delivery source, so a webhook-delivered issue and
|
||||
a later poll of the same issue dedup for free instead of double-enqueuing.
|
||||
Playbook-binding-dispatched tasks enqueue
|
||||
via `EnqueueChatTask`/`EnqueueBindingTask` (`internal/store`), the same direct
|
||||
path chat-spawned tasks use, stamped with `binding_id`/`binding_version` for
|
||||
provenance. See `docs/architecture/bindings.md` for the binding model and its
|
||||
threat model in full.
|
||||
|
||||
## Workflow Engine
|
||||
|
||||
### Core types (`workflow.go`)
|
||||
|
||||
- `Workflow` = named list of `Stage`s
|
||||
- `Stage` = `Name` + `Run(ctx, *TaskContext) error`
|
||||
- `TaskContext` = mutable bag: Task, Repo, Config, Forge, Store, Agent runner,
|
||||
worktree dir/branch, scratch fields
|
||||
- `Outcome` = terminal decision (status + detail) -- ends the workflow
|
||||
immediately
|
||||
- `Registry` = `map[string]Workflow`
|
||||
|
||||
### Routing (`Route`)
|
||||
|
||||
Label-driven, no LLM involved. Pre-assigned workflow wins; then labels decide.
|
||||
The built-in bindings are:
|
||||
|
||||
- `bug` → `tdd`
|
||||
- `feature` → `feasibility`
|
||||
- `bootstrap` → `bootstrap` (diagnostics, no LLM spend)
|
||||
- Default → `implement`
|
||||
|
||||
Both the closed `bug`/`feature`/`bootstrap` set's target workflow and
|
||||
arbitrary additional labels are YAML-overridable at daemon startup
|
||||
(`internal/domain/workflow/routing.go`'s `LoadKindWorkflowsYAML`/
|
||||
`LoadLabelWorkflowsYAML`, `WorkflowRoutingFile`/`WorkflowLabelsFile`/
|
||||
`PlaybookDirs` config) -- see `docs/prds/eda-playbook-engine.md`. A label
|
||||
already owned by the closed kind set, or a binding declared twice across
|
||||
sources, is a reported load failure, not a silent override.
|
||||
|
||||
### Execution (`Run`)
|
||||
|
||||
Stages execute sequentially. After each stage:
|
||||
|
||||
- Task is persisted to SQLite
|
||||
- Error → park the task (comment on issue, keep worktree)
|
||||
- Outcome set → finish (transition task, update labels)
|
||||
- Neither → continue to next stage
|
||||
|
||||
A workflow that ends without an outcome parks -- definition bugs must not vanish
|
||||
silently.
|
||||
|
||||
## Workflows
|
||||
|
||||
### Bootstrap (diagnostics, no LLM)
|
||||
|
||||
```
|
||||
prepare → apply(marker file) → commit-push → diff-cap → open-pr
|
||||
```
|
||||
|
||||
Proves the plumbing: clone, push, PR. Label any test issue `bootstrap` to verify
|
||||
end-to-end.
|
||||
|
||||
### Implement (default)
|
||||
|
||||
```
|
||||
prepare → baseline-gate → plan(planner, read-only) → build(builder, gated) → commit-push → diff-cap → open-pr
|
||||
```
|
||||
|
||||
- **baseline-gate:** runs the repo's gate at the base commit before anything is
|
||||
touched
|
||||
- **plan:** read-only agent explores codebase, produces implementation plan,
|
||||
posts it as a comment
|
||||
- **build:** full toolset agent implements against the plan behind the repo's
|
||||
quality gate
|
||||
- **diff-cap:** parks oversized changes (>400 lines default)
|
||||
- **open-pr:** builder's summary becomes the PR body
|
||||
|
||||
### TDD (bug label)
|
||||
|
||||
```
|
||||
prepare → baseline-gate → analyse(planner) → repro-tests(builder, inverted gate) → capture-proof → commit-repro → fix(builder, normal gate, test files protected) → commit-push → diff-cap → open-pr + repro-evidence
|
||||
```
|
||||
|
||||
- **repro-tests:** the quality gate is **inverted** -- the test command must
|
||||
FAIL. Proven failure is required.
|
||||
- **capture-proof:** runs the test command deterministically, captures the
|
||||
failing output
|
||||
- **commit-repro:** commits the failing tests as the first commit
|
||||
- **fix:** test files are **environmentally write-protected** (not
|
||||
prompt-ruled). The agent fixes code, not tests.
|
||||
- **open-pr + evidence:** posts both the PR and the captured failure proof
|
||||
|
||||
### Feasibility (feature label)
|
||||
|
||||
```
|
||||
prepare → assess(planner, with decide tool) → [close_if_bad_fit | prd(planner)] → deliver → waiting_human
|
||||
```
|
||||
|
||||
- **assess:** reads AGENT.md, ROADMAP.md, README. Calls a `decide` tool
|
||||
(structured output, not parsed prose). Bad fit → close with reasons.
|
||||
- **prd:** read-only agent writes a PRD: problem, solution, files affected,
|
||||
acceptance criteria, non-goals, diff estimate
|
||||
- **deliver:** posts PRD as issue comment + webhook notification (n8n → email).
|
||||
Sets state to `waiting_human`.
|
||||
- The daemon watches for human replies, judges them with a triage LLM
|
||||
(APPROVE/REJECT/UNCLEAR), requeues or closes.
|
||||
|
||||
## Forge Interface
|
||||
|
||||
A thin abstraction over the forge. GitHub (`github.go`) and Gitea (`gitea.go`)
|
||||
both implement it, plus a no-op (`noop.go`) used when no credential resolves —
|
||||
see the degradation rule in `docs/architecture/configuration.md`. A multi-forge
|
||||
deployment is configured per identity; see
|
||||
`deployments/multi-forge-github-gitea.toml`.
|
||||
|
||||
| Method | Purpose |
|
||||
| ------------------- | --------------------------------------- |
|
||||
| `AcceptInvitations` | Auto-accept repo invites |
|
||||
| `AssignedIssues` | Poll assigned issues (excluding PRs) |
|
||||
| `IssuesWithLabel` | Poll labelled issues |
|
||||
| `Comment` | Post issue/PR comment, return ID |
|
||||
| `RepliesAfter` | Find human replies after a comment ID |
|
||||
| `CreatePR` | Open pull request |
|
||||
| `PRState` | Check merged/open/closed |
|
||||
| `CloseIssue` | Close with final comment |
|
||||
| `React` | Emoji reaction (pickup acknowledgement) |
|
||||
| `SetStateLabel` | Replace old state label with new one |
|
||||
| `VerifyPush` | Confirm push permission at startup |
|
||||
|
||||
State labels (`archie:queued`, `archie:working`, etc.) are created on demand,
|
||||
removed when transitioning. They report state; they do not drive it. Removing
|
||||
a label no longer retries a parked task -- retries are an explicit operator
|
||||
action from the dashboard or chat, capped by `max_retries`.
|
||||
|
||||
### Webhook intake (alternative to polling)
|
||||
|
||||
`internal/forge/webhook` is a separate HTTP receiver, not a `Forge` method: it
|
||||
verifies a GitHub webhook's HMAC signature (`internal/webhookguard.VerifyHMAC`),
|
||||
decodes an `issues` event, applies the same dispatch predicate the poller
|
||||
uses, and calls the same `PublishTask` the poller calls. It is opt-in via
|
||||
`Forge.Intake` (`poll` default, `webhook`, `both`) and single-identity only: a
|
||||
config naming `webhook`/`both` together with `[[identities]]`, or setting
|
||||
intake on an identity, is rejected at validation rather than started with the
|
||||
setting ignored -- the receiver binds one secret and one dispatch predicate,
|
||||
so it cannot judge a second identity's events by the right rules. A
|
||||
multi-identity deployment polls per identity until per-identity intake lands.
|
||||
See `docs/prds/event-sources-and-reactions.md` for why this stayed a
|
||||
thin decode-and-reuse layer rather than a second intake mechanism.
|
||||
|
||||
## Worktree Manager
|
||||
|
||||
Every task gets a fresh clone -- no persistent state between runs. The model
|
||||
never runs git.
|
||||
|
||||
```
|
||||
~/.local/share/archie/work/<owner>-<repo>/issue-<N>/
|
||||
```
|
||||
|
||||
Token auth via a generated `GIT_ASKPASS` helper script -- the token never
|
||||
appears in `.git/config` or process argv.
|
||||
|
||||
## Config
|
||||
|
||||
Daemon-level TOML (`~/.config/archie/config.toml`):
|
||||
|
||||
- `[forge]` -- type (github/gitea), host, token secret reference; `intake`
|
||||
(`poll` default, `webhook`, or `both`) with `webhook_secret`/`webhook_addr`
|
||||
when reacting to forge events instead of, or alongside, polling
|
||||
(single-identity deployments only; rejected, not ignored, alongside
|
||||
`[[identities]]` or on a `[identities.forge]` entry)
|
||||
- `[dispatch]` -- trigger (assignee/label/either), labels, ack reaction
|
||||
- `[[repos]]` -- owner, name, base branch, gate commands, protected paths,
|
||||
ecosystem
|
||||
- `[models]` -- planner, builder, triage (provider/model refs)
|
||||
- `[providers]` -- LLM provider configs
|
||||
- `[nats]` -- embedded or external broker deployment
|
||||
- `[containers]` -- managed `archie-agent` image, limits, storage, and network
|
||||
- `[budgets]` -- max steps, max tokens, wall clock, gate max failures
|
||||
- `[web]` -- dashboard listen address, bound by the standalone archie-ui
|
||||
process (the daemon runs no dashboard listener after the UI cutover)
|
||||
- `[notify]` -- webhook URL for notifications
|
||||
|
||||
Secrets (forge token, provider API keys, channel tokens) are not embedded in
|
||||
config files. `internal/secret` defines a pluggable `Engine` interface (`Name`,
|
||||
`Version`, `Resolve(key) (string, error)`) resolved through a `Registry`; the
|
||||
built-in `env` engine reads an environment variable by name and the built-in
|
||||
`bws` engine caches the accessible Bitwarden project at startup. Custom engines
|
||||
(sops, Vault/OpenBao) are Yaegi-interpreted `.go` plugins loaded from a
|
||||
directory, following the same convention as `internal/plugin`'s daemon plugins.
|
||||
Config fields reference a secret as
|
||||
`{engine, key}` (`secret.SecretRef`), e.g.
|
||||
`token = { engine = "env", key = "ARCHIE_GITHUB_TOKEN" }`. As of this writing
|
||||
`Forge.Token` and `Provider.APIKey` use `SecretRef`; resolved provider values
|
||||
are exported under private, identity-scoped environment names because the SDK
|
||||
and container boundary consume credential names rather than
|
||||
plaintext wire fields. The older `Provider.APIKeyEnv`, `NATSConfig.TokenEnv`, and
|
||||
`TelegramConfig.TokenEnv` field names remain supported.
|
||||
|
||||
Per-repo gates are command lists: `[[repos.gate]] = ["go", "vet", "./..."]`. The
|
||||
last command is the test runner (by convention -- TDD inverts it).
|
||||
|
||||
## Observability
|
||||
|
||||
Every lifecycle event flows through an internal event bus:
|
||||
|
||||
- SQLite event log (every event stamped with a row ID)
|
||||
- Live dashboard via SSE (server-sent events)
|
||||
- Bounded subscriber buffers -- slow consumers drop events, never block the
|
||||
daemon
|
||||
|
||||
## Plugin engine rule (strict)
|
||||
|
||||
“Engine” is reserved for a typed, lifecycle-managed capability family. It is not
|
||||
a synonym for a generic plugin hook. Every new plugin engine must satisfy all of
|
||||
these invariants:
|
||||
|
||||
1. **Typed domain contract.** The engine interface exposes real
|
||||
capability-specific operations in addition to identity metadata. Examples are
|
||||
resolving a secret, delivering a message, or running an agent. A plugin that
|
||||
only exposes `Name` and `Version` is metadata, not an engine.
|
||||
2. **Owning family manager.** The capability package owns a `Registry` or
|
||||
`Manager` that controls provider registration and discovery, initialization,
|
||||
or access. Providers do not register arbitrary callbacks directly on the
|
||||
daemon.
|
||||
3. **Lifecycle and health.** When an implementation owns resources or background
|
||||
work, its typed family contract must expose start, health, and stop
|
||||
semantics. The owning manager invokes them and defines failure isolation and
|
||||
shutdown ordering. Stateless providers may make these operations explicit
|
||||
no-ops.
|
||||
4. **Narrow host access.** Plugins receive the typed family registrar and only
|
||||
the host services their declared capability requires. They never receive
|
||||
`*daemon.Daemon`, a service locator, or an untyped hook map.
|
||||
5. **Metadata-only generic plugin contract.** `plugin.Plugin` remains limited to
|
||||
`Name()` and `Version()`. Domain hooks belong on typed engine interfaces;
|
||||
adding capability methods to the generic interface is forbidden.
|
||||
6. **Trust boundary stays explicit.** Explicitly trusted, operator-installed
|
||||
plugins—including third-party secret-engine plugins the operator chooses to
|
||||
trust—may run in-process and have daemon privileges. Repository-supplied code
|
||||
runs in the task container. Integrations that are not trusted as daemon code
|
||||
run out of process through MCP or a versioned protocol and, when a
|
||||
confidentiality or integrity boundary is required, inside a real container
|
||||
sandbox. A subprocess boundary alone is not a security sandbox, and calling
|
||||
Yaegi-loaded code a plugin does not isolate it.
|
||||
|
||||
`internal/plugin/architecture_test.go` enforces the mechanically testable parts
|
||||
of this rule: the generic plugin method set, the shared agent-instruction
|
||||
source, and the requirement that engine interfaces have domain behavior plus an
|
||||
owning registry or manager.
|
||||
|
||||
### Memory engine family
|
||||
|
||||
One engine, addressed by four typed scopes -- `ScopeGlobal`, `ScopeAgent`,
|
||||
`ScopeUser`, `ScopeAgentUser` (`internal/domain/memory`, `Scope`/`ScopeKind`).
|
||||
A caller names exactly the scopes it may read or write; the engine applies no
|
||||
access policy of its own, so isolation falls out mechanically because
|
||||
`ScopeAgent{a}` and `ScopeAgent{b}` are different storage keys. See
|
||||
`docs/prds/memory-engine-unification.md` for the decision this contract
|
||||
implements; it superseded `internal/memory` (`MemoryProvider`/`Manager`),
|
||||
deleted in that PRD's slice 5.
|
||||
|
||||
`MemoryEngine` (`internal/domain/memory/contract.go`) is the typed family
|
||||
contract: `Create`, `Get`, `Query`, `List`, `Update`, `Forget`, `Revisions` --
|
||||
CRUD with revisions retained, not just create/read/delete. `Update` supersedes
|
||||
rather than overwrites: the superseded state is appended to the scope's
|
||||
`HISTORY.md` before the live block is replaced, and `Update` carries no
|
||||
`Scope` field, so a record can never change scope. The family's content
|
||||
scanner (prompt-injection / sensitive-data patterns) is applied inside
|
||||
`Create` and `Update`, the single choke point every producer crosses.
|
||||
|
||||
`internal/domain/memory.Registry` is the owning family registry: registration,
|
||||
start/health/stop, shutdown ordering, and failure isolation, following the
|
||||
plugin engine rule (`ARCHITECTURE.md#plugin-engine-rule-strict`).
|
||||
`internal/infrastructure/memory.NewBuiltinEngine` is the only registered
|
||||
engine today; it persists through `internal/infrastructure/memory/builtin`,
|
||||
a markdown store (`MEMORY.md`-shaped per-scope files) that owns its on-disk
|
||||
format end-to-end.
|
||||
|
||||
Two per-turn seams in `internal/gateway` connect a chat turn to the engine,
|
||||
each narrowed to exactly the operations it needs:
|
||||
|
||||
- **Read** (`turn_memory.go`, `MemoryStore`): `prepareTurn` runs a
|
||||
scope-only `Query` over the resolved `Subject`'s readable scopes,
|
||||
synchronously and before the prompt is built. It never returns an error --
|
||||
a panicking or failing engine degrades to an empty `<memory>` block rather
|
||||
than failing the turn -- and is bounded by a per-scope record limit and a
|
||||
byte cap on the rendered block.
|
||||
- **Write** (`turn_memory_tool.go`, `MemoryWriteStore`): four tools --
|
||||
`memory_create`, `memory_update`, `memory_delete`, `memory_list` -- built
|
||||
per turn onto the resolved `Subject`'s writable scopes, not registered once
|
||||
at boot. The model chooses the scope kind; it never chooses the agent or
|
||||
user id, which come from the turn's resolved `Subject` and have no schema
|
||||
field to override. `ScopeGlobal` is never model-writable.
|
||||
|
||||
`boot.setupMemoryEngine` (`internal/app/archied/bootstrap.go`) registers and
|
||||
starts the engine and must run before `setupGatewayChat`, which constructs the
|
||||
only chat turn runner in production and captures the engine at construction
|
||||
time (`internal/app/archied/composition_order_test.go` pins the ordering), and
|
||||
before `setupCurators`, whose `Registrar` captures the engine registry. The session curator (`internal/infrastructure/sessioncurator`)
|
||||
writes derived records onto `ScopeAgentUser`, making it the engine's other
|
||||
live producer besides the chat write path.
|
||||
|
||||
## Key Design Decisions
|
||||
|
||||
1. **Environmental constraints over prompt rules.** The gate, test-file
|
||||
protection, and diff cap are code enforcement -- not "please don't do that"
|
||||
in the system prompt.
|
||||
2. **The model never runs git.** Worktree operations are deterministic steps,
|
||||
not agent tools.
|
||||
3. **Tokens as cost, not features.** Token usage is tracked per task and emitted
|
||||
in observability events but never budgeted beyond the agent loop's own
|
||||
limits.
|
||||
4. **Label-driven routing.** Workflow selection is a switch statement, not an
|
||||
LLM call. A triage LLM is used only for the human reply judgment in
|
||||
waiting_human.
|
||||
5. **Shared code.** `ai-sdk/agentloop` and `ai-sdk/toolkit` provide the common
|
||||
agent loop and tool set.
|
||||
6. **No daemon-internal cron.** Polling is a ticker loop, not cron. The
|
||||
feasibility PRD notification uses an external webhook (n8n).
|
||||
7. **Fresh worktree per task.** No persistent state between runs. Crash recovery
|
||||
just re-queues.
|
||||
8. **Agent execution is a data boundary.** Autonomous stages receive a versioned
|
||||
request and return a fenced result; SQLite, forge operations, git, workflow
|
||||
sequencing, and outcome handling stay daemon-owned.
|
||||
|
||||
## What's Implemented vs Planned
|
||||
|
||||
**Implemented:**
|
||||
|
||||
- Daemon poll loop, enqueue, claim, process
|
||||
- Forge webhook intake as a feature-flagged alternative/backstop pairing to
|
||||
polling (single-identity deployments; see `internal/forge/webhook`)
|
||||
- Bootstrap, implement, TDD, feasibility workflows
|
||||
- GitHub and Gitea forges (issues, PRs, labels, comments, reactions)
|
||||
- Worktree isolation (clone, branch, commit, push, diff, cleanup)
|
||||
- SQLite store with transition audit
|
||||
- Config with ecosystem support (go, python, node, rust)
|
||||
- Agent stages with gates, budgets, preflight, protected paths
|
||||
- Observability (event bus, SQLite log, SSE dashboard)
|
||||
- Crash recovery (re-queue stale running tasks)
|
||||
- Human reply judgment (triage LLM for waiting_human)
|
||||
|
||||
**Planned:**
|
||||
|
||||
- Multi-identity webhook intake (currently single-identity only)
|
||||
- More ecosystems
|
||||
- Notification integrations beyond n8n webhook
|
||||
- Skills (SKILL.md support -- see `.archie/skills/`)
|
||||
+746
@@ -5,6 +5,752 @@ release's per-component sections are labelled beneath its heading.
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
## [1.49.0] - 2026-10-07
|
||||
|
||||
### archied
|
||||
|
||||
- Extensions that declare no egress hosts (vault, email, gitea) reach the network again; only packages that declare their hosts are confined to them. The Accept dialog shows "network: unrestricted" for the rest.
|
||||
- The update check finds releases itself, and reuses a found release for ten minutes so repeated checks stay under GitHub's rate limit.
|
||||
|
||||
## [1.48.1] - 2026-10-07
|
||||
|
||||
### archied
|
||||
|
||||
- **Settings → Status → Updates** now chooses only the release channel (stable, prereleases, or a pinned version). Update checks and installs always run the `archie-update-*` scripts installed beside the binaries; the dashboard can no longer set the command that runs.
|
||||
|
||||
## [1.48.0] - 2026-10-07
|
||||
|
||||
### archied
|
||||
|
||||
- **Settings → Status → Updates** edits the update check and install commands. They default to the `archie-update-*` scripts installed beside the binaries, so a zip install shows **Install** on the Versions card with nothing configured. The `update_check_command` and `update_install_command` keys under `[chat.telegram]` are no longer read; remove them from `config.toml`.
|
||||
- `archie-update-install` run from a shell now reads `~/.config/archie/env`, so the pre-update backup of the bundled database no longer fails with `no password supplied`. Run it with `--auto` to install the newest release.
|
||||
|
||||
## [1.47.3] - 2026-10-07
|
||||
|
||||
### archied
|
||||
|
||||
- **Settings → Extensions**: **Accept** in the authority review now accepts the extension, and **Remove** removes it. Both previously closed the dialog without doing anything.
|
||||
|
||||
## [1.47.2] - 2026-10-06
|
||||
|
||||
### archied
|
||||
|
||||
- **Events → Inspector** now lists your capture sources with their real URLs and a **New source** button, replacing the `/webhooks/capture/<source>` placeholder. Sources no longer sit on the Bindings tab.
|
||||
|
||||
## [1.47.1] - 2026-10-06
|
||||
|
||||
### archied
|
||||
|
||||
- The bundled PostgreSQL has no network and publishes no port: the services reach it through its Unix socket under `~/.local/share/archie/postgres`, so it no longer collides with another PostgreSQL on 5432. Leaving the database question blank in `archied setup` selects it.
|
||||
- The installer does not start the services when the bundled PostgreSQL fails to start; it names the command to read its logs.
|
||||
- On hosts that restrict unprivileged user namespaces (Ubuntu 23.10+), the installer prints an AppArmor profile allowing them for the Archie binaries only.
|
||||
|
||||
## [1.47.0] - 2026-10-06
|
||||
|
||||
### archied
|
||||
|
||||
- Install with one command: `curl -fsSL https://raw.githubusercontent.com/samcharles93/archie-core/main/install.sh | bash` downloads this release, verifies its checksum and runs `archied setup`. `--from-source` builds a checkout instead.
|
||||
- `archied setup` asks for the PostgreSQL URL. Left blank, it uses the bundled Compose database with a generated password stored in `~/.config/archie/env` as `PGPASSWORD`, not in `config.toml`.
|
||||
- The bundled PostgreSQL listens on 127.0.0.1 only. A database created before this release keeps its old `archie` password; enter its URL at setup or recreate the volume.
|
||||
- The release zip carries `docker-compose.yml`.
|
||||
- Extensions need unprivileged user namespaces, which Ubuntu 23.10 and later restrict. Allow them for the Archie binaries with an AppArmor profile; from the next release the installer prints it. Do not disable the restriction system-wide.
|
||||
- fix(app): assign the temp-file close result on the error path
|
||||
- fix(webhook): set a ReadHeaderTimeout on the forge webhook receivers
|
||||
- fix(forge): refuse a review line number that does not fit an int
|
||||
- fix(storepkg): mask the tar mode to the permission bits before narrowing
|
||||
- fix(webui): navigate the Events chain once, not twice
|
||||
- feat(tools): fail the gate when docs cite a path that no longer exists
|
||||
- fix(webhookguard): verify uppercase-hex HMAC signatures
|
||||
- fix(configuration): make bot_user required, defaulted, and named
|
||||
- feat(workflow): add the command.run step type
|
||||
- fix(controlplane): an absent MCP server field inherits the file value
|
||||
- fix(build): restore the go fix fixpoint, and give the formatter one owner
|
||||
- fix(archied): restore contextcheck directives and drop unused adapter
|
||||
- feat(secretengine): serve secret engines as go-plugin extensions
|
||||
- refactor(statestore): own package for the State Store service; access reset moves to archie-state-store
|
||||
- refactor(archied): gateway owns model work; daemon drops chat runtime, tools, memory and curators
|
||||
- refactor(archiegateway): own package for the Gateway service
|
||||
- fix(services): services wait for peers instead of exiting; restarted broker keeps its endpoint
|
||||
- refactor(archieplaybooks): fold archie-playbooks into archied playbooks lint|serve
|
||||
- refactor(agentrun): agent stage contract moves to the domain layer
|
||||
- refactor(agentexec): model loop moves to agentexec/modelloop
|
||||
- fix(configuration): bindings encryption keys must use the env engine
|
||||
- feat(storepkg): fetch packages from any registry, plain HTTP on loopback only
|
||||
- feat(webui): install, accept and enable extensions from the dashboard
|
||||
- feat(presence): every service re-stamps a presence record in the State Store
|
||||
- refactor(plugin): delete Yaegi daemon plugins and plugin_dir
|
||||
- refactor(module): the log action is built in; delete the module loader and reconciler
|
||||
- refactor(skill): delete Yaegi skill scripts and the run_go_script tool
|
||||
- refactor(examples): the firewall workflow moves to archipelago
|
||||
- feat(presence): services card on the status page and archied status
|
||||
- feat(archiemessaging): verify update reports against archied's presence and restore release announcements
|
||||
- fix(configuration): an overlay stands in for a missing config file; dev overlay is complete
|
||||
- feat(access): edit org, workspace and object policies from the dashboard; refuse owner lockout
|
||||
- feat(access): instance network rules at the capture receiver; policies reload without a restart
|
||||
- feat(staterpc): attribute State Store calls to the calling service; policy audit records it
|
||||
- feat(controlplane): playbooks and agent profiles install from packages; the daemon reads eda-playbooks live
|
||||
- feat(forgeext): forge surface served by extensions; forge.type names the installed package
|
||||
- refactor(forge): github and gitea leave core; webhooks parse in the forge extension
|
||||
- feat(staterpc): the State Store derives org and actor from the principal archie-ui forwards
|
||||
- feat(channelext): chat channels served by extensions; messaging runs the enabled ones
|
||||
- refactor(channels): webhook and email run only as extensions; their channel settings go
|
||||
- feat(skills): skill packages project into a skills resource the gateway reads live
|
||||
- fix(gatewayrpc): sender_id and rate_limited cross the chat wire
|
||||
- fix(controlplane): change history names kinds and reads only the caller's org
|
||||
- feat(contracts)!: requests no longer name their org; the State Store derives it from the caller
|
||||
- feat(identity): personal API tokens, created and revoked from the dashboard, act as their owner
|
||||
- fix(archieui): a sign-in provider outage is a health issue, not a startup failure
|
||||
- feat(staterpc): one run credential per task, kept in the State Store, authorizes its store calls and its push
|
||||
- fix(forgerpc): forge calls need the run credential and reach only the run's own repository
|
||||
- feat(controlplane): identity credential grants edited from the dashboard and applied live
|
||||
- feat(daemon): a workflow that names an identity runs as it; the dispatcher needs run on the workflow
|
||||
- feat(staterpc): every run start is audited by the State Store, or the run credential is withdrawn
|
||||
- refactor(forgerpc): identity RPC subjects are keyed by identity ID
|
||||
- fix(nats): containers log in with their run credential and reach only their task's subjects
|
||||
- feat(egress): the run credential is the proxy login; Kit secrets resolve per request from live grants
|
||||
- fix(webui): bind the container runtime document's keys, drop the blank Advanced page
|
||||
- fix(webui): drop the repository review switch the server no longer accepts
|
||||
- feat(controlplane): serve the step vocabulary in the workflow-definitions schema; the editor checks step types against it
|
||||
- fix(ui): drop the topbar nav's edge fade that clipped the first item
|
||||
- refactor(workflow): delete the bootstrap smoke-test workflow and its intake kind
|
||||
- feat(workflow): step ids, {{ }} references to earlier results, agent.run result schemas, workflow.finish and on_failure
|
||||
- feat(workflow): repository step types; implement and tdd ship as YAML in general steps
|
||||
- feat(workflow): when conditions, handoff, human approval and forge steps; feasibility and triage ship as YAML
|
||||
- feat(workflow): retries, parallel branches, review steps; every shipped workflow is YAML and the per-workflow step types are gone
|
||||
- feat(ui): workflow canvas renders each definition as a step graph with data edges, parallel branches and conditions
|
||||
- feat(ui): the workflow canvas watches a run live: each step shows its state, duration and error, and the view follows the step in progress
|
||||
- feat(controlplane): serve each step type's settings schema; the workflow editor checks settings before save
|
||||
- feat(ui): build workflows on the canvas: step palette, schema-driven settings forms, references to earlier results, reorder and remove
|
||||
- feat(ui): the canvas Start node lists what starts the workflow: issue routes, event bindings, playbooks and other workflows
|
||||
- feat(ui): canvas authoring by right-click menu and + insertion points; steps edit in a slide-in panel and show what they do
|
||||
- fix(ui): workflow page header is one tab row with save and a more menu; drop the ID field, step list, version footer and the meaningless origin pill
|
||||
- feat(ui): drive workflows from the canvas: run a workflow, act on the watched run, edit workflow settings from the Start node; the canvas fills the viewport
|
||||
- feat(ui): inspect workflow step runs from canvas
|
||||
- feat(workflow): resume a parked run from a chosen step
|
||||
- feat(ui): bind an event to a workflow from its Start node
|
||||
- fix(ui): reveal signing secret in canvas source creation
|
||||
- feat(ui): select review gate findings before approval
|
||||
- fix(ui): load task debug reliably and copy JSON output
|
||||
- fix(postgres): queue a review that arrives during a remediation
|
||||
- fix(ui): keep JSON copy inline on hover
|
||||
- fix(webui): stop returning database_url from /api/config
|
||||
- refactor(config): drop unused dispatch state labels
|
||||
- feat(gateway): serve the dashboard skills and curators over ChatService
|
||||
- refactor(archieui): leave channel reload unserved by the gateway
|
||||
- feat(releaseupdate): install from release artifacts with journaled rollback, topology check and channels
|
||||
- feat(gateway): load SOUL into the chat prompt per turn
|
||||
- refactor(config): drop the unwired artifact sender and [artifacts] config
|
||||
- feat(messaging): serve MessagingService.Deliver and deliver chat schedules through it
|
||||
- refactor(gateway)!: drop budget_key with the webhook chat channel
|
||||
- refactor(configuration): delete the dead runtime config overlay
|
||||
- fix(daemon): record terminal non-dispatch outcomes so a capture is evaluated once
|
||||
- fix(daemon): refuse a disabled workflow on every start path
|
||||
- fix(workflow): validate workflow.call inside parallel branches
|
||||
- fix(workflow): validate handoff and approve targets at save
|
||||
- feat(taskactions): rejecting a pr_open task closes its pull request
|
||||
- feat(eda): link binding dispatches to the captures and tasks they started
|
||||
- feat(eda): record every terminal binding outcome and flag failing bindings
|
||||
- feat(workflow): record parallel branch steps as their own steps
|
||||
- feat(workflow): record steps skipped by when as skipped
|
||||
- feat(webui): page and filter the task list on the server
|
||||
- fix(webui): admit dashboard work requests through the State Store and honour the workflow's repository mode
|
||||
- fix(ui): restoring shipped workflows keeps custom ones
|
||||
- refactor(org): rename the default org to org-sys
|
||||
- fix(postgres): collect inline comments on a review queued behind a running remediation
|
||||
- fix(daemon): webhook forge intake does not poll for issues
|
||||
- refactor(archied): drop the unreachable multi-identity webhook skip; validation refuses it
|
||||
- feat(access): the dashboard operator is a person owning org-sys
|
||||
- fix(workflow): refuse undeclared inputs and result fields at save
|
||||
- fix(ui): offer resume only where the server accepts it
|
||||
- feat(daemon): the timeline names and links the binding and capture that started a task
|
||||
- feat(eda): pause and resume a binding; resuming goes back through approval
|
||||
- feat(org): org, workspace and membership API
|
||||
- fix(webui): the org-sys owner is the instance owner
|
||||
- fix(webui): member changes need the admin grant and owner changes an owner
|
||||
- feat(daemon): withdrawing an issue declines its queued or running work
|
||||
- feat(workflow): later steps read a waited workflow.call's outputs as its result
|
||||
- feat(workflow): record each failed attempt of a retried step
|
||||
- feat(daemon): record an approving review on the task's timeline
|
||||
- feat(workflow): each remediation round names its number, cap and the review it answers
|
||||
- fix(ui): show step retries as archie's record, not the agent's report
|
||||
- feat(webui): run details show inputs, outputs and workflow.call links both ways
|
||||
- feat(webui): page through task logs
|
||||
- feat(eda): name and delete capture sources; an armed binding blocks the delete
|
||||
- feat(ui): edit retry backoff and needs on the canvas
|
||||
- fix(controlplane): report watch outages and align live/restart kind labels
|
||||
- feat(taskactions): merge pull request action from the task
|
||||
- fix(daemon): withdraw only issues the same dispatch rule found eligible and then lost
|
||||
- feat(org): instance admins manage every org
|
||||
- feat(ui): org area with members, agents, workspaces, access and tokens
|
||||
- fix(ui): trim filler prose and expose appearance in settings nav
|
||||
- fix(archiegateway,agentexec,agentworker): rely on ai-sdk reasoning token selection
|
||||
- feat(ui): org switcher and new org for instance admins
|
||||
- fix(extension): confine each extension's network to its accepted egress hosts
|
||||
- fix(captureintake): unwrap form-encoded webhook payloads
|
||||
- fix(captureintake): decode any form-encoded webhook body to JSON
|
||||
- fix(modelloop): feed the cached model catalog to the runtime so reasoning models get the right token parameter
|
||||
- fix(webui): list services with the State Store marked down when it is unreachable
|
||||
- fix(release): push the release commit and its tag atomically
|
||||
- fix(eda): dispatch each webhook delivery once, however often the sender retries it
|
||||
- fix(eda): name a source's delivery header in the dashboard instead of a built-in sender list
|
||||
- fix(modelloop): mark reasoning models from the carried model limits, in the gateway and the agent worker
|
||||
- feat(telegram): /stop stops the chat agent, else the tasks it created, or one task; delete the dead approval actions
|
||||
- feat(storepkg): install packages from a signed default catalogue, listed on the Extensions page
|
||||
- feat(setup): one guided flow; ask for PostgreSQL and generate the bundled database's password
|
||||
- fix(setup): keep the generated database password out of config.toml
|
||||
- feat(install): install from a verified release with curl | bash; ship docker-compose.yml in the release
|
||||
|
||||
### archie-agent
|
||||
|
||||
- fix(forge): refuse a review line number that does not fit an int
|
||||
- fix(webhookguard): verify uppercase-hex HMAC signatures
|
||||
- feat(workflow): add the command.run step type
|
||||
- feat(secretengine): serve secret engines as go-plugin extensions
|
||||
- refactor(statestore): own package for the State Store service; access reset moves to archie-state-store
|
||||
- fix(services): services wait for peers instead of exiting; restarted broker keeps its endpoint
|
||||
- refactor(agentrun): agent stage contract moves to the domain layer
|
||||
- refactor(agentexec): model loop moves to agentexec/modelloop
|
||||
- fix(configuration): bindings encryption keys must use the env engine
|
||||
- feat(presence): every service re-stamps a presence record in the State Store
|
||||
- refactor(plugin): delete Yaegi daemon plugins and plugin_dir
|
||||
- refactor(module): the log action is built in; delete the module loader and reconciler
|
||||
- refactor(skill): delete Yaegi skill scripts and the run_go_script tool
|
||||
- feat(access): edit org, workspace and object policies from the dashboard; refuse owner lockout
|
||||
- feat(access): instance network rules at the capture receiver; policies reload without a restart
|
||||
- feat(staterpc): attribute State Store calls to the calling service; policy audit records it
|
||||
- feat(controlplane): playbooks and agent profiles install from packages; the daemon reads eda-playbooks live
|
||||
- feat(forgeext): forge surface served by extensions; forge.type names the installed package
|
||||
- refactor(forge): github and gitea leave core; webhooks parse in the forge extension
|
||||
- feat(staterpc): the State Store derives org and actor from the principal archie-ui forwards
|
||||
- feat(channelext): chat channels served by extensions; messaging runs the enabled ones
|
||||
- refactor(channels): webhook and email run only as extensions; their channel settings go
|
||||
- feat(skills): skill packages project into a skills resource the gateway reads live
|
||||
- fix(controlplane): change history names kinds and reads only the caller's org
|
||||
- feat(contracts)!: requests no longer name their org; the State Store derives it from the caller
|
||||
- feat(identity): personal API tokens, created and revoked from the dashboard, act as their owner
|
||||
- fix(archieui): a sign-in provider outage is a health issue, not a startup failure
|
||||
- feat(staterpc): one run credential per task, kept in the State Store, authorizes its store calls and its push
|
||||
- fix(forgerpc): forge calls need the run credential and reach only the run's own repository
|
||||
- feat(daemon): a workflow that names an identity runs as it; the dispatcher needs run on the workflow
|
||||
- feat(staterpc): every run start is audited by the State Store, or the run credential is withdrawn
|
||||
- refactor(forgerpc): identity RPC subjects are keyed by identity ID
|
||||
- fix(nats): containers log in with their run credential and reach only their task's subjects
|
||||
- feat(egress): the run credential is the proxy login; Kit secrets resolve per request from live grants
|
||||
- feat(controlplane): serve the step vocabulary in the workflow-definitions schema; the editor checks step types against it
|
||||
- refactor(workflow): delete the bootstrap smoke-test workflow and its intake kind
|
||||
- feat(workflow): step ids, {{ }} references to earlier results, agent.run result schemas, workflow.finish and on_failure
|
||||
- feat(workflow): repository step types; implement and tdd ship as YAML in general steps
|
||||
- feat(workflow): when conditions, handoff, human approval and forge steps; feasibility and triage ship as YAML
|
||||
- feat(workflow): retries, parallel branches, review steps; every shipped workflow is YAML and the per-workflow step types are gone
|
||||
- feat(controlplane): serve each step type's settings schema; the workflow editor checks settings before save
|
||||
- feat(ui): the canvas Start node lists what starts the workflow: issue routes, event bindings, playbooks and other workflows
|
||||
- feat(ui): inspect workflow step runs from canvas
|
||||
- feat(workflow): resume a parked run from a chosen step
|
||||
- fix(postgres): queue a review that arrives during a remediation
|
||||
- refactor(config): drop unused dispatch state labels
|
||||
- refactor(config): drop the unwired artifact sender and [artifacts] config
|
||||
- feat(messaging): serve MessagingService.Deliver and deliver chat schedules through it
|
||||
- refactor(gateway)!: drop budget_key with the webhook chat channel
|
||||
- fix(daemon): record terminal non-dispatch outcomes so a capture is evaluated once
|
||||
- fix(workflow): validate workflow.call inside parallel branches
|
||||
- fix(workflow): validate handoff and approve targets at save
|
||||
- feat(taskactions): rejecting a pr_open task closes its pull request
|
||||
- feat(eda): link binding dispatches to the captures and tasks they started
|
||||
- feat(workflow): record parallel branch steps as their own steps
|
||||
- feat(workflow): record steps skipped by when as skipped
|
||||
- feat(webui): page and filter the task list on the server
|
||||
- refactor(org): rename the default org to org-sys
|
||||
- fix(postgres): collect inline comments on a review queued behind a running remediation
|
||||
- feat(access): the dashboard operator is a person owning org-sys
|
||||
- fix(workflow): refuse undeclared inputs and result fields at save
|
||||
- feat(daemon): the timeline names and links the binding and capture that started a task
|
||||
- feat(eda): pause and resume a binding; resuming goes back through approval
|
||||
- feat(org): org, workspace and membership API
|
||||
- feat(daemon): withdrawing an issue declines its queued or running work
|
||||
- feat(workflow): later steps read a waited workflow.call's outputs as its result
|
||||
- feat(workflow): record each failed attempt of a retried step
|
||||
- feat(daemon): record an approving review on the task's timeline
|
||||
- feat(workflow): each remediation round names its number, cap and the review it answers
|
||||
- feat(webui): run details show inputs, outputs and workflow.call links both ways
|
||||
- feat(webui): page through task logs
|
||||
- feat(eda): name and delete capture sources; an armed binding blocks the delete
|
||||
- feat(taskactions): merge pull request action from the task
|
||||
- feat(org): instance admins manage every org
|
||||
- fix(archiegateway,agentexec,agentworker): rely on ai-sdk reasoning token selection
|
||||
- fix(extension): confine each extension's network to its accepted egress hosts
|
||||
- fix(modelloop): feed the cached model catalog to the runtime so reasoning models get the right token parameter
|
||||
- fix(eda): dispatch each webhook delivery once, however often the sender retries it
|
||||
- fix(eda): name a source's delivery header in the dashboard instead of a built-in sender list
|
||||
- fix(modelloop): mark reasoning models from the carried model limits, in the gateway and the agent worker
|
||||
- feat(telegram): /stop stops the chat agent, else the tasks it created, or one task; delete the dead approval actions
|
||||
- feat(storepkg): install packages from a signed default catalogue, listed on the Extensions page
|
||||
|
||||
## [1.46.0] - 2026-10-02
|
||||
|
||||
### archied
|
||||
|
||||
- feat(workflow): declared workflow outputs for wait:true callers
|
||||
- feat(prreview): the operator-approval gate is PRReview's own stage-list entry
|
||||
- feat(staterpc): carry the review gate and re-review rounds, with one guarded response write
|
||||
- feat(prreview): the gate records the review it holds and posts the operator's answer
|
||||
- feat(taskactions): one approval path answers the review gate from every surface
|
||||
- feat(webui): the dashboard answers the review gate, including a re-review's instructions
|
||||
- feat(daemon): resolve the producing identity's org before publishing work
|
||||
- feat(webui): block invalid settings and show a field's former value
|
||||
- fix(workflow): derive a declared output's captures need for profile selection
|
||||
- fix(storepkg): validate every declared authority grant at the package descriptor
|
||||
- feat(archied): refresh the model catalog at runtime
|
||||
- feat(mcp): answer server-initiated sampling from the chat model
|
||||
- feat(container): send registry auth on image pull
|
||||
- feat(messaging): retract ephemeral replies after their TTL
|
||||
- feat(messaging): transcribe Telegram voice notes
|
||||
- fix(egress): take a run's credential kind from its binding, not the Kit
|
||||
- feat(webui): a live-apply setting reads as applied, never as a restart
|
||||
- feat(webui): the dashboard reads harness bindings and opens the setup terminal
|
||||
- feat(gateway): list the harness page in the dashboard page registry
|
||||
- feat(webui): the harness settings page and its setup terminal
|
||||
- fix(workflow): park environment gate failures without dispatching a builder
|
||||
- feat(messaging): adapter-facing clarify, picker and approval contract
|
||||
- feat(gateway): gate admin slash commands by sender policy
|
||||
- feat(plugins): load plugin and secret-engine files without a restart
|
||||
- fix(workflow): deliver the feasibility PRD to the forge issue
|
||||
- fix(messaging): report the daemon version this process was built from
|
||||
- fix(messaging): carry an inbound attachment's bytes to the gateway turn
|
||||
- fix(daemon): resume a retry whose worktree is gone
|
||||
- fix(archied): omit the max-token bound on reasoning-class models
|
||||
- fix(logging): file a task log record under its own event time
|
||||
- fix(control-plane): unify validation for the domain-managed kinds
|
||||
- feat(webui): let the operator choose the retry worktree mode
|
||||
- feat(agent): seed a starter SOUL and upgrade only untouched templates
|
||||
- feat(controlplane): add the writable review-settings resource
|
||||
- fix(messaging): transcribe voice notes on the model-owning side of the boundary
|
||||
- fix(messaging): gate the boundary on config reads, not only package links
|
||||
- feat(messaging): restart only the channel whose settings changed
|
||||
- feat(container): apply container-runtime-policies live
|
||||
- feat(tools): reconcile MCP servers and tool settings live
|
||||
- feat(messaging): add a per-turn interactive carrier for clarify and picker
|
||||
- feat(gateway): offer ask_user when the turn's channel can carry a question
|
||||
- feat(telegram): carry clarify and picker through the text fallback
|
||||
- fix(webui): pin the dashboard validators to the control plane's
|
||||
- refactor(agent): drop the SOUL upgrade branch with no shipped template
|
||||
- feat(agentworker): answer MCP sampling from the task's model
|
||||
- fix(workflow): bind the remediate worktree before the builder runs
|
||||
- fix(config): carry max_retries into the worker TaskConfig snapshot
|
||||
- fix(agentworker): supply the guardrail engine to every task run
|
||||
|
||||
### archie-agent
|
||||
|
||||
- feat(workflow): declared workflow outputs for wait:true callers
|
||||
- feat(prreview): the operator-approval gate is PRReview's own stage-list entry
|
||||
- feat(staterpc): carry the review gate and re-review rounds, with one guarded response write
|
||||
- feat(prreview): the gate records the review it holds and posts the operator's answer
|
||||
- feat(taskactions): one approval path answers the review gate from every surface
|
||||
- fix(workflow): derive a declared output's captures need for profile selection
|
||||
- fix(storepkg): validate every declared authority grant at the package descriptor
|
||||
- feat(mcp): answer server-initiated sampling from the chat model
|
||||
- feat(container): send registry auth on image pull
|
||||
- feat(messaging): retract ephemeral replies after their TTL
|
||||
- feat(messaging): transcribe Telegram voice notes
|
||||
- fix(egress): take a run's credential kind from its binding, not the Kit
|
||||
- fix(workflow): park environment gate failures without dispatching a builder
|
||||
- feat(messaging): adapter-facing clarify, picker and approval contract
|
||||
- feat(plugins): load plugin and secret-engine files without a restart
|
||||
- fix(workflow): deliver the feasibility PRD to the forge issue
|
||||
- fix(messaging): carry an inbound attachment's bytes to the gateway turn
|
||||
- fix(daemon): resume a retry whose worktree is gone
|
||||
- fix(logging): file a task log record under its own event time
|
||||
- fix(control-plane): unify validation for the domain-managed kinds
|
||||
- feat(webui): let the operator choose the retry worktree mode
|
||||
- fix(messaging): transcribe voice notes on the model-owning side of the boundary
|
||||
- feat(messaging): restart only the channel whose settings changed
|
||||
- feat(container): apply container-runtime-policies live
|
||||
- feat(tools): reconcile MCP servers and tool settings live
|
||||
- feat(messaging): add a per-turn interactive carrier for clarify and picker
|
||||
- feat(agentworker): answer MCP sampling from the task's model
|
||||
- fix(workflow): bind the remediate worktree before the builder runs
|
||||
- fix(config): carry max_retries into the worker TaskConfig snapshot
|
||||
- fix(agentworker): supply the guardrail engine to every task run
|
||||
|
||||
## [1.45.0] - 2026-09-30
|
||||
|
||||
### archied
|
||||
|
||||
- fix(eda): reject a result map missing a field or needing a conversion
|
||||
- feat(eda): per-org workflow enable/disable gating bindings
|
||||
- feat(telegram): carry inbound media through the chat turn
|
||||
- fix(prsource): use a CodeQL-recognised containment guard when extracting archives
|
||||
- feat(store): key control-plane resources by (org, kind)
|
||||
- fix(store): refuse resource keys the audit key cannot disambiguate
|
||||
- fix(daemon): resume the task branch before container acquisition
|
||||
- feat(webui): show attachment metadata in the session transcript
|
||||
- feat(webui): name a workflow's declared inputs on the work-request form
|
||||
- feat(controlplane): carry the caller org from the request principal
|
||||
- fix(webui): the workflow handlers act in the caller's org
|
||||
- feat(kitrun): render the OAuth credential file with sentinels
|
||||
- feat(store): record accepted package authority against the pin
|
||||
- fix(workflow): the own-PR flow no longer parks on the operator-approval gate
|
||||
- feat(gateway): a TTL-bounded dedup gate for redelivered platform messages
|
||||
- feat(egress): capture the OAuth scope set and carry it to the harness secret
|
||||
- feat(kitrun): render the OAuth scopes and omit an uncaptured primary key
|
||||
- feat(store): project installed package contributions into org resources
|
||||
- feat(gateway): coalesce rapid-fire text events into one turn
|
||||
- fix(config): expand plugin, module and skills dirs like every other operator path
|
||||
- fix(webui): drop the config schema's editability advert
|
||||
- feat(webui): events counts, YAML reading, log rows and dashboard filters
|
||||
|
||||
### archie-agent
|
||||
|
||||
- feat(eda): per-org workflow enable/disable gating bindings
|
||||
- feat(telegram): carry inbound media through the chat turn
|
||||
- fix(prsource): use a CodeQL-recognised containment guard when extracting archives
|
||||
- feat(store): key control-plane resources by (org, kind)
|
||||
- feat(controlplane): carry the caller org from the request principal
|
||||
- feat(kitrun): render the OAuth credential file with sentinels
|
||||
- feat(store): record accepted package authority against the pin
|
||||
- fix(workflow): the own-PR flow no longer parks on the operator-approval gate
|
||||
- feat(egress): capture the OAuth scope set and carry it to the harness secret
|
||||
- feat(kitrun): render the OAuth scopes and omit an uncaptured primary key
|
||||
- feat(store): project installed package contributions into org resources
|
||||
|
||||
## [1.44.1] - 2026-09-29
|
||||
|
||||
### archied
|
||||
|
||||
Two fixes to tasks that could not get past their workflow definition.
|
||||
|
||||
- **Approving a task no longer parks it again.** A task requeued under a
|
||||
different workflow kept the previous run's definition pinned, so the worker
|
||||
refused to compile the dispatch — it named `feasibility` while the row named
|
||||
`implement` — and the task parked immediately, identically on every further
|
||||
approval, which left `decline` as the only working operator action.
|
||||
The daemon now re-pins whenever the pinned definition's id disagrees with the
|
||||
task's workflow. A pin that is present, digest-valid and id-consistent is
|
||||
still a strict no-op, so an operator's own definition override survives a
|
||||
dispatch unchanged.
|
||||
- **A shipped workflow definition now reaches an existing install.** A stored
|
||||
seed was consulted only for a resource the store did not already hold, so a
|
||||
document that changed in the build never reached a database an earlier
|
||||
release had seeded. For workflow definitions that is a total outage rather
|
||||
than a stale setting: the collection validates as one document, so a stored
|
||||
step type this build no longer has failed every task's pin, whatever workflow
|
||||
the task named — and the documented recovery, removing the resource and
|
||||
restarting, wrote nothing either, because the store answered the seed's known
|
||||
request ID from a history that outlives the resource. A seed now refreshes a
|
||||
kind it wrote the newest revision of and re-creates a resource that is gone,
|
||||
while an operator's own replacement is never undone.
|
||||
|
||||
### archie-agent
|
||||
|
||||
The runtime image is rebuilt with this release and links the shared workflow
|
||||
package carrying the definition-id helper above. Hosts that run agent
|
||||
containers need `docker compose pull agent` after updating to pick it up.
|
||||
|
||||
## [1.44.0] - 2026-09-29
|
||||
|
||||
### archied
|
||||
|
||||
Archie can now review pull requests.
|
||||
|
||||
- **Reviews on request and by watch.** Ask in chat or on the dashboard work form, add a repository to the watch list, or just let archie review its own PRs before it opens them. Review intensity follows a depth dial (quick/standard/deep) classified from the size of the change, and every finished review passes a verification layer — coverage-gap and cross-finding consistency checks — before it is produced.
|
||||
- **No forge credential reaches the review sandbox.** The daemon prefetches the pull request's data and rebuilds its source snapshot over the forge's HTTP API, so the agent container works from an isolated copy with no read access to the repository's credentials.
|
||||
- **Reviews stop at the operator gate before posting.** `review.precision_gate` / `approve_before_post` decide whether a finished review posts itself or parks for operator approval. With this release the parked state is a stop sign, not a checkpoint: the approve/reject/re-review responses behind the gate are not wired yet, and the gate's settings are not yet editable in the dashboard (configure them in `config.toml`). A parked review sits until that follow-up lands.
|
||||
- The adversarial self-review pass archie previously ran before opening its own PRs is superseded by this pipeline and has been removed.
|
||||
- Hardened harness input handling: harness identifiers are bounded to integer types.
|
||||
|
||||
### archie-agent
|
||||
|
||||
The runtime image is rebuilt with this release; it links the shared pr-review workflow packages behind the reviews above. Hosts that run agent containers need `docker compose pull agent` after updating to pick it up.
|
||||
|
||||
## [1.43.0] - 2026-09-28
|
||||
|
||||
### archied
|
||||
|
||||
- **Organisations.** Tasks, identities and settings now belong to an org. An
|
||||
existing install is upgraded into a default org when the State Store first
|
||||
starts; the upgrade resumes if interrupted. Task de-duplication is scoped
|
||||
per org and identity.
|
||||
- **Access policies are enforced** at the dashboard, the API and task
|
||||
dispatch, with shipped roles and a rule that nothing crosses between orgs.
|
||||
Denials are recorded and reported on the health page. If a policy locks
|
||||
you out, `archied access reset --org <org>` (or `--instance`) on the State
|
||||
Store host restores the shipped defaults.
|
||||
- **Workflows can call workflows** with a `workflow.call` step. Inputs and
|
||||
call cycles are checked when the workflow is saved, and the caller waits
|
||||
on the callee's result.
|
||||
- **Runs record each step.** A run's stages and agent calls are stored as
|
||||
steps, the task detail page reads them, and stopping a task or archiving
|
||||
it goes through one cancel path. After a crash, steps left running are
|
||||
marked interrupted. Archiving a task removes its worktree.
|
||||
- **Model roles, repositories, scheduling policy, providers and agent
|
||||
profiles apply without a restart.**
|
||||
- **Kit harness profiles:**
|
||||
- `kit` is now one digest-pinned reference, a workload Kit or a published
|
||||
Kit set, not a list. **Rewrite `kit = [...]` in `config.toml` or the
|
||||
agent-profiles settings as the single reference**; a list no longer
|
||||
loads. Compose mixins by publishing a Kit set.
|
||||
- OAuth logins are handled on the host: the egress proxy refreshes tokens,
|
||||
stores them encrypted, and gives the container only placeholders.
|
||||
- A Kit's skills request mounts `skills_dir` read-only, and its
|
||||
instructions file (such as `CLAUDE.md`) is written beside the workspace,
|
||||
which is now `/archie/workspace`.
|
||||
- A run still cannot be granted the credential a Kit needs, so a Kit that
|
||||
requires one is refused at launch.
|
||||
- Rate-limited webhook deliveries get `429`.
|
||||
- `archie-gateway` and `archie-state-store` report ready to systemd.
|
||||
|
||||
### archie-agent
|
||||
|
||||
- Runs workflow calls, records its steps and agent calls, and runs Kit
|
||||
harness stages under the profile's Kit.
|
||||
|
||||
## [1.42.0] - 2026-09-26
|
||||
|
||||
### archied
|
||||
|
||||
- **The dashboard is rebuilt on a new Graphite theme.** Settings moved to its
|
||||
own sidebar with one save flow across every page (Channels, Tools & MCP,
|
||||
Scheduling policy, Personas and Schedules, Identities, Plugins, Container
|
||||
runtime, and a History of past changes). The top bar, Dashboard, Workflows,
|
||||
task detail, the New task dialog and the Events page are all new: Dashboard
|
||||
leads with what needs you, a run's stage rail and detail panels sit
|
||||
side by side, Workflows shows per-workflow stats including completed runs,
|
||||
and Events states capture status with a copyable capture endpoint. Live
|
||||
updates share one stream and reopen after a drop instead of going quiet.
|
||||
- **Settings changes are audited.** A field-level audit table records who
|
||||
changed what, with a view on each settings page.
|
||||
- **A task can carry a whole-run wall-clock limit**, separate from a stage's
|
||||
own budget.
|
||||
- **A run that makes no changes now ends as completed and its worktree is
|
||||
cleaned up**, rather than left in a state Workflows didn't count.
|
||||
- **Abandoning a task no longer closes its forge issue.** Only the workflow's
|
||||
own terminal outcomes do that now.
|
||||
- **A task whose container exits before the worker replies is parked**
|
||||
instead of left running with no way to finish.
|
||||
- **A worktree still holding uncommitted work is kept**, rather than reset,
|
||||
when its task reaches a terminal state.
|
||||
- **A provider's stored settings no longer get corrupted with a process-local
|
||||
placeholder in place of your configured secret reference**, and archied
|
||||
rejects a stored value shaped like one on the way back in.
|
||||
- **Kit v3 harness profiles.** A `[containers.profiles.<name>]` entry can now
|
||||
name a Kit v3 image (`kit = [...]`, pinned by digest) instead of a plain
|
||||
container image, running the task's agent stages on an external CLI --
|
||||
Claude Code, Codex, Pi, OMP or GitHub Copilot CLI -- inside an isolated
|
||||
sandbox network. This release lands the daemon-side plumbing (egress
|
||||
proxy, sandbox network, credential injection points); it does not yet ship
|
||||
a way to grant a run's identity the credential a Kit needs, so a Kit
|
||||
requiring one is refused at launch until a later release adds it.
|
||||
- `task dev` now starts the State Store and waits for it before the rest of
|
||||
the stack.
|
||||
- Every service binary the installer builds is stamped with its version.
|
||||
|
||||
### archie-agent
|
||||
|
||||
- Carries the same task-lifecycle fixes as archied above (no-change runs,
|
||||
parking on an early container exit, and the abandon/forge-issue fix), plus
|
||||
the Kit v3 harness runner: a stage can now drive an external CLI
|
||||
headlessly, read output from Claude Code, Codex, Pi, OMP or GitHub Copilot
|
||||
CLI, and serve it capture tools over MCP.
|
||||
- Claude's cached tokens are counted as prompt tokens, matching the built-in
|
||||
agent loop's accounting.
|
||||
|
||||
## [1.41.2] - 2026-09-25
|
||||
|
||||
### archied
|
||||
|
||||
- **`/update` no longer offers an old runtime.** The runtime has shipped under
|
||||
the release version since the version streams merged, but the update check
|
||||
still read the retired runtime tags, so a current host was offered runtime
|
||||
1.35.0 as an update. Do not approve that offer on 1.41.1; update to 1.41.2
|
||||
instead.
|
||||
- **`/version` reports the runtime version.** Binaries from the release zip
|
||||
showed `Runtime: dev`.
|
||||
|
||||
## [1.41.1] - 2026-09-25
|
||||
|
||||
### archied
|
||||
|
||||
- **First published build of 1.41.0.** The 1.41.0 tag produced no release
|
||||
artifacts; 1.41.1 carries everything listed under 1.41.0 below, including
|
||||
the PostgreSQL 18 requirement and the removed config keys.
|
||||
|
||||
## [1.41.0] - 2026-09-25
|
||||
|
||||
### archied
|
||||
|
||||
- **Archie now stores everything in PostgreSQL 18, and `database_url` is
|
||||
required.** Tasks, events, captures, bindings, settings and chat
|
||||
conversations are served from the database `database_url` names; the State
|
||||
Store, archied and the Gateway refuse to start without it, and refuse a
|
||||
server older than PostgreSQL 18. `docker compose up -d postgres` starts a
|
||||
matching local database with the default URL in `config.example.toml`.
|
||||
- **Existing SQLite data is not carried over.** This release reads no SQLite
|
||||
file and ships no importer, so an upgraded install starts with empty task,
|
||||
event and conversation history. `db_path` is gone; `state_dir` (default
|
||||
`~/.local/share/archie`) now holds the embedded NATS store and task logs.
|
||||
- **Backups are whole-database snapshots.** `archie-state-store backup` and
|
||||
`restore` work on the PostgreSQL database through `pg_dump`/`pg_restore`,
|
||||
which must be on `PATH`. There is no automatic schema rollback: the way back
|
||||
from an upgrade is restoring the snapshot taken before it.
|
||||
- **Events carry a type, and bindings pick one.** Archie infers an event type
|
||||
from captured payloads; the Inspector shows proposed and unidentified
|
||||
events and lets you name them. Mappings are per event type and show how
|
||||
many captures they match, a source can feed several bindings, and a binding
|
||||
chooses an event type plus an optional filter. An unidentified event does
|
||||
not dispatch.
|
||||
- **Sources own webhook signing.** Each source gets a UUIDv7 path and its own
|
||||
signing secret, or can be explicitly approved to accept unsigned events. A
|
||||
new binding starts pending approval.
|
||||
- **EDA playbooks can run module actions and take workflow inputs.** Action
|
||||
playbooks run at most once per event through the dispatch ledger, a binding
|
||||
can pass inputs to its workflow, the repository is optional, and a workflow
|
||||
can name an agent profile. `archie-playbooks lint -eda-dir` checks a
|
||||
directory, and `archie-playbooks serve` publishes the same findings to your
|
||||
editor as a language server.
|
||||
- **Config keys removed.** `[agent]`, `[oidc]`, `[image]`,
|
||||
`containers.enabled`, `db_path`, and the `token_env` form of `[forge]`,
|
||||
`[artifacts]` and `[chat.telegram]` no longer exist. Write each credential as
|
||||
`token = { engine = "env", key = "NAME" }`. A leftover key is reported at
|
||||
startup as unrecognised rather than failing the load.
|
||||
- **Dashboard.** Old `#/path` links and the `/captures`, `/mappings` and
|
||||
`/bindings` addresses no longer redirect; use the Events page tabs. The live
|
||||
stream moved to `/api/stream`, so reloading `/events` serves the page.
|
||||
|
||||
### archie-agent
|
||||
|
||||
- The Postgres-backed wire formats, event types and workflow inputs are part
|
||||
of this image; a host that runs the agent should `docker compose pull agent`
|
||||
to pick it up.
|
||||
|
||||
## [1.40.0] - 2026-09-23
|
||||
|
||||
### archied
|
||||
|
||||
- **Every park now says what kind of intervention it needs.** A parked task
|
||||
is classified as `needs you` (a decision or fix only an operator can
|
||||
supply), `transient` (an environment problem -- container pool, storage,
|
||||
transport -- retry once it is fixed), or `terminal` (the repository or
|
||||
identity cannot act; retrying cannot succeed). The class shows beside the
|
||||
Parked badge on the dashboard, so "needs you" reads as a request rather
|
||||
than a failure.
|
||||
- **Operator retries and review-remediation rounds now have separate
|
||||
budgets.** An operator's manual retries no longer draw down the rounds
|
||||
Archie may spend addressing review feedback on its pull requests, and a
|
||||
round-cap park no longer makes a later retry re-park immediately.
|
||||
- **`latest` now names the newest release. A push to `main` that is not a
|
||||
release publishes `edge` and `sha-<commit>` instead. A host that was
|
||||
following `main` by pulling `latest` stops advancing at this release --
|
||||
switch it to `edge` to keep tracking `main`, or leave it on `latest` to
|
||||
follow releases.**
|
||||
|
||||
### archie-agent
|
||||
|
||||
- The park-classification wire format is part of this image; a host that
|
||||
runs the agent should `docker compose pull agent` to pick it up.
|
||||
|
||||
## [1.39.0] - 2026-09-23
|
||||
|
||||
### archied
|
||||
|
||||
- **Archie now acts on review comments left on its own pull requests.** A
|
||||
requested-changes review (or a standalone comment) on a PR Archie opened
|
||||
dispatches a remediation run: the smallest change that satisfies the
|
||||
feedback, committed to the same PR branch and answered in the review
|
||||
thread. Approved reviews never remediate, each reaction is its own round,
|
||||
and the exchange is bounded by the repo's `max_retries` before Archie stops
|
||||
and says so on the PR.
|
||||
- **The task run page is a master-detail view.** The run's stage rail and
|
||||
detail panels sit beside the run list, so one run's timeline is visible
|
||||
without leaving the page.
|
||||
- **Live activity groups related updates instead of stacking them by event
|
||||
kind**, so a burst of progress on one task reads as one story, and the
|
||||
stage filter resets when you switch attempts.
|
||||
- Contrast fixes on the info and subtle text tokens clear WCAG AA.
|
||||
|
||||
### archie-agent
|
||||
|
||||
- The review-reaction remediation path is part of this image; a host that
|
||||
runs the agent should `docker compose pull agent` to pick it up.
|
||||
|
||||
## [1.38.0] - 2026-09-23
|
||||
|
||||
### archied — Event capture, mappings and bindings are PocketBase records
|
||||
|
||||
- **Captured events, field mappings and playbook bindings live in PocketBase
|
||||
collections instead of SQLite tables.** They are ordinary records, which is
|
||||
what lets a binding be changed at runtime rather than by editing a database.
|
||||
- **A read-only operator surface over the task database ships with the State
|
||||
Store** (`archie-state-store -admin-addr`). It serves view collections over
|
||||
tasks, transitions, events, identities and resources, and refuses
|
||||
`/api/backups` and `POST /api/sql`, so it cannot rewrite state or hand out the
|
||||
database file.
|
||||
- **A binding cannot go live without approval.** It moves draft → pending
|
||||
approval → armed; one binding per source is enforced on insert, on edit and
|
||||
on approval; and an edit always returns it to pending approval. A secret left
|
||||
blank on an edit keeps the stored one rather than disarming a live binding.
|
||||
- **The workspace code-search indexer is gone.** No deployment configured it,
|
||||
and it was one more resident writer over the workspace.
|
||||
|
||||
### archied — Editing a binding or a mapping shows on the activity stream
|
||||
|
||||
- **A dashboard edit no longer needs a manual refresh.** A successful binding or
|
||||
mapping write announces itself on the same activity path a captured event
|
||||
already uses. The announcement carries the record id and the action and the
|
||||
dashboard refetches the record, so the signal cannot go stale.
|
||||
|
||||
### archied — Cron schedules fire
|
||||
|
||||
- **A cron job computes its next run and fires.** Until this release a cron
|
||||
schedule was accepted at creation and then refused at run time with
|
||||
`ErrScheduleUnsupported`, so a cron job never ran.
|
||||
- **The dialect is PocketBase's, and it differs from Vixie cron on one point.**
|
||||
Day-of-month and day-of-week are combined with AND rather than Vixie's OR, so
|
||||
`0 0 1 * 1` means Monday the 1st, not "the 1st, or any Monday". The
|
||||
`@daily`-style macros behave as usual. An expression that can never match,
|
||||
such as `0 0 30 2 *`, is rejected instead of being left to run forever.
|
||||
|
||||
### archied — Tool calls are queryable
|
||||
|
||||
- **Every completed tool call is a row in the `tool_calls` collection**, not
|
||||
only a line in the on-disk task log. The row carries the task, the attempt,
|
||||
the tool, its result or its error, and when it ran.
|
||||
- **A failed projection never fails the task.** The event is the record and the
|
||||
collection is a transcript of it, so a copy that could not be written is
|
||||
logged and counted rather than propagated.
|
||||
|
||||
### archied — A task whose identity no longer resolves parks instead of acting as root
|
||||
|
||||
- **A task naming an identity archie no longer knows — renamed, retired or
|
||||
removed in the control plane — no longer falls back to the root forge's
|
||||
credential.** It parks with the reason recorded. A task arriving over NATS
|
||||
with such an identity is refused before it is enqueued. A task with no
|
||||
identity is the single-identity root path and is unchanged.
|
||||
|
||||
### archied — The PR review is published as a readable artifact
|
||||
|
||||
- **A completed review is rendered to markdown and published to the
|
||||
collaborative editor**, so a person reads it and comments on it instead of
|
||||
reading a wall of text in a pull-request comment.
|
||||
- **Publishing never fails the review.** With `[artifacts] base_url` unset the
|
||||
sender is not constructed and publishing is a log line; a publish that fails
|
||||
is logged with its status and the same review is republished the next time it
|
||||
completes. Set `[artifacts] token` (or `WORKSPACE_INGEST_TOKEN`) to enable it.
|
||||
|
||||
### archied — The activity feed no longer depends on row ids being monotonic
|
||||
|
||||
- **The feed's resume cursor is opaque, and a malformed or pre-upgrade cursor
|
||||
degrades to "from the beginning" rather than failing the stream.** One
|
||||
consequence on upgrade: a browser holding a cursor issued before this release
|
||||
replays the backlog once.
|
||||
|
||||
### archie-agent
|
||||
|
||||
- **The runtime image is rebuilt by this release, and a host must pull it**
|
||||
(`docker compose pull agent`). The shared State Store contract changed shape
|
||||
in the sections above — task and event-capture id fields are strings now — and
|
||||
the two halves are versioned together, so an agent image built before this
|
||||
release does not speak to the new State Store. There are no agent behaviour
|
||||
changes of its own in this release.
|
||||
|
||||
## [1.37.1] - 2026-09-22
|
||||
|
||||
### archied — A recorded event names the actor in its own fields
|
||||
|
||||
@@ -1,362 +1,152 @@
|
||||
# AGENTS.md
|
||||
|
||||
Guidance for any coding agent working in this repository.
|
||||
|
||||
Keep every rule here harness-agnostic: name the required behaviour, not the tool
|
||||
that provides it (e.g. "spawn a fresh reviewer that did not write the code", not
|
||||
a specific sub-command).
|
||||
|
||||
## Code Quality & Refactoring Standards
|
||||
|
||||
- **Zero Patch Stacking:** Never apply more than two sequential fixes to the
|
||||
same logic block. If a solution fails twice, scrap the block and rewrite it
|
||||
cleanly.
|
||||
- **Root-Cause Fixes:** Fix invalid state at the producer, not via defensive
|
||||
checks at the consumer.
|
||||
- **Architectural Simplicity:** Prefer a complete 20-line rewrite over a 5-line
|
||||
band-aid that adds conditional complexity or obscures intent.
|
||||
- **Revert on Flail:** If an implementation becomes convoluted to satisfy edge
|
||||
cases, discard the approach and select a simpler design.
|
||||
Rules for any agent working in this repository. Short on purpose: every rule
|
||||
here changes a decision. If a rule stops changing decisions, delete it.
|
||||
|
||||
## What this is
|
||||
|
||||
**archied** is a resident daemon that polls a forge (GitHub, Gitea) for issues
|
||||
assigned/labelled to it, works each one in an isolated git worktree through a
|
||||
routed workflow (bootstrap / implement / TDD / feasibility), and opens pull
|
||||
requests for human review.
|
||||
**archie-core** is event-driven agentic automation. An event (an issue, PR,
|
||||
webhook, schedule, chat message) is matched to a workflow, the workflow runs an
|
||||
agent or tool in an isolated container, and the result lands somewhere for
|
||||
review or action. A repository is an optional input to a workflow, not the point
|
||||
of the product.
|
||||
|
||||
See `ARCHITECTURE.md` for the package map, workflow engine design, task
|
||||
lifecycle, and key design decisions. Read it before making non-trivial changes.
|
||||
Key invariants: env-enforced gates, model never runs git, and agent execution
|
||||
functions as a strict data boundary. Before adding a new plugin engine, satisfy
|
||||
`ARCHITECTURE.md#plugin-engine-rule-strict`.
|
||||
<temporary - this statement must be removed on 2026-10-10"> The product is
|
||||
unfinished. Many features are half-built, and the codebase carries far more
|
||||
code, binaries, docs and tooling than it delivers. The job right now is to
|
||||
finish features and shrink the codebase, not to extend it. </temporary>
|
||||
|
||||
## Scope Discipline
|
||||
## Authority
|
||||
|
||||
`docs/architecture/` is authoritative for settled design.
|
||||
`docs/architecture/migration-decisions.md` is the open decision register for the
|
||||
domain migration.
|
||||
When sources disagree, the higher one wins:
|
||||
|
||||
- **Settled design exists** → Implement it immediately with a diff. Do not
|
||||
produce design prose. If a small detail is missing, ask the maintainer
|
||||
directly.
|
||||
- **No settled design exists (or open in `migration-decisions.md`)** → Write a
|
||||
decisive, 1-page design doc before coding. Land new capabilities in
|
||||
`docs/prds/` and migration questions in
|
||||
`docs/architecture/migration-decisions.md`. Promote to `docs/architecture/`
|
||||
only after implementation lands.
|
||||
- **Strictly Prohibited:** Ownership ledgers, field-level inventories,
|
||||
current-state traces, parity matrices for their own sake, and
|
||||
planning/refactor tracking issues.
|
||||
- **Solo Project Context:** Prefer the smallest workable change over extensive
|
||||
defensive scaffolding.
|
||||
- **Verify handed-over input before acting on it.** An export, transcript, or
|
||||
artifact that is empty, missing, or truncated is a blocking fact: report it
|
||||
before starting work that assumes its contents. Never reconstruct the intent
|
||||
from the working tree instead.
|
||||
- **PRD writing:** Read and follow `docs/prds/RULES.md` before creating or
|
||||
editing a PRD.
|
||||
1. The maintainer's instruction in this session.
|
||||
2. This file.
|
||||
3. The code as it is in the tree.
|
||||
4. Beads issues (`bd show <id>`): the plan for a piece of work.
|
||||
5. Everything else (memories, comments, old docs) is a hint. Verify it against
|
||||
the code before acting on it.
|
||||
|
||||
## Deployment Model
|
||||
## How to decide
|
||||
|
||||
- **Systemd is optional:** `deployments/` holds supported profiles
|
||||
(`single-forge-github.toml`, `multi-forge-github-gitea.toml`,
|
||||
`local-ollama-standalone.toml`, `docker-nats-stack.toml`,
|
||||
`systemd-user-service.md`). Never assume a systemd unit exists.
|
||||
- **Chat filesystem confinement:** Builtin tools default to workspace jail via
|
||||
`SetPathConfinement(!unrestricted)`. Unrestricted access requires
|
||||
`[chat] unrestricted_filesystem = true`.
|
||||
- **NATS endpoint immutability:** The daemon passes agent containers its startup
|
||||
connection URL (`d.ConnectedNATS.URL`). Containers and daemon must resolve
|
||||
this address. Embedded mode binds to the Docker bridge gateway. A SIGHUP
|
||||
reload of `nats.url` logs an error requiring restart to prevent split-brain
|
||||
delivery.
|
||||
- **Container pull policy:** `containers.pull_policy` must be `"missing"`
|
||||
(default) or `"always"`. Private registries return 401 on `"always"` because
|
||||
no auth is sent. Refresh explicitly via `docker compose pull agent`.
|
||||
- **Docker Compose:** `docker-compose.yml` carries optional external NATS and
|
||||
the `agent` build stanza. The agent uses a `build` profile so `up -d nats`
|
||||
never starts it as a persistent service.
|
||||
- **Config path:** Runtime configuration lives at
|
||||
`${XDG_CONFIG_HOME:-~/.config}/archie/config.toml`. Nothing in the working
|
||||
tree is load-bearing at runtime.
|
||||
- **Broken beats new.** A bug that blocks work gets fixed now, with the smallest
|
||||
change that unblocks it. No design docs and no new mechanism.
|
||||
- **Cheapest option first.** Before building, name the smallest change that
|
||||
solves the problem, including changing configuration or deleting something. If
|
||||
your plan adds a new mechanism (RPC, process, binary, abstraction, config
|
||||
field, tool) or grows past about 100 lines, stop and assess whether you're
|
||||
taking the path of least resistance.
|
||||
- **Delete before adding.** Unused code, dead paths, fallbacks nobody takes and
|
||||
features nobody runs get removed, not maintained. Solo project, single user:
|
||||
breaking changes need no compatibility shims.
|
||||
- **Finish before starting.** Prefer completing a half-built feature end to end
|
||||
over starting a new one.
|
||||
- **Services own contracts.** A service is a gRPC contract in
|
||||
`proto/<service>/v1` and one binary that serves it. Services reach each other
|
||||
only through those contracts, never through another service's tables or
|
||||
packages. A new command is a subcommand of an existing binary. A new binary
|
||||
exists only for a new service or a real process boundary.
|
||||
- **No compensating tools.** Do not write a linter, checker or generator to
|
||||
enforce something a simpler design would make unnecessary. Fix the design.
|
||||
- **A setting must work end to end.** A config field that parses but has no
|
||||
consumer is a bug. Settings are edited through the control plane (API and
|
||||
dashboard), never by requiring a server login.
|
||||
- **Ask only for real decisions.** Product direction and trade-offs the
|
||||
maintainer owns are questions. Everything with a conventional answer is not:
|
||||
decide, do it, say what you chose.
|
||||
|
||||
## Release Process
|
||||
## Code
|
||||
|
||||
See `RELEASING.md`. Most sessions touch only `archied`, making releases
|
||||
gateway-only (`RUNTIME=skip`) by default. Skip untouched components
|
||||
automatically and note it in the handoff.
|
||||
- Idiomatic Go. Small functions, explicit errors, no package-level mutable
|
||||
state, no god objects. Each feature wires itself; a composition root only
|
||||
calls those constructors in order.
|
||||
- Dependencies point inward: `cmd → app → {domain, infrastructure}`,
|
||||
`infrastructure` implements `domain` interfaces, `domain` imports neither.
|
||||
`cmd/` parses flags and calls `app`, nothing else.
|
||||
- Fix invalid state where it is produced, not with checks where it is consumed.
|
||||
- If a fix fails twice, throw the block away and rewrite it simply.
|
||||
- Comments say why, briefly. No migration history, phase names or issue
|
||||
narration in code.
|
||||
- Generated files (`ui/dist/`, protobuf, sqlc) are regenerated and committed
|
||||
with the change that caused them, never hand-edited.
|
||||
|
||||
## Build & Test
|
||||
## Tests
|
||||
|
||||
Commands are defined in `Taskfile.yml` (requires Go 1.27.0,
|
||||
[Task](https://taskfile.dev), `gofumpt`, `golangci-lint`, and Node/npm).
|
||||
`golangci-lint` is the single writer for ordinary Go formatting; standalone
|
||||
`gofumpt` formats generated protobuf contracts only.
|
||||
The default for a change is no new test. Write one only when:
|
||||
|
||||
- something actually broke: write the test that reproduces it, see it fail on
|
||||
the assertion, then fix; or
|
||||
- the change alters one of these seams: State Store SQL semantics (transition
|
||||
guards, idempotent dispatch, cancellation), security boundaries (HMAC, grants,
|
||||
path confinement, egress, secrets), the workflow step contract, or the
|
||||
import-boundary rules.
|
||||
|
||||
A test that exists must catch a real regression, survive refactoring, run fast,
|
||||
and be cheap to keep. Never test wiring, constants, defaults, struct shapes,
|
||||
fakes, or call order. One table-driven test per behaviour; extend the table
|
||||
instead of adding a second test. Prefer making an invalid state unrepresentable
|
||||
to testing that it is rejected. Test helpers live in `_test.go` files only.
|
||||
|
||||
## Invariants
|
||||
|
||||
These protect users. Do not weaken them without the maintainer's say-so.
|
||||
|
||||
- Failure stays local. Any service may crash, restart or be absent without
|
||||
losing accepted work or taking another service down. Callers retry, degrade
|
||||
and report the dependency as unhealthy; they never exit because a peer is
|
||||
missing, and work is acknowledged only once it is durable.
|
||||
- The model never runs git. Commits and pushes go through the daemon.
|
||||
- The daemon's own credentials never enter an agent container. Containers get
|
||||
task-scoped grants that are revoked when the task ends.
|
||||
- Webhook HMAC is verified before the payload is parsed.
|
||||
- Task briefs go in `<worktree>/.git/task.json`, never the worktree root.
|
||||
- NATS: task and RPC replies use `msg.Respond`; flush after registering a
|
||||
responder; `ARCHIE_TASKS` is a work queue, so never bind overlapping
|
||||
consumers.
|
||||
- `ai-sdk` `FullStream` must be drained completely.
|
||||
|
||||
## Build and gate
|
||||
|
||||
```bash
|
||||
task build # build archied and archie-agent binaries into bin/
|
||||
task test # go test ./... -count=1
|
||||
task test:ui # dashboard node tests (DOM-building primitives)
|
||||
task ui # build dashboard into ui/dist (LAW asset)
|
||||
task fmt # go fix ./... && golangci-lint fmt
|
||||
task vet # go vet ./...
|
||||
task lint # golangci-lint run ./...
|
||||
task check # fmt + proto:lint + proto:check + docs:check + vet + lint + build + test + test:tools + test:ui (The Definitive Gate)
|
||||
task dev # archied live-reload + Vite HMR together on :5173
|
||||
task build # binaries into bin/
|
||||
task test # go test -short ./...
|
||||
task ui # dashboard into ui/dist
|
||||
task check # the gate
|
||||
```
|
||||
|
||||
Single package/test runs:
|
||||
Requires Go 1.27, Task, golangci-lint, Node/npm and Docker. Adopt `task fmt` and
|
||||
`go fix` output as-is.
|
||||
|
||||
- `task check` gates the commit: `task check && git commit ...`. Never claim a
|
||||
gate result you did not just produce on that exact tree; if the gate could not
|
||||
run, say what you did verify.
|
||||
- Commit finished work without asking. Stage only your own paths and commit in
|
||||
the same command. Conventional Commits scoped by package, short messages. Push
|
||||
only when told.
|
||||
- Never commit binaries, build output, scratch files or `.references/`. Scratch
|
||||
goes in `/tmp`.
|
||||
- Runtime config lives at `${XDG_CONFIG_HOME:-~/.config}/archie/config.toml`.
|
||||
Nothing in the working tree is read at runtime. Systemd is optional.
|
||||
- Releases: `RELEASING.md`.
|
||||
|
||||
## Issues (beads)
|
||||
|
||||
Work is tracked in `bd`, never in Markdown TODO files.
|
||||
|
||||
```bash
|
||||
go test ./internal/domain/workflow/... -run TestName -v -count=1
|
||||
bd ready | bd show <id> | bd update <id> --claim | bd close <id>
|
||||
```
|
||||
|
||||
## Repository Hygiene
|
||||
- An issue is the plan: what is wrong or wanted, and how you know it is done.
|
||||
Keep it to that.
|
||||
- Bead state syncs through Dolt (`bd dolt push/pull`, only when told), not git.
|
||||
Never commit `.beads/` exports.
|
||||
- No host names, IPs, paths, PIDs or credentials in any bead: they are
|
||||
published.
|
||||
- File follow-up work you find as a bead. Do not fix it in passing.
|
||||
|
||||
- **Generated assets are LAW:** Never modify, revert, or ignore generated files
|
||||
in `ui/dist/` or schema outputs. Incorporate them into relevant commits.
|
||||
- **Ignored paths:** Never commit build artifacts, binaries (`/bin/`,
|
||||
`/archied`), DB files, working screenshots, `.references/`, or
|
||||
`node_modules/`.
|
||||
- **Scratch files:** Place scratch files strictly in `/tmp` or the harness
|
||||
scratch space. Never put scratch files in the working tree
|
||||
(`worktree.CommitAll` will stage them).
|
||||
- **Conventional Commits:** Scope by package: `feat(webui): ...`,
|
||||
`fix(build): ...`, `chore(release): ...`.
|
||||
- **Commit policy:** Commit finished, gate-clean changes (`task check`
|
||||
passing) without asking. Push only when instructed.
|
||||
## Changing this file
|
||||
|
||||
## Organisation (Strict Domain-Driven Architecture)
|
||||
|
||||
`docs/architecture/organisation.md` is authoritative. Do not follow flat
|
||||
structures found in legacy packages.
|
||||
|
||||
### Layers and Ownership
|
||||
|
||||
- `internal/domain/<area>/`: Domain logic, entities, state machines, commands,
|
||||
events, and required contracts (interfaces). Never imports infrastructure or
|
||||
app.
|
||||
- `internal/infrastructure/<service>/`: Implementations of domain contracts
|
||||
(persistence, forge clients, external transports, config loading).
|
||||
- `internal/app/<application>/`: Dependency injection, wiring domain to
|
||||
infrastructure, lifecycle management, and shutdown ordering.
|
||||
- `cmd/<binary>/`: CLI flag parsing, OS signal traps, and entry point routing
|
||||
only. No domain wiring.
|
||||
|
||||
### Invariants
|
||||
|
||||
- **Dependency Flow:** `cmd → app → {domain, infrastructure}`, with
|
||||
`infrastructure → domain` implementing contracts. Downward/inward dependencies
|
||||
only.
|
||||
- **Cross-Cutting Packages:** `logging`, `events`, `eventbus`, `policy`,
|
||||
`taskstate` sit directly under `internal/`. They may be imported by any layer,
|
||||
but **must import zero internal packages**. No `shared/`, `utils/`, or
|
||||
`common/` catch-alls.
|
||||
- **File Layout:** One file per API concern (`api_tasks.go`, `api_logs.go`). A
|
||||
package owns its on-disk format end-to-end (e.g. `internal/logging` defines
|
||||
and reads its format; transport layers do not parse).
|
||||
- **Frontend:** Features live in `ui/src/<feature>/` with colocated `.js` and
|
||||
`.css`. Extract to `ui/src/base/` only on the second distinct consumer.
|
||||
|
||||
## Per-Package Invariants & Traps
|
||||
|
||||
- **Config fields (cross-cutting): a field that parses is not a field that works.**
|
||||
A knob added to a struct the extensible surface reuses *parses* everywhere
|
||||
without taking effect anywhere, and a knob read from the wrong layer is just
|
||||
as invisible: a file key is only a seed once a stored resource outranks it.
|
||||
Before adding or reusing a config field, name its consumer, and reject the
|
||||
configuration when there is none - which is what this repo now does for
|
||||
per-identity `forge.intake`. Two documents carry the detail:
|
||||
`.agents/skills/archie-config-and-flags` holds the wiring matrix, the
|
||||
decoded-but-unwired ledger and the three shapes an unwired field can take;
|
||||
`docs/architecture/configuration.md` is the authority on the config model and
|
||||
its reloadability criterion.
|
||||
|
||||
- **`internal/channels/telegram/`:**
|
||||
- The long-polling worker must call `dropPendingUpdates(ctx, b)` before
|
||||
`b.Start(ctx)` and on `/restart`.
|
||||
- Always publish command menus to `default`, `all_private_chats`, and
|
||||
`all_group_chats` simultaneously via `commands.go` to avoid scope shadowing
|
||||
from legacy registrations.
|
||||
|
||||
- **`ai-sdk` Streaming:** `FullStream` writes synchronously and MUST be drained
|
||||
completely to prevent producer deadlocks. Do not rely on `TextStream` (drops
|
||||
deltas).
|
||||
- **NATS Invariants:**
|
||||
- `ARCHIE_TASKS` uses `jetstream.WorkQueuePolicy`. Do not bind overlapping
|
||||
consumer filters; use `Fetch` on existing durables instead of new `Subscribe`
|
||||
calls.
|
||||
- RPC and task responses must use core NATS `msg.Respond` to write to ephemeral
|
||||
`_INBOX.*` subjects, not `eventbus.Publisher`.
|
||||
- Always flush connections (`nc.Flush()`) immediately after registering
|
||||
responders to avoid race conditions on initial requests.
|
||||
|
||||
- **`internal/gateway/` Chat Prompt:** System prompt `<tools>` blocks are
|
||||
rendered strictly from the active `core.ToolSet`. Never decouple prompt tool
|
||||
definitions from passed runtime tools.
|
||||
- **`internal/container/pool.go` (`WriteTaskJSON`):** Write task briefs to
|
||||
`<worktree>/.git/task.json`. Never place them in the worktree root (`go-git`
|
||||
`Add{All:true}` ignores `.gitignore` and leaks root files into branch
|
||||
commits).
|
||||
- **MCP Providers:** Daemon registers providers as optional via
|
||||
`providerRegistry.RegisterOptional`. Missing or failed providers log warnings
|
||||
and degrade health without terminating the process.
|
||||
- **`internal/infrastructure/staterpc/` (State Store gRPC contract):**
|
||||
Authority is `docs/prds/state-store-contract.md` (rev. 2e) -- read it before
|
||||
changing this package or its callers.
|
||||
- The proto (`proto/state/v1/state.proto`, service `StateStoreService`,
|
||||
package `statev1` in `internal/contracts/state/v1/`) is one gRPC service
|
||||
fronting every ratified store contract (50 RPCs, including grant management
|
||||
and deprecated compatibility RPCs); the Go consumer facades
|
||||
stay narrow (`workflow.Store`, `store.TaskStore`, etc., all ≤8 methods
|
||||
except the `TaskStore` composite) via `staterpc.Client`'s multiple `var _`
|
||||
assertions -- never add a Go interface method without a matching RPC.
|
||||
- Error sentinels (`store.ErrStaleTransition`, `ErrBindingNotFound`, ...)
|
||||
cross the wire via `mapError`/`unmapError` in `values.go`, matched on
|
||||
`(code, exact canonical message)`. Changing a canonical message string
|
||||
breaks `errors.Is` on the client without changing behavior visibly --
|
||||
treat those message constants as part of the wire contract.
|
||||
- The State Store is a standalone process (`cmd/archie-state-store`, run via
|
||||
`archied.RunStateStore`) -- the daemon and Gateway never own `archie.db` or
|
||||
serve this service in-process; `boot.openStateStore` in
|
||||
`internal/app/archied/state_store.go` is the only caller of
|
||||
`openProductionTaskStore`. Never add a second listener for the same
|
||||
service, and never reintroduce an in-process serving path in the
|
||||
daemon/Gateway (`TestOpenStoresNeverOwnsTaskDB` guards this).
|
||||
- Per-task credentials are scoped, not just authenticated: `daemon.
|
||||
StateStoreGrantIssuer` (`staterpc.GrantIssuer`) registers a fresh
|
||||
task-scoped grant at the remote State Store via `RegisterTaskGrant` before
|
||||
`ContainerPool.Acquire` and revokes it via `RevokeTaskGrant` on `Release`
|
||||
(`acquireTaskContainer`/`process` in `internal/daemon/daemon.go`). Fails
|
||||
closed (parks the task) if a State Store is configured but no issuer is
|
||||
wired -- it must never fall back to forwarding the daemon's own
|
||||
administrative token. Server-side, `staterpc.TaskGrants.UnaryInterceptor`
|
||||
authorizes a task-scoped token for only `Update`/`Transition`/`InsertEvent`
|
||||
on its own task ID; every other RPC (including `RegisterTaskGrant`/
|
||||
`RevokeTaskGrant` themselves and the streaming capture RPCs) requires the
|
||||
administrative token.
|
||||
- `archie-agent` has exactly one `workflow.Store` path: gRPC via
|
||||
`staterpc.Client` (`agenttransport/nats.Transport.Store`), using the
|
||||
`STATE_STORE_URL`/`STATE_STORE_TOKEN` env the daemon injects. The legacy
|
||||
NATS `storerpc` transport is deleted (`internal/storerpc` no longer
|
||||
exists); do not reintroduce a dual-path selection.
|
||||
- `store.BindingDispatcher.RecordDispatch` takes no `*sql.Tx` (dropped in
|
||||
`.4.2` -- it cannot cross a gRPC boundary; production always passed `nil`).
|
||||
Do not reintroduce a transaction parameter on a producer-owned store
|
||||
interface that a remote adapter must also implement.
|
||||
- **`internal/forge/webhook/` (forge webhook receiver):**
|
||||
- Verify HMAC (`webhookguard.VerifyHMAC` against `X-Hub-Signature-256`) before
|
||||
parsing the payload, never after -- an unverified body must not reach
|
||||
`github.ParseWebHook`.
|
||||
- Do not give the webhook-built `workintake.TaskEnvelope` a delivery-source-
|
||||
specific idempotency key. `IdempotencyKey()` is keyed on `owner/repo/number`
|
||||
only so a webhook-delivered issue and a later poll of the same issue dedup
|
||||
against each other via `PublishUnique`; adding an event ID or timestamp to
|
||||
the key defeats that and reintroduces poll/webhook double-dispatch.
|
||||
- Webhook intake refuses to start when `[[identities]]` is configured (one
|
||||
receiver, one dispatch config). Do not silently enable it for multi-identity
|
||||
deployments without first building per-identity routing -- see
|
||||
`ARCHITECTURE.md`'s "Webhook intake" section.
|
||||
- **`internal/domain/embedding/` + `internal/infrastructure/embedding/`:**
|
||||
Embedding client contract + implementation. Config-driven exactly like chat
|
||||
model roles: `models.embedding = "provider/model"` plus a `[providers.*]`
|
||||
entry. `infrastructure/embedding.New` degrades to `(nil, false)` -- never an
|
||||
error -- for a missing role, unknown provider, unsupported class, or
|
||||
unresolved credential; wired as an optional capability in
|
||||
`bootstrap.go`'s `setupEmbeddings`. Only provider classes matching
|
||||
`config.Provider`'s shape are supported (openai, gemini, ollama, cohere,
|
||||
mistral) -- azure needs a `Deployment` field this config type doesn't have.
|
||||
- **`internal/domain/sampling/`:** The curator `Sampler` interface (see
|
||||
`docs/prds/curator-sampler-wave1.md`) plus four pure, deterministic
|
||||
strategies (recency, staleness, random, all). No curator consumes a
|
||||
`Sampler` yet -- `curator.Registrar` is untouched by this package.
|
||||
|
||||
## Development Protocol
|
||||
|
||||
1. **Red (Failing Test):** For behaviour with real logic, branching, or a
|
||||
contract, write failing table-driven tests first against target behaviour.
|
||||
Verify the failure originates from test assertions, not compilation errors.
|
||||
Do not write tests that restate an assignment or a constant: a test that
|
||||
cannot fail for an interesting reason is noise in the gate.
|
||||
2. **Green (Implementation):** Implement minimal code to satisfy the failing
|
||||
tests.
|
||||
3. **Quality Gate:** Run `task check`.
|
||||
- **The gate gates the commit.** Let the gate's exit status decide whether
|
||||
the commit runs, as one conditional chain (`check && commit && push`).
|
||||
Writing them as separate statements on one command line makes the gate
|
||||
decorative: nothing reads its status but the operator, and a failure is
|
||||
discovered after it has already been pushed.
|
||||
- **Never assert a gate result you have not just produced on that exact
|
||||
tree.** A commit message outlives the tree it describes, and "verified"
|
||||
is read by people who were not there. If the tree moved, describe the
|
||||
change and let the run speak.
|
||||
4. **Formatting is LAW:** Adopt all formatting and simplification changes from
|
||||
`task fmt` (`go fix` + the configured golangci-lint formatters) verbatim.
|
||||
Never revert or fight canonical linter/formatter diffs.
|
||||
5. **No standing adversarial-review pass (for contributors):** Do not spawn a
|
||||
separate fresh-context reviewer pass on every change as a matter of course.
|
||||
Red-green TDD plus `task check` is the gate; a manual adversarial pass is
|
||||
opt-in per request — ask before running one. This is the rule for a human or
|
||||
agent *contributor*. Separately, archied runs the same adversarial review
|
||||
automatically on the PRs it opens (gated per repo by `repo.review_enabled`)
|
||||
— see `docs/architecture/adversarial-review.md`. The two paths are distinct:
|
||||
you run one when asked; archied runs one before it opens a PR.
|
||||
6. **Linter Guard:**
|
||||
|
||||
- When using `errorlint` fixes, ensure boolean predicates (e.g.
|
||||
`exitErr.ExitCode() == 1`) are retained alongside `errors.As`.
|
||||
- When extracting loops/conditionals, verify slice mutations and pointer
|
||||
semantics do not duplicate elements.
|
||||
|
||||
## Issue Tracking (Beads)
|
||||
|
||||
All task management is tracked via **bd (beads)**. Do not write local Markdown
|
||||
TODO lists or use non-Beads trackers.
|
||||
|
||||
### Commands
|
||||
|
||||
```bash
|
||||
bd ready # List unclaimed work
|
||||
bd show <id> # View issue details
|
||||
bd update <id> --claim # Claim an issue
|
||||
bd close <id> # Mark issue complete
|
||||
bd remember # Persist cross-session architectural facts
|
||||
```
|
||||
|
||||
- Run `bd prime` to inspect full engine context.
|
||||
- Use `bd remember` for knowledge retention. Do not write to root `MEMORY.md`
|
||||
files.
|
||||
- Issues live in a local Dolt DB, synced to its own `git+` remote via
|
||||
`bd dolt push`/`bd dolt pull`. `.beads/issues.jsonl` and
|
||||
`.beads/interactions.jsonl` are local-only export/audit files
|
||||
(`.gitignore`d, `export.auto: false`) -- never `git add` them and never
|
||||
create a commit whose only content is beads bookkeeping. Bead state moves
|
||||
through Dolt, not through git commits on this repo.
|
||||
|
||||
## Session Completion Protocol
|
||||
|
||||
1. **Log remaining work:** File new items via `bd` for identified debt or
|
||||
follow-up tasks.
|
||||
2. **Run gate:** Verify `task check` passes completely clean.
|
||||
3. **Update tracker:** Close finished issues via `bd close <id>`. This alone
|
||||
is not commit-worthy -- do not stage or commit `.beads/` for it.
|
||||
4. **Commit:** Only for actual code/doc changes, scoped to the files that
|
||||
changed.
|
||||
|
||||
```bash
|
||||
git add <scoped-files>
|
||||
git commit -m "feat(scope): description"
|
||||
```
|
||||
|
||||
5. **Sync & Push Policy:** Do not push to git remotes or run `bd dolt push`
|
||||
unless explicitly instructed.
|
||||
6. **Handoff:** Report changed files, gate verification results, and active
|
||||
issue states.
|
||||
|
||||
## Maintaining this file
|
||||
|
||||
Keep this file for knowledge useful to almost every future agent session in this project.
|
||||
Do not repeat what the codebase already shows; point to the authoritative file or command instead.
|
||||
Prefer rewriting or pruning existing entries over appending new ones.
|
||||
When updating this file, preserve this bar for all agents and keep entries concise.
|
||||
A rule is added only after a real failure it would have prevented, and it must
|
||||
say which decision it changes. Remove rules that no longer change decisions.
|
||||
Keep it short enough to read in full every session.
|
||||
+4
-16
@@ -3,10 +3,8 @@
|
||||
# Language packages are installed at runtime via uv/npm/go.
|
||||
#
|
||||
# Build: docker build -t archie-agent:latest .
|
||||
# This image is launched only by archied with a daemon-written task brief,
|
||||
# task worktree mount, and authenticated NATS environment.
|
||||
|
||||
# ── builder ───────────────────────────────────────────────────────────
|
||||
# ── builder ──
|
||||
FROM golang:1.27-trixie AS builder
|
||||
ARG RUNTIME_VERSION=dev
|
||||
WORKDIR /src
|
||||
@@ -17,17 +15,15 @@ RUN CGO_ENABLED=0 go build \
|
||||
-ldflags "-X github.com/samcharles93/archie-core/internal/app/agentworker.version=${RUNTIME_VERSION} -X github.com/samcharles93/archie-core/internal/installtype.buildType=container" \
|
||||
-o /usr/local/bin/archie-agent ./cmd/archie-agent/
|
||||
|
||||
# Same Debian release as the runtime, so glibc matches.
|
||||
FROM node:24-trixie-slim AS node
|
||||
|
||||
# ── runtime ───────────────────────────────────────────────────────────
|
||||
# ── runtime ──
|
||||
FROM debian:trixie-slim
|
||||
ARG RUNTIME_VERSION=dev
|
||||
LABEL org.opencontainers.image.version="${RUNTIME_VERSION}"
|
||||
|
||||
ENV DEBIAN_FRONTEND=noninteractive
|
||||
|
||||
# build-essential is for agents building native npm/Python extensions.
|
||||
RUN apt-get update && apt-get install -y --no-install-recommends \
|
||||
ca-certificates \
|
||||
curl \
|
||||
@@ -41,7 +37,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
|
||||
openssh-client \
|
||||
&& rm -rf /var/lib/apt/lists/*
|
||||
|
||||
# ── Node.js 24 ────────────────────────────────────────────────────────
|
||||
# ── Node.js 24 ──
|
||||
COPY --from=node /usr/local/bin/node /usr/local/bin/node
|
||||
COPY --from=node /usr/local/include/node /usr/local/include/node
|
||||
COPY --from=node /usr/local/lib/node_modules /usr/local/lib/node_modules
|
||||
@@ -50,7 +46,7 @@ RUN ln -s ../lib/node_modules/npm/bin/npm-cli.js /usr/local/bin/npm && \
|
||||
npm install -g pnpm typescript tsx esbuild stylelint htmlhint && \
|
||||
npm cache clean --force
|
||||
|
||||
# ── Go ────────────────────────────────────────────────────────────────
|
||||
# ── Go ──
|
||||
# Reuse the builder's toolchain so the runtime Go can't drift from the one
|
||||
# archie-agent was compiled with.
|
||||
COPY --from=builder /usr/local/go /usr/local/go
|
||||
@@ -58,12 +54,6 @@ ENV GOPATH="/go"
|
||||
# /go/bin must be on PATH or anything `go install` puts there is unreachable.
|
||||
ENV PATH="/usr/local/go/bin:/go/bin:${PATH}"
|
||||
|
||||
# Pinned release binaries. Building these with `go install` pulled ~2GB of
|
||||
# module and build cache into the image. delve is omitted because it ships no
|
||||
# prebuilt binary; `go install ...@latest` at runtime if an agent needs it.
|
||||
#
|
||||
# golangci-lint owns ordinary source formatting and lint checks. Standalone
|
||||
# gofumpt is retained for generated protobuf contracts in tools/proto.sh.
|
||||
ARG GOLANGCI_LINT_VERSION=2.13.2
|
||||
ARG GOFUMPT_VERSION=0.11.0
|
||||
ARG BUF_VERSION=1.72.0
|
||||
@@ -78,8 +68,6 @@ RUN curl -fsSL "https://github.com/golangci/golangci-lint/releases/download/v${G
|
||||
chmod +x /usr/local/bin/gofumpt /usr/local/bin/buf
|
||||
|
||||
# ── Python via uv ─────────────────────────────────────────────────────
|
||||
# uv manages its own interpreters — no apt Python, no deadsnakes PPA. One
|
||||
# version is the default; agents can `uv python install <other>` on demand.
|
||||
ARG PYTHON_VERSION=3.14
|
||||
RUN curl -fsSL https://astral.sh/uv/install.sh | sh
|
||||
ENV PATH="/root/.local/bin:${PATH}"
|
||||
|
||||
+6
-17
@@ -1,4 +1,4 @@
|
||||
# archied — the archie daemon, built as a standalone container.
|
||||
# archied — the archie daemon
|
||||
# Run via docker compose alongside NATS.
|
||||
|
||||
FROM golang:1.27-trixie AS builder
|
||||
@@ -9,21 +9,9 @@ COPY . .
|
||||
ARG GATEWAY_VERSION=dev
|
||||
ARG RUNTIME_VERSION=dev
|
||||
RUN CGO_ENABLED=0 go build \
|
||||
-ldflags "-X github.com/samcharles93/archie-core/internal/app/archied.gatewayVersion=${GATEWAY_VERSION} -X github.com/samcharles93/archie-core/internal/app/archied.runtimeVersion=${RUNTIME_VERSION} -X github.com/samcharles93/archie-core/internal/installtype.buildType=container" \
|
||||
-ldflags "-X github.com/samcharles93/archie-core/internal/buildinfo.Version=${GATEWAY_VERSION} -X github.com/samcharles93/archie-core/internal/buildinfo.Runtime=${RUNTIME_VERSION} -X github.com/samcharles93/archie-core/internal/installtype.buildType=container" \
|
||||
-o /usr/local/bin/archied ./cmd/archied/
|
||||
# archied is static, but this can't be scratch: in inprocess mode the daemon
|
||||
# runs agent tools itself, and the shell tool invokes bash; codesearch shells
|
||||
# to git. Worktrees don't count — internal/worktree uses go-git. This image
|
||||
# is not part of the current deployment (docker-compose.yml only builds
|
||||
# Dockerfile, the agent image; archied runs on the host under systemd), but
|
||||
# if it's ever used in inprocess mode, grep needs ripgrep on PATH -- it is
|
||||
# no longer embedded in the binary.
|
||||
#
|
||||
# No Node: the builtin tools (read/write/edit/find/grep/shell/test) cover what
|
||||
# desktop-commander did. Any npx-launched MCP stdio server will now fail to
|
||||
# start, and a failed provider rolls back the tool-provider family and exits
|
||||
# the daemon — so remove tools.mcp_servers entries needing npx before
|
||||
# deploying this image.
|
||||
|
||||
FROM debian:trixie-slim
|
||||
RUN apt-get update && apt-get install -y --no-install-recommends \
|
||||
ca-certificates git && \
|
||||
@@ -33,6 +21,7 @@ ARG GATEWAY_VERSION=dev
|
||||
ARG RUNTIME_VERSION=dev
|
||||
LABEL org.opencontainers.image.version="${GATEWAY_VERSION}"
|
||||
LABEL cloud.catlow.archie.runtime-version="${RUNTIME_VERSION}"
|
||||
COPY CHANGELOG.archied.md /usr/share/archie/CHANGELOG.archied.md
|
||||
COPY CHANGELOG.archie.md /usr/share/archie/CHANGELOG.archie.md
|
||||
|
||||
COPY CHANGELOG.md /usr/share/archie/CHANGELOG.md
|
||||
|
||||
ENTRYPOINT ["archied"]
|
||||
@@ -0,0 +1,202 @@
|
||||
|
||||
Apache License
|
||||
Version 2.0, January 2004
|
||||
http://www.apache.org/licenses/
|
||||
|
||||
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
|
||||
|
||||
1. Definitions.
|
||||
|
||||
"License" shall mean the terms and conditions for use, reproduction,
|
||||
and distribution as defined by Sections 1 through 9 of this document.
|
||||
|
||||
"Licensor" shall mean the copyright owner or entity authorized by
|
||||
the copyright owner that is granting the License.
|
||||
|
||||
"Legal Entity" shall mean the union of the acting entity and all
|
||||
other entities that control, are controlled by, or are under common
|
||||
control with that entity. For the purposes of this definition,
|
||||
"control" means (i) the power, direct or indirect, to cause the
|
||||
direction or management of such entity, whether by contract or
|
||||
otherwise, or (ii) ownership of fifty percent (50%) or more of the
|
||||
outstanding shares, or (iii) beneficial ownership of such entity.
|
||||
|
||||
"You" (or "Your") shall mean an individual or Legal Entity
|
||||
exercising permissions granted by this License.
|
||||
|
||||
"Source" form shall mean the preferred form for making modifications,
|
||||
including but not limited to software source code, documentation
|
||||
source, and configuration files.
|
||||
|
||||
"Object" form shall mean any form resulting from mechanical
|
||||
transformation or translation of a Source form, including but
|
||||
not limited to compiled object code, generated documentation,
|
||||
and conversions to other media types.
|
||||
|
||||
"Work" shall mean the work of authorship, whether in Source or
|
||||
Object form, made available under the License, as indicated by a
|
||||
copyright notice that is included in or attached to the work
|
||||
(an example is provided in the Appendix below).
|
||||
|
||||
"Derivative Works" shall mean any work, whether in Source or Object
|
||||
form, that is based on (or derived from) the Work and for which the
|
||||
editorial revisions, annotations, elaborations, or other modifications
|
||||
represent, as a whole, an original work of authorship. For the purposes
|
||||
of this License, Derivative Works shall not include works that remain
|
||||
separable from, or merely link (or bind by name) to the interfaces of,
|
||||
the Work and Derivative Works thereof.
|
||||
|
||||
"Contribution" shall mean any work of authorship, including
|
||||
the original version of the Work and any modifications or additions
|
||||
to that Work or Derivative Works thereof, that is intentionally
|
||||
submitted to Licensor for inclusion in the Work by the copyright owner
|
||||
or by an individual or Legal Entity authorized to submit on behalf of
|
||||
the copyright owner. For the purposes of this definition, "submitted"
|
||||
means any form of electronic, verbal, or written communication sent
|
||||
to the Licensor or its representatives, including but not limited to
|
||||
communication on electronic mailing lists, source code control systems,
|
||||
and issue tracking systems that are managed by, or on behalf of, the
|
||||
Licensor for the purpose of discussing and improving the Work, but
|
||||
excluding communication that is conspicuously marked or otherwise
|
||||
designated in writing by the copyright owner as "Not a Contribution."
|
||||
|
||||
"Contributor" shall mean Licensor and any individual or Legal Entity
|
||||
on behalf of whom a Contribution has been received by Licensor and
|
||||
subsequently incorporated within the Work.
|
||||
|
||||
2. Grant of Copyright License. Subject to the terms and conditions of
|
||||
this License, each Contributor hereby grants to You a perpetual,
|
||||
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
|
||||
copyright license to reproduce, prepare Derivative Works of,
|
||||
publicly display, publicly perform, sublicense, and distribute the
|
||||
Work and such Derivative Works in Source or Object form.
|
||||
|
||||
3. Grant of Patent License. Subject to the terms and conditions of
|
||||
this License, each Contributor hereby grants to You a perpetual,
|
||||
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
|
||||
(except as stated in this section) patent license to make, have made,
|
||||
use, offer to sell, sell, import, and otherwise transfer the Work,
|
||||
where such license applies only to those patent claims licensable
|
||||
by such Contributor that are necessarily infringed by their
|
||||
Contribution(s) alone or by combination of their Contribution(s)
|
||||
with the Work to which such Contribution(s) was submitted. If You
|
||||
institute patent litigation against any entity (including a
|
||||
cross-claim or counterclaim in a lawsuit) alleging that the Work
|
||||
or a Contribution incorporated within the Work constitutes direct
|
||||
or contributory patent infringement, then any patent licenses
|
||||
granted to You under this License for that Work shall terminate
|
||||
as of the date such litigation is filed.
|
||||
|
||||
4. Redistribution. You may reproduce and distribute copies of the
|
||||
Work or Derivative Works thereof in any medium, with or without
|
||||
modifications, and in Source or Object form, provided that You
|
||||
meet the following conditions:
|
||||
|
||||
(a) You must give any other recipients of the Work or
|
||||
Derivative Works a copy of this License; and
|
||||
|
||||
(b) You must cause any modified files to carry prominent notices
|
||||
stating that You changed the files; and
|
||||
|
||||
(c) You must retain, in the Source form of any Derivative Works
|
||||
that You distribute, all copyright, patent, trademark, and
|
||||
attribution notices from the Source form of the Work,
|
||||
excluding those notices that do not pertain to any part of
|
||||
the Derivative Works; and
|
||||
|
||||
(d) If the Work includes a "NOTICE" text file as part of its
|
||||
distribution, then any Derivative Works that You distribute must
|
||||
include a readable copy of the attribution notices contained
|
||||
within such NOTICE file, excluding those notices that do not
|
||||
pertain to any part of the Derivative Works, in at least one
|
||||
of the following places: within a NOTICE text file distributed
|
||||
as part of the Derivative Works; within the Source form or
|
||||
documentation, if provided along with the Derivative Works; or,
|
||||
within a display generated by the Derivative Works, if and
|
||||
wherever such third-party notices normally appear. The contents
|
||||
of the NOTICE file are for informational purposes only and
|
||||
do not modify the License. You may add Your own attribution
|
||||
notices within Derivative Works that You distribute, alongside
|
||||
or as an addendum to the NOTICE text from the Work, provided
|
||||
that such additional attribution notices cannot be construed
|
||||
as modifying the License.
|
||||
|
||||
You may add Your own copyright statement to Your modifications and
|
||||
may provide additional or different license terms and conditions
|
||||
for use, reproduction, or distribution of Your modifications, or
|
||||
for any such Derivative Works as a whole, provided Your use,
|
||||
reproduction, and distribution of the Work otherwise complies with
|
||||
the conditions stated in this License.
|
||||
|
||||
5. Submission of Contributions. Unless You explicitly state otherwise,
|
||||
any Contribution intentionally submitted for inclusion in the Work
|
||||
by You to the Licensor shall be under the terms and conditions of
|
||||
this License, without any additional terms or conditions.
|
||||
Notwithstanding the above, nothing herein shall supersede or modify
|
||||
the terms of any separate license agreement you may have executed
|
||||
with Licensor regarding such Contributions.
|
||||
|
||||
6. Trademarks. This License does not grant permission to use the trade
|
||||
names, trademarks, service marks, or product names of the Licensor,
|
||||
except as required for reasonable and customary use in describing the
|
||||
origin of the Work and reproducing the content of the NOTICE file.
|
||||
|
||||
7. Disclaimer of Warranty. Unless required by applicable law or
|
||||
agreed to in writing, Licensor provides the Work (and each
|
||||
Contributor provides its Contributions) on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
||||
implied, including, without limitation, any warranties or conditions
|
||||
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
|
||||
PARTICULAR PURPOSE. You are solely responsible for determining the
|
||||
appropriateness of using or redistributing the Work and assume any
|
||||
risks associated with Your exercise of permissions under this License.
|
||||
|
||||
8. Limitation of Liability. In no event and under no legal theory,
|
||||
whether in tort (including negligence), contract, or otherwise,
|
||||
unless required by applicable law (such as deliberate and grossly
|
||||
negligent acts) or agreed to in writing, shall any Contributor be
|
||||
liable to You for damages, including any direct, indirect, special,
|
||||
incidental, or consequential damages of any character arising as a
|
||||
result of this License or out of the use or inability to use the
|
||||
Work (including but not limited to damages for loss of goodwill,
|
||||
work stoppage, computer failure or malfunction, or any and all
|
||||
other commercial damages or losses), even if such Contributor
|
||||
has been advised of the possibility of such damages.
|
||||
|
||||
9. Accepting Warranty or Additional Liability. While redistributing
|
||||
the Work or Derivative Works thereof, You may choose to offer,
|
||||
and charge a fee for, acceptance of support, warranty, indemnity,
|
||||
or other liability obligations and/or rights consistent with this
|
||||
License. However, in accepting such obligations, You may act only
|
||||
on Your own behalf and on Your sole responsibility, not on behalf
|
||||
of any other Contributor, and only if You agree to indemnify,
|
||||
defend, and hold each Contributor harmless for any liability
|
||||
incurred by, or claims asserted against, such Contributor by reason
|
||||
of your accepting any such warranty or additional liability.
|
||||
|
||||
END OF TERMS AND CONDITIONS
|
||||
|
||||
APPENDIX: How to apply the Apache License to your work.
|
||||
|
||||
To apply the Apache License to your work, attach the following
|
||||
boilerplate notice, with the fields enclosed by brackets "[]"
|
||||
replaced with your own identifying information. (Don't include
|
||||
the brackets!) The text should be enclosed in the appropriate
|
||||
comment syntax for the file format. We also recommend that a
|
||||
file or class name and description of purpose be included on the
|
||||
same "printed page" as the copyright notice for easier
|
||||
identification within third-party archives.
|
||||
|
||||
Copyright [yyyy] [name of copyright owner]
|
||||
|
||||
Licensed under the Apache License, Version 2.0 (the "License");
|
||||
you may not use this file except in compliance with the License.
|
||||
You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
@@ -0,0 +1,19 @@
|
||||
NOTICE
|
||||
|
||||
This product includes software derived from PR-AF
|
||||
(https://github.com/Agent-Field/pr-af), Copyright AgentField,
|
||||
licensed under the Apache License, Version 2.0.
|
||||
|
||||
Derived portions: internal/domain/workflow/prreview -- the unified diff
|
||||
parser, change clustering, blast radius, evidence extraction, scoring,
|
||||
deduplication, line mapping and review-event selection.
|
||||
|
||||
PR-AF declares the Apache License, Version 2.0 in its pyproject.toml and
|
||||
ships no license file. A copy of the License is available at
|
||||
https://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
This product includes software from the Cedar project
|
||||
(https://github.com/cedar-policy/cedar), Copyright Amazon.com, Inc. or its
|
||||
affiliates, licensed under the Apache License, Version 2.0, as implemented by
|
||||
github.com/cedar-policy/cedar-go, which declares the same license in its
|
||||
repository. This repository links the library; it derives no source from it.
|
||||
@@ -0,0 +1,160 @@
|
||||
[](https://github.com/samcharles93/archie-core/actions/workflows/quality.yml)
|
||||
|
||||
# Archie
|
||||
|
||||
**Event-driven Agentic Automation**
|
||||
|
||||
Archie connects events from your systems to agents that can investigate, reason,
|
||||
and act. Define what an event means, map its data into a workflow, and give that
|
||||
workflow an agent equipped for the job: its own execution environment, tools,
|
||||
and identity.
|
||||
|
||||
The aim is to automate work across system administration, incident response,
|
||||
network operations, service management, and software delivery. You define the
|
||||
process and the access it requires; agents work through its stages, using the
|
||||
context of each event to decide how to accomplish the task.
|
||||
|
||||
Archie is under active development and not every capability below is
|
||||
finished.
|
||||
|
||||
## From an event to an outcome
|
||||
|
||||
```text
|
||||
Event source → Event type → Mapping → Binding → Workflow → Agent
|
||||
```
|
||||
|
||||
| Concept | Purpose |
|
||||
| -------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------ |
|
||||
| **Source** | Receive events from a system such as a firewall, monitoring stack, service desk, or forge. Configure its endpoint and signing requirements. |
|
||||
| **Event type** | Identify which kind of event arrived from its headers and payload. Infer a schema from captured events or a pasted example. |
|
||||
| **Mapping** | Extract named, typed parameters from the event. Reuse a mapping across bindings and see how often it matches. |
|
||||
| **Binding** | Select a workflow, filter the events that should trigger it, and supply its inputs from mapped values or constants. |
|
||||
| **Workflow** | Define the stages of work, their inputs and outputs, and the agent profile to use. Call other workflows when work needs another specialist or process. |
|
||||
| **Agent** | Execute the work in a container with the tools for its purpose, acting under its own identity and granted permissions. |
|
||||
|
||||
A single source can produce several event types. An event type can feed several
|
||||
bindings, and each binding can apply its own conditions. This lets the same
|
||||
incoming data drive different responses without building a custom integration
|
||||
for every workflow.
|
||||
|
||||
For example, a firewall sends a blocked-connection event. Archie identifies the
|
||||
event type and maps the source address and severity into an investigation
|
||||
workflow. A network investigator gathers evidence, assesses the activity, and
|
||||
returns its findings. The workflow could then call a separate containment
|
||||
workflow, subject to the permissions and approvals configured for that action.
|
||||
|
||||
The same model supports other processes:
|
||||
|
||||
- **Infrastructure operations:** A monitoring alert starts a diagnostic workflow
|
||||
to inspect a service, collect evidence, and propose or perform an authorised
|
||||
recovery action.
|
||||
- **Service management:** An incoming request supplies the parameters for a
|
||||
triage, investigation, or fulfilment workflow.
|
||||
- **Software delivery:** A forge event starts a review or implementation
|
||||
workflow with the repository's toolchain, validation steps, and pull request
|
||||
as its output.
|
||||
|
||||
These are examples of workflows you can build. Their behaviour comes from the
|
||||
workflow, tools, and access you configure.
|
||||
|
||||
## Agents equipped for their work
|
||||
|
||||
An agent profile selects the container image and available tools. You can supply
|
||||
images with the software needed for a particular environment: network utilities
|
||||
for an investigator, operational tooling for a systems agent, or a language
|
||||
runtime and test framework for repository work.
|
||||
|
||||
Workflows declare structured inputs and can return structured outputs. They can
|
||||
run with a scratch workspace, require a repository, or accept one optionally. An
|
||||
investigation can finish with a report; a maintenance workflow can finish with
|
||||
an operational result; a coding workflow can finish with a pull request.
|
||||
|
||||
Workflows can also call other workflows and pass data between them. Each called
|
||||
workflow has its own run and agent profile. A caller can wait for the result or
|
||||
continue while the called workflow runs independently.
|
||||
|
||||
The archipelago marketplace's `workflows/firewall` package is an example of a
|
||||
workflow that uses typed inputs, a network investigator profile, and no
|
||||
repository.
|
||||
|
||||
## Identities and controlled execution
|
||||
|
||||
Agents act as their own identities, with secrets and permissions granted to
|
||||
that identity. Runs receive credentials scoped to their task; event data
|
||||
supplies inputs and cannot grant access. Organisations, workspaces and
|
||||
policy-based access control are in progress.
|
||||
|
||||
## Building and operating automations
|
||||
|
||||
The dashboard brings together event inspection, mappings, bindings, workflows,
|
||||
and task activity. The intended authoring path starts with a real payload or an
|
||||
example: identify its structure, map the fields you need, select a workflow, and
|
||||
approve the binding.
|
||||
|
||||
Sources default to signed delivery; an unsigned source must be explicitly
|
||||
approved. Binding changes require re-approval before they can dispatch work.
|
||||
|
||||
## Run it on a server
|
||||
|
||||
You need x86_64 Linux with curl and unzip, Docker (agents and the bundled
|
||||
PostgreSQL run in containers) and a model: local [Ollama](https://ollama.com)
|
||||
or a hosted provider API key.
|
||||
|
||||
1. **Install.**
|
||||
|
||||
```bash
|
||||
curl -fsSL https://raw.githubusercontent.com/samcharles93/archie-core/main/install.sh | bash
|
||||
```
|
||||
|
||||
It downloads the latest release, verifies its checksum, installs the five
|
||||
services into `~/.local/bin` and runs `archied setup`. Setup asks for the
|
||||
PostgreSQL URL (leave it blank for a bundled database with a generated
|
||||
password), a model provider and key, and a forge (choose **none** for
|
||||
event-driven automation only). Answers go to `~/.config/archie/config.toml`
|
||||
and secrets to `~/.config/archie/env`. The installer then starts the
|
||||
bundled PostgreSQL with Docker Compose and installs and starts systemd user
|
||||
units. Pass options with `| bash -s -- --help`; `--from-source` builds a
|
||||
checkout instead. Re-run `archied setup` at any time to change the answers.
|
||||
|
||||
Extensions run in an unprivileged user namespace. Ubuntu 23.10 and later
|
||||
block these by default; on such a host the installer prints an AppArmor
|
||||
profile that allows them for the Archie binaries only, to install with
|
||||
`sudo`.
|
||||
|
||||
2. **Check it is up.**
|
||||
|
||||
```bash
|
||||
systemctl --user status archied archie-state-store archie-gateway archie-ui archie-messaging
|
||||
curl -s http://127.0.0.1:8485/health/detailed
|
||||
```
|
||||
|
||||
3. **Open the dashboard** at <http://127.0.0.1:8484>. It binds loopback by
|
||||
default; tunnel to it (`ssh -L 8484:127.0.0.1:8484 server`) or see
|
||||
[deployments](deployments/README.md#running-the-dashboard) to expose it
|
||||
with a token.
|
||||
|
||||
4. **Automate your first event** with
|
||||
[Your first playbook](docs/guides/first-playbook.md): send a webhook, map
|
||||
its fields, bind it to a workflow and watch the task run.
|
||||
|
||||
To write the config by hand instead, start from
|
||||
[`deployments/standalone.toml`](deployments/standalone.toml) (no forge) or
|
||||
another [deployment template](deployments/README.md).
|
||||
|
||||
## Develop
|
||||
|
||||
`task dev` starts every service with Vite hot reload at
|
||||
<http://localhost:5173>, using [`deployments/dev.toml`](deployments/dev.toml).
|
||||
`task check` is the quality gate; [AGENTS.md](AGENTS.md) lists its tools.
|
||||
|
||||
## Documentation
|
||||
|
||||
- [Your first playbook](docs/guides/first-playbook.md)
|
||||
- [Deployment examples](deployments/README.md)
|
||||
- [Release process](RELEASING.md)
|
||||
|
||||
Contributions follow [AGENTS.md](AGENTS.md).
|
||||
|
||||
## License
|
||||
|
||||
Copyright 2026 Sam Catlow. Licensed under the [Apache License, Version 2.0](LICENSE). Third-party attributions are in [NOTICE](NOTICE).
|
||||
+87
-58
@@ -1,52 +1,52 @@
|
||||
# Releasing
|
||||
|
||||
One release stream. `CHANGELOG.md` carries every release section, one generated page
|
||||
per version describes it, and one tag names the release. A release is one version
|
||||
covering whatever changed; the components' entries are labelled sections inside it
|
||||
(`### archied`, `### archie-agent`), not separate numbers or separate pages.
|
||||
One release stream. `CHANGELOG.md` carries every release section, one generated
|
||||
page per version describes it, and one tag names the release. A release is one
|
||||
version covering whatever changed; the components' entries are labelled sections
|
||||
inside it (`### archied`, `### archie-agent`), not separate numbers or separate
|
||||
pages.
|
||||
|
||||
The host bundle ships six processes — `archied`, `archie-gateway`,
|
||||
`archie-state-store`, `archie-ui`, `archie-messaging`, `archie-playbooks` — and one
|
||||
version covers all of them. `archie-agent`, the per-task sandboxed runtime, ships as a
|
||||
container image and its changes are the `## [version]` release's `### archie-agent`
|
||||
section.
|
||||
The host bundle ships five processes (`archied`, `archie-gateway`,
|
||||
`archie-state-store`, `archie-ui`, `archie-messaging`), and
|
||||
one version covers all of them. `archie-agent`, the per-task sandboxed runtime,
|
||||
ships as a container image and its changes are the `## [version]` release's
|
||||
`### archie-agent` section.
|
||||
|
||||
`tools/release.sh` decides which commits a release carries from the package closure of
|
||||
**every shipped binary**, not from commit-message guessing: a change to a package only
|
||||
the messaging service, state store, playbook runner or UI links still lands in the
|
||||
changelog. Read its header comment for how it partitions commits and enforces
|
||||
`main`-only, clean-tree releases.
|
||||
`tools/release.sh` decides which commits a release carries from the package
|
||||
closure of **every shipped binary**, not from commit-message guessing: a change
|
||||
to a package only the messaging service, state store, playbook runner or UI
|
||||
links still lands in the changelog. Read its header comment for how it
|
||||
partitions commits and enforces `main`-only, clean-tree releases.
|
||||
|
||||
## What justifies a version
|
||||
|
||||
`task release:preview VERSION=X.Y.Z` shows exactly what would land, before anything is
|
||||
written. A commit set that justifies no version produces no version: `release.sh`
|
||||
exits **3** with "nothing to release" rather than inventing one, so a pipeline can
|
||||
finish green without tagging.
|
||||
`task release:preview VERSION=X.Y.Z` shows exactly what would land, before
|
||||
anything is written. A commit set that justifies no version produces no version:
|
||||
`release.sh` exits **3** with "nothing to release" rather than inventing one, so
|
||||
a pipeline can finish green without tagging.
|
||||
|
||||
Most sessions touch the gateway side (daemon, gateway, web UI, chat, messaging) and
|
||||
leave the agent runtime alone. That is no longer a per-component `skip` decision — one
|
||||
version covers the release — but a runtime code change being merged to `main` is still
|
||||
not the same as it being in production: the `archie-agent` image is rebuilt by the
|
||||
release, and a host that runs the agent must pull the new image
|
||||
(`docker compose pull agent`) to get it.
|
||||
Most sessions touch the gateway side (daemon, gateway, web UI, chat, messaging)
|
||||
and leave the agent runtime alone. That is no longer a per-component `skip`
|
||||
decision — one version covers the release — but a runtime code change being
|
||||
merged to `main` is still not the same as it being in production: the
|
||||
`archie-agent` image is rebuilt by the release, and a host that runs the agent
|
||||
must pull the new image (`docker compose pull agent`) to get it.
|
||||
|
||||
## What the notes are for
|
||||
|
||||
**Release notes describe the reader's experience of what shipped.** The test is
|
||||
the reader, not whether a sentence is negative:
|
||||
|
||||
- A capability that **never existed** leaves no expectation to correct, so a note
|
||||
about it reads as a feature to someone who never had the thing — out.
|
||||
- A capability that **never existed** leaves no expectation to correct, so a
|
||||
note about it reads as a feature to someone who never had the thing — out.
|
||||
- **The implementation's journey** — what was rebuilt, what a guard finally
|
||||
covers, what a browser API refuses to surface — is not the reader's experience
|
||||
either — out.
|
||||
- A capability that **shipped but is not yet wired** *is* the reader's
|
||||
experience, so it belongs, worded as a caveat on the capability and paired with
|
||||
the behaviour that compensates for it.
|
||||
- A capability that **shipped but is not yet wired** _is_ the reader's
|
||||
experience, so it belongs, worded as a caveat on the capability and paired
|
||||
with the behaviour that compensates for it.
|
||||
|
||||
Design constraints and withheld capabilities belong in `docs/architecture/`,
|
||||
where implementers look, because there they are requirements rather than news.
|
||||
Design constraints and withheld capabilities are not release news.
|
||||
Do not apply this mechanically: deleting a caveat a reader needs misleads them,
|
||||
which is the failure this rule exists to prevent.
|
||||
|
||||
@@ -57,44 +57,73 @@ task release:preview VERSION=1.3.0 # preview what would land
|
||||
task release:prepare VERSION=1.3.0 # write the section into CHANGELOG.md, uncommitted
|
||||
# edit CHANGELOG.md -- generated notes are a starting point, not the release
|
||||
task release VERSION=1.3.0 # commit + annotated tag
|
||||
git push origin main --follow-tags # CI stamps images with real versions
|
||||
git push --atomic origin main v1.3.0 # both refs or neither
|
||||
```
|
||||
|
||||
`release:prepare` emits bare commit subjects; they are a starting point. Rewrite them
|
||||
to say what a reader gets, per "What the notes are for" above.
|
||||
`release:prepare` emits bare commit subjects; they are a starting point. Rewrite
|
||||
them to say what a reader gets, per "What the notes are for" above.
|
||||
|
||||
Pushing is a separate, explicit step — never push without confirming first (see the
|
||||
repo's general "check before doing anything hard to reverse" rule). The deploy
|
||||
workflow reads tags pointing at `HEAD`; pushing the commit without its tag gets images
|
||||
stamped `dev`.
|
||||
Pushing is a separate, explicit step — never push without confirming first (see
|
||||
the repo's general "check before doing anything hard to reverse" rule). The
|
||||
deploy workflow reads tags pointing at `HEAD`; pushing the commit without its
|
||||
tag gets images stamped `dev`, which is why the push names the tag and is
|
||||
`--atomic`.
|
||||
|
||||
### After a release, `main` and the working branch have diverged
|
||||
|
||||
The release commit lands on `main` — `tools/release.sh` refuses to run anywhere
|
||||
else — while the working branch keeps advancing. So after every release, `main`
|
||||
is ahead by exactly that commit and the branch is ahead by however far it has
|
||||
moved: **neither tip is an ancestor of the other**, and `--ff-only` fails in
|
||||
both directions. That refusal reads as "the tree is not ready" when in fact the
|
||||
tree is fine.
|
||||
|
||||
Merge the release commit into the branch first, so any conflict is resolved on
|
||||
the branch, where it is reversible and nobody is reading the tip:
|
||||
|
||||
```bash
|
||||
git merge main # on the branch
|
||||
git merge --ff-only <branch> # then, in whichever worktree holds main
|
||||
```
|
||||
|
||||
Confirm which worktree holds `main` with `git worktree list` before the
|
||||
`--ff-only`. A detached worktree sitting at the same commit will accept it and
|
||||
move nothing, which looks like success.
|
||||
|
||||
## What a release publishes
|
||||
|
||||
Tagging one version produces, from a single `deploy` run:
|
||||
|
||||
- **Container images** — `ghcr.io/samcharles93/archied:latest` and
|
||||
`ghcr.io/samcharles93/archie-agent:latest`. The runtime image is rebuilt by the
|
||||
release, so runtime commits merged to `main` do not reach a running sandbox until the
|
||||
host pulls the new image.
|
||||
- **A GitHub Release with a distribution zip** — `dist-zip` builds every process the
|
||||
reference deployment runs (`archied`, `archie-gateway`, `archie-state-store`,
|
||||
`archie-ui`, `archie-messaging`, `archie-playbooks`) for linux/amd64, packs them with
|
||||
`deployments/INSTRUCTIONS.md` and `CHANGELOG.md`, and attaches the zip to the
|
||||
Release. The Release body is that version's `## [version]` section of `CHANGELOG.md`.
|
||||
`ghcr.io/samcharles93/archie-agent:latest`. The runtime image is rebuilt by
|
||||
the release, so runtime commits merged to `main` do not reach a running
|
||||
sandbox until the host pulls the new image.
|
||||
- **`:latest` names the newest release, not the newest commit.** A push to
|
||||
`main` that is not a release publishes `archied:edge` (mutable, tracking
|
||||
`main`) and `archied:sha-<commit>` (immutable) instead, so a release's
|
||||
`:latest` stamping is not overwritten minutes later by the next ordinary
|
||||
commit. A host that runs releases follows `:latest`; a host that tracks `main`
|
||||
follows `:edge`.
|
||||
- **A GitHub Release with a distribution zip** — `dist-zip` builds every process
|
||||
the reference deployment runs (`archied`, `archie-gateway`,
|
||||
`archie-state-store`, `archie-ui`, `archie-messaging`) for
|
||||
linux/amd64, packs them with `deployments/INSTRUCTIONS.md` and `CHANGELOG.md`,
|
||||
and attaches the zip to the Release. The Release body is that version's
|
||||
`## [version]` section of `CHANGELOG.md`.
|
||||
|
||||
The zip is also uploaded as an Actions artifact, but that is a backup copy: artifacts
|
||||
expire after 90 days and need an Actions login to download. The Release asset is the
|
||||
durable, operator-reachable one.
|
||||
The zip is also uploaded as an Actions artifact, but that is a backup copy:
|
||||
artifacts expire after 90 days and need an Actions login to download. The
|
||||
Release asset is the durable, operator-reachable one.
|
||||
|
||||
## Gate
|
||||
|
||||
CI (`deploy.yml`) runs `task check` before building images, then verifies any release
|
||||
tag at `HEAD` has a matching `[version]` section in `CHANGELOG.md`. A tag with no
|
||||
changelog entry is a hard failure. No tags at `HEAD` is a warning, not a failure —
|
||||
images get stamped `dev`.
|
||||
CI (`deploy.yml`) runs `task check` before building images, then verifies any
|
||||
release tag at `HEAD` has a matching `[version]` section in `CHANGELOG.md`. A
|
||||
tag with no changelog entry is a hard failure. No tags at `HEAD` is a warning,
|
||||
not a failure — images get stamped `dev`.
|
||||
|
||||
One consequence worth knowing when a release commit needs amending: GitHub Actions
|
||||
runs the workflow **from the commit that triggered it**, so a fix to `deploy.yml` only
|
||||
takes effect for a release if it is an ancestor of the tagged commit. Delete and re-cut
|
||||
the tag (`git tag -d`, `task release`) rather than committing the fix on top of an
|
||||
already-tagged release.
|
||||
One consequence worth knowing when a release commit needs amending: GitHub
|
||||
Actions runs the workflow **from the commit that triggered it**, so a fix to
|
||||
`deploy.yml` only takes effect for a release if it is an ancestor of the tagged
|
||||
commit. Delete and re-cut the tag (`git tag -d`, `task release`) rather than
|
||||
committing the fix on top of an already-tagged release.
|
||||
+91
-339
@@ -53,125 +53,32 @@ tasks:
|
||||
cmds:
|
||||
- bash tools/proto.sh lint
|
||||
|
||||
db:generate:
|
||||
desc: "Regenerate the sqlc query code from the schema and query files"
|
||||
cmds:
|
||||
- go -C tools tool sqlc generate -f {{.ROOT_DIR}}/internal/infrastructure/postgres/sqlc.yaml
|
||||
|
||||
db:check:
|
||||
desc: "Regenerate the sqlc code and reject uncommitted generated differences"
|
||||
cmds:
|
||||
- task: db:generate
|
||||
- git diff --exit-code -- internal/infrastructure/postgres/postgresdb
|
||||
|
||||
proto:check:
|
||||
desc: Regenerate contracts and reject uncommitted generated differences
|
||||
cmds:
|
||||
- bash tools/proto.sh check
|
||||
|
||||
docs:generate:
|
||||
desc: Regenerate the committed contract reference from Archie-owned types
|
||||
summary: |
|
||||
Writes docs/data/generated/contracts.json. The output is committed, so
|
||||
this dirties the tree deliberately: review the diff and commit it with
|
||||
the code change that shifted the contract surface. Never hand-edit the
|
||||
artifact.
|
||||
|
||||
-mod=readonly is mandatory on every `go -C tools` command; see
|
||||
task test:tools for why.
|
||||
cmds:
|
||||
- go -C tools run -mod=readonly ./docsgen --repo-root ..
|
||||
|
||||
docs:check:
|
||||
desc: Verify the committed contract reference matches Archie-owned types
|
||||
summary: |
|
||||
Implements Step 6 of docs/architecture/generated-documentation.md:
|
||||
generates into a temporary directory, compares it with the committed
|
||||
output, names the authoritative Go definition behind each mismatch, and
|
||||
exits non-zero without modifying the working tree.
|
||||
|
||||
Fix a failure with `task docs:generate`, then commit the result in the
|
||||
same commit as the code change that shifted the contract surface. This
|
||||
checks rather than regenerates on purpose: a gate that silently rewrote
|
||||
the artifact would bless an unintended contract change with no reviewer
|
||||
ever seeing it, which Step 9 explicitly forbids.
|
||||
cmds:
|
||||
- go -C tools run -mod=readonly ./docsgen check --repo-root ..
|
||||
|
||||
docs:prds:
|
||||
desc: Reject session-bound writing in docs/prds
|
||||
summary: |
|
||||
A PRD states a decision, a requirement, a constraint or evidence. Those
|
||||
survive the code moving underneath them. A line number, a progress
|
||||
report or a dated status claim does not: it is true on the day it is
|
||||
written and silently wrong a month later, while still reading as
|
||||
authoritative. The tracker records progress; the PRD records the design.
|
||||
|
||||
Each finding names the file, the line, the rule and the fix. There is no
|
||||
--fix: the replacement is a judgement about what the sentence was for.
|
||||
cmds:
|
||||
- go -C tools run -mod=readonly ./prdlint --repo-root ..
|
||||
|
||||
news:
|
||||
desc: Regenerate the news page and per-version release notes from the changelog
|
||||
summary: |
|
||||
Writes docs/news/releases.json, docs/news/redirects.json and docs/news/.
|
||||
The JSON is the canonical, host-neutral fact set every renderer reads;
|
||||
the redirect table maps the retired /news/<component>/<version>/ URLs to
|
||||
the unified page for that version; the markdown is the MkDocs adapter.
|
||||
All of it comes from CHANGELOG.md, so cutting a release adds no writing
|
||||
here.
|
||||
|
||||
The files are committed, so this dirties the tree deliberately: review
|
||||
the diff and commit it with the changelog that produced it. Never
|
||||
hand-edit a generated release page.
|
||||
|
||||
tools/release.sh --tag runs this before the release commit, and it skips
|
||||
any file whose bytes already match, so a re-run leaves the tree clean.
|
||||
desc: Regenerate the release data artifacts from the changelog
|
||||
cmds:
|
||||
- go -C tools run -mod=readonly ./newsgen --repo-root ..
|
||||
|
||||
news:check:
|
||||
desc: Verify the committed release notes match the changelog
|
||||
summary: |
|
||||
Derives the release notes in memory and fails when the committed files
|
||||
differ, without modifying the working tree. Runs in `task check`, so a
|
||||
changelog edit cannot land without its regeneration.
|
||||
|
||||
A version page the generator does not produce (a page for a release the
|
||||
changelog no longer carries, or one left in the retired
|
||||
docs/news/<component>/ layout) is a finding too; a hand-written news item
|
||||
belongs at the docs/news root instead.
|
||||
cmds:
|
||||
- go -C tools run -mod=readonly ./newsgen check --repo-root ..
|
||||
|
||||
docs:artifact:
|
||||
desc: Regenerate the canonical docs artifacts from the Markdown sources
|
||||
summary: |
|
||||
Writes docs/data/generated/docs.json and dev-docs.json: every published
|
||||
page's url, title, section and raw Markdown body, plus the sidebar tree
|
||||
derived from the layout, one file per set. The JSON is the canonical,
|
||||
host-neutral fact set a renderer reads; the Markdown stays the source.
|
||||
MkDocs was the first renderer and the Astro app is the second, so the
|
||||
artifact is the product.
|
||||
|
||||
Two sets, split by audience: the public set (served under /docs/) is what a
|
||||
reader of the product needs, the development set (/dev/) is architecture/
|
||||
and prds/. The split and the reasons for what is held back entirely --
|
||||
archive/, inspiration/, news/ and the credential notes -- live in
|
||||
tools/docsite/main.go, because a renderer reading an artifact cannot see
|
||||
why a page is absent from it.
|
||||
|
||||
The files are committed, so this dirties the tree deliberately: review the
|
||||
diff and commit it with the page that produced it.
|
||||
|
||||
The artifact's keys are a frozen contract: an application is built against
|
||||
them, so renaming one breaks a consumer this repository does not compile.
|
||||
cmds:
|
||||
- go -C tools run -mod=readonly ./docsite --repo-root ..
|
||||
|
||||
docs:artifact:check:
|
||||
desc: Verify the committed docs artifacts match the Markdown sources
|
||||
summary: |
|
||||
Reproduces both artifacts in memory and fails when a committed file
|
||||
differs, without modifying the working tree. Runs in `task check`, so a
|
||||
page edit cannot land without its regeneration.
|
||||
|
||||
The generated directory is accounted for by docsgen's generatedArtifacts,
|
||||
which names both files alongside contracts.json: one registry for the
|
||||
directory rather than one per writer.
|
||||
cmds:
|
||||
- go -C tools run -mod=readonly ./docsite check --repo-root ..
|
||||
|
||||
vet:
|
||||
desc: Run go vet
|
||||
cmds:
|
||||
@@ -179,111 +86,36 @@ tasks:
|
||||
|
||||
lint:
|
||||
desc: Run golangci-lint
|
||||
summary: |
|
||||
Both modules. ./... from the root stops at the root module, so the tools
|
||||
module was never linted and drifted unseen -- the same hole task check
|
||||
already closes for tests with test:tools.
|
||||
cmds:
|
||||
- golangci-lint run ./...
|
||||
- task: lint:tools
|
||||
|
||||
lint:tools:
|
||||
desc: Run golangci-lint over the tools module
|
||||
summary: |
|
||||
./... from the root stops at the root module, so the tools module was
|
||||
never linted and drifted unseen -- the same hole task check already
|
||||
closes for tests with test:tools.
|
||||
dir: tools
|
||||
cmds:
|
||||
- golangci-lint run ./...
|
||||
|
||||
lint:playbooks:
|
||||
desc: "Lint playbook binding dirs for collisions (standalone tool, cmd/archie-playbooks)"
|
||||
summary: |
|
||||
Runs the standalone playbook linter (archie-playbooks lint) against
|
||||
./playbooks by default. It validates playbook YAML binding files
|
||||
against the same loaders the daemon uses at startup, so a pre-merge
|
||||
check can never disagree with runtime validation. Exit non-zero on
|
||||
any collision / malformed file / invalid binding.
|
||||
|
||||
Lint a different set of directories directly:
|
||||
go run ./cmd/archie-playbooks lint -dir ./a -dir ./b
|
||||
desc: Validate playbook bindings
|
||||
cmds:
|
||||
- go run ./cmd/archie-playbooks lint -dir ./playbooks
|
||||
- go run ./cmd/archied playbooks lint -dir ./playbooks
|
||||
|
||||
vuln:
|
||||
desc: "Scan for known stdlib/dependency CVEs (govulncheck). Not part of task check: it needs network access to the vuln DB and is not build/test-blocking; run it explicitly or in CI."
|
||||
desc: Scan for known vulnerabilities (requires network access)
|
||||
cmds:
|
||||
- govulncheck ./...
|
||||
|
||||
deadcode:
|
||||
desc: "Report functions no shipped binary can reach (whole-program RTA from ./cmd/...). Not part of task check: it reports a standing backlog, so gating on it would fail every run until that backlog is zero."
|
||||
summary: |
|
||||
Answers "is this reachable in production", which no linter does:
|
||||
golangci-lint's unused check is package-scoped, so anything exported
|
||||
and called from a sibling package looks live even when no binary
|
||||
reaches it.
|
||||
|
||||
Run via `go run ...@latest` deliberately. A locally installed deadcode
|
||||
built against an older Go than this module exits non-zero and prints
|
||||
NOTHING, which reads as "no dead code" instead of "analysis failed".
|
||||
Building it against the repo toolchain makes that failure impossible.
|
||||
|
||||
-test=false is the point of the report: a function reached only by its
|
||||
own tests is not reachable in production.
|
||||
|
||||
Read the output in one direction only. RTA over-approximates what is
|
||||
reachable, so "unreachable func" is sound and worth acting on, while
|
||||
silence proves nothing: interface dispatch and any address-taken
|
||||
function (every reflect.ValueOf entry in the *extract tables) is
|
||||
assumed reachable whether or not it is ever called.
|
||||
desc: Report unreachable production functions (advisory)
|
||||
cmds:
|
||||
- go run golang.org/x/tools/cmd/deadcode@latest -test=false ./cmd/...
|
||||
|
||||
reachaudit:
|
||||
desc: "Classify unreachable code as tracked / untracked / dynamic (tools/reachaudit). Wraps task deadcode with provenance and tracker status."
|
||||
summary: |
|
||||
deadcode says a function is unreachable. reachaudit says whether that
|
||||
is a known gap, a forgotten one, or an artifact of runtime loading
|
||||
(yaegi, reflection) that must never be deleted.
|
||||
|
||||
Two report sections, because a dead whole package and a dead symbol
|
||||
inside a live one are different failure modes: "unreachable-*" is a
|
||||
package no shipped binary imports at all; "in-package-*" is a symbol
|
||||
dead inside a package that IS shipped -- the ChatCourier/Dispatch
|
||||
shape, where the feature is wired everywhere except its own call site.
|
||||
Both carry the same tracked/untracked/dynamic classification.
|
||||
|
||||
--refresh re-runs the analysis. Without it the tool reuses
|
||||
/tmp/reachaudit-deadcode-<sha>.txt with no staleness check beyond HEAD
|
||||
and a dirty-tree check, which will happily report last week's tree
|
||||
against today's code if HEAD hasn't moved.
|
||||
|
||||
--json PATH and --md PATH write the same findings as structured data or
|
||||
a Markdown report, in addition to the terminal summary.
|
||||
cmds:
|
||||
- python3 tools/reachaudit/reachaudit.py --repo . {{.CLI_ARGS}}
|
||||
docs:site:
|
||||
desc: "Build the documentation site into ./site (MkDocs). --strict, so a dead internal link fails the build."
|
||||
summary: |
|
||||
Publishes docs/ minus the subtrees held back in mkdocs.yml's
|
||||
exclude_docs. Requires mkdocs-material:
|
||||
|
||||
pip install --user mkdocs-material
|
||||
|
||||
Distinct from docs:check, which verifies the generated contract data
|
||||
rather than the site.
|
||||
cmds:
|
||||
- mkdocs build --strict
|
||||
|
||||
docs:serve:
|
||||
desc: "Serve the documentation site locally with live reload on :8000."
|
||||
cmds:
|
||||
- mkdocs serve
|
||||
|
||||
ui:deps:
|
||||
desc: Install the dashboard's node dependencies (ui/node_modules is gitignored)
|
||||
desc: Install dashboard dependencies
|
||||
internal: true
|
||||
# Parallel UI checks must share one dependency install.
|
||||
run: once
|
||||
dir: ui
|
||||
cmds:
|
||||
- npm install --no-audit --no-fund
|
||||
@@ -297,25 +129,6 @@ tasks:
|
||||
|
||||
ui:check:
|
||||
desc: Rebuild the dashboard into a temporary directory and reject a stale ui/dist
|
||||
summary: |
|
||||
ui/dist is committed because the Go build embeds it, so it is a generated
|
||||
source file. Nothing else in the gate reads it and `task ui` rewrites it
|
||||
in place, so before this a change to ui/src that landed without the
|
||||
rebuilt bundle was invisible -- and two agents in two worktrees could each
|
||||
"pass" while producing different dashboards.
|
||||
|
||||
Builds somewhere temporary and compares, never rewriting the committed
|
||||
artifact, which is the rule docs:check already follows for the contract
|
||||
reference. A gate that rebuilt ui/dist in place would bless an unintended
|
||||
UI change with no reviewer ever seeing it.
|
||||
|
||||
Fix a failure with `task ui`, then commit the rebuilt bundle in the same
|
||||
commit as the source change that caused it.
|
||||
|
||||
Declares ui:deps like `ui` and `test:ui` do, so a fresh clone works; that
|
||||
means the gate runs `npm install` once for each dependent. Task's
|
||||
sources/generates up-to-date check does not apply to a node_modules
|
||||
directory, so the guard against that is a follow-up, not a claim here.
|
||||
deps: [ui:deps]
|
||||
cmds:
|
||||
- bash tools/uidist.sh check
|
||||
@@ -323,78 +136,81 @@ tasks:
|
||||
test:ui:
|
||||
desc: Test and type-check the dashboard
|
||||
dir: ui
|
||||
# ui:deps so a fresh clone fails on a real error rather than on a missing
|
||||
# node_modules, which is gitignored and installed by nothing else.
|
||||
deps: [ui:deps]
|
||||
cmds:
|
||||
- npm test
|
||||
- npm run typecheck
|
||||
|
||||
# A test event for the capture intake, so the Events surfaces can be driven by
|
||||
# hand without a real webhook source. See tools/webhook-send.sh --list.
|
||||
webhook:send:
|
||||
desc: Send a test event to the dashboard's capture intake (--help for kinds)
|
||||
cmds:
|
||||
- bash tools/webhook-send.sh {{.CLI_ARGS}}
|
||||
|
||||
dev:
|
||||
desc: "Develop: archied live-reload + archie-gateway + archie-state-store + archie-ui + Vite HMR together. Open http://localhost:5173"
|
||||
summary: |
|
||||
Runs the dev loop in one terminal:
|
||||
desc: Run development services and Vite at http://localhost:5173
|
||||
deps: [dev:daemon, dev:gateway, dev:messaging, dev:state-store, dev:dashboard, dev:ui]
|
||||
|
||||
* air rebuilds and restarts archied on Go changes
|
||||
* archie-gateway serves ChatContract on 127.0.0.1:8585 (archied
|
||||
and archie-ui dial it; neither embeds a gateway)
|
||||
* archie-state-store owns archie.db on 127.0.0.1:9091, loopback,
|
||||
no token (deployments/dev.toml); archied,
|
||||
archie-gateway and archie-ui dial it -- none owns
|
||||
the DB in-process
|
||||
(docs/prds/state-store-contract.md §12 step 7)
|
||||
* archie-ui serves the dashboard on 127.0.0.1:8484 from the
|
||||
embedded dist (deployments/dev.toml). After the
|
||||
UI cutover (archie-core-8cda.5.4) archied runs no
|
||||
dashboard listener: this is what :8484 is.
|
||||
* vite serves the dashboard with hot reload on :5173,
|
||||
proxying /api and /events through to archie-ui
|
||||
on :8484
|
||||
|
||||
The gRPC ports come from [services.state].listen and [services.gateway].listen in
|
||||
deployments/dev.toml, each paired with the target that dials it. Move a pair there
|
||||
together when a port is already taken on the host.
|
||||
|
||||
Open http://localhost:5173 -- not :8484. The Vite server is the one with
|
||||
hot reload; :8484 serves the last built dist/ and will look stale.
|
||||
|
||||
Ctrl-C stops all five.
|
||||
deps: [dev:daemon, dev:gateway, dev:state-store, dev:dashboard, dev:ui]
|
||||
dev:postgres:
|
||||
desc: Start PostgreSQL and wait for readiness
|
||||
cmds:
|
||||
- docker compose up -d postgres
|
||||
- |
|
||||
set -eu
|
||||
for _ in $(seq 1 60); do
|
||||
status=$(docker inspect --format '{{`{{.State.Health.Status}}`}}' "$(docker compose ps -q postgres)" 2>/dev/null || true)
|
||||
if [ "$status" = "healthy" ]; then
|
||||
exit 0
|
||||
fi
|
||||
sleep 1
|
||||
done
|
||||
echo "postgres did not become healthy within 60s" >&2
|
||||
exit 1
|
||||
|
||||
dev:daemon:
|
||||
desc: archied only, live-reloading via air (prefer `task dev`)
|
||||
desc: Run archied with live reload
|
||||
cmds:
|
||||
- |
|
||||
# The daemon and Gateway read their settings from the State Store at
|
||||
# boot and exit if it is not up yet; it starts only once PostgreSQL
|
||||
# is healthy, so wait for its port ([services.state] in
|
||||
# deployments/dev.toml) first.
|
||||
for _ in $(seq 1 120); do nc -z 127.0.0.1 9091 && exit 0; sleep 1; done
|
||||
echo "state store did not come up on 127.0.0.1:9091 within 120s" >&2
|
||||
exit 1
|
||||
- air -build.args_bin="-config-overlay,deployments/dev.toml"
|
||||
|
||||
dev:dashboard:
|
||||
desc: archie-ui only, no live-reload (prefer `task dev`)
|
||||
desc: Run the dashboard backend
|
||||
cmds:
|
||||
- go run ./cmd/archie-ui -config-overlay deployments/dev.toml
|
||||
|
||||
dev:state-store:
|
||||
desc: archie-state-store only, no live-reload (prefer `task dev`)
|
||||
desc: Run the State Store with development PostgreSQL
|
||||
deps: [dev:postgres]
|
||||
cmds:
|
||||
- go run ./cmd/archie-state-store -config-overlay deployments/dev.toml
|
||||
|
||||
dev:gateway:
|
||||
desc: archie-gateway only, no live-reload (prefer `task dev`)
|
||||
# The overlay carries [services.state].target, which archie-gateway
|
||||
# requires (openStateStoreAdapter fails closed on an empty target).
|
||||
# Without it `task dev` leaves the gateway dialling whatever the
|
||||
# developer's installed config names, or unable to start at all, while
|
||||
# archied, archie-ui and the state store all dial 127.0.0.1:9091.
|
||||
desc: Run the development Gateway
|
||||
cmds:
|
||||
- |
|
||||
# The daemon and Gateway read their settings from the State Store at
|
||||
# boot and exit if it is not up yet; it starts only once PostgreSQL
|
||||
# is healthy, so wait for its port ([services.state] in
|
||||
# deployments/dev.toml) first.
|
||||
for _ in $(seq 1 120); do nc -z 127.0.0.1 9091 && exit 0; sleep 1; done
|
||||
echo "state store did not come up on 127.0.0.1:9091 within 120s" >&2
|
||||
exit 1
|
||||
- go run ./cmd/archie-gateway -config-overlay deployments/dev.toml
|
||||
|
||||
dev:messaging:
|
||||
desc: Run the development Messaging Service
|
||||
cmds:
|
||||
- for _ in $(seq 1 120); do nc -z 127.0.0.1 9091 && exit 0; sleep 1; done; echo "state store did not come up on 127.0.0.1:9091 within 120s" >&2; exit 1
|
||||
- go run ./cmd/archie-messaging -config-overlay deployments/dev.toml
|
||||
|
||||
dev:ui:
|
||||
desc: Vite dev server only, expects archie-ui already running (prefer `task dev`)
|
||||
desc: Run Vite (requires the dashboard backend)
|
||||
dir: ui
|
||||
cmds:
|
||||
- npm install --no-audit --no-fund
|
||||
@@ -402,17 +218,6 @@ tasks:
|
||||
|
||||
dev:mobile:
|
||||
desc: Serve the dashboard on your LAN (token-protected) for phone viewing
|
||||
summary: |
|
||||
Starts archie-ui with a LAN-reachable [web] bind and a minted dashboard
|
||||
token, printing the URL (LAN IP + token) and a QR code to scan. After
|
||||
the UI cutover the dashboard is archie-ui's process: this task starts
|
||||
archie-ui only. Run the daemon separately (task dev, or archied) for
|
||||
actual archie operation -- two daemons sharing the bot identity would
|
||||
double-poll the forge.
|
||||
|
||||
The frontend served is the embedded dist, so run `task ui` if you
|
||||
changed the frontend. The token file is the path archied used to mint
|
||||
before the cutover, so an existing phone setup keeps its token.
|
||||
deps:
|
||||
- ui
|
||||
cmds:
|
||||
@@ -431,23 +236,17 @@ tasks:
|
||||
|
||||
build:
|
||||
desc: Build archie services and agent binaries
|
||||
# Version stamping used to live only in Dockerfile.archied, so any build
|
||||
# from source -- including a host deployment -- reported "dev" for
|
||||
# both components and /version was useless there. Derive the same
|
||||
# -X values from the release tags so a source build is stamped too.
|
||||
# git describe (without --abbrev=0) yields 1.7.0-2-gbb54786 when HEAD is
|
||||
# past the tag, which is the honest answer for a mid-cycle build.
|
||||
vars:
|
||||
GATEWAY_VERSION:
|
||||
sh: git describe --tags --match 'archied/v*' 2>/dev/null | sed 's|^archied/v||' || echo dev
|
||||
RUNTIME_VERSION:
|
||||
sh: git describe --tags --match 'archie/v*' 2>/dev/null | sed 's|^archie/v||' || echo dev
|
||||
GATEWAY_VERSION: '{{.GATEWAY_VERSION | default "dev"}}'
|
||||
RUNTIME_VERSION: '{{.RUNTIME_VERSION | default "dev"}}'
|
||||
SERVICE_LDFLAGS: >-
|
||||
-X github.com/samcharles93/archie-core/internal/installtype.buildType=binary
|
||||
-X github.com/samcharles93/archie-core/internal/buildinfo.Version={{.GATEWAY_VERSION}}
|
||||
-X github.com/samcharles93/archie-core/internal/buildinfo.Runtime={{.RUNTIME_VERSION}}
|
||||
sources:
|
||||
- "**/*.go"
|
||||
- go.mod
|
||||
- go.sum
|
||||
# ui/dist is committed and embedded by ui/embed.go (//go:embed all:dist),
|
||||
# so it is a build input even though no .go file names it.
|
||||
- "ui/dist/**"
|
||||
generates:
|
||||
- "{{.BIN_DIR}}/archied"
|
||||
@@ -457,90 +256,43 @@ tasks:
|
||||
- "{{.BIN_DIR}}/archie-messaging"
|
||||
- "{{.BIN_DIR}}/archie-agent"
|
||||
cmds:
|
||||
- go build -ldflags "-X github.com/samcharles93/archie-core/internal/app/archied.gatewayVersion={{.GATEWAY_VERSION}} -X github.com/samcharles93/archie-core/internal/app/archied.runtimeVersion={{.RUNTIME_VERSION}} -X github.com/samcharles93/archie-core/internal/installtype.buildType=binary" -o {{.BIN_DIR}}/archied ./cmd/archied
|
||||
- go build -ldflags "-X github.com/samcharles93/archie-core/internal/app/archied.gatewayVersion={{.GATEWAY_VERSION}} -X github.com/samcharles93/archie-core/internal/installtype.buildType=binary" -o {{.BIN_DIR}}/archie-gateway ./cmd/archie-gateway
|
||||
- go build -ldflags "-X github.com/samcharles93/archie-core/internal/installtype.buildType=binary" -o {{.BIN_DIR}}/archie-state-store ./cmd/archie-state-store
|
||||
- go build -ldflags "-X github.com/samcharles93/archie-core/internal/installtype.buildType=binary" -o {{.BIN_DIR}}/archie-ui ./cmd/archie-ui
|
||||
- go build -ldflags "-X github.com/samcharles93/archie-core/internal/installtype.buildType=binary" -o {{.BIN_DIR}}/archie-messaging ./cmd/archie-messaging
|
||||
# One flag set for every service, matching scripts/archie-update-install
|
||||
# and the release workflow, so each binary reports the same version.
|
||||
- for: [archied, archie-gateway, archie-state-store, archie-ui, archie-messaging]
|
||||
cmd: go build -ldflags "{{.SERVICE_LDFLAGS}}" -o {{.BIN_DIR}}/{{.ITEM}} ./cmd/{{.ITEM}}
|
||||
- go build -ldflags "-X github.com/samcharles93/archie-core/internal/app/agentworker.version={{.RUNTIME_VERSION}} -X github.com/samcharles93/archie-core/internal/installtype.buildType=binary" -o {{.BIN_DIR}}/archie-agent ./cmd/archie-agent
|
||||
|
||||
test:
|
||||
desc: Run the Go test suite
|
||||
desc: Run short Go tests with caching
|
||||
cmds:
|
||||
- go test -short ./...
|
||||
|
||||
test:full:
|
||||
desc: Run the whole Go test suite uncached, including the wall-clock-bound tests
|
||||
cmds:
|
||||
- go test ./... -count=1
|
||||
|
||||
test:tools:
|
||||
desc: Run the nested tools module suite, refusing to rewrite its go.mod
|
||||
summary: |
|
||||
tools/go.mod replaces the root module, so its build list must satisfy
|
||||
the root module's requirements. When the root moves on, the tools module
|
||||
goes stale and any plain go command there rewrites tools/go.mod and
|
||||
tools/go.sum to catch up, leaving an unrelated dirty diff.
|
||||
|
||||
-mod=readonly is explicit because a developer's global GOFLAGS=-mod=mod
|
||||
overrides the toolchain default and re-enables the silent rewrite.
|
||||
Fix a failure here with: go -C tools mod tidy
|
||||
cmds:
|
||||
- go -C tools test -mod=readonly ./... -count=1
|
||||
|
||||
check:
|
||||
desc: "Full quality gate: fmt, proto, docs, vet, lint, build, test, tools tests, ui tests and bundle"
|
||||
desc: Run the full quality gate
|
||||
# Finish mutations before starting parallel checks.
|
||||
cmds:
|
||||
- task: fmt
|
||||
- task: proto:lint
|
||||
- task: proto:check
|
||||
- task: docs:check
|
||||
- task: docs:prds
|
||||
# Release notes are generated from the changelogs the release process
|
||||
# already freezes. Left out of the gate, a changelog edit would land
|
||||
# while the published notes silently lag behind it.
|
||||
- task: db:check
|
||||
- task: check:readonly
|
||||
|
||||
check:readonly:
|
||||
internal: true
|
||||
deps:
|
||||
- task: proto:lint
|
||||
- task: news:check
|
||||
# The public-docs artifact is what the site renders, so a page edit that
|
||||
# does not reach it publishes a site that disagrees with the repository.
|
||||
- task: docs:artifact:check
|
||||
- task: vet
|
||||
- task: lint
|
||||
- task: build
|
||||
- task: test
|
||||
# The tools module is not covered by ./... from the root; without this
|
||||
# its dependency drift is only ever discovered by a command that
|
||||
# silently repairs it.
|
||||
- task: test:tools
|
||||
# The dashboard's suite runs here too. Left out of the gate it rots
|
||||
# silently: nothing else executes it, so a broken DOM primitive ships.
|
||||
- task: test:ui
|
||||
# ...and so is the bundle that suite is built from. ui/dist is committed
|
||||
# and embedded; nothing else checks it against ui/src, and `task ui`
|
||||
# rewrites it in place, so a forgotten rebuild used to leave no trace in
|
||||
# the gate at all.
|
||||
- task: ui:check
|
||||
|
||||
contract:
|
||||
desc: "Report contract conformance: declared surfaces, their consumers, and the drift between them"
|
||||
summary: |
|
||||
Walks every declared contract surface -- the two gRPC services, the
|
||||
dashboard HTTP API -- and classifies each subject as consumed,
|
||||
declared-unconsumed, undeclared, or a stale declaration.
|
||||
|
||||
ADVISORY, and deliberately NOT part of `task check`, matching
|
||||
tools/reachaudit. The surfaces are discovered by scanning source text:
|
||||
the .proto files, the adapter bodies that call the generated client, the
|
||||
route registrations in internal/webui, and the path literals under
|
||||
ui/src. That makes it useful for a periodic survey and unsafe as a gate
|
||||
-- a rename or a reformat elsewhere in the tree can change its output
|
||||
without anything being wrong, and it has already produced a batch of
|
||||
false "unconsumed" readings once when the dashboard's request helper was
|
||||
renamed.
|
||||
|
||||
Read the findings as a prompt to go and check, not as a verdict. To make
|
||||
it fail on an undeclared or stale entry, pass --strict by hand:
|
||||
|
||||
go -C tools run ./contractaudit --repo-root .. --strict
|
||||
|
||||
See docs/prds/contract-conformance-audit.md.
|
||||
cmds:
|
||||
- go -C tools run ./contractaudit --repo-root ..
|
||||
|
||||
release:preview:
|
||||
desc: "Show the release notes that would be generated (VERSION=1.2.0)"
|
||||
cmds:
|
||||
@@ -549,14 +301,14 @@ tasks:
|
||||
vars: [VERSION]
|
||||
|
||||
release:prepare:
|
||||
desc: "Write the generated notes into CHANGELOG.md, uncommitted, for editing (VERSION=1.2.0)"
|
||||
desc: Prepare changelog notes for editing (VERSION=1.2.0)
|
||||
cmds:
|
||||
- tools/release.sh --version {{.VERSION}} --prepare
|
||||
requires:
|
||||
vars: [VERSION]
|
||||
|
||||
release:
|
||||
desc: "Freeze the edited changelog into a release commit and tag (VERSION=1.2.0). Run release:prepare first."
|
||||
desc: Commit and tag the prepared release (VERSION=1.2.0)
|
||||
cmds:
|
||||
- tools/release.sh --version {{.VERSION}} --tag
|
||||
requires:
|
||||
|
||||
+293
@@ -0,0 +1,293 @@
|
||||
# Workflow definitions
|
||||
|
||||
A workflow is a YAML document: an id, what it declares to whatever starts it,
|
||||
and an ordered list of steps. Definitions are stored in the control plane's
|
||||
`workflow-definitions` resource and edited on the dashboard's Workflows page
|
||||
(the Canvas and YAML tabs edit the same document). The shipped workflows are in
|
||||
`internal/domain/workflow/shipped/`.
|
||||
|
||||
The server is the authority. It serves the step vocabulary, including each step
|
||||
type's settings schema, in the `workflow-definitions` catalog entry
|
||||
(`x-step-types`), and validates every definition when it is saved. This file
|
||||
describes that vocabulary; when they disagree, the catalog wins.
|
||||
|
||||
```yaml
|
||||
id: implement
|
||||
repository: required
|
||||
inputs:
|
||||
pr_number: {type: number, required: true}
|
||||
steps:
|
||||
- type: repo.prepare
|
||||
- id: plan
|
||||
type: agent.run
|
||||
settings:
|
||||
role: planner
|
||||
read_only: true
|
||||
mission: |
|
||||
Plan this change: {{ task.prompt }}
|
||||
- id: build
|
||||
type: agent.run
|
||||
settings:
|
||||
gate: repository
|
||||
mission: "Implement it following this plan: {{ steps.plan.summary }}"
|
||||
- type: repo.commit
|
||||
settings: {message: "{{ task.title }}", push: true, if_empty: complete}
|
||||
- type: repo.open-pr
|
||||
settings: {body: "{{ steps.build.summary }}"}
|
||||
```
|
||||
|
||||
## The workflow
|
||||
|
||||
| Field | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `id` | text | The workflow's name. Required, unique. |
|
||||
| `steps` | list | The steps, run in order. At least one. |
|
||||
| `repository` | `required` \| `optional` \| `none` | `required` (the default) clones the task's repository into a worktree. `optional` clones one when the run names a repository and uses a scratch workspace otherwise. `none` never clones; only steps that run without a repository may be used. |
|
||||
| `inputs` | mapping | Named, typed values whatever starts the run must supply: `{type, required}`, where type is `string`, `number`, `bool`, `object`, `array` or `any`. Steps read them as `{{ inputs.<name> }}`. |
|
||||
| `outputs` | mapping | Named, typed results the run writes once each (same shape as inputs). A required output the run never writes parks it. A calling workflow reads them. |
|
||||
| `profile` | text | The container profile (`[containers.profiles]`) the run's agents use. Resolved when the task is dispatched. |
|
||||
| `identity` | text | The identity every run acts as, whatever started it. Empty runs as the starter. |
|
||||
| `needs` | mapping | Harness capabilities the run requires: `captures` (bool), `gate_retries` (number). Declared outputs imply `captures`. |
|
||||
|
||||
## A step
|
||||
|
||||
| Field | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `type` | text | The step type (below). |
|
||||
| `id` | text | Names the step so later steps can read its result. Unique in the workflow; letters, digits, `-` and `_`. The run records the step under this name. |
|
||||
| `settings` | mapping | The step type's settings. String settings may contain references. |
|
||||
| `when` | condition | Skip the step unless the condition holds. |
|
||||
| `on_failure` | `park` \| `continue` | `park` (the default) stops the run for an operator. `continue` records the failure and moves on. |
|
||||
| `retry` | mapping | `attempts` (1 to 10) and `backoff` (a duration such as `30s`). A failed step runs again before `on_failure` applies. |
|
||||
| `parallel` | mapping | Instead of `type`: named branches, each a list of steps, run at the same time. |
|
||||
|
||||
### References
|
||||
|
||||
Any string setting may contain `{{ path }}`, replaced when the step runs:
|
||||
|
||||
| Path | Value |
|
||||
|---|---|
|
||||
| `task.title`, `task.body` | The issue or chat request. |
|
||||
| `task.prompt` | The title and body framed for an agent mission. |
|
||||
| `task.repository` | `owner/name`. |
|
||||
| `task.kind` | What the task came from, as prose: `GitHub issue` or `chat-originated task`. |
|
||||
| `task.issue`, `task.pr` | Issue and pull request numbers. |
|
||||
| `task.plan` | The plan a `human.approve` step handed over (an approved PRD). |
|
||||
| `task.review` | The review comments a remediation round addresses. |
|
||||
| `inputs.<name>` | A declared input; an undeclared one is refused at save. |
|
||||
| `steps.<id>.summary` | What an earlier step reported, e.g. an agent's finish summary or a gate's output. |
|
||||
| `steps.<id>.result.<field>` | A field of an earlier agent's structured result, or an output of an earlier `workflow.call` that waits. A field the agent's `result` schema or the callee's `outputs` does not declare is refused at save. |
|
||||
|
||||
Only earlier steps may be referenced; a reference to a later or unknown step is
|
||||
refused when the definition is saved. A value that does not exist at run time
|
||||
(for instance, a step that was skipped) renders empty.
|
||||
|
||||
### Conditions
|
||||
|
||||
`when` is a reference path, written without braces:
|
||||
|
||||
- `steps.assess.result.fit` holds when the value is true, a non-empty string other than `false`, or a non-zero number.
|
||||
- `!steps.assess.result.fit` holds when it does not.
|
||||
- `steps.classify.result.workflow == tdd` and `!=` compare the value as text.
|
||||
|
||||
### Parallel branches
|
||||
|
||||
```yaml
|
||||
- id: research
|
||||
parallel:
|
||||
code: [{id: code, type: agent.run, settings: {mission: ..., read_only: true}}]
|
||||
docs: [{id: docs, type: agent.run, settings: {mission: ..., read_only: true}}]
|
||||
- type: agent.run
|
||||
settings: {mission: "{{ steps.code.summary }} {{ steps.docs.summary }}"}
|
||||
```
|
||||
|
||||
Branches share one worktree, so only read-only `agent.run` and `workflow.call`
|
||||
steps may run in them. A branch sees the steps before the parallel step and its
|
||||
own earlier steps, never a sibling's. Every branch's results are visible after
|
||||
it. Parallel steps do not nest, and need at least two branches.
|
||||
|
||||
### How a run ends
|
||||
|
||||
A run ends at the first step that sets an outcome: `workflow.finish`,
|
||||
`workflow.handoff`, `human.approve`, `repo.open-pr`, `repo.commit` with
|
||||
`if_empty: complete`, or `review.reply`. A run that reaches the end of its steps
|
||||
completes, with the last step's summary as its detail. A step that fails parks
|
||||
the run unless it continues on failure.
|
||||
|
||||
A parked run can be retried from a top-level step instead of from the start.
|
||||
The steps before it are skipped and their results stay available to
|
||||
references. The resume point is named by the step's id (else its type), so
|
||||
give an id to any step whose type appears twice. A run with a repository
|
||||
resumes only on its pushed branch: work an earlier step did not push is not
|
||||
there.
|
||||
|
||||
## Step types
|
||||
|
||||
### `agent.run`
|
||||
|
||||
_runs without a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `extra_rules` | text | Appended to the agent system prompt. |
|
||||
| `gate` | `repository` \| `test-failure` | Hold the agent to the repository gate before it may finish; test-failure requires the tests to fail. |
|
||||
| `mission` | text | What the agent is asked to do. May reference {{ task.* }}, {{ inputs.* }} and {{ steps.<id>.* }}. |
|
||||
| `protect_tests` | bool | Write-block the repository test files. |
|
||||
| `read_only` | bool | Restrict the agent to read-only tools. |
|
||||
| `result` | mapping | A JSON Schema object the agent must return; later steps read it as steps.<id>.result. |
|
||||
| `role` | text | Which configured model role runs the agent, e.g. builder or planner. Empty means builder. |
|
||||
|
||||
### `command.run`
|
||||
|
||||
_needs a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `level` | `error` \| `warn` | error stops the run on a failing command; warn reports it and continues. |
|
||||
| `run` | list of mapping | The commands to run in order; the first failure ends the step. |
|
||||
|
||||
### `repo.commit`
|
||||
|
||||
_needs a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `if_empty` | `fail` \| `skip` \| `complete` | fail stops the run, skip moves on, complete closes the issue and ends the run. |
|
||||
| `message` | text | The commit message. |
|
||||
| `push` | bool | Push the branch after committing. |
|
||||
| `reference` | `Fixes` \| `Implements` \| `Refs` | How the commit links to the task issue. |
|
||||
|
||||
### `repo.open-pr`
|
||||
|
||||
_needs a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `body` | text | The pull request description. |
|
||||
| `review` | bool | Review the change first; a blocking finding parks the task instead of opening the PR. |
|
||||
|
||||
### `repo.prepare`
|
||||
|
||||
_needs a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `branch` | `fresh` \| `task` | fresh starts a new branch from the base; task resumes the branch this task pushed. |
|
||||
|
||||
### `gate.diff-rules`
|
||||
|
||||
_needs a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `rules` | list of mapping | Patterns the change must not match. |
|
||||
|
||||
### `gate.diff-size`
|
||||
|
||||
_needs a repository._
|
||||
|
||||
No settings.
|
||||
|
||||
### `gate.repository`
|
||||
|
||||
_needs a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `expect` | `pass` \| `test-failure` | pass requires every gate command to pass; test-failure requires the test command to fail. |
|
||||
| `repair` | bool | Let the builder fix a failing gate before the step fails. |
|
||||
|
||||
### `forge.close-issue`
|
||||
|
||||
_runs without a repository._
|
||||
|
||||
No settings.
|
||||
|
||||
### `forge.comment`
|
||||
|
||||
_runs without a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `body` | text | The comment text. |
|
||||
| `on` | `issue` \| `pr` | Comment on the issue or the pull request. Empty means issue. |
|
||||
|
||||
### `human.approve`
|
||||
|
||||
_runs without a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `plan` | text | What the human decides on; the next workflow reads it as task.plan. |
|
||||
| `then` | text | The workflow the task runs once approved. |
|
||||
|
||||
### `review.pr`
|
||||
|
||||
_needs a repository._
|
||||
|
||||
No settings.
|
||||
|
||||
### `review.reply`
|
||||
|
||||
_needs a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `body` | text | The reply to the review. |
|
||||
|
||||
### `review.start-round`
|
||||
|
||||
_needs a repository._
|
||||
|
||||
No settings.
|
||||
|
||||
### `workflow.call`
|
||||
|
||||
_runs without a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `inputs` | mapping | |
|
||||
| `outputs` | mapping | |
|
||||
| `wait` | bool | Wait for the child run to finish before continuing. |
|
||||
| `workflow` | text | The workflow to start as a child run. |
|
||||
|
||||
### `workflow.finish`
|
||||
|
||||
_runs without a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `detail` | text | What the operator reads about the outcome. |
|
||||
| `status` | `completed` \| `parked` \| `waiting_human` \| `declined` | How the run ends. Empty means completed. |
|
||||
|
||||
### `workflow.handoff`
|
||||
|
||||
_runs without a repository._
|
||||
|
||||
| Setting | Type | Meaning |
|
||||
|---|---|---|
|
||||
| `detail` | text | Why the task was handed off. |
|
||||
| `workflow` | text | The workflow the task is requeued under. |
|
||||
|
||||
`command.run` commands are `{name, argv, expect_failure}`: `argv` is the
|
||||
program and its arguments, and `expect_failure` requires a non-zero exit.
|
||||
|
||||
`gate.diff-rules` rules are `{id, level, pattern, path, exclude_path, message}`:
|
||||
`level` (`error` blocks, `warn` reports) and `pattern` (an RE2 expression matched
|
||||
against each added line) are required; `path` and `exclude_path` are RE2
|
||||
expressions that limit which files the rule applies to.
|
||||
|
||||
## What starts a workflow
|
||||
|
||||
- **Issues**, by label: `bug` runs `tdd`, `feature` runs `feasibility`, anything
|
||||
else runs `triage`, which classifies it and hands off.
|
||||
- **Event bindings**: a webhook source mapped onto a workflow and its inputs
|
||||
(Events page).
|
||||
- **Playbooks**: a trigger (issue kind and labels) and actions that dispatch
|
||||
workflows.
|
||||
- **Other workflows**: `workflow.call` (a child run), `workflow.handoff` (the
|
||||
same task, requeued), `human.approve` (once approved).
|
||||
- **By hand**: the New task form, or Run on the Workflows page.
|
||||
|
||||
The canvas Start node lists the triggers of each workflow.
|
||||
@@ -0,0 +1,9 @@
|
||||
package configtemplate
|
||||
|
||||
import _ "embed"
|
||||
|
||||
// Changelog is the verbatim contents of CHANGELOG.md, so a binary carries the
|
||||
// release notes for the version it was built as.
|
||||
//
|
||||
//go:embed CHANGELOG.md
|
||||
var Changelog string
|
||||
@@ -1,108 +0,0 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"go/ast"
|
||||
"go/parser"
|
||||
"go/token"
|
||||
"path/filepath"
|
||||
"strconv"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestCommandBoundary(t *testing.T) {
|
||||
paths, err := filepath.Glob("*.go")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
for _, path := range paths {
|
||||
if !strings.HasSuffix(path, "_test.go") && path != "main.go" {
|
||||
t.Errorf("cmd/archie-agent contains substantive production file %q; runtime ownership belongs in internal/app/agentworker", path)
|
||||
}
|
||||
}
|
||||
|
||||
file, err := parser.ParseFile(token.NewFileSet(), "main.go", nil, 0)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
const (
|
||||
projectInternal = "github.com/samcharles93/archie-core/internal/"
|
||||
appImport = projectInternal + "app/agentworker"
|
||||
)
|
||||
appIdent := "agentworker"
|
||||
for _, imported := range file.Imports {
|
||||
path, err := strconv.Unquote(imported.Path.Value)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if strings.HasPrefix(path, projectInternal) && path != appImport {
|
||||
t.Errorf("cmd/archie-agent imports substantive internal package %q; only %q is allowed", path, appImport)
|
||||
}
|
||||
if path == appImport && imported.Name != nil {
|
||||
if imported.Name.Name == "." || imported.Name.Name == "_" {
|
||||
t.Errorf("cmd/archie-agent imports %q with unsupported alias %q", appImport, imported.Name.Name)
|
||||
} else {
|
||||
appIdent = imported.Name.Name
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
allowedFunctions := map[string]bool{
|
||||
"main": true,
|
||||
"run": true,
|
||||
"runCommand": true,
|
||||
"natsConnectionSettings": true,
|
||||
}
|
||||
for _, declaration := range file.Decls {
|
||||
function, ok := declaration.(*ast.FuncDecl)
|
||||
if !ok {
|
||||
continue
|
||||
}
|
||||
if function.Recv != nil || !allowedFunctions[function.Name.Name] {
|
||||
t.Errorf("cmd/archie-agent main.go declares unexpected function %q; orchestration belongs in internal/app/agentworker", function.Name.Name)
|
||||
}
|
||||
delete(allowedFunctions, function.Name.Name)
|
||||
}
|
||||
for name := range allowedFunctions {
|
||||
t.Errorf("cmd/archie-agent main.go is missing intended process function %q", name)
|
||||
}
|
||||
|
||||
var runFunction *ast.FuncDecl
|
||||
for _, declaration := range file.Decls {
|
||||
function, ok := declaration.(*ast.FuncDecl)
|
||||
if ok && function.Name.Name == "run" {
|
||||
runFunction = function
|
||||
break
|
||||
}
|
||||
}
|
||||
if runFunction == nil {
|
||||
t.Fatal("cmd/archie-agent has no run function")
|
||||
}
|
||||
|
||||
workerCalls := 0
|
||||
ast.Inspect(runFunction.Body, func(node ast.Node) bool {
|
||||
call, ok := node.(*ast.CallExpr)
|
||||
if !ok {
|
||||
return true
|
||||
}
|
||||
callee, ok := call.Fun.(*ast.Ident)
|
||||
if !ok || callee.Name != "runCommand" {
|
||||
return true
|
||||
}
|
||||
for _, argument := range call.Args {
|
||||
selector, ok := argument.(*ast.SelectorExpr)
|
||||
if !ok || selector.Sel.Name != "Run" {
|
||||
continue
|
||||
}
|
||||
pkg, ok := selector.X.(*ast.Ident)
|
||||
if ok && pkg.Name == appIdent {
|
||||
workerCalls++
|
||||
}
|
||||
}
|
||||
return true
|
||||
})
|
||||
if workerCalls != 1 {
|
||||
t.Fatalf("cmd/archie-agent run passes agentworker.Run to runCommand %d times, want exactly 1", workerCalls)
|
||||
}
|
||||
}
|
||||
@@ -8,8 +8,10 @@ import (
|
||||
"fmt"
|
||||
"io"
|
||||
"log/slog"
|
||||
"net"
|
||||
"os"
|
||||
"os/signal"
|
||||
"strings"
|
||||
"syscall"
|
||||
|
||||
"github.com/samcharles93/archie-core/internal/app/agentworker"
|
||||
@@ -26,6 +28,12 @@ func run() int {
|
||||
}
|
||||
|
||||
func runCommand(args []string, getenv func(string) string, stderr io.Writer, runWorker workerRunner) int {
|
||||
if len(args) > 0 && args[0] == "relay" {
|
||||
return runRelay(args[1:], stderr, agentworker.RunRelay)
|
||||
}
|
||||
if len(args) > 0 && args[0] == "mcp" {
|
||||
return runMCP(args[1:], stderr, agentworker.RunCaptureMCP)
|
||||
}
|
||||
flags := flag.NewFlagSet("archie-agent", flag.ContinueOnError)
|
||||
flags.SetOutput(stderr)
|
||||
natsURLFlag := flags.String("nats-url", "", "NATS server URL (defaults to NATS_URL)")
|
||||
@@ -81,3 +89,78 @@ func natsConnectionSettings(flagURL string, getenv func(string) string) (url, to
|
||||
}
|
||||
return url, getenv("NATS_TOKEN")
|
||||
}
|
||||
|
||||
type relayServer func(ctx context.Context, forwards map[string]string) error
|
||||
|
||||
// runRelay is the sandbox egress relay: the container on both a sandbox's
|
||||
// isolated network and the host-reachable one, forwarding a fixed set of
|
||||
// ports to the proxy, NATS and the State Store.
|
||||
func runRelay(args []string, stderr io.Writer, serve relayServer) int {
|
||||
flags := flag.NewFlagSet("archie-agent relay", flag.ContinueOnError)
|
||||
flags.SetOutput(stderr)
|
||||
forwards := map[string]string{}
|
||||
flags.Func("forward", "listen=target: forward connections on listen to target (repeatable)", func(v string) error {
|
||||
listen, target, ok := strings.Cut(v, "=")
|
||||
if !ok || listen == "" || target == "" {
|
||||
return fmt.Errorf("%q is not listen=target", v)
|
||||
}
|
||||
if _, _, err := net.SplitHostPort(listen); err != nil {
|
||||
return fmt.Errorf("listen address %q: %w", listen, err)
|
||||
}
|
||||
if _, _, err := net.SplitHostPort(target); err != nil {
|
||||
return fmt.Errorf("target %q: %w", target, err)
|
||||
}
|
||||
if _, dup := forwards[listen]; dup {
|
||||
return fmt.Errorf("listen address %q is forwarded twice", listen)
|
||||
}
|
||||
forwards[listen] = target
|
||||
return nil
|
||||
})
|
||||
if err := flags.Parse(args); err != nil {
|
||||
if errors.Is(err, flag.ErrHelp) {
|
||||
return 0
|
||||
}
|
||||
return 2
|
||||
}
|
||||
if len(forwards) == 0 {
|
||||
fmt.Fprintln(stderr, "error: at least one -forward is required")
|
||||
flags.Usage()
|
||||
return 1
|
||||
}
|
||||
ctx, stop := signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGTERM)
|
||||
defer stop()
|
||||
if err := serve(ctx, forwards); err != nil {
|
||||
fmt.Fprintln(stderr, "error:", err)
|
||||
return 1
|
||||
}
|
||||
return 0
|
||||
}
|
||||
|
||||
type mcpServer func(ctx context.Context, specPath, capturesPath string) error
|
||||
|
||||
// runMCP serves a stage's capture tools to a harness over stdio. The
|
||||
// harness starts it, so it runs as the harness user and holds no secrets.
|
||||
func runMCP(args []string, stderr io.Writer, serve mcpServer) int {
|
||||
flags := flag.NewFlagSet("archie-agent mcp", flag.ContinueOnError)
|
||||
flags.SetOutput(stderr)
|
||||
spec := flags.String("spec", "", "JSON file listing the stage's capture tools")
|
||||
captures := flags.String("captures", "", "file accepted capture calls are appended to")
|
||||
if err := flags.Parse(args); err != nil {
|
||||
if errors.Is(err, flag.ErrHelp) {
|
||||
return 0
|
||||
}
|
||||
return 2
|
||||
}
|
||||
if *spec == "" || *captures == "" {
|
||||
fmt.Fprintln(stderr, "error: -spec and -captures are required")
|
||||
flags.Usage()
|
||||
return 1
|
||||
}
|
||||
ctx, stop := signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGTERM)
|
||||
defer stop()
|
||||
if err := serve(ctx, *spec, *captures); err != nil {
|
||||
fmt.Fprintln(stderr, "error:", err)
|
||||
return 1
|
||||
}
|
||||
return 0
|
||||
}
|
||||
@@ -1,134 +0,0 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"errors"
|
||||
"log/slog"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/samcharles93/archie-core/internal/app/agentworker"
|
||||
)
|
||||
|
||||
func TestRunCommandPreservesCLIExitSemantics(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
args []string
|
||||
getenv func(string) string
|
||||
worker workerRunner
|
||||
wantCode int
|
||||
}{
|
||||
{name: "help", args: []string{"-h"}},
|
||||
{name: "flag parse error", args: []string{"-unknown"}, wantCode: 2},
|
||||
{name: "removed consumer flag", args: []string{"-consumer", "legacy"}, wantCode: 2},
|
||||
{name: "missing NATS URL", wantCode: 1},
|
||||
{name: "missing state store URL", args: []string{"-nats-url", "nats://test"}, wantCode: 1},
|
||||
{
|
||||
name: "worker failure",
|
||||
args: []string{"-nats-url", "nats://test", "-state-store-url", "127.0.0.1:9090"},
|
||||
worker: func(context.Context, agentworker.Settings, *slog.Logger) error {
|
||||
return errors.New("worker failed")
|
||||
},
|
||||
wantCode: 1,
|
||||
},
|
||||
{
|
||||
name: "success",
|
||||
args: []string{"-nats-url", "nats://test", "-state-store-url", "127.0.0.1:9090"},
|
||||
worker: func(context.Context, agentworker.Settings, *slog.Logger) error {
|
||||
return nil
|
||||
},
|
||||
},
|
||||
}
|
||||
for _, test := range tests {
|
||||
t.Run(test.name, func(t *testing.T) {
|
||||
getenv := test.getenv
|
||||
if getenv == nil {
|
||||
getenv = func(string) string { return "" }
|
||||
}
|
||||
worker := test.worker
|
||||
if worker == nil {
|
||||
worker = func(context.Context, agentworker.Settings, *slog.Logger) error {
|
||||
t.Fatal("worker called")
|
||||
return nil
|
||||
}
|
||||
}
|
||||
if got := runCommand(test.args, getenv, &bytes.Buffer{}, worker); got != test.wantCode {
|
||||
t.Fatalf("runCommand() = %d, want %d", got, test.wantCode)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestRunCommandRequiresNATSURL(t *testing.T) {
|
||||
var stderr bytes.Buffer
|
||||
called := false
|
||||
code := runCommand(nil, func(string) string { return "" }, &stderr, func(context.Context, agentworker.Settings, *slog.Logger) error {
|
||||
called = true
|
||||
return nil
|
||||
})
|
||||
if code != 1 || called {
|
||||
t.Fatalf("(code, worker called) = (%d, %v), want (1, false)", code, called)
|
||||
}
|
||||
for _, want := range []string{"error: -nats-url or NATS_URL is required", "Usage of archie-agent:"} {
|
||||
if !strings.Contains(stderr.String(), want) {
|
||||
t.Fatalf("stderr %q does not contain %q", stderr.String(), want)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestRunCommandMapsWorkerOutcomeToExitStatus(t *testing.T) {
|
||||
workerErr := errors.New("startup failed")
|
||||
tests := []struct {
|
||||
name string
|
||||
workerErr error
|
||||
wantCode int
|
||||
}{
|
||||
{name: "success"},
|
||||
{name: "worker failure", workerErr: workerErr, wantCode: 1},
|
||||
}
|
||||
for _, test := range tests {
|
||||
t.Run(test.name, func(t *testing.T) {
|
||||
var stderr bytes.Buffer
|
||||
code := runCommand([]string{"-nats-url", "nats://flag"}, func(string) string { return "token" }, &stderr, func(_ context.Context, settings agentworker.Settings, _ *slog.Logger) error {
|
||||
if settings.NATSURL != "nats://flag" || settings.NATSToken != "token" {
|
||||
t.Fatalf("settings = %#v", settings)
|
||||
}
|
||||
return test.workerErr
|
||||
})
|
||||
if code != test.wantCode {
|
||||
t.Fatalf("code = %d, want %d", code, test.wantCode)
|
||||
}
|
||||
if test.workerErr != nil && stderr.Len() != 0 {
|
||||
t.Fatalf("stderr = %q, want command not to duplicate application logging", stderr.String())
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestNATSConnectionSettings(t *testing.T) {
|
||||
getenv := func(name string) string {
|
||||
switch name {
|
||||
case "NATS_URL":
|
||||
return "nats://nats.example:4222"
|
||||
case "NATS_TOKEN":
|
||||
return "test-nats-token"
|
||||
default:
|
||||
return ""
|
||||
}
|
||||
}
|
||||
|
||||
t.Run("container environment", func(t *testing.T) {
|
||||
url, token := natsConnectionSettings("", getenv)
|
||||
if url != "nats://nats.example:4222" || token != "test-nats-token" {
|
||||
t.Fatalf("natsConnectionSettings() = (%q, %q)", url, token)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("flag URL takes precedence", func(t *testing.T) {
|
||||
url, token := natsConnectionSettings("nats://flag.example:4222", getenv)
|
||||
if url != "nats://flag.example:4222" || token != "test-nats-token" {
|
||||
t.Fatalf("natsConnectionSettings() = (%q, %q)", url, token)
|
||||
}
|
||||
})
|
||||
}
|
||||
@@ -9,7 +9,7 @@ import (
|
||||
"os/signal"
|
||||
"syscall"
|
||||
|
||||
"github.com/samcharles93/archie-core/internal/app/archied"
|
||||
"github.com/samcharles93/archie-core/internal/app/archiegateway"
|
||||
"github.com/samcharles93/archie-core/internal/buildinfo"
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/configuration"
|
||||
)
|
||||
@@ -17,7 +17,7 @@ import (
|
||||
func main() { os.Exit(run()) }
|
||||
|
||||
func run() int {
|
||||
var options archied.GatewayOptions
|
||||
var options archiegateway.Options
|
||||
showVersion := buildinfo.RegisterVersionFlag("archie-gateway")
|
||||
flag.StringVar(&options.Config, "config", configuration.DefaultConfigPath(), "configuration file or directory")
|
||||
flag.StringVar(&options.Overlay, "config-overlay", "", "configuration overlay file or directory")
|
||||
@@ -27,7 +27,7 @@ func run() int {
|
||||
showVersion()
|
||||
ctx, stop := signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGTERM)
|
||||
defer stop()
|
||||
if err := archied.RunGateway(ctx, options); err != nil {
|
||||
if err := archiegateway.Run(ctx, options); err != nil {
|
||||
fmt.Fprintln(os.Stderr, err)
|
||||
return 1
|
||||
}
|
||||
|
||||
@@ -1,125 +0,0 @@
|
||||
// This file enforces the objective half of the Messaging Service deletion gate
|
||||
// (docs/prds/messaging-service-boundary.md, "Deletion Gate and Verification"): the
|
||||
// linked binary carries no state-store, daemon, workflow, forge, gateway or
|
||||
// dashboard runtime. Go imports are atomic, so a single reference to a type living
|
||||
// beside a runtime relinks the runtime, and the severance holds only while
|
||||
// something re-measures it. That is exactly how this package came to link the
|
||||
// SQLite driver, the workflow engine and agentexec through one import of
|
||||
// internal/app/controlplane (archie-core-1ng1).
|
||||
|
||||
package main
|
||||
|
||||
import (
|
||||
"os/exec"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
const modulePath = "github.com/samcharles93/archie-core/"
|
||||
|
||||
// bannedCategory is one class of runtime the Messaging Service must not link.
|
||||
// The names are the PRD's wording; the prefixes are how that class appears in
|
||||
// this module.
|
||||
type bannedCategory struct {
|
||||
name string
|
||||
prefixes []string
|
||||
}
|
||||
|
||||
// deletionGate is the PRD's list, one entry per category it names. Two deliberate
|
||||
// absences:
|
||||
//
|
||||
// - internal/channels is NOT here. The Messaging Service hosts those adapters;
|
||||
// it is the process they live in, not a consumer of them.
|
||||
// - internal/gatewayrpc needs no exception. It is the Gateway's contract, not
|
||||
// its runtime, and it does not sit under the internal/gateway prefix -- the
|
||||
// check below would catch it if it ever did.
|
||||
var deletionGate = []bannedCategory{
|
||||
{"state store", []string{
|
||||
"modernc.org/sqlite",
|
||||
modulePath + "internal/store",
|
||||
}},
|
||||
{"daemon runtime", []string{
|
||||
modulePath + "internal/daemon",
|
||||
modulePath + "internal/app/archied",
|
||||
modulePath + "internal/container",
|
||||
modulePath + "internal/worktree",
|
||||
}},
|
||||
{"workflow engine", []string{
|
||||
modulePath + "internal/domain/workflow",
|
||||
modulePath + "internal/agentexec",
|
||||
modulePath + "internal/taskrun",
|
||||
}},
|
||||
{"forge client", []string{
|
||||
modulePath + "internal/forge",
|
||||
modulePath + "internal/forgerpc",
|
||||
}},
|
||||
{"gateway runtime", []string{
|
||||
modulePath + "internal/gateway",
|
||||
}},
|
||||
{"dashboard", []string{
|
||||
modulePath + "internal/webui",
|
||||
}},
|
||||
}
|
||||
|
||||
// gateExceptions are packages under a banned prefix that carry only contract,
|
||||
// vocabulary or view types, so linking them is the intended end state rather
|
||||
// than a tolerated leak. internal/domain/workflow/task is the Task status and
|
||||
// view vocabulary the Messaging Service renders; its own dependency set holds
|
||||
// none of the banned runtimes, which is what makes the exception defensible
|
||||
// rather than a hole. cmd/archie-ui/architecture_test.go carries the same entry
|
||||
// for the same reason.
|
||||
//
|
||||
// Each one must stay linked: an exception nothing needs any more is a hole in
|
||||
// the fence, so this list is checked in both directions.
|
||||
var gateExceptions = []string{
|
||||
modulePath + "internal/domain/workflow/task",
|
||||
}
|
||||
|
||||
// under reports whether importPath is prefix or a package below it.
|
||||
func under(importPath, prefix string) bool {
|
||||
return importPath == prefix || strings.HasPrefix(importPath, prefix+"/")
|
||||
}
|
||||
|
||||
func TestMessagingProcessLinksNoRuntimeItOnlyDials(t *testing.T) {
|
||||
listed, err := exec.CommandContext(t.Context(), "go", "list", "-deps", ".").CombinedOutput()
|
||||
if err != nil {
|
||||
t.Fatalf("go list -deps .: %v\n%s", err, listed)
|
||||
}
|
||||
|
||||
linked := make(map[string]bool, len(gateExceptions))
|
||||
for importPath := range strings.FieldsSeq(string(listed)) {
|
||||
if excepted(importPath, linked) {
|
||||
continue
|
||||
}
|
||||
for _, category := range deletionGate {
|
||||
for _, prefix := range category.prefixes {
|
||||
if !under(importPath, prefix) {
|
||||
continue
|
||||
}
|
||||
t.Errorf("archie-messaging links %s (%s); the Messaging Service reaches that capability over a contract, never in-process (docs/prds/messaging-service-boundary.md, deletion gate)", importPath, category.name)
|
||||
}
|
||||
}
|
||||
}
|
||||
for _, exception := range gateExceptions {
|
||||
if !linked[exception] {
|
||||
t.Errorf("%s is excepted from the deletion gate but is no longer linked; drop the exception instead of leaving its prefix open", exception)
|
||||
}
|
||||
}
|
||||
// A gate that cannot fail, and a `go list` that returns nothing usable, both
|
||||
// read as a pass. This pins the one thing the loop above assumes.
|
||||
if !strings.Contains(string(listed), modulePath+"cmd/archie-messaging") {
|
||||
t.Fatal("go list -deps returned a list that does not even name this package: the gate asserted nothing")
|
||||
}
|
||||
}
|
||||
|
||||
// excepted reports whether importPath sits under an excepted package, recording
|
||||
// the ones actually linked so a stale exception fails.
|
||||
func excepted(importPath string, linked map[string]bool) bool {
|
||||
for _, exception := range gateExceptions {
|
||||
if under(importPath, exception) {
|
||||
linked[exception] = true
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
@@ -26,6 +26,8 @@ func run() int {
|
||||
flag.StringVar(&options.Gateway.Token, "gateway-token", "", "bearer token presented to archie-gateway")
|
||||
flag.StringVar(&options.StateStore.Target, "state-store-target", "", "archie-state-store gRPC address (defaults to [services.state].target)")
|
||||
flag.StringVar(&options.StateStore.Token, "state-store-token", "", "bearer token presented to archie-state-store")
|
||||
flag.StringVar(&options.Listen, "listen", "", "MessagingService gRPC listen address (defaults to [services.messaging].listen)")
|
||||
flag.StringVar(&options.Token, "token", "", "bearer token required from MessagingService callers on a non-loopback listener")
|
||||
flag.DurationVar(&options.DependencyTimeout, "dependency-timeout", 0, "readiness probe timeout (default 5s)")
|
||||
flag.DurationVar(&options.ShutdownTimeout, "shutdown-timeout", 0, "shutdown timeout (default 5s)")
|
||||
flag.Parse()
|
||||
|
||||
@@ -1,153 +0,0 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"context"
|
||||
"net"
|
||||
"os"
|
||||
"os/exec"
|
||||
"path/filepath"
|
||||
"runtime"
|
||||
"strings"
|
||||
"syscall"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"google.golang.org/grpc"
|
||||
|
||||
controlpb "github.com/samcharles93/archie-core/internal/contracts/controlplane/v1"
|
||||
"github.com/samcharles93/archie-core/internal/domain/messaging"
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/gatewayrpc"
|
||||
)
|
||||
|
||||
func repoRoot(t *testing.T) string {
|
||||
t.Helper()
|
||||
_, file, _, ok := runtime.Caller(0)
|
||||
if !ok {
|
||||
t.Fatal("runtime.Caller failed")
|
||||
}
|
||||
dir := filepath.Dir(file)
|
||||
for {
|
||||
if _, err := os.Stat(filepath.Join(dir, "go.mod")); err == nil {
|
||||
return dir
|
||||
}
|
||||
parent := filepath.Dir(dir)
|
||||
if parent == dir {
|
||||
t.Fatal("could not find repo root")
|
||||
}
|
||||
dir = parent
|
||||
}
|
||||
}
|
||||
|
||||
func buildBinary(t *testing.T) string {
|
||||
t.Helper()
|
||||
bin := filepath.Join(t.TempDir(), "archie-messaging")
|
||||
cmd := exec.CommandContext(t.Context(), "go", "build", "-o", bin, "./cmd/archie-messaging")
|
||||
cmd.Dir = repoRoot(t)
|
||||
if out, err := cmd.CombinedOutput(); err != nil {
|
||||
t.Fatalf("go build archie-messaging: %v\n%s", err, string(out))
|
||||
}
|
||||
return bin
|
||||
}
|
||||
|
||||
type fakeChatServer struct {
|
||||
messaging.ChatContract
|
||||
}
|
||||
|
||||
func (f *fakeChatServer) Snapshot(ctx context.Context) (messaging.ChatSnapshot, error) {
|
||||
return messaging.ChatSnapshot{}, nil
|
||||
}
|
||||
|
||||
func startTestGateway(t *testing.T) (target string, cleanup func()) {
|
||||
t.Helper()
|
||||
lis, err := (&net.ListenConfig{}).Listen(t.Context(), "tcp", "127.0.0.1:0")
|
||||
if err != nil {
|
||||
t.Fatalf("net.Listen: %v", err)
|
||||
}
|
||||
srv := grpc.NewServer()
|
||||
gatewayrpc.RegisterServer(srv, &fakeChatServer{})
|
||||
go func() {
|
||||
_ = srv.Serve(lis)
|
||||
}()
|
||||
return lis.Addr().String(), func() {
|
||||
srv.GracefulStop()
|
||||
_ = lis.Close()
|
||||
}
|
||||
}
|
||||
|
||||
// fakeControlPlane serves the empty channel-settings resource the Messaging
|
||||
// Service reads at startup. The database is authoritative for channel
|
||||
// settings, so the process refuses to start without a State Store to read.
|
||||
type fakeControlPlane struct {
|
||||
controlpb.UnimplementedControlPlaneServiceServer
|
||||
}
|
||||
|
||||
func (f *fakeControlPlane) Catalog(context.Context, *controlpb.CatalogRequest) (*controlpb.CatalogResponse, error) {
|
||||
return &controlpb.CatalogResponse{}, nil
|
||||
}
|
||||
|
||||
func (f *fakeControlPlane) Query(_ context.Context, request *controlpb.QueryRequest) (*controlpb.QueryResponse, error) {
|
||||
return &controlpb.QueryResponse{Resource: &controlpb.Resource{Kind: request.GetKind(), Version: 1, ValueJson: []byte("{}")}}, nil
|
||||
}
|
||||
|
||||
func startTestStateStore(t *testing.T) (target string, cleanup func()) {
|
||||
t.Helper()
|
||||
lis, err := (&net.ListenConfig{}).Listen(t.Context(), "tcp", "127.0.0.1:0")
|
||||
if err != nil {
|
||||
t.Fatalf("net.Listen: %v", err)
|
||||
}
|
||||
srv := grpc.NewServer()
|
||||
controlpb.RegisterControlPlaneServiceServer(srv, &fakeControlPlane{})
|
||||
go func() {
|
||||
_ = srv.Serve(lis)
|
||||
}()
|
||||
return lis.Addr().String(), func() {
|
||||
srv.GracefulStop()
|
||||
_ = lis.Close()
|
||||
}
|
||||
}
|
||||
|
||||
func TestBinaryHelp(t *testing.T) {
|
||||
bin := buildBinary(t)
|
||||
cmd := exec.CommandContext(t.Context(), bin, "-help")
|
||||
out, err := cmd.CombinedOutput()
|
||||
// flag.ExitOnError or flag help returns exit 0 or 2 depending on standard library
|
||||
if !strings.Contains(string(out), "gateway-target") {
|
||||
t.Fatalf("help output missing gateway-target flag: %v\n%s", err, string(out))
|
||||
}
|
||||
}
|
||||
|
||||
func TestBinaryStartsAndShutsDownCleanly(t *testing.T) {
|
||||
bin := buildBinary(t)
|
||||
gatewayTarget, cleanup := startTestGateway(t)
|
||||
defer cleanup()
|
||||
stateStoreTarget, stopStateStore := startTestStateStore(t)
|
||||
defer stopStateStore()
|
||||
|
||||
cmd := exec.CommandContext(t.Context(), bin, "-gateway-target", gatewayTarget, "-state-store-target", stateStoreTarget)
|
||||
if err := cmd.Start(); err != nil {
|
||||
t.Fatalf("cmd.Start: %v", err)
|
||||
}
|
||||
|
||||
// Allow the process to start up.
|
||||
time.Sleep(200 * time.Millisecond)
|
||||
|
||||
// Send SIGTERM to shut down gracefully.
|
||||
if err := cmd.Process.Signal(syscall.SIGTERM); err != nil {
|
||||
t.Fatalf("send SIGTERM: %v", err)
|
||||
}
|
||||
|
||||
errCh := make(chan error, 1)
|
||||
go func() {
|
||||
errCh <- cmd.Wait()
|
||||
}()
|
||||
|
||||
select {
|
||||
case err := <-errCh:
|
||||
if err != nil {
|
||||
t.Fatalf("process exited with error on SIGTERM: %v", err)
|
||||
}
|
||||
case <-time.After(3 * time.Second):
|
||||
_ = cmd.Process.Kill()
|
||||
t.Fatal("process did not exit in time after SIGTERM")
|
||||
}
|
||||
}
|
||||
@@ -1,91 +0,0 @@
|
||||
// Command archie-playbooks is the standalone playbook tool for archie-core,
|
||||
// shaped like gopls: one binary, multiple invocation modes. It validates
|
||||
// playbook YAML binding files against the same schema the daemon loads at
|
||||
// startup, so a pre-merge check can never disagree with runtime validation.
|
||||
//
|
||||
// Today it ships one mode (lint). The command dispatch is a table from day
|
||||
// one, so a future serve/lsp mode slots in without restructuring -- both
|
||||
// modes are entrypoints into the same validation source in
|
||||
// internal/domain/workflow.
|
||||
//
|
||||
// Known limitation (as of this slice): findings are file-granular, not
|
||||
// line-granular. The loader decodes playbooks with yaml.Unmarshal into a
|
||||
// plain map, which discards line numbers; a compiler-style file:line
|
||||
// diagnostic needs a yaml.Node decoding upgrade, which is out of scope
|
||||
// here and tracked separately.
|
||||
package main
|
||||
|
||||
import (
|
||||
"flag"
|
||||
"fmt"
|
||||
"io"
|
||||
"os"
|
||||
|
||||
"github.com/samcharles93/archie-core/internal/app/archieplaybooks"
|
||||
"github.com/samcharles93/archie-core/internal/buildinfo"
|
||||
)
|
||||
|
||||
func main() {
|
||||
os.Exit(run(os.Args[1:], os.Stderr))
|
||||
}
|
||||
|
||||
func run(args []string, stderr io.Writer) int {
|
||||
// Subcommand table from day one (gopls shape): each mode owns its flag
|
||||
// set and returns an exit code. Adding serve/lsp later is a new entry
|
||||
// here, not a restructuring.
|
||||
commands := map[string]func([]string, io.Writer) int{
|
||||
"lint": runLint,
|
||||
}
|
||||
|
||||
if len(args) > 0 && (args[0] == "-version" || args[0] == "--version") {
|
||||
buildinfo.Print("archie-playbooks")
|
||||
return 0
|
||||
}
|
||||
|
||||
if len(args) == 0 {
|
||||
fmt.Fprintln(stderr, "usage: archie-playbooks <command> [args]")
|
||||
fmt.Fprintln(stderr, "commands:")
|
||||
for name := range commands {
|
||||
fmt.Fprintf(stderr, " %s\n", name)
|
||||
}
|
||||
return 2
|
||||
}
|
||||
|
||||
cmd, ok := commands[args[0]]
|
||||
if !ok {
|
||||
fmt.Fprintf(stderr, "archie-playbooks: unknown command %q\n", args[0])
|
||||
return 2
|
||||
}
|
||||
return cmd(args[1:], stderr)
|
||||
}
|
||||
|
||||
// runLint validates one or more playbook directories against the domain
|
||||
// loaders and reports collisions / malformed files / invalid bindings.
|
||||
// Exit codes: 0 clean, 1 findings, 2 usage error.
|
||||
func runLint(args []string, stderr io.Writer) int {
|
||||
flags := flag.NewFlagSet("archie-playbooks lint", flag.ContinueOnError)
|
||||
flags.SetOutput(stderr)
|
||||
var dirs multiFlag
|
||||
flags.Var(&dirs, "dir", "playbook directory to lint (repeatable)")
|
||||
if err := flags.Parse(args); err != nil {
|
||||
return 2 // flag.ContinueOnError already printed the message
|
||||
}
|
||||
if len(dirs) == 0 {
|
||||
fmt.Fprintln(stderr, "lint: at least one -dir is required")
|
||||
flags.Usage()
|
||||
return 2
|
||||
}
|
||||
|
||||
result := archieplaybooks.Lint(dirs, stderr)
|
||||
return result.ExitCode
|
||||
}
|
||||
|
||||
// multiFlag collects repeated -dir flags.
|
||||
type multiFlag []string
|
||||
|
||||
func (m *multiFlag) String() string { return fmt.Sprint([]string(*m)) }
|
||||
|
||||
func (m *multiFlag) Set(v string) error {
|
||||
*m = append(*m, v)
|
||||
return nil
|
||||
}
|
||||
@@ -1,75 +0,0 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// TestRunUnknownCommandExits2: an unrecognised subcommand is a usage error.
|
||||
func TestRunUnknownCommandExits2(t *testing.T) {
|
||||
var stderr bytes.Buffer
|
||||
if code := run([]string{"frobnicate"}, &stderr); code != 2 {
|
||||
t.Fatalf("run(unknown) = %d, want 2", code)
|
||||
}
|
||||
if !strings.Contains(stderr.String(), "unknown command") {
|
||||
t.Fatalf("stderr = %q, want unknown-command message", stderr.String())
|
||||
}
|
||||
}
|
||||
|
||||
// TestRunNoCommandExits2: no subcommand is a usage error with the command
|
||||
// table printed (the gopls-shaped dispatch surface).
|
||||
func TestRunNoCommandExits2(t *testing.T) {
|
||||
var stderr bytes.Buffer
|
||||
if code := run(nil, &stderr); code != 2 {
|
||||
t.Fatalf("run(nil) = %d, want 2", code)
|
||||
}
|
||||
if !strings.Contains(stderr.String(), "lint") {
|
||||
t.Fatalf("stderr = %q, want lint listed in usage", stderr.String())
|
||||
}
|
||||
}
|
||||
|
||||
// TestRunLintCleanExits0: lint over a valid directory exits 0.
|
||||
func TestRunLintCleanExits0(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
writeFile(t, filepath.Join(dir, "routes.yaml"), "bug: tdd\n")
|
||||
|
||||
var stderr bytes.Buffer
|
||||
if code := run([]string{"lint", "-dir", dir}, &stderr); code != 0 {
|
||||
t.Fatalf("run(lint clean) = %d, want 0; stderr=%q", code, stderr.String())
|
||||
}
|
||||
}
|
||||
|
||||
// TestRunLintCollisionExits1: a cross-directory collision exits 1 and names
|
||||
// the colliding key.
|
||||
func TestRunLintCollisionExits1(t *testing.T) {
|
||||
dirA := t.TempDir()
|
||||
dirB := t.TempDir()
|
||||
writeFile(t, filepath.Join(dirA, "a.yaml"), "security: security-review\n")
|
||||
writeFile(t, filepath.Join(dirB, "b.yaml"), "security: other-security\n")
|
||||
|
||||
var stderr bytes.Buffer
|
||||
if code := run([]string{"lint", "-dir", dirA, "-dir", dirB}, &stderr); code != 1 {
|
||||
t.Fatalf("run(lint collision) = %d, want 1; stderr=%q", code, stderr.String())
|
||||
}
|
||||
if !strings.Contains(stderr.String(), "security") {
|
||||
t.Fatalf("stderr = %q, want the colliding label named", stderr.String())
|
||||
}
|
||||
}
|
||||
|
||||
// TestRunLintNoDirsExits2: lint without any -dir is a usage error.
|
||||
func TestRunLintNoDirsExits2(t *testing.T) {
|
||||
var stderr bytes.Buffer
|
||||
if code := run([]string{"lint"}, &stderr); code != 2 {
|
||||
t.Fatalf("run(lint no dirs) = %d, want 2", code)
|
||||
}
|
||||
}
|
||||
|
||||
func writeFile(t *testing.T, path, content string) {
|
||||
t.Helper()
|
||||
if err := os.WriteFile(path, []byte(content), 0o600); err != nil {
|
||||
t.Fatalf("write %s: %v", path, err)
|
||||
}
|
||||
}
|
||||
@@ -1,11 +1,5 @@
|
||||
// Command archie-state-store hosts the State Store's gRPC contract and owns
|
||||
// the single archie.db SQLite file. It is the .4.3 companion to the daemon's
|
||||
// in-process State Store server: the same StateStoreService .4.2 serves, but
|
||||
// extracted into its own process with its own store lifecycle.
|
||||
//
|
||||
// The gateway's session SQLite is owned by the separate archie-gateway process
|
||||
// and is untouched here. See docs/prds/state-store-contract.md (rev. 2c) §5,
|
||||
// §9 and §11.
|
||||
// Command archie-state-store hosts the State Store's gRPC contract and is the
|
||||
// only process that owns the PostgreSQL stores behind it.
|
||||
package main
|
||||
|
||||
import (
|
||||
@@ -17,7 +11,7 @@ import (
|
||||
"strings"
|
||||
"syscall"
|
||||
|
||||
"github.com/samcharles93/archie-core/internal/app/archied"
|
||||
"github.com/samcharles93/archie-core/internal/app/statestore"
|
||||
"github.com/samcharles93/archie-core/internal/buildinfo"
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/configuration"
|
||||
)
|
||||
@@ -29,10 +23,13 @@ func run() int {
|
||||
// including no arguments at all, serves the State Store contract. An
|
||||
// unrecognised word is refused rather than ignored, so a mistyped recovery
|
||||
// command never leaves an operator watching a server start instead.
|
||||
if args := os.Args[1:]; statestore.IsAccessResetArgs(args) {
|
||||
return statestore.RunAccessReset(context.Background(), args[2:], os.Stderr)
|
||||
}
|
||||
if args := os.Args[1:]; len(args) > 0 && !strings.HasPrefix(args[0], "-") {
|
||||
return runRecovery(args, os.Stdout, os.Stderr)
|
||||
}
|
||||
var options archied.StateStoreOptions
|
||||
var options statestore.Options
|
||||
showVersion := buildinfo.RegisterVersionFlag("archie-state-store")
|
||||
flag.StringVar(&options.Config, "config", configuration.DefaultConfigPath(), "configuration file or directory")
|
||||
flag.StringVar(&options.Overlay, "config-overlay", "", "configuration overlay file or directory")
|
||||
@@ -40,14 +37,14 @@ func run() int {
|
||||
flag.StringVar(&options.Token, "token", "", "bearer token required for a non-loopback listener (defaults to [services.state].target_token)")
|
||||
flag.StringVar(&options.ReadyAddr, "ready-addr", "", "optional readiness HTTP listen address (e.g. 127.0.0.1:9091)")
|
||||
flag.Usage = func() {
|
||||
fmt.Fprintf(flag.CommandLine.Output(), "usage: archie-state-store [flags] # serve the State Store gRPC contract\n\noffline recovery: archie-state-store <backup|restore|validate|rollback> -h\n\n")
|
||||
fmt.Fprintf(flag.CommandLine.Output(), "usage: archie-state-store [flags] # serve the State Store gRPC contract\n\noffline recovery: archie-state-store <backup|restore|validate|rollback> -h | access reset -h\n\n")
|
||||
flag.PrintDefaults()
|
||||
}
|
||||
flag.Parse()
|
||||
showVersion()
|
||||
ctx, stop := signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGTERM)
|
||||
defer stop()
|
||||
if err := archied.RunStateStore(ctx, options); err != nil {
|
||||
if err := statestore.Run(ctx, options); err != nil {
|
||||
fmt.Fprintln(os.Stderr, err)
|
||||
return 1
|
||||
}
|
||||
|
||||
@@ -1,620 +0,0 @@
|
||||
// Package main smoke-tests the standalone archie-state-store process by
|
||||
// building the real binary, running it against a minimal config on the
|
||||
// loopback interface, and driving it through the State Store gRPC contract
|
||||
// exactly the way a consumer (archied, archie-gateway, archie-agent) does.
|
||||
//
|
||||
// This is the .4.7 end-to-end verification for
|
||||
// docs/prds/state-store-contract.md (rev. 2c): it proves the process owns the
|
||||
// single archie.db task SQLite, serves the combined task/event/capture
|
||||
// surface over one gRPC service, preserves error-sentinel fidelity across the
|
||||
// wire, honours a per-call deadline, survives a restart/recovery cycle, and
|
||||
// is the sole owner of the SQLite file. See §5 (binary layout), §6 (handoff),
|
||||
// §7 (error semantics), §11 (remote adapter) and §12 step 7/8 (single owner).
|
||||
|
||||
package main
|
||||
|
||||
import (
|
||||
"bufio"
|
||||
"bytes"
|
||||
"context"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
"net"
|
||||
"net/http"
|
||||
"os"
|
||||
"os/exec"
|
||||
"path/filepath"
|
||||
"runtime"
|
||||
"strings"
|
||||
"sync"
|
||||
"syscall"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"google.golang.org/grpc"
|
||||
"google.golang.org/grpc/credentials/insecure"
|
||||
|
||||
"github.com/samcharles93/archie-core/internal/domain/binding"
|
||||
"github.com/samcharles93/archie-core/internal/domain/mapping"
|
||||
"github.com/samcharles93/archie-core/internal/events"
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/staterpc"
|
||||
"github.com/samcharles93/archie-core/internal/store"
|
||||
)
|
||||
|
||||
// repoRoot walks up from the test's source directory to find the module root
|
||||
// (where go.mod lives). The test runs in the package directory
|
||||
// (cmd/archie-state-store), so the module root is above it; walking keeps the
|
||||
// result correct regardless of the harness working directory.
|
||||
func repoRoot(t *testing.T) string {
|
||||
t.Helper()
|
||||
_, file, _, ok := runtime.Caller(0)
|
||||
if !ok {
|
||||
t.Fatal("cannot determine test source path")
|
||||
}
|
||||
dir := filepath.Dir(file)
|
||||
for {
|
||||
if _, err := os.Stat(filepath.Join(dir, "go.mod")); err == nil {
|
||||
return dir
|
||||
}
|
||||
parent := filepath.Dir(dir)
|
||||
if parent == dir {
|
||||
t.Fatal("go.mod not found above test source")
|
||||
}
|
||||
dir = parent
|
||||
}
|
||||
}
|
||||
|
||||
// buildBinary compiles ./cmd/archie-state-store into dir and returns the path.
|
||||
// This is the real binary the smoke test exercises, not a test double -- the
|
||||
// point of .4.7 is to verify the actual process.
|
||||
func buildBinary(t *testing.T, dir string) string {
|
||||
t.Helper()
|
||||
bin := filepath.Join(dir, "archie-state-store")
|
||||
cmd := exec.CommandContext(t.Context(), "go", "build", "-o", bin, "./cmd/archie-state-store")
|
||||
cmd.Dir = repoRoot(t)
|
||||
cmd.Env = os.Environ()
|
||||
out, err := cmd.CombinedOutput()
|
||||
if err != nil {
|
||||
t.Fatalf("go build archie-state-store: %v\n%s", err, out)
|
||||
}
|
||||
if _, err := os.Stat(bin); err != nil {
|
||||
t.Fatalf("built binary not found: %v", err)
|
||||
}
|
||||
return bin
|
||||
}
|
||||
|
||||
// writeMinimalConfig writes a config.toml that passes configuration.Validate
|
||||
// while keeping the process minimal: the standalone binary takes its gRPC
|
||||
// listen address from -listen or [services.state].listen, never from the
|
||||
// target, so the config only needs the fields validation requires plus the
|
||||
// db_path it owns. The
|
||||
// forge token resolves from an env var, so no real credential is needed.
|
||||
func writeMinimalConfig(t *testing.T, dir string) string {
|
||||
t.Helper()
|
||||
cfg := filepath.Join(dir, "config.toml")
|
||||
content := fmt.Sprintf(`bot_user = "archie-bot"
|
||||
db_path = %q
|
||||
[forge]
|
||||
type = "github"
|
||||
host = "https://github.example.com"
|
||||
token = { engine = "env", key = "ARCHIE_GITHUB_TOKEN" }
|
||||
[[repos]]
|
||||
owner = "acme"
|
||||
name = "widget"
|
||||
`, filepath.Join(dir, "archie.db"))
|
||||
if err := os.WriteFile(cfg, []byte(content), 0o600); err != nil {
|
||||
t.Fatalf("write config: %v", err)
|
||||
}
|
||||
return cfg
|
||||
}
|
||||
|
||||
// writeConfigWithServiceListen is writeMinimalConfig plus the
|
||||
// [services.state] block that lets a test supply the listen address through
|
||||
// configuration instead of the -listen flag.
|
||||
func writeConfigWithServiceListen(t *testing.T, dir string) string {
|
||||
t.Helper()
|
||||
cfg := writeMinimalConfig(t, dir)
|
||||
f, err := os.OpenFile(cfg, os.O_APPEND|os.O_WRONLY, 0o600)
|
||||
if err != nil {
|
||||
t.Fatalf("open config to append: %v", err)
|
||||
}
|
||||
defer func() {
|
||||
if err := f.Close(); err != nil {
|
||||
t.Fatalf("close config: %v", err)
|
||||
}
|
||||
}()
|
||||
if _, err := f.WriteString("\n[services.state]\nlisten = \"127.0.0.1:0\"\n"); err != nil {
|
||||
t.Fatalf("append [services.state]: %v", err)
|
||||
}
|
||||
return cfg
|
||||
}
|
||||
|
||||
// syncBuffer is a concurrency-safe buffer for a subprocess's stdout/stderr:
|
||||
// the os/exec goroutine writes while the test goroutine reads (to parse the
|
||||
// log and to report it on failure). A plain strings.Builder races under
|
||||
// -race, so both paths take the mutex.
|
||||
type syncBuffer struct {
|
||||
mu sync.Mutex
|
||||
b bytes.Buffer
|
||||
}
|
||||
|
||||
func (s *syncBuffer) Write(p []byte) (int, error) {
|
||||
s.mu.Lock()
|
||||
defer s.mu.Unlock()
|
||||
return s.b.Write(p)
|
||||
}
|
||||
|
||||
func (s *syncBuffer) String() string {
|
||||
s.mu.Lock()
|
||||
defer s.mu.Unlock()
|
||||
return s.b.String()
|
||||
}
|
||||
|
||||
// stateStoreProcess wraps a running archie-state-store subprocess plus the
|
||||
// addresses it bound. addr is the gRPC listen address; readyAddr is the
|
||||
// readiness HTTP surface. It is stopped gracefully on cleanup by SIGTERM, the
|
||||
// signal the systemd unit ("Restart=on-failure") and the daemon use to drain
|
||||
// the server.
|
||||
type stateStoreProcess struct {
|
||||
cmd *exec.Cmd
|
||||
addr string
|
||||
readyAddr string
|
||||
log *syncBuffer
|
||||
}
|
||||
|
||||
// startStateStoreProcess starts bin with config, waiting for the gRPC listener
|
||||
// to come up and the readiness surface to answer /healthz. It parses the
|
||||
// binary's stderr log for the bound addresses because --listen 127.0.0.1:0
|
||||
// lets the process choose ephemeral ports, and the real address (not the
|
||||
// configured one) is what a consumer must dial.
|
||||
func startStateStoreProcess(t *testing.T, bin, cfg string) *stateStoreProcess {
|
||||
t.Helper()
|
||||
return startStateStore(t, bin, cfg, "127.0.0.1:0", "")
|
||||
}
|
||||
|
||||
// startStateStore is startStateStoreProcess with the listener topology and
|
||||
// bearer token exposed: the token-protected, non-loopback listener is the
|
||||
// topology every container-mode deployment profile uses
|
||||
// (docs/prds/state-store-contract.md §9), where the server installs the
|
||||
// credential interceptors on both the unary and the streaming surface.
|
||||
func startStateStore(t *testing.T, bin, cfg, listen, token string) *stateStoreProcess {
|
||||
t.Helper()
|
||||
args := []string{"-config", cfg, "-ready-addr", "127.0.0.1:0"}
|
||||
if listen != "" {
|
||||
// An empty listen means "pass no -listen at all". A test uses that to
|
||||
// prove the bound address came from [services.state].listen.
|
||||
args = append(args, "-listen", listen)
|
||||
}
|
||||
if token != "" {
|
||||
// An explicit -token wins over [services.state].target_token and the
|
||||
// STATE_STORE_TOKEN secret, so the process authenticates callers with
|
||||
// exactly this value.
|
||||
args = append(args, "-token", token)
|
||||
}
|
||||
cmd := exec.CommandContext(t.Context(), bin, args...)
|
||||
cmd.Env = append(os.Environ(), "ARCHIE_GITHUB_TOKEN=test-token")
|
||||
var log syncBuffer
|
||||
cmd.Stderr = &log
|
||||
cmd.Stdout = &log
|
||||
if err := cmd.Start(); err != nil {
|
||||
t.Fatalf("start state store: %v", err)
|
||||
}
|
||||
p := &stateStoreProcess{cmd: cmd, log: &log}
|
||||
t.Cleanup(func() { p.stop(t) })
|
||||
|
||||
// Recover the ephemeral ports from the JSON log lines the binary emits.
|
||||
deadline := time.Now().Add(15 * time.Second)
|
||||
for time.Now().Before(deadline) {
|
||||
if p.parseAddrs() {
|
||||
break
|
||||
}
|
||||
if cmd.ProcessState != nil {
|
||||
t.Fatalf("state store exited early:\n%s", log.String())
|
||||
}
|
||||
time.Sleep(25 * time.Millisecond)
|
||||
}
|
||||
if p.addr == "" || p.readyAddr == "" {
|
||||
t.Fatalf("did not recover bound addresses from log:\n%s", log.String())
|
||||
}
|
||||
|
||||
// The readiness surface is the liveness signal the runbook uses; poll it
|
||||
// until it answers (the gRPC listener may come up a tick ahead of it).
|
||||
deadline = time.Now().Add(15 * time.Second)
|
||||
req, err := http.NewRequestWithContext(t.Context(), http.MethodGet, "http://"+p.readyAddr+"/healthz", nil)
|
||||
if err != nil {
|
||||
t.Fatalf("build readiness request: %v", err)
|
||||
}
|
||||
for time.Now().Before(deadline) {
|
||||
if resp, err := http.DefaultClient.Do(req); err == nil {
|
||||
_ = resp.Body.Close()
|
||||
if resp.StatusCode == http.StatusOK {
|
||||
return p
|
||||
}
|
||||
}
|
||||
time.Sleep(25 * time.Millisecond)
|
||||
}
|
||||
t.Fatalf("readiness /healthz never became healthy:\n%s", log.String())
|
||||
return nil
|
||||
}
|
||||
|
||||
// parseAddrs scans the captured log for the bound gRPC and readiness
|
||||
// addresses. The binary logs "archie-state-store running" with the gRPC addr
|
||||
// and "state store readiness listening" with the HTTP addr.
|
||||
func (p *stateStoreProcess) parseAddrs() bool {
|
||||
if p.addr != "" && p.readyAddr != "" {
|
||||
return true
|
||||
}
|
||||
scanner := bufio.NewScanner(strings.NewReader(p.log.String()))
|
||||
for scanner.Scan() {
|
||||
line := scanner.Text()
|
||||
var rec map[string]any
|
||||
if err := json.Unmarshal([]byte(line), &rec); err != nil {
|
||||
continue
|
||||
}
|
||||
if msg, _ := rec["msg"].(string); msg == "archie-state-store running" {
|
||||
if addr, ok := rec["addr"].(string); ok && addr != "" && p.addr == "" {
|
||||
p.addr = addr
|
||||
}
|
||||
}
|
||||
if msg, _ := rec["msg"].(string); msg == "state store readiness listening" {
|
||||
if addr, ok := rec["addr"].(string); ok && addr != "" && p.readyAddr == "" {
|
||||
p.readyAddr = strings.TrimPrefix(addr, "http://")
|
||||
}
|
||||
}
|
||||
}
|
||||
return p.addr != "" && p.readyAddr != ""
|
||||
}
|
||||
|
||||
// stop drains the process with SIGTERM and waits for it to exit. This is the
|
||||
// same graceful-stop path serveStateStore's signal handling implements.
|
||||
func (p *stateStoreProcess) stop(t *testing.T) {
|
||||
t.Helper()
|
||||
if p.cmd.Process == nil {
|
||||
return
|
||||
}
|
||||
_ = p.cmd.Process.Signal(syscall.SIGTERM)
|
||||
done := make(chan struct{})
|
||||
go func() { _ = p.cmd.Wait(); close(done) }()
|
||||
select {
|
||||
case <-done:
|
||||
case <-time.After(10 * time.Second):
|
||||
_ = p.cmd.Process.Kill()
|
||||
<-done
|
||||
}
|
||||
}
|
||||
|
||||
// contract is the combined consumer surface a daemon/gateway/agent mixes: the
|
||||
// task lifecycle + events surface (store.TaskStore) and the capture surface.
|
||||
// Mapping/binding/dispatch is exercised separately in
|
||||
// TestStateStoreRealProcessRemoteSurfaces via the concrete Client, which
|
||||
// asserts against each narrow interface at compile time.
|
||||
type contract interface {
|
||||
store.TaskStore
|
||||
store.CaptureStore
|
||||
}
|
||||
|
||||
// dial opens a gRPC connection to the state store process and wraps it in the
|
||||
// remote contract adapter, exactly as the daemon/gateway/agent consumer does
|
||||
// (internal/infrastructure/staterpc.Client).
|
||||
func dial(t *testing.T, addr string) contract {
|
||||
t.Helper()
|
||||
conn, err := grpc.NewClient("passthrough:///"+addr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
||||
if err != nil {
|
||||
t.Fatalf("dial %s: %v", addr, err)
|
||||
}
|
||||
t.Cleanup(func() { _ = conn.Close() })
|
||||
return staterpc.NewClient(conn)
|
||||
}
|
||||
|
||||
// capture builds a CapturedEvent without pulling the whole store field set
|
||||
// into every call site.
|
||||
func capture(source, body string) store.CapturedEvent {
|
||||
return store.CapturedEvent{Source: source, Body: body, Authenticated: true}
|
||||
}
|
||||
|
||||
// TestStateStoreRealProcessSmoke exercises the actual archie-state-store
|
||||
// binary end-to-end: the combined task/event/capture view through one consumer
|
||||
// adapter, error-sentinel fidelity across the wire, the not-found-as-(nil,nil)
|
||||
// convention, and single-owner SQLite (the binary owns the one archie.db file
|
||||
// and the consumer dials gRPC without opening any store file).
|
||||
//
|
||||
// It also takes its listen address from [services.state].listen rather than
|
||||
// -listen, so the startup path every deployment uses is covered by the process
|
||||
// that exercises the most: before that key existed the address came from a flag
|
||||
// default with no config key, so a host whose port was already taken could
|
||||
// only be retargeted by passing -listen and
|
||||
// hand-writing an overlay whose target matched -- and the failure read as a
|
||||
// code fault, "address already in use" in the store and a gRPC handshake error
|
||||
// in every client.
|
||||
func TestStateStoreRealProcessSmoke(t *testing.T) {
|
||||
if testing.Short() {
|
||||
t.Skip("real-process smoke test builds and execs the binary; skip under -short")
|
||||
}
|
||||
dir := t.TempDir()
|
||||
bin := buildBinary(t, dir)
|
||||
cfg := writeConfigWithServiceListen(t, dir)
|
||||
st := startStateStore(t, bin, cfg, "", "")
|
||||
if st.addr == "" {
|
||||
t.Fatalf("no bound gRPC address in the log:\n%s", st.log.String())
|
||||
}
|
||||
if !strings.Contains(st.log.String(), `"listen":"127.0.0.1:0"`) {
|
||||
t.Fatalf("the resolved listen was not the configured address:\n%s", st.log.String())
|
||||
}
|
||||
cl := dial(t, st.addr)
|
||||
|
||||
ctx := t.Context()
|
||||
|
||||
// Combined task/event/capture view: a task, an event on that task, and an
|
||||
// unrelated capture written through one consumer, read back across all
|
||||
// three surfaces in a single pass (the dashboard/observability read path).
|
||||
task, err := cl.EnqueueChatTask(ctx, "acme", "widget", "verify state store", "body", "implement", "")
|
||||
if err != nil || task == nil {
|
||||
t.Fatalf("EnqueueChatTask = %+v, %v", task, err)
|
||||
}
|
||||
if err := cl.Transition(ctx, task.ID, task.Status, "running", "smoke started"); err != nil {
|
||||
t.Fatalf("Transition: %v", err)
|
||||
}
|
||||
if _, err := cl.InsertEvent(ctx, events.Event{Kind: "stage_finish", TaskID: task.ID, Attempt: 1, Data: map[string]any{"duration_ms": 12.0}}); err != nil {
|
||||
t.Fatalf("InsertEvent: %v", err)
|
||||
}
|
||||
// R4's document is stored as an event, so the real process must round-trip
|
||||
// it with its nested structure and its attempt key intact: the standalone
|
||||
// State Store owns the only copy, and a lost field here is a Config tab
|
||||
// that reads a run it cannot describe. The key is the daemon's own
|
||||
// (internal/daemon/daemon.go writes "document"), asserted by name below.
|
||||
if _, err := cl.InsertEvent(ctx, events.Event{
|
||||
Kind: events.KindConfigCaptured, TaskID: task.ID, Attempt: 1,
|
||||
Data: map[string]any{
|
||||
"schema": events.ConfigCapturedSchema,
|
||||
"document": map[string]any{"bot_user": "archie", "models": map[string]any{"implement": "anthropic/claude"}},
|
||||
},
|
||||
}); err != nil {
|
||||
t.Fatalf("InsertEvent config_captured: %v", err)
|
||||
}
|
||||
if capID, err := cl.InsertCapture(ctx, capture("sentry", `{"id":1}`), 0, 0); err != nil || capID == 0 {
|
||||
t.Fatalf("InsertCapture = (%d, %v)", capID, err)
|
||||
}
|
||||
|
||||
got, err := cl.TaskByID(ctx, task.ID)
|
||||
if err != nil || got == nil || got.ID != task.ID || got.Status != "running" {
|
||||
t.Fatalf("TaskByID after transition = %+v, %v", got, err)
|
||||
}
|
||||
evs, err := cl.TaskEvents(ctx, task.ID)
|
||||
if err != nil || len(evs) != 2 || evs[0].Kind != "stage_finish" {
|
||||
t.Fatalf("TaskEvents = %+v, %v", evs, err)
|
||||
}
|
||||
if evs[0].Attempt != 1 {
|
||||
t.Errorf("TaskEvents attempt = %d, want 1 across the real process", evs[0].Attempt)
|
||||
}
|
||||
if evs[1].Kind != events.KindConfigCaptured || evs[1].Attempt != 1 || evs[1].Data["schema"] != events.ConfigCapturedSchema {
|
||||
t.Errorf("config_captured event = %+v, want its kind, attempt and schema preserved", evs[1])
|
||||
}
|
||||
if _, renamed := evs[1].Data["config"]; renamed {
|
||||
t.Error(`the document crossed under "config"; the producer writes it under "document"`)
|
||||
}
|
||||
if len(evs[1].Data) != 2 {
|
||||
t.Errorf("config_captured data keys = %v, want exactly schema and document", evs[1].Data)
|
||||
}
|
||||
if doc, ok := evs[1].Data["document"].(map[string]any); !ok || doc["bot_user"] != "archie" {
|
||||
t.Errorf("config_captured payload = %#v, want the decoded document under its own key", evs[1].Data)
|
||||
}
|
||||
if caps, err := cl.ListCaptures(ctx, 10); err != nil || len(caps) != 1 || caps[0].Source != "sentry" {
|
||||
t.Fatalf("ListCaptures = %+v, %v", caps, err)
|
||||
}
|
||||
if counts, err := cl.StatusCounts(ctx); err != nil || counts["running"] != 1 {
|
||||
t.Fatalf("StatusCounts = %+v, %v", counts, err)
|
||||
}
|
||||
|
||||
t.Run("error_sentinel_fidelity", func(t *testing.T) {
|
||||
// A stale transition must rehydrate to store.ErrStaleTransition across
|
||||
// the wire (§7). Because the binary is up and we dialed it, a sentinel
|
||||
// mismatch here would surface as a transport error, so a pass proves
|
||||
// the gRPC mapError/unmapError round-trip, not just the in-process
|
||||
// adapter.
|
||||
err := cl.Transition(ctx, task.ID, "queued", "merged", "")
|
||||
if !errors.Is(err, store.ErrStaleTransition) {
|
||||
t.Fatalf("stale Transition = %v, want store.ErrStaleTransition", err)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("not_found_is_not_error", func(t *testing.T) {
|
||||
// Reading a missing task returns (nil, nil), never a NotFound gRPC
|
||||
// error (§7's found=false-not-error convention).
|
||||
missing, err := cl.TaskByID(ctx, task.ID+999999)
|
||||
if err != nil || missing != nil {
|
||||
t.Fatalf("TaskByID missing = (%+v, %v), want (nil, nil)", missing, err)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("single_owner_sqlite", func(t *testing.T) {
|
||||
// The binary owns one task SQLite file (db_path + "-tasks.sqlite");
|
||||
// the consumer called only gRPC methods and never opened a store file.
|
||||
// The config anchor path itself must not be opened directly (no dual
|
||||
// store ownership, §12 step 8).
|
||||
taskFile := filepath.Join(dir, "archie.db-tasks.sqlite")
|
||||
if _, err := os.Stat(taskFile); err != nil {
|
||||
t.Fatalf("state store did not own %s: %v", taskFile, err)
|
||||
}
|
||||
if _, err := os.Stat(filepath.Join(dir, "archie.db")); err == nil {
|
||||
t.Fatalf("config anchor path was opened directly; dual store ownership violated §12 step 8")
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
// TestStateStoreRealProcessDeadline verifies the per-call deadline behaviour
|
||||
// the state store contract requires (§6 StoreTimeout): a consumer context that
|
||||
// is cancelled before the call completes must surface a deadline/cancel error
|
||||
// rather than hang or silently succeed.
|
||||
func TestStateStoreRealProcessDeadline(t *testing.T) {
|
||||
if testing.Short() {
|
||||
t.Skip("real-process smoke test builds and execs the binary; skip under -short")
|
||||
}
|
||||
dir := t.TempDir()
|
||||
bin := buildBinary(t, dir)
|
||||
cfg := writeMinimalConfig(t, dir)
|
||||
st := startStateStoreProcess(t, bin, cfg)
|
||||
cl := dial(t, st.addr)
|
||||
|
||||
ctx, cancel := context.WithCancel(t.Context())
|
||||
cancel()
|
||||
_, err := cl.StatusCounts(ctx)
|
||||
if err == nil {
|
||||
t.Fatal("StatusCounts on a cancelled context returned nil; expected a deadline/cancel error")
|
||||
}
|
||||
if !errors.Is(err, context.Canceled) && !errors.Is(err, context.DeadlineExceeded) {
|
||||
t.Fatalf("StatusCounts cancelled = %v, want context.Canceled or DeadlineExceeded", err)
|
||||
}
|
||||
}
|
||||
|
||||
// TestStateStoreRealProcessRestartRecovery starts the process, writes a task,
|
||||
// stops it (SIGTERM), restarts it on the same config/db_path, and verifies the
|
||||
// task and its events were recovered from the on-disk SQLite -- the
|
||||
// restart/recovery path the runbook relies on when archie-state-store is
|
||||
// restarted as a service.
|
||||
func TestStateStoreRealProcessRestartRecovery(t *testing.T) {
|
||||
if testing.Short() {
|
||||
t.Skip("real-process smoke test builds and execs the binary; skip under -short")
|
||||
}
|
||||
dir := t.TempDir()
|
||||
bin := buildBinary(t, dir)
|
||||
cfg := writeMinimalConfig(t, dir)
|
||||
|
||||
first := startStateStoreProcess(t, bin, cfg)
|
||||
s1 := dial(t, first.addr)
|
||||
task, err := s1.EnqueueChatTask(t.Context(), "acme", "widget", "survive restart", "body", "implement", "")
|
||||
if err != nil || task == nil {
|
||||
t.Fatalf("first EnqueueChatTask = %+v, %v", task, err)
|
||||
}
|
||||
if _, err := s1.InsertEvent(t.Context(), events.Event{Kind: "run_started", TaskID: task.ID}); err != nil {
|
||||
t.Fatalf("first InsertEvent: %v", err)
|
||||
}
|
||||
first.stop(t)
|
||||
|
||||
// Restart on the same config; the SQLite file persists on disk.
|
||||
second := startStateStoreProcess(t, bin, cfg)
|
||||
s2 := dial(t, second.addr)
|
||||
|
||||
got, err := s2.TaskByID(t.Context(), task.ID)
|
||||
if err != nil || got == nil || got.Title != "survive restart" {
|
||||
t.Fatalf("TaskByID after restart = %+v, %v", got, err)
|
||||
}
|
||||
if evs, err := s2.TaskEvents(t.Context(), task.ID); err != nil || len(evs) != 1 {
|
||||
t.Fatalf("TaskEvents after restart = %+v, %v", evs, err)
|
||||
}
|
||||
// Stale-running work reopened on a fresh process is recovered by
|
||||
// RecoverStale, which must return without error on the restarted store.
|
||||
if _, err := s2.RecoverStale(t.Context()); err != nil {
|
||||
t.Fatalf("RecoverStale after restart: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
// TestStateStoreRealProcessTokenProtectedCaptureStream is the capture-batch
|
||||
// regression against the real binary: the token-protected, non-loopback
|
||||
// listener topology a container-mode deployment uses, read through the
|
||||
// production client wiring (staterpc.Dial) the daemon and the dashboard both
|
||||
// use. The reads the batch needs are server-streaming RPCs, whose metadata
|
||||
// the unary-only client interceptor never saw -- so before the fix this
|
||||
// failed with PermissionDenied, and no unary fallback existed to take. 20 x
|
||||
// 256 KiB is 5 MiB, past gRPC's 4 MiB unary cap, so the batch also proves the
|
||||
// streams still carry it.
|
||||
func TestStateStoreRealProcessTokenProtectedCaptureStream(t *testing.T) {
|
||||
if testing.Short() {
|
||||
t.Skip("real-process smoke test builds and execs the binary; skip under -short")
|
||||
}
|
||||
const token = "operator-secret-token"
|
||||
dir := t.TempDir()
|
||||
bin := buildBinary(t, dir)
|
||||
cfg := writeMinimalConfig(t, dir)
|
||||
st := startStateStore(t, bin, cfg, "0.0.0.0:0", token)
|
||||
|
||||
// The listener advertises the wildcard address it bound; a consumer dials
|
||||
// the host address it can reach, which is this host's loopback.
|
||||
_, port, err := net.SplitHostPort(st.addr)
|
||||
if err != nil {
|
||||
t.Fatalf("parse bound address %q: %v", st.addr, err)
|
||||
}
|
||||
cl, cleanup, err := staterpc.Dial("127.0.0.1:"+port, token)
|
||||
if err != nil {
|
||||
t.Fatalf("dial token-protected state store: %v", err)
|
||||
}
|
||||
t.Cleanup(cleanup)
|
||||
|
||||
ctx := t.Context()
|
||||
body := strings.Repeat("x", 256<<10)
|
||||
for range 20 {
|
||||
if _, err := cl.InsertCapture(ctx, capture("large", body), 0, 0); err != nil {
|
||||
t.Fatalf("InsertCapture: %v", err)
|
||||
}
|
||||
}
|
||||
captures, err := cl.ListCaptures(ctx, 20)
|
||||
if err != nil {
|
||||
t.Fatalf("ListCaptures over a token-protected listener: %v", err)
|
||||
}
|
||||
if len(captures) != 20 {
|
||||
t.Fatalf("got %d captures, want 20", len(captures))
|
||||
}
|
||||
for _, c := range captures {
|
||||
if c.Body != body {
|
||||
t.Fatal("capture body truncated")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// TestStateStoreRealProcessRemoteSurfaces exercises the capture/mapping/
|
||||
// binding surfaces the standalone process fronts (the daemon/webui surfaces
|
||||
// swapped to the adapter in .4.4/.4.5), proving one process serves the full
|
||||
// combined contract a consumer mixes.
|
||||
func TestStateStoreRealProcessRemoteSurfaces(t *testing.T) {
|
||||
if testing.Short() {
|
||||
t.Skip("real-process smoke test builds and execs the binary; skip under -short")
|
||||
}
|
||||
dir := t.TempDir()
|
||||
bin := buildBinary(t, dir)
|
||||
cfg := writeMinimalConfig(t, dir)
|
||||
st := startStateStoreProcess(t, bin, cfg)
|
||||
|
||||
conn, err := grpc.NewClient("passthrough:///"+st.addr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
||||
if err != nil {
|
||||
t.Fatalf("dial: %v", err)
|
||||
}
|
||||
t.Cleanup(func() { _ = conn.Close() })
|
||||
cl := staterpc.NewClient(conn)
|
||||
|
||||
ctx := t.Context()
|
||||
mappingID, err := cl.InsertMapping(ctx, mapping.Mapping{Name: "m1", Fields: []mapping.Field{{Name: "a", Path: "a", Type: mapping.TypeString}}})
|
||||
if err != nil || mappingID == 0 {
|
||||
t.Fatalf("InsertMapping = (%d, %v)", mappingID, err)
|
||||
}
|
||||
if got, err := cl.GetMapping(ctx, mappingID); err != nil || got == nil || got.Name != "m1" {
|
||||
t.Fatalf("GetMapping = %+v, %v", got, err)
|
||||
}
|
||||
bindingID, err := cl.InsertBinding(ctx, binding.Binding{
|
||||
Name: "b1", Matcher: binding.Matcher{Source: "sentry"}, MappingID: mappingID,
|
||||
Workflow: "implement", Secret: "0123456789abcdef0123456789abcdef",
|
||||
})
|
||||
if err != nil || bindingID == 0 {
|
||||
t.Fatalf("InsertBinding = (%d, %v)", bindingID, err)
|
||||
}
|
||||
// A binding starts as draft and must be edited (draft -> pending_approval)
|
||||
// then approved (pending_approval -> armed) before it is armed for a
|
||||
// source. Drive the state machine so ArmedBindingsForSource returns it.
|
||||
if err := cl.UpdateBinding(ctx, binding.Binding{
|
||||
ID: bindingID, Name: "b1", Matcher: binding.Matcher{Source: "sentry"},
|
||||
MappingID: mappingID, Workflow: "implement", Owner: "acme", Repo: "widget",
|
||||
Secret: "0123456789abcdef0123456789abcdef",
|
||||
}); err != nil {
|
||||
t.Fatalf("UpdateBinding: %v", err)
|
||||
}
|
||||
if err := cl.ApproveBinding(ctx, bindingID); err != nil {
|
||||
t.Fatalf("ApproveBinding: %v", err)
|
||||
}
|
||||
if armed, err := cl.ArmedBindingsForSource(ctx, "sentry"); err != nil || len(armed) != 1 || armed[0].ID != bindingID {
|
||||
t.Fatalf("ArmedBindingsForSource = %+v, %v", armed, err)
|
||||
}
|
||||
// Remote surfaces share error-sentinel fidelity on the wire too.
|
||||
missing := mapping.Mapping{ID: mappingID + 999999, Name: "x", Fields: []mapping.Field{{Name: "a", Path: "a", Type: mapping.TypeString}}}
|
||||
if err := cl.UpdateMapping(ctx, missing); !errors.Is(err, store.ErrMappingNotFound) {
|
||||
t.Fatalf("UpdateMapping missing = %v, want ErrMappingNotFound", err)
|
||||
}
|
||||
}
|
||||
@@ -7,30 +7,39 @@ import (
|
||||
"fmt"
|
||||
"io"
|
||||
|
||||
"github.com/samcharles93/archie-core/internal/app/archied"
|
||||
"github.com/samcharles93/archie-core/internal/app/statestore"
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/configuration"
|
||||
)
|
||||
|
||||
// recoveryUsage is the whole flag surface of the offline recovery commands.
|
||||
// They are subcommands of this binary rather than a recovery binary of their
|
||||
// own: offline database maintenance belongs to the process that owns the file
|
||||
// and its path layout (docs/architecture/organisation.md#process-boundaries).
|
||||
// and its path layout.
|
||||
const recoveryUsage = `usage: archie-state-store <command> [flags]
|
||||
|
||||
With no command, archie-state-store serves the State Store gRPC contract.
|
||||
|
||||
The recovery commands operate on the task database file directly -- the
|
||||
configured db_path with "-tasks.sqlite" appended -- and are how an operator
|
||||
recovers a database the control plane will not start on. Stop the State Store
|
||||
first: restore and rollback rewrite the file and refuse while another process
|
||||
owns it, while backup takes a consistent snapshot of a serving store.
|
||||
The recovery commands are how an operator recovers a database the control
|
||||
plane will not start on. They operate on the PostgreSQL database the
|
||||
configuration's database_url names, through pg_dump and pg_restore (which
|
||||
must be on PATH).
|
||||
|
||||
backup -db FILE -out FILE write a snapshot of the database
|
||||
restore -db FILE -from FILE replace the database with a snapshot
|
||||
validate -db FILE [-config FILE] check the file, its stored settings and the
|
||||
configuration the daemon would boot with
|
||||
rollback -db FILE -kind KIND replay an earlier revision of a stored
|
||||
backup takes a consistent snapshot of a serving database. restore is
|
||||
destructive and offline: stop every archie service first, since it refuses
|
||||
while any of them holds its ownership claim, and every write made after the
|
||||
snapshot is lost. rollback refuses while the State Store serves. There is no
|
||||
automatic schema rollback: the way back from a migration is restoring the
|
||||
snapshot taken before it.
|
||||
|
||||
backup -out FILE write a snapshot of the database
|
||||
restore -from FILE replace the database with a snapshot
|
||||
validate check the database, its stored settings and
|
||||
the configuration the daemon would boot with
|
||||
rollback -kind KIND replay an earlier revision of a stored
|
||||
[-revision N] resource through the ordinary replace
|
||||
|
||||
Every command takes -config FILE and -config-overlay FILE: the configuration
|
||||
the daemon boots with, which names the database.
|
||||
`
|
||||
|
||||
// runRecovery parses and performs one offline recovery command, reporting the
|
||||
@@ -42,9 +51,9 @@ func runRecovery(args []string, stdout, stderr io.Writer) int {
|
||||
return 2
|
||||
}
|
||||
command := args[0]
|
||||
options := archied.StateStoreRecoveryOptions{Operation: command}
|
||||
options := statestore.RecoveryOptions{Operation: command}
|
||||
switch command {
|
||||
case archied.RecoveryBackup, archied.RecoveryRestore, archied.RecoveryValidate, archied.RecoveryRollback:
|
||||
case statestore.RecoveryBackup, statestore.RecoveryRestore, statestore.RecoveryValidate, statestore.RecoveryRollback:
|
||||
default:
|
||||
fmt.Fprintf(stderr, "archie-state-store: unknown command %q\n\n", command)
|
||||
fmt.Fprint(stderr, recoveryUsage)
|
||||
@@ -54,17 +63,14 @@ func runRecovery(args []string, stdout, stderr io.Writer) int {
|
||||
flags := flag.NewFlagSet("archie-state-store "+command, flag.ContinueOnError)
|
||||
flags.SetOutput(stderr)
|
||||
flags.Usage = func() { fmt.Fprint(stderr, recoveryUsage) }
|
||||
flags.StringVar(&options.DB, "db", "", "task database file the State Store owns (<db_path>-tasks.sqlite)")
|
||||
flags.StringVar(&options.Out, "out", "", "snapshot file backup writes")
|
||||
flags.StringVar(&options.From, "from", "", "snapshot file restore reads")
|
||||
flags.StringVar(&options.Kind, "kind", "", "control-plane resource kind rollback replays")
|
||||
flags.Int64Var(&options.Revision, "revision", 0, "revision rollback replays (default: the newest one older than the current value)")
|
||||
// Only validate asks a question about the process rather than the file, so
|
||||
// only validate takes the configuration the process would boot with.
|
||||
if command == archied.RecoveryValidate {
|
||||
flags.StringVar(&options.Config, "config", configuration.DefaultConfigPath(), "configuration file or directory the daemon boots with")
|
||||
flags.StringVar(&options.Overlay, "config-overlay", "", "configuration overlay file or directory")
|
||||
}
|
||||
// The configuration names the PostgreSQL database, and validate also checks
|
||||
// the stored settings against it.
|
||||
flags.StringVar(&options.Config, "config", configuration.DefaultConfigPath(), "configuration file or directory the daemon boots with")
|
||||
flags.StringVar(&options.Overlay, "config-overlay", "", "configuration overlay file or directory")
|
||||
if err := flags.Parse(args[1:]); err != nil {
|
||||
// A requested help is not a wrong command line: the usage above is the
|
||||
// answer, and the serve path exits 0 for the same request.
|
||||
@@ -78,7 +84,7 @@ func runRecovery(args []string, stdout, stderr io.Writer) int {
|
||||
return 2
|
||||
}
|
||||
|
||||
summary, err := archied.RunStateStoreRecovery(context.Background(), options)
|
||||
summary, err := statestore.RunRecovery(context.Background(), options)
|
||||
if err != nil {
|
||||
fmt.Fprintf(stderr, "archie-state-store %s: %v\n", command, err)
|
||||
return 1
|
||||
|
||||
@@ -1,809 +0,0 @@
|
||||
// Package main tests the offline recovery subcommands of archie-state-store:
|
||||
// backup, restore, validate and rollback against the task database file
|
||||
// directly. They are the operator's only path back when the control plane's
|
||||
// stored settings will not validate, because the daemon fails closed: the
|
||||
// in-band remedy (replay an earlier revision while the State Store is up) is
|
||||
// unavailable in exactly the case that needs it.
|
||||
//
|
||||
// The tests drive the subcommands the way an operator does -- through
|
||||
// runRecovery, against real files on disk -- rather than through the internal
|
||||
// helpers, so the flag surface and the exit codes are part of what is verified.
|
||||
|
||||
package main
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"database/sql"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"strconv"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
_ "modernc.org/sqlite"
|
||||
|
||||
"github.com/samcharles93/archie-core/internal/app/archied"
|
||||
"github.com/samcharles93/archie-core/internal/app/controlplane"
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/configuration"
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/workflowsteps"
|
||||
"github.com/samcharles93/archie-core/internal/store"
|
||||
)
|
||||
|
||||
// runRecoveryCmd runs one subcommand the way main does and returns its exit
|
||||
// code with both streams captured.
|
||||
func runRecoveryCmd(t *testing.T, args ...string) (int, string, string) {
|
||||
t.Helper()
|
||||
var stdout, stderr bytes.Buffer
|
||||
code := runRecovery(args, &stdout, &stderr)
|
||||
return code, stdout.String(), stderr.String()
|
||||
}
|
||||
|
||||
// openTaskStore opens the task database the subcommands operate on. It does not
|
||||
// take the ownership lock: only the serving process does that, and a test that
|
||||
// wants a "live" store holds it explicitly with holdStoreOwnership.
|
||||
func openTaskStore(t *testing.T, path string) *store.Store {
|
||||
t.Helper()
|
||||
st, err := store.Open(t.Context(), path)
|
||||
if err != nil {
|
||||
t.Fatalf("open task store %s: %v", path, err)
|
||||
}
|
||||
t.Cleanup(func() { _ = st.Close() })
|
||||
return st
|
||||
}
|
||||
|
||||
// holdStoreOwnership takes the ownership lock the running State Store holds for
|
||||
// its whole life, so a test can prove a command refuses to touch a live store.
|
||||
func holdStoreOwnership(t *testing.T, path string) {
|
||||
t.Helper()
|
||||
ownership, err := store.AcquireOwnership(path)
|
||||
if err != nil {
|
||||
t.Fatalf("acquire store ownership: %v", err)
|
||||
}
|
||||
t.Cleanup(func() { _ = ownership.Release() })
|
||||
}
|
||||
|
||||
// seedTask writes one task so a snapshot can be distinguished from the live
|
||||
// database by what it contains, not merely by its existence.
|
||||
func seedTask(t *testing.T, st *store.Store, title string) {
|
||||
t.Helper()
|
||||
if _, err := st.EnqueueChatTask(t.Context(), "acme", "widget", title, "body", "implement", ""); err != nil {
|
||||
t.Fatalf("seed task %q: %v", title, err)
|
||||
}
|
||||
}
|
||||
|
||||
func taskTitles(t *testing.T, path string) []string {
|
||||
t.Helper()
|
||||
st := openTaskStore(t, path)
|
||||
tasks, err := st.Tasks(t.Context(), 100)
|
||||
if err != nil {
|
||||
t.Fatalf("list tasks in %s: %v", path, err)
|
||||
}
|
||||
titles := make([]string, 0, len(tasks))
|
||||
for _, task := range tasks {
|
||||
titles = append(titles, task.Title)
|
||||
}
|
||||
return titles
|
||||
}
|
||||
|
||||
// backupPath is the snapshot every restore test restores from.
|
||||
func backupPath(t *testing.T, dir string) string { return filepath.Join(dir, "snapshot.sqlite") }
|
||||
|
||||
// backup takes the snapshot the caller then restores, through the subcommand
|
||||
// under test rather than through the store directly, so a broken backup fails
|
||||
// the restore test too instead of silently passing an empty file.
|
||||
func backup(t *testing.T, db, out string) {
|
||||
t.Helper()
|
||||
code, _, stderr := runRecoveryCmd(t, "backup", "-db", db, "-out", out)
|
||||
if code != 0 {
|
||||
t.Fatalf("backup exited %d: %s", code, stderr)
|
||||
}
|
||||
}
|
||||
|
||||
// The update installer cannot stop the process that runs it, so it backs the
|
||||
// task database up while the State Store is serving. VACUUM INTO is safe
|
||||
// against a live writer; a backup that insisted on an exclusively-owned file
|
||||
// would break the one caller it has, and the update would refuse to start.
|
||||
func TestRecoveryBackupSnapshotsAStoreItsStateStoreIsServing(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
db := filepath.Join(dir, "archie.db-tasks.sqlite")
|
||||
out := backupPath(t, dir)
|
||||
seedTask(t, openTaskStore(t, db), "before")
|
||||
holdStoreOwnership(t, db)
|
||||
if err := os.WriteFile(out, []byte("stale snapshot"), 0o600); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
code, stdout, stderr := runRecoveryCmd(t, "backup", "-db", db, "-out", out)
|
||||
if code != 0 {
|
||||
t.Fatalf("backup exited %d: %s", code, stderr)
|
||||
}
|
||||
if !strings.Contains(stdout, out) || !strings.Contains(stdout, db) {
|
||||
t.Errorf("backup must report the database and the snapshot it wrote; stdout = %q", stdout)
|
||||
}
|
||||
// The stale file was replaced by a real snapshot, and the snapshot is a
|
||||
// store a restore can put back: same rows, readable through the store.
|
||||
if got := taskTitles(t, out); len(got) != 1 || got[0] != "before" {
|
||||
t.Fatalf("snapshot tasks = %v, want the one seeded task", got)
|
||||
}
|
||||
if entries, err := filepath.Glob(out + ".tmp*"); err != nil || len(entries) != 0 {
|
||||
t.Errorf("backup left scratch files beside the snapshot: %v (%v)", entries, err)
|
||||
}
|
||||
}
|
||||
|
||||
// The snapshot is the rollback state, so an interrupted backup must never
|
||||
// leave a truncated file where a good snapshot was.
|
||||
func TestRecoveryBackupRefusesAMissingDatabase(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
code, _, stderr := runRecoveryCmd(t, "backup", "-db", filepath.Join(dir, "absent.sqlite"), "-out", backupPath(t, dir))
|
||||
if code == 0 {
|
||||
t.Fatal("backup of a missing database succeeded")
|
||||
}
|
||||
if !strings.Contains(stderr, "absent.sqlite") {
|
||||
t.Errorf("refusal must name the database it could not read; stderr = %q", stderr)
|
||||
}
|
||||
}
|
||||
|
||||
// backup is the one recovery command allowed to run against a serving store,
|
||||
// and that exemption is only sound while it never replaces the database. With
|
||||
// -out naming the database it renames the snapshot over the live file and
|
||||
// leaves the WAL of the database it just unlinked -- the state the restore path
|
||||
// refuses up front and the code elsewhere calls unrecoverable.
|
||||
func TestRecoveryBackupRefusesTheDatabaseAsItsOwnSnapshot(t *testing.T) {
|
||||
db := filepath.Join(t.TempDir(), "archie.db-tasks.sqlite")
|
||||
st := openTaskStore(t, db)
|
||||
seedTask(t, st, "live")
|
||||
|
||||
code, _, stderr := runRecoveryCmd(t, "backup", "-db", db, "-out", db)
|
||||
if code == 0 {
|
||||
t.Fatal("backup over the database itself succeeded")
|
||||
}
|
||||
if !strings.Contains(stderr, "is the database itself") {
|
||||
t.Errorf("refusal must say the snapshot is the database; stderr = %q", stderr)
|
||||
}
|
||||
if got := taskTitles(t, db); len(got) != 1 || got[0] != "live" {
|
||||
t.Fatalf("refused backup changed the database: tasks = %v", got)
|
||||
}
|
||||
}
|
||||
|
||||
// Restoring is the forward-migration escape hatch: the previous release
|
||||
// reads this file, so it must be exactly the snapshot, with the WAL that
|
||||
// belongs to the replaced database gone rather than replayed over it.
|
||||
func TestRecoveryRestorePutsTheSnapshotBackAndDropsItsWAL(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
db := filepath.Join(dir, "archie.db-tasks.sqlite")
|
||||
out := backupPath(t, dir)
|
||||
st := openTaskStore(t, db)
|
||||
seedTask(t, st, "before")
|
||||
backup(t, db, out)
|
||||
seedTask(t, st, "after")
|
||||
|
||||
code, stdout, stderr := runRecoveryCmd(t, "restore", "-db", db, "-from", out)
|
||||
if code != 0 {
|
||||
t.Fatalf("restore exited %d: %s", code, stderr)
|
||||
}
|
||||
if !strings.Contains(stdout, out) {
|
||||
t.Errorf("restore must report the snapshot it restored from; stdout = %q", stdout)
|
||||
}
|
||||
// Checked before anything reopens the database: opening a store sets WAL
|
||||
// mode, which creates these files, so the point is that the restore did not
|
||||
// leave the replaced database's log behind -- not that a later reader
|
||||
// cannot recreate its own.
|
||||
for _, suffix := range []string{"-wal", "-shm"} {
|
||||
if _, err := os.Stat(db + suffix); err == nil {
|
||||
t.Errorf("%s survived the restore: the replaced database's write-ahead log must not be replayed over the snapshot", db+suffix)
|
||||
}
|
||||
}
|
||||
if got := taskTitles(t, db); len(got) != 1 || got[0] != "before" {
|
||||
t.Fatalf("restored tasks = %v, want only the snapshot's task", got)
|
||||
}
|
||||
}
|
||||
|
||||
// Overwriting a database a running State Store still owns leaves that process
|
||||
// writing to an unlinked inode while the store serves a file nobody owns --
|
||||
// the one way an offline command can destroy a task store.
|
||||
func TestRecoveryRestoreRefusesAStoreTheStateStoreIsRunning(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
db := filepath.Join(dir, "archie.db-tasks.sqlite")
|
||||
out := backupPath(t, dir)
|
||||
st := openTaskStore(t, db)
|
||||
seedTask(t, st, "before")
|
||||
backup(t, db, out)
|
||||
seedTask(t, st, "after")
|
||||
holdStoreOwnership(t, db)
|
||||
|
||||
code, _, stderr := runRecoveryCmd(t, "restore", "-db", db, "-from", out)
|
||||
if code == 0 {
|
||||
t.Fatal("restore against a live State Store succeeded")
|
||||
}
|
||||
if !strings.Contains(stderr, "owned by another process") {
|
||||
t.Errorf("refusal must say the database is owned by another process; stderr = %q", stderr)
|
||||
}
|
||||
if got := taskTitles(t, db); len(got) != 2 {
|
||||
t.Fatalf("refused restore changed the database: tasks = %v", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRecoveryRestoreRefusesAFileThatIsNotAStore(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
db := filepath.Join(dir, "archie.db-tasks.sqlite")
|
||||
seedTask(t, openTaskStore(t, db), "live")
|
||||
notAStore := filepath.Join(dir, "notes.txt")
|
||||
if err := os.WriteFile(notAStore, []byte("this is not a database"), 0o600); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
code, _, stderr := runRecoveryCmd(t, "restore", "-db", db, "-from", notAStore)
|
||||
if code == 0 {
|
||||
t.Fatal("restore from a file that is not a store succeeded")
|
||||
}
|
||||
if !strings.Contains(stderr, notAStore) {
|
||||
t.Errorf("refusal must name the snapshot it could not read; stderr = %q", stderr)
|
||||
}
|
||||
if got := taskTitles(t, db); len(got) != 1 {
|
||||
t.Fatalf("refused restore changed the database: tasks = %v", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRecoveryRestoreRefusesTheDatabaseAsItsOwnSnapshot(t *testing.T) {
|
||||
// Restoring a database from itself would delete the write-ahead log of the
|
||||
// file it is about to copy, so the one case that must never reach the swap
|
||||
// is refused up front.
|
||||
db := filepath.Join(t.TempDir(), "archie.db-tasks.sqlite")
|
||||
seedTask(t, openTaskStore(t, db), "live")
|
||||
|
||||
code, _, stderr := runRecoveryCmd(t, "restore", "-db", db, "-from", db)
|
||||
if code == 0 {
|
||||
t.Fatal("restore from the database itself succeeded")
|
||||
}
|
||||
if !strings.Contains(stderr, "is the database itself") {
|
||||
t.Errorf("refusal must say the snapshot is the database; stderr = %q", stderr)
|
||||
}
|
||||
if got := taskTitles(t, db); len(got) != 1 {
|
||||
t.Fatalf("refused restore changed the database: tasks = %v", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRecoveryValidateAcceptsAHealthyStore(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
configPath := writeMinimalConfig(t, dir)
|
||||
db := filepath.Join(dir, "archie.db-tasks.sqlite")
|
||||
st := openTaskStore(t, db)
|
||||
seedTask(t, st, "healthy")
|
||||
seedStoreResources(t, st, configPath)
|
||||
|
||||
code, stdout, stderr := runRecoveryCmd(t, "validate", "-db", db, "-config", configPath)
|
||||
if code != 0 {
|
||||
t.Fatalf("validate exited %d: %s", code, stderr)
|
||||
}
|
||||
if !strings.Contains(stdout, "schema version") {
|
||||
t.Errorf("validate must report the schema version it verified; stdout = %q", stdout)
|
||||
}
|
||||
// The count is part of what the operator reads, and a check that reports
|
||||
// "0 stored resources" for a store full of them is worse than no check.
|
||||
if count := storedResourceCount(t, stdout); count == 0 {
|
||||
t.Errorf("validate reported no stored resources for a seeded store; stdout = %q", stdout)
|
||||
}
|
||||
}
|
||||
|
||||
// validate's verdict is only useful if it is the daemon's verdict. Boot refuses
|
||||
// on configuration.Validate over the file config with every stored resource
|
||||
// layered onto it (internal/app/archied/control_plane.go), not on the write
|
||||
// path's own per-resource decode, and the two disagree: the write path accepts
|
||||
// a scheduling policy boot rejects.
|
||||
func TestRecoveryValidateRunsTheGateBootRuns(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
configPath := writeMinimalConfig(t, dir)
|
||||
db := filepath.Join(dir, "archie.db-tasks.sqlite")
|
||||
seedStoreResources(t, openTaskStore(t, db), configPath)
|
||||
|
||||
// The control: a store seeded from this config is one the daemon boots on.
|
||||
code, _, stderr := runRecoveryCmd(t, "validate", "-db", db, "-config", configPath)
|
||||
if code != 0 {
|
||||
t.Fatalf("validate exited %d on a store the daemon starts on: %s", code, stderr)
|
||||
}
|
||||
|
||||
// A hand-edited value, or an older revision of one: the write path's own
|
||||
// validator never inspects dispatch.trigger, so only the config gate
|
||||
// catches it, and the daemon exits 1 on it (validateDispatch).
|
||||
if err := execRaw(t, db, `UPDATE resources SET value='{"poll_interval":"1m","max_retries":3,"dispatch":{"trigger":"bogus"}}' WHERE kind='scheduling-policy'`); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
code, stdout, stderr := runRecoveryCmd(t, "validate", "-db", db, "-config", configPath)
|
||||
if code == 0 {
|
||||
t.Fatalf("validate accepted a stored policy the daemon refuses to boot with; stdout = %q", stdout)
|
||||
}
|
||||
if !strings.Contains(stderr, "dispatch.trigger") {
|
||||
t.Errorf("refusal must name what boot rejects; stderr = %q", stderr)
|
||||
}
|
||||
|
||||
// A store the State Store never seeded holds no kinds at all. Its next start
|
||||
// creates the resources table and seeds every kind from this same config
|
||||
// (internal/app/archied/state_store.go), so archied layers those seeds and
|
||||
// starts: refusing the file here would send an operator to restore a
|
||||
// snapshot for a store the daemon boots on perfectly well.
|
||||
unseeded := filepath.Join(dir, "unseeded.db-tasks.sqlite")
|
||||
openTaskStore(t, unseeded)
|
||||
code, stdout, stderr = runRecoveryCmd(t, "validate", "-db", unseeded, "-config", configPath)
|
||||
if code != 0 {
|
||||
t.Fatalf("validate refused a store the State Store would seed on its next start; stderr = %q", stderr)
|
||||
}
|
||||
if !strings.Contains(stdout, "0 stored resources validate") {
|
||||
t.Errorf("validate must report that there was nothing stored to check; stdout = %q", stdout)
|
||||
}
|
||||
|
||||
// The upgrade case: a release defines a kind the store does not hold yet,
|
||||
// and validate runs before the State Store has started again. The State
|
||||
// Store seeds the kind it is missing, so this is the same stance as the
|
||||
// store with nothing stored at all -- the file is not the reason the daemon
|
||||
// would refuse to start, and saying otherwise costs the operator a snapshot.
|
||||
partial := filepath.Join(dir, "partial.db-tasks.sqlite")
|
||||
seedStoreResources(t, openTaskStore(t, partial), configPath)
|
||||
if err := execRaw(t, partial, `DELETE FROM resources WHERE kind='provider-settings'`); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
code, stdout, stderr = runRecoveryCmd(t, "validate", "-db", partial, "-config", configPath)
|
||||
if code != 0 {
|
||||
t.Fatalf("validate refused a store missing a kind the State Store seeds; stderr = %q", stderr)
|
||||
}
|
||||
if count := storedResourceCount(t, stdout); count == 0 {
|
||||
t.Errorf("validate must still check the kinds the store does hold; stdout = %q", stdout)
|
||||
}
|
||||
}
|
||||
|
||||
// The subcommands advertise -h as the way to read their flags, and the serve
|
||||
// path in the same binary exits 0 for the same request, so a script probing the
|
||||
// recovery surface must not read a requested help as a failure.
|
||||
func TestRecoveryHelpExitsZero(t *testing.T) {
|
||||
commands := []string{archied.RecoveryBackup, archied.RecoveryRestore, archied.RecoveryValidate, archied.RecoveryRollback}
|
||||
for _, command := range commands {
|
||||
code, _, stderr := runRecoveryCmd(t, command, "-h")
|
||||
if code != 0 {
|
||||
t.Errorf("%s -h exited %d, want 0; stderr = %q", command, code, stderr)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// validate diagnoses a deployment; it is not the deployment. Resolving the boot
|
||||
// config must not create, append to, or rotate the daemon's log file or the
|
||||
// directory it lives in: a line stamped component="daemon" in archied's log is
|
||||
// indistinguishable from the daemon having written it.
|
||||
func TestRecoveryValidateLeavesTheDaemonLogAlone(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
configPath, logFile := writeConfigWithLogFile(t, dir)
|
||||
db := filepath.Join(dir, "archie.db-tasks.sqlite")
|
||||
seedStoreResources(t, openTaskStore(t, db), configPath)
|
||||
|
||||
code, _, stderr := runRecoveryCmd(t, "validate", "-db", db, "-config", configPath)
|
||||
if code != 0 {
|
||||
t.Fatalf("validate exited %d: %s", code, stderr)
|
||||
}
|
||||
if _, err := os.Stat(logFile); !os.IsNotExist(err) {
|
||||
t.Fatalf("validate touched the daemon's log file %s (stat err = %v)", logFile, err)
|
||||
}
|
||||
if _, err := os.Stat(filepath.Dir(logFile)); !os.IsNotExist(err) {
|
||||
t.Errorf("validate created the log directory %s (stat err = %v)", filepath.Dir(logFile), err)
|
||||
}
|
||||
}
|
||||
|
||||
// validate's verdict is the daemon's verdict only if it reads the configuration
|
||||
// the daemon reads, and with no -config it reads whatever the one shared
|
||||
// helper resolves. The resolution rule itself is pinned where it lives
|
||||
// (internal/infrastructure/configuration); what only this test can pin is that
|
||||
// the command takes its default from that helper rather than deriving it.
|
||||
//
|
||||
// A relative XDG_CONFIG_HOME is the case that separates the two: the command
|
||||
// has to resolve ${XDG_CONFIG_HOME}/archie/config.toml relative to its working
|
||||
// directory, and a second derivation through os.UserConfigDir rejects a
|
||||
// relative value outright, leaving the command with no config to answer about.
|
||||
func TestRecoveryDefaultConfigResolvesWhereTheDaemonReads(t *testing.T) {
|
||||
// The second layout is the teeth: the command has to read the config at the
|
||||
// resolved path, not merely find some config somewhere under the config home.
|
||||
// A resolution that drifts finds nothing and validate has no verdict.
|
||||
tests := []struct {
|
||||
name string
|
||||
configDir string // relative to $XDG_CONFIG_HOME
|
||||
wantOK bool
|
||||
}{
|
||||
{name: "$XDG_CONFIG_HOME/archie/config.toml", configDir: "archie", wantOK: true},
|
||||
{name: "a config elsewhere in the config home is not the default", configDir: "wrong-place"},
|
||||
}
|
||||
for _, tc := range tests {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
t.Chdir(root)
|
||||
t.Setenv("XDG_CONFIG_HOME", "xdg")
|
||||
|
||||
configDir := filepath.Join(root, "xdg", tc.configDir)
|
||||
if err := os.MkdirAll(configDir, 0o700); err != nil {
|
||||
t.Fatalf("create %s: %v", configDir, err)
|
||||
}
|
||||
configPath := writeMinimalConfig(t, configDir)
|
||||
db := filepath.Join(root, "archie.db-tasks.sqlite")
|
||||
seedStoreResources(t, openTaskStore(t, db), configPath)
|
||||
|
||||
code, stdout, stderr := runRecoveryCmd(t, "validate", "-db", db)
|
||||
if !tc.wantOK {
|
||||
if code == 0 {
|
||||
t.Fatalf("validate exited 0 with no config at the resolved path %s: %s", configPath, stdout)
|
||||
}
|
||||
return
|
||||
}
|
||||
if code != 0 {
|
||||
t.Fatalf("validate with no -config exited %d, so it did not read %s: %s", code, configPath, stderr)
|
||||
}
|
||||
if !strings.Contains(stdout, "stored resources validate") {
|
||||
t.Errorf("validate reported %q, want the verdict on the store seeded from the resolved config", stdout)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// validate exists to answer "would archied start against this file". Each case
|
||||
// below is a state the daemon fails closed on, or a file it cannot read at all.
|
||||
func TestRecoveryValidateRefusesWhatTheDaemonRefuses(t *testing.T) {
|
||||
newStore := func(t *testing.T) string {
|
||||
t.Helper()
|
||||
db := filepath.Join(t.TempDir(), "archie.db-tasks.sqlite")
|
||||
openTaskStore(t, db)
|
||||
return db
|
||||
}
|
||||
|
||||
t.Run("forward_migrated_schema", func(t *testing.T) {
|
||||
// A database written by a newer release is the state a rollback has to
|
||||
// recognise before it hands the file to an older binary.
|
||||
db := newStore(t)
|
||||
if err := execRaw(t, db, `PRAGMA user_version = 99`); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
code, _, stderr := runRecoveryCmd(t, "validate", "-db", db)
|
||||
if code == 0 {
|
||||
t.Fatal("validate accepted a forward-migrated database")
|
||||
}
|
||||
if !strings.Contains(stderr, "newer than supported version") {
|
||||
t.Errorf("refusal must name the schema version; stderr = %q", stderr)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("corrupt_file", func(t *testing.T) {
|
||||
// A real database header over pages that are not a database. The magic
|
||||
// is right, so this fails on the content rather than on the format, which
|
||||
// is the shape a half-written or truncated store has.
|
||||
db := filepath.Join(t.TempDir(), "archie.db-tasks.sqlite")
|
||||
corrupt := append([]byte("SQLite format 3\x00"), bytes.Repeat([]byte{0xff}, 4096)...)
|
||||
if err := os.WriteFile(db, corrupt, 0o600); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
code, _, stderr := runRecoveryCmd(t, "validate", "-db", db)
|
||||
if code == 0 {
|
||||
t.Fatal("validate accepted a corrupt database")
|
||||
}
|
||||
if !strings.Contains(stderr, db) {
|
||||
t.Errorf("refusal must name the file; stderr = %q", stderr)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("not_a_database", func(t *testing.T) {
|
||||
// Pointing -db at the wrong file is the common operator mistake, and the
|
||||
// configured db_path is a different file from the task database the
|
||||
// State Store owns.
|
||||
db := filepath.Join(t.TempDir(), "archie.db")
|
||||
if err := os.WriteFile(db, []byte("db_path, not the task database"), 0o600); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
code, _, stderr := runRecoveryCmd(t, "validate", "-db", db)
|
||||
if code == 0 {
|
||||
t.Fatal("validate accepted a file that is not a database")
|
||||
}
|
||||
if !strings.Contains(stderr, db) {
|
||||
t.Errorf("refusal must name the file; stderr = %q", stderr)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("stored_resource_that_will_not_validate", func(t *testing.T) {
|
||||
// A stored value that both gates refuse: the write path stops it at
|
||||
// Decode (workflow.ExecutionSettings.Validate rejects a negative limit),
|
||||
// and boot stops on it too -- startWorkflowExecutionSettings decodes the
|
||||
// same document and exits 1. It can only get here by bypassing the write
|
||||
// path, which is exactly the state the operator has no path back from.
|
||||
db := newStore(t)
|
||||
seedResource(t, openTaskStore(t, db), controlplane.WorkflowExecutionSettingsKind,
|
||||
`{"max_model_tool_steps":-1,"max_runtime_seconds":60,"max_consecutive_gate_failures":3}`, "hand-edited")
|
||||
code, _, stderr := runRecoveryCmd(t, "validate", "-db", db)
|
||||
if code == 0 {
|
||||
t.Fatal("validate accepted a stored resource the write path would refuse")
|
||||
}
|
||||
if !strings.Contains(stderr, controlplane.WorkflowExecutionSettingsKind) {
|
||||
t.Errorf("refusal must name the resource kind; stderr = %q", stderr)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("missing_database", func(t *testing.T) {
|
||||
db := newStore(t)
|
||||
if err := os.Remove(db); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
code, _, stderr := runRecoveryCmd(t, "validate", "-db", db)
|
||||
if code == 0 {
|
||||
t.Fatal("validate accepted a database that does not exist")
|
||||
}
|
||||
if !strings.Contains(stderr, db) {
|
||||
t.Errorf("refusal must name the file; stderr = %q", stderr)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("store_without_the_control_plane_table", func(t *testing.T) {
|
||||
// A store written before the control plane existed holds no stored
|
||||
// settings. The serving process creates the table on its next start, so
|
||||
// refusing this file would send an operator to restore a snapshot for a
|
||||
// database that would have started perfectly well.
|
||||
dir := t.TempDir()
|
||||
configPath := writeMinimalConfig(t, dir)
|
||||
db := filepath.Join(dir, "archie.db-tasks.sqlite")
|
||||
openTaskStore(t, db)
|
||||
if err := execRaw(t, db, `DROP TABLE resources`); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
code, stdout, stderr := runRecoveryCmd(t, "validate", "-db", db, "-config", configPath)
|
||||
if code != 0 {
|
||||
t.Fatalf("validate exited %d: %s", code, stderr)
|
||||
}
|
||||
if !strings.Contains(stdout, "0 stored resources validate") {
|
||||
t.Errorf("validate must report that there was nothing stored to check; stdout = %q", stdout)
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
// rollback is the one operation that closes the documented gap: with the State
|
||||
// Store stopped, it replays the value an earlier revision recorded through the
|
||||
// ordinary replace, so no rollback RPC is needed and the rollback itself is
|
||||
// audited as one more revision.
|
||||
func TestRecoveryRollbackReplaysTheRevisionThroughReplace(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
db := filepath.Join(dir, "archie.db-tasks.sqlite")
|
||||
st := openTaskStore(t, db)
|
||||
seedResource(t, st, controlplane.ModelRoleAssignmentsKind, `{"implement":"anthropic/claude"}`, "first")
|
||||
seedResource(t, st, controlplane.ModelRoleAssignmentsKind, `{"implement":"openai/gpt"}`, "second")
|
||||
|
||||
code, stdout, stderr := runRecoveryCmd(t, "rollback", "-db", db, "-kind", controlplane.ModelRoleAssignmentsKind)
|
||||
if code != 0 {
|
||||
t.Fatalf("rollback exited %d: %s", code, stderr)
|
||||
}
|
||||
if !strings.Contains(stdout, controlplane.ModelRoleAssignmentsKind) {
|
||||
t.Errorf("rollback must name the resource it replayed; stdout = %q", stdout)
|
||||
}
|
||||
resource, err := st.Resource(t.Context(), controlplane.ModelRoleAssignmentsKind)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if string(resource.Value) != `{"implement":"anthropic/claude"}` {
|
||||
t.Errorf("resource value = %s, want the first revision's value", resource.Value)
|
||||
}
|
||||
if resource.Version != 3 {
|
||||
t.Errorf("resource version = %d, want a new revision (3) rather than a rewrite of the old one", resource.Version)
|
||||
}
|
||||
history, err := st.ResourceHistory(t.Context(), controlplane.ModelRoleAssignmentsKind, 0)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if len(history) != 3 {
|
||||
t.Fatalf("history has %d revisions, want the rollback recorded as the third", len(history))
|
||||
}
|
||||
if history[0].Source != archied.OfflineRollbackSource {
|
||||
t.Errorf("newest revision source = %q, want %q so the rollback is auditable", history[0].Source, archied.OfflineRollbackSource)
|
||||
}
|
||||
}
|
||||
|
||||
// The revision to restore may be named, which is how an operator reaches past
|
||||
// the most recent change without replaying it first.
|
||||
func TestRecoveryRollbackRestoresANamedRevision(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
db := filepath.Join(dir, "archie.db-tasks.sqlite")
|
||||
st := openTaskStore(t, db)
|
||||
seedResource(t, st, controlplane.ModelRoleAssignmentsKind, `{"implement":"anthropic/claude"}`, "first")
|
||||
seedResource(t, st, controlplane.ModelRoleAssignmentsKind, `{"implement":"openai/gpt"}`, "second")
|
||||
seedResource(t, st, controlplane.ModelRoleAssignmentsKind, `{"implement":"google/gemini"}`, "third")
|
||||
|
||||
code, _, stderr := runRecoveryCmd(t, "rollback", "-db", db, "-kind", controlplane.ModelRoleAssignmentsKind, "-revision", "1")
|
||||
if code != 0 {
|
||||
t.Fatalf("rollback exited %d: %s", code, stderr)
|
||||
}
|
||||
resource, err := st.Resource(t.Context(), controlplane.ModelRoleAssignmentsKind)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if string(resource.Value) != `{"implement":"anthropic/claude"}` {
|
||||
t.Errorf("resource value = %s, want the value recorded at revision 1", resource.Value)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRecoveryRollbackRefusesWhatItCannotReplay(t *testing.T) {
|
||||
newStore := func(t *testing.T, revisions int) string {
|
||||
t.Helper()
|
||||
db := filepath.Join(t.TempDir(), "archie.db-tasks.sqlite")
|
||||
st := openTaskStore(t, db)
|
||||
for i := range revisions {
|
||||
value := `{"implement":"anthropic/claude"}`
|
||||
if i > 0 {
|
||||
value = `{"implement":"openai/gpt"}`
|
||||
}
|
||||
seedResource(t, st, controlplane.ModelRoleAssignmentsKind, value, "seed")
|
||||
}
|
||||
return db
|
||||
}
|
||||
|
||||
t.Run("unknown_kind", func(t *testing.T) {
|
||||
db := newStore(t, 2)
|
||||
code, _, stderr := runRecoveryCmd(t, "rollback", "-db", db, "-kind", "not-a-resource")
|
||||
if code == 0 {
|
||||
t.Fatal("rollback of an unknown resource kind succeeded")
|
||||
}
|
||||
if !strings.Contains(stderr, "not-a-resource") {
|
||||
t.Errorf("refusal must name the kind; stderr = %q", stderr)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("no_earlier_revision", func(t *testing.T) {
|
||||
db := newStore(t, 1)
|
||||
code, _, stderr := runRecoveryCmd(t, "rollback", "-db", db, "-kind", controlplane.ModelRoleAssignmentsKind)
|
||||
if code == 0 {
|
||||
t.Fatal("rollback with no earlier revision succeeded")
|
||||
}
|
||||
if !strings.Contains(stderr, "no earlier revision") {
|
||||
t.Errorf("refusal must say there is nothing to roll back to; stderr = %q", stderr)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("current_revision", func(t *testing.T) {
|
||||
db := newStore(t, 2)
|
||||
code, _, stderr := runRecoveryCmd(t, "rollback", "-db", db, "-kind", controlplane.ModelRoleAssignmentsKind, "-revision", "2")
|
||||
if code == 0 {
|
||||
t.Fatal("rollback of the current revision succeeded")
|
||||
}
|
||||
if !strings.Contains(stderr, "is the current version") {
|
||||
t.Errorf("refusal must say the revision is already the current value; stderr = %q", stderr)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("live_state_store", func(t *testing.T) {
|
||||
db := newStore(t, 2)
|
||||
holdStoreOwnership(t, db)
|
||||
code, _, stderr := runRecoveryCmd(t, "rollback", "-db", db, "-kind", controlplane.ModelRoleAssignmentsKind)
|
||||
if code == 0 {
|
||||
t.Fatal("rollback against a live State Store succeeded")
|
||||
}
|
||||
if !strings.Contains(stderr, "owned by another process") {
|
||||
t.Errorf("refusal must say the database is owned by another process; stderr = %q", stderr)
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
// A positional argument that is not a subcommand used to be ignored, leaving
|
||||
// an operator who mistyped a command watching a server start instead.
|
||||
func TestRecoveryRejectsAnUnknownSubcommand(t *testing.T) {
|
||||
var stdout, stderr bytes.Buffer
|
||||
code := runRecovery([]string{"backp", "-db", "x"}, &stdout, &stderr)
|
||||
if code == 0 {
|
||||
t.Fatal("an unknown subcommand exited 0")
|
||||
}
|
||||
if !strings.Contains(stderr.String(), "backp") {
|
||||
t.Errorf("refusal must name the unknown subcommand; stderr = %q", stderr.String())
|
||||
}
|
||||
}
|
||||
|
||||
// writeConfigWithLogFile is writeMinimalConfig plus the daemon's durable log
|
||||
// destination, which only the daemon may bring into existence.
|
||||
func writeConfigWithLogFile(t *testing.T, dir string) (string, string) {
|
||||
t.Helper()
|
||||
configPath := writeMinimalConfig(t, dir)
|
||||
logFile := filepath.Join(dir, "logs", "archied.log")
|
||||
f, err := os.OpenFile(configPath, os.O_APPEND|os.O_WRONLY, 0o600)
|
||||
if err != nil {
|
||||
t.Fatalf("open config to append: %v", err)
|
||||
}
|
||||
defer func() {
|
||||
if err := f.Close(); err != nil {
|
||||
t.Fatalf("close config: %v", err)
|
||||
}
|
||||
}()
|
||||
if _, err := fmt.Fprintf(f, "\n[log]\nfile = %q\n", logFile); err != nil {
|
||||
t.Fatalf("append [log]: %v", err)
|
||||
}
|
||||
return configPath, logFile
|
||||
}
|
||||
|
||||
// seedStoreResources seeds the store the way the State Store seeds it at boot,
|
||||
// from the same config file the operator hands validate: the command's verdict
|
||||
// is about the pair, and a store whose settings never matched the config is a
|
||||
// state boot does not recognise either.
|
||||
//
|
||||
// The seeding builds its control-plane server from the shared provider set
|
||||
// (internal/infrastructure/workflowsteps), which is what every composition root
|
||||
// registers -- including openStateStoreControlPlane, the root helper the
|
||||
// recovery path uses. This test cannot call that unexported helper, so it
|
||||
// registers the same set itself rather than an empty manager: the definitions
|
||||
// are decoded with the vocabulary the served path validates against, which is
|
||||
// what makes the seeded values the ones validate is asked about.
|
||||
func seedStoreResources(t *testing.T, st *store.Store, configPath string) {
|
||||
t.Helper()
|
||||
doc, err := configuration.New(nil).Resolve(configPath, "")
|
||||
if err != nil {
|
||||
t.Fatalf("resolve %s: %v", configPath, err)
|
||||
}
|
||||
steps, err := workflowsteps.NewManager()
|
||||
if err != nil {
|
||||
t.Fatalf("register workflow step vocabulary: %v", err)
|
||||
}
|
||||
server, err := controlplane.NewServer(st, steps)
|
||||
if err != nil {
|
||||
t.Fatalf("build control plane server: %v", err)
|
||||
}
|
||||
_, skipped, err := server.ImportConfig(t.Context(), doc.Config)
|
||||
if err != nil {
|
||||
t.Fatalf("seed store resources: %v", err)
|
||||
}
|
||||
if len(skipped) > 0 {
|
||||
// This helper stands in for the State Store's own seeding, which seeds
|
||||
// every kind it can and leaves the rest absent. A skipped kind here
|
||||
// would mean the fixture store is missing a resource it claims to hold,
|
||||
// and the verdict under test would be about a different store.
|
||||
t.Fatalf("seed store resources: %d kind(s) refused: %+v", len(skipped), skipped)
|
||||
}
|
||||
}
|
||||
|
||||
// storedResourceCount reads the count validate reports out of its summary line.
|
||||
func storedResourceCount(t *testing.T, stdout string) int {
|
||||
t.Helper()
|
||||
before, found := strings.CutSuffix(stdout, " stored resources validate\n")
|
||||
if !found {
|
||||
t.Fatalf("no resource count in %q", stdout)
|
||||
}
|
||||
fields := strings.Fields(before)
|
||||
count, err := strconv.Atoi(fields[len(fields)-1])
|
||||
if err != nil {
|
||||
t.Fatalf("resource count in %q: %v", stdout, err)
|
||||
}
|
||||
return count
|
||||
}
|
||||
|
||||
// seedResource writes one revision of a control-plane resource through the
|
||||
// store, the way the control plane's replace does. The request ID is derived
|
||||
// from the label and the revision it produces: the store deduplicates a
|
||||
// repeated request ID, so a fixed one would make the second write of a series
|
||||
// a silent no-op.
|
||||
func seedResource(t *testing.T, st *store.Store, kind, value, label string) {
|
||||
t.Helper()
|
||||
current, err := st.Resource(t.Context(), kind)
|
||||
expected := int64(0)
|
||||
if err == nil {
|
||||
expected = current.Version
|
||||
}
|
||||
var document any
|
||||
if err := json.Unmarshal([]byte(value), &document); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
encoded, err := json.Marshal(document)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := st.PutResource(t.Context(), store.ResourceWrite{
|
||||
Kind: kind, Value: encoded, Actor: label, Source: "test",
|
||||
RequestID: fmt.Sprintf("%s-%d", label, expected+1), ExpectedVersion: expected,
|
||||
}); err != nil {
|
||||
t.Fatalf("seed resource %s: %v", kind, err)
|
||||
}
|
||||
}
|
||||
|
||||
// execRaw runs one statement against the database file the way an operator
|
||||
// editing a broken store would, bypassing every check the store applies.
|
||||
func execRaw(t *testing.T, path, statement string) error {
|
||||
t.Helper()
|
||||
db, err := sql.Open("sqlite", path)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
defer func() { _ = db.Close() }()
|
||||
_, err = db.ExecContext(t.Context(), statement)
|
||||
return err
|
||||
}
|
||||
@@ -1,152 +0,0 @@
|
||||
// This file enforces the objective half of the UI Service deletion gate
|
||||
// (docs/prds/ui-service-boundary.md, "The deletion gate is objective"). The
|
||||
// composition half -- no config.Holder, no concrete *store.Store, no Gateway
|
||||
// runtime type -- is pinned by internal/app/archieui's
|
||||
// TestComposeUIServerHoldsNoDaemonState. This pins the claim that test cannot
|
||||
// see: that the linked binary carries no daemon runtime at all. Go imports
|
||||
// are atomic, so a single reference to a type living beside a runtime relinks
|
||||
// the runtime, and the severance holds only while something re-measures it.
|
||||
|
||||
package main
|
||||
|
||||
import (
|
||||
"os/exec"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
const modulePath = "github.com/samcharles93/archie-core/"
|
||||
|
||||
// bannedCategory is one class of runtime the UI process must not link. The
|
||||
// names are the PRD's wording; the prefixes are how that class appears in
|
||||
// this module.
|
||||
type bannedCategory struct {
|
||||
name string
|
||||
prefixes []string
|
||||
}
|
||||
|
||||
var deletionGate = []bannedCategory{
|
||||
{"SQL/store implementation", []string{
|
||||
"modernc.org/sqlite",
|
||||
modulePath + "internal/store",
|
||||
}},
|
||||
{"daemon runtime", []string{
|
||||
modulePath + "internal/daemon",
|
||||
modulePath + "internal/app/archied",
|
||||
modulePath + "internal/container",
|
||||
modulePath + "internal/worktree",
|
||||
modulePath + "internal/worktreerpc",
|
||||
}},
|
||||
{"workflow engine", []string{
|
||||
modulePath + "internal/domain/workflow",
|
||||
modulePath + "internal/taskrun",
|
||||
modulePath + "internal/agentexec",
|
||||
}},
|
||||
{"forge client", []string{
|
||||
modulePath + "internal/forge",
|
||||
modulePath + "internal/forgerpc",
|
||||
}},
|
||||
{"channel runtime", []string{
|
||||
modulePath + "internal/channels",
|
||||
}},
|
||||
{"model runtime", []string{
|
||||
modulePath + "internal/gateway",
|
||||
modulePath + "internal/infrastructure/modelcatalog",
|
||||
modulePath + "internal/domain/embedding",
|
||||
modulePath + "internal/infrastructure/embedding",
|
||||
}},
|
||||
{"secret runtime", []string{
|
||||
modulePath + "internal/secret",
|
||||
}},
|
||||
{"agent tooling", []string{
|
||||
modulePath + "internal/tools",
|
||||
modulePath + "internal/skill",
|
||||
modulePath + "internal/skillscript",
|
||||
modulePath + "internal/yaegiutil",
|
||||
modulePath + "internal/plugin",
|
||||
}},
|
||||
{"memory and curator runtime", []string{
|
||||
modulePath + "internal/domain/memory",
|
||||
modulePath + "internal/infrastructure/memory",
|
||||
modulePath + "internal/domain/curator",
|
||||
modulePath + "internal/infrastructure/sessioncurator",
|
||||
modulePath + "internal/infrastructure/skillcurator",
|
||||
}},
|
||||
{"broker transport", []string{
|
||||
modulePath + "internal/eventbus",
|
||||
modulePath + "internal/infrastructure/eventbus",
|
||||
modulePath + "internal/natsrpc",
|
||||
}},
|
||||
}
|
||||
|
||||
// bannedExact is banned as a package rather than as a subtree. Nothing may
|
||||
// reach the database through the UI process, but database/sql/driver and its
|
||||
// support package arrive from github.com/google/uuid's Valuer/Scanner methods
|
||||
// and bring no driver with them.
|
||||
var bannedExact = map[string]string{
|
||||
"database/sql": "SQL/store implementation",
|
||||
}
|
||||
|
||||
// gateExceptions are packages under a banned prefix that carry only contract,
|
||||
// vocabulary or view types. The severance moved the UI's references here so
|
||||
// the parent runtime would stop linking, which makes them the intended end
|
||||
// state rather than a tolerated leak.
|
||||
//
|
||||
// Each one must stay linked. An exception the UI no longer needs is a hole in
|
||||
// the fence, so this list is checked in both directions.
|
||||
var gateExceptions = []string{
|
||||
modulePath + "internal/channels/status",
|
||||
modulePath + "internal/domain/workflow/task",
|
||||
}
|
||||
|
||||
// under reports whether importPath is prefix or a package below it.
|
||||
func under(importPath, prefix string) bool {
|
||||
return importPath == prefix || strings.HasPrefix(importPath, prefix+"/")
|
||||
}
|
||||
|
||||
func TestUIProcessLinksNoDaemonRuntime(t *testing.T) {
|
||||
listed, err := exec.CommandContext(t.Context(), "go", "list", "-deps", ".").CombinedOutput()
|
||||
if err != nil {
|
||||
t.Fatalf("go list -deps .: %v\n%s", err, listed)
|
||||
}
|
||||
|
||||
linkedExceptions := make(map[string]bool, len(gateExceptions))
|
||||
for importPath := range strings.FieldsSeq(string(listed)) {
|
||||
if excepted(importPath, linkedExceptions) {
|
||||
continue
|
||||
}
|
||||
if category, banned := bannedExact[importPath]; banned {
|
||||
reportLink(t, importPath, category)
|
||||
}
|
||||
for _, category := range deletionGate {
|
||||
for _, prefix := range category.prefixes {
|
||||
if under(importPath, prefix) {
|
||||
reportLink(t, importPath, category.name)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
for _, exception := range gateExceptions {
|
||||
if !linkedExceptions[exception] {
|
||||
t.Errorf("%s is excepted from the deletion gate but is no longer linked; drop the exception instead of leaving its prefix open", exception)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func reportLink(t *testing.T, importPath, category string) {
|
||||
t.Helper()
|
||||
t.Errorf("archie-ui links %s (%s); the UI process reaches that capability over a contract, never in-process (docs/prds/ui-service-boundary.md, deletion gate)", importPath, category)
|
||||
}
|
||||
|
||||
// excepted reports whether importPath is allowed past the gate, recording
|
||||
// which exception admitted it so a stale one is reported.
|
||||
func excepted(importPath string, linked map[string]bool) bool {
|
||||
for _, exception := range gateExceptions {
|
||||
if under(importPath, exception) {
|
||||
linked[exception] = true
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
@@ -3,8 +3,6 @@
|
||||
// contracts. It is the .5.2 companion to archie-gateway and
|
||||
// archie-state-store: a thin main that parses process inputs and hands them
|
||||
// to archieui.Run.
|
||||
//
|
||||
// See docs/prds/ui-service-boundary.md for the ratified boundary.
|
||||
package main
|
||||
|
||||
import (
|
||||
|
||||
@@ -1,964 +0,0 @@
|
||||
// Package main's smoke test runs the real archie-ui binary against a State
|
||||
// Store and a Gateway reached over loopback gRPC, and drives it through HTTP
|
||||
// the way an operator's browser does.
|
||||
//
|
||||
// The in-process suite (internal/app/archieui) proves the composition; this
|
||||
// proves the process: flags and configuration file, listener bind, dashboard
|
||||
// token, SPA assets, streamed chat, an operator task action crossing to the
|
||||
// Gateway, the degradations the PRD ratified, dependency loss while running,
|
||||
// and a clean SIGTERM. See docs/prds/ui-service-boundary.md, migration
|
||||
// sequence step 6.
|
||||
|
||||
package main
|
||||
|
||||
import (
|
||||
"bufio"
|
||||
"bytes"
|
||||
"context"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"io"
|
||||
"log/slog"
|
||||
"net"
|
||||
"net/http"
|
||||
"os"
|
||||
"os/exec"
|
||||
"path/filepath"
|
||||
"runtime"
|
||||
"strings"
|
||||
"sync"
|
||||
"syscall"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"google.golang.org/grpc"
|
||||
|
||||
"github.com/samcharles93/archie-core/internal/config"
|
||||
"github.com/samcharles93/archie-core/internal/domain/health"
|
||||
"github.com/samcharles93/archie-core/internal/domain/messaging"
|
||||
"github.com/samcharles93/archie-core/internal/domain/taskactions"
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/gatewayrpc"
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/staterpc"
|
||||
"github.com/samcharles93/archie-core/internal/store"
|
||||
"github.com/samcharles93/archie-core/internal/taskstate"
|
||||
"github.com/samcharles93/archie-core/internal/webui"
|
||||
)
|
||||
|
||||
const dashboardToken = "smoke-token"
|
||||
|
||||
// fakeGateway stands in for the archie-gateway process. The dashboard only
|
||||
// needs the Gateway to answer, stream, and accept an operator action, so the
|
||||
// rest satisfy messaging.ChatContract without pretending to do more.
|
||||
type fakeGateway struct {
|
||||
mu sync.Mutex
|
||||
actions []string
|
||||
}
|
||||
|
||||
func (f *fakeGateway) Snapshot(context.Context) (messaging.ChatSnapshot, error) {
|
||||
return messaging.ChatSnapshot{
|
||||
Sessions: []messaging.SessionContext{{
|
||||
SessionID: "s1",
|
||||
Source: messaging.SessionSource{Platform: "web", ChannelID: "dash"},
|
||||
}},
|
||||
Models: []string{"test/model"},
|
||||
ActiveModel: "test/model",
|
||||
ActivePersonas: map[string]string{},
|
||||
CancellationAvailable: true,
|
||||
}, nil
|
||||
}
|
||||
|
||||
func (f *fakeGateway) GetSession(context.Context, string) (messaging.SessionContext, bool, error) {
|
||||
return messaging.SessionContext{}, false, nil
|
||||
}
|
||||
|
||||
func (f *fakeGateway) RecentMessages(context.Context, string, int) ([]messaging.Message, error) {
|
||||
return nil, nil
|
||||
}
|
||||
|
||||
func (f *fakeGateway) RecentTurns(context.Context, string, int) ([]messaging.TurnRecord, error) {
|
||||
return nil, nil
|
||||
}
|
||||
|
||||
func (f *fakeGateway) Route(context.Context, messaging.Inbound) (messaging.ChatReply, error) {
|
||||
return messaging.ChatReply{Text: "routed", SessionID: "s1"}, nil
|
||||
}
|
||||
|
||||
// Stream emits the contract's documented order: started, a delta, then done.
|
||||
//
|
||||
// A turn that used a tool emits its tool event between the delta and the done,
|
||||
// which is where the Gateway's own stream reports completed tool activity.
|
||||
// Whether the dashboard renders it is the operator's setting, carried to this
|
||||
// process only by the published configuration projection (GitHub #821).
|
||||
func (f *fakeGateway) Stream(ctx context.Context, in messaging.Inbound) (<-chan messaging.ChatEvent, error) {
|
||||
events := make(chan messaging.ChatEvent, 4)
|
||||
go func() {
|
||||
defer close(events)
|
||||
turn := []messaging.ChatEvent{
|
||||
{Kind: "started", SessionID: "s1"},
|
||||
{Kind: "delta", Text: "hello " + in.Message.Text, SessionID: "s1"},
|
||||
{Kind: "done", SessionID: "s1"},
|
||||
}
|
||||
if in.Message.Text == toolCallPrompt {
|
||||
turn = []messaging.ChatEvent{
|
||||
{Kind: "started", SessionID: "s1"},
|
||||
{Kind: "tool", SessionID: "s1", Tool: messaging.ToolCallEvent{
|
||||
ID: "call-1", Name: "read_file", Parameters: `{"path":"main.go"}`,
|
||||
Output: "package main",
|
||||
}},
|
||||
{Kind: "delta", Text: "read it", SessionID: "s1"},
|
||||
{Kind: "done", SessionID: "s1"},
|
||||
}
|
||||
}
|
||||
for _, event := range turn {
|
||||
select {
|
||||
case events <- event:
|
||||
case <-ctx.Done():
|
||||
return
|
||||
}
|
||||
}
|
||||
}()
|
||||
return events, nil
|
||||
}
|
||||
|
||||
// toolCallPrompt is the message this suite sends when it wants the fake
|
||||
// Gateway to report a completed tool call in the turn.
|
||||
const toolCallPrompt = "read main.go"
|
||||
|
||||
func (f *fakeGateway) Cancel(context.Context, string) (messaging.ChatCancellation, error) {
|
||||
return messaging.ChatCancellation{Cancelled: true}, nil
|
||||
}
|
||||
|
||||
func (f *fakeGateway) SetPersona(context.Context, string, string) (bool, error) { return false, nil }
|
||||
|
||||
func (f *fakeGateway) ApplyTaskAction(context.Context, string, int64, taskstate.Action) (messaging.TaskActionResult, error) {
|
||||
return messaging.TaskActionResult{}, nil
|
||||
}
|
||||
|
||||
func (f *fakeGateway) ApplyOperatorTaskAction(_ context.Context, actor taskactions.Actor, id int64, action taskstate.Action) (messaging.TaskActionResult, error) {
|
||||
f.mu.Lock()
|
||||
defer f.mu.Unlock()
|
||||
f.actions = append(f.actions, fmt.Sprintf("%d:%s", id, action))
|
||||
return messaging.TaskActionResult{TaskID: id, Action: string(action)}, nil
|
||||
}
|
||||
|
||||
func (f *fakeGateway) applied() []string {
|
||||
f.mu.Lock()
|
||||
defer f.mu.Unlock()
|
||||
return append([]string(nil), f.actions...)
|
||||
}
|
||||
|
||||
// repoRoot walks up from this test's source directory to the module root, so
|
||||
// the build works regardless of the harness working directory.
|
||||
func repoRoot(t *testing.T) string {
|
||||
t.Helper()
|
||||
_, file, _, ok := runtime.Caller(0)
|
||||
if !ok {
|
||||
t.Fatal("cannot determine test source path")
|
||||
}
|
||||
dir := filepath.Dir(file)
|
||||
for {
|
||||
if _, err := os.Stat(filepath.Join(dir, "go.mod")); err == nil {
|
||||
return dir
|
||||
}
|
||||
parent := filepath.Dir(dir)
|
||||
if parent == dir {
|
||||
t.Fatal("go.mod not found above test source")
|
||||
}
|
||||
dir = parent
|
||||
}
|
||||
}
|
||||
|
||||
func buildUIBinary(t *testing.T, dir string) string {
|
||||
t.Helper()
|
||||
bin := filepath.Join(dir, "archie-ui")
|
||||
cmd := exec.CommandContext(t.Context(), "go", "build", "-o", bin, "./cmd/archie-ui")
|
||||
cmd.Dir = repoRoot(t)
|
||||
cmd.Env = os.Environ()
|
||||
if out, err := cmd.CombinedOutput(); err != nil {
|
||||
t.Fatalf("go build archie-ui: %v\n%s", err, out)
|
||||
}
|
||||
return bin
|
||||
}
|
||||
|
||||
// syncBuffer is a concurrency-safe sink for the subprocess's stderr: the
|
||||
// os/exec goroutine writes while the test reads it to recover the bound
|
||||
// address and to report it on failure.
|
||||
type syncBuffer struct {
|
||||
mu sync.Mutex
|
||||
b bytes.Buffer
|
||||
}
|
||||
|
||||
func (s *syncBuffer) Write(p []byte) (int, error) {
|
||||
s.mu.Lock()
|
||||
defer s.mu.Unlock()
|
||||
return s.b.Write(p)
|
||||
}
|
||||
|
||||
func (s *syncBuffer) String() string {
|
||||
s.mu.Lock()
|
||||
defer s.mu.Unlock()
|
||||
return s.b.String()
|
||||
}
|
||||
|
||||
// serveGRPC runs register against a fresh loopback listener, returning the
|
||||
// dial target and a stop func so a test can take the dependency away.
|
||||
func serveGRPC(t *testing.T, register func(grpc.ServiceRegistrar)) (target string, stop func()) {
|
||||
t.Helper()
|
||||
listener, err := (&net.ListenConfig{}).Listen(t.Context(), "tcp", "127.0.0.1:0")
|
||||
if err != nil {
|
||||
t.Fatalf("listen: %v", err)
|
||||
}
|
||||
server := grpc.NewServer()
|
||||
register(server)
|
||||
go func() { _ = server.Serve(listener) }()
|
||||
t.Cleanup(server.Stop)
|
||||
return listener.Addr().String(), server.Stop
|
||||
}
|
||||
|
||||
// writeUIConfig writes the config.toml an operator would keep: the service
|
||||
// endpoints the UI dials live in it, so the process is started without
|
||||
// -gateway-target or -state-target and has to read them itself. The rest is
|
||||
// what configuration validation requires of any archie config file.
|
||||
func writeUIConfig(t *testing.T, dir, stateTarget, gatewayTarget string) string {
|
||||
t.Helper()
|
||||
path := filepath.Join(dir, "config.toml")
|
||||
content := fmt.Sprintf(`bot_user = "archie-bot"
|
||||
db_path = %q
|
||||
[forge]
|
||||
type = "github"
|
||||
host = "https://github.example.com"
|
||||
token = { engine = "env", key = "ARCHIE_GITHUB_TOKEN" }
|
||||
[[repos]]
|
||||
owner = "acme"
|
||||
name = "widget"
|
||||
[services.state]
|
||||
target = %q
|
||||
[services.gateway]
|
||||
target = %q
|
||||
`, filepath.Join(dir, "archie.db"), stateTarget, gatewayTarget)
|
||||
if err := os.WriteFile(path, []byte(content), 0o600); err != nil {
|
||||
t.Fatalf("write ui config: %v", err)
|
||||
}
|
||||
return path
|
||||
}
|
||||
|
||||
// uiProcess is a running archie-ui, plus the address it actually bound.
|
||||
type uiProcess struct {
|
||||
cmd *exec.Cmd
|
||||
addr string
|
||||
log *syncBuffer
|
||||
}
|
||||
|
||||
func startUIProcess(t *testing.T, bin, cfg string) *uiProcess {
|
||||
t.Helper()
|
||||
// The process outlives t.Context() deliberately: that context is
|
||||
// cancelled just before cleanups run, which would SIGKILL archie-ui out
|
||||
// from under the graceful-shutdown check in stop. Cancelling this one is
|
||||
// registered first, so it runs last and only backstops a process that
|
||||
// ignored SIGTERM.
|
||||
ctx, cancel := context.WithCancel(context.WithoutCancel(t.Context()))
|
||||
t.Cleanup(cancel)
|
||||
cmd := exec.CommandContext(
|
||||
ctx, bin,
|
||||
"-config", cfg,
|
||||
"-listen", "127.0.0.1:0",
|
||||
"-token", dashboardToken,
|
||||
)
|
||||
cmd.Env = append(os.Environ(), "ARCHIE_GITHUB_TOKEN=test-token")
|
||||
var log syncBuffer
|
||||
cmd.Stderr = &log
|
||||
cmd.Stdout = &log
|
||||
if err := cmd.Start(); err != nil {
|
||||
t.Fatalf("start archie-ui: %v", err)
|
||||
}
|
||||
p := &uiProcess{cmd: cmd, log: &log}
|
||||
t.Cleanup(func() { p.stop(t) })
|
||||
|
||||
// -listen 127.0.0.1:0 means the kernel picks the port, so the bound
|
||||
// address comes back out of the process's own startup log.
|
||||
deadline := time.Now().Add(20 * time.Second)
|
||||
for time.Now().Before(deadline) && p.addr == "" {
|
||||
if cmd.ProcessState != nil {
|
||||
t.Fatalf("archie-ui exited early:\n%s", log.String())
|
||||
}
|
||||
p.parseAddr()
|
||||
if p.addr == "" {
|
||||
time.Sleep(25 * time.Millisecond)
|
||||
}
|
||||
}
|
||||
if p.addr == "" {
|
||||
t.Fatalf("did not recover the bound address from the log:\n%s", log.String())
|
||||
}
|
||||
waitHealthy(t, p)
|
||||
return p
|
||||
}
|
||||
|
||||
func (p *uiProcess) parseAddr() {
|
||||
scanner := bufio.NewScanner(strings.NewReader(p.log.String()))
|
||||
for scanner.Scan() {
|
||||
var record map[string]any
|
||||
if err := json.Unmarshal(scanner.Bytes(), &record); err != nil {
|
||||
continue
|
||||
}
|
||||
if msg, _ := record["msg"].(string); msg != "archie-ui running" {
|
||||
continue
|
||||
}
|
||||
if addr, ok := record["addr"].(string); ok && addr != "" {
|
||||
p.addr = addr
|
||||
return
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func waitHealthy(t *testing.T, p *uiProcess) {
|
||||
t.Helper()
|
||||
deadline := time.Now().Add(20 * time.Second)
|
||||
for time.Now().Before(deadline) {
|
||||
req, err := http.NewRequestWithContext(t.Context(), http.MethodGet, "http://"+p.addr+"/healthz", nil)
|
||||
if err != nil {
|
||||
t.Fatalf("build liveness request: %v", err)
|
||||
}
|
||||
if resp, err := http.DefaultClient.Do(req); err == nil {
|
||||
_ = resp.Body.Close()
|
||||
if resp.StatusCode == http.StatusOK {
|
||||
return
|
||||
}
|
||||
}
|
||||
time.Sleep(25 * time.Millisecond)
|
||||
}
|
||||
t.Fatalf("/healthz never answered:\n%s", p.log.String())
|
||||
}
|
||||
|
||||
// stop ends the process the way a service manager does and reports a
|
||||
// non-graceful exit, which is how a shutdown-ordering regression surfaces.
|
||||
func (p *uiProcess) stop(t *testing.T) {
|
||||
t.Helper()
|
||||
if p.cmd.Process == nil || p.cmd.ProcessState != nil {
|
||||
return
|
||||
}
|
||||
if err := p.cmd.Process.Signal(syscall.SIGTERM); err != nil {
|
||||
t.Errorf("SIGTERM archie-ui: %v", err)
|
||||
return
|
||||
}
|
||||
done := make(chan error, 1)
|
||||
go func() { done <- p.cmd.Wait() }()
|
||||
select {
|
||||
case err := <-done:
|
||||
if err != nil {
|
||||
t.Errorf("archie-ui exited %v after SIGTERM, want a clean shutdown:\n%s", err, p.log.String())
|
||||
}
|
||||
case <-time.After(20 * time.Second):
|
||||
_ = p.cmd.Process.Kill()
|
||||
t.Errorf("archie-ui did not exit within 20s of SIGTERM:\n%s", p.log.String())
|
||||
}
|
||||
}
|
||||
|
||||
// reply is one dashboard response, already read and closed. The assertions
|
||||
// want the status and the bytes rather than a live body, and handing back a
|
||||
// closed value keeps the close where the read is.
|
||||
type reply struct {
|
||||
status int
|
||||
header http.Header
|
||||
body []byte
|
||||
}
|
||||
|
||||
func (r reply) cookies() []*http.Cookie {
|
||||
return (&http.Response{Header: r.header}).Cookies()
|
||||
}
|
||||
|
||||
// dashboard is a browser-shaped client for the running process.
|
||||
type dashboard struct {
|
||||
t *testing.T
|
||||
base string
|
||||
client *http.Client
|
||||
}
|
||||
|
||||
// noRedirect returns a dashboard that reports a redirect rather than
|
||||
// following it, so an exchange can be inspected instead of chased. Following
|
||||
// it here would land on the clean URL without the cookie jar a browser has.
|
||||
func (d dashboard) noRedirect() dashboard {
|
||||
d.client = &http.Client{CheckRedirect: func(*http.Request, []*http.Request) error {
|
||||
return http.ErrUseLastResponse
|
||||
}}
|
||||
return d
|
||||
}
|
||||
|
||||
func (d dashboard) do(req *http.Request) reply {
|
||||
d.t.Helper()
|
||||
client := d.client
|
||||
if client == nil {
|
||||
client = http.DefaultClient
|
||||
}
|
||||
resp, err := client.Do(req)
|
||||
if err != nil {
|
||||
d.t.Fatalf("%s %s: %v", req.Method, req.URL.Path, err)
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
body, err := io.ReadAll(resp.Body)
|
||||
if err != nil {
|
||||
d.t.Fatalf("read %s: %v", req.URL.Path, err)
|
||||
}
|
||||
return reply{status: resp.StatusCode, header: resp.Header, body: body}
|
||||
}
|
||||
|
||||
func (d dashboard) request(method, path, body string, authorized bool) *http.Request {
|
||||
d.t.Helper()
|
||||
var reader io.Reader = http.NoBody
|
||||
if body != "" {
|
||||
reader = strings.NewReader(body)
|
||||
}
|
||||
req, err := http.NewRequestWithContext(d.t.Context(), method, d.base+path, reader)
|
||||
if err != nil {
|
||||
d.t.Fatalf("build %s %s: %v", method, path, err)
|
||||
}
|
||||
if authorized {
|
||||
req.Header.Set("Authorization", "Bearer "+dashboardToken)
|
||||
}
|
||||
if body != "" {
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
req.Header.Set("X-Archie-CSRF", "1")
|
||||
}
|
||||
return req
|
||||
}
|
||||
|
||||
func (d dashboard) get(path string) reply {
|
||||
d.t.Helper()
|
||||
return d.do(d.request(http.MethodGet, path, "", true))
|
||||
}
|
||||
|
||||
// chatFrame is one `data: {...}` frame of the chat stream, decoded into the
|
||||
// fields this suite reads. The UI process only ever receives these over HTTP,
|
||||
// so asserting on them is asserting on what the browser is handed.
|
||||
type chatFrame struct {
|
||||
Type string `json:"type"`
|
||||
Text string `json:"text"`
|
||||
Tool string `json:"tool"`
|
||||
}
|
||||
|
||||
// streamChat runs one chat turn over the real HTTP stream and returns every
|
||||
// frame up to and including the terminating done.
|
||||
func streamChat(t *testing.T, d dashboard, prompt string) []chatFrame {
|
||||
t.Helper()
|
||||
body, err := json.Marshal(map[string]string{"text": prompt, "channel_id": "dash"})
|
||||
if err != nil {
|
||||
t.Fatalf("encode the chat turn: %v", err)
|
||||
}
|
||||
resp, err := http.DefaultClient.Do(d.request(http.MethodPost, "/api/chat/stream", string(body), true))
|
||||
if err != nil {
|
||||
t.Fatalf("POST /api/chat/stream: %v", err)
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
if resp.StatusCode != http.StatusOK {
|
||||
t.Fatalf("POST /api/chat/stream = %d, want 200", resp.StatusCode)
|
||||
}
|
||||
var frames []chatFrame
|
||||
scanner := bufio.NewScanner(resp.Body)
|
||||
for scanner.Scan() {
|
||||
payload, ok := strings.CutPrefix(scanner.Text(), "data: ")
|
||||
if !ok {
|
||||
continue
|
||||
}
|
||||
var frame chatFrame
|
||||
if err := json.Unmarshal([]byte(payload), &frame); err != nil {
|
||||
t.Fatalf("decode stream frame %q: %v", payload, err)
|
||||
}
|
||||
frames = append(frames, frame)
|
||||
if frame.Type == "done" {
|
||||
break
|
||||
}
|
||||
}
|
||||
if err := scanner.Err(); err != nil {
|
||||
t.Fatalf("read the chat stream: %v", err)
|
||||
}
|
||||
return frames
|
||||
}
|
||||
|
||||
// seedStore fills a real task database and publishes the configuration
|
||||
// projection, so everything the dashboard renders arrives over the wire from
|
||||
// a store this process never opens.
|
||||
//
|
||||
// The document is rendered by webui.BuildConfigView -- the same function the
|
||||
// daemon calls -- from a config.Config rather than hand-written as a
|
||||
// ConfigView. A suite that hand-writes the document cannot catch a producer
|
||||
// that forgets to publish a field, which is the failure mode this covers:
|
||||
// chat.show_tool_calls, the operator name and the channel flag all reach the
|
||||
// extracted process through this projection and nowhere else (GitHub #821).
|
||||
func seedStore(t *testing.T, dir string) *store.Store {
|
||||
t.Helper()
|
||||
st, err := store.Open(t.Context(), filepath.Join(dir, "tasks.sqlite"))
|
||||
if err != nil {
|
||||
t.Fatalf("open store: %v", err)
|
||||
}
|
||||
t.Cleanup(func() { _ = st.Close() })
|
||||
|
||||
if _, err := st.EnqueueIssue(t.Context(), "acme", "widget", 7, "smoke task", "body", "", ""); err != nil {
|
||||
t.Fatalf("seed task: %v", err)
|
||||
}
|
||||
tasks, err := st.Tasks(t.Context(), 10)
|
||||
if err != nil || len(tasks) != 1 {
|
||||
t.Fatalf("seeded tasks = %d (%v), want 1", len(tasks), err)
|
||||
}
|
||||
seeded := tasks[0]
|
||||
seeded.PRNumber = 34
|
||||
if err := st.Update(t.Context(), &seeded); err != nil {
|
||||
t.Fatalf("record PR number: %v", err)
|
||||
}
|
||||
|
||||
publishConfig(t, st, daemonConfig(true))
|
||||
return st
|
||||
}
|
||||
|
||||
// daemonConfig is the configuration the daemon would hold for this smoke run.
|
||||
// showToolCalls is the setting the chat page's expansion is gated on.
|
||||
func daemonConfig(showToolCalls bool) config.Config {
|
||||
return config.Config{
|
||||
BotUser: "archie-bot",
|
||||
Forge: config.Forge{Type: "github", Host: "https://github.example.com"},
|
||||
Repos: []config.Repo{{Owner: "acme", Name: "widget", Base: "main"}},
|
||||
Chat: config.ChatConfig{
|
||||
ShowToolCalls: showToolCalls,
|
||||
Operator: "Sam",
|
||||
WebhookAddr: "127.0.0.1:9099",
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
// publishConfig renders cfg the way the daemon's configuration owner does and
|
||||
// writes the result to the store the UI process reads it back from. The UI
|
||||
// process holds no configuration, so this is the only path by which a setting
|
||||
// reaches its pages.
|
||||
func publishConfig(t *testing.T, st *store.Store, cfg config.Config) {
|
||||
t.Helper()
|
||||
document, err := json.Marshal(webui.BuildConfigView(webui.ConfigViewInput{Config: cfg}))
|
||||
if err != nil {
|
||||
t.Fatalf("render the configuration projection: %v", err)
|
||||
}
|
||||
if err := st.PutConfigSnapshot(t.Context(), store.ConfigSnapshot{
|
||||
Schema: webui.ConfigViewSchema, Document: document,
|
||||
}); err != nil {
|
||||
t.Fatalf("publish config snapshot: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
// TestUIProcessLinksMultiIdentityTaskRowsToTheirOwningForge drives the real
|
||||
// binary against a State Store holding a multi-identity deployment's
|
||||
// projection. Task rows in such a deployment used to render no link at all:
|
||||
// the projection carried the default identity's forge alone, so the renderer
|
||||
// withheld rather than pointing every row at the wrong forge
|
||||
// (archie-core-pv6t). With per-identity forges published, each row is
|
||||
// attributed to the identity that owns it, by identity name first and repo
|
||||
// ownership second.
|
||||
//
|
||||
// Its own store and process: it publishes a different projection than the
|
||||
// single-identity smoke test, and republishing over a shared one would rewire
|
||||
// that test's page underneath it.
|
||||
func TestUIProcessLinksMultiIdentityTaskRowsToTheirOwningForge(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
st, err := store.Open(t.Context(), filepath.Join(dir, "tasks.sqlite"))
|
||||
if err != nil {
|
||||
t.Fatalf("open store: %v", err)
|
||||
}
|
||||
t.Cleanup(func() { _ = st.Close() })
|
||||
|
||||
// One task carrying its identity (name resolves it), one without an
|
||||
// identity but on a repo only the Gitea identity owns (ownership
|
||||
// resolves it), and one on a repo both identities claim (ambiguous, so
|
||||
// it falls back to the default forge).
|
||||
for _, seed := range []struct {
|
||||
owner, repo, identity string
|
||||
number int
|
||||
}{
|
||||
{owner: "acme", repo: "widget", identity: "gitea-bot", number: 7},
|
||||
{owner: "beta", repo: "svc", number: 8},
|
||||
{owner: "acme", repo: "shared", number: 9},
|
||||
} {
|
||||
if _, err := st.EnqueueIssue(t.Context(), seed.owner, seed.repo, seed.number, "seeded", "body", "", seed.identity); err != nil {
|
||||
t.Fatalf("seed %s/%s: %v", seed.owner, seed.repo, err)
|
||||
}
|
||||
}
|
||||
|
||||
published, err := json.Marshal(webui.ConfigView{
|
||||
Identity: webui.IdentityView{BotUser: "archie-bot", ForgeType: "github", ForgeHost: "https://github.example.com"},
|
||||
MultiIdentity: true,
|
||||
Identities: []webui.ForgeIdentityView{
|
||||
{
|
||||
Name: "gitea-bot", ForgeType: "gitea", ForgeHost: "https://gitea.example.com",
|
||||
Repos: []webui.ForgeRepoView{{Owner: "acme", Name: "widget"}, {Owner: "acme", Name: "shared"}},
|
||||
},
|
||||
{
|
||||
Name: "github-bot", ForgeType: "github", ForgeHost: "https://github.example.com",
|
||||
Repos: []webui.ForgeRepoView{{Owner: "beta", Name: "svc"}, {Owner: "acme", Name: "shared"}},
|
||||
},
|
||||
},
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := st.PutConfigSnapshot(t.Context(), store.ConfigSnapshot{
|
||||
Schema: webui.ConfigViewSchema, Document: published,
|
||||
}); err != nil {
|
||||
t.Fatalf("publish config snapshot: %v", err)
|
||||
}
|
||||
|
||||
stateTarget, stopState := serveGRPC(t, func(r grpc.ServiceRegistrar) {
|
||||
staterpc.RegisterServer(r, staterpc.Deps{
|
||||
Tasks: st, Captures: st, BindingDispatcher: st, ConfigSnapshots: st,
|
||||
Log: slog.New(slog.DiscardHandler),
|
||||
})
|
||||
})
|
||||
defer stopState()
|
||||
gatewayTarget, stopGateway := serveGRPC(t, func(r grpc.ServiceRegistrar) {
|
||||
gatewayrpc.RegisterServer(r, &fakeGateway{})
|
||||
})
|
||||
defer stopGateway()
|
||||
|
||||
ui := startUIProcess(t, buildUIBinary(t, dir), writeUIConfig(t, dir, stateTarget, gatewayTarget))
|
||||
d := dashboard{t: t, base: "http://" + ui.addr}
|
||||
|
||||
got := d.get("/api/tasks")
|
||||
if got.status != http.StatusOK {
|
||||
t.Fatalf("GET /api/tasks = %d (%s), want 200", got.status, got.body)
|
||||
}
|
||||
var rows []struct {
|
||||
Owner string `json:"owner"`
|
||||
Repo string `json:"repo"`
|
||||
IssueNumber int `json:"issue_number"`
|
||||
RepoURL string `json:"repo_url"`
|
||||
IssueURL string `json:"issue_url"`
|
||||
}
|
||||
if err := json.Unmarshal(got.body, &rows); err != nil {
|
||||
t.Fatalf("decode task rows: %v (%s)", err, got.body)
|
||||
}
|
||||
if len(rows) != 3 {
|
||||
t.Fatalf("task rows = %d, want the 3 seeded behind the State Store (%s)", len(rows), got.body)
|
||||
}
|
||||
|
||||
want := map[string]string{
|
||||
"acme/widget#7": "https://gitea.example.com/acme/widget/issues/7",
|
||||
"beta/svc#8": "https://github.example.com/beta/svc/issues/8",
|
||||
"acme/shared#9": "https://github.example.com/acme/shared/issues/9",
|
||||
}
|
||||
for _, row := range rows {
|
||||
key := fmt.Sprintf("%s/%s#%d", row.Owner, row.Repo, row.IssueNumber)
|
||||
expected, ok := want[key]
|
||||
if !ok {
|
||||
t.Errorf("unexpected row %q (%s)", key, got.body)
|
||||
continue
|
||||
}
|
||||
if row.RepoURL == "" || row.IssueURL != expected {
|
||||
t.Errorf("row %s links = %q, %q; want %q", key, row.RepoURL, row.IssueURL, expected)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestUIProcessServesTheDashboardAgainstLiveDependencies(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
st := seedStore(t, dir)
|
||||
gateway := &fakeGateway{}
|
||||
|
||||
stateTarget, stopState := serveGRPC(t, func(r grpc.ServiceRegistrar) {
|
||||
staterpc.RegisterServer(r, staterpc.Deps{
|
||||
Tasks: st, Captures: st, BindingDispatcher: st, ConfigSnapshots: st,
|
||||
Log: slog.New(slog.DiscardHandler),
|
||||
})
|
||||
})
|
||||
gatewayTarget, _ := serveGRPC(t, func(r grpc.ServiceRegistrar) {
|
||||
gatewayrpc.RegisterServer(r, gateway)
|
||||
})
|
||||
|
||||
ui := startUIProcess(t, buildUIBinary(t, dir), writeUIConfig(t, dir, stateTarget, gatewayTarget))
|
||||
d := dashboard{t: t, base: "http://" + ui.addr}
|
||||
|
||||
t.Run("liveness stays unauthenticated", func(t *testing.T) {
|
||||
for _, path := range []string{"/healthz", "/health"} {
|
||||
if got := d.do(d.request(http.MethodGet, path, "", false)); got.status != http.StatusOK {
|
||||
t.Errorf("GET %s = %d without a token, want 200: probes must not need the dashboard token", path, got.status)
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("an unauthenticated API request is refused", func(t *testing.T) {
|
||||
if got := d.do(d.request(http.MethodGet, "/api/tasks", "", false)); got.status != http.StatusUnauthorized {
|
||||
t.Errorf("GET /api/tasks = %d without a token, want 401", got.status)
|
||||
}
|
||||
wrong := d.request(http.MethodGet, "/api/tasks", "", false)
|
||||
wrong.Header.Set("Authorization", "Bearer not-the-token")
|
||||
if got := d.do(wrong); got.status != http.StatusUnauthorized {
|
||||
t.Errorf("GET /api/tasks = %d with a wrong token, want 401", got.status)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("the token in the URL is exchanged for a cookie", func(t *testing.T) {
|
||||
got := d.noRedirect().do(d.request(http.MethodGet, "/?t="+dashboardToken, "", false))
|
||||
if got.status != http.StatusSeeOther {
|
||||
t.Fatalf("GET /?t=<token> = %d, want 303 onto the clean URL", got.status)
|
||||
}
|
||||
var carried bool
|
||||
for _, cookie := range got.cookies() {
|
||||
if cookie.Value == dashboardToken && cookie.HttpOnly {
|
||||
carried = true
|
||||
}
|
||||
}
|
||||
if !carried {
|
||||
t.Errorf("no HttpOnly cookie carried the token; it would stay in browser history (%v)", got.cookies())
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("task rows carry forge links from the published projection", func(t *testing.T) {
|
||||
got := d.get("/api/tasks")
|
||||
if got.status != http.StatusOK {
|
||||
t.Fatalf("GET /api/tasks = %d (%s), want 200", got.status, got.body)
|
||||
}
|
||||
var rows []struct {
|
||||
ID int64 `json:"id"`
|
||||
RepoURL string `json:"repo_url"`
|
||||
IssueURL string `json:"issue_url"`
|
||||
PRURL string `json:"pr_url"`
|
||||
}
|
||||
if err := json.Unmarshal(got.body, &rows); err != nil {
|
||||
t.Fatalf("decode task rows: %v (%s)", err, got.body)
|
||||
}
|
||||
if len(rows) != 1 {
|
||||
t.Fatalf("task rows = %d, want the 1 seeded behind the State Store (%s)", len(rows), got.body)
|
||||
}
|
||||
const repoURL = "https://github.example.com/acme/widget"
|
||||
if rows[0].RepoURL != repoURL || rows[0].IssueURL != repoURL+"/issues/7" || rows[0].PRURL != repoURL+"/pull/34" {
|
||||
t.Errorf("forge links = %q, %q, %q; want them built from the daemon's published projection, since this process holds no configuration of its own",
|
||||
rows[0].RepoURL, rows[0].IssueURL, rows[0].PRURL)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("the SPA and its assets are served", func(t *testing.T) {
|
||||
index := d.get("/")
|
||||
if index.status != http.StatusOK || !bytes.Contains(bytes.ToLower(index.body), []byte("<!doctype html")) {
|
||||
t.Errorf("GET / = %d serving %d bytes; want the embedded index.html", index.status, len(index.body))
|
||||
}
|
||||
for path, wantType := range map[string]string{
|
||||
"/assets/index.js": "javascript",
|
||||
"/assets/index.css": "css",
|
||||
} {
|
||||
asset := d.get(path)
|
||||
if asset.status != http.StatusOK {
|
||||
t.Errorf("GET %s = %d, want the embedded asset", path, asset.status)
|
||||
continue
|
||||
}
|
||||
if contentType := asset.header.Get("Content-Type"); !strings.Contains(contentType, wantType) {
|
||||
t.Errorf("GET %s Content-Type = %q, want %s", path, contentType, wantType)
|
||||
}
|
||||
if len(asset.body) == 0 {
|
||||
t.Errorf("GET %s served an empty body", path)
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("chat streams over the Gateway contract", func(t *testing.T) {
|
||||
req := d.request(http.MethodPost, "/api/chat/stream", `{"text":"there","channel_id":"dash"}`, true)
|
||||
resp, err := http.DefaultClient.Do(req)
|
||||
if err != nil {
|
||||
t.Fatalf("POST /api/chat/stream: %v", err)
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
if resp.StatusCode != http.StatusOK {
|
||||
t.Fatalf("POST /api/chat/stream = %d, want 200", resp.StatusCode)
|
||||
}
|
||||
if contentType := resp.Header.Get("Content-Type"); !strings.Contains(contentType, "text/event-stream") {
|
||||
t.Fatalf("stream Content-Type = %q, want text/event-stream", contentType)
|
||||
}
|
||||
var kinds []string
|
||||
var text string
|
||||
scanner := bufio.NewScanner(resp.Body)
|
||||
for scanner.Scan() {
|
||||
payload, ok := strings.CutPrefix(scanner.Text(), "data: ")
|
||||
if !ok {
|
||||
continue
|
||||
}
|
||||
var frame struct {
|
||||
Type string `json:"type"`
|
||||
Text string `json:"text"`
|
||||
}
|
||||
if err := json.Unmarshal([]byte(payload), &frame); err != nil {
|
||||
t.Fatalf("decode stream frame %q: %v", payload, err)
|
||||
}
|
||||
kinds = append(kinds, frame.Type)
|
||||
if frame.Type == "delta" {
|
||||
text += frame.Text
|
||||
}
|
||||
if frame.Type == "done" {
|
||||
break
|
||||
}
|
||||
}
|
||||
if strings.Join(kinds, ",") != "started,delta,done" {
|
||||
t.Errorf("stream frames = %v, want started,delta,done in order", kinds)
|
||||
}
|
||||
if text != "hello there" {
|
||||
t.Errorf("streamed text = %q, want the Gateway's reply relayed verbatim", text)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("the daemon's show_tool_calls setting decides whether tool calls reach the chat page", func(t *testing.T) {
|
||||
// The chat page expands a completed tool call only when the frame
|
||||
// arrives, and this process has no [chat] section of its own: the
|
||||
// setting reaches it through the published projection alone. A turn
|
||||
// streamed with the setting off must carry no tool frame, and one
|
||||
// streamed with it on must carry the tool the Gateway reported
|
||||
// (GitHub #821).
|
||||
//
|
||||
// Each case republishes before streaming, the way a config reload
|
||||
// does; the default is restored afterwards so a later subtest does
|
||||
// not inherit whichever case ran last.
|
||||
tests := []struct {
|
||||
name string
|
||||
showTools bool
|
||||
wantFrame bool
|
||||
}{
|
||||
{name: "off", showTools: false, wantFrame: false},
|
||||
{name: "on", showTools: true, wantFrame: true},
|
||||
}
|
||||
for _, tc := range tests {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
publishConfig(t, st, daemonConfig(tc.showTools))
|
||||
|
||||
frames := streamChat(t, d, toolCallPrompt)
|
||||
var sawTool bool
|
||||
for _, frame := range frames {
|
||||
if frame.Tool == "read_file" {
|
||||
sawTool = true
|
||||
}
|
||||
if frame.Type == "done" {
|
||||
break
|
||||
}
|
||||
}
|
||||
if sawTool != tc.wantFrame {
|
||||
t.Errorf("show_tool_calls=%v produced tool frame = %v, want %v; frames = %+v",
|
||||
tc.showTools, sawTool, tc.wantFrame, frames)
|
||||
}
|
||||
})
|
||||
}
|
||||
publishConfig(t, st, daemonConfig(true))
|
||||
})
|
||||
|
||||
t.Run("an operator task action crosses to the Gateway", func(t *testing.T) {
|
||||
listed := d.get("/api/tasks")
|
||||
var rows []struct {
|
||||
ID int64 `json:"id"`
|
||||
}
|
||||
if err := json.Unmarshal(listed.body, &rows); err != nil || len(rows) != 1 {
|
||||
t.Fatalf("decode task rows: %v (%s)", err, listed.body)
|
||||
}
|
||||
path := fmt.Sprintf("/api/tasks/%d/action", rows[0].ID)
|
||||
action := string(taskstate.ActionCancel)
|
||||
if got := d.do(d.request(http.MethodPost, path, `{"action":"`+action+`"}`, true)); got.status != http.StatusOK {
|
||||
t.Fatalf("POST %s = %d (%s), want 200", path, got.status, got.body)
|
||||
}
|
||||
want := fmt.Sprintf("%d:%s", rows[0].ID, action)
|
||||
if applied := gateway.applied(); len(applied) != 1 || applied[0] != want {
|
||||
t.Errorf("Gateway saw %v, want exactly [%s]: the UI must not mutate task state itself", applied, want)
|
||||
}
|
||||
|
||||
// The same action without the CSRF header is refused, so a
|
||||
// cross-site form post cannot drive the daemon.
|
||||
noCSRF := d.request(http.MethodPost, path, "", true)
|
||||
noCSRF.Body = io.NopCloser(strings.NewReader(`{"action":"` + action + `"}`))
|
||||
noCSRF.Header.Set("Content-Type", "application/json")
|
||||
if got := d.do(noCSRF); got.status != http.StatusForbidden {
|
||||
t.Errorf("POST %s without the CSRF header = %d, want 403", path, got.status)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("capture intake is served without the dashboard token", func(t *testing.T) {
|
||||
accepted := d.do(d.request(http.MethodPost, "/webhooks/capture/demo", "", false))
|
||||
if accepted.status != http.StatusAccepted {
|
||||
t.Fatalf("POST /webhooks/capture/demo = %d (%s), want 202: this process is the only listener serving intake after the cutover", accepted.status, accepted.body)
|
||||
}
|
||||
listed := d.get("/api/captures")
|
||||
if listed.status != http.StatusOK || !strings.Contains(string(listed.body), `"enabled":true`) {
|
||||
t.Errorf("GET /api/captures = %d (%s), want the capture list over the State Store", listed.status, listed.body)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("routes with no owner degrade explicitly", func(t *testing.T) {
|
||||
// The daemon's log feed is host-local and has no contract, so the
|
||||
// page reports itself off rather than erroring
|
||||
// (docs/prds/ui-service-boundary.md, route family table).
|
||||
logs := d.get("/api/logs")
|
||||
if logs.status != http.StatusOK || !strings.Contains(string(logs.body), `"disabled":true`) {
|
||||
t.Errorf("GET /api/logs = %d (%s), want an explicit disabled report", logs.status, logs.body)
|
||||
}
|
||||
if version := d.get("/api/version"); version.status != http.StatusNotImplemented {
|
||||
t.Errorf("GET /api/version = %d, want 501: host-local update reporting stays with the daemon", version.status)
|
||||
}
|
||||
|
||||
// Configuration renders from the published snapshot, and this
|
||||
// process is not a second writer.
|
||||
rendered := d.get("/api/config")
|
||||
if rendered.status != http.StatusOK {
|
||||
t.Fatalf("GET /api/config = %d (%s), want 200", rendered.status, rendered.body)
|
||||
}
|
||||
var view webui.ConfigView
|
||||
if err := json.Unmarshal(rendered.body, &view); err != nil {
|
||||
t.Fatalf("decode config view: %v (%s)", err, rendered.body)
|
||||
}
|
||||
if view.Identity.BotUser != "archie-bot" {
|
||||
t.Errorf("config view = %s, want the published projection rendered read-only", rendered.body)
|
||||
}
|
||||
if got := d.do(d.request(http.MethodPatch, "/api/config", `{}`, true)); got.status != http.StatusMethodNotAllowed {
|
||||
t.Errorf("PATCH /api/config = %d, want 405: configuration is read here and written through the control plane", got.status)
|
||||
}
|
||||
|
||||
// The setup checklist reads the same projection. It reported
|
||||
// nothing here while it needed a live config.Holder this process
|
||||
// never receives (archie-core-ml30).
|
||||
setup := d.get("/api/setup")
|
||||
if setup.status != http.StatusOK {
|
||||
t.Fatalf("GET /api/setup = %d (%s), want 200", setup.status, setup.body)
|
||||
}
|
||||
var checklist struct {
|
||||
Steps []struct {
|
||||
Title string `json:"title"`
|
||||
Done bool `json:"done"`
|
||||
} `json:"steps"`
|
||||
Operator string `json:"operator"`
|
||||
}
|
||||
if err := json.Unmarshal(setup.body, &checklist); err != nil {
|
||||
t.Fatalf("decode setup checklist: %v (%s)", err, setup.body)
|
||||
}
|
||||
if len(checklist.Steps) == 0 {
|
||||
t.Errorf("setup checklist is empty; the published projection carries what it reads (%s)", setup.body)
|
||||
}
|
||||
if checklist.Operator != "Sam" {
|
||||
t.Errorf("setup operator = %q, want the published name", checklist.Operator)
|
||||
}
|
||||
for _, step := range checklist.Steps {
|
||||
if step.Title == "Connect a repository" && !step.Done {
|
||||
t.Errorf("checklist says no repository is connected; the projection publishes one (%s)", setup.body)
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
// Last: taking the State Store away is not reversible for this process.
|
||||
t.Run("losing a dependency degrades readiness without failing liveness", func(t *testing.T) {
|
||||
healthy := d.get("/health/detailed")
|
||||
if healthy.status != http.StatusOK {
|
||||
t.Fatalf("GET /health/detailed = %d (%s), want 200", healthy.status, healthy.body)
|
||||
}
|
||||
var report health.Report
|
||||
if err := json.Unmarshal(healthy.body, &report); err != nil {
|
||||
t.Fatalf("decode readiness: %v (%s)", err, healthy.body)
|
||||
}
|
||||
if report.Status != health.StatusOK {
|
||||
t.Fatalf("readiness = %s with both dependencies up, want ok (%s)", report.Status, healthy.body)
|
||||
}
|
||||
|
||||
stopState()
|
||||
degraded := d.get("/health/detailed")
|
||||
if err := json.Unmarshal(degraded.body, &report); err != nil {
|
||||
t.Fatalf("decode readiness after outage: %v (%s)", err, degraded.body)
|
||||
}
|
||||
if report.Status == health.StatusOK {
|
||||
t.Errorf("readiness stayed ok with the State Store stopped (%s)", degraded.body)
|
||||
}
|
||||
if live := d.do(d.request(http.MethodGet, "/healthz", "", false)); live.status != http.StatusOK {
|
||||
t.Errorf("GET /healthz = %d during a dependency outage, want 200: liveness must not imply dependency readiness", live.status)
|
||||
}
|
||||
})
|
||||
}
|
||||
+15
-5
@@ -5,6 +5,7 @@ import (
|
||||
"os"
|
||||
|
||||
"github.com/samcharles93/archie-core/internal/app/archied"
|
||||
"github.com/samcharles93/archie-core/internal/app/archieplaybooks"
|
||||
)
|
||||
|
||||
func main() {
|
||||
@@ -15,11 +16,20 @@ func main() {
|
||||
if archied.IsSetupArgs(args) {
|
||||
os.Exit(archied.RunSetup(args[1:], os.Stdin, os.Stdout, os.Stderr))
|
||||
}
|
||||
// The codesearch helper is dispatched before the daemon's flags are
|
||||
// parsed: it is this same binary re-invoked as a short-lived child by
|
||||
// internal/indexing, and it must not touch config, the store or NATS.
|
||||
if archied.IsCodesearchHelperArgs(args) {
|
||||
os.Exit(archied.RunCodesearchHelper(args[1:], os.Stdout))
|
||||
if len(args) > 0 && args[0] == "update" {
|
||||
os.Exit(archied.RunUpdate(args[1:], os.Stdout, os.Stderr))
|
||||
}
|
||||
if len(args) > 0 && args[0] == "update-image" {
|
||||
os.Exit(archied.RunUpdateImage(args[1:], os.Stderr))
|
||||
}
|
||||
if len(args) > 0 && args[0] == "update-topology" {
|
||||
os.Exit(archied.RunUpdateTopology(args[1:], os.Stdout, os.Stderr))
|
||||
}
|
||||
if len(args) > 0 && args[0] == "status" {
|
||||
os.Exit(archied.RunStatus(args[1:], os.Stdout, os.Stderr))
|
||||
}
|
||||
if len(args) > 0 && args[0] == "playbooks" {
|
||||
os.Exit(archieplaybooks.Run(args[1:], os.Stderr))
|
||||
}
|
||||
os.Exit(archied.Run())
|
||||
}
|
||||
+78
-115
@@ -3,31 +3,31 @@
|
||||
#
|
||||
# Secrets are NOT stored here: each one is a {engine, key}
|
||||
# reference resolved through a secrets engine at startup.
|
||||
# The built-in "env" engine reads key as an environment variable name;
|
||||
# "bws" (Bitwarden Secrets Manager) is compiled in. Custom engines are
|
||||
# Yaegi plugins loaded from this directory -- reference implementations
|
||||
# for sops, vault/openbao and age ship in examples/secret-engines/ and
|
||||
# each needs its CLI on PATH plus engine-specific env (sops: SOPS_FILE;
|
||||
# vault: VAULT_ADDR, VAULT_TOKEN, optional VAULT_SECRET_PATH;
|
||||
# age: AGE_FILE, AGE_IDENTITY).
|
||||
# secret_engine_dir = "~/.config/archie/secret-engines"
|
||||
# The built-in "env" engine reads key as an environment variable name.
|
||||
# Every other engine (bws, sops, vault, age) is an extension installed from
|
||||
# the archipelago marketplace and enabled through the control plane.
|
||||
|
||||
# work_dir = "~/.local/share/archie/work" # default
|
||||
# db_path = "~/.local/share/archie/archie.db" # prefix for independent task and conversation SQLite files
|
||||
# state_dir = "~/.local/share/archie" # default; embedded NATS store, task logs, disk probe
|
||||
|
||||
# The PostgreSQL connection archie-state-store, archied and archie-gateway
|
||||
# serve from. Required: each fails closed without it.
|
||||
# `docker compose up -d postgres` starts a matching local postgres:18 with this
|
||||
# default URL.
|
||||
# database_url = "postgres://archie:archie@127.0.0.1:5432/archie?sslmode=disable"
|
||||
|
||||
# skills_dir = "~/.local/share/archie/skills" # SKILL.md search path; defaults under work_dir when unset
|
||||
# plugin_dir = "~/.local/share/archie/plugins" # daemon plugin manifests; unset means no plugins are loaded
|
||||
# module_dir = "~/.local/share/archie/modules" # EDA playbook Module action kinds (log.go etc.); unset means no modules loaded
|
||||
# workflow_routing_file = "~/.local/share/archie/workflow-routing.yaml" # kind->workflow rebinding (bug/feature/bootstrap)
|
||||
# workflow_routing_file = "~/.local/share/archie/workflow-routing.yaml" # kind->workflow rebinding (bug/feature)
|
||||
# workflow_labels_file = "~/.local/share/archie/workflow-labels.yaml" # arbitrary forge label -> workflow (EDA playbook slice 2)
|
||||
# playbook_dirs = ["~/.local/share/archie/workflows"] # list of dirs of *.yaml binding files, merged with the two above (slice 3); a key bound twice across sources is a load failure
|
||||
# eda_playbook_dir = "~/.local/share/archie/eda-playbooks" # rich EDA playbook documents (one trigger; either a CEL-gated workflow action or a list of module actions); a matching workflow playbook decides the task's workflow ahead of the three binding sources above; distinct from playbook_dirs
|
||||
|
||||
poll_interval = "60s"
|
||||
label = "archie"
|
||||
bot_user = "vectis-labs-archie"
|
||||
# 0 switches the cap off; omit the key to take the built-in default (400).
|
||||
diff_cap_lines = 400
|
||||
# org = "acme" # empty means the default org (a single-operator install's one identity)
|
||||
# granted_credentials = ["openai"] # credential@1 services the root identity may resolve (see [containers.credentials])
|
||||
|
||||
# how many operator-triggered retries a parked task gets
|
||||
# before it moves to dead (global default; set per-repo to
|
||||
@@ -35,6 +35,8 @@ diff_cap_lines = 400
|
||||
# max_retries = 3
|
||||
|
||||
[forge]
|
||||
# The name of an installed, enabled forge package (archipelago: forge/github, forge/gitea), or "none".
|
||||
# Install and enable it from the Extensions page, then restart archied.
|
||||
type = "github"
|
||||
host = "https://github.com"
|
||||
token = { engine = "env", key = "ARCHIE_GITHUB_TOKEN" }
|
||||
@@ -61,14 +63,15 @@ token = { engine = "env", key = "ARCHIE_GITHUB_TOKEN" }
|
||||
# intake per identity is a pending migration, not a setting.
|
||||
|
||||
# [[identities]] runs more than one bot identity from a single daemon, each
|
||||
# with its own forge/dispatch/models/providers/budgets/notify -- see
|
||||
# docs/architecture/identity.md for the full design and constraints (e.g.
|
||||
# intake settings are rejected per identity, and [forge].intake =
|
||||
# "webhook"/"both" is rejected alongside [[identities]]). Minimal shape:
|
||||
# with its own forge/dispatch/models/providers/budgets/notify. Intake
|
||||
# settings are rejected per identity, and [forge].intake = "webhook"/"both"
|
||||
# is rejected alongside [[identities]]. Minimal shape:
|
||||
# [[identities]]
|
||||
# name = "personal" # required; namespaces logs/events/NATS subjects
|
||||
# bot_user = "your-bot" # required
|
||||
# forge = { type = "github", host = "https://github.com", token = { engine = "env", key = "ARCHIE_GITHUB_TOKEN_PERSONAL" } }
|
||||
# org = "acme" # empty inherits the shared org (empty = default)
|
||||
# granted_credentials = ["openai"] # credential@1 services this identity may resolve (see [containers.credentials])
|
||||
|
||||
[dispatch]
|
||||
# Can be of "assignee", "label", or "either"
|
||||
@@ -79,21 +82,6 @@ trigger = "assignee"
|
||||
# setting this to "off" disables the pickup reactions.
|
||||
ack_reaction = "eyes"
|
||||
|
||||
# dispatch.labels maps each task lifecycle state to the label
|
||||
# Archie applies on the issue.
|
||||
# You can rename labels to match your project's conventions,
|
||||
# or comment one out to skip that transition.
|
||||
# The labels are the *source of truth* for the dispatch loop: Archie
|
||||
# scans for issues bearing queued, then moves them through working →
|
||||
# waiting → pr → parked (→ dead when max_retries is exhausted).
|
||||
[dispatch.labels]
|
||||
queued = "archie:queued"
|
||||
working = "archie:working"
|
||||
waiting = "archie:waiting"
|
||||
pr = "archie:pr"
|
||||
parked = "archie:parked"
|
||||
# dead = "archie:dead" # state label for a task that exhausted max_retries
|
||||
|
||||
[models] # role -> ai-sdk runtime ref (used by agent workflows)
|
||||
triage = "openai/gpt-5.4"
|
||||
planner = "openai/gpt-5.4"
|
||||
@@ -105,11 +93,15 @@ builder = "openai/gpt-5.4"
|
||||
# (curators first). Unset, or a credential that fails to resolve, degrades
|
||||
# to the capability reporting unavailable -- archied still starts.
|
||||
# embedding = "openai/text-embedding-3-small"
|
||||
# `transcription` is optional: it turns Telegram voice notes into text before
|
||||
# the turn is dispatched, behind a "[voice transcription]" marker. Read by
|
||||
# archie-messaging. Unset, or a provider that does not resolve, leaves the
|
||||
# voice note as its media placeholder -- the turn still runs.
|
||||
# transcription = "openai/whisper-1"
|
||||
|
||||
[providers.openai]
|
||||
class = "openai"
|
||||
api_key = { engine = "bws", key = "OPENAI_API_KEY" }
|
||||
# api_key_env = "OPENAI_API_KEY" # backwards-compatible environment form
|
||||
# [providers.openai]
|
||||
# class = "openai"
|
||||
# api_key = { engine = "env", key = "OPENAI_API_KEY" }
|
||||
|
||||
[providers.ollama]
|
||||
class = "ollama"
|
||||
@@ -154,45 +146,13 @@ class = "ollama"
|
||||
# "openrouter/openai/gpt-5.6-sol",
|
||||
# ]
|
||||
|
||||
# Optional self-hosted update adapter. Both values are argv arrays (never
|
||||
# shell snippets). The check command must write a releaseupdate.Snapshot JSON
|
||||
# document to stdout; configure the installer as well to show Approve/Defer.
|
||||
# [chat.telegram]
|
||||
# Preferred: resolve the bot token through a configured secret engine.
|
||||
# The bot token from @BotFather, resolved through a configured secret engine.
|
||||
# token = { engine = "bws", key = "TELEGRAM_BOT_TOKEN" }
|
||||
# Legacy compatibility: read the token from this environment variable.
|
||||
# token_env = "TELEGRAM_BOT_TOKEN" # env var holding the bot token from @BotFather
|
||||
# Run by archie-messaging, which serves /update, so these commands execute on
|
||||
# whichever host runs that process.
|
||||
# update_check_command = ["/usr/local/bin/archie-update-check"]
|
||||
# update_install_command = ["/usr/local/bin/archie-update-install"]
|
||||
|
||||
# Inbound email as a chat channel, via SMTP. Empty listen_addr disables it.
|
||||
# [chat.email]
|
||||
# listen_addr = "0.0.0.0:2525" # inbound SMTP server
|
||||
# relay_addr = "smtp.example.com:587" # outbound relay for replies
|
||||
|
||||
# Generic inbound webhook gateway: external services push messages into
|
||||
# chat for LLM processing. This is a distinct surface from
|
||||
# [forge].webhook_addr (forge issue events) and [capture] (unbound event
|
||||
# storage for later binding) -- three different inbound HTTP concerns that
|
||||
# happen to share the word "webhook".
|
||||
# webhook_addr = "0.0.0.0:8646" # under [chat], not [chat.telegram]
|
||||
#
|
||||
# [chat.webhook] configures the single route the gateway serves. Every
|
||||
# field is optional; an absent section runs with the pre-existing
|
||||
# behaviour: path "/webhook", no signature validation, raw body as message
|
||||
# text, no reply.
|
||||
# [chat.webhook]
|
||||
# path = "/webhook"
|
||||
# secret = { engine = "bws", key = "CHAT_WEBHOOK_SECRET" } # verifies
|
||||
# # X-Hub-Signature-256 on inbound payloads. Empty (the default) accepts
|
||||
# # any unsigned POST -- set this to make the gateway actually verify
|
||||
# # what it claims to.
|
||||
# template = "issue.title" # dot-notation extraction of the message text
|
||||
# # from the JSON payload. Empty uses the raw body.
|
||||
# deliver_to = "origin" # "origin" writes the reply as the HTTP
|
||||
# # response; empty (the default) sends no reply.
|
||||
# Email and the generic inbound webhook are archipelago channel extensions
|
||||
# (channels/email, channels/webhook): install, accept and enable them from the
|
||||
# Extensions page, with their settings there.
|
||||
|
||||
# Per-(channel, sender) inbound rate limiting, shared by every chat channel:
|
||||
# Telegram keys by numeric user ID, email by SMTP from address, webhook by
|
||||
@@ -227,13 +187,6 @@ class = "ollama"
|
||||
# work_dir = "/path/to/workspace"
|
||||
# parallel_tool_calls = false
|
||||
|
||||
# Workspace code-search index. Paths default under work_dir when unset.
|
||||
[indexing]
|
||||
# Code-search index files (default: <work_dir>/indexes).
|
||||
# index_dir = "/var/lib/archie/indexes"
|
||||
# Per-index lifecycle metadata DB (default: <work_dir>/workspace-indexes.db).
|
||||
# db_path = "/var/lib/archie/workspace-indexes.db"
|
||||
|
||||
# archied's own liveness surface, always on. GET /healthz and /health answer
|
||||
# 200 once the daemon is serving (503 while it is still booting), and
|
||||
# /health/detailed reports the readiness probes. This is what the update
|
||||
@@ -254,7 +207,7 @@ listen = "127.0.0.1:8485"
|
||||
# and streaming API. Auth is token-based for non-loopback addresses;
|
||||
# loopback binds (127.0.0.1, ::1, localhost) skip auth automatically.
|
||||
#
|
||||
# From the UI cutover (archie-core-8cda.5.4) the dashboard is served by the
|
||||
# The dashboard is served by the
|
||||
# standalone archie-ui process, not by archied: this listen address is what
|
||||
# archie-ui binds, and archied runs no dashboard listener at all. Run
|
||||
# `archie-ui -config <same config.toml>` alongside the other services.
|
||||
@@ -295,23 +248,6 @@ listen = "127.0.0.1:8484"
|
||||
# [memory]
|
||||
# engine = "builtin" # "builtin" is the only engine implemented so far
|
||||
|
||||
# Image generation capability (internal/domain/image). No provider is
|
||||
# implemented yet -- this section defines the contract/config surface only
|
||||
# (archie-core-1786748942147-2-47cd5bd1). Absent is valid and registers no
|
||||
# provider. default names the provider /image uses without asking; leaving
|
||||
# it unset means /image always asks which mechanism to use. Every provider
|
||||
# is off by default -- a hosted provider spends real API credits per call,
|
||||
# and a local one can saturate the host GPU, so both require an explicit
|
||||
# enabled = true, never an inferred one from the presence of a key alone.
|
||||
# [image.hosted.openai]
|
||||
# enabled = false
|
||||
# class = "openai"
|
||||
# api_key_env = "OPENAI_API_KEY"
|
||||
#
|
||||
# [image.local.sdxl]
|
||||
# enabled = false
|
||||
# backend = "sdxl-turbo"
|
||||
|
||||
# Notifications for human-in-the-loop moments
|
||||
# (approval requests, gate failures, parked tasks).
|
||||
# Archie POSTs a JSON payload to the webhook
|
||||
@@ -321,11 +257,11 @@ listen = "127.0.0.1:8484"
|
||||
|
||||
[budgets]
|
||||
max_steps = 60
|
||||
wall_clock = "30m"
|
||||
wall_clock = "30m" # one agent call
|
||||
gate_max_failures = 5
|
||||
task_wall_clock = "4h" # a whole task run; keep containers.max_uptime at or above it
|
||||
|
||||
# Services selects contract adapters at composition time (see
|
||||
# docs/prds/state-store-contract.md).
|
||||
# Services selects contract adapters at composition time.
|
||||
[services.gateway]
|
||||
target = "127.0.0.1:8585" # archie-gateway's gRPC address (always remote once set)
|
||||
# listen = "127.0.0.1:8585" # The address archie-gateway BINDS. Read only by the
|
||||
@@ -341,10 +277,9 @@ target = "127.0.0.1:8585" # archie-gateway's gRPC address (always remot
|
||||
|
||||
[services.state]
|
||||
target = "127.0.0.1:9090" # REQUIRED. The State Store gRPC address archied and
|
||||
# # archie-gateway dial. They no longer own archie.db
|
||||
# # archie-gateway dial. They own no task data
|
||||
# # in-process: the standalone archie-state-store process
|
||||
# # owns the single SQLite file (docs/prds/state-store-contract.md
|
||||
# # §10/§12 step 7). An empty target is a startup error.
|
||||
# # owns it in PostgreSQL. An empty target is a startup error.
|
||||
# listen = "127.0.0.1:9090" # The address archie-state-store BINDS. Read only by that
|
||||
# # process; every client ignores it. Defaults to the target
|
||||
# # above, so a default deployment's client and server cannot
|
||||
@@ -352,8 +287,7 @@ target = "127.0.0.1:9090" # REQUIRED. The State Store gRPC address arch
|
||||
# # taken on the host.
|
||||
# target_token = "..." # bearer token for a NON-loopback target. A loopback target
|
||||
# # (127.0.0.1/::1/localhost) needs no token. A non-loopback
|
||||
# # target without a token fails closed (docs/prds/state-store-contract.md
|
||||
# # §9). The same token is injected as STATE_STORE_TOKEN into
|
||||
# # target without a token fails closed. The same token is injected as STATE_STORE_TOKEN into
|
||||
# # archie-agent containers so the agent authenticates to the
|
||||
# # same remote store. See deployments/README.md for how to
|
||||
# # start archie-state-store.
|
||||
@@ -370,14 +304,13 @@ target = "127.0.0.1:9090" # REQUIRED. The State Store gRPC address arch
|
||||
|
||||
# Unbound webhook capture: POST /webhooks/capture/{source} accepts and
|
||||
# stores any inbound payload archie doesn't yet have a binding for, so it can
|
||||
# be inspected and mapped later (see docs/prds/event-capture-storage.md).
|
||||
# Stored in the same SQLite database as tasks, not NATS -- capture has one
|
||||
# be inspected and mapped later.
|
||||
# Stored in the same PostgreSQL database as tasks, not NATS -- capture has one
|
||||
# writer and one (human, dashboard) reader, so it doesn't need JetStream's
|
||||
# fan-out/replay machinery, and SQLite is available in every deployment
|
||||
# shape unconditionally. All fields default when the section is absent;
|
||||
# fan-out/replay machinery. All fields default when the section is absent;
|
||||
# capture is on by default.
|
||||
#
|
||||
# From the UI cutover (archie-core-8cda.5.4) the receiver is mounted by the
|
||||
# The receiver is mounted by the
|
||||
# archie-ui process, which projects these same values from this file; the
|
||||
# daemon's binding-dispatch loop consumes captures from the shared State
|
||||
# Store. Leave this section here even if you do not edit it: both processes
|
||||
@@ -427,8 +360,8 @@ target = "127.0.0.1:9090" # REQUIRED. The State Store gRPC address arch
|
||||
|
||||
# Playbook-binding at-rest encryption: [bindings].encryption_key resolves a
|
||||
# 32-byte high-entropy key through the secret registry (engine + key) and seals
|
||||
# each binding's HMAC secret in the SQLite bindings.secret column with AES-256-
|
||||
# GCM (see docs/prds/binding-secret-encryption.md). When the key is absent,
|
||||
# each binding's HMAC secret in the bindings.secret column with AES-256-
|
||||
# GCM. When the key is absent,
|
||||
# binding secrets are stored as plaintext (the pre-t2db.7 behaviour) -- enabling
|
||||
# encryption does not retroactively encrypt existing rows, which stay plaintext
|
||||
# until they are edited. Rotation: after changing encryption_key, retain the
|
||||
@@ -450,6 +383,39 @@ target = "127.0.0.1:9090" # REQUIRED. The State Store gRPC address arch
|
||||
# max_uptime = "60m" # container lifetime cap
|
||||
# volume_ttl = "72h" # max age for persistent repo volumes and Git clone caches
|
||||
# pull_policy = "missing" # "missing" or "always"
|
||||
#
|
||||
# A private registry needs a credential the daemon sends on pull (an
|
||||
# anonymous pull always answers 401 there, whatever the policy). The value is
|
||||
# a Docker registry.AuthConfig JSON document -- {"username":"bot","password":"..."}
|
||||
# ("identitytoken"/"registrytoken" are alternatives; "serveraddress" is
|
||||
# optional and defaults to the image's registry). Unset means anonymous pulls,
|
||||
# exactly as before this key existed; a reference that cannot be resolved
|
||||
# warns and pulls anonymously rather than failing the daemon.
|
||||
# registry_auth = { engine = "env", key = "ARCHIE_REGISTRY_AUTH" }
|
||||
#
|
||||
# Agent profiles a workflow selects with `profile: <name>`. A workflow that
|
||||
# names none runs under [containers].image with every tool.
|
||||
# Once the State Store holds container policies, edit profiles in the
|
||||
# dashboard (Settings, Advanced); a stored set replaces the file's.
|
||||
# [containers.profiles.network-investigator]
|
||||
# image = "archie-agent-net:local" # docker compose build agent-net; empty uses [containers].image
|
||||
# tools = [] # allowlist over MCP, script and plugin tools; empty allows all
|
||||
# A Kit profile runs every agent stage on an external CLI packaged as a Kit v3
|
||||
# image: one workload Kit or published Kit set (which merges a workload with
|
||||
# its mixins), pinned by digest.
|
||||
# [containers.profiles.claude]
|
||||
# kit = "docker/claude-code-kit@sha256:<digest>"
|
||||
# adapter = "claude-code" # claude-code, codex, pi, omp or copilot; empty runs without capture tools or usage
|
||||
#
|
||||
# Credential bindings map a Kit's credential@1 service name to a secret. A
|
||||
# binding alone grants nothing -- an identity resolves it only when its own
|
||||
# org matches and the service is in its granted_credentials
|
||||
# ([[identities]] above). Once the State Store holds it, edit bindings in the
|
||||
# dashboard (Settings, Advanced); a stored set replaces the file's.
|
||||
# [[containers.credentials]]
|
||||
# service = "openai"
|
||||
# org = "acme" # empty means the default org
|
||||
# secret = {engine = "env", key = "OPENAI_API_KEY"}
|
||||
|
||||
# At least one [[repos]] entry is required before archied will poll
|
||||
# anything -- it is deliberately left commented rather than shipped active:
|
||||
@@ -481,9 +447,6 @@ target = "127.0.0.1:9090" # REQUIRED. The State Store gRPC address arch
|
||||
# # [containers].max_concurrency globally.
|
||||
# # persistent_storage = true # reuse a per-repo Docker volume and Git object cache until volume_ttl
|
||||
# # max_retries = 5 # per-repo override of the global max_retries above
|
||||
# # review_enabled = true # run a fresh adversarial reviewer (no path to the implementer's
|
||||
# # context) after gates pass and before the PR opens. Default false --
|
||||
# # an uncalibrated reviewer that cries wolf is worse than no review.
|
||||
|
||||
# ── Tools ───────────────────────────────────────────────────────────────────
|
||||
# Limits on what a tool may return. These bound how much of the context window
|
||||
|
||||
+2
-9
@@ -1,12 +1,5 @@
|
||||
// Package configtemplate embeds config.example.toml so archied setup can
|
||||
// generate a first-run config.toml from the exact file operators already
|
||||
// read as documentation, instead of a second copy that can drift from it.
|
||||
//
|
||||
// It lives at the module root, rather than under internal/, because embed
|
||||
// patterns cannot reach outside the directory of the .go file that declares
|
||||
// them, and config.example.toml is kept at the root where it is easy to
|
||||
// find and hand-edit. (Written without the directive prefix on purpose:
|
||||
// staticcheck reads "// go:embed" in prose as a malformed directive.)
|
||||
// Package configtemplate embeds config.example.toml for archied setup. It
|
||||
// sits at the module root because embed cannot reach parent directories.
|
||||
package configtemplate
|
||||
|
||||
import _ "embed"
|
||||
|
||||
@@ -1,314 +0,0 @@
|
||||
package configtemplate
|
||||
|
||||
import (
|
||||
"os"
|
||||
"path/filepath"
|
||||
"sort"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestDeployWorkflowOnlyPublishesRuntimeImageForRuntimeTag(t *testing.T) {
|
||||
source := readDeploymentFile(t, ".github/workflows/deploy.yml")
|
||||
|
||||
// The fallback remains necessary because Dockerfile.archied accepts a
|
||||
// runtime version, but it must not be used as the image-publish selector.
|
||||
for _, required := range []string{
|
||||
`RUNTIME_TAG="$(git tag --points-at HEAD --list 'archie/v*' | sort -V | tail -1)"`,
|
||||
`echo "runtime_tag=$RUNTIME_TAG" >> "$GITHUB_OUTPUT"`,
|
||||
"if: steps.versions.outputs.runtime_tag != ''",
|
||||
} {
|
||||
if !strings.Contains(source, required) {
|
||||
t.Errorf("deploy workflow is missing runtime-image guard %q", required)
|
||||
}
|
||||
}
|
||||
|
||||
// The gateway build remains unconditional, while the runtime build is
|
||||
// guarded. This verifies both sides of the gateway-only/dual-tag contract.
|
||||
agentMarker := " - name: Build and push archie-agent\n"
|
||||
agentStart := strings.Index(source, agentMarker)
|
||||
if agentStart < 0 {
|
||||
t.Fatal("deploy workflow has no archie-agent build step")
|
||||
}
|
||||
if !strings.Contains(source[agentStart:], agentMarker+" if: steps.versions.outputs.runtime_tag != ''\n") {
|
||||
t.Fatal("archie-agent build step is not conditionally enabled")
|
||||
}
|
||||
|
||||
gatewayMarker := " - name: Build and push archied\n"
|
||||
gatewayStart := strings.Index(source, gatewayMarker)
|
||||
if gatewayStart < 0 {
|
||||
t.Fatal("deploy workflow has no archied build step")
|
||||
}
|
||||
if strings.Contains(source[gatewayStart:agentStart], "\n if:") {
|
||||
t.Fatal("archied build step is unexpectedly conditional")
|
||||
}
|
||||
}
|
||||
|
||||
func TestDeployWorkflowUsesConfiguredFormatters(t *testing.T) {
|
||||
source := readDeploymentFile(t, ".github/workflows/deploy.yml")
|
||||
for _, required := range []string{
|
||||
"github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.13.2",
|
||||
"golangci-lint fmt",
|
||||
"git diff --exit-code",
|
||||
"golangci-lint run ./...",
|
||||
} {
|
||||
if !strings.Contains(source, required) {
|
||||
t.Errorf("deploy workflow is missing formatter gate %q", required)
|
||||
}
|
||||
}
|
||||
if strings.Contains(source, "gofumpt -w .") {
|
||||
t.Error("deploy workflow bypasses the configured formatter set")
|
||||
}
|
||||
}
|
||||
|
||||
func TestPullRequestsRunTheDefinitiveGateWithoutPublishAccess(t *testing.T) {
|
||||
source := readDeploymentFile(t, ".github/workflows/quality.yml")
|
||||
for _, required := range []string{
|
||||
"pull_request:",
|
||||
"contents: read",
|
||||
"task check",
|
||||
"git diff --exit-code",
|
||||
} {
|
||||
if !strings.Contains(source, required) {
|
||||
t.Errorf("quality workflow is missing %q", required)
|
||||
}
|
||||
}
|
||||
for _, forbidden := range []string{
|
||||
"packages: write",
|
||||
"docker/login-action",
|
||||
"docker/build-push-action",
|
||||
} {
|
||||
if strings.Contains(source, forbidden) {
|
||||
t.Errorf("quality workflow has publishing capability %q", forbidden)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// unpackagedCommands are commands that deliberately never ship as a host binary.
|
||||
// Naming each one with its reason keeps an omission a decision rather than an
|
||||
// oversight -- which is exactly how archied's channels were lost.
|
||||
var unpackagedCommands = map[string]string{
|
||||
"archie-agent": "runs only inside the Docker image build-and-push publishes, never as a host binary",
|
||||
}
|
||||
|
||||
// cliOnlyCommands ship in the zip but must never be restarted by the updater:
|
||||
// they are not services.
|
||||
var cliOnlyCommands = map[string]bool{"archie-playbooks": true}
|
||||
|
||||
// TestDistZipShipsEveryHostCommand is why archie-core-1c01 went unnoticed for
|
||||
// two days. The v1.30.0 extraction moved Telegram, email and webhook out of
|
||||
// archied into a new cmd/archie-messaging that nothing packaged: the release zip
|
||||
// omitted it, scripts/archie-update-install omitted it from both of its lists,
|
||||
// and install.sh's build loop omitted it too, so a host install ran on with a
|
||||
// dead Telegram bot and no error logged anywhere. The daemon looked healthy
|
||||
// throughout.
|
||||
//
|
||||
// The host component set was enumerated independently in four places (the zip's
|
||||
// build loop, the zip's copy list, install.sh's build loop, and the updater's
|
||||
// two lists), so two coordinated edits would have drifted again. Every list is
|
||||
// pinned to cmd/ here instead: adding a command fails this test until it is
|
||||
// packaged, and extracting one fails it until the previous command is removed.
|
||||
// The updater's service list is separately required to have a documented unit,
|
||||
// and its runtime guard refuses a host unit the list omits.
|
||||
func TestDistZipShipsEveryHostCommand(t *testing.T) {
|
||||
workflow := readDeploymentFile(t, ".github/workflows/deploy.yml")
|
||||
installer := readDeploymentFile(t, filepath.Join("scripts", "archie-update-install"))
|
||||
installSh := readDeploymentFile(t, "install.sh")
|
||||
|
||||
want := hostRunCommands(t)
|
||||
wantBinaries := want
|
||||
wantServices := withoutCLIOnly(want)
|
||||
|
||||
built := wordsAfter(t, workflow, "for cmd in ", "; do", nil)
|
||||
// The marker consumes the prefix of the first word only, so restore it for
|
||||
// whichever word the marker ended inside.
|
||||
var shipped []string
|
||||
for _, word := range wordsAfter(t, workflow, "cp dist/", ` "$name/"`, nil) {
|
||||
if !strings.HasPrefix(word, "dist/") {
|
||||
word = "dist/" + word
|
||||
}
|
||||
shipped = append(shipped, strings.TrimPrefix(word, "dist/"))
|
||||
}
|
||||
services := wordsAfter(t, installer, `GATEWAY_SERVICES="`, `"`, nil)
|
||||
binaries := wordsAfter(t, installer, `GATEWAY_BINARIES="`, `"`, map[string][]string{"$GATEWAY_SERVICES": services})
|
||||
installBuilt := installBuildCommands(t, installSh)
|
||||
|
||||
for _, list := range []struct {
|
||||
name string
|
||||
got []string
|
||||
want []string
|
||||
}{
|
||||
{"deploy.yml dist-zip build loop", built, wantBinaries},
|
||||
{"deploy.yml dist-zip copy list", shipped, wantBinaries},
|
||||
{"install.sh build loop", installBuilt, wantBinaries},
|
||||
{"archie-update-install GATEWAY_BINARIES", binaries, wantBinaries},
|
||||
{"archie-update-install GATEWAY_SERVICES", services, wantServices},
|
||||
} {
|
||||
if diff := setDifference(list.want, list.got); diff != "" {
|
||||
t.Errorf("%s does not match the host-run commands in cmd/: %s", list.name, diff)
|
||||
}
|
||||
}
|
||||
|
||||
// The installer now REFUSES an update when a service unit is missing and
|
||||
// tells the operator to create it from this runbook, so a service the
|
||||
// runbook never shows is a dead end rather than a documentation gap.
|
||||
// Stamping is its own list, and a third build site made it three: the zip,
|
||||
// install.sh and the updater each build the host binaries. A binary that
|
||||
// cannot say what it is cannot be compared (archie-core-k94o), so a seventh
|
||||
// command added unstamped fails here rather than waiting to be noticed.
|
||||
for name, source := range map[string]string{
|
||||
"deploy.yml": workflow,
|
||||
"install.sh": installSh,
|
||||
"archie-update-install": installer,
|
||||
} {
|
||||
if !strings.Contains(source, "internal/buildinfo.Version=") {
|
||||
t.Errorf("%s does not stamp internal/buildinfo.Version", name)
|
||||
}
|
||||
}
|
||||
for _, command := range wantBinaries {
|
||||
// archied's flag lives in the app package it delegates to, not its thin
|
||||
// cmd main; the rest report through buildinfo in their own main.
|
||||
source := filepath.Join("cmd", command, "main.go")
|
||||
if command == "archied" {
|
||||
source = filepath.Join("internal", "app", "archied", "main.go")
|
||||
}
|
||||
main := readDeploymentFile(t, source)
|
||||
if !strings.Contains(main, "buildinfo") && !strings.Contains(main, "-version") && !strings.Contains(main, "\"version\"") {
|
||||
t.Errorf("%s has no way to report its version", source)
|
||||
}
|
||||
}
|
||||
|
||||
// The installer writes the units, so the runbook no longer carries their
|
||||
// contents; it must still name each unit, or an operator cannot find one to
|
||||
// inspect or override.
|
||||
runbook := readDeploymentFile(t, filepath.Join("deployments", "systemd-user-service.md"))
|
||||
var undocumented []string
|
||||
for _, service := range wantServices {
|
||||
if !strings.Contains(runbook, service+".service") {
|
||||
undocumented = append(undocumented, service)
|
||||
}
|
||||
}
|
||||
if len(undocumented) > 0 {
|
||||
t.Errorf("deployments/systemd-user-service.md names no unit for: %s", strings.Join(undocumented, " "))
|
||||
}
|
||||
}
|
||||
|
||||
// installBuildCommands reads install.sh's build loop. The file has a second
|
||||
// `for cmd in` (the git/go preflight), so the loop is located by the go build it
|
||||
// drives rather than by the first marker -- and read from the real list, so a
|
||||
// missing command is named instead of the marker merely going absent.
|
||||
func installBuildCommands(t *testing.T, source string) []string {
|
||||
t.Helper()
|
||||
before, _, ok := strings.Cut(source, `go build -ldflags "${LDFLAGS}"`)
|
||||
if !ok {
|
||||
t.Fatal("install.sh has no go build loop to read")
|
||||
}
|
||||
prefix := before
|
||||
start := strings.LastIndex(prefix, "for cmd in ")
|
||||
if start < 0 {
|
||||
t.Fatal("install.sh build loop has no for cmd list")
|
||||
}
|
||||
rest := prefix[start+len("for cmd in "):]
|
||||
before0, _, ok0 := strings.Cut(rest, "; do")
|
||||
if !ok0 {
|
||||
t.Fatal("install.sh build loop is unterminated")
|
||||
}
|
||||
return strings.Fields(before0)
|
||||
}
|
||||
|
||||
// hostRunCommands is every command under cmd/, minus the deliberately
|
||||
// unpackaged ones. Deriving it is the point: a list written out here would drift
|
||||
// from cmd/ exactly as the packaged lists did.
|
||||
func hostRunCommands(t *testing.T) []string {
|
||||
t.Helper()
|
||||
entries, err := os.ReadDir("cmd")
|
||||
if err != nil {
|
||||
t.Fatalf("read cmd/: %v", err)
|
||||
}
|
||||
var commands []string
|
||||
for _, entry := range entries {
|
||||
if !entry.IsDir() {
|
||||
continue
|
||||
}
|
||||
if _, skip := unpackagedCommands[entry.Name()]; skip {
|
||||
continue
|
||||
}
|
||||
commands = append(commands, entry.Name())
|
||||
}
|
||||
if len(commands) == 0 {
|
||||
t.Fatal("cmd/ holds no commands: this guard would assert nothing")
|
||||
}
|
||||
sort.Strings(commands)
|
||||
return commands
|
||||
}
|
||||
|
||||
func withoutCLIOnly(commands []string) []string {
|
||||
out := make([]string, 0, len(commands))
|
||||
for _, command := range commands {
|
||||
if cliOnlyCommands[command] {
|
||||
continue
|
||||
}
|
||||
out = append(out, command)
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
// wordsAfter returns the whitespace-separated words between two markers on the
|
||||
// same line. expand maps a word to the words it stands for, which is how the
|
||||
// installer's "$GATEWAY_SERVICES" reference is followed to what it names.
|
||||
func wordsAfter(t *testing.T, source, marker, terminator string, expand map[string][]string) []string {
|
||||
t.Helper()
|
||||
start := strings.Index(source, marker)
|
||||
if start < 0 {
|
||||
t.Fatalf("no %q in the file under test", marker)
|
||||
}
|
||||
rest := source[start+len(marker):]
|
||||
end := strings.Index(rest, terminator)
|
||||
if end < 0 {
|
||||
t.Fatalf("no %q after %q", terminator, marker)
|
||||
}
|
||||
var words []string
|
||||
for word := range strings.FieldsSeq(rest[:end]) {
|
||||
if replacement, ok := expand[word]; ok {
|
||||
words = append(words, replacement...)
|
||||
continue
|
||||
}
|
||||
words = append(words, word)
|
||||
}
|
||||
return words
|
||||
}
|
||||
|
||||
// setDifference names what is missing from and extra in got, so a failure says
|
||||
// which side moved rather than that two lists differ.
|
||||
func setDifference(want, got []string) string {
|
||||
present := make(map[string]bool, len(got))
|
||||
for _, item := range got {
|
||||
present[item] = true
|
||||
}
|
||||
var missing []string
|
||||
for _, item := range want {
|
||||
if !present[item] {
|
||||
missing = append(missing, item)
|
||||
}
|
||||
}
|
||||
expected := make(map[string]bool, len(want))
|
||||
for _, item := range want {
|
||||
expected[item] = true
|
||||
}
|
||||
var extra []string
|
||||
for _, item := range got {
|
||||
if !expected[item] {
|
||||
extra = append(extra, item)
|
||||
}
|
||||
}
|
||||
sort.Strings(missing)
|
||||
sort.Strings(extra)
|
||||
var problems []string
|
||||
if len(missing) > 0 {
|
||||
problems = append(problems, "missing "+strings.Join(missing, " "))
|
||||
}
|
||||
if len(extra) > 0 {
|
||||
problems = append(problems, "unexpected "+strings.Join(extra, " "))
|
||||
}
|
||||
return strings.Join(problems, "; ")
|
||||
}
|
||||
@@ -1,269 +0,0 @@
|
||||
package configtemplate
|
||||
|
||||
import (
|
||||
"os"
|
||||
"regexp"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/samcharles93/archie-core/internal/config"
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/configuration"
|
||||
)
|
||||
|
||||
func readDeploymentFile(t *testing.T, path string) string {
|
||||
t.Helper()
|
||||
data, err := os.ReadFile(path)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
return string(data)
|
||||
}
|
||||
|
||||
func TestExternalNATSProfileLoadsWithManagedWorkers(t *testing.T) {
|
||||
doc, err := configuration.New(nil).File("deployments/docker-nats-stack.toml")
|
||||
if err != nil {
|
||||
t.Fatalf("load external NATS deployment: %v", err)
|
||||
}
|
||||
if doc.Config.NATS.Mode != config.NATSModeExternal {
|
||||
t.Errorf("NATS mode = %q, want %q", doc.Config.NATS.Mode, config.NATSModeExternal)
|
||||
}
|
||||
if doc.Config.Containers.Image == "" {
|
||||
t.Error("managed worker image is empty")
|
||||
}
|
||||
legacy := doc.Config.LegacyAgent
|
||||
if legacy.Mode != "" || legacy.Command != "" || len(legacy.Env) != 0 {
|
||||
t.Errorf("legacy agent selector decoded from supported profile: %#v", doc.Config.LegacyAgent)
|
||||
}
|
||||
}
|
||||
|
||||
func TestInstallerUsesNativeDaemonAndManagedWorkerImage(t *testing.T) {
|
||||
source := readDeploymentFile(t, "install.sh")
|
||||
for _, forbidden := range []string{
|
||||
"[agent]",
|
||||
`go build -o "${ARCHIE_BIN_DIR}/archie-agent"`,
|
||||
`- archie-agent`,
|
||||
"required only for NATS container mode",
|
||||
} {
|
||||
if strings.Contains(source, forbidden) {
|
||||
t.Errorf("install.sh contains removed deployment behavior %q", forbidden)
|
||||
}
|
||||
}
|
||||
for _, required := range []string{
|
||||
`ExecStart=${ARCHIE_BIN_DIR}/archied`,
|
||||
"Docker is required for autonomous workflows",
|
||||
} {
|
||||
if !strings.Contains(source, required) {
|
||||
t.Errorf("install.sh is missing deployment contract %q", required)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestWorkerImageIsNotDocumentedAsAStandaloneExecutor(t *testing.T) {
|
||||
source := readDeploymentFile(t, "Dockerfile")
|
||||
if strings.Contains(source, "docker run -e NATS_URL") {
|
||||
t.Error("Dockerfile documents an unsupported manually started worker")
|
||||
}
|
||||
if !strings.Contains(source, "launched only by archied") {
|
||||
t.Error("Dockerfile does not state that archied owns worker lifecycle")
|
||||
}
|
||||
}
|
||||
|
||||
func TestFormattingUsesOneConfiguredWriter(t *testing.T) {
|
||||
taskfile := readDeploymentFile(t, "Taskfile.yml")
|
||||
fmtStart := strings.Index(taskfile, " fmt:\n")
|
||||
fmtEnd := strings.Index(taskfile, " proto:install:\n")
|
||||
if fmtStart < 0 || fmtEnd < fmtStart {
|
||||
t.Fatal("Taskfile has no bounded fmt task")
|
||||
}
|
||||
fmtTask := taskfile[fmtStart:fmtEnd]
|
||||
|
||||
const (
|
||||
applyFix = "go fix ./..."
|
||||
verifyFix = "go fix -diff ./..."
|
||||
)
|
||||
fix := strings.Index(fmtTask, applyFix)
|
||||
format := strings.Index(fmtTask, "golangci-lint fmt")
|
||||
if fix < 0 || format < 0 || fix > format {
|
||||
t.Error("fmt task must run go fix before the configured golangci-lint formatters")
|
||||
}
|
||||
if strings.Contains(fmtTask, "gofumpt -") {
|
||||
t.Error("fmt task bypasses the configured formatter set with standalone gofumpt")
|
||||
}
|
||||
// One go fix pass is not a fixpoint: stditerators rewrites
|
||||
// `for i := range t.NumField()` into a field iterator that copies its loop
|
||||
// variable, and forvar only deletes that copy on the following pass. A tree
|
||||
// that stops after one pass is therefore one copyloopvar rejects, so fmt has
|
||||
// to keep applying passes and prove the plateau with a dry run that exits
|
||||
// clean only when nothing is left to fix.
|
||||
if !strings.Contains(fmtTask, verifyFix) {
|
||||
t.Error("fmt task does not prove that repeated go fix passes have reached a fixpoint")
|
||||
}
|
||||
if got := strings.Count(fmtTask, applyFix); got != 1 {
|
||||
t.Errorf("fmt task applies go fix %d times inline, want 1: the repetition belongs to the fixpoint loop", got)
|
||||
}
|
||||
if got := strings.Count(fmtTask, verifyFix); got != 1 {
|
||||
t.Errorf("fmt task verifies the go fix fixpoint %d times, want 1", got)
|
||||
}
|
||||
if got, owned := strings.Count(taskfile, applyFix), strings.Count(fmtTask, applyFix); got != owned {
|
||||
t.Errorf("Taskfile invokes go fix %d times, %d of them through task fmt: formatting has one owner", got, owned)
|
||||
}
|
||||
}
|
||||
|
||||
func TestBuildTaskSourcesTrackEmbeddedAssets(t *testing.T) {
|
||||
taskfile := readDeploymentFile(t, "Taskfile.yml")
|
||||
start := strings.Index(taskfile, "\n build:\n")
|
||||
end := strings.Index(taskfile, "\n test:\n")
|
||||
if start < 0 || end < start {
|
||||
t.Fatal("Taskfile has no bounded build task")
|
||||
}
|
||||
build := taskfile[start:end]
|
||||
sourcesAt := strings.Index(build, "sources:")
|
||||
generatesAt := strings.Index(build, "generates:")
|
||||
if sourcesAt < 0 || generatesAt < sourcesAt {
|
||||
t.Fatal("build task has no bounded sources block")
|
||||
}
|
||||
sources := build[sourcesAt:generatesAt]
|
||||
|
||||
for _, tc := range []struct {
|
||||
name string
|
||||
path string
|
||||
reason string
|
||||
}{
|
||||
{
|
||||
name: "embedded dashboard",
|
||||
path: "ui/dist/**",
|
||||
reason: "ui/embed.go embeds it with //go:embed all:dist, so a dashboard changing with no .go file changing must still rebuild the binaries",
|
||||
},
|
||||
} {
|
||||
if !strings.Contains(sources, tc.path) {
|
||||
t.Errorf("build sources do not track %s: %s", tc.name, tc.reason)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestBuildTaskStampsInstallTypeOnEveryCommand(t *testing.T) {
|
||||
taskfile := readDeploymentFile(t, "Taskfile.yml")
|
||||
start := strings.Index(taskfile, "\n build:\n")
|
||||
end := strings.Index(taskfile, "\n test:\n")
|
||||
if start < 0 || end < start {
|
||||
t.Fatal("Taskfile has no bounded build task")
|
||||
}
|
||||
build := taskfile[start:end]
|
||||
cmdsAt := strings.Index(build, "\n cmds:\n")
|
||||
if cmdsAt < 0 {
|
||||
t.Fatal("build task has no cmds block")
|
||||
}
|
||||
cmds := build[cmdsAt:]
|
||||
|
||||
buildLine := regexp.MustCompile(`^ - go build .*\./cmd/([a-z0-9-]+)`)
|
||||
found := 0
|
||||
for line := range strings.SplitSeq(cmds, "\n") {
|
||||
m := buildLine.FindStringSubmatch(line)
|
||||
if m == nil {
|
||||
continue
|
||||
}
|
||||
found++
|
||||
if !strings.Contains(line, "internal/installtype.buildType=") {
|
||||
t.Errorf("build task does not stamp installtype.buildType on %s: %s", m[1], strings.TrimSpace(line))
|
||||
}
|
||||
}
|
||||
if found == 0 {
|
||||
t.Fatal("build task has no go build commands under ./cmd/: this guard would assert nothing")
|
||||
}
|
||||
}
|
||||
|
||||
func TestFormattersExcludeInterpretedSecretEngines(t *testing.T) {
|
||||
config := readDeploymentFile(t, ".golangci.yml")
|
||||
if !strings.Contains(config, `^examples/secret-engines/(age|sops|vault)\.go$`) {
|
||||
t.Fatal("formatter config does not protect the interpreted secret engines")
|
||||
}
|
||||
}
|
||||
|
||||
func TestSupportedProfilesUseOneExecutionTopology(t *testing.T) {
|
||||
profiles := []string{
|
||||
"deployments/single-forge-github.toml",
|
||||
"deployments/multi-forge-github-gitea.toml",
|
||||
"deployments/local-ollama-standalone.toml",
|
||||
"deployments/docker-nats-stack.toml",
|
||||
}
|
||||
for _, path := range profiles {
|
||||
source := readDeploymentFile(t, path)
|
||||
if strings.Contains(source, "\n[agent]\n") {
|
||||
t.Errorf("%s still selects a legacy agent executor", path)
|
||||
}
|
||||
}
|
||||
|
||||
for _, path := range profiles[:2] {
|
||||
source := readDeploymentFile(t, path)
|
||||
for _, required := range []string{`mode = "embedded"`, "[containers]"} {
|
||||
if !strings.Contains(source, required) {
|
||||
t.Errorf("%s is missing default topology marker %q", path, required)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
external := readDeploymentFile(t, "deployments/docker-nats-stack.toml")
|
||||
if !strings.Contains(external, `mode = "external"`) {
|
||||
t.Error("docker-nats-stack.toml does not explicitly select external NATS")
|
||||
}
|
||||
|
||||
systemd := readDeploymentFile(t, "deployments/systemd-user-service.md")
|
||||
if !strings.Contains(systemd, "Embedded NATS is the default") {
|
||||
t.Error("systemd runbook does not identify embedded NATS as the default")
|
||||
}
|
||||
if strings.Contains(systemd, "still needs NATS") {
|
||||
t.Error("systemd runbook still requires an external Compose NATS service")
|
||||
}
|
||||
}
|
||||
|
||||
// TestInstallerDelegatesConfigGenerationToArchiedSetup pins the contract the
|
||||
// installer already drifted from once: it hand-rolled a config.toml, hardcoded
|
||||
// the GitHub token key and the Gitea host, and choosing Gitea then produced a
|
||||
// config naming a token it never wrote. The durable fix is that the code writing
|
||||
// the config is the code reading it -- archied setup renders it, archied loads it
|
||||
// (docs/architecture/configuration.md) -- and nothing stopped the generating
|
||||
// branch growing back until this.
|
||||
func TestInstallerDelegatesConfigGenerationToArchiedSetup(t *testing.T) {
|
||||
source := readDeploymentFile(t, "install.sh")
|
||||
|
||||
for _, required := range []string{
|
||||
// It runs the binary it just built, so the installer cannot hold a
|
||||
// second idea of what a valid config looks like.
|
||||
`"${ARCHIE_BIN_DIR}/archied" setup`,
|
||||
// For a fresh install only: an existing config is the operator's.
|
||||
`if [ ! -f "${ARCHIE_CONFIG_DIR}/config.toml" ]; then`,
|
||||
"already exists (preserving user config)",
|
||||
// The setup run is allowed to fail, and a failure is loud. A config that
|
||||
// never gets written is the only honest outcome after that.
|
||||
"could not generate",
|
||||
} {
|
||||
if !strings.Contains(source, required) {
|
||||
t.Errorf("install.sh is missing %q", required)
|
||||
}
|
||||
}
|
||||
|
||||
// Nothing here renders TOML or splices it afterwards. The splice check is
|
||||
// per line so a legitimate sed/awk elsewhere in the installer stays allowed.
|
||||
if strings.Contains(source, "forge_block") {
|
||||
t.Error("install.sh still carries the forge_block helper: it is what hardcoded the GitHub token key and Gitea host")
|
||||
}
|
||||
redirection := regexp.MustCompile(`>>?\s*"?[^"'\s]*config\.toml`)
|
||||
for index, line := range strings.Split(source, "\n") {
|
||||
if !strings.Contains(line, "config.toml") {
|
||||
continue
|
||||
}
|
||||
if strings.Contains(line, "sed ") || strings.Contains(line, "awk ") {
|
||||
t.Errorf("install.sh:%d splices config.toml (%s)", index+1, strings.TrimSpace(line))
|
||||
}
|
||||
if redirection.MatchString(line) {
|
||||
t.Errorf("install.sh:%d writes config.toml itself (%s)", index+1, strings.TrimSpace(line))
|
||||
}
|
||||
}
|
||||
// A TOML table header in the installer is a template by definition. The
|
||||
// systemd unit it also writes is INI, whose only sections are Unit/Service/
|
||||
// Install, so those are no part of this list.
|
||||
template := regexp.MustCompile(`(?m)^\s*\[(forge|models|providers|runners|containers|nats|web|budgets|notify|identit|chat)\]`)
|
||||
if found := template.FindString(source); found != "" {
|
||||
t.Errorf("install.sh carries a TOML template (%q): the installer must not hold its own idea of the config schema", strings.TrimSpace(found))
|
||||
}
|
||||
}
|
||||
+72
-33
@@ -1,28 +1,23 @@
|
||||
# Running this distribution
|
||||
|
||||
This archive contains six linux/amd64 binaries:
|
||||
This archive contains five linux/amd64 binaries:
|
||||
|
||||
- **`archied`** — the resident daemon: polls your forge for assigned issues
|
||||
and dispatches them into sandboxed `archie-agent` containers. It serves no
|
||||
dashboard: the web UI is `archie-ui`'s process (UI cutover,
|
||||
`archie-core-8cda.5.4`).
|
||||
- **`archie-ui`** — serves the operator dashboard and the webhook capture
|
||||
receiver, dialing the Gateway and State Store gRPC contracts. Reads only
|
||||
`[services.*]`, `[web]` and `[capture]` from the shared `config.toml`.
|
||||
- **`archie-gateway`** — serves the chat (`ChatContract`) surface `archied`,
|
||||
`archie-ui` and `archie-messaging` dial. Runs as its own process; `archied`
|
||||
never embeds a gateway.
|
||||
- **`archie-messaging`** — serves the Telegram, email and webhook channels,
|
||||
dialing the Gateway for the chat contract and the State Store for the stored
|
||||
channel settings. `archied` runs no gateway for those channels, so without
|
||||
this process they are simply absent — and nothing logs an error
|
||||
(`archie-core-1c01`), which is why it has a unit of its own in
|
||||
`deployments/systemd-user-service.md`.
|
||||
- **`archie-state-store`** — owns the single `archie.db` SQLite file behind
|
||||
a gRPC contract. `archied` and `archie-gateway` are gRPC clients of it, not
|
||||
owners of the database.
|
||||
- **`archie-playbooks`** — standalone CLI to lint playbook binding YAML
|
||||
before it reaches `archied`.
|
||||
Each service owns its data and reaches the others only through their gRPC
|
||||
contracts (or NATS, for task actions):
|
||||
|
||||
| Service | Owns | Reaches |
|
||||
|---|---|---|
|
||||
| `archie-state-store` | tasks, events, control-plane settings, identities and access policies, installed packages (PostgreSQL) | nothing |
|
||||
| `archie-gateway` | conversations (PostgreSQL, its own tables) and every model call: chat turns, curators, MCP tools and sampling | State Store; daemon over NATS for task actions |
|
||||
| `archied` | dispatch: forge polling, the task queue, the embedded NATS broker, agent containers | State Store; Gateway |
|
||||
| `archie-messaging` | the Telegram, email and webhook channel connections | Gateway; State Store for channel settings |
|
||||
| `archie-ui` | the dashboard and the webhook capture receiver | Gateway; State Store |
|
||||
|
||||
`archied playbooks lint` checks playbook binding YAML before it reaches the
|
||||
daemon, and `archied playbooks serve` is its language server for editors.
|
||||
|
||||
Without `archie-messaging` the channels are simply absent, so it needs a unit
|
||||
of its own (`deployments/systemd-user-service.md`).
|
||||
|
||||
`archie-agent` (the per-task sandboxed runtime) is **not** in this archive —
|
||||
it only ever runs inside the Docker container `archied` spawns per task, never
|
||||
@@ -33,9 +28,10 @@ as a host binary. Pull it from GHCR: `ghcr.io/samcharles93/archie-agent`.
|
||||
1. Pick a starting configuration. The full set of annotated templates lives
|
||||
in this repository's `deployments/` directory on GitHub
|
||||
(<https://github.com/samcharles93/archie-core/tree/main/deployments>) —
|
||||
`single-forge-github.toml`, `multi-forge-github-gitea.toml`,
|
||||
`local-ollama-standalone.toml`, and `docker-nats-stack.toml` cover the
|
||||
common cases. Copy whichever fits to:
|
||||
`standalone.toml` (no forge, the simplest start),
|
||||
`single-forge-github.toml`, `multi-forge-github-gitea.toml` and
|
||||
`docker-nats-stack.toml` cover the common cases. Every one needs
|
||||
PostgreSQL 18 at `database_url`. Copy whichever fits to:
|
||||
|
||||
```bash
|
||||
mkdir -p ~/.config/archie
|
||||
@@ -46,9 +42,10 @@ as a host binary. Pull it from GHCR: `ghcr.io/samcharles93/archie-agent`.
|
||||
providers) and place any secrets in `~/.config/archie/env` or referenced
|
||||
`secret://` locations.
|
||||
|
||||
3. Start the five processes, in order (`archie-state-store` and
|
||||
`archie-gateway` first — `archied`, `archie-ui` and `archie-messaging` dial
|
||||
both at startup):
|
||||
3. Start the five processes. Order does not matter: a service whose peer is
|
||||
not up yet waits for it and reports it as degraded on its health surface
|
||||
meanwhile. The Gateway waits for the daemon's NATS endpoint when the broker
|
||||
is embedded.
|
||||
|
||||
```bash
|
||||
./archie-state-store -config ~/.config/archie/config.toml -listen 127.0.0.1:9090 &
|
||||
@@ -73,15 +70,15 @@ as a host binary. Pull it from GHCR: `ghcr.io/samcharles93/archie-agent`.
|
||||
|
||||
## Verifying an install
|
||||
|
||||
`archie-playbooks lint -dir <playbooks-dir>` validates playbook binding YAML
|
||||
`archied playbooks lint -dir <playbooks-dir>` validates playbook binding YAML
|
||||
against the same schema `archied` loads at startup — run it against your
|
||||
playbooks directory before pointing `archied` at it.
|
||||
|
||||
## Version
|
||||
|
||||
This archive's binaries are built from the `archied` release tag in its
|
||||
filename; `archie-ui`, `archie-gateway`, `archie-state-store`,
|
||||
`archie-messaging` and `archie-playbooks` ship at that same version rather than
|
||||
filename; `archie-ui`, `archie-gateway`, `archie-state-store` and
|
||||
`archie-messaging` ship at that same version rather than
|
||||
being independently tagged (see `RELEASING.md` in the source repository for why
|
||||
only `archied` and `archie-agent` are independently versioned).
|
||||
|
||||
@@ -89,5 +86,47 @@ only `archied` and `archie-agent` are independently versioned).
|
||||
`archied` are services that must be running and addressable; `archie-messaging`
|
||||
carries the Telegram, email and webhook channels since the v1.30.0 extraction, so
|
||||
an install (or an upgrade across v1.30.0) needs its unit as well -- see
|
||||
`deployments/systemd-user-service.md`. `archie-playbooks` is a CLI and runs on
|
||||
demand.
|
||||
`deployments/systemd-user-service.md`.
|
||||
|
||||
### Native self-update
|
||||
|
||||
`archie-update-install` downloads the approved release's Linux/amd64 archive
|
||||
and verifies its `SHA256SUMS` entry before executing or installing it. Releases
|
||||
must include `release.json`, all host binaries, and the two updater scripts.
|
||||
Older releases without this contract cannot be installed through the artifact
|
||||
path. `--from-source` (or `ARCHIE_UPDATE_SOURCE_BUILD=1`) explicitly clones and
|
||||
builds the selected release instead.
|
||||
|
||||
`archied update check` finds the newest GitHub release with a linux-amd64 zip on
|
||||
the channel chosen under Settings → Status → Updates: stable, next (includes
|
||||
prereleases) or a pinned version. From a shell it reads
|
||||
`ARCHIE_UPDATE_RELEASE_CHANNEL` and `ARCHIE_UPDATE_PIN`, or `-channel` and `-pin`.
|
||||
The notification destination remains separate from the release channel.
|
||||
|
||||
For scheduled, unattended runs, `archie-update-install --auto` discovers the
|
||||
selected release and refuses if the daemon reports work in flight. It checks
|
||||
again immediately before promotion. A scheduler can set
|
||||
`ARCHIE_UPDATE_RELEASE_CHANNEL` and `ARCHIE_UPDATE_PIN`; nothing schedules updates
|
||||
by default. All services stop through their ordinary graceful shutdown path.
|
||||
|
||||
`release.json` supplies the service order and required config sections to both
|
||||
first-install and self-update. A missing unit or config section produces an
|
||||
ordered migration plan and refuses installation. Apply that plan before retrying.
|
||||
Automatic topology edits are intentionally unsupported.
|
||||
|
||||
The watchdog switches staged executables by rename, restarts services, and
|
||||
requires the candidate daemon's existing readiness registry to remain healthy
|
||||
for 120 seconds. Agent images come from the release manifest by digest. The
|
||||
image switch updates the control-plane policy, preserving other settings;
|
||||
rollback restores the prior image policy with conflict detection. Source builds
|
||||
use the built image's immutable image ID.
|
||||
|
||||
Transactions live in `${XDG_STATE_HOME:-~/.local/state}/archie/update`, outside
|
||||
the binary directory. `phase`, `environment`, `image.json` (when applicable),
|
||||
and `previous/` describe the transaction. A lock reports the owning process.
|
||||
On daemon boot, an interrupted transaction schedules independent recovery before
|
||||
normal startup. To recover manually, run `transaction/watchdog --recover` from
|
||||
that state directory. A failed recovery keeps the journal for another attempt.
|
||||
|
||||
Database snapshots remain available for manual recovery. Schema migrations and
|
||||
PostgreSQL data are never automatically reversed.
|
||||
+19
-19
@@ -4,19 +4,20 @@ This directory contains configuration templates and guides for different deploym
|
||||
|
||||
## Directory Structure
|
||||
|
||||
* **[`single-forge-github.toml`](./single-forge-github.toml)**:
|
||||
- **[`single-forge-github.toml`](./single-forge-github.toml)**:
|
||||
Standard single-forge deployment managing multiple GitHub repositories under a single bot account and GitHub token.
|
||||
|
||||
* **[`multi-forge-github-gitea.toml`](./multi-forge-github-gitea.toml)**:
|
||||
- **[`multi-forge-github-gitea.toml`](./multi-forge-github-gitea.toml)**:
|
||||
Multi-identity deployment running GitHub and a self-hosted Gitea instance simultaneously with distinct bot accounts, tokens, and repository sets.
|
||||
|
||||
* **[`local-ollama-standalone.toml`](./local-ollama-standalone.toml)**:
|
||||
Self-hosted deployment running local LLM models via Ollama (e.g., `llama3`, `qwen2.5`) with optional standalone (forge-disabled) operation.
|
||||
- **[`standalone.toml`](./standalone.toml)**: start here. Event-driven
|
||||
automation with no forge or repositories, local Ollama models, loopback
|
||||
services and no tokens.
|
||||
|
||||
* **[`docker-nats-stack.toml`](./docker-nats-stack.toml)**:
|
||||
- **[`docker-nats-stack.toml`](./docker-nats-stack.toml)**:
|
||||
Host-run `archied` orchestrating sandboxed `archie-agent` containers over the repository's Compose-managed NATS service. Copy to `~/.config/archie/config.toml`, start NATS with Compose, then start `archied` on the host.
|
||||
|
||||
* **[`systemd-user-service.md`](./systemd-user-service.md)**:
|
||||
- **[`systemd-user-service.md`](./systemd-user-service.md)**:
|
||||
Operational runbook for running `archied` as a persistent 24/7 background service via systemd user units and `loginctl enable-linger`.
|
||||
|
||||
---
|
||||
@@ -42,15 +43,14 @@ archied -config ~/.config/archie/config.toml
|
||||
systemctl --user start archied
|
||||
```
|
||||
|
||||
The templates use the extracted Gateway Service by default. Start
|
||||
`archie-gateway` before `archied`; it owns the conversation SQLite file and
|
||||
serves the `ChatContract` gRPC API on the configured target.
|
||||
Start order does not matter: a service waits for its peers and reports them as
|
||||
degraded meanwhile. Every template needs PostgreSQL 18 at `database_url`;
|
||||
`docker compose up -d postgres` provides the default one.
|
||||
|
||||
The State Store service (`archie-state-store`) owns the single `archie.db` task
|
||||
SQLite file and serves the `StateStore` gRPC contract. After the in-process
|
||||
store path was deleted, BOTH `archied` and `archie-gateway` dial it via
|
||||
`[services.state].target` and never open `archie.db` themselves
|
||||
(`docs/prds/state-store-contract.md` §12 step 7). The templates set
|
||||
The State Store service (`archie-state-store`) owns the task data in the
|
||||
PostgreSQL database `database_url` names and serves the `StateStore` gRPC
|
||||
contract. BOTH `archied` and `archie-gateway` dial it via
|
||||
`[services.state].target` and never open the task tables themselves. The templates set
|
||||
`[services.state]` accordingly: a host-only agent reaches a loopback bind
|
||||
(`127.0.0.1:9090`) with no token, while a container-mode agent needs the
|
||||
Docker bridge gateway address plus a matching bearer token (`target_token` /
|
||||
@@ -60,7 +60,7 @@ loopback.
|
||||
## Running the dashboard
|
||||
|
||||
The dashboard is served by the standalone UI Service (`archie-ui`), not by
|
||||
`archied` (UI cutover, `archie-core-8cda.5.4`; `docs/prds/ui-service-boundary.md`).
|
||||
`archied`.
|
||||
It reads the same `config.toml`, dials the Gateway and State Store targets
|
||||
already configured there, and binds `[web].listen` (`127.0.0.1:8484` by
|
||||
default). Start it after the Gateway and the State Store:
|
||||
@@ -117,10 +117,10 @@ curl -s -o /dev/null -w '%{http_code}\n' http://127.0.0.1:9091/healthz #
|
||||
curl -s http://127.0.0.1:9091/health/detailed # state_db component -> 200, or 503 when degraded
|
||||
```
|
||||
|
||||
A running State Store owns exactly one task SQLite file (`<db_path>-tasks.sqlite`);
|
||||
`archied` and `archie-gateway` never open `archie.db` directly, so a second
|
||||
store process on the same `db_path`, or a consumer that opens the task file,
|
||||
indicates dual-store ownership (`docs/prds/state-store-contract.md` §12 step 7/8).
|
||||
A running State Store holds the `state-store` ownership lock on its database;
|
||||
`archied` and `archie-gateway` never open the task tables directly, so a second
|
||||
store process on the same `database_url` refuses to start, and a consumer that
|
||||
opens the task tables indicates dual-store ownership.
|
||||
The readiness probe is the single-writer check the runbook has against a
|
||||
degraded store: a `503` from `/health/detailed` means `archied` should be
|
||||
started only after the store is healthy.
|
||||
@@ -1,13 +1,21 @@
|
||||
# Development overlay for `task dev` and `task dev:dashboard`.
|
||||
#
|
||||
# Match Vite's API/event proxy without changing the installed configuration.
|
||||
# After the UI cutover (archie-core-8cda.5.4) the dashboard on :8484 is the
|
||||
# The dashboard on :8484 is the
|
||||
# archie-ui process's listener, not archied's; this overlay is what both
|
||||
# `go run ./cmd/archied -config-overlay deployments/dev.toml` and
|
||||
# `go run ./cmd/archie-ui -config-overlay deployments/dev.toml` read. Only
|
||||
# [web], [services.*] and [capture] land in archie-ui; the daemon ignores
|
||||
# [web] entirely.
|
||||
|
||||
# `task dev` runs archie-state-store against this overlay, and the State Store
|
||||
# fails closed without a PostgreSQL URL. This must reach the `postgres`
|
||||
# service in docker-compose.yml, which `task dev` brings up first via
|
||||
# dev:postgres -- keep the URL and that service in agreement.
|
||||
bot_user = "archie-dev"
|
||||
|
||||
database_url = "postgres://archie:archie@127.0.0.1:5432/archie?sslmode=disable"
|
||||
|
||||
[web]
|
||||
listen = "127.0.0.1:8484"
|
||||
|
||||
@@ -17,7 +25,6 @@ listen = "127.0.0.1:8484"
|
||||
# when a port is already taken on the host -- before the
|
||||
# listen key existed the collision could only be worked around by hand-writing
|
||||
# a matching target and passing -listen, and it read as a code fault.
|
||||
# (docs/prds/state-store-contract.md §12 step 7).
|
||||
[services.state]
|
||||
target = "127.0.0.1:9091"
|
||||
listen = "127.0.0.1:9091"
|
||||
|
||||
@@ -15,13 +15,17 @@ poll_interval = "60s"
|
||||
bot_user = "archie"
|
||||
diff_cap_lines = 0
|
||||
work_dir = "~/.local/share/archie/work"
|
||||
db_path = "~/.local/share/archie/archie.db"
|
||||
state_dir = "~/.local/share/archie" # NATS store, task logs
|
||||
# The State Store's PostgreSQL connection (PostgreSQL 18, required).
|
||||
# `docker compose up -d postgres` provides this local default; point it at
|
||||
# your own Postgres 18 server otherwise.
|
||||
database_url = "postgres://archie:archie@127.0.0.1:5432/archie?sslmode=disable"
|
||||
|
||||
[services.gateway]
|
||||
target = "127.0.0.1:8585"
|
||||
|
||||
# The State Store gRPC service owns the single archie.db SQLite file; archied
|
||||
# and archie-gateway dial it and never open archie.db themselves (§12 step 7).
|
||||
# The State Store gRPC service owns the PostgreSQL task data; archied and
|
||||
# archie-gateway dial it and never open those tables themselves.
|
||||
# This deployment runs the agent in containers, so target is the Docker bridge
|
||||
# gateway (172.17.0.1) the container can reach, with a matching target_token
|
||||
# that archie-state-store validates. Host-only agent: use 127.0.0.1:9090 with
|
||||
@@ -42,13 +46,6 @@ key = "ARCHIE_GITEA_TOKEN"
|
||||
trigger = "assignee"
|
||||
ack_reaction = "eyes"
|
||||
|
||||
[dispatch.labels]
|
||||
queued = "agent:queued"
|
||||
working = "agent:working"
|
||||
waiting = "agent:waiting"
|
||||
pr = "agent:pr"
|
||||
parked = "agent:parked"
|
||||
|
||||
# Stages run in sandboxed archie-agent containers over NATS. archied only
|
||||
# orchestrates: the agent image carries the toolchain and makes the model
|
||||
# calls, so gate commands resolve there, not in the native daemon.
|
||||
@@ -74,8 +71,7 @@ max_uptime = "60m"
|
||||
pull_policy = "missing"
|
||||
|
||||
[web]
|
||||
# Bound by the archie-ui process (the host-run dashboard after the UI
|
||||
# cutover, archie-core-8cda.5.4); it dials the [services.*] targets above --
|
||||
# Bound by the archie-ui process; it dials the [services.*] targets above --
|
||||
# the bridge-gateway State Store address works from the host too.
|
||||
listen = "127.0.0.1:8484"
|
||||
# Trust X-Forwarded-Proto when fronted by a reverse proxy (e.g. Traefik)
|
||||
@@ -118,6 +114,6 @@ gate = [
|
||||
# Every env var named here must be present in the environment of the host
|
||||
# archied process, normally through its configured supervisor or launch shell.
|
||||
[chat.telegram]
|
||||
token_env = "TELEGRAM_BOT_TOKEN"
|
||||
token = { engine = "env", key = "TELEGRAM_BOT_TOKEN" }
|
||||
# Empty list denies everyone.
|
||||
allowed_user_ids = []
|
||||
@@ -1,46 +0,0 @@
|
||||
# ==============================================================================
|
||||
# Self-Hosted Ollama + Standalone Mode Deployment Example
|
||||
#
|
||||
# Runs local open-weights models via Ollama (e.g. llama3, qwen2.5) with forge
|
||||
# polling disabled (standalone execution mode).
|
||||
# ==============================================================================
|
||||
|
||||
work_dir = "~/.local/share/archie/work"
|
||||
db_path = "~/.local/share/archie/archie.db"
|
||||
|
||||
[services.gateway]
|
||||
target = "127.0.0.1:8585"
|
||||
|
||||
# The State Store gRPC service owns the single archie.db SQLite file; archied
|
||||
# and archie-gateway dial it and never open archie.db themselves (§12 step 7).
|
||||
# Host-only deployment: the agent runs on the host, so the loopback target
|
||||
# 127.0.0.1:9090 needs no token. Start archie-state-store with the matching
|
||||
# `-listen 127.0.0.1:9090`.
|
||||
[services.state]
|
||||
target = "127.0.0.1:9090"
|
||||
|
||||
# Standalone execution: Forge polling is disabled
|
||||
[forge]
|
||||
type = "none"
|
||||
|
||||
[models]
|
||||
triage = "ollama/llama3:latest"
|
||||
planner = "ollama/llama3:latest"
|
||||
builder = "ollama/llama3:latest"
|
||||
|
||||
[providers.ollama]
|
||||
class = "ollama"
|
||||
|
||||
# Optional chat workspace configuration
|
||||
[chat]
|
||||
operator = "Local Operator"
|
||||
workspace = "~/.local/share/archie/workspace"
|
||||
max_steps = 100
|
||||
models = [
|
||||
"ollama/llama3:latest",
|
||||
"ollama/qwen2.5:7b"
|
||||
]
|
||||
|
||||
[budgets]
|
||||
max_steps = 60
|
||||
wall_clock = "30m"
|
||||
@@ -7,13 +7,17 @@
|
||||
# ==============================================================================
|
||||
|
||||
work_dir = "~/.local/share/archie/work"
|
||||
db_path = "~/.local/share/archie/archie.db"
|
||||
state_dir = "~/.local/share/archie" # NATS store, task logs
|
||||
# The State Store's PostgreSQL connection (PostgreSQL 18, required).
|
||||
# `docker compose up -d postgres` provides this local default; point it at
|
||||
# your own Postgres 18 server otherwise.
|
||||
database_url = "postgres://archie:archie@127.0.0.1:5432/archie?sslmode=disable"
|
||||
|
||||
[services.gateway]
|
||||
target = "127.0.0.1:8585"
|
||||
|
||||
# The State Store gRPC service owns the single archie.db SQLite file; archied
|
||||
# and archie-gateway dial it and never open archie.db themselves (§12 step 7).
|
||||
# The State Store gRPC service owns the PostgreSQL task data; archied and
|
||||
# archie-gateway dial it and never open those tables themselves.
|
||||
# This deployment runs the agent in containers, so target is the Docker bridge
|
||||
# gateway (172.17.0.1) the container can reach, with a matching target_token
|
||||
# that archie-state-store validates. Host-only agent: use 127.0.0.1:9090 with
|
||||
@@ -23,9 +27,9 @@ target = "172.17.0.1:9090"
|
||||
target_token = "change-me-state-store-token"
|
||||
|
||||
[models]
|
||||
triage = "openai/gpt-4o"
|
||||
planner = "openai/gpt-4o"
|
||||
builder = "openai/gpt-4o"
|
||||
triage = "openai/gpt-6-luna"
|
||||
planner = "openai/gpt-6-luna"
|
||||
builder = "openai/gpt-6-luna"
|
||||
|
||||
[providers.openai]
|
||||
class = "openai"
|
||||
|
||||
@@ -6,7 +6,11 @@
|
||||
# ==============================================================================
|
||||
|
||||
work_dir = "~/.local/share/archie/work"
|
||||
db_path = "~/.local/share/archie/archie.db"
|
||||
state_dir = "~/.local/share/archie" # NATS store, task logs
|
||||
# The State Store's PostgreSQL connection (PostgreSQL 18, required).
|
||||
# `docker compose up -d postgres` provides this local default; point it at
|
||||
# your own Postgres 18 server otherwise.
|
||||
database_url = "postgres://archie:archie@127.0.0.1:5432/archie?sslmode=disable"
|
||||
poll_interval = "60s"
|
||||
label = "archie"
|
||||
bot_user = "archie-bot"
|
||||
@@ -19,9 +23,9 @@ diff_cap_lines = 400
|
||||
[services.gateway]
|
||||
target = "127.0.0.1:8585"
|
||||
|
||||
# The State Store gRPC service owns the single archie.db SQLite file. archied
|
||||
# and archie-gateway dial it here and never open archie.db themselves
|
||||
# (docs/prds/state-store-contract.md §12 step 7). This deployment runs the
|
||||
# The State Store gRPC service owns the PostgreSQL task data. archied and
|
||||
# archie-gateway dial it here and never open those tables themselves.
|
||||
# This deployment runs the
|
||||
# agent in containers, so the target must be the Docker bridge gateway address
|
||||
# (172.17.0.1) that the container can reach, and a non-loopback target requires
|
||||
# a matching target_token that archie-state-store validates -- start it with the
|
||||
@@ -41,17 +45,10 @@ token = { engine = "env", key = "ARCHIE_GITHUB_TOKEN" }
|
||||
trigger = "assignee" # "assignee", "label", or "either"
|
||||
ack_reaction = "eyes" # Emoji reaction on issue pickup
|
||||
|
||||
[dispatch.labels]
|
||||
queued = "archie:queued"
|
||||
working = "archie:working"
|
||||
waiting = "archie:waiting"
|
||||
pr = "archie:pr"
|
||||
parked = "archie:parked"
|
||||
|
||||
[models]
|
||||
triage = "openai/gpt-4o"
|
||||
planner = "openai/gpt-4o"
|
||||
builder = "openai/gpt-4o"
|
||||
triage = "openai/gpt-6-luna"
|
||||
planner = "openai/gpt-6-luna"
|
||||
builder = "openai/gpt-6-luna"
|
||||
|
||||
[providers.openai]
|
||||
class = "openai"
|
||||
|
||||
@@ -0,0 +1,57 @@
|
||||
# ==============================================================================
|
||||
# Minimal event-driven deployment: no forge, no repositories
|
||||
#
|
||||
# Events arrive as webhooks at the dashboard and run workflows. Models run
|
||||
# locally through Ollama; for a hosted provider replace [providers.ollama] with
|
||||
# e.g. [providers.openai] class = "openai", api_key_env = "OPENAI_API_KEY"
|
||||
# and change the model names to "openai/<model>".
|
||||
# ==============================================================================
|
||||
|
||||
# Standalone still needs a bot identity: it names the agent that chat turns and
|
||||
# the session curator attribute memory to, and it becomes the seeded identity's
|
||||
# display name when there is no [[identities]] block.
|
||||
bot_user = "archie"
|
||||
|
||||
work_dir = "~/.local/share/archie/work"
|
||||
state_dir = "~/.local/share/archie" # NATS store, task logs
|
||||
# PostgreSQL 18 connection (required).
|
||||
# `docker compose up -d postgres` provides this local default; point it at
|
||||
# your own Postgres 18 server otherwise.
|
||||
database_url = "postgres://archie:archie@127.0.0.1:5432/archie?sslmode=disable"
|
||||
|
||||
[services.gateway]
|
||||
target = "127.0.0.1:8585"
|
||||
|
||||
# The State Store gRPC service owns the PostgreSQL task data; archied and
|
||||
# archie-gateway dial it and never open those tables themselves.
|
||||
# Host-only deployment: the agent runs on the host, so the loopback target
|
||||
# 127.0.0.1:9090 needs no token. Start archie-state-store with the matching
|
||||
# `-listen 127.0.0.1:9090`.
|
||||
[services.state]
|
||||
target = "127.0.0.1:9090"
|
||||
|
||||
# Standalone execution: Forge polling is disabled
|
||||
[forge]
|
||||
type = "none"
|
||||
|
||||
[models]
|
||||
triage = "ollama/llama3:latest"
|
||||
planner = "ollama/llama3:latest"
|
||||
builder = "ollama/llama3:latest"
|
||||
|
||||
[providers.ollama]
|
||||
class = "ollama"
|
||||
|
||||
# Optional chat workspace configuration
|
||||
[chat]
|
||||
operator = "Local Operator"
|
||||
workspace = "~/.local/share/archie/workspace"
|
||||
max_steps = 100
|
||||
models = [
|
||||
"ollama/llama3:latest",
|
||||
"ollama/qwen2.5:7b"
|
||||
]
|
||||
|
||||
[budgets]
|
||||
max_steps = 60
|
||||
wall_clock = "30m"
|
||||
@@ -16,11 +16,10 @@ here, where it would drift from what is written.
|
||||
The Gateway unit is `archie-gateway.service`, written by `install.sh` beside
|
||||
`archied.service`.
|
||||
|
||||
The State Store unit is `archie-state-store.service`. It owns the single `archie.db` SQLite
|
||||
file and serves the `StateStore` gRPC contract. After the in-process store path
|
||||
was deleted, BOTH `archied` and `archie-gateway` dial it via
|
||||
`[services.state].target` (see the `archied` config below) and never open
|
||||
`archie.db` themselves (`docs/prds/state-store-contract.md` §12 step 7). A
|
||||
The State Store unit is `archie-state-store.service`. It owns the task data in
|
||||
PostgreSQL and serves the `StateStore` gRPC contract. BOTH `archied` and
|
||||
`archie-gateway` dial it via `[services.state].target` (see the `archied`
|
||||
config below) and never open the task tables themselves. A
|
||||
host-only agent uses the loopback bind with no token below; a container-mode
|
||||
agent needs the Docker bridge gateway address plus a bearer token via
|
||||
`--token`/`STATE_STORE_TOKEN` or `[services.state].target_token`, and a
|
||||
@@ -36,8 +35,7 @@ The Telegram, email and webhook channels are served by `archie-messaging`, not
|
||||
by `archied`, since the v1.30.0 extraction. `archied` starts no gateway for them
|
||||
and logs nothing when one is absent, so a host that updates across v1.30.0
|
||||
without this unit runs on with dead channels and a daemon that looks perfectly
|
||||
healthy -- that was `archie-core-1c01`, found after two days of a silently dead
|
||||
Telegram bot. `install.sh` writes this unit on a fresh install;
|
||||
healthy. `install.sh` writes this unit on a fresh install;
|
||||
`scripts/archie-update-install` refuses an
|
||||
update when a host is missing a unit and names what is missing, which now fires
|
||||
for a host that drifted or predates this release rather than the normal path.
|
||||
@@ -47,18 +45,18 @@ channel settings, and reads the same `config.toml`. Like `archie-ui` it resolves
|
||||
`GATEWAY_TOKEN` and `STATE_STORE_TOKEN` from its process environment, hence the
|
||||
`EnvironmentFile`:
|
||||
|
||||
`install.sh` writes `archie-messaging.service`, whose `After=` and `Wants=`
|
||||
lines preserve that store-then-gateway order.
|
||||
`install.sh` writes `archie-messaging.service`. Its `After=` and `Wants=`
|
||||
lines only tidy the start sequence: nothing depends on that order, because
|
||||
each service waits for the peers it needs.
|
||||
|
||||
## 2. UI Service Unit (`~/.config/systemd/user/archie-ui.service`)
|
||||
|
||||
The dashboard is served by the standalone UI Service, not by `archied`
|
||||
(UI cutover, `archie-core-8cda.5.4`). It reads the same `config.toml`, dials
|
||||
The dashboard is served by the standalone UI Service, not by `archied`. It reads the same `config.toml`, dials
|
||||
the Gateway and State Store targets already in it, and binds `[web].listen`.
|
||||
A non-loopback bind requires a dashboard token (`-token`, or `-token-file` to
|
||||
mint and persist one);
|
||||
|
||||
**Auth note (deliberate design, `archie-core-8cda.5.5`):** unlike `archied`,
|
||||
**Auth note:** unlike `archied`,
|
||||
`archie-ui` has no secret registry — it resolves `GATEWAY_TOKEN` and
|
||||
`STATE_STORE_TOKEN` from its **process environment only** (or from the
|
||||
`target_token` values in `config.toml`). Whatever starts `archie-ui` is
|
||||
@@ -107,6 +105,7 @@ loginctl enable-linger "$USER"
|
||||
```
|
||||
|
||||
Verify linger status:
|
||||
|
||||
```bash
|
||||
loginctl show-user "$USER" | grep Linger
|
||||
# Output: Linger=yes
|
||||
@@ -117,26 +116,31 @@ loginctl show-user "$USER" | grep Linger
|
||||
## 4. Service Commands
|
||||
|
||||
Reload systemd daemon files:
|
||||
|
||||
```bash
|
||||
systemctl --user daemon-reload
|
||||
```
|
||||
|
||||
Enable and start the service immediately:
|
||||
|
||||
```bash
|
||||
systemctl --user enable --now archie-state-store archie-gateway archie-messaging archie-ui archied
|
||||
```
|
||||
|
||||
Check service status:
|
||||
|
||||
```bash
|
||||
systemctl --user status archied
|
||||
```
|
||||
|
||||
Tail live daemon logs:
|
||||
|
||||
```bash
|
||||
journalctl --user -u archied -f
|
||||
```
|
||||
|
||||
Restart or stop the service:
|
||||
|
||||
```bash
|
||||
systemctl --user restart archied
|
||||
systemctl --user stop archied
|
||||
@@ -188,8 +192,8 @@ fall back to a host model loop.
|
||||
## 6. Pinning the archie-agent Image
|
||||
|
||||
`ghcr.io/samcharles93/archie-agent:latest` is a moving target: every push to
|
||||
`main` that touches the runtime's package closure re-publishes it (see
|
||||
`.github/workflows/deploy.yml`), so `latest` can change under a running
|
||||
`main` that touches the runtime's package closure re-publishes it
|
||||
(`.github/workflows/deploy.yml`), so `latest` can change under a running
|
||||
deployment with no warning and no way to reproduce a prior build.
|
||||
|
||||
As of this writing, `archie-agent` has **no published semantic-version tag**
|
||||
@@ -254,6 +258,5 @@ with the operator's Docker credentials and retain `pull_policy = "missing"`:
|
||||
docker compose pull agent
|
||||
```
|
||||
|
||||
`db_path` and other paths are native host paths. Point them at the intended
|
||||
state directory; changing from an old containerized daemon path can otherwise
|
||||
start Archie against empty state files.
|
||||
`state_dir` and other paths are native host paths. Point `state_dir` at the
|
||||
intended state directory (embedded NATS store, task logs).
|
||||
+45
-3
@@ -1,24 +1,53 @@
|
||||
# Optional external NATS, plus the agent image the daemon spawns per task.
|
||||
# PostgreSQL for the State Store, optional external NATS, and the agent images
|
||||
# the daemon spawns per task.
|
||||
#
|
||||
# archied itself runs on the host under systemd, not here -- its chat tools
|
||||
# operate on host files, which a container cannot reach. See
|
||||
# deployments/systemd-user-service.md.
|
||||
#
|
||||
# Embedded NATS is the normal deployment and needs no Compose service.
|
||||
# State Store DB: docker compose up -d postgres
|
||||
# External broker: docker compose up -d nats
|
||||
# Build worker: docker compose build agent
|
||||
# Profile image: docker compose build agent-net
|
||||
# Stop external: docker compose down
|
||||
# Logs: journalctl --user -u archied -f (the daemon)
|
||||
# docker compose logs -f nats (the bus)
|
||||
|
||||
services:
|
||||
# ── PostgreSQL (State Store) ───────────────────────────────────
|
||||
# The standalone archie-state-store process's database. PostgreSQL 18 is
|
||||
# the required minimum and target; `postgres.Open` refuses anything older.
|
||||
# `task dev` brings this up before the State Store via dev:postgres. The
|
||||
# credentials and database name below are the dev default mirrored by
|
||||
# deployments/dev.toml's database_url -- change both together.
|
||||
postgres:
|
||||
image: postgres:18
|
||||
environment:
|
||||
POSTGRES_USER: archie
|
||||
POSTGRES_PASSWORD: archie
|
||||
POSTGRES_DB: archie
|
||||
# postgres:18 moved its default PGDATA under a versioned path; pin the
|
||||
# classic location so the named volume keeps working across image updates.
|
||||
PGDATA: /var/lib/postgresql/data/pgdata
|
||||
ports:
|
||||
- "127.0.0.1:5432:5432"
|
||||
volumes:
|
||||
- pg_data:/var/lib/postgresql/data
|
||||
restart: unless-stopped
|
||||
healthcheck:
|
||||
test: ["CMD-SHELL", "pg_isready -U archie -d archie"]
|
||||
interval: 10s
|
||||
timeout: 5s
|
||||
retries: 5
|
||||
|
||||
# ── NATS JetStream ────────────────────────────────────────────────
|
||||
nats:
|
||||
image: nats:2.14-alpine3.22
|
||||
command: -js -m 8222
|
||||
ports:
|
||||
- "4222:4222" # client
|
||||
- "8222:8222" # monitoring (http://localhost:8222)
|
||||
- "4222:4222" # client
|
||||
- "8222:8222" # monitoring (http://localhost:8222)
|
||||
volumes:
|
||||
- nats_data:/data
|
||||
restart: unless-stopped
|
||||
@@ -54,8 +83,21 @@ services:
|
||||
# deployments/systemd-user-service.md#pinning-the-archie-agent-image.
|
||||
image: ghcr.io/samcharles93/archie-agent@sha256:870f1b1357979cfea23fccacb24166ebeb9ab321708ef2c2b218a763ed99b090
|
||||
|
||||
# ── example agent profile image ─────────────────────────────────────
|
||||
# The agent image plus network lookup tools, for a workflow that names
|
||||
# `profile: network-investigator` (archipelago: workflows/firewall).
|
||||
# Build-only for the same reason as agent. It is local, so leave
|
||||
# containers.pull_policy at "missing": "always" would try to pull it.
|
||||
agent-net:
|
||||
profiles: ["build"]
|
||||
build:
|
||||
context: examples/profiles
|
||||
dockerfile: Dockerfile.agent-net
|
||||
image: archie-agent-net:local
|
||||
|
||||
volumes:
|
||||
nats_data:
|
||||
pg_data:
|
||||
|
||||
# The subnet is pinned for the optional external-broker profile because its
|
||||
# configured URL must be reachable from both the native daemon and workers.
|
||||
|
||||
@@ -1,77 +0,0 @@
|
||||
# Adversarial self-review
|
||||
|
||||
Archie runs a fresh adversarial review of the diff before it opens a pull
|
||||
request, so a PR arrives with a findings record rather than an unreviewed
|
||||
claim. The reviewer provably cannot see the implementer's context: it reviews a
|
||||
`.git`-free snapshot of the committed tree, not the worktree, the commit
|
||||
history, or the implementer's transcript.
|
||||
|
||||
Promoted from `docs/prds/adversarial-self-review.md` (the design decision;
|
||||
`archie-core-h019`). Describes the stage as shipped.
|
||||
|
||||
## Contract (`internal/domain/workflow`)
|
||||
|
||||
The workflow domain owns the contract and the blocking decision; it never names
|
||||
the executor.
|
||||
|
||||
- `Reviewer.Review(ctx, ReviewRequest) ReviewReport` — the interface the
|
||||
workflow stage consumes.
|
||||
- `ReviewRequest` is the reviewer's entire input: `SnapshotDir` (a `.git`-free
|
||||
export of the reviewed commit), `Diff` (base...head), `IssueText` (the
|
||||
originating issue title/body), and `MaxSteps`.
|
||||
- `ReviewFinding` / `ReviewReport` are the structured result. The load-bearing
|
||||
rule is `Blocking() == (Verdict == confirmed && Level == error)`: only a
|
||||
confirmed error-level finding blocks; a plausible finding never blocks
|
||||
however severe it claims to be.
|
||||
|
||||
`ReviewReport` distinguishes `not_run`, `skipped`, and `completed` (zero
|
||||
findings) structurally, so "ran and found nothing" is not the same as "never
|
||||
ran" — collapsing them would make an outage indistinguishable from a clean
|
||||
review.
|
||||
|
||||
## Execution (`internal/app/agentworker`)
|
||||
|
||||
The executor is an ai-sdk `agent.Subagent`: a nested synchronous generation in
|
||||
the same worker process, with its own model, system prompt, toolset and step
|
||||
budget.
|
||||
|
||||
- **Conversation isolation is structural.** `Subagent.Run` sends only a prompt
|
||||
string, never the implementer's message history.
|
||||
- **Workspace isolation is the `.git`-free snapshot.** The reviewer's toolset is
|
||||
read-only (`read`, `grep`, `find`) and rooted at `SnapshotDir` — never the
|
||||
worker's own toolset, which carries the `worktreerpc` publication grant.
|
||||
- **Findings return through a typed capture tool** (`record_finding`), validated
|
||||
on the way in, so the reviewer reports through the contract rather than free
|
||||
text the caller regexes.
|
||||
- **Fail-closed.** A reviewer that errors, truncates, or reaches no conclusion
|
||||
yields `ReviewStatusNotRun`, which the stage treats as a park — never a silent
|
||||
"PR opened unreviewed".
|
||||
|
||||
## Lifecycle effect
|
||||
|
||||
`StageReview` runs in the implement workflow after the deterministic gates and
|
||||
before `StageOpenPR`, gated by `repo.review_enabled` (opt-in, default off). A
|
||||
surviving blocking finding — or a review that failed to run — parks the task
|
||||
(`StatusParked`, not `waiting_human`) with the findings rendered into the park
|
||||
reason; `StageOpenPR` never runs. Warn/plausible findings and the zero-finding
|
||||
case leave the outcome unset, so the PR opens with a findings section rendered
|
||||
onto its body. `StagePostReviewComments` then runs after `StageOpenPR` and posts
|
||||
the **line-anchored** findings as inline review comments, carrying a one-click
|
||||
suggestion on a confirmed finding the reviewer could state a fix for. That stage
|
||||
is best-effort — a comment that fails to post is logged, never a park — because
|
||||
the body section already lists every finding, and it is the record a whole-file
|
||||
finding (no line to anchor to) only ever appears in.
|
||||
|
||||
## Model and budget
|
||||
|
||||
The reviewer model is `models.reviewer`, falling back to `models.builder`.
|
||||
Effort is the per-stage `MaxSteps` budget, mapped onto `Subagent.MaxSteps`
|
||||
(default 10).
|
||||
|
||||
## Operator-triggered review
|
||||
|
||||
The same reviewer runs against an *existing* PR via the channel-neutral
|
||||
`review_pr` chat command: fetch the PR's head, snapshot it, run the isolated
|
||||
reviewer, and return the structured findings. Authorization is identity-scoped
|
||||
to the operator's configured repositories; duplicate or concurrent reviews of
|
||||
the same PR are deduplicated.
|
||||
@@ -1,386 +0,0 @@
|
||||
# Agent System
|
||||
|
||||
**Status:** Current-state investigation in progress
|
||||
**Date:** 2026-07-28
|
||||
**Tracking issue:** [#73](https://github.com/samcharles93/archie-core/issues/73)
|
||||
|
||||
## Domain framing
|
||||
|
||||
The domain is the Agent System.
|
||||
|
||||
`Task` is not a core Agent System concept. Forge tasks, forge issues, Jira
|
||||
issues, email, Telegram messages, webhooks, and future external inputs are
|
||||
channel-specific messages. Channels translate those messages into requests to
|
||||
the Agent System; external issue or task models MUST NOT shape execution state.
|
||||
|
||||
The current `store.Task` is a persisted workflow execution. Treating that row as
|
||||
a task-domain aggregate would incorrectly turn Archie into an agentic issue
|
||||
board.
|
||||
|
||||
## Canonical agent interaction model
|
||||
|
||||
An **Agent** is a persistent assistant selected for an interaction. It is not a
|
||||
model invocation and is not a WorkflowExecution.
|
||||
|
||||
Each Agent has its own:
|
||||
|
||||
- immutable acting `IdentityID` for ownership and audit;
|
||||
- durable memory and learned information about the user;
|
||||
- perspective, specialisation, instructions, and communication behaviour;
|
||||
- conversation history and channel bindings;
|
||||
- available tools, capabilities, and policy;
|
||||
- continuity across model or provider changes.
|
||||
|
||||
The underlying model is a replaceable runtime dependency. Changing a model,
|
||||
provider, or model version MUST NOT create a new Agent, discard its memory, or
|
||||
change ownership of its history.
|
||||
|
||||
A user MAY create multiple Agents. Each Agent develops its own memory and view
|
||||
of the user from the interactions and responsibilities assigned to it. Memories
|
||||
MUST NOT be silently pooled merely because Agents belong to the same user or
|
||||
application.
|
||||
|
||||
Agent and Identity are separate aggregates. Every Agent references exactly one
|
||||
acting IdentityID, and no two Agents share an agent identity. User, system, and
|
||||
service-account identities may exist without an Agent.
|
||||
|
||||
An action initiated through an Agent records the Agent's acting IdentityID and,
|
||||
when applicable, the initiating user's IdentityID. A future fully automated
|
||||
WorkflowExecution MAY use an explicitly selected service-account identity for a
|
||||
concrete unattended use case; this is not the default execution identity.
|
||||
|
||||
## Workflow execution identity
|
||||
|
||||
A Workflow is owned by an IdentityID. By default, every WorkflowExecution acts
|
||||
as the Workflow owner's identity.
|
||||
|
||||
Future delegated execution MAY add an explicit `RunAsIdentityID` assignment to a
|
||||
Workflow. This allows a Workflow owner to select another user or service-account
|
||||
identity for execution without changing Workflow ownership. Until that
|
||||
capability is deliberately introduced, owner identity and execution identity are
|
||||
the same.
|
||||
|
||||
WorkflowExecution audit records MUST preserve the Workflow owner, effective
|
||||
execution identity, initiating user when one exists, and any explicit delegation
|
||||
that selected a different run-as identity.
|
||||
|
||||
## Memory scopes
|
||||
|
||||
The Agent System requires four distinct durable memory scopes:
|
||||
|
||||
- **global shared memory**: information intentionally available across the
|
||||
Archie application;
|
||||
- **agent-wide memory**: general expertise, operating knowledge, and perspective
|
||||
owned by one Agent and safe for that Agent to use across users;
|
||||
- **user-wide memory**: information associated with one user and available to
|
||||
authorized Agents serving that user;
|
||||
- **Agent-user relationship memory**: private history and learned context from
|
||||
one particular Agent's relationship with one particular user.
|
||||
|
||||
Agent-wide memory is private to its owning Agent by default. Another Agent MUST
|
||||
NOT read, inherit, search, or mutate it implicitly.
|
||||
|
||||
Agent-user relationship memory is addressed by both AgentID and User IdentityID.
|
||||
Neither another Agent serving the same user nor another user speaking to the
|
||||
same Agent may access it implicitly.
|
||||
|
||||
Archie is a multi-user system even when initially deployed for one person.
|
||||
Multiple users, including family members, may interact with the same configured
|
||||
Agents. Per-user memory is therefore an isolation and personalization boundary,
|
||||
not merely an attribution tag on the primary user's records.
|
||||
|
||||
An Agent MUST resolve the initiating user before assembling memory context.
|
||||
Memory belonging to one user MUST NOT become visible to another user merely
|
||||
because both users interact with the same Agent.
|
||||
|
||||
Shared memory does not erase provenance. Every memory record retains its scope,
|
||||
author or acting identity, originating user when applicable, source, and
|
||||
revision history. The rules for selecting a write scope, granting access
|
||||
to global and user-wide memory, and authorizing explicit cross-scope sharing are
|
||||
settled by [`docs/prds/memory-engine-unification.md`](../prds/memory-engine-unification.md)
|
||||
and recorded in [`migration-decisions.md`](migration-decisions.md#5-memory-placement-and-storage)
|
||||
section 5.
|
||||
|
||||
An Agent interaction may answer conversationally, use a tool or capability, read
|
||||
or send messages, retain information, or propose durable workflow-backed work.
|
||||
None of these operations inherently requires a WorkflowExecution.
|
||||
|
||||
## Agent and Workflow domain boundary
|
||||
|
||||
Agent and Workflow are separate domains:
|
||||
|
||||
```text
|
||||
internal/domain/agent
|
||||
internal/domain/workflow
|
||||
```
|
||||
|
||||
The Agent domain owns persistent assistants, their specialisation, instructions,
|
||||
model-independent continuity, capability context, and associations with identity
|
||||
and memory.
|
||||
|
||||
The Workflow domain owns reusable, user- or Agent-defined behaviour and every
|
||||
durable execution of that behaviour. An Agent may invoke or define a Workflow,
|
||||
but the Workflow is not part of the Agent aggregate and does not require a
|
||||
conversational Agent interaction to execute.
|
||||
|
||||
## Canonical workflow model
|
||||
|
||||
The Workflow feature uses these canonical terms:
|
||||
|
||||
- **Workflow**: a reusable, versioned definition of how an agent behaves and
|
||||
performs a kind of work.
|
||||
- **WorkflowExecution**: one durable execution of a specific Workflow version.
|
||||
- **WorkflowStep**: one defined operation in a Workflow.
|
||||
- **StepExecution**: the recorded execution and outcome of one WorkflowStep.
|
||||
- **Attempt**: a retry of the same WorkflowExecution, not a new execution.
|
||||
|
||||
A Workflow MAY structure any repeatable agent behaviour, including personal
|
||||
assistance and scheduled routines. For example, a morning email review may
|
||||
combine a schedule event, message retrieval tool, LLM classification and
|
||||
summarisation, and delivery of the resulting rundown. Workflow is therefore not
|
||||
restricted to forge work, source changes, or requests submitted by a user at
|
||||
execution time.
|
||||
|
||||
Workflows are extensible through Workflow-owned plugins. The Workflow domain
|
||||
defines the typed plugin registration, definition, validation, versioning, and
|
||||
execution contracts. Users and Agents may define reusable Workflows through
|
||||
those contracts.
|
||||
|
||||
The generic plugin contract remains metadata-only. It MUST NOT own Workflow
|
||||
semantics or replace the Workflow registry with generic hooks.
|
||||
|
||||
`Workflow` and `WorkflowExecution` are the names used in architecture, generated
|
||||
reference, configuration, commands, events, and external contracts. The
|
||||
implementation MAY use package qualification to remain concise:
|
||||
|
||||
```go
|
||||
workflow.Definition
|
||||
workflow.Execution
|
||||
workflow.Step
|
||||
workflow.StepExecution
|
||||
```
|
||||
|
||||
The unqualified name `Execution` MUST NOT be used in cross-domain contracts or
|
||||
documentation because it is ambiguous among workflow, tool, command, policy, and
|
||||
service execution.
|
||||
|
||||
## Current workflow-execution feature
|
||||
|
||||
The current feature takes a channel request through agent execution and a
|
||||
durable outcome.
|
||||
|
||||
Current execution state includes source-message references, owning identity,
|
||||
repository, selected workflow and stage, agent output, branch and pull-request
|
||||
references, token and iteration counts, retry information, human-wait
|
||||
information, and failure details.
|
||||
|
||||
The current `store.Task` lifecycle uses:
|
||||
|
||||
```text
|
||||
queued -> running
|
||||
running -> waiting_human | pr_open | merged | parked | closed_wont_do
|
||||
waiting_human -> queued | closed_wont_do
|
||||
parked -> queued | dead
|
||||
pr_open -> merged | rejected
|
||||
running after crash -> queued
|
||||
```
|
||||
|
||||
Workflows select and sequence deterministic and agent-run stages. Implement,
|
||||
TDD, feasibility, and bootstrap are current Workflow definitions.
|
||||
Every WorkflowExecution is handed wholesale over core NATS to a task-scoped
|
||||
`archie-agent` container, which owns the workflow stage loop.
|
||||
|
||||
## Current workflow-feature placement
|
||||
|
||||
The behaviour is divided across technical packages:
|
||||
|
||||
- `internal/store` defines the current `Task` execution record and status
|
||||
strings and persists mutable state and transition history.
|
||||
- `internal/daemon` discovers, claims, schedules, retries, recovers, processes,
|
||||
waits for human input, and reconciles pull requests.
|
||||
- `internal/domain/workflow` routes work, executes stages, mutates tasks, applies
|
||||
outcomes, parks failures, and performs forge/worktree operations.
|
||||
- `internal/agentexec` defines and runs individual autonomous-stage protocols.
|
||||
- `internal/taskrun` hands a complete WorkflowExecution to a container worker.
|
||||
- `internal/gate` and repository configuration define execution constraints.
|
||||
- `internal/gateway` duplicates task status strings and applies task-control
|
||||
rules.
|
||||
- forge, worktree, NATS, SQLite, containers, and agent runtimes are concrete
|
||||
dependencies mixed into orchestration.
|
||||
|
||||
## Current `task` meanings and required replacements
|
||||
|
||||
The existing code uses `task` for unrelated concepts. Migration MUST resolve
|
||||
each meaning deliberately; a global text replacement is prohibited.
|
||||
|
||||
| Current meaning | Representative locations | Target concept | Requirements |
|
||||
| -------------------------------------------------- | --------------------------------------------------------------- | -------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
|
||||
| Forge issue or external task | `internal/forge`, daemon polling | Channel message | Preserve the channel's native reference and payload. Translate it into an Agent System request without importing forge or issue semantics into Workflow. |
|
||||
| Jira issue or other external work item | Messaging infrastructure adapter | Channel message or external artifact | The external system retains its own vocabulary inside its integration. Its record may lead to an accepted work request but is not a Workflow or WorkflowExecution. |
|
||||
| Persisted `store.Task` row | `internal/store` | WorkflowExecution | Own identity, Workflow ID and version, lifecycle, source-message reference, outputs, attempts, and outcome. Persistence implements the Agent System repository contract. |
|
||||
| Task status and transition history | `store.Status*`, `transitions` | WorkflowExecution lifecycle and domain events | Enforce legal transitions atomically. Domain events and state changes cannot diverge. Remove duplicated status strings from consumers. |
|
||||
| Claimed or queued task | `ClaimNext`, `ClaimByIssue`, `RecoverStale` | Scheduled WorkflowExecution | Claim by WorkflowExecution ID and expected version/state. Crash recovery and leases must not silently create a new execution. |
|
||||
| `workflow.TaskContext` | `internal/domain/workflow` | WorkflowExecution context | Replace the mutable service bag with execution state plus narrow step-required contracts. Complete application configuration and unrelated services are forbidden. |
|
||||
| `taskrun.Request` and `taskrun.Response` | `internal/taskrun`; consumed by `internal/app/agentworker`, decoded by `internal/infrastructure/agenttransport/nats` | WorkflowExecution handoff | This is the versioned worker contract for executing a WorkflowExecution. It carries domain-owned execution data, not store rows or global configuration DTOs. |
|
||||
| Per-stage `agentexec.Request.TaskID` | `internal/agentexec` | WorkflowExecutionID correlation | An agent invocation is a bounded WorkflowStep execution. Correlate request/result with WorkflowExecutionID, StepExecutionID, attempt, and protocol version. |
|
||||
| NATS `TaskMessage` and `archie.task.*` | `internal/domain/workintake` (subjects, `TaskEnvelope`); `internal/infrastructure/agenttransport/nats` (transport) -- `internal/nats` no longer exists; whether this row's "current meaning" itself is now superseded by `TaskEnvelope` needs a closer look, not asserted here | Channel request or WorkflowExecution transport | Discovery messages and execution dispatch are different contracts and subjects. Domain meaning stays outside NATS infrastructure. Identity and source-message idempotency must be explicit. |
|
||||
| `taskDispatcher` work item | `internal/daemon` | WorkflowExecution scheduling | Scheduling operates on execution references and declared concurrency policy. Repository serialization is policy, not identity derived from an incomplete task struct. |
|
||||
| `container.TaskPayload` and `task.json` | `internal/container`; read by `internal/infrastructure/agentboot` | WorkflowExecution brief | Rename the boot artifact and schema. It identifies the mounted execution and required workspace only; it is not an alternative execution definition. Missing or malformed input must fail startup before the worker subscribes. |
|
||||
| `storage.TaskRef` | `internal/storage` | WorkflowExecution workspace lease | Storage receives the minimal execution/workspace reference and policy required to provision and release resources. It does not receive the WorkflowExecution aggregate. |
|
||||
| Gateway `TaskCreator` | `internal/gateway` | Accepted work request handoff | A channel may carry a request for durable workflow-backed work, but it does not request or create a WorkflowExecution directly. Work intake admits and routes the request; the Agent System consumes the accepted work request and is the sole owner of selecting a Workflow version and creating the WorkflowExecution. Ordinary agent interactions do not require this handoff. |
|
||||
| Gateway `TaskController` and `ChatTaskStatus` | `internal/gateway/tasks.go` | WorkflowExecution commands and query view | Approve, cancel, and status use Agent System contracts. Channel code does not duplicate lifecycle constants or decide transitions. |
|
||||
| Gateway `TaskProfile` | `internal/gateway/tasks.go`, `cmd/archied` | Channel/identity execution defaults | This is configuration selecting allowed source targets and default Workflow inputs, not task state. Split it into settings owned by the relevant channel and Agent System features. |
|
||||
| `config.TaskConfig` and `TaskForge` | `internal/config` | Worker execution settings and channel/service references | Dissolve with `internal/config`. Each field moves to its owning runtime settings or versioned WorkflowExecution handoff contract. Secrets and external configuration forms do not enter the domain. |
|
||||
| `events.Event.TaskID`, task event timelines | `internal/events`, stores, web UI | WorkflowExecutionID and WorkflowExecution events | Authoritative events are Agent System events. Observability and timelines project those events rather than inventing parallel generic task events. |
|
||||
| Web UI task lists and counts | `internal/webui`, store query APIs | WorkflowExecution read model | Dashboard status, history, and counts are projections of WorkflowExecution state and events. The UI does not depend on persistence records. |
|
||||
| Task-scoped forge/store/worktree RPC | `forgerpc`, `storerpc`, `worktreerpc`, `registerTaskRPCServers` | Execution-scoped capability ports | Worker calls use narrow domain-required service contracts, carry WorkflowExecutionID and IdentityID, and resolve the owning capability binding. Root-client fallback is forbidden. |
|
||||
| Per-task worktree, branch, volume, and cleanup | daemon, worktree, storage, container | WorkflowExecution workspace | Every WorkflowExecution receives isolated workspace state. Workspace lifecycle is explicit, identity-aware, recoverable, and controlled outside the model. |
|
||||
| Task retry, dead, waiting-human, PR reconciliation | daemon, workflow, gateway | WorkflowExecution lifecycle policies | Retry, waiting, cancellation, reconciliation, and terminal outcomes are Agent System behaviour. Channels and infrastructure report facts or submit commands; they do not mutate state. |
|
||||
| Task-run readiness and retry timeouts | daemon taskrun request loop | Worker-dispatch settings and policy | These settings govern WorkflowExecution handoff availability. They are not Workflow data and must be owned by the worker-dispatch capability. |
|
||||
|
||||
### Terms that do not migrate
|
||||
|
||||
- The `task` command in `Taskfile.yml` is the external Task build tool and keeps
|
||||
its name.
|
||||
- A forge may call its own records issues or tasks inside its channel adapter.
|
||||
- General prose may use “task” informally only when it clearly refers to an
|
||||
external system. Agent System contracts and generated reference MUST use the
|
||||
canonical Workflow vocabulary.
|
||||
|
||||
## Current WorkflowExecution data inventory
|
||||
|
||||
This inventory is the migration ledger for data currently spread across
|
||||
`store.Task`, database-only columns, `workflow.TaskContext`, worker messages,
|
||||
and surrounding configuration. Implementation SHOULD NOT require another
|
||||
repository-wide search to determine what existing execution data must be
|
||||
preserved or deliberately removed.
|
||||
|
||||
| Current data | Current representation | Required target |
|
||||
| ---------------------- | ----------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------- |
|
||||
| Execution identity | `Task.ID`, `task_id`, NATS subjects, logs | Immutable WorkflowExecutionID used consistently by state, events, workers, projections, and capability calls |
|
||||
| Owning actor | `Task.Identity` string | Canonical IdentityID |
|
||||
| Source type | `Task.Source` (`forge` or `chat`) | Typed channel and SourceMessageReference; no closed source enum in WorkflowExecution |
|
||||
| Source address | `Owner`, `Repo`, `IssueNumber`; synthetic chat issue number | Channel-owned source reference with native message/thread/object identifiers; synthetic identifiers removed |
|
||||
| Requested work | `Title`, `Body`, `Labels` | Immutable execution input captured from the source request; channel-specific metadata retained in the source envelope |
|
||||
| Workflow selection | `Workflow` string | Immutable WorkflowID plus selected WorkflowVersion |
|
||||
| Lifecycle | `Status` string | Enforced WorkflowExecution state |
|
||||
| Current position | mutable `Stage` string | Derived current WorkflowStep reference plus durable StepExecution history |
|
||||
| Attempts | `Attempt`, `RetryCount` | Execution attempt history and retry-policy evidence; distinguish worker delivery retry from workflow retry |
|
||||
| Failure | `ParkReason`, transition detail, response errors | Typed failure classification, evidence, retryability, and resulting lifecycle event |
|
||||
| Human wait | `WatchCommentID`, `waiting_human` | Channel-neutral wait condition and correlation reference; forge comment IDs stay in the forge channel |
|
||||
| Workspace | `Dir`, `Branch`, worktree path, `task.json` | Execution workspace reference and independently managed workspace lifecycle |
|
||||
| Change outcome | `BuildSummary`, `BuildNoChanges`, changed files | Step outputs and final WorkflowExecution outcome |
|
||||
| Reproduction evidence | `ReproProof` | Typed TDD step evidence retained with the StepExecution and final outcome |
|
||||
| Planning output | `Plan` | Typed step output referenced by later steps rather than a special aggregate field |
|
||||
| Notes | `Notes`, appended agent notes | Ordered execution annotations with actor, source step, and timestamp |
|
||||
| Pull request | `PRNumber`, forge host/repository assumptions | Forge-channel delivery reference and reconciliation state |
|
||||
| Agent usage | `TokensUsed`, `Iterations` | StepExecution usage measurements aggregated into execution projections |
|
||||
| Decision capture | private feasibility `decision`, capture-tool output | Typed WorkflowStep output defined by that Workflow version |
|
||||
| Terminal outcome | mutable `Outcome{Status, Detail}` | Explicit WorkflowExecution outcome command/event validated by the state machine |
|
||||
| Skill context | `SkillBody`, `SkillPlugins` | Resolved Workflow version dependencies or execution inputs, with provenance |
|
||||
| Agent prompt context | `SystemPrompt`, `ExtraRules`, mission strings | Versioned WorkflowStep definition plus resolved execution context; mutable global prompt callbacks removed |
|
||||
| Gates and protection | `Gate`, `Preflight`, `Protection`, repository config | Agent System policy definitions resolved for the WorkflowExecution and enforced outside the agent |
|
||||
| Budgets | steps, tokens, wall clock, gate failures | Execution and StepExecution policy values with measured usage and evidence |
|
||||
| Tool access | capture tools, registry, guardrails, skill plugins | Resolved step capability set and policy; global registry pointers do not enter execution state |
|
||||
| Persistence timestamps | SQL `created_at` and `updated_at` | Domain timestamps and version used for optimistic concurrency and audit |
|
||||
| Transition history | SQL `transitions` and generic events | Authoritative WorkflowExecution domain events stored atomically with state |
|
||||
|
||||
## Current runtime responsibilities to unify
|
||||
|
||||
The following behaviours currently act on the same WorkflowExecution but are
|
||||
implemented in different packages:
|
||||
|
||||
- accept a request from a channel and enforce idempotency;
|
||||
- select and version a Workflow;
|
||||
- create, queue, claim, schedule, and execute a WorkflowExecution;
|
||||
- serialize same-repository execution where policy requires it;
|
||||
- resolve identity-specific capabilities;
|
||||
- prepare, retain, recover, and clean up the workspace;
|
||||
- run deterministic and agent-backed WorkflowSteps;
|
||||
- enforce gates, budgets, protected paths, tool constraints, and result review;
|
||||
- persist state and StepExecution outputs;
|
||||
- publish authoritative lifecycle events;
|
||||
- wait for channel input and resume;
|
||||
- classify failure, retry, park, mark exhausted, cancel, or recover after crash;
|
||||
- deliver and reconcile forge changes;
|
||||
- project status, history, counts, and audit for channels and the web UI;
|
||||
- hand execution to a worker without moving domain ownership to the worker.
|
||||
|
||||
## Current workflow-feature hazards
|
||||
|
||||
- There is no enforced WorkflowExecution state machine. `Store.Transition`
|
||||
ignores the supplied `from` state when updating the row.
|
||||
- State update and transition-history insertion are separate operations, so
|
||||
state and audit can diverge.
|
||||
- Callers frequently discard persistence and transition errors.
|
||||
- Gateway task control duplicates lifecycle status constants by hand.
|
||||
- `workflow.TaskContext` is a mutable service bag containing complete
|
||||
configuration plus forge, store, worktree, agent, event bus, logging, memory,
|
||||
guardrails, skills, and scratch state.
|
||||
- Lifecycle changes occur in both daemon and workflow code.
|
||||
- Workflow orchestration runs inside task-scoped agent containers while the
|
||||
daemon retains lifecycle, admission, and authority-bearing RPC ownership.
|
||||
- Forge-backed and chat-created work share one record through source flags and
|
||||
synthetic issue numbers.
|
||||
- Repository labels currently select workflows and mirror task state, coupling
|
||||
domain transitions to forge presentation.
|
||||
- Failure generally becomes `parked`, but failure classification and
|
||||
retryability are not represented explicitly.
|
||||
- Generic observability events are emitted alongside state changes rather than
|
||||
being the authoritative domain events.
|
||||
|
||||
## Existing invariants to preserve
|
||||
|
||||
- The model never performs git operations directly.
|
||||
- Deterministic policy and gates cannot be waived by the agent.
|
||||
- TDD captures a failing reproduction before implementation and protects the
|
||||
test during the fix.
|
||||
- Every run ends in an explicit outcome; definition errors and stage errors do
|
||||
not disappear silently.
|
||||
- Crash recovery requeues interrupted work.
|
||||
- Agent execution crosses a versioned data boundary.
|
||||
- Forge, persistence, workspace, transport, container, and model runtimes remain
|
||||
replaceable infrastructure.
|
||||
- Work from the same repository is serialized by default.
|
||||
|
||||
## Required migration
|
||||
|
||||
- Rename the current persisted `store.Task` concept to WorkflowExecution.
|
||||
- Replace task lifecycle terminology in core commands, events, persistence,
|
||||
worker contracts, logs, and generated reference.
|
||||
- Preserve external source terminology only inside its channel adapter.
|
||||
- Replace synthetic issue numbers with explicit source-message references.
|
||||
- Associate every WorkflowExecution with an immutable Workflow identifier and
|
||||
version.
|
||||
- Record StepExecutions explicitly rather than treating one mutable `stage`
|
||||
field as complete execution history.
|
||||
- Keep Attempt as retry state within the same WorkflowExecution.
|
||||
|
||||
## Curator isolation invariant
|
||||
|
||||
Decided 2026-08-05
|
||||
([#435](https://github.com/samcharles93/archie-core/issues/435) epic,
|
||||
[#98](https://github.com/samcharles93/archie-core/issues/98) runtime).
|
||||
Recovered 2026-08-09 from the pre-migration issue tracker.
|
||||
|
||||
**Curators are peers, not dependencies.** They must never block, delay, or take
|
||||
down chat turns, agent runs, or the daemon.
|
||||
|
||||
1. Registry-owned goroutines, one per curator, with per-pass `recover()`,
|
||||
per-pass budgets (max steps, tokens, timeout), and a configurable maximum of
|
||||
concurrent passes (default 1) so curators cannot saturate the shared LLM
|
||||
runtime against chat.
|
||||
2. Wake events ride the in-process `events.Bus`, which is mutex fan-out with
|
||||
bounded per-subscriber buffers that **drop** on overflow
|
||||
(`internal/events/events.go`). A slow curator can never backpressure the chat
|
||||
publisher.
|
||||
3. Wake is a best-effort nudge. The trigger is a deterministic read of persisted
|
||||
primary-input state at pass time, so a dropped wake only delays a run to the
|
||||
next check-in and never corrupts trigger accounting
|
||||
([#22](https://github.com/samcharles93/archie-core/issues/22)).
|
||||
4. The curator registry lifecycle is independent of the agent loop. Daemon
|
||||
shutdown cancels in-flight passes and waits bounded.
|
||||
|
||||
Chat turns keep their per-session lanes; agent runs keep their workflow
|
||||
goroutines and containers. Rule of thumb: **no code path a curator executes may
|
||||
ever appear on a chat turn's critical path.**
|
||||
@@ -1,189 +0,0 @@
|
||||
# Playbook bindings: model and threat model
|
||||
|
||||
**Status:** Approved foundation (documents shipped code: `archie-core-t2db.1`
|
||||
through `.5`, `.7`, `.9`-`.15`)
|
||||
**Date:** 2026-09-03
|
||||
|
||||
This document covers the binding model and the intake threat model portion
|
||||
of `archie-core-t2db.6`. It does not cover the `ARCHITECTURE.md` task-lifecycle
|
||||
addendum or the operator walkthrough -- those remain separate, open pieces of
|
||||
the same ticket.
|
||||
|
||||
## What a binding is
|
||||
|
||||
A `binding` (`internal/domain/binding.Binding`) ties four things together:
|
||||
a **matcher** (which captured events it applies to), a **mapping**
|
||||
(`internal/domain/mapping.Mapping`, how fields are pulled out of a payload),
|
||||
a **workflow** (which registered workflow runs on a match), and a **state
|
||||
machine** governing whether it is live.
|
||||
|
||||
```go
|
||||
type Binding struct {
|
||||
ID, Name // identity
|
||||
Matcher // { Source string } -- the webhook path segment, e.g. "sentry"
|
||||
MappingID // which Mapping resolves payload fields
|
||||
Workflow // registered workflow name to dispatch to
|
||||
Version // bumped on every edit
|
||||
Status // draft | pending_approval | armed
|
||||
Secret // HMAC-SHA256 shared secret, encrypted at rest, never returned by GET
|
||||
}
|
||||
```
|
||||
|
||||
Bindings live in the store (SQLite), not `config.toml` -- operators author
|
||||
them from the dashboard while the daemon runs, without a restart.
|
||||
|
||||
### Matching
|
||||
|
||||
`Matcher.Source` is the only predicate today: the path segment a sender
|
||||
POSTs to (e.g. a webhook hitting `.../sentry` matches bindings with
|
||||
`Matcher.Source == "sentry"`). The storage column is plain `TEXT`, so adding
|
||||
predicates later is non-breaking -- extend `Matcher`, don't invent a second
|
||||
matcher shape.
|
||||
|
||||
### Mapping
|
||||
|
||||
`mapping.Resolve(fields, payload)` walks a captured JSON payload against a
|
||||
list of typed `Field`s (name, JSON path, expected type), returning resolved
|
||||
values plus a `[]Failure` for anything that didn't parse or type-match. This
|
||||
is schema-by-example in practice: a mapping is authored by pointing at a
|
||||
real captured payload in the dashboard, not by guessing a schema in advance.
|
||||
|
||||
### Versioning
|
||||
|
||||
`Version` increments on every `UpdateBinding` call. This exists so an
|
||||
editor's later change can never silently rewrite the historical provenance
|
||||
of a task that already fired -- a dispatched task's binding reference is
|
||||
pinned to the version that was armed when it fired, not "whatever the
|
||||
binding currently says."
|
||||
|
||||
### State machine
|
||||
|
||||
```
|
||||
draft ---> pending_approval ---> armed
|
||||
^ ^ |
|
||||
| | |
|
||||
+--------------+-----------------+
|
||||
(any edit to an armed binding drops it back to pending_approval)
|
||||
```
|
||||
|
||||
Modeled directly on Telegram's existing `dangerousAction`/`pendingApproval`
|
||||
flow (`internal/channels/telegram/dangerous.go`, `approval.go`) -- not a new
|
||||
approval mechanism invented for this feature. **Only `armed` evaluates
|
||||
against incoming events** (`binding.Matches`, `internal/domain/binding/
|
||||
binding.go`); `draft` and `pending_approval` bindings are inert. An edit to
|
||||
an already-armed binding cannot bypass approval by silent mutation -- it
|
||||
drops back to `pending_approval` and requires an explicit `Approve` call to
|
||||
re-arm.
|
||||
|
||||
## The threat model
|
||||
|
||||
This is a public, unauthenticated-by-default intake surface whose output is
|
||||
an agent with a repo, a worktree, and tool access. The design brief
|
||||
(`archie-core-t2db.5`, `docs/prds/webhook-intake-security.md`) named five
|
||||
non-negotiables; each is verified below against the actual shipped code,
|
||||
not the design intent.
|
||||
|
||||
### 1. Per-source authentication
|
||||
|
||||
Reuses `internal/channels/webhook`'s existing HMAC-SHA256 scheme --
|
||||
capture accepts unsigned events (visible in the dashboard, marked
|
||||
unauthenticated), but **only authenticated events can ever match a
|
||||
binding**. `binding.Matches`' doc comment states this plainly: "an
|
||||
unauthenticated event can never trigger a binding, no matter how well it
|
||||
would otherwise match." Enforced structurally at two points, not just
|
||||
convention:
|
||||
|
||||
- `captured_events.authenticated` is a real column (`internal/store/
|
||||
captures.go`), set at capture time.
|
||||
- `dispatchBindings` (`internal/daemon/daemon.go:479`) walks **authenticated
|
||||
captures whose source has at least one armed binding** -- an
|
||||
unauthenticated capture is never even considered for dispatch.
|
||||
|
||||
### 2. Human approval before a binding goes live
|
||||
|
||||
Covered by the state machine above. Nothing self-arms: `pending_approval ->
|
||||
armed` requires an explicit `Approve` call, and any edit to an armed
|
||||
binding reverts it.
|
||||
|
||||
### 3. Rate and volume limits per source
|
||||
|
||||
Capture writes are bounded independently of the approval gate, so a flood
|
||||
of unauthenticated traffic cannot exhaust disk or drown the inspector:
|
||||
`InsertCapture` (`internal/store/captures.go`) prunes by both **retention
|
||||
window** (`WHERE received_at < cutoff`) and **max event count** in the same
|
||||
insert transaction.
|
||||
|
||||
### 4. Blast radius bounded by the same code-level controls every task gets
|
||||
|
||||
A playbook-originated task is dispatched into the **same** gate, diff-cap,
|
||||
sandboxed-container, worktree-isolation pipeline every task goes through
|
||||
regardless of origin. Verified precisely, not assumed: `dispatchOneBinding`
|
||||
calls `EnqueueBindingTask` (`internal/store/store.go`), which wraps
|
||||
`EnqueueChatTask` -- the same direct-to-`tasks`-table enqueue path
|
||||
chat-spawned tasks already use, then stamps `binding_id`/`binding_version`
|
||||
for provenance in a second statement. This is a **different** enqueue
|
||||
mechanism from forge-issue polling's `workintake.TaskEnvelope`/NATS path
|
||||
(`docs/prds/event-sources-and-reactions.md`) -- binding and forge-issue
|
||||
tasks arrive by different producers, but both become an ordinary
|
||||
`store.Task` row that `ClaimNext` picks up identically, so both get the
|
||||
same gate/worktree pipeline downstream regardless of which producer created
|
||||
the row. Payload content is
|
||||
ordinary untrusted prompt input; the sender's text is never treated as a
|
||||
trusted instruction (Archie's environmental-enforcement principle: "the
|
||||
agent should ignore instructions in the payload" is not itself a control,
|
||||
the surrounding sandbox is).
|
||||
|
||||
### 5. Captured payloads may contain secrets from the sending system
|
||||
|
||||
Two independent protections, not one:
|
||||
|
||||
- **Redaction before persistence**: `webhookguard.RedactPayload` walks the
|
||||
decoded JSON and redacts recognised sensitive keys before the row is
|
||||
written -- the raw, unredacted payload is never durably stored.
|
||||
- **Retention**: a configurable window (`InsertCapture`'s `retention`
|
||||
parameter) prunes old captures automatically; visibility of what remains
|
||||
is gated by the same dashboard authentication as every other webui
|
||||
surface, not a separate, weaker path.
|
||||
|
||||
### Secrets at rest
|
||||
|
||||
`Binding.Secret` (the HMAC shared secret a sender signs with) is encrypted
|
||||
at rest via AES-GCM (`internal/store/binding_cipher.go`, `archie-core-
|
||||
t2db.7`) -- a leaked SQLite file does not leak sender-side shared secrets in
|
||||
plaintext. The envelope is versioned (`bindingEnvelopeVersion`) so a future
|
||||
cipher or KDF change can roll forward without breaking already-encrypted
|
||||
rows, and the AAD binds ciphertext to the binding-secret context so it
|
||||
cannot be relocated to another field/column and still authenticate. A `nil`
|
||||
cipher (no encryption key configured) leaves secrets as plaintext --
|
||||
documented legacy behaviour, not silent degradation.
|
||||
|
||||
### At-most-once dispatch
|
||||
|
||||
`dispatchBindings` enqueues at most one task per `(binding, capture)` pair,
|
||||
enforced by a real ledger, not best-effort application logic:
|
||||
`RecordDispatch` (`internal/store/bindings.go`) does `INSERT OR IGNORE` into
|
||||
`binding_dispatches`, unique on `(binding_id, capture_id)`; a duplicate
|
||||
insert returns the sentinel `ErrAlreadyDispatched`, which the dispatch loop
|
||||
treats as "another cycle raced us," not an error. This guarantee holds
|
||||
**across daemon restarts**, not just within one process's lifetime, because
|
||||
the ledger is a durable table, not in-memory state.
|
||||
|
||||
This ledger is also the direct precedent for the EDA playbook engine's
|
||||
execution-time idempotency, now landed (`archie-core-t2db.17` closed): the
|
||||
`playbook_dispatches` table in `internal/store/playbook_dispatches.go` copies
|
||||
`binding_dispatches`'s `INSERT OR IGNORE` conventions with a
|
||||
`(playbook_id, playbook_version, event_id, action_id)` key
|
||||
(`docs/prds/eda-playbook-engine.md` gap 2).
|
||||
|
||||
## What this document does not cover
|
||||
|
||||
- The `ARCHITECTURE.md` task-lifecycle section noting that a
|
||||
playbook-originated task has different provenance from a forge-issue
|
||||
task -- open, part of `archie-core-t2db.6`.
|
||||
- An end-to-end operator walkthrough (point an external app at archie,
|
||||
build a first playbook) -- open, part of `archie-core-t2db.6`.
|
||||
- The playbook YAML / CEL / Module/Channel/Forge action-position work
|
||||
(`docs/prds/eda-playbook-engine.md`, `module-position.md`,
|
||||
`channel-forge-positions.md`) -- a different, newer mechanism than the
|
||||
binding model described here; the two are related but not the same
|
||||
system, and this document does not attempt to unify them.
|
||||
@@ -1,409 +0,0 @@
|
||||
# Configuration
|
||||
|
||||
**Status:** Approved; existing-type assignment is ongoing
|
||||
**Date:** 2026-07-28
|
||||
**Tracking issue:** [#73](https://github.com/samcharles93/archie-core/issues/73)
|
||||
|
||||
## Ownership
|
||||
|
||||
Configuration has two separate responsibilities:
|
||||
|
||||
1. `internal/infrastructure/configuration` loads files, environment variables,
|
||||
secret references, overlays, and compatibility representations.
|
||||
2. Each domain and plugin owns the typed runtime settings required for its
|
||||
behaviour.
|
||||
|
||||
`internal/app` translates external input into those settings, validates
|
||||
cross-capability combinations, and supplies each component only its own
|
||||
settings.
|
||||
|
||||
The following are prohibited:
|
||||
|
||||
- passing complete application configuration into a domain;
|
||||
- making a domain depend on TOML, YAML, environment-variable names, secret
|
||||
references, or a configuration library;
|
||||
- defining a central runtime configuration type imported across the system;
|
||||
- placing plugin options in an unrelated global configuration model.
|
||||
|
||||
## Private input document
|
||||
|
||||
`internal/infrastructure/configuration` MAY use a complete decoded document
|
||||
while discovering files, decoding sections, and applying overlays. It is an
|
||||
input-boundary DTO only.
|
||||
|
||||
The document:
|
||||
|
||||
- remains private to the configuration infrastructure;
|
||||
- is composed from separately defined feature sections;
|
||||
- is immediately translated by application composition;
|
||||
- is never returned as the application's runtime model;
|
||||
- is never passed through runtime components.
|
||||
|
||||
External DTOs and domain runtime settings are separate types.
|
||||
|
||||
Plugins supply external configuration definitions through a narrow extension
|
||||
contract. The core loader MUST NOT gain a field or recognized filename for every
|
||||
plugin.
|
||||
|
||||
Invalid configuration input MUST NOT replace active valid settings or terminate
|
||||
unaffected capabilities. Configuration changes use the candidate validation,
|
||||
promotion, audit, and recovery requirements in
|
||||
[safe-change-and-recovery.md](safe-change-and-recovery.md).
|
||||
|
||||
## Dissolution of `internal/config`
|
||||
|
||||
`internal/config` has no target location. It MUST be dissolved and MUST NOT
|
||||
survive as a shared package, configuration domain, or renamed global model.
|
||||
|
||||
Its loading behaviour moves to `internal/infrastructure/configuration`. Existing
|
||||
types and methods are reassigned by behaviour. Repository execution policy,
|
||||
dispatch policy, retry policy, ecosystem defaults, tool policy, memory settings,
|
||||
indexing settings, provider settings, and channel settings move to their
|
||||
respective owners.
|
||||
|
||||
## Repository settings
|
||||
|
||||
The existing `config.Repo` MUST NOT move intact into a repository domain or
|
||||
shared settings package. A managed repository is an application association:
|
||||
|
||||
- work intake owns which repository references an identity monitors;
|
||||
- task execution owns gates, preflight, test protection, ecosystem behaviour,
|
||||
and change limits;
|
||||
- task lifecycle owns retry behaviour;
|
||||
- scheduling owns concurrency policy;
|
||||
- workspace management owns base branch and persistent-storage requirements.
|
||||
|
||||
Application composition correlates these settings by repository reference. No
|
||||
domain receives a universal repository profile.
|
||||
|
||||
## Documentation
|
||||
|
||||
Generated configuration reference describes external sections and their owning
|
||||
capabilities. It MUST NOT establish a global Go configuration structure as the
|
||||
public contract.
|
||||
|
||||
## Value classification rule
|
||||
|
||||
Every value that controls behaviour MUST have an explicit owner and MUST be
|
||||
classified as exactly one of:
|
||||
|
||||
1. **Invariant** — changing it changes the meaning of the program, a wire
|
||||
protocol, or a domain concept. It may be a Go constant.
|
||||
2. **Runtime setting** — an operator, identity, domain, plugin, or deployment
|
||||
may legitimately choose a different value. It is typed configuration owned by
|
||||
the affected capability.
|
||||
3. **Policy value** — it expresses what is allowed, limited, routed, retried,
|
||||
protected, or gated. Its typed definition belongs to the owning domain and it
|
||||
is evaluated through the policy system.
|
||||
4. **Derived value** — it is computed from other settings and is not
|
||||
independently mutable.
|
||||
5. **Runtime state** — it changes as the application operates, such as the
|
||||
active model for a conversation. It is changed by a domain command and is not
|
||||
configuration merely because it can be changed.
|
||||
|
||||
An unclassified behavioural literal is a defect.
|
||||
|
||||
`const` MUST NOT be used merely because a value currently has one default.
|
||||
Constants are reserved for actual invariants: enum discriminants, protocol
|
||||
versions, fixed compatibility tokens, and values whose alteration would change
|
||||
the program's semantics rather than configure an installation.
|
||||
|
||||
In Go, a constant is a compile-time value and does not represent mutable runtime
|
||||
storage. It generally has no address that can be observed or changed.
|
||||
Architecturally, a constant therefore asserts that the value cannot change for
|
||||
the lifetime of the application. Any value that may legitimately change while
|
||||
the application is running, between application instances, or between
|
||||
deployments is not a constant.
|
||||
|
||||
A runtime setting may have a default, but the default is not its only access
|
||||
path. The owner exposes a typed settings structure, validation, and a
|
||||
`DefaultSettings` constructor or equivalent. Private constants used to implement
|
||||
defaults do not turn those defaults into invariants and MUST NOT be consumed
|
||||
directly by runtime code.
|
||||
|
||||
Each runtime setting and policy value MUST declare:
|
||||
|
||||
- its owner;
|
||||
- type, units, validation constraints, and safe bounds;
|
||||
- default and derivation, if any;
|
||||
- whether it is startup-only, live-reloadable, or restart-required;
|
||||
- whether it may differ by installation, identity, repository, workflow,
|
||||
channel, or plugin instance;
|
||||
- whether it is secret, sensitive, or safe to report;
|
||||
- its current source, effective value, version, and last-known-good version;
|
||||
- the command and identity required to change it.
|
||||
|
||||
## Current configuration migration ledger
|
||||
|
||||
This ledger records the current meanings hidden inside `internal/config`. It is
|
||||
the source inventory for dissolving that package; rows are split where the
|
||||
existing structure combines different owners.
|
||||
|
||||
| Current values | Current location | Target owner and requirement |
|
||||
| ----------------------------------------------------------------------------------------------- | --------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------- |
|
||||
| `WorkDir`, `DBPath` | root `Config` | Workspace/storage infrastructure settings. `DBPath` is the prefix for independent task and conversation SQLite files. Defaults derive from the platform data directory. |
|
||||
| `SkillsDir`, `PluginDir` | root `Config` | Skill and plugin infrastructure settings, independently typed. |
|
||||
| `PollInterval` | root `Config` | Work-intake scheduling setting; not a daemon-wide constant. |
|
||||
| `Label`, `BotUser`, `BotEmail` | root `Config` | Identity and dispatch associations. `BotEmail` may be derived from the selected forge account but remains overrideable. |
|
||||
| `MaxRetries` | root `Config`, `Repo` | Retry policy owned by the operation being retried. The duplicate global/repository representation must disappear. |
|
||||
| `DiffCapLines` | root `Config` | Agent-change policy value. |
|
||||
| `MaxSteps`, `WallClock`, `GateMaxFailures` | `Budgets` | Workflow-execution policy, with units and zero/unlimited semantics made explicit. |
|
||||
| `Class`, `APIKeyEnv`, `BaseURL` | `Provider` | Provider instance settings. Secret lookup becomes a `SecretRef`, not an environment variable name leaking into the provider domain. |
|
||||
| `Mode`, `Command`, `Env` | `LegacyAgent` | Decode-only compatibility input for the removed executor selector. Delete after the config migration window; it has no runtime settings owner. |
|
||||
| `Type`, `Host`, `Token` / `TokenEnv` (older form) | `Forge` | Forge adapter settings. The older `TokenEnv` input is accepted only at the loader boundary. |
|
||||
| `Trigger`, `AckReaction`, label names | `Dispatch` | Work-intake and forge presentation policy. Label vocabulary is configurable per forge/identity association. |
|
||||
| `Engine` | `MemoryConfig` | Memory engine selection. `internal/domain/memory` is the only engine family; per-engine settings remain owned and validated by that engine. |
|
||||
| `Name`, `Transport`, `Command`, `Args`, `WorkDir`, `URL` | `MCPServer` | One typed MCP server instance specification. Transport-specific variants must reject fields belonging to other variants. |
|
||||
| `MaxResultChars` | `ToolPolicy` | Tool-execution policy values, not generic daemon configuration. |
|
||||
| `URL`, `TokenEnv` | `NATSConfig` | NATS transport settings with a secret reference replacing the environment-name field. |
|
||||
| `Image`, `MaxConcurrency`, `MaxUptime`, `VolumeTTL`, `PullPolicy`, `Network` | `ContainerConfig` | Mandatory managed-worker infrastructure settings and resource policy. The legacy `enabled` input is decode-only. |
|
||||
| model mappings, email, webhook, Telegram | `ChatConfig` | Separate channel instance settings plus channel-routing associations; there is no chat-wide settings owner. |
|
||||
| `AllowedUserIDs`, `Token` / `TokenEnv` (older form), update commands | Telegram config | Telegram adapter settings and access policy. `Token` is the preferred `secret.SecretRef`; `TokenEnv` remains a backwards-compatible fallback. |
|
||||
| listen/relay addresses | email config | Email adapter instance settings. |
|
||||
| webhook target | `Notify` | Notification adapter instance settings. |
|
||||
| web listen address | `Web` | Web transport settings. |
|
||||
| `listen` under `[services.state]` and `[services.gateway]` | `ServiceConnection` | The bind address of the process that owns the service. Read only by that process, and defaulted to the address its clients dial so the pair cannot drift. |
|
||||
| index directory and database path | `Indexing` | Index infrastructure settings, derived from storage settings unless explicitly overridden. |
|
||||
| forge, dispatch, models, providers, containers, memory, tools, indexing and repositories | `IdentityConfig` | Existing composite duplicates unrelated settings. Replace it with associations from an `IdentityID` to independently owned configured instances. |
|
||||
| owner, name, base, gate, protection, ecosystem, preflight, storage, retry and concurrency | `Repo` | Split across work intake, workspace, workflow execution, policy, gate, and scheduling as described in Repository settings. |
|
||||
| `TaskConfig`, `TaskForge` | worker snapshot | Replace with the minimum immutable, versioned WorkflowExecution input assembled by the application. It is not a second configuration model. |
|
||||
| `Extra` and arbitrary maps | root/provider config | Allowed only at an extension boundary whose owning plugin/provider supplies schema and validation. Core configuration never consumes an untyped catch-all. |
|
||||
|
||||
## Behavioural literals and incorrectly fixed values
|
||||
|
||||
The following current values affect useful behaviour but are not represented as
|
||||
owned typed settings or policy. They MUST be classified and migrated before the
|
||||
old configuration package is removed. The listed target is the architectural
|
||||
decision; exact setting names are implementation details.
|
||||
|
||||
| Capability | Values fixed in current code | Required classification |
|
||||
| ---------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
|
||||
| Chat agent | maximum steps `8` in `cmd/archied` | Workflow/chat execution policy. |
|
||||
| Context compression | enabled, threshold `0.5`, context size `128000`, protect first `3` and last `20`, compression marker, token estimate of four characters per token | Model/context runtime settings. The marker is presentation; the estimate is provider/model strategy, not a universal truth. |
|
||||
| Tool guardrails | escalation thresholds `3`, `5`, `10`, `2` | Tool-use policy with named meanings and bounded defaults. |
|
||||
| Tool output | per-result cap `50000` characters, no aggregate turn cap, preview `500` characters | Tool-execution resource and presentation settings. Per-result spill/truncation remains; turn continuation is not character- or token-gated. |
|
||||
| Pairing/access | code TTL `1h`, maximum pending `3`, rate window `10m`, failures `5`, lockout `1h`, maximum lockout `24h` | Access policy. Code length/alphabet and salt length require an explicit security-constraint decision; they are not automatically valid constants. |
|
||||
| NATS daemon consumer | stream `ARCHIE_TASKS`, consumer `archie-daemon`, deduplication `2m`, poll `2s`, deliveries `3`, acknowledgement wait `5m`, inactive threshold `24h`, subjects | NATS topology settings plus delivery policy. Subject grammar or protocol headers may be invariants only if declared as versioned wire contracts. |
|
||||
| NATS worker consumer | stream `ARCHIE_TASKS`, consumer `archie-agent`, deduplication `2m`, poll `5s`, acknowledgement wait `30m`, deliveries `3`, inactive threshold `24h`, queue group and retry delay `1s` | Worker transport settings and delivery/retry policy. Shared stream defaults must have one owner rather than two copies. |
|
||||
| Worker readiness | readiness timeout `20s`, retry delay `250ms` | Worker lifecycle and retry policy. |
|
||||
| Execution/RPC | agent execution `30m`, task-run RPC `60s`, worktree RPC `15m` | Per-operation timeout policy. |
|
||||
| Indexing | build timeout `10m`, metadata timeout `5s` | Index operation policy. |
|
||||
| Plugin/tool cleanup | plugin rollback `10s`, tool-provider cleanup `10s`, MCP-provider cleanup `10s` | Lifecycle shutdown/rollback policy owned by each engine, with a shared policy vocabulary where appropriate. |
|
||||
| Memory read path | per-scope record limit `20`, rendered `<memory>` block byte cap `8192` | Memory read policy owned by the engine family (`internal/domain/memory`). |
|
||||
| Built-in memory store | per-file size limit `100KiB`, query result limit `100` | Split into memory resource policy, input policy, and presentation settings. |
|
||||
| Memory safety scanner | compiled prompt-injection and sensitive-data patterns with fixed warn/block consequences | Versioned memory-domain policy definitions. Patterns and consequences must be inspectable and replaceable without editing scanner code. |
|
||||
| MCP stdio | initial backoff `500ms`, maximum backoff `30s`, unlimited default retries, send and shutdown `5s` | MCP transport retry, request, and lifecycle policy. Unlimited retries must be explicit rather than a zero-value accident. |
|
||||
| MCP SSE/HTTP | reconnect `1s` to `30s`, POST/request timeout `30s` | MCP transport settings and retry policy. |
|
||||
| Message framing | MCP frame `4MiB`, worker protocol frame `8MiB`, diagnostic `64KiB`, media/base64 `64MiB` | Resource/security policy unless a published wire protocol mandates the limit. Limits must be configurable only within safe bounds. |
|
||||
| Webhooks and web UI | webhook bind `0.0.0.0:8644`, webhook shutdown `5s`, web read-header `5s`, web shutdown `2s` | Transport instance and lifecycle settings. |
|
||||
| Telegram | typing refresh `4s`, draft interval `700ms`, update-action TTL `10m` | Telegram adapter presentation and lifecycle settings. |
|
||||
| Telegram limits | message length `4000` and callback/update prefixes | Record the upstream platform constraint and version it as an adapter compatibility limit; prefixes may remain wire constants when changing them would invalidate outstanding callbacks. |
|
||||
| Containers | stop and pull timeouts `10s` and `30s` | Container lifecycle policy. |
|
||||
| HTTP clients | feasibility notification timeout `10s`; other paths use `http.DefaultClient` | Adapter request policy. Every outbound client requires an explicit timeout profile. |
|
||||
| Workflow routing | labels `bug`, `feature`, `bootstrap`; workflows `tdd`, `feasibility`, `bootstrap`; fallback `implement` | Agent-system routing policy. Workflow identifiers are references, not compiled routing decisions. |
|
||||
| Filesystem/deployment | `.agents/skills`, `.archie/stages`, `.archie/gate.go`, `/data/worktree`, `/data/repo`, cache names/paths and prepared sentinel | Split into deployment settings, repository conventions, and genuine internal protocol markers. Paths an installation may relocate are settings. |
|
||||
| Packaged release data | `/usr/share/archie/CHANGELOG.md` | Packaging/deployment settings or paths derived from an installation prefix. |
|
||||
| Forge presentation | default label colour `bfd4f2` and state-label colours | Forge adapter presentation settings. |
|
||||
| Fallback system prompt | compiled fallback prompt | Agent-system default content, versioned and replaceable through its owning settings; safety constraints remain policy/code. |
|
||||
| Default paths and identities | config path, data paths, listen addresses, model roles and workflow names | Typed defaults belonging to their respective owners, never global constants consumed throughout the application. |
|
||||
|
||||
This inventory is intentionally broader than exported Go `const` declarations. A
|
||||
literal hidden in a constructor, timeout, switch, retry loop, path join, prompt,
|
||||
label map, or client setup restricts behaviour just as effectively as an
|
||||
incorrectly used constant.
|
||||
|
||||
## Constants that may remain
|
||||
|
||||
A value may remain constant only when its owner documents why runtime variation
|
||||
would be invalid. Typical valid cases are:
|
||||
|
||||
- domain enum values and state names;
|
||||
- a versioned wire-protocol version or framing token;
|
||||
- reserved internal headers and callback prefixes that peers must interpret
|
||||
identically;
|
||||
- compile-time mathematical relationships;
|
||||
- sentinel errors and internal type identifiers.
|
||||
|
||||
Names such as a stream, consumer, label, workflow, file, directory, network,
|
||||
model role, timeout, retry count, capacity, size limit, colour, prompt, command,
|
||||
or executable are not invariants merely because the current application has only
|
||||
one of them.
|
||||
|
||||
Architecture tests SHOULD reject exported behavioural constants outside approved
|
||||
invariant packages and SHOULD detect direct consumption of private default
|
||||
constants outside their owning `DefaultSettings` construction.
|
||||
|
||||
## Current mutation and reload ledger
|
||||
|
||||
The application currently changes behavioural values through unrelated paths:
|
||||
|
||||
| Current change seam | Current behaviour | Required target |
|
||||
| ------------------------------------ | -------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
|
||||
| Telegram `/restart` in `cmd/archied` | Re-reads the global document and directly replaces Telegram token and allowed-user IDs; failure retains old values. | Submit a Telegram-settings candidate through the universal change protocol. Validate the complete candidate, promote atomically, audit the acting identity, and retain last-known-good. |
|
||||
| Active model selection | `chatModelManager.SetActiveModel` changes a model reference. | A conversation/session command changing runtime state. Validate against configured model instances and audit it; do not rewrite configuration. |
|
||||
| Active provider selection | `chatModelManager.SetActiveProvider` changes provider selection. | A conversation/session command changing runtime state, with the same distinction from provider-instance configuration. |
|
||||
| Persona selection | `PersonaRegistry.SetActive` mutates an in-memory per-session choice. | Agent-system session state. Persistence and audit requirements are owned by that domain, not the configuration loader. |
|
||||
| File and environment overlays | Applied while loading `internal/config`; defaults are filled by mutation in `finalize`. | Configuration-infrastructure input processing that produces separately typed candidates. Defaults and derivations remain visible in provenance. |
|
||||
| SIGHUP config reload (2026-08) | Re-resolves the file config, re-applies the database layer over it, validates, then atomically republishes through `config.Holder`. A failed reload, whether the file or the control plane caused it, keeps the running config and records `last_error`/`last_error_at` in `/api/config`. | Candidate promotion with last-known-good retention: the running snapshot is untouched on failure. A bounded observation period and actor audit are not yet implemented. |
|
||||
| Control-plane resource command (2026-09) | `ControlPlaneService.Command` validates a whole resource document against its owning feature, then writes it with an audit record (actor, source, request ID, expected version) under optimistic concurrency. Hosted on the State Store's gRPC server; the Web UI and messaging channels are its only clients. See `docs/prds/runtime-control-plane.md`. | Met for validate-stage-promote, actor audit and versioned history. Per-field health observation and validate-before-switch on live apply are not yet implemented. |
|
||||
|
||||
Any further mutation seam discovered during migration MUST be added here before
|
||||
it is changed. Direct field assignment on a live settings object is prohibited.
|
||||
|
||||
## Universal change protocol
|
||||
|
||||
Changing configuration is an application command performed by an identity. It
|
||||
MUST:
|
||||
|
||||
1. resolve the target owner and current version;
|
||||
2. parse into that owner's typed settings;
|
||||
3. validate syntax, semantic constraints, policy, references, and safe bounds;
|
||||
4. stage a candidate without altering the active value;
|
||||
5. run owner-defined readiness and health checks;
|
||||
6. atomically promote the candidate and record actor, source, reason, diff,
|
||||
prior version, and new version;
|
||||
7. observe the affected capability for a bounded period;
|
||||
8. retain the new version on success, or automatically restore last-known-good
|
||||
on failure;
|
||||
9. report the rejected or rolled-back candidate without terminating unaffected
|
||||
capabilities.
|
||||
|
||||
Startup loading uses the same candidate rules. A bad user value therefore does
|
||||
not partially mutate the application or make a previously healthy capability
|
||||
unavailable.
|
||||
|
||||
Settings that cannot safely reload in-process are marked restart-required. The
|
||||
change may still be validated and versioned immediately, but promotion occurs
|
||||
through a controlled restart with the same health and rollback semantics.
|
||||
|
||||
## Implemented runtime reload and settings writes (2026-09)
|
||||
|
||||
Two mechanisms change behavioural values at runtime: SIGHUP re-reads the file
|
||||
config, and the control plane owns every database-backed setting. The dashboard
|
||||
runtime overlay that used to sit between them was deleted once the control plane
|
||||
covered its surface; `-config-overlay` names a file overlay and is unrelated.
|
||||
|
||||
### Published snapshot: `config.Holder`
|
||||
|
||||
The running configuration is a published snapshot held in `config.Holder`
|
||||
(`internal/config/holder.go`). Get returns a value under RLock; Set replaces the
|
||||
whole snapshot. A published Config is immutable: reload constructs a fresh one
|
||||
and calls Set. `config.Clone` deep-copies every reference-type field so a failed
|
||||
decode cannot mutate the published snapshot's shared maps. `Holder.Get` panics
|
||||
on a nil receiver — a forgotten `NewHolder` must fail loudly, not boot a daemon
|
||||
that silently runs on an empty config.
|
||||
|
||||
### The reloadable-field criterion
|
||||
|
||||
The diff-and-warn on reload asks whether a changed field takes effect without a
|
||||
restart. The criterion is: **a field is reloadable when every consumer re-reads
|
||||
it.** That question read as "what does the daemon re-read" while the daemon owned
|
||||
the only Holder; it stopped being sufficient when webui began sharing that
|
||||
Holder, because webui handlers re-read on every request. The allowlist lives in
|
||||
`cmd/archied/reload.go` and is deliberately a deny-by-default list: a field added
|
||||
to Config later defaults to requires-restart, forcing whoever adds it to decide
|
||||
deliberately. A reload that changes any non-allowlisted field logs
|
||||
"requires a restart" with the field names; a fully-applied reload logs Info.
|
||||
|
||||
### SIGHUP reload
|
||||
|
||||
SIGHUP re-resolves the file config, re-applies the database layer over it
|
||||
(`boot.runtimeConfig`, the same call boot makes), validates, and atomically
|
||||
republishes through the shared Holder. A failed reload keeps the running config
|
||||
and records `last_error`/`last_error_at` in `/api/config` so the stale state is
|
||||
visible where the operator is looking. The three poll tickers re-read
|
||||
`PollInterval` per iteration and reset on change, so a reloaded interval
|
||||
genuinely takes effect.
|
||||
|
||||
### Settings writes go through the control plane
|
||||
|
||||
Database-backed settings are read and written through
|
||||
`ControlPlaneService` on the State Store's gRPC server: catalog, query,
|
||||
command, watch. Each feature owns its resource's validation and commands;
|
||||
storage writes versions and audit records only. `docs/prds/runtime-control-plane.md`
|
||||
is the specification.
|
||||
|
||||
Two properties matter to anyone changing this area:
|
||||
|
||||
- **Bootstrap stays file-owned.** The daemon reads the file config first and
|
||||
layers database resources over it at boot (`boot.loadRuntimeConfig`). Values
|
||||
the daemon needs before it can reach the State Store — the database path,
|
||||
listen addresses, credentials — stay file-only by design.
|
||||
- **Reload re-reads them.** SIGHUP resolves the file document and then runs the
|
||||
same `boot.runtimeConfig` layering boot does, so a reload cannot revert a
|
||||
database-owned setting to its file value. A control plane that cannot answer
|
||||
fails the reload rather than publishing the file's values over the running
|
||||
ones. Workflow execution budgets arrive on a watch rather than in a resource
|
||||
query, so boot records the last published settings and the reload re-applies
|
||||
them from there.
|
||||
|
||||
## Completion criteria
|
||||
|
||||
The configuration rearchitecture is complete only when:
|
||||
|
||||
- `internal/config` no longer exists;
|
||||
- every behavioural value has one classification and owner;
|
||||
- every current field and hard-coded value in the ledgers has a recorded
|
||||
disposition;
|
||||
- domains and plugins receive only their typed settings;
|
||||
- all changes use semantic commands and the universal change protocol;
|
||||
- active, candidate, rejected, rolled-back, and last-known-good versions are
|
||||
queryable with secret-safe provenance;
|
||||
- generated documentation lists every external key, default, constraint,
|
||||
mutability class, owner, and deprecation;
|
||||
- architecture tests prevent a new central runtime configuration model, direct
|
||||
live-setting mutation, and incorrectly fixed behavioural values.
|
||||
|
||||
## Startup policy: missing credential degrades, invalid config is fatal
|
||||
|
||||
Decided 2026-07-30. Recovered 2026-08-09 from the pre-migration issue tracker.
|
||||
|
||||
A missing **credential** disables a capability. Only an **invalid config** stops
|
||||
the daemon. "Forge is a feature, not a requirement."
|
||||
|
||||
Before `518a1a0`, an unresolvable forge token did `return 1` in
|
||||
`cmd/archied/main.go`, so a chat-only user who never configured GitHub got no
|
||||
chat, no gateway, nothing — and under a systemd unit with `Restart=on-failure`
|
||||
and no start limit it crash-looped every five seconds with the error scrolling
|
||||
past unread. Forge construction now lives in `resolveForge`, shared by the
|
||||
primary forge and every configured identity, and degrades to `forge.NewNoop`
|
||||
with a warning. The identity path had the same defect and was worse: one
|
||||
identity's missing credential killed all the others.
|
||||
|
||||
Malformed configuration still fails fast in `configuration.Validate`, well
|
||||
before this point. That distinction is the whole design.
|
||||
|
||||
Apply the same reasoning to any future capability credential, LLM keys
|
||||
especially: start, report the capability as unavailable, let the operator see it.
|
||||
Guarded by `TestResolveForgeDegradesInsteadOfFailing`.
|
||||
|
||||
**Known consequence, tracked separately:** `worktree.Manager` still receives the
|
||||
empty token, so pushes fail late rather than at startup.
|
||||
|
||||
## Config generation belongs to `archied setup`, not `install.sh`
|
||||
|
||||
Decided 2026-07-30 ([#368](https://github.com/samcharles93/archie-core/issues/368)).
|
||||
Recovered 2026-08-09 from the pre-migration issue tracker.
|
||||
|
||||
`install.sh` must stop generating `config.toml`; `archied setup` owns it. The
|
||||
installer hand-rolling TOML has already drifted from the schema once: the
|
||||
generated-config branch hardcoded `key = ARCHIE_GITHUB_TOKEN` and
|
||||
`host = ${GITEA_URL}` regardless of the answers given, so choosing Gitea produced
|
||||
a config naming a token the installer never wrote (archied then exited 1), and
|
||||
choosing GitHub pointed `host` at `gitea.example.com`. `61a5b35` patched this
|
||||
with a `forge_block` shell helper shared by both config paths — that helper is a
|
||||
**workaround**, deleted by
|
||||
[#72](https://github.com/samcharles93/archie-core/issues/72). The durable fix is
|
||||
that the code writing the config is the code that reads it.
|
||||
|
||||
Why Go and not Python: the installer must run where nothing is installed yet, and
|
||||
`python3` with `tomllib` means 3.11+, which is not safe on LTS distros. `archied`
|
||||
is already being built two steps earlier.
|
||||
|
||||
**Key constraint for the port:** `BurntSushi/toml` does **not** survive a
|
||||
decode/encode round trip with comments intact, and `config.example.toml` carries
|
||||
documentation users are meant to hand-edit. Decide the write strategy
|
||||
([#412](https://github.com/samcharles93/archie-core/issues/412)) before writing
|
||||
any prompting code. Do not port a separate `config.yaml`/`auth.yaml` secret
|
||||
split — Archie already has `secret.SecretRef{engine,key}`, so setup writes the
|
||||
reference to TOML and the value to the secret engine.
|
||||
@@ -1,39 +0,0 @@
|
||||
# The dashboard's tools for an in-browser agent
|
||||
|
||||
The dashboard registers in-browser tools an agent can call through the page's model
|
||||
context. Four are read-only — `list_tasks`, `get_task`, `recent_events`,
|
||||
`daemon_health` — and three recover stuck work: `retry_task`, `stop_task`,
|
||||
`cancel_task`. Each wraps the same `ui/src/lib/api.ts` client the dashboard itself
|
||||
calls, so an agent and a person exercise one path rather than two.
|
||||
|
||||
The four judgement verbs are withheld for the reason `identity.md` gives: an agent
|
||||
that can approve can approve its own work.
|
||||
|
||||
## What a tool call can be attributed to
|
||||
|
||||
A page can invoke its own tools, so an agent's call and a page script's call reach
|
||||
the server identically — the difference does not exist on the wire, and no header
|
||||
recovers it. A tool call is therefore attributed to the signed-in identity the
|
||||
request presented, with its source recorded as a hint; it never records that an
|
||||
agent acted, and it never records that a human approved. An agent's action is
|
||||
attributable only on a surface where the agent presents its own credential.
|
||||
|
||||
## Confirmation is a signal, not a control
|
||||
|
||||
The three recovery tools require an explicit `confirm: true`, which makes a
|
||||
consequential call deliberate rather than incidental. It is not a security control:
|
||||
an agent can trivially satisfy it, and the browser cannot enforce
|
||||
`consequentialHint` at all — Chrome accepts it at registration and omits it from
|
||||
`getTools()`, so no client can see what the browser does not surface.
|
||||
|
||||
The boundary that holds is the session. These tools cannot exceed what the operator
|
||||
signed in at the provider is already permitted to do.
|
||||
|
||||
## Two ways the surface fails silently
|
||||
|
||||
- **A secure context is required.** On a plain-HTTP origin `document.modelContext` is
|
||||
absent even with the flag enabled, and nothing reports why. `mkcert` covers local
|
||||
development.
|
||||
- **The dashboard embeds `ui/dist` into its binary.** Rebuilding the distribution is
|
||||
not deploying it: a running process can serve a bundle without tools while the
|
||||
built one has them, or serve a bundle older than its own binary.
|
||||
@@ -1,71 +0,0 @@
|
||||
# Dependencies and Contracts
|
||||
|
||||
**Status:** Approved foundation
|
||||
**Date:** 2026-07-28
|
||||
**Tracking issue:** [#73](https://github.com/samcharles93/archie-core/issues/73)
|
||||
|
||||
## Dependency direction
|
||||
|
||||
```text
|
||||
domain and shared application contracts <- infrastructure implementations
|
||||
^
|
||||
|
|
||||
application composition
|
||||
```
|
||||
|
||||
The following rules are strict:
|
||||
|
||||
1. Domains MUST NOT import `internal/infrastructure`.
|
||||
2. A domain defines the smallest interfaces required to perform its work.
|
||||
3. Infrastructure implements those interfaces and translates external
|
||||
representations at the boundary.
|
||||
4. Only application composition chooses concrete implementations.
|
||||
5. A domain MUST NOT manipulate another domain's state or call its internal
|
||||
services.
|
||||
6. Cross-domain work uses an explicitly designed command, event, or approved
|
||||
shared contract.
|
||||
7. Implementation difficulty is not permission to violate a boundary.
|
||||
|
||||
Broker messages, database rows, SDK response types, and configuration DTOs MUST
|
||||
NOT leak into domain models.
|
||||
|
||||
## Commands and events
|
||||
|
||||
- An event records something that happened and is owned by its publishing
|
||||
domain.
|
||||
- A command requests an action and is owned by the domain expected to handle it.
|
||||
- Consumers do not redefine an event's meaning.
|
||||
- Senders obey the receiving domain's command contract.
|
||||
- There is no generic package containing unrelated application messages.
|
||||
|
||||
## Event bus
|
||||
|
||||
`internal/eventbus` is an approved shared application contract. It defines only
|
||||
the messaging behaviour Archie requires, including publication, subscription,
|
||||
delivery outcomes, and required lifecycle semantics.
|
||||
|
||||
It MUST remain broker-neutral. NATS subjects, JetStream configuration, consumer
|
||||
groups, acknowledgements, reconnection, and serialization belong under
|
||||
`internal/infrastructure/eventbus/nats` unless Archie explicitly requires a
|
||||
semantic guarantee in the shared contract.
|
||||
|
||||
Message schemas stay with their owning domains. The event bus transports
|
||||
messages; it does not own their meaning.
|
||||
|
||||
## Wire contracts and generation
|
||||
|
||||
Canonical worker and service wire contracts and their authoritative generation
|
||||
inputs are owned by the domain or capability that defines their meaning. They
|
||||
MUST NOT be centralized in `internal/infrastructure/spec` or another generic
|
||||
schema package.
|
||||
|
||||
Infrastructure owns:
|
||||
|
||||
- generic contract-generation machinery;
|
||||
- transport-specific adapters and generated implementations;
|
||||
- RPC, REST, NATS, and other external encoding and delivery concerns.
|
||||
|
||||
For example, agent-worker requests and results belong to task execution.
|
||||
Subprocess, NATS, or HTTP representations are infrastructure implementations of
|
||||
that contract. The same rule applies independently to forge, persistence,
|
||||
workspace, and other service contracts.
|
||||
Loaded 100 of 2192 files, more files were not shown because too many files have changed in this diff.
Show more
Reference in new issue
Block a user