prreview.MapLine classifies a file line as added, context or outside the diff. Nothing calls it; only AddedLines is used, so a comment on a line outside the diff is posted unclassified. Plan: confirm in the review posting stages whether the forge rejects out-of-diff inline comments today; if it does, classify with MapLine before posting and route LineOutside to the general review body. Table test over added, context and outside lines. Done when MapLine has a production caller.
Imported from beads archie-core-a6dp4 · GitHub #1721 · type bug · priority P2 · created 2026-10-14
prreview.MapLine classifies a file line as added, context or outside the diff. Nothing calls it; only AddedLines is used, so a comment on a line outside the diff is posted unclassified. Plan: confirm in the review posting stages whether the forge rejects out-of-diff inline comments today; if it does, classify with MapLine before posting and route LineOutside to the general review body. Table test over added, context and outside lines. Done when MapLine has a production caller.
---
_Imported from beads `archie-core-a6dp4` · GitHub #1721 · type bug · priority P2 · created 2026-10-14_
Already fixed by 0a1aa8b3c: MapLine is called from forgeReview (internal/domain/workflow/prreview_stages.go), findings outside the diff go into the review body, covered by prreview/diff_test.go and prreview_post_test.go.
Already fixed by 0a1aa8b3c: MapLine is called from forgeReview (internal/domain/workflow/prreview_stages.go), findings outside the diff go into the review body, covered by prreview/diff_test.go and prreview_post_test.go.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
prreview.MapLine classifies a file line as added, context or outside the diff. Nothing calls it; only AddedLines is used, so a comment on a line outside the diff is posted unclassified. Plan: confirm in the review posting stages whether the forge rejects out-of-diff inline comments today; if it does, classify with MapLine before posting and route LineOutside to the general review body. Table test over added, context and outside lines. Done when MapLine has a production caller.
Imported from beads
archie-core-a6dp4· GitHub #1721 · type bug · priority P2 · created 2026-10-14Already fixed by
0a1aa8b3c: MapLine is called from forgeReview (internal/domain/workflow/prreview_stages.go), findings outside the diff go into the review body, covered by prreview/diff_test.go and prreview_post_test.go.