Review comments are not checked against the diff before posting (MapLine unused) #1214

Closed
opened 2026-10-27 13:39:28 +00:00 by sam · 1 comment
Owner

prreview.MapLine classifies a file line as added, context or outside the diff. Nothing calls it; only AddedLines is used, so a comment on a line outside the diff is posted unclassified. Plan: confirm in the review posting stages whether the forge rejects out-of-diff inline comments today; if it does, classify with MapLine before posting and route LineOutside to the general review body. Table test over added, context and outside lines. Done when MapLine has a production caller.


Imported from beads archie-core-a6dp4 · GitHub #1721 · type bug · priority P2 · created 2026-10-14

prreview.MapLine classifies a file line as added, context or outside the diff. Nothing calls it; only AddedLines is used, so a comment on a line outside the diff is posted unclassified. Plan: confirm in the review posting stages whether the forge rejects out-of-diff inline comments today; if it does, classify with MapLine before posting and route LineOutside to the general review body. Table test over added, context and outside lines. Done when MapLine has a production caller. --- _Imported from beads `archie-core-a6dp4` · GitHub #1721 · type bug · priority P2 · created 2026-10-14_
sam added the mediumbug labels 2026-10-27 13:39:28 +00:00
sam self-assigned this 2026-10-27 13:39:28 +00:00
Author
Owner

Already fixed by 0a1aa8b3c: MapLine is called from forgeReview (internal/domain/workflow/prreview_stages.go), findings outside the diff go into the review body, covered by prreview/diff_test.go and prreview_post_test.go.

Already fixed by 0a1aa8b3c: MapLine is called from forgeReview (internal/domain/workflow/prreview_stages.go), findings outside the diff go into the review body, covered by prreview/diff_test.go and prreview_post_test.go.
sam closed this issue 2026-11-14 04:06:56 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1214