Ratify args evaluation-failure semantics once EvalArgs has a production consumer #998

Closed
opened 2026-10-27 13:38:37 +00:00 by sam · 0 comments
Owner

Raised by the t2db.26 work. J3 settled only the failure rule for the when predicate (error -> false, skip, log). There is no ratified rule for args: EvalArgs currently returns the error to its caller.

The asymmetry is defensible and is being documented as propagate-and-abort for now. when is a predicate, so "false" is a meaningful outcome and skipping is correct. args is data, so a value that cannot be evaluated has no meaningful substitute and aborting the action is correct. Silently skipping an action whose arguments failed to evaluate would be the same silent-failure class this codebase keeps removing.

WHY NOT SETTLED NOW

  • args has no production consumer yet: it is parsed, compiled and stored on the workflow position only. Any rule would be ratified against a caller that does not exist. t2db.26's own note is that the field is deliberately inert-but-valid so .26 and .27 could land without a second loader change.

WHAT TO DECIDE, WHEN THE CONSUMER EXISTS

  1. Propagate-and-abort (current, documented) versus mirroring J3 (skip + log). Whichever is chosen, state it once and test it at the call site.
  2. Whether a failed args evaluation aborts just the action, the whole playbook run, or only the dispatch.
  3. Whether it must be surfaced to the operator (log, task event, or both). J3 logs; a silent abort would be worse than either option.

Blocked on: the first side-effecting position reaching production (tracked as archie-core-t2db.31).

Close reason

Ratified as J6 in docs/prds/playbook-expression-syntax.md and locked at the call site, commit 3a0f5b8a. Propagate-and-abort stands over mirroring J3: a failed args evaluation aborts that playbook run (the action and every later action in it do not run), other playbooks matching the event still run, the task is unaffected, and the daemon log names the task, playbook and action (no task event). J3 stays predicate-specific. TestRunAbortsThePlaybookOnAnArgsEvaluationFailure fails if the rule is weakened to a skip (mutation-checked). The stale "unbuilt decisions" header line was dropped: J1, J2 and the Result schema declarations have shipped. task check clean on the committed tree.


Imported from beads archie-core-1h05 · GitHub #1110 · type decision · priority P2 · created 2026-09-21 · closed 2026-09-29

Raised by the t2db.26 work. J3 settled only the failure rule for the `when` predicate (error -> false, skip, log). There is no ratified rule for `args`: EvalArgs currently returns the error to its caller. The asymmetry is defensible and is being documented as propagate-and-abort for now. `when` is a predicate, so "false" is a meaningful outcome and skipping is correct. `args` is data, so a value that cannot be evaluated has no meaningful substitute and aborting the action is correct. Silently skipping an action whose arguments failed to evaluate would be the same silent-failure class this codebase keeps removing. WHY NOT SETTLED NOW - `args` has no production consumer yet: it is parsed, compiled and stored on the workflow position only. Any rule would be ratified against a caller that does not exist. t2db.26's own note is that the field is deliberately inert-but-valid so .26 and .27 could land without a second loader change. WHAT TO DECIDE, WHEN THE CONSUMER EXISTS 1. Propagate-and-abort (current, documented) versus mirroring J3 (skip + log). Whichever is chosen, state it once and test it at the call site. 2. Whether a failed args evaluation aborts just the action, the whole playbook run, or only the dispatch. 3. Whether it must be surfaced to the operator (log, task event, or both). J3 logs; a silent abort would be worse than either option. Blocked on: the first side-effecting position reaching production (tracked as archie-core-t2db.31). ### Close reason Ratified as J6 in docs/prds/playbook-expression-syntax.md and locked at the call site, commit 3a0f5b8a. Propagate-and-abort stands over mirroring J3: a failed args evaluation aborts that playbook run (the action and every later action in it do not run), other playbooks matching the event still run, the task is unaffected, and the daemon log names the task, playbook and action (no task event). J3 stays predicate-specific. TestRunAbortsThePlaybookOnAnArgsEvaluationFailure fails if the rule is weakened to a skip (mutation-checked). The stale "unbuilt decisions" header line was dropped: J1, J2 and the Result schema declarations have shipped. task check clean on the committed tree. --- _Imported from beads `archie-core-1h05` · GitHub #1110 · type decision · priority P2 · created 2026-09-21 · closed 2026-09-29_
sam added the mediumdecision labels 2026-10-27 13:38:37 +00:00
sam self-assigned this 2026-10-27 13:38:37 +00:00
sam closed this issue 2026-10-27 13:38:37 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#998