fix(staterpc): carry park class and remediation rounds across the wire

d6f61c2c added Task.ParkClass and Task.RemediationRounds to the domain
without the wire half; the parity guard went red. Add the two proto
fields (32/33) and map both directions in values.go.
This commit is contained in:
sam committed 2026-09-23 13:10:31 +10:00
1 parent 5d6fbd5c30
commit 53bdbd3309
3 files changed
+46 -5

No files matched your search

+32 -5
View File
@@ -1307,9 +1307,19 @@ type Task struct {
// comment cursor) because the two forge sequences are independent; one
// combined cursor would silently skip reviews once a larger comment ID
// landed (docs/prds/pr-review-remediation.md decision 2).
ReviewCursor int64 `protobuf:"varint,31,opt,name=review_cursor,json=reviewCursor,proto3" json:"review_cursor,omitempty"`
unknownFields protoimpl.UnknownFields
sizeCache protoimpl.SizeCache
ReviewCursor int64 `protobuf:"varint,31,opt,name=review_cursor,json=reviewCursor,proto3" json:"review_cursor,omitempty"`
// park_class is the producer-recorded answer to "what kind of
// intervention does this park need?" (taskstate.ParkClass:
// needs_human, transient, terminal). Store-side normalization makes
// empty and unknown values needs_human, so the class is advisory on
// the wire and authoritative only as recorded at the park site.
ParkClass string `protobuf:"bytes,32,opt,name=park_class,json=parkClass,proto3" json:"park_class,omitempty"`
// remediation_rounds counts review-triggered remediation rounds
// separately from retry_count, so an operator's manual retries no
// longer draw down the review-remediation budget (and vice versa).
RemediationRounds int32 `protobuf:"varint,33,opt,name=remediation_rounds,json=remediationRounds,proto3" json:"remediation_rounds,omitempty"`
unknownFields protoimpl.UnknownFields
sizeCache protoimpl.SizeCache
}
func (x *Task) Reset() {
@@ -1559,6 +1569,20 @@ func (x *Task) GetReviewCursor() int64 {
return 0
}
func (x *Task) GetParkClass() string {
if x != nil {
return x.ParkClass
}
return ""
}
func (x *Task) GetRemediationRounds() int32 {
if x != nil {
return x.RemediationRounds
}
return 0
}
// Event mirrors internal/events.Event. Data is carried as a JSON object
// string (matching the store's own on-disk representation) rather than
// google.protobuf.Struct, to stay a direct mirror of the existing column.
@@ -7994,7 +8018,7 @@ const file_state_v1_state_proto_rawDesc = "" +
"\asubject\x18\x03 \x01(\tR\asubject\x12-\n" +
"\x05audit\x18\x04 \x01(\v2\x17.state.v1.IdentityAuditR\x05audit\"M\n" +
"\x1bBindIdentitySubjectResponse\x12.\n" +
"\bidentity\x18\x01 \x01(\v2\x12.state.v1.IdentityR\bidentity\"\x8b\b\n" +
"\bidentity\x18\x01 \x01(\v2\x12.state.v1.IdentityR\bidentity\"\xd9\b\n" +
"\x04Task\x12\x0e\n" +
"\x02id\x18\x01 \x01(\x03R\x02id\x12\x14\n" +
"\x05owner\x18\x02 \x01(\tR\x05owner\x12\x12\n" +
@@ -8035,7 +8059,10 @@ const file_state_v1_state_proto_rawDesc = "" +
"\x1bworkflow_definition_version\x18\x1c \x01(\x03R\x19workflowDefinitionVersion\x12<\n" +
"\x1aworkflow_definition_digest\x18\x1d \x01(\tR\x18workflowDefinitionDigest\x128\n" +
"\x18workflow_definition_yaml\x18\x1e \x01(\tR\x16workflowDefinitionYaml\x12#\n" +
"\rreview_cursor\x18\x1f \x01(\x03R\freviewCursor\"\xf8\x02\n" +
"\rreview_cursor\x18\x1f \x01(\x03R\freviewCursor\x12\x1d\n" +
"\n" +
"park_class\x18 \x01(\tR\tparkClass\x12-\n" +
"\x12remediation_rounds\x18! \x01(\x05R\x11remediationRounds\"\xf8\x02\n" +
"\x05Event\x12\x0e\n" +
"\x02id\x18\x01 \x01(\x03R\x02id\x12*\n" +
"\x02at\x18\x02 \x01(\v2\x1a.google.protobuf.TimestampR\x02at\x12\x12\n" +
@@ -69,6 +69,8 @@ func taskProto(t *task.Task) *pb.Task { //nolint:dupl // mirror-image field-by-f
CreatedAt: timestamp(t.CreatedAt), UpdatedAt: timestamp(t.UpdatedAt),
ReviewPayload: t.ReviewPayload,
ReviewCursor: t.ReviewCursor,
ParkClass: t.ParkClass,
RemediationRounds: int32(t.RemediationRounds),
WorkflowDefinitionVersion: t.WorkflowDefinitionVersion,
WorkflowDefinitionDigest: t.WorkflowDefinitionDigest,
WorkflowDefinitionYaml: t.WorkflowDefinitionYAML,
@@ -90,6 +92,8 @@ func taskValue(t *pb.Task) *task.Task { //nolint:dupl // see taskProto above
CreatedAt: timeValue(t.CreatedAt), UpdatedAt: timeValue(t.UpdatedAt),
ReviewPayload: t.ReviewPayload,
ReviewCursor: t.ReviewCursor,
ParkClass: t.ParkClass,
RemediationRounds: int(t.RemediationRounds),
WorkflowDefinitionVersion: t.WorkflowDefinitionVersion,
WorkflowDefinitionDigest: t.WorkflowDefinitionDigest,
WorkflowDefinitionYAML: t.WorkflowDefinitionYaml,
+10
View File
@@ -254,6 +254,16 @@ message Task {
// combined cursor would silently skip reviews once a larger comment ID
// landed (docs/prds/pr-review-remediation.md decision 2).
int64 review_cursor = 31;
// park_class is the producer-recorded answer to "what kind of
// intervention does this park need?" (taskstate.ParkClass:
// needs_human, transient, terminal). Store-side normalization makes
// empty and unknown values needs_human, so the class is advisory on
// the wire and authoritative only as recorded at the park site.
string park_class = 32;
// remediation_rounds counts review-triggered remediation rounds
// separately from retry_count, so an operator's manual retries no
// longer draw down the review-remediation budget (and vice versa).
int32 remediation_rounds = 33;
}
// Event mirrors internal/events.Event. Data is carried as a JSON object