fix(workflow): carry max_retries into TaskConfig so the remediation round cap fires #1216

Closed
opened 2026-10-27 13:39:29 +00:00 by sam · 0 comments
Owner

Mechanism: the remediate round-cap stage runs inside the archie-agent container and reads config.TaskConfig.MaxRetries via TaskContext.Cfg, but config.TaskConfig never carried the global Config.MaxRetries (Config.ForTask and TaskConfig.ToConfig both omitted it). A default configuration therefore reached the stage as 0, so the cap never parked a remediation and a review-remediation loop could run forever. Fix shape: carry the value across the daemon/worker boundary in TaskConfig (ForTask + ToConfig) so the cap reads the configured value; a repo-level override still wins via Repo.EffectiveMaxRetries. Evidence shape: a configuration with a global max_retries and no per-repo override must park the task once RemediationRounds reaches the configured number.

Close reason

Fixed in f84b84fa


Imported from beads archie-core-ad3p · GitHub #1456 · type bug · priority P2 · created 2026-10-02 · closed 2026-10-02

Mechanism: the remediate round-cap stage runs inside the archie-agent container and reads config.TaskConfig.MaxRetries via TaskContext.Cfg, but config.TaskConfig never carried the global Config.MaxRetries (Config.ForTask and TaskConfig.ToConfig both omitted it). A default configuration therefore reached the stage as 0, so the cap never parked a remediation and a review-remediation loop could run forever. Fix shape: carry the value across the daemon/worker boundary in TaskConfig (ForTask + ToConfig) so the cap reads the configured value; a repo-level override still wins via Repo.EffectiveMaxRetries. Evidence shape: a configuration with a global max_retries and no per-repo override must park the task once RemediationRounds reaches the configured number. ### Close reason Fixed in f84b84fa --- _Imported from beads `archie-core-ad3p` · GitHub #1456 · type bug · priority P2 · created 2026-10-02 · closed 2026-10-02_
sam added the mediumbug labels 2026-10-27 13:39:29 +00:00
sam self-assigned this 2026-10-27 13:39:29 +00:00
sam closed this issue 2026-10-27 13:39:29 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1216