docs(prds): PR review agent

This commit is contained in:
sam committed 2026-09-26 02:05:52 +10:00
1 parent a98ca2c8e9
commit fca30d6445
4 files changed
+198 -2

No files matched your search

+2 -2
View File
@@ -388,7 +388,7 @@
"url": "/dev/prds/operator-pr-review/",
"title": "Operator-triggered PR review",
"section": "PRDs",
"body": "# Operator-triggered PR review\n\n**Status:** Draft\n**Beads issue:** `archie-core-h019.8`\n\nThis PRD reuses the adversarial-self-review contract\n(`docs/prds/adversarial-self-review.md`) and the `workflow.Reviewer` /\n`workflow.ReviewReport` types from `internal/domain/workflow`. It decides\nonly what is new: how an operator asks for a review of an _existing_ PR, and\nhow that PR's content reaches the reviewer.\n\n## Problem\n\nThe adversarial reviewer (`StageReview`) runs automatically before `StageOpenPR`\nand reviews the task's own worktree HEAD. There is no way to review a PR that\nalready exists: one archie opened, a human opened, or one whose findings the\noperator wants re-checked after a push.\n\n## Shape\n\nOne channel-neutral command — `review_pr` — accepts a repository and PR number\nand returns the structured `ReviewReport`. The Web UI chat and Telegram invoke\nthe same command; neither duplicates review behaviour. The reviewer model is\n`models.reviewer` (falling back to `models.builder`), already the rule the\nworkflow stage uses, so an operator configures it independently of\nplanner/builder.\n\n## Decisions\n\n1. **Forge read.** `GetPullRequest(owner, repo, number)` returns a\n forge-neutral `PullRequest{Number, Title, Body, HeadRef, BaseRef, HeadSHA,\nBaseSHA, State}`. Declared as a narrow `PullRequestReader` interface,\n implemented by GitHub and Gitea; the noop forge does not implement it, so\n the composition root type-asserts and refuses review with \"forge does not support PR\n review\". Adding to the fat `Forge` interface would churn every test fake for\n a capability the noop forge cannot honestly provide.\n\n2. **Materialisation.** `worktree.Manager.CheckoutPR(owner, repo, headRef,\nbaseRef)` clones the repository fully and checks out `origin/\u003cheadRef\u003e`.\n `Diff(dir, baseRef)` and `Snapshot(dir, destDir)` then work unchanged:\n `Diff` resolves `origin/\u003cbaseRef\u003e` via the existing `resolveBase`, and\n `Snapshot` strips `.git` exactly as the workflow stage does. The head must\n already be pushed to the same repository — archie's own PRs always are; a\n cross-repo or deleted head is refused with that reason, not half-reviewed.\n\n3. **Reviewer reuse.** `agentworker.NewOperatorReviewer(models, providers)`\n builds the same `subagentReviewer` the stage uses, from daemon-level config\n rather than a `taskrun.Request`. It drops only the `Repo.ReviewEnabled`\n gate (the operator asked explicitly) and the task-run scaffolding.\n\n4. **Command.** A gateway tool `review_pr` (toolset `tasks`) bound to the\n channel's identity at construction — the model never names an identity,\n matching `task_spawn`/`task_action`. The Gateway process serves it: it\n composes the worktree manager it needs to materialise the PR head, and the\n composition root supplies `ChatPRReviewer`, a narrow gateway interface\n whose adapter maps `workflow.ReviewReport` into a gateway-owned result\n shape (gateway states what it needs, the composition root adapts — the\n `ChatTaskActor` pattern).\n\n5. **Authorisation.** Identity-scoped repository allow-list, the\n `task_spawn` rule: a chat identity may only review a repo in its\n `TaskProfile.Repos`. `identity == nil` denotes an authenticated dashboard\n operator who may review any configured repository.\n\n6. **Determinism.** One review per (owner, repo, number) at a time: the\n Gateway holds an in-flight set; a concurrent request for the same PR returns\n \"review already in progress\" rather than launching a second reviewer and\n racing on the snapshot.\n\n## Files\n\n- `internal/forge/forge.go`, `github.go`, `gitea.go` — `PullRequest`,\n `PullRequestReader`, `GetPullRequest`.\n- `internal/worktree/worktree.go` — `CheckoutPR`.\n- `internal/app/agentworker/review.go` — `NewOperatorReviewer`.\n- `internal/gateway/review_tools.go` — `ChatPRReviewer`, result shape, `review_pr`.\n- `internal/gateway/turn.go`, `gateway.go` — tool wiring into the turn.\n- `internal/app/archied/pr_review.go` — the `ChatPRReviewer` adapter.\n- `internal/app/archied/{bootstrap.go,gateway.go,main.go}` — composition.\n\n## Not in scope\n\n- Surfacing findings on the PR body or the dashboard (h019.6).\n- Reviewer model per-invocation override: configuration via `models.reviewer`\n is the selection surface; a per-call override is a later knob.\n"
"body": "# Operator-triggered PR review\n\n**Status:** Draft\n**Beads issue:** `archie-core-h019.8`\n\n\u003e Superseded by `docs/prds/pr-review-agent.md`.\n\nThis PRD reuses the adversarial-self-review contract\n(`docs/prds/adversarial-self-review.md`) and the `workflow.Reviewer` /\n`workflow.ReviewReport` types from `internal/domain/workflow`. It decides\nonly what is new: how an operator asks for a review of an _existing_ PR, and\nhow that PR's content reaches the reviewer.\n\n## Problem\n\nThe adversarial reviewer (`StageReview`) runs automatically before `StageOpenPR`\nand reviews the task's own worktree HEAD. There is no way to review a PR that\nalready exists: one archie opened, a human opened, or one whose findings the\noperator wants re-checked after a push.\n\n## Shape\n\nOne channel-neutral command — `review_pr` — accepts a repository and PR number\nand returns the structured `ReviewReport`. The Web UI chat and Telegram invoke\nthe same command; neither duplicates review behaviour. The reviewer model is\n`models.reviewer` (falling back to `models.builder`), already the rule the\nworkflow stage uses, so an operator configures it independently of\nplanner/builder.\n\n## Decisions\n\n1. **Forge read.** `GetPullRequest(owner, repo, number)` returns a\n forge-neutral `PullRequest{Number, Title, Body, HeadRef, BaseRef, HeadSHA,\nBaseSHA, State}`. Declared as a narrow `PullRequestReader` interface,\n implemented by GitHub and Gitea; the noop forge does not implement it, so\n the composition root type-asserts and refuses review with \"forge does not support PR\n review\". Adding to the fat `Forge` interface would churn every test fake for\n a capability the noop forge cannot honestly provide.\n\n2. **Materialisation.** `worktree.Manager.CheckoutPR(owner, repo, headRef,\nbaseRef)` clones the repository fully and checks out `origin/\u003cheadRef\u003e`.\n `Diff(dir, baseRef)` and `Snapshot(dir, destDir)` then work unchanged:\n `Diff` resolves `origin/\u003cbaseRef\u003e` via the existing `resolveBase`, and\n `Snapshot` strips `.git` exactly as the workflow stage does. The head must\n already be pushed to the same repository — archie's own PRs always are; a\n cross-repo or deleted head is refused with that reason, not half-reviewed.\n\n3. **Reviewer reuse.** `agentworker.NewOperatorReviewer(models, providers)`\n builds the same `subagentReviewer` the stage uses, from daemon-level config\n rather than a `taskrun.Request`. It drops only the `Repo.ReviewEnabled`\n gate (the operator asked explicitly) and the task-run scaffolding.\n\n4. **Command.** A gateway tool `review_pr` (toolset `tasks`) bound to the\n channel's identity at construction — the model never names an identity,\n matching `task_spawn`/`task_action`. The Gateway process serves it: it\n composes the worktree manager it needs to materialise the PR head, and the\n composition root supplies `ChatPRReviewer`, a narrow gateway interface\n whose adapter maps `workflow.ReviewReport` into a gateway-owned result\n shape (gateway states what it needs, the composition root adapts — the\n `ChatTaskActor` pattern).\n\n5. **Authorisation.** Identity-scoped repository allow-list, the\n `task_spawn` rule: a chat identity may only review a repo in its\n `TaskProfile.Repos`. `identity == nil` denotes an authenticated dashboard\n operator who may review any configured repository.\n\n6. **Determinism.** One review per (owner, repo, number) at a time: the\n Gateway holds an in-flight set; a concurrent request for the same PR returns\n \"review already in progress\" rather than launching a second reviewer and\n racing on the snapshot.\n\n## Files\n\n- `internal/forge/forge.go`, `github.go`, `gitea.go` — `PullRequest`,\n `PullRequestReader`, `GetPullRequest`.\n- `internal/worktree/worktree.go` — `CheckoutPR`.\n- `internal/app/agentworker/review.go` — `NewOperatorReviewer`.\n- `internal/gateway/review_tools.go` — `ChatPRReviewer`, result shape, `review_pr`.\n- `internal/gateway/turn.go`, `gateway.go` — tool wiring into the turn.\n- `internal/app/archied/pr_review.go` — the `ChatPRReviewer` adapter.\n- `internal/app/archied/{bootstrap.go,gateway.go,main.go}` — composition.\n\n## Not in scope\n\n- Surfacing findings on the PR body or the dashboard (h019.6).\n- Reviewer model per-invocation override: configuration via `models.reviewer`\n is the selection surface; a per-call override is a later knob.\n"
},
{
"url": "/dev/prds/orgs-and-access/",
@@ -436,7 +436,7 @@
"url": "/dev/prds/review-calibration/",
"title": "Review calibration -- decision",
"section": "PRDs",
"body": "# Review calibration -- decision\n\n**Status:** Draft\n**Beads issue:** `archie-core-h019.5` (parent `archie-core-h019`)\n\nDecides the half of calibration `docs/prds/adversarial-self-review.md` left\nopen: \"the adversarial-confirmation mechanism that keeps a finding from\nsurfacing on a single reviewer's say-so.\"\n\n## The problem, precisely\n\nThe shipped contract (`internal/domain/workflow/review_findings.go`, h019.2)\nalready makes only a **confirmed** error-level finding block\n(`Blocking() == Verdict == confirmed \u0026\u0026 Level == error`), and a zero-finding\nreview is already distinguishable from one that never ran (`ReviewStatus`).\nWhat is missing is the other half: a reviewer can report _nothing_\nand say only \"I found nothing\" in free text. The operator cannot tell \"I\nchecked the five things that matter and they are clean\" from \"I did not look.\"\nThat is the failure the epic names -- a findings surface that consumes attention\nwithout earning trust.\n\n## Decisions\n\n### 1. \"Checked and cleared\" becomes structured, not prose\n\n`ReviewReport` gains `Checked []ReviewCheck`:\n\n```go\ntype ReviewCheck struct {\n Property string // what was verified clean, e.g. \"nil-safety of Foo callers\"\n Evidence string // how it was verified, e.g. \"read all 4 callers; each nil-checks\"\n}\n```\n\n`Evidence` is required, for the same reason `ReviewFinding.FailureScenario` is:\na check without evidence is an assertion, and the whole point is to separate a\nverified property from an unexamined one. A zero-finding review is credible\nonly when it lists what it checked.\n\n### 2. Report checks through a typed tool, like findings\n\nThe reviewer calls a new capture tool `record_checked` (mirroring\n`record_finding`) once per property it verified clean. The same environmental\nargument as findings applies: the reviewer cannot end its turn having silently\nskipped the checklist. `ReviewReport.Summary` stays as the human overview.\n\n### 3. Style nits are out of contract\n\nA finding must describe wrong behaviour or a crash. Style, formatting, naming,\nand preference nits are explicitly out of contract -- they are the padding that\ntrains the operator to skim. Stated in the reviewer prompt and in the\n`ReviewFinding` type's own documentation. Not machine-enforced: deciding \"is\nthis a style nit\" from free text is unreliable, and a wrong rejection is worse\nthan a tolerated one. The category enum already has no style bucket; the rule\ncloses the gap that would otherwise let one hide under `other`.\n\n### 4. Surfacing\n\nThe PR-body findings section lists the cleared properties alongside findings,\nso \"ran and found nothing\" arrives with its evidence. (Park reasons keep\nrendering only blocking findings -- what a human needs to act on, not the full\nchecklist.)\n\n## What this does not decide\n\n- Adding a second, independent reviewer pass. The verdict distinction plus the\n recorded checks is the confirmation mechanism; a second model pass is a\n separate, heavier decision and nothing in `h019.5` requires it.\n- How many findings can survive before `MaxSteps` is exhausted (a budget\n question, already satisfied by the per-stage budget).\n\n## Packages this touches\n\n- `internal/domain/workflow` -- `ReviewCheck`, `ReviewReport.Checked`, validation.\n- `internal/app/agentworker` -- `record_checked` tool, prompt rules.\n- `internal/domain/workflow/review.go` -- render cleared properties on the PR body.\n"
"body": "# Review calibration -- decision\n\n**Status:** Draft\n**Beads issue:** `archie-core-h019.5` (parent `archie-core-h019`)\n\n\u003e Superseded by `docs/prds/pr-review-agent.md`.\n\nDecides the half of calibration `docs/prds/adversarial-self-review.md` left\nopen: \"the adversarial-confirmation mechanism that keeps a finding from\nsurfacing on a single reviewer's say-so.\"\n\n## The problem, precisely\n\nThe shipped contract (`internal/domain/workflow/review_findings.go`, h019.2)\nalready makes only a **confirmed** error-level finding block\n(`Blocking() == Verdict == confirmed \u0026\u0026 Level == error`), and a zero-finding\nreview is already distinguishable from one that never ran (`ReviewStatus`).\nWhat is missing is the other half: a reviewer can report _nothing_\nand say only \"I found nothing\" in free text. The operator cannot tell \"I\nchecked the five things that matter and they are clean\" from \"I did not look.\"\nThat is the failure the epic names -- a findings surface that consumes attention\nwithout earning trust.\n\n## Decisions\n\n### 1. \"Checked and cleared\" becomes structured, not prose\n\n`ReviewReport` gains `Checked []ReviewCheck`:\n\n```go\ntype ReviewCheck struct {\n Property string // what was verified clean, e.g. \"nil-safety of Foo callers\"\n Evidence string // how it was verified, e.g. \"read all 4 callers; each nil-checks\"\n}\n```\n\n`Evidence` is required, for the same reason `ReviewFinding.FailureScenario` is:\na check without evidence is an assertion, and the whole point is to separate a\nverified property from an unexamined one. A zero-finding review is credible\nonly when it lists what it checked.\n\n### 2. Report checks through a typed tool, like findings\n\nThe reviewer calls a new capture tool `record_checked` (mirroring\n`record_finding`) once per property it verified clean. The same environmental\nargument as findings applies: the reviewer cannot end its turn having silently\nskipped the checklist. `ReviewReport.Summary` stays as the human overview.\n\n### 3. Style nits are out of contract\n\nA finding must describe wrong behaviour or a crash. Style, formatting, naming,\nand preference nits are explicitly out of contract -- they are the padding that\ntrains the operator to skim. Stated in the reviewer prompt and in the\n`ReviewFinding` type's own documentation. Not machine-enforced: deciding \"is\nthis a style nit\" from free text is unreliable, and a wrong rejection is worse\nthan a tolerated one. The category enum already has no style bucket; the rule\ncloses the gap that would otherwise let one hide under `other`.\n\n### 4. Surfacing\n\nThe PR-body findings section lists the cleared properties alongside findings,\nso \"ran and found nothing\" arrives with its evidence. (Park reasons keep\nrendering only blocking findings -- what a human needs to act on, not the full\nchecklist.)\n\n## What this does not decide\n\n- Adding a second, independent reviewer pass. The verdict distinction plus the\n recorded checks is the confirmation mechanism; a second model pass is a\n separate, heavier decision and nothing in `h019.5` requires it.\n- How many findings can survive before `MaxSteps` is exhausted (a budget\n question, already satisfied by the per-stage budget).\n\n## Packages this touches\n\n- `internal/domain/workflow` -- `ReviewCheck`, `ReviewReport.Checked`, validation.\n- `internal/app/agentworker` -- `record_checked` tool, prompt rules.\n- `internal/domain/workflow/review.go` -- render cleared properties on the PR body.\n"
},
{
"url": "/dev/prds/runtime-control-plane/",
+2
View File
@@ -3,6 +3,8 @@
**Status:** Draft
**Beads issue:** `archie-core-h019.8`
> Superseded by `docs/prds/pr-review-agent.md`.
This PRD reuses the adversarial-self-review contract
(`docs/prds/adversarial-self-review.md`) and the `workflow.Reviewer` /
`workflow.ReviewReport` types from `internal/domain/workflow`. It decides
+192
View File
@@ -0,0 +1,192 @@
# PR review agent
**Status:** Draft
**Authority:** `docs/architecture/agent-system.md`; supersedes the reviewer
executor and blocking rule in `docs/architecture/adversarial-review.md`, and
the designs in `docs/prds/operator-pr-review.md` and
`docs/prds/review-calibration.md`.
**Compounds with:** `docs/prds/execution-tree-state-machine.md` (every agent
call is a StepExecution), `docs/prds/external-agent-harness.md` (any agent
step may run on a harness), `docs/prds/inline-review.md` (posting),
`docs/prds/pr-review-remediation.md` (consumes the findings).
## Decision
Archie ships a pull request reviewer as its first end-to-end product. It
reviews any pull request on a watched repository, a PR an operator names, and
archie's own PRs before they open.
The reviewer is a fixed pipeline, not a single agent. The review strategy is
generated per PR: three lens agents propose review dimensions from the PR's
content, one reviewer definition runs once per dimension, and later agents
verify, challenge and combine the findings. Everything that can be computed
is code: diff parsing, clustering, blast radius, evidence extraction,
scoring, deduplication, line mapping and the review event.
The pipeline is **recall-first**. It posts every evidenced finding above the
confidence threshold, up to the comment cap. A precision gate exists as an
operator dial and is off by default.
Acceptance is measured, not asserted: see Verification.
## Pipeline
Each numbered phase is a stage of the `pr-review` workflow. Each agent call is
an `agent` StepExecution; fan-out phases record one child per call.
1. **Intake.** Code reads the PR metadata and diff statistics: type,
complexity, languages, areas touched, risk signals. Depth comes from lines
changed: under 100 is `quick` (at most 3 dimensions), under 500 is
`standard` (6), otherwise `deep` (12). An operator may set depth
explicitly.
2. **Anatomy.** Code parses the diff into files and hunks, clusters related
files, and computes the blast radius: unchanged files that import or are
imported by changed files. One agent writes the PR narrative, risk
surfaces, changes that do not fit the narrative, and gaps between the
description and the diff.
3. **Dimension selection.** Three lens agents run in parallel over the intake,
anatomy and diff, each able to read the repository:
- **behaviour:** where the old and new code diverge for any input; API
contracts, concurrency and state, security, error handling, data flow;
- **mechanics:** whether the code runs at the language and framework
level; types, signatures and every caller, decorators and middleware,
framework contracts, imports;
- **fit:** patterns, complexity, abstraction, test adequacy, documentation
that no longer matches, dependencies, migration completeness.
Each lens returns review dimensions: a name, a reviewer prompt written for
this PR, target files, context files and a priority. Code merges them,
drops duplicates and keeps the highest-priority dimensions up to the
depth's cap.
4. **Review.** One reviewer definition runs once per dimension, in parallel,
at most 8 at a time. Each reads its target and context files and may
follow references. Each finding carries file, line range, severity
(`critical`, `important`, `suggestion`, `nitpick`), title, body, an
optional suggested fix, quoted evidence, confidence and tags.
5. **Verification layer**, over the review findings:
- code extracts an evidence package per finding: the code at the cited
lines and snippets from its callers;
- an evidence verifier checks high-priority findings against their
packages;
- an adversary confirms or challenges each finding, looks for issues every
reviewer missed, and is more sceptical when intake scores the PR as
likely machine-written;
- a compound agent looks, within each cluster of confirmed findings, for
defects that only exist in combination.
6. **Coverage and consistency**, in parallel:
- a coverage gate checks every cluster and high-exposure blast-radius file
was reviewed, and runs gap reviewers for what was not, at most 2 rounds;
- consistency verification lists every cross-location obligation the
changed code creates (what must be true elsewhere for this line to be
correct), then verifies each by reading both ends. A broken obligation
becomes a finding.
7. **Synthesis**, code only:
- score = severity weight (1.0, 0.7, 0.3, 0.1) × confidence × multipliers:
compound 1.5, adversary-confirmed 1.3, adversary-challenged 0.5, likely
machine-written PR 1.2, blast radius over 10 files 1.2;
- drop findings under the severity's confidence floor: critical 0.2,
important 0.3, suggestion 0.4, nitpick 0.4;
- merge exact duplicates (file, overlapping lines, category) in code, and
near-duplicates through a small classification call that keeps both
when unsure;
- map lines to the diff's coordinates, sort by score, cap at 25 inline
comments.
8. **Merge gate.** One classification call per finding decides blocking or
advisory: blocking only for broken builds, security, data loss, contract
breaks and regressions. A failed call means advisory.
9. **Output.** One call per comment tightens its wording, keeping the
original on failure. The review is posted as one forge review with inline
comments. Any blocking finding requests changes; otherwise the review is a
comment. Archie never posts an approval.
## Precision dial
With `review.precision_gate = true`, a post-worthiness pass runs after phase 4
and before the verification layer. It keeps every concrete, evidenced defect
and drops nitpicks, style and unverifiable claims, keeping a finding when
unsure. It trades recall for precision and cuts verification cost by
filtering early.
## Operator approval
With `review.approve_before_post = true`, synthesis ends in
`waiting_human`. The operator chooses which findings to post, rejects the
review, or asks for a re-review with instructions. A re-review reruns phases
3 to 8 with the instructions added to the lens and reviewer prompts, at most
2 times. A review with no findings posts nothing and does not wait.
## Isolation
Every agent in the pipeline reads a `.git`-free snapshot of the PR head, with
read-only tools rooted at it, and never the implementer's worktree or
transcript. No pipeline agent holds a forge credential; posting is code.
## Budget
A run has a cost cap and a wall-clock cap, split into per-phase shares. A
phase whose share is spent is skipped and recorded on its StepExecution. The
posted review names every skipped phase, so an exhausted run never reads as a
clean one. A run whose review stage fails posts nothing and
fails.
## Triggers
- **Watched repositories:** a PR opened or updated on a repository with
`review.enabled` starts a run. An update cancels the in-flight run for the
same PR.
- **Operator:** a PR URL from the dashboard or chat starts a run on any
repository the identity can read.
- **Archie's own PRs:** the implement workflow runs the pipeline before
opening its PR. A blocking finding the adversary did not challenge parks
the task with the findings. A pipeline that fails parks the task. Advisory
findings are posted after the PR opens.
## Models
Each agent phase names a model role. Lens, reviewer, verification,
adversary, compound and consistency agents use the review role. Intake,
coverage, dedup, merge gate and polish calls use the classification role.
Either role may run on the built-in runner or a harness.
## Out of scope
- SARIF and standalone report formats. The findings are StepExecution outputs
and the forge review.
- Reviewing a diff without a forge PR.
- Self-consistency reruns.
## Plan
1. Deterministic core: diff parsing, clustering, blast radius, evidence
extraction, scoring, dedup, line mapping, review event. Table-driven tests.
2. The benchmark harness (Verification), run against the deterministic core
with fixture findings.
3. `pr-review` workflow: intake, anatomy, lenses, reviewers, synthesis,
output, with the execution tree recording each call.
4. Verification layer, coverage loop and consistency verification.
5. Merge gate, polish, budget shares and skipped-phase reporting.
6. Benchmark acceptance run.
7. Triggers: operator, watched repositories, archie's own PRs replacing the
single-reviewer stage.
8. Precision dial and operator approval.
## Verification
- **Benchmark acceptance.** On the 38 runnable PRs of the Martian
Code-Review-Bench offline set, one blind run per PR at `deep` with the
review and classification roles on GLM-5.2, and an independent judge
(`anthropic/claude-sonnet-4.6`) matching posted comments to golden
comments: golden micro-recall is at least 0.70. Golden-only precision is
reported alongside it. The run is reproducible from a script in the
repository.
- Scoring, thresholds, dedup and line mapping give identical output for
identical findings.
- A run whose phase share is exhausted posts a review naming the skipped
phase.
- An update to a PR under review cancels the running review and its child
steps.
- No pipeline agent can write to the snapshot, and none can reach a forge
credential.
- Archie's own PR with an unchallenged blocking finding is parked, not
opened.
- Archie never submits an approving review.
+2
View File
@@ -3,6 +3,8 @@
**Status:** Draft
**Beads issue:** `archie-core-h019.5` (parent `archie-core-h019`)
> Superseded by `docs/prds/pr-review-agent.md`.
Decides the half of calibration `docs/prds/adversarial-self-review.md` left
open: "the adversarial-confirmation mechanism that keeps a finding from
surfacing on a single reviewer's say-so."