Tasks and review: lifecycle and PR-review gaps #1433

Closed
opened 2026-10-27 13:40:22 +00:00 by sam · 1 comment
Owner

Gaps from the adversarial review of task lifecycle, operator actions, PR review and intake. Already tracked: archie-core-mkrq (reject closes issue #0), archie-core-4pv3 (log position for parked banner), archie-core-q832 (REQUEST_CHANGES and line-less findings), archie-core-ho86 (Telegram /approve shadowed).


Imported from beads archie-core-l8rc · GitHub #1263 · type epic · priority P1 · created 2026-10-05

Gaps from the adversarial review of task lifecycle, operator actions, PR review and intake. Already tracked: archie-core-mkrq (reject closes issue #0), archie-core-4pv3 (log position for parked banner), archie-core-q832 (REQUEST_CHANGES and line-less findings), archie-core-ho86 (Telegram /approve shadowed). --- _Imported from beads `archie-core-l8rc` · GitHub #1263 · type epic · priority P1 · created 2026-10-05_
sam added the highepic labels 2026-10-27 13:40:22 +00:00
sam self-assigned this 2026-10-27 13:40:22 +00:00
Author
Owner

Triaged: no code change is needed for this. This is a tracking epic, not a work item. The body of #1433 (beads archie-core-l8rc) names four gaps and states outright that all four are already tracked: archie-core-mkrq (reject closes issue #0), archie-core-4pv3 (log position for parked banner), archie-core-q832 (REQUEST_CHANGES and line-less findings), archie-core-ho86 (Telegram /approve shadowed). It describes no fifth gap, no acceptance criteria and no desired behaviour of its own, so there is nothing here to design or implement — the concrete defects live in their own issues.

Evidence from the tree that the named work is owned elsewhere and partly already landed:

  • PR review: internal/domain/workflow/prreview/scoring.go:408 ReviewEventFor returns REQUEST_CHANGES when any finding blocks, and internal/domain/workflow/prreview_stages.go:704 documents listing findings outside the diff — the q832-shaped behaviour. CHANGELOG 1.56.0: "Pull request reviews submit REQUEST_CHANGES on blocking findings, list findings outside the diff in the review body, and repost without inline comments when the forge refuses their placement."
  • Telegram /approve: internal/gateway/gateway.go:322 routes it, and CHANGELOG 1.53.0 (2026-10-11, six days after this epic was filed) records "/approve reaches Telegram; the router served it but nothing published it."
  • Reject/issue close: internal/domain/taskactions/service.go:638 closeRejectedIssue and closeRejectedPR exist with tests in service_test.go, so mkrq is a defect inside a live code path, not an unbuilt feature.

Routing this epic to implement/tdd/feasibility would duplicate whichever sub-issue it happened to pick, and would guess at scope the body does not state. The right handling is to close #1433 as a container and let mkrq, 4pv3, q832 and ho86 be worked individually — tdd for mkrq and 4pv3 (reproducible wrong behaviour: a rejected task closing issue #0, and the parked banner's log position), and confirm-and-close for q832 and ho86 if the shipped changelog entries cover them.

Triaged: no code change is needed for this. This is a tracking epic, not a work item. The body of #1433 (beads `archie-core-l8rc`) names four gaps and states outright that all four are already tracked: `archie-core-mkrq` (reject closes issue #0), `archie-core-4pv3` (log position for parked banner), `archie-core-q832` (REQUEST_CHANGES and line-less findings), `archie-core-ho86` (Telegram /approve shadowed). It describes no fifth gap, no acceptance criteria and no desired behaviour of its own, so there is nothing here to design or implement — the concrete defects live in their own issues. Evidence from the tree that the named work is owned elsewhere and partly already landed: - PR review: `internal/domain/workflow/prreview/scoring.go:408` `ReviewEventFor` returns REQUEST_CHANGES when any finding blocks, and `internal/domain/workflow/prreview_stages.go:704` documents listing findings outside the diff — the q832-shaped behaviour. CHANGELOG 1.56.0: "Pull request reviews submit REQUEST_CHANGES on blocking findings, list findings outside the diff in the review body, and repost without inline comments when the forge refuses their placement." - Telegram /approve: `internal/gateway/gateway.go:322` routes it, and CHANGELOG 1.53.0 (2026-10-11, six days after this epic was filed) records "`/approve` reaches Telegram; the router served it but nothing published it." - Reject/issue close: `internal/domain/taskactions/service.go:638` `closeRejectedIssue` and `closeRejectedPR` exist with tests in `service_test.go`, so mkrq is a defect inside a live code path, not an unbuilt feature. Routing this epic to implement/tdd/feasibility would duplicate whichever sub-issue it happened to pick, and would guess at scope the body does not state. The right handling is to close #1433 as a container and let mkrq, 4pv3, q832 and ho86 be worked individually — tdd for mkrq and 4pv3 (reproducible wrong behaviour: a rejected task closing issue #0, and the parked banner's log position), and confirm-and-close for q832 and ho86 if the shipped changelog entries cover them.
sam closed this issue 2026-11-08 12:21:02 +00:00
sam added the task label 2026-11-14 14:45:21 +00:00
sam added a new dependency 2026-11-14 14:45:21 +00:00
sam added a new dependency 2026-11-14 14:45:21 +00:00
sam added a new dependency 2026-11-14 14:45:21 +00:00
sam added a new dependency 2026-11-14 14:45:21 +00:00
sam added a new dependency 2026-11-14 14:45:21 +00:00
sam added a new dependency 2026-11-14 14:45:21 +00:00
sam added a new dependency 2026-11-14 14:45:21 +00:00
sam added a new dependency 2026-11-14 14:45:22 +00:00
sam added a new dependency 2026-11-14 14:45:22 +00:00
sam added a new dependency 2026-11-14 14:45:22 +00:00
sam added a new dependency 2026-11-14 14:45:22 +00:00
sam added a new dependency 2026-11-14 14:45:22 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1433