Tasks and review: lifecycle and PR-review gaps #1433
Notifications
Due Date
No due date set.
Depends on
#325 Record an approved review on the task
sam/archie
#327 Merge an archie PR from the task
sam/archie
#331 Rejecting a pr_open task closes its PR
sam/archie
#333 Paginate the task list on the server
sam/archie
#334 Page through task logs in the dashboard
sam/archie
#335 forge.intake = webhook stops polling
sam/archie
#337 Withdrawing an issue declines its work
sam/archie
Reference: sam/archie#1433
Reference in new issue
Block a user
Gaps from the adversarial review of task lifecycle, operator actions, PR review and intake. Already tracked: archie-core-mkrq (reject closes issue #0), archie-core-4pv3 (log position for parked banner), archie-core-q832 (REQUEST_CHANGES and line-less findings), archie-core-ho86 (Telegram /approve shadowed).
Imported from beads
archie-core-l8rc· GitHub #1263 · type epic · priority P1 · created 2026-10-05Triaged: no code change is needed for this. This is a tracking epic, not a work item. The body of #1433 (beads
archie-core-l8rc) names four gaps and states outright that all four are already tracked:archie-core-mkrq(reject closes issue #0),archie-core-4pv3(log position for parked banner),archie-core-q832(REQUEST_CHANGES and line-less findings),archie-core-ho86(Telegram /approve shadowed). It describes no fifth gap, no acceptance criteria and no desired behaviour of its own, so there is nothing here to design or implement — the concrete defects live in their own issues.Evidence from the tree that the named work is owned elsewhere and partly already landed:
internal/domain/workflow/prreview/scoring.go:408ReviewEventForreturns REQUEST_CHANGES when any finding blocks, andinternal/domain/workflow/prreview_stages.go:704documents listing findings outside the diff — the q832-shaped behaviour. CHANGELOG 1.56.0: "Pull request reviews submit REQUEST_CHANGES on blocking findings, list findings outside the diff in the review body, and repost without inline comments when the forge refuses their placement."internal/gateway/gateway.go:322routes it, and CHANGELOG 1.53.0 (2026-10-11, six days after this epic was filed) records "/approvereaches Telegram; the router served it but nothing published it."internal/domain/taskactions/service.go:638closeRejectedIssueandcloseRejectedPRexist with tests inservice_test.go, so mkrq is a defect inside a live code path, not an unbuilt feature.Routing this epic to implement/tdd/feasibility would duplicate whichever sub-issue it happened to pick, and would guess at scope the body does not state. The right handling is to close #1433 as a container and let mkrq, 4pv3, q832 and ho86 be worked individually — tdd for mkrq and 4pv3 (reproducible wrong behaviour: a rejected task closing issue #0, and the parked banner's log position), and confirm-and-close for q832 and ho86 if the shipped changelog entries cover them.