A second review during pending remediation is not lost #330

Closed
opened 2026-10-27 13:35:52 +00:00 by sam · 0 comments
Owner

Goal

A review with a distinct id that arrives while remediation is queued or running is remediated after the current run.

Evidence

internal/daemon/reactions.go:133-140 acks and drops on ErrStaleTransition; review_scan.go:29-49 moves the cursor past it.

Rules

Read CLAUDE.md. Do only what the Goal and Stop when need. File anything else you notice as a bead; do not fix it. Run task check once at the end; if it fails twice on the same problem, comment on this bead and stop.

Stop when

  • The review is left unacked or queued durably, never acked and dropped.
  • Test in the State Store seam: two reviews, both remediated in order.
    Then commit (Conventional Commits, scoped by package), bd close this bead and stop.

Close reason

Second review during pending remediation is queued in tasks.pending_reviews and promoted to the next queued run when the current one returns the task to pr_open; store-seam test covers two reviews remediated in order.


Imported from beads archie-core-l8rc.2 · GitHub #1394 · type bug · priority P0 · created 2026-10-05 · closed 2026-10-05

## Goal A review with a distinct id that arrives while remediation is queued or running is remediated after the current run. ## Evidence internal/daemon/reactions.go:133-140 acks and drops on ErrStaleTransition; review_scan.go:29-49 moves the cursor past it. ## Rules Read CLAUDE.md. Do only what the Goal and Stop when need. File anything else you notice as a bead; do not fix it. Run `task check` once at the end; if it fails twice on the same problem, comment on this bead and stop. ## Stop when - [ ] The review is left unacked or queued durably, never acked and dropped. - [ ] Test in the State Store seam: two reviews, both remediated in order. Then commit (Conventional Commits, scoped by package), `bd close` this bead and stop. ### Close reason Second review during pending remediation is queued in tasks.pending_reviews and promoted to the next queued run when the current one returns the task to pr_open; store-seam test covers two reviews remediated in order. --- _Imported from beads `archie-core-l8rc.2` · GitHub #1394 · type bug · priority P0 · created 2026-10-05 · closed 2026-10-05_
sam added the criticalbug labels 2026-10-27 13:35:52 +00:00
sam self-assigned this 2026-10-27 13:35:52 +00:00
sam closed this issue 2026-10-27 13:35:52 +00:00
sam added a new dependency 2026-11-14 14:45:21 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#330