Show review gate findings and post only the selected ones #323

Closed
opened 2026-10-27 13:35:51 +00:00 by sam · 0 comments
Owner

Goal

A waiting_human pr-review task shows its gate findings with checkboxes, and Approve sends the selected keys.

Evidence

Server supports finding keys (internal/domain/taskactions/service.go:285-299); ui/src/tasks/TaskRow.vue declares review_gate but nothing renders it; TaskRowActions.vue sends only instructions and retry_mode.

Rules

Read CLAUDE.md. Do only what the Goal and Stop when need. File anything else you notice as a bead; do not fix it. Run task check once at the end; if it fails twice on the same problem, comment on this bead and stop.

Stop when

  • Task detail renders the gate offer (findings, scores, head commit) with selection.
  • Approve posts {findings:[keys]}.
  • Playwright check with a stubbed gate.
    Then commit (Conventional Commits, scoped by package), bd close this bead and stop.

Close reason

Implemented in 225286e1. Waiting review task detail shows findings with checkboxes, scores, confidence, and head commit; Approve sends selected finding keys. Empty selection disables approval because the server interprets empty as all. Approvals from other surfaces open task detail; ordinary approval remains unchanged. Selection survives refresh of an unchanged offer and resets for a new offer. Playwright with stubbed gate at 1920x947 reproduced the old missing-key payload and passed the final selection, refresh, navigation, and ordinary approval checks. Dashboard rebuilt; task check passed.


Imported from beads archie-core-l8rc.1 · GitHub #1395 · type feature · priority P0 · created 2026-10-05 · closed 2026-10-05

## Goal A waiting_human pr-review task shows its gate findings with checkboxes, and Approve sends the selected keys. ## Evidence Server supports finding keys (internal/domain/taskactions/service.go:285-299); ui/src/tasks/TaskRow.vue declares review_gate but nothing renders it; TaskRowActions.vue sends only instructions and retry_mode. ## Rules Read CLAUDE.md. Do only what the Goal and Stop when need. File anything else you notice as a bead; do not fix it. Run `task check` once at the end; if it fails twice on the same problem, comment on this bead and stop. ## Stop when - [ ] Task detail renders the gate offer (findings, scores, head commit) with selection. - [ ] Approve posts {findings:[keys]}. - [ ] Playwright check with a stubbed gate. Then commit (Conventional Commits, scoped by package), `bd close` this bead and stop. ### Close reason Implemented in 225286e1. Waiting review task detail shows findings with checkboxes, scores, confidence, and head commit; Approve sends selected finding keys. Empty selection disables approval because the server interprets empty as all. Approvals from other surfaces open task detail; ordinary approval remains unchanged. Selection survives refresh of an unchanged offer and resets for a new offer. Playwright with stubbed gate at 1920x947 reproduced the old missing-key payload and passed the final selection, refresh, navigation, and ordinary approval checks. Dashboard rebuilt; task check passed. --- _Imported from beads `archie-core-l8rc.1` · GitHub #1395 · type feature · priority P0 · created 2026-10-05 · closed 2026-10-05_
sam added the criticalfeature labels 2026-10-27 13:35:51 +00:00
sam self-assigned this 2026-10-27 13:35:51 +00:00
sam closed this issue 2026-10-27 13:35:51 +00:00
sam added a new dependency 2026-11-14 14:45:22 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#323