Inline comments on a review queued behind a running remediation are dropped #329

Closed
opened 2026-10-27 13:35:52 +00:00 by sam · 0 comments
Owner

When a review arrives while a remediation owns the task, the review is now queued in tasks.pending_reviews and remediated after the current run. But its inline comments, published as separate reactions, are handled by reactionConsumer.handleComment, which only accepts a comment whose parent review is the task's ACTIVE unit (task.ReviewPayload). A comment on a review that is still waiting in pending_reviews matches no active unit and is dropped, so the queued review is remediated from its summary alone, without the inline comments it actually carries.

Evidence: internal/daemon/reactions.go handleComment, the 'comment's parent review is not the pending unit' drop.

Done when: a reaction comment whose parent review is queued (pending_reviews) is collected against that queued unit and addressed when its round runs.

Close reason

store merges a parent-review comment into the unclaimed unit, active or pending, under a row lock; test in the review-queue seam


Imported from beads archie-core-l8rc.15 · GitHub #1285 · type bug · priority P2 · created 2026-10-05 · closed 2026-10-05

When a review arrives while a remediation owns the task, the review is now queued in tasks.pending_reviews and remediated after the current run. But its inline comments, published as separate reactions, are handled by reactionConsumer.handleComment, which only accepts a comment whose parent review is the task's ACTIVE unit (task.ReviewPayload). A comment on a review that is still waiting in pending_reviews matches no active unit and is dropped, so the queued review is remediated from its summary alone, without the inline comments it actually carries. Evidence: internal/daemon/reactions.go handleComment, the 'comment's parent review is not the pending unit' drop. Done when: a reaction comment whose parent review is queued (pending_reviews) is collected against that queued unit and addressed when its round runs. ### Close reason store merges a parent-review comment into the unclaimed unit, active or pending, under a row lock; test in the review-queue seam --- _Imported from beads `archie-core-l8rc.15` · GitHub #1285 · type bug · priority P2 · created 2026-10-05 · closed 2026-10-05_
sam added the mediumbug labels 2026-10-27 13:35:52 +00:00
sam self-assigned this 2026-10-27 13:35:52 +00:00
sam closed this issue 2026-10-27 13:35:52 +00:00
sam added a new dependency 2026-11-14 14:45:21 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#329