Inline comments on a review queued behind a running remediation are dropped #329
Notifications
Due Date
No due date set.
Blocks
Reference: sam/archie#329
Reference in new issue
Block a user
When a review arrives while a remediation owns the task, the review is now queued in tasks.pending_reviews and remediated after the current run. But its inline comments, published as separate reactions, are handled by reactionConsumer.handleComment, which only accepts a comment whose parent review is the task's ACTIVE unit (task.ReviewPayload). A comment on a review that is still waiting in pending_reviews matches no active unit and is dropped, so the queued review is remediated from its summary alone, without the inline comments it actually carries.
Evidence: internal/daemon/reactions.go handleComment, the 'comment's parent review is not the pending unit' drop.
Done when: a reaction comment whose parent review is queued (pending_reviews) is collected against that queued unit and addressed when its round runs.
Close reason
store merges a parent-review comment into the unclaimed unit, active or pending, under a row lock; test in the review-queue seam
Imported from beads
archie-core-l8rc.15· GitHub #1285 · type bug · priority P2 · created 2026-10-05 · closed 2026-10-05