feat(workflow): route arbitrary forge labels to workflows via playbook YAML #433

Closed
opened 2026-10-27 13:36:18 +00:00 by sam · 0 comments
Owner

Second slice of docs/prds/eda-playbook-engine.md, complementing the kind->workflow layer (WorkflowRoutingFile): the label vocabulary itself becomes playbook data. A label outside the closed bug/feature/bootstrap kind set (e.g. security) dispatches to a registered workflow from an optional WorkflowLabelsFile, instead of falling through to triage.

  • LabelWorkflows + LoadLabelWorkflowsYAML/SetLabelWorkflows in internal/domain/workflow/routing.go, mirroring the kind layer's once-at-startup lifecycle. The closed Kind/NATS-subject set is untouched; the map only extends binding authority for labels the kind layer does not own.
  • Collision rule per design doc: a label owned by the kind set, an empty label, an empty workflow name, or a duplicate binding is a reported load failure (dropped, logged, error returned to the caller) -- the schema defines what is accepted; nothing is silently arbitrated by schema/version.
  • Route() precedence: explicit t.Workflow -> arbitrary-label binding -> kind binding -> triage -> implement -> default.
  • Config: WorkflowLabelsFile (workflow_labels_file), wired at boot alongside WorkflowRoutingFile; documented in config.example.toml.
  • PRD: records this slice's decisions (single-file shape, collision rule, precedence) so later slices stay anchored.

Committed as 93a5f3a and pushed to main.

Design

Follows the EDA playbook engine design doc (docs/prds/eda-playbook-engine.md). Open question 2 (config field shape) partially resolved: single file (workflow_labels_file) mirroring WorkflowRoutingFile and SkillsDir's single-path precedent; a directory remains open and larger. Data-flow/condition syntax (Q1), mid-run failure semantics and idempotency (design gaps 1-2) are explicitly out of this slice's scope per the PRD phasing -- they land with Module/Channel/Forge action kinds.

Acceptance criteria

  1. An issue labelled with an arbitrary label (not bug/feature/bootstrap) routes to the workflow bound in workflow_labels_file.
  2. No workflow_labels_file configured: kind-only routing unchanged (backward compatible).
  3. Colliding/empty/kind-owned labels in the file produce a reported load error, not silent arbitration.
  4. Route() precedence: explicit t.Workflow > arbitrary-label binding > kind binding > triage > implement > default.
  5. task check is green; tests cover dispatch, collision, empties, nil-restore, and precedence.

Close reason

Verified landed: workflow.LoadLabelWorkflowsYAML + cfg.WorkflowLabelsFile, called from boot.loadWorkflowRouting.


Imported from beads archie-core-t2db.10 · GitHub #701 · type task · priority P2 · created 2026-09-02 · closed 2026-09-11

Second slice of docs/prds/eda-playbook-engine.md, complementing the kind->workflow layer (WorkflowRoutingFile): the label vocabulary itself becomes playbook data. A label outside the closed bug/feature/bootstrap kind set (e.g. security) dispatches to a registered workflow from an optional WorkflowLabelsFile, instead of falling through to triage. - LabelWorkflows + LoadLabelWorkflowsYAML/SetLabelWorkflows in internal/domain/workflow/routing.go, mirroring the kind layer's once-at-startup lifecycle. The closed Kind/NATS-subject set is untouched; the map only extends binding authority for labels the kind layer does not own. - Collision rule per design doc: a label owned by the kind set, an empty label, an empty workflow name, or a duplicate binding is a reported load failure (dropped, logged, error returned to the caller) -- the schema defines what is accepted; nothing is silently arbitrated by schema/version. - Route() precedence: explicit t.Workflow -> arbitrary-label binding -> kind binding -> triage -> implement -> default. - Config: WorkflowLabelsFile (workflow_labels_file), wired at boot alongside WorkflowRoutingFile; documented in config.example.toml. - PRD: records this slice's decisions (single-file shape, collision rule, precedence) so later slices stay anchored. Committed as 93a5f3a and pushed to main. ### Design Follows the EDA playbook engine design doc (docs/prds/eda-playbook-engine.md). Open question 2 (config field shape) partially resolved: single file (workflow_labels_file) mirroring WorkflowRoutingFile and SkillsDir's single-path precedent; a directory remains open and larger. Data-flow/condition syntax (Q1), mid-run failure semantics and idempotency (design gaps 1-2) are explicitly out of this slice's scope per the PRD phasing -- they land with Module/Channel/Forge action kinds. ### Acceptance criteria 1. An issue labelled with an arbitrary label (not bug/feature/bootstrap) routes to the workflow bound in workflow_labels_file. 2. No workflow_labels_file configured: kind-only routing unchanged (backward compatible). 3. Colliding/empty/kind-owned labels in the file produce a reported load error, not silent arbitration. 4. Route() precedence: explicit t.Workflow > arbitrary-label binding > kind binding > triage > implement > default. 5. task check is green; tests cover dispatch, collision, empties, nil-restore, and precedence. ### Close reason Verified landed: workflow.LoadLabelWorkflowsYAML + cfg.WorkflowLabelsFile, called from boot.loadWorkflowRouting. --- _Imported from beads `archie-core-t2db.10` · GitHub #701 · type task · priority P2 · created 2026-09-02 · closed 2026-09-11_
sam added the mediumtask labels 2026-10-27 13:36:18 +00:00
sam self-assigned this 2026-10-27 13:36:18 +00:00
sam closed this issue 2026-10-27 13:36:18 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#433