Migrate Kit resolution and assembly to sandbox-kit-spec m.8 #226

Closed
opened 2026-10-27 13:35:28 +00:00 by sam · 0 comments
Owner

The upgraded sandbox-kit-spec v3.0.0-m.8 removes fetch.Client.Assemble. internal/infrastructure/kitrun/launcher.go read still calls it and consumes MergeResult and Env; kit.FromMerge relies on the previous composition result. Investigate Resolve/Resolved versus package-level fetch.Assemble and choose the smallest migration that preserves composed image configuration, per-Kit exports, context sources, and admission before launch. Do not add new capability support as part of this migration.

Acceptance criteria

Build against m.8; workload and Kit-set launches preserve resolved environment, context sources, and image configuration; invalid required capabilities refuse before container startup; task check passes.

Notes

Stopgap in place: commit 7438c321 pinned docker/sandbox-kit-spec back to v3.0.0-m.6 because main did not compile (fetch.Client.Assemble removed; CredentialCapability.Phase became spec.Phases). The migration must unpin and adapt internal/infrastructure/egress/credentials.go and oauth.go too: Phase is a list, and a credential naming both install and runtime must apply in both phases (slices.Contains, not equality).
Implemented in be31522e. Restored sandbox-kit-spec v3.0.0-m.8. kitrun.read uses Fetch.Resolve with image-default environment and Archie capability selection; FromResolved retains argument exports, selected per-Kit guidance and selection records. Published Kit sets remain one precomposed digest-pinned Docker image, as config.AgentProfile specifies. TestKitCapabilitySelection exercises the real registry/Resolve path and launch derivation. Final task check passed; focused Docker and race tests passed.

Close reason

Migration landed in be31522e (in HEAD): go.mod pins sandbox-kit-spec v3.0.0-m.8, kitrun.read uses Fetch.Resolve + kit.FromResolved, Phase lists use slices.Contains, and go build ./... succeeds.


Imported from beads archie-core-egkf.16 · GitHub #1517 · type task · priority P1 · created 2026-10-09 · closed 2026-10-27

The upgraded sandbox-kit-spec v3.0.0-m.8 removes fetch.Client.Assemble. internal/infrastructure/kitrun/launcher.go read still calls it and consumes MergeResult and Env; kit.FromMerge relies on the previous composition result. Investigate Resolve/Resolved versus package-level fetch.Assemble and choose the smallest migration that preserves composed image configuration, per-Kit exports, context sources, and admission before launch. Do not add new capability support as part of this migration. ### Acceptance criteria Build against m.8; workload and Kit-set launches preserve resolved environment, context sources, and image configuration; invalid required capabilities refuse before container startup; task check passes. ### Notes Stopgap in place: commit 7438c321 pinned docker/sandbox-kit-spec back to v3.0.0-m.6 because main did not compile (fetch.Client.Assemble removed; CredentialCapability.Phase became spec.Phases). The migration must unpin and adapt internal/infrastructure/egress/credentials.go and oauth.go too: Phase is a list, and a credential naming both install and runtime must apply in both phases (slices.Contains, not equality). Implemented in be31522e. Restored sandbox-kit-spec v3.0.0-m.8. kitrun.read uses Fetch.Resolve with image-default environment and Archie capability selection; FromResolved retains argument exports, selected per-Kit guidance and selection records. Published Kit sets remain one precomposed digest-pinned Docker image, as config.AgentProfile specifies. TestKitCapabilitySelection exercises the real registry/Resolve path and launch derivation. Final task check passed; focused Docker and race tests passed. ### Close reason Migration landed in be31522e (in HEAD): go.mod pins sandbox-kit-spec v3.0.0-m.8, kitrun.read uses Fetch.Resolve + kit.FromResolved, Phase lists use slices.Contains, and go build ./... succeeds. --- _Imported from beads `archie-core-egkf.16` · GitHub #1517 · type task · priority P1 · created 2026-10-09 · closed 2026-10-27_
sam added the hightask labels 2026-10-27 13:35:28 +00:00
sam self-assigned this 2026-10-27 13:35:28 +00:00
sam closed this issue 2026-10-27 13:35:28 +00:00
sam added a new dependency 2026-10-27 13:41:47 +00:00
sam added a new dependency 2026-10-27 13:41:47 +00:00
sam added a new dependency 2026-10-27 13:41:47 +00:00
sam added a new dependency 2026-10-27 13:41:47 +00:00
sam added a new dependency 2026-11-14 14:45:12 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#226