Align Kit skill discovery with bundled and optional shared skills #231

Closed
opened 2026-10-27 13:35:29 +00:00 by sam · 0 comments
Owner

sandbox-kit-spec m.7 changes agent-skills@1 to discover bundled agent-skill@1 content with optional host sharing; mode bounds host-store access. kitrun.skillsBinds currently mounts the shared host store directly onto every requested discovery path when configured, which may obscure bundled skills. Audit capability admission and assembled skill staging; honor the revised contract without adding writable host access or marking unsupported bundled skills as provided.

Acceptance criteria

Bundled-only skills remain visible when no host store exists; configured shared skills do not mask bundled content; disabled or missing sharing does not prevent supported startup; unsupported required behavior is refused explicitly; retain read-only host confinement and pass task check.

Notes

Implemented in be31522e. Selected image-bundled skills are copied into discovery destinations before startup; shared host directories are mounted per skill, read-only, instead of obscuring the whole discovery directory. Shared names override existing image content; unavailable or disabled sharing does not block startup; top-level host symlinks are not mounted. Shared SELinux labels permit multiple containers to read the store. TestSharedSkillsDoNotMaskImageDiscovery covers sharing, missing/disabled stores and symlinks. Docker TestKitRuntimeDiscovery checks bundled plus shared content remains visible and the host mount is read-only. Final task check and focused race tests passed.

Close reason

HEAD already mounts shared skills per-skill read-only (kitrun/launcher.go:498-516) with bundled staging in kit/bundledSkills and TestSharedSkillsDoNotMaskImageDiscovery passing, so the bead's work landed in be31522e.


Imported from beads archie-core-egkf.20 · GitHub #1547 · type task · priority P2 · created 2026-10-09 · closed 2026-10-27

sandbox-kit-spec m.7 changes agent-skills@1 to discover bundled agent-skill@1 content with optional host sharing; mode bounds host-store access. kitrun.skillsBinds currently mounts the shared host store directly onto every requested discovery path when configured, which may obscure bundled skills. Audit capability admission and assembled skill staging; honor the revised contract without adding writable host access or marking unsupported bundled skills as provided. ### Acceptance criteria Bundled-only skills remain visible when no host store exists; configured shared skills do not mask bundled content; disabled or missing sharing does not prevent supported startup; unsupported required behavior is refused explicitly; retain read-only host confinement and pass task check. ### Notes Implemented in be31522e. Selected image-bundled skills are copied into discovery destinations before startup; shared host directories are mounted per skill, read-only, instead of obscuring the whole discovery directory. Shared names override existing image content; unavailable or disabled sharing does not block startup; top-level host symlinks are not mounted. Shared SELinux labels permit multiple containers to read the store. TestSharedSkillsDoNotMaskImageDiscovery covers sharing, missing/disabled stores and symlinks. Docker TestKitRuntimeDiscovery checks bundled plus shared content remains visible and the host mount is read-only. Final task check and focused race tests passed. ### Close reason HEAD already mounts shared skills per-skill read-only (kitrun/launcher.go:498-516) with bundled staging in kit/bundledSkills and TestSharedSkillsDoNotMaskImageDiscovery passing, so the bead's work landed in be31522e. --- _Imported from beads `archie-core-egkf.20` · GitHub #1547 · type task · priority P2 · created 2026-10-09 · closed 2026-10-27_
sam added the mediumtask labels 2026-10-27 13:35:29 +00:00
sam self-assigned this 2026-10-27 13:35:29 +00:00
sam closed this issue 2026-10-27 13:35:29 +00:00
sam added a new dependency 2026-10-27 13:41:47 +00:00
sam added a new dependency 2026-11-14 14:45:12 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#231