Honor Kit agent-context discovery directories #232

Closed
opened 2026-10-27 13:35:29 +00:00 by sam · 0 comments
Owner

sandbox-kit-spec m.8 adds agent-context@1.directory and composition precedence for discovery profiles. kit.contextFiles always stages the discovery file beside the workspace and reduces Filename to a basename, so an admitted declaration with directory may be ignored. Update discovery location and composition behavior using the upstream resolved profile; preserve unrelated instructions outside runtime-managed sections and path confinement.

Acceptance criteria

Legacy declarations keep their discovery location; explicit absolute directories are honored with correct composed precedence; conflicts refuse launch; existing non-managed instructions are preserved; unsafe paths cannot escape approved container staging; task check passes.

Notes

Implemented in be31522e. Context staging honors the resolved absolute discovery directory, with the legacy workspace-sibling default retained. The runtime replaces only an ARCHIE-managed section, preserving existing image instructions, and refuses symlinked targets/parents. Upstream Resolve owns profile composition and conflict validation. TestKitContextDiscovery reproduces and verifies explicit-directory handling; Docker TestKitRuntimeDiscovery verifies managed replacement, preservation and symlink refusal. Final task check and focused race tests passed.

Close reason

Implemented and in tree since be31522e: kit contextFiles honors the resolved absolute agent-context directory with legacy workspace-sibling default (internal/infrastructure/kit/launch.go:231-259), runtime replaces only an ARCHIE-managed section while refusing symlinked targets/parents (internal/container/kit.go:160-188), and TestKitContextDiscovery + Docker TestKitRuntimeDiscovery cover it.


Imported from beads archie-core-egkf.21 · GitHub #1546 · type task · priority P2 · created 2026-10-09 · closed 2026-10-27

sandbox-kit-spec m.8 adds agent-context@1.directory and composition precedence for discovery profiles. kit.contextFiles always stages the discovery file beside the workspace and reduces Filename to a basename, so an admitted declaration with directory may be ignored. Update discovery location and composition behavior using the upstream resolved profile; preserve unrelated instructions outside runtime-managed sections and path confinement. ### Acceptance criteria Legacy declarations keep their discovery location; explicit absolute directories are honored with correct composed precedence; conflicts refuse launch; existing non-managed instructions are preserved; unsafe paths cannot escape approved container staging; task check passes. ### Notes Implemented in be31522e. Context staging honors the resolved absolute discovery directory, with the legacy workspace-sibling default retained. The runtime replaces only an ARCHIE-managed section, preserving existing image instructions, and refuses symlinked targets/parents. Upstream Resolve owns profile composition and conflict validation. TestKitContextDiscovery reproduces and verifies explicit-directory handling; Docker TestKitRuntimeDiscovery verifies managed replacement, preservation and symlink refusal. Final task check and focused race tests passed. ### Close reason Implemented and in tree since be31522e: kit contextFiles honors the resolved absolute agent-context directory with legacy workspace-sibling default (internal/infrastructure/kit/launch.go:231-259), runtime replaces only an ARCHIE-managed section while refusing symlinked targets/parents (internal/container/kit.go:160-188), and TestKitContextDiscovery + Docker TestKitRuntimeDiscovery cover it. --- _Imported from beads `archie-core-egkf.21` · GitHub #1546 · type task · priority P2 · created 2026-10-09 · closed 2026-10-27_
sam added the mediumtask labels 2026-10-27 13:35:29 +00:00
sam self-assigned this 2026-10-27 13:35:29 +00:00
sam closed this issue 2026-10-27 13:35:29 +00:00
sam added a new dependency 2026-10-27 13:41:47 +00:00
sam added a new dependency 2026-11-14 14:45:12 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#232