test(e2e): chat dock browser checks (#1886) #1901

Merged
sam merged 2 commits from test/1886-chat-dock-checks into main 2026-11-12 12:14:41 +00:00
Owner

Adds seven chat-dock-* browser checks for the merged chat dock work (#1886).

  • chat-dock-pin: drag to an edge pins and the page reflows, double-click unpins, hide and reload keep the choice.
  • chat-dock-drag-cancel: a cancelled drag leaves the dock unmoved and unpinned, and the next drag works.
  • chat-dock-layout: saved side and width restored, out-of-range widths clamped, unreadable JSON falls back to a usable dock, phone width never rewrites the saved layout.
  • chat-dock-resize: divider arrow keys on both sides, 16px steps, 320 to 720 limits, saved.
  • chat-dock-drafts: per-conversation text and task tags across New chat, switching and hide/reopen.
  • chat-dock-picker: # picker arrows (with wrap), Enter, Escape, and IME Enter with the picker open.
  • chat-dock-phone: 390px with a stored desktop pin; the dock stays on screen and adds no sideways scroll.

IME Enter in the plain composer was already covered by chat-composer. Checks for context tags and unread counts are a follow-up.

Verified: all seven pass with chat-composer on a stack built from this branch, and task check passes. Breaking the drag-cancel and key-resize code in the dock makes those checks fail.

Not covered, filed as #1900: a stored layout with an unknown side or non-numeric width overlaps the page.

Known unrelated failure: phone-overflow fails at 390px on main (topbar breadcrumb is 2px wide). chat-dock-phone measures the dock against the page without it, so it is unaffected.

Adds seven `chat-dock-*` browser checks for the merged chat dock work (#1886). - `chat-dock-pin`: drag to an edge pins and the page reflows, double-click unpins, hide and reload keep the choice. - `chat-dock-drag-cancel`: a cancelled drag leaves the dock unmoved and unpinned, and the next drag works. - `chat-dock-layout`: saved side and width restored, out-of-range widths clamped, unreadable JSON falls back to a usable dock, phone width never rewrites the saved layout. - `chat-dock-resize`: divider arrow keys on both sides, 16px steps, 320 to 720 limits, saved. - `chat-dock-drafts`: per-conversation text and task tags across New chat, switching and hide/reopen. - `chat-dock-picker`: # picker arrows (with wrap), Enter, Escape, and IME Enter with the picker open. - `chat-dock-phone`: 390px with a stored desktop pin; the dock stays on screen and adds no sideways scroll. IME Enter in the plain composer was already covered by `chat-composer`. Checks for context tags and unread counts are a follow-up. Verified: all seven pass with `chat-composer` on a stack built from this branch, and `task check` passes. Breaking the drag-cancel and key-resize code in the dock makes those checks fail. Not covered, filed as #1900: a stored layout with an unknown side or non-numeric width overlaps the page. Known unrelated failure: `phone-overflow` fails at 390px on main (topbar breadcrumb is 2px wide). `chat-dock-phone` measures the dock against the page without it, so it is unaffected.
sam added 1 commit 2026-11-12 12:08:11 +00:00
test(e2e): chat dock browser checks (#1886)
ci/woodpecker/pr/quality Pipeline was successful
Quality / check (pull_request) Canceled after 0s
3f092c0704
sam added 1 commit 2026-11-12 12:14:32 +00:00
Merge branch 'main' into test/1886-chat-dock-checks
ci/woodpecker/pr/quality Pipeline was successful
Quality / check (pull_request) Failing after 10m40s
cdae23d7e9
sam merged commit 38d9cca84a into main 2026-11-12 12:14:41 +00:00
sam deleted branch test/1886-chat-dock-checks 2026-11-12 12:14:41 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1901