Chat dock: a stored layout with a bad side or width overlaps the page #1900

Closed
opened 2026-11-12 12:08:03 +00:00 by sam · 1 comment
Owner

The dock saves its side and width in browser storage and trusts what it reads back. A stored side other than left or right (for example "up") pins the dock to the right. A non-numeric width (for example "huge") makes the dock width and the page's reserved room invalid, so the pinned dock covers the page instead of reflowing it.

Done when: an unknown side falls back to floating, a non-numeric width falls back to the default 420, and the page still reflows beside a pinned dock. e2e/checks/chat-dock-layout.cjs covers valid shapes only; extend it with these two.

The dock saves its side and width in browser storage and trusts what it reads back. A stored side other than left or right (for example "up") pins the dock to the right. A non-numeric width (for example "huge") makes the dock width and the page's reserved room invalid, so the pinned dock covers the page instead of reflowing it. Done when: an unknown side falls back to floating, a non-numeric width falls back to the default 420, and the page still reflows beside a pinned dock. e2e/checks/chat-dock-layout.cjs covers valid shapes only; extend it with these two.
Author
Owner

Already handled by the float rework: normalizeLayout in ui/src/chat/ChatDockLayout.ts sanitises every stored layout read (unknown mode, non-finite or non-numeric rect, clamped sizes, legacy side/width migrated), covered by ui/test/chat-dock-float.test.ts.

Already handled by the float rework: normalizeLayout in ui/src/chat/ChatDockLayout.ts sanitises every stored layout read (unknown mode, non-finite or non-numeric rect, clamped sizes, legacy side/width migrated), covered by ui/test/chat-dock-float.test.ts.
sam closed this issue 2026-11-14 04:08:13 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1900