Merge pull request 'test(e2e): chat dock browser checks (#1886)' (#1901) from test/1886-chat-dock-checks into main
ci/woodpecker/push/deploy Pipeline is pending
deploy / plan (push) Canceled after 0s
deploy / gate (push) Canceled after 0s
deploy / archied-image (push) Canceled after 0s
deploy / agent-image (push) Canceled after 0s
deploy / dist-zip (push) Canceled after 0s
ci/woodpecker/push/deploy Pipeline is pending
deploy / plan (push) Canceled after 0s
deploy / gate (push) Canceled after 0s
deploy / archied-image (push) Canceled after 0s
deploy / agent-image (push) Canceled after 0s
deploy / dist-zip (push) Canceled after 0s
Reviewed-on: #1901
This commit was merged in pull request #1901.
This commit is contained in:
commit
38d9cca84a
9 files changed
+369
-1
No files matched your search
+2
-1
@@ -84,7 +84,8 @@ console or page error fails the check. One module covers one behaviour;
|
||||
families share a prefix: `audit-*` for the audit page (redirect,
|
||||
filters, revert, runtime, views-export, retention-live, phone),
|
||||
`workflow-*` for the canvas (loading, validation, phone-layout, logic),
|
||||
`chat-composer` for chat input.
|
||||
`chat-composer` for chat input, `chat-dock-*` for the chat dock (pin, drag-cancel,
|
||||
layout, resize, drafts, picker, phone).
|
||||
|
||||
`routes` loads every static route and flags text with stray leading,
|
||||
trailing or doubled spaces. `seeded` checks the seed is visible.
|
||||
|
||||
@@ -0,0 +1,42 @@
|
||||
// Each conversation keeps its own unsent text and attached tasks. Starting a
|
||||
// new chat opens an empty composer, switching back restores the earlier
|
||||
// draft, and hiding and reopening the conversation loses nothing.
|
||||
const assert = require('node:assert/strict');
|
||||
const h = require('./helpers/chat-dock.cjs');
|
||||
|
||||
module.exports = async ({ page, go, shot }) => {
|
||||
await page.route('**/api/tasks?*', (route) =>
|
||||
route.fulfill({ contentType: 'application/json', body: JSON.stringify([{ id: 1861, title: 'Task picker', status: 'running' }]) }),
|
||||
);
|
||||
await h.load(page, go);
|
||||
await h.expand(page);
|
||||
const composer = h.composerOf(page);
|
||||
const tags = page.getByRole('list', { name: 'Attached tasks' });
|
||||
|
||||
await composer.fill('draft for the first chat');
|
||||
await composer.fill('#');
|
||||
await page.getByRole('listbox', { name: 'Tasks' }).getByRole('option').first().click();
|
||||
await tags.getByText('#1861').waitFor();
|
||||
await composer.fill('draft for the first chat');
|
||||
|
||||
await page.getByRole('button', { name: 'New chat' }).click();
|
||||
await h.until(async () => (await composer.inputValue()) === '' && (await tags.count()) === 0, 'a new chat inherited the first chat draft');
|
||||
await composer.fill('draft for the second chat');
|
||||
|
||||
await h.hideOf(page).click();
|
||||
await h.expand(page);
|
||||
assert.equal(await composer.inputValue(), 'draft for the second chat', 'hiding the conversation lost the draft');
|
||||
|
||||
const pick = async (index) => {
|
||||
await page.getByRole('combobox', { name: 'Conversation' }).click();
|
||||
await page.getByRole('option').nth(index).click();
|
||||
};
|
||||
await pick(1);
|
||||
await h.until(async () => (await composer.inputValue()) === 'draft for the first chat', 'switching back did not restore the first draft');
|
||||
await tags.getByText('#1861').waitFor();
|
||||
await shot('first-chat-draft');
|
||||
|
||||
await pick(0);
|
||||
await h.until(async () => (await composer.inputValue()) === 'draft for the second chat', 'switching forward did not restore the second draft');
|
||||
assert.equal(await tags.count(), 0, 'the first chat task tag leaked into the second chat');
|
||||
};
|
||||
@@ -0,0 +1,27 @@
|
||||
// A drag the browser cancels (a touch turned into a scroll, a lost pointer)
|
||||
// leaves the dock where it was: nothing pins, nothing stays offset, and the
|
||||
// next drag still works.
|
||||
const assert = require('node:assert/strict');
|
||||
const h = require('./helpers/chat-dock.cjs');
|
||||
|
||||
module.exports = async ({ page, go }) => {
|
||||
await h.load(page, go);
|
||||
await h.expand(page);
|
||||
const dock = h.dockOf(page);
|
||||
const before = await dock.boundingBox();
|
||||
const header = dock.locator('div.cursor-grab');
|
||||
|
||||
await h.dragTo(page, 1430);
|
||||
const dragging = await dock.getAttribute('style');
|
||||
assert.ok(/translate/.test(dragging || ''), 'the drag never started, so cancelling it proves nothing');
|
||||
await header.dispatchEvent('pointercancel');
|
||||
await page.mouse.up();
|
||||
|
||||
await h.until(async () => !/translate/.test((await dock.getAttribute('style')) || ''), 'the dock stayed offset after the drag was cancelled');
|
||||
assert.deepEqual(await dock.boundingBox(), before, 'cancelling the drag moved the dock');
|
||||
assert.equal((await h.saved(page)).side, null, 'a cancelled drag pinned the dock');
|
||||
|
||||
await h.dragTo(page, 1430);
|
||||
await page.mouse.up();
|
||||
await h.until(async () => (await h.saved(page)).side === 'right', 'a drag after a cancelled one did not pin');
|
||||
};
|
||||
@@ -0,0 +1,46 @@
|
||||
// The saved dock layout: a stored side and width are honoured, widths outside
|
||||
// the allowed range are clamped, unreadable JSON falls back to a usable
|
||||
// floating dock that saves again, and visiting phone width never overwrites
|
||||
// the desktop choice.
|
||||
const assert = require('node:assert/strict');
|
||||
const h = require('./helpers/chat-dock.cjs');
|
||||
|
||||
module.exports = async ({ page, go, shot, tolerate }) => {
|
||||
tolerate(/JSON|SyntaxError/);
|
||||
const dock = h.dockOf(page);
|
||||
|
||||
await h.load(page, go, JSON.stringify({ side: 'left', width: 500 }));
|
||||
await h.expand(page);
|
||||
let box = await dock.boundingBox();
|
||||
h.near(box.x, 0, 'saved left side');
|
||||
h.near(box.width, 500, 'saved width');
|
||||
assert.ok((await h.mainRect(page)).x >= 499, 'page did not reflow beside the restored dock');
|
||||
|
||||
await h.load(page, go, JSON.stringify({ side: 'right', width: -4 }));
|
||||
await h.expand(page);
|
||||
h.near((await dock.boundingBox()).width, 320, 'a negative width clamps to the minimum');
|
||||
|
||||
await h.load(page, go, JSON.stringify({ side: 'right', width: 9999 }));
|
||||
await h.expand(page);
|
||||
h.near((await dock.boundingBox()).width, 720, 'a huge width clamps to the maximum');
|
||||
|
||||
await h.load(page, go, '{broken');
|
||||
await h.expand(page);
|
||||
box = await dock.boundingBox();
|
||||
assert.ok(box.height < 900 && box.x > 0 && box.x + box.width < 1440, 'unreadable layout did not fall back to a floating dock');
|
||||
await h.composerOf(page).fill('still usable');
|
||||
await h.dragTo(page, 1430);
|
||||
await page.mouse.up();
|
||||
await h.until(async () => (await h.saved(page)).side === 'right', 'the dock did not save a layout over the unreadable one');
|
||||
await shot('recovered');
|
||||
|
||||
await h.load(page, go, JSON.stringify({ side: 'left', width: 460 }));
|
||||
const layout = await h.stored(page);
|
||||
await page.setViewportSize({ width: 390, height: 844 });
|
||||
await h.expand(page);
|
||||
box = await dock.boundingBox();
|
||||
assert.ok(box.x >= 0 && box.x + box.width <= 390, 'the dock overflows the phone viewport');
|
||||
await page.setViewportSize({ width: 1440, height: 900 });
|
||||
assert.equal(await h.stored(page), layout, 'visiting phone width rewrote the saved layout');
|
||||
await h.until(async () => Math.abs((await dock.boundingBox()).width - 460) <= 1, 'the desktop layout did not return after phone width');
|
||||
};
|
||||
@@ -0,0 +1,41 @@
|
||||
// The chat dock at phone width: the bar and the open conversation fit the
|
||||
// screen on a few pages, a stored desktop pin is ignored, the composer stays
|
||||
// reachable, and the dock adds no sideways scroll. The page's own overflow is
|
||||
// phone-overflow's to report, so the dock is measured against the page
|
||||
// without it.
|
||||
const assert = require('node:assert/strict');
|
||||
const h = require('./helpers/chat-dock.cjs');
|
||||
|
||||
module.exports = async ({ page, go, shot, tolerate }) => {
|
||||
tolerate(/extensions\/catalogue/);
|
||||
await page.setViewportSize({ width: 390, height: 844 });
|
||||
const fits = async (label) => {
|
||||
const { scroll, bare, inner } = await page.evaluate(() => {
|
||||
const root = document.querySelector('aside[aria-label="Chat with Archie"]').parentElement;
|
||||
const scroll = document.documentElement.scrollWidth;
|
||||
root.style.display = 'none';
|
||||
const bare = document.documentElement.scrollWidth;
|
||||
root.style.display = '';
|
||||
return { scroll, bare, inner: window.innerWidth };
|
||||
});
|
||||
assert.ok(scroll <= Math.max(bare, inner), `${label}: the dock widens the page (${scroll} > ${Math.max(bare, inner)})`);
|
||||
const box = await h.dockOf(page).boundingBox();
|
||||
assert.ok(box.x >= 0 && box.x + box.width <= inner, `${label}: dock leaves the screen (${box.x}..${box.x + box.width})`);
|
||||
assert.ok(box.y >= 0 && box.y + box.height <= 844, `${label}: dock leaves the screen vertically`);
|
||||
};
|
||||
|
||||
for (const path of ['/events', '/account', '/org/agents']) {
|
||||
await h.load(page, go, JSON.stringify({ side: 'right', width: 420 }));
|
||||
await go(path);
|
||||
await fits(`${path} collapsed`);
|
||||
await h.expand(page);
|
||||
await fits(`${path} open`);
|
||||
assert.equal(await page.evaluate(() => document.documentElement.style.getPropertyValue('--chat-pin-r')), '0px', `${path}: the page reserved room for a pin on a phone`);
|
||||
const composer = await h.composerOf(page).boundingBox();
|
||||
assert.ok(composer.y + composer.height <= 844 && composer.x >= 0 && composer.x + composer.width <= 390, `${path}: composer is off screen`);
|
||||
assert.equal(await h.dividerOf(page).count(), 0, `${path}: a phone shows the pin divider`);
|
||||
await h.composerOf(page).fill('A long unbroken line '.repeat(20));
|
||||
await fits(`${path} long draft`);
|
||||
await shot(path);
|
||||
}
|
||||
};
|
||||
@@ -0,0 +1,59 @@
|
||||
// The # task picker by keyboard: arrows move the selection and wrap, Enter
|
||||
// attaches the selected task, Escape closes the picker and leaves the
|
||||
// conversation open, and an IME confirmation Enter never picks.
|
||||
const assert = require('node:assert/strict');
|
||||
const h = require('./helpers/chat-dock.cjs');
|
||||
|
||||
const tasks = [
|
||||
{ id: 1861, title: 'Task picker', status: 'running' },
|
||||
{ id: 1842, title: 'Retry stalled task runs', status: 'done' },
|
||||
{ id: 1830, title: 'Filter forge text', status: 'queued' },
|
||||
];
|
||||
|
||||
module.exports = async ({ page, go, shot }) => {
|
||||
await page.route('**/api/tasks?*', (route) => route.fulfill({ contentType: 'application/json', body: JSON.stringify(tasks) }));
|
||||
await h.load(page, go);
|
||||
await h.expand(page);
|
||||
const composer = h.composerOf(page);
|
||||
const palette = page.getByRole('listbox', { name: 'Tasks' });
|
||||
const options = palette.getByRole('option');
|
||||
const selected = () => options.evaluateAll((els) => els.findIndex((el) => el.getAttribute('aria-selected') === 'true'));
|
||||
const tags = page.getByRole('list', { name: 'Attached tasks' });
|
||||
|
||||
await composer.fill('Look at #');
|
||||
await options.first().waitFor();
|
||||
assert.equal(await options.count(), 3);
|
||||
assert.equal(await selected(), 0);
|
||||
await shot('picker');
|
||||
|
||||
await composer.press('ArrowDown');
|
||||
assert.equal(await selected(), 1);
|
||||
assert.equal(await composer.getAttribute('aria-activedescendant'), 'slash-palette-option-1');
|
||||
await composer.press('ArrowUp');
|
||||
await composer.press('ArrowUp');
|
||||
assert.equal(await selected(), 2, 'ArrowUp from the first row did not wrap to the last');
|
||||
await composer.press('ArrowDown');
|
||||
assert.equal(await selected(), 0, 'ArrowDown from the last row did not wrap to the first');
|
||||
await composer.press('ArrowDown');
|
||||
|
||||
for (const event of [{ isComposing: true }, { keyCode: 229 }]) {
|
||||
await composer.dispatchEvent('keydown', { key: 'Enter', bubbles: true, cancelable: true, ...event });
|
||||
assert.equal(await options.count(), 3, 'an IME confirmation closed the picker');
|
||||
assert.equal(await tags.count(), 0, 'an IME confirmation attached a task');
|
||||
}
|
||||
|
||||
await composer.press('Enter');
|
||||
await palette.waitFor({ state: 'hidden' });
|
||||
await tags.getByText('#1842').waitFor();
|
||||
assert.equal(await tags.getByRole('listitem').count(), 1);
|
||||
assert.equal(await composer.inputValue(), 'Look at ', 'the # token stayed in the text');
|
||||
assert.ok(await composer.evaluate((el) => document.activeElement === el), 'focus left the composer');
|
||||
|
||||
await composer.fill('Look at #');
|
||||
await options.first().waitFor();
|
||||
await composer.press('Escape');
|
||||
await palette.waitFor({ state: 'hidden' });
|
||||
assert.equal(await h.hideOf(page).isVisible(), true, 'Escape on the picker also closed the conversation');
|
||||
await composer.press('Escape');
|
||||
await h.hideOf(page).waitFor({ state: 'hidden' });
|
||||
};
|
||||
@@ -0,0 +1,52 @@
|
||||
// Pinning the chat dock: dragging its header to an edge pins it there and the
|
||||
// page reflows beside it; double-clicking the header unpins it; hiding the
|
||||
// conversation gives the page back its width; the choice survives a reload.
|
||||
const assert = require('node:assert/strict');
|
||||
const h = require('./helpers/chat-dock.cjs');
|
||||
|
||||
module.exports = async ({ page, go, shot }) => {
|
||||
await h.load(page, go);
|
||||
await h.expand(page);
|
||||
const dock = h.dockOf(page);
|
||||
const free = await h.mainRect(page);
|
||||
const floating = await dock.boundingBox();
|
||||
assert.ok(floating.height < 900, 'the dock starts as a floating card');
|
||||
|
||||
await h.dragTo(page, 1430);
|
||||
await page.mouse.up();
|
||||
await h.until(async () => (await h.saved(page)).side === 'right', 'dragging to the right edge did not pin right');
|
||||
const right = await dock.boundingBox();
|
||||
h.near(right.x + right.width, 1440, 'right pin touches the right edge');
|
||||
h.near(right.height, 900, 'a pinned dock is full height');
|
||||
const reflowed = await h.mainRect(page);
|
||||
assert.ok(reflowed.x + reflowed.width <= right.x + 1, `page content runs under the pinned dock: ${reflowed.x + reflowed.width} > ${right.x}`);
|
||||
assert.ok(reflowed.width < free.width, 'the page did not give up any width');
|
||||
assert.ok(await page.evaluate(() => document.documentElement.scrollWidth <= window.innerWidth), 'pinning made the page scroll sideways');
|
||||
await shot('pinned-right');
|
||||
|
||||
await page.reload();
|
||||
await h.expand(page);
|
||||
await h.until(async () => Math.abs((await dock.boundingBox()).x - right.x) <= 1, 'the right pin did not survive a reload');
|
||||
|
||||
await h.hideOf(page).click();
|
||||
await h.until(async () => Math.abs((await h.mainRect(page)).width - free.width) <= 1, 'hiding the conversation kept the page narrowed');
|
||||
await h.expand(page);
|
||||
await h.until(async () => Math.abs((await dock.boundingBox()).x - right.x) <= 1, 'reopening did not restore the pin');
|
||||
|
||||
const strip = await h.grip(page);
|
||||
await page.mouse.dblclick(strip.x, strip.y);
|
||||
await h.until(async () => (await h.saved(page)).side === null, 'double-clicking the header did not unpin');
|
||||
assert.ok((await dock.boundingBox()).height < 900, 'an unpinned dock is a floating card again');
|
||||
h.near((await h.mainRect(page)).width, free.width, 'the page returns to its full width');
|
||||
|
||||
await h.dragTo(page, 10);
|
||||
await page.mouse.up();
|
||||
await h.until(async () => (await h.saved(page)).side === 'left', 'dragging to the left edge did not pin left');
|
||||
const left = await dock.boundingBox();
|
||||
h.near(left.x, 0, 'left pin touches the left edge');
|
||||
assert.ok((await h.mainRect(page)).x >= left.x + left.width - 1, 'page content runs under the left-pinned dock');
|
||||
await shot('pinned-left');
|
||||
|
||||
await page.mouse.dblclick((await h.grip(page)).x, (await h.grip(page)).y);
|
||||
await h.until(async () => (await h.saved(page)).side === null, 'double-clicking did not unpin the left pin');
|
||||
};
|
||||
@@ -0,0 +1,37 @@
|
||||
// The pinned dock's divider is a keyboard separator: the arrow toward the
|
||||
// page widens the dock, the arrow away narrows it, both stop at the allowed
|
||||
// range, and the width is saved.
|
||||
const assert = require('node:assert/strict');
|
||||
const h = require('./helpers/chat-dock.cjs');
|
||||
|
||||
const width = (page) => h.dockOf(page).boundingBox().then((b) => Math.round(b.width));
|
||||
const value = (page) => h.dividerOf(page).getAttribute('aria-valuenow').then(Number);
|
||||
|
||||
module.exports = async ({ page, go }) => {
|
||||
const divider = h.dividerOf(page);
|
||||
for (const [side, grow, shrink] of [['right', 'ArrowLeft', 'ArrowRight'], ['left', 'ArrowRight', 'ArrowLeft']]) {
|
||||
await h.load(page, go, JSON.stringify({ side, width: 420 }));
|
||||
await h.expand(page);
|
||||
await divider.focus();
|
||||
assert.equal(await value(page), 420);
|
||||
assert.equal(await divider.getAttribute('aria-valuemin'), '320');
|
||||
|
||||
await page.keyboard.press(grow);
|
||||
await h.until(async () => (await value(page)) === 436 && (await width(page)) === 436, `${side}: ${grow} did not widen by 16`);
|
||||
await page.keyboard.press(shrink);
|
||||
await page.keyboard.press(shrink);
|
||||
await h.until(async () => (await value(page)) === 404 && (await width(page)) === 404, `${side}: ${shrink} did not narrow by 16`);
|
||||
assert.equal((await h.saved(page)).width, 404, `${side}: the width was not saved`);
|
||||
|
||||
await page.keyboard.press('ArrowUp');
|
||||
assert.equal(await value(page), 404, `${side}: a vertical arrow resized the dock`);
|
||||
|
||||
for (let i = 0; i < 12; i++) await page.keyboard.press(shrink);
|
||||
await h.until(async () => (await width(page)) === 320, `${side}: the dock narrowed past its minimum`);
|
||||
assert.equal(await value(page), 320);
|
||||
|
||||
for (let i = 0; i < 30; i++) await page.keyboard.press(grow);
|
||||
await h.until(async () => (await width(page)) === 720, `${side}: the dock widened past its maximum`);
|
||||
assert.equal(await value(page), 720);
|
||||
}
|
||||
};
|
||||
@@ -0,0 +1,63 @@
|
||||
// Shared handles for the chat dock checks: the dock's own storage key, its
|
||||
// landmarks, and the pointer gestures that pin it.
|
||||
const assert = require('node:assert/strict');
|
||||
|
||||
const KEY = 'archie.chat.dock';
|
||||
|
||||
const dockOf = (page) => page.getByRole('complementary', { name: 'Chat with Archie' });
|
||||
const composerOf = (page) => page.getByRole('combobox', { name: 'Message Archie', exact: true });
|
||||
const hideOf = (page) => page.getByRole('button', { name: 'Hide conversation' });
|
||||
const dividerOf = (page) => page.getByRole('separator', { name: 'Resize chat' });
|
||||
|
||||
const stored = (page) => page.evaluate((key) => localStorage.getItem(key), KEY);
|
||||
const saved = async (page) => JSON.parse(await stored(page));
|
||||
|
||||
// Loads /events with the given stored layout (a string, or null for none).
|
||||
async function load(page, go, layout = null) {
|
||||
await go('/events');
|
||||
await page.evaluate(([key, value]) => (value === null ? localStorage.removeItem(key) : localStorage.setItem(key, value)), [KEY, layout]);
|
||||
await go('/events');
|
||||
}
|
||||
|
||||
// Focusing the composer is how the operator opens the conversation.
|
||||
async function expand(page) {
|
||||
await composerOf(page).focus();
|
||||
await hideOf(page).waitFor();
|
||||
}
|
||||
|
||||
// Retries an assertion until it holds: the dock settles over a few frames.
|
||||
async function until(check, message, timeout = 5000) {
|
||||
const end = Date.now() + timeout;
|
||||
let last;
|
||||
for (;;) {
|
||||
try {
|
||||
const ok = await check();
|
||||
if (ok) return;
|
||||
last = ok;
|
||||
} catch (e) {
|
||||
last = e;
|
||||
}
|
||||
if (Date.now() > end) throw new Error(`${message}${last instanceof Error ? `: ${last.message}` : ''}`);
|
||||
await new Promise((r) => setTimeout(r, 50));
|
||||
}
|
||||
}
|
||||
|
||||
const near = (a, b, message, tolerance = 1) => assert.ok(Math.abs(a - b) <= tolerance, `${message}: ${a} is not within ${tolerance} of ${b}`);
|
||||
|
||||
// The empty strip at the top of the header, where a drag starts.
|
||||
async function grip(page) {
|
||||
const box = await dockOf(page).boundingBox();
|
||||
return { x: box.x + box.width / 2, y: box.y + 8 };
|
||||
}
|
||||
|
||||
async function dragTo(page, x, steps = 10) {
|
||||
const from = await grip(page);
|
||||
await page.mouse.move(from.x, from.y);
|
||||
await page.mouse.down();
|
||||
await page.mouse.move(x, from.y, { steps });
|
||||
return from;
|
||||
}
|
||||
|
||||
const mainRect = (page) => page.locator('#main-content').boundingBox();
|
||||
|
||||
module.exports = { KEY, dockOf, composerOf, hideOf, dividerOf, stored, saved, load, expand, until, near, grip, dragTo, mainRect };
|
||||
Reference in new issue
Block a user