8ae21f25dbf14036bbe10daa9de5793c32c3bf69
cmd/archied opens nell.OpenStore, not internal/store. Adapter.Transition
and Adapter.Requeue accepted a from status and never read it: they loaded
the document, overwrote the status and put. ErrStaleTransition could not
occur, so every compare-and-swap the callers depend on was absent in
production while passing in tests, which use the SQLite store.
Measured on the adapter: eight concurrent dashboard retries requeued one
task four times; twenty concurrent IncrementRetryCount calls landed a
count of one, so the retry cap added in 170fe02 could be evaded
indefinitely by holding Retry down. The same gap made approve and reject
read-then-write races -- a waiting_human task the daemon had since
claimed could be yanked back to queued and executed twice.
All three now take the adapter's existing mutex and check the guard. A
document store has no conditional update, so read-then-write has to be
serialised; the daemon is a single process, which is where the
concurrency is. No internal caller holds the lock when calling these, so
there is no self-deadlock.
Found by the adversarial review. It is the clearest argument yet for the
conformance-suite pattern: the guarantee was tested only on the backend
nobody runs.
Description
Archie connects events from your systems to agents that can investigate, reason, and act.
Define what an event means, map its data into a workflow, and give that workflow an agent equipped for the job: its own execution environment, tools, and identity.
https://archie.catlow.cloud
133 MiB
0 Stars
1 Watchers
0 Forks
Releases
11
Archie v1.62.0
Latest
Languages
Go
76.7%
Vue
13.1%
TypeScript
7.8%
JavaScript
1.2%
Shell
0.6%
Other
0.4%