Files
archie/internal/infrastructure/postgres/migrations/0017_step_executions.sql
T
sam fa4566fb0d feat(statestore): step_executions, StartStep/FinishStep under the run credential
Plan item 3 of docs/prds/execution-tree-state-machine.md (archie-core-1220), on
top of the transition tables and ErrIllegalTransition enforcement (1214/1215,
archie-core-qdbo.5):

- Migration 0017 adds step_executions -- id, org_id, workspace_id, execution_id,
  attempt, parent_id, depth, kind, name, called_execution_id, status, detail,
  tokens_used, started_at, finished_at, indexed on (execution_id, attempt, id).
  Ownership fields are stamped from the execution's row; depth is derived from
  the parent, never supplied by a caller. Existing rows gain no backfilled
  steps.
- task.Store (the workflow engine's mid-run facade) gains StartStep/FinishStep
  (5 methods, within the 8 cap), with storecontract.StepRecorder fronting them
  on the server; deadlineStore wraps both with its per-call timeout.
- The store enforces each write as one transaction: the guarded row write
  under the shared step transition table plus the transition's own
  stage_start/stage_finish event row. Staleness is decided before legality,
  the way guardTransition decides it, and the store returns the persisted
  event for the caller's post-commit publish -- the EmitDurable convention
  (the daemon's event sink skips already-persisted rows by assigned ID), which
  is why workflow.Run stops emitting stage events beside the store and no
  longer discards step-write errors: a failed start or finish parks the
  execution, and the stage does not run unrecorded. An interrupted stage
  records interrupted rather than failed; a recording failure on that
  shutdown path is logged and left to RecoverStale, which owns the
  interrupted-execution sweep in plan item 6.
- The run credential of docs/prds/orgs-and-access.md authorises StartStep and
  FinishStep on its own execution only: both requests carry the execution ID
  the grant check verifies (FinishStep carries it because the interceptor
  never reads the database), and FinishStep verifies handler-side that the
  step really is that execution's. authorizesTaskScopedCall's sanctioned
  widenings are now held as a lookup table so the next one stops growing a
  switch.
- The PRD's wire contract is StartStep(execution, attempt, parent, kind, name)
  -> step id; the responses also carry the persisted event (needed for the
  post-commit publish) and FinishStep's request carries execution_id (needed
  for the grant check) -- both noted here as deliberate additions to the PRD's
  shorthand. called_execution_id exists in the table but not yet on the wire:
  its named consumer is the workflow-call recording of plan item 4 (#1216).

Conformance drives both adapters; grant tests pin the own-execution scoping;
the wire sentinel set gains ErrInvalidStep (InvalidArgument, "step execution
invalid") for a step kind no consumer names.
2026-09-27 05:42:32 +10:00

32 lines
1.3 KiB
SQL

-- Step executions: one durable record per stage run and per agent or
-- workflow.call step inside a WorkflowExecution
-- (docs/prds/execution-tree-state-machine.md). Statuses are taskstate's
-- StepStatus vocabulary and move only through the step transition table the
-- store enforces; depth is derived from parent_id, never supplied by a
-- caller. Existing rows gain no backfilled steps: their stage history stays
-- in transitions and events.
-- +goose Up
CREATE TABLE step_executions (
id bigint GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
org_id text NOT NULL DEFAULT 'default',
workspace_id text NOT NULL DEFAULT 'default',
execution_id bigint NOT NULL,
attempt bigint NOT NULL,
parent_id bigint,
depth int NOT NULL DEFAULT 0,
kind text NOT NULL,
name text NOT NULL,
called_execution_id bigint NOT NULL DEFAULT 0,
status text NOT NULL DEFAULT 'pending',
detail text NOT NULL DEFAULT '',
tokens_used bigint NOT NULL DEFAULT 0,
started_at timestamptz,
finished_at timestamptz
);
CREATE INDEX idx_step_executions_attempt ON step_executions (execution_id, attempt, id);
-- +goose Down
DROP TABLE step_executions;