6ae883a665332d04b63f648b70add6b37d991d20
Code review on this PR: navigating from one /tasks/:id route to another keeps the previous task's data. The router renders pages with Preact's own render() into one long-lived outlet (main.jsx show()), and taskDetailPage returned RunDetail with no key, so the same element was diffed in place and never remounted. Every task-scoped read lives in a useEffect with empty deps and the open tab and pinned attempt are useState initialisers, so all of them ran once for the first task and the new task was rendered against another task's reads: run history, events, open tab, pinned attempt, and the log/change/debug caches. RunDetail's own comment already asserted "the route remounts it when that changes" -- the remount it relied on never happened. Keying by id makes it happen. Keying rather than resetting is deliberate: RunDetail holds 14 pieces of task-scoped state, and a hand-rolled reset must name every one and silently regresses when a fifteenth is added. A remount is exhaustive by construction. Preact 10.29.8 wraps render() in a Fragment and diffs children by key, so a changed root key unmounts and mounts fresh; both regression tests were shown to fail without the key. Tests: component-level (two task ids rendered into one shared host, mirroring the router's outlet) and router-level through the real show() path.
Description
Archie connects events from your systems to agents that can investigate, reason, and act.
Define what an event means, map its data into a workflow, and give that workflow an agent equipped for the job: its own execution environment, tools, and identity.
https://archie.catlow.cloud
133 MiB
0 Stars
1 Watchers
0 Forks
Releases
11
Archie v1.62.0
Latest
Languages
Go
76.8%
Vue
13.1%
TypeScript
7.8%
JavaScript
1.2%
Shell
0.6%
Other
0.4%