Files
archie/ui/test/chat-update-status.test.js
T
sam e94040a882 fix(chat): stop showing raw 501 banner for unconfigured update-check
refreshUpdate() rendered the fetch error's raw message text into a
visible banner on every page load, including a plain "501: Not
Implemented" when chat.telegram.update_check_command is unset -- a
normal "feature not configured" state, not a failure.

Add updateUnavailableMessage() (chat-update-status.js) to branch on
ApiError.status: 501 renders nothing (matching how Channels shows a
calm "not configured" state for an unconfigured channel), any other
error gets a fixed human message instead of the raw fetch text.

Fixes #443
2026-08-09 02:41:38 +10:00

23 lines
904 B
JavaScript

import { test } from "node:test";
import assert from "node:assert/strict";
import { ApiError } from "../src/base/api.js";
import { updateUnavailableMessage } from "../src/chat/chat-update-status.js";
test("a 501 (feature not configured) is a quiet non-error, not a banner", () => {
assert.equal(updateUnavailableMessage(new ApiError("501: Not Implemented", 501)), null);
});
test("a genuine failure gets a clear human message, not the raw fetch error text", () => {
const err = new ApiError("500 Internal Server Error", 500);
const message = updateUnavailableMessage(err);
assert.ok(message);
assert.notEqual(message, err.message);
});
test("an error with no status (e.g. a network failure) also gets a human message", () => {
const err = new TypeError("Failed to fetch");
const message = updateUnavailableMessage(err);
assert.ok(message);
assert.notEqual(message, err.message);
});