Files
archie/internal/webui/api_config_repos_test.go
T
sam 5552ee9c56 feat(webui): inline editing for per-repo allow_concurrent/max_retries/review_enabled
Adds PATCH /api/config/repos/{owner}/{name}, a dedicated seam distinct
from the generic dotted-key PATCH /api/config path: a repository is
one element of []config.Repo, not a flat key. Traced the mechanism
before adding any new plumbing -- overlay.Nest/ApplyOverlayValues
already handle "repos" as a single whole-slice key with no dot, so
the fix is a webui handler plus a bootstrap seam that reads the
daemon's live, untrimmed Repos (never webui.RepoView, which omits
Preflight/TestGlob), mutates the one matched field via the pure
applyRepoFieldUpdate helper, and republishes through the existing
UpdateConfig(ctx, {"repos": repos}) path unchanged.

config-row.js's row() gains an opts.save override so an edit can be
redirected to a different persistence call. The repositories table
renders an autosaving checkbox for the two booleans and a
save-on-blur/Enter input for max_retries, via api.configRepoUpdate.

Closes archie-core-b6ew.6, and with it archie-core-b6ew.
2026-09-02 22:35:03 +10:00

89 lines
2.6 KiB
Go

package webui
import (
"context"
"net/http"
"net/http/httptest"
"strings"
"testing"
)
func TestHandleConfigRepoUpdateAppliesViaSeam(t *testing.T) {
srv := newTestServer(t)
type call struct {
owner, name, field string
value any
}
var got call
srv.UpdateRepoField = func(_ context.Context, owner, name, field string, value any) error {
got = call{owner, name, field, value}
return nil
}
req := httptest.NewRequestWithContext(t.Context(), http.MethodPatch, "/api/config/repos/acme/widget",
strings.NewReader(`{"field": "allow_concurrent", "value": true}`))
w := httptest.NewRecorder()
srv.Handler().ServeHTTP(w, req)
if w.Code != http.StatusOK {
t.Fatalf("status = %d, body = %s", w.Code, w.Body)
}
if got != (call{"acme", "widget", "allow_concurrent", true}) {
t.Errorf("seam called with %+v", got)
}
}
// TestHandleConfigRepoUpdateRejectsUneditableFields proves the handler
// itself refuses a field outside RepoEditableFields before ever calling the
// seam -- Gate, Protect, and every other repo field stay file-edited.
func TestHandleConfigRepoUpdateRejectsUneditableFields(t *testing.T) {
srv := newTestServer(t)
called := false
srv.UpdateRepoField = func(context.Context, string, string, string, any) error {
called = true
return nil
}
req := httptest.NewRequestWithContext(t.Context(), http.MethodPatch, "/api/config/repos/acme/widget",
strings.NewReader(`{"field": "gate", "value": [["rm", "-rf", "/"]]}`))
w := httptest.NewRecorder()
srv.Handler().ServeHTTP(w, req)
if w.Code != http.StatusBadRequest {
t.Fatalf("status = %d, want 400", w.Code)
}
if called {
t.Error("UpdateRepoField was called for a field outside RepoEditableFields")
}
}
func TestHandleConfigRepoUpdateUnavailableMapsTo503(t *testing.T) {
srv := newTestServer(t)
srv.UpdateRepoField = nil
req := httptest.NewRequestWithContext(t.Context(), http.MethodPatch, "/api/config/repos/acme/widget",
strings.NewReader(`{"field": "allow_concurrent", "value": true}`))
w := httptest.NewRecorder()
srv.Handler().ServeHTTP(w, req)
if w.Code != http.StatusServiceUnavailable {
t.Fatalf("status = %d, want 503", w.Code)
}
}
func TestHandleConfigRepoUpdateSeamErrorMapsTo400(t *testing.T) {
srv := newTestServer(t)
srv.UpdateRepoField = func(context.Context, string, string, string, any) error {
return ErrConfigUpdateInvalid
}
req := httptest.NewRequestWithContext(t.Context(), http.MethodPatch, "/api/config/repos/acme/widget",
strings.NewReader(`{"field": "max_retries", "value": 5}`))
w := httptest.NewRecorder()
srv.Handler().ServeHTTP(w, req)
if w.Code != http.StatusBadRequest {
t.Fatalf("status = %d, want 400", w.Code)
}
}