* feat(curator): add embedding client and sampler wave-1 prerequisites Bead archie-core-1786637500752-415-434e5bb9 (GitHub #436) was closed with no linked PR/commits, and the surprisal-sampling bead archie-core-1786637500776-416-600a66e5 (GitHub #437) found none of its stated prerequisites -- an embedding client, a Sampler interface, or the four wave-1 cheap sampling strategies -- actually exist. This builds them: - internal/domain/embedding + internal/infrastructure/embedding: a narrow typed embedding client, config-driven via a providers table + a role in [models], mirroring the existing chat model role convention. Degrades to capability-unavailable (never fails startup or a call) for a missing role, unknown provider, unsupported class, or unresolved credential. Wired as an optional capability in bootstrap.go's setupEmbeddings. - internal/domain/sampling: the Sampler interface plus recency, random, all, and staleness-proxy strategies, per docs/prds/curator-sampler-wave1.md. Deterministic given fixed inputs, matching GitHub #437's stated acceptance criterion for the embedding-backed strategy it will add behind this same interface (not part of this change). Table-driven tests throughout; httptest for the embedding client, no live service. No curator wiring yet -- nothing consumes either capability in this change. * no-mistakes(document): docs(architecture): mark curator sampling prereqs as landed
37 lines
1.1 KiB
Go
37 lines
1.1 KiB
Go
package sampling
|
|
|
|
import (
|
|
"context"
|
|
"slices"
|
|
)
|
|
|
|
// recencySampler is the "recency" strategy: prefers more recently
|
|
// created/updated content, i.e. the largest Candidate.At first.
|
|
type recencySampler struct{}
|
|
|
|
// NewRecency builds the "recency" strategy.
|
|
func NewRecency() Sampler { return recencySampler{} }
|
|
|
|
func (recencySampler) Name() string { return "recency" }
|
|
|
|
func (recencySampler) Sample(_ context.Context, candidates []Candidate, req Request) ([]Candidate, error) {
|
|
sorted := sortByTime(candidates, true)
|
|
return sorted[:effectiveCap(req.Cap, len(sorted))], nil
|
|
}
|
|
|
|
// sortByTime returns a stably-sorted copy of candidates, never mutating the
|
|
// input. newestFirst true sorts descending by At (recency); false sorts
|
|
// ascending (staleness). A stable sort keeps ties in input order, which is
|
|
// what makes both strategies deterministic when candidates share a
|
|
// timestamp.
|
|
func sortByTime(candidates []Candidate, newestFirst bool) []Candidate {
|
|
sorted := append([]Candidate(nil), candidates...)
|
|
slices.SortStableFunc(sorted, func(a, b Candidate) int {
|
|
if newestFirst {
|
|
return b.At.Compare(a.At)
|
|
}
|
|
return a.At.Compare(b.At)
|
|
})
|
|
return sorted
|
|
}
|