Files
archie/internal/forge/writer_issues_test.go
sam 9f830db510 fix(daemon): publish polled issues only from authors with write access (#1830)
The issue poller published title and body of every labelled or assigned
issue to the agent. It now keeps only write-access authors, failing closed
when the forge cannot answer. The filter moves to forge.WriterIssues,
shared with the issue_list tool.
2026-11-14 18:31:54 +11:00

60 lines
1.4 KiB
Go

package forge
import (
"context"
"errors"
"log/slog"
"testing"
)
type writerForge struct {
IssueForge
writers map[string]bool
err error
}
func (f writerForge) HasWriteAccess(_ context.Context, _, _, user string) (bool, error) {
return f.writers[user], f.err
}
type plainForge struct{ IssueForge }
func TestWriterIssues(t *testing.T) {
issues := []Issue{
{Number: 1, Author: "maint"},
{Number: 2, Author: "stranger"},
{Number: 3, Author: "maint"},
{Number: 4},
}
tests := []struct {
name string
forge IssueForge
want []int
wantErr bool
}{
{"keeps collaborators only", writerForge{writers: map[string]bool{"maint": true}}, []int{1, 3}, false},
{"fails closed on forge error", writerForge{err: errors.New("down")}, nil, true},
{"fails closed without a checker", plainForge{}, nil, true},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := WriterIssues(t.Context(), slog.New(slog.DiscardHandler), tt.forge, "o", "r", issues)
if (err != nil) != tt.wantErr {
t.Fatalf("err = %v, wantErr %v", err, tt.wantErr)
}
var nums []int
for _, is := range got {
nums = append(nums, is.Number)
}
if len(nums) != len(tt.want) {
t.Fatalf("got %v, want %v", nums, tt.want)
}
for i := range nums {
if nums[i] != tt.want[i] {
t.Fatalf("got %v, want %v", nums, tt.want)
}
}
})
}
}