Forge text from non-collaborators reaches agents unfiltered #1830

Closed
opened 2026-11-08 22:12:07 +00:00 by sam · 3 comments
Owner

PR review comments and reviews are published to running tasks from any author except the bot (review scan), and agents can read issue bodies and comments through the issue tools. On a public repository anyone can write that text, so a stranger can steer an agent that holds task push grants.

Done when: forge text reaches an agent only from authors with write access to the repository (or an operator-set allowlist per repository policy); text from anyone else is dropped before publish and recorded; the agent brief marks forge text as untrusted data.

PR review comments and reviews are published to running tasks from any author except the bot (review scan), and agents can read issue bodies and comments through the issue tools. On a public repository anyone can write that text, so a stranger can steer an agent that holds task push grants. Done when: forge text reaches an agent only from authors with write access to the repository (or an operator-set allowlist per repository policy); text from anyone else is dropped before publish and recorded; the agent brief marks forge text as untrusted data.
Author
Owner

Core side done (3b840d784): review scan drops authors without write access and fails closed when the forge cannot answer. Open until the forge extensions in archipelago serve HasWriteAccess; until then no PR review activity reaches agents.

Core side done (3b840d784): review scan drops authors without write access and fails closed when the forge cannot answer. Open until the forge extensions in archipelago serve HasWriteAccess; until then no PR review activity reaches agents.
Author
Owner

Done in code: archipelago a753d22 (GitHub/Gitea HasWriteAccess, Issue.Author, extensions 1.3.0) and archie-core e3dc7fc2e (issue list keeps only write-access authors, fails closed). Closes once forge extensions 1.3.0 are published and installed.

Done in code: archipelago a753d22 (GitHub/Gitea HasWriteAccess, Issue.Author, extensions 1.3.0) and archie-core e3dc7fc2e (issue list keeps only write-access authors, fails closed). Closes once forge extensions 1.3.0 are published and installed.
Author
Owner

Landed 9f830db51 and deployed to carina: the issue poller publishes only issues from authors with write access, through the shared forge.WriterIssues filter, and publishes nothing when the forge cannot answer. TestPublishDiscoveredDropsNonWriters fails without the change. The running Gitea and GitHub forge extensions on carina serve HasWriteAccess. Prompts marking forge text as untrusted data are filed separately.

Landed 9f830db51 and deployed to carina: the issue poller publishes only issues from authors with write access, through the shared forge.WriterIssues filter, and publishes nothing when the forge cannot answer. TestPublishDiscoveredDropsNonWriters fails without the change. The running Gitea and GitHub forge extensions on carina serve HasWriteAccess. Prompts marking forge text as untrusted data are filed separately.
sam closed this issue 2026-11-14 07:35:09 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1830