Log with context in sdnotify and staterpc logFailure #1936

Closed
opened 2026-11-12 16:57:21 +00:00 by sam · 1 comment
Owner

After #1927, two places still log without a context, so their lines carry no trace id: sdnotify's Send and Heartbeat (their archied call sites have no ctx), and staterpc's logFailure, which has about 115 call sites in the gRPC handlers. Thread the request ctx into logFailure and the service ctx into the notifier.

Done when neither package calls a non-Context logger method.

After #1927, two places still log without a context, so their lines carry no trace id: sdnotify's Send and Heartbeat (their archied call sites have no ctx), and staterpc's logFailure, which has about 115 call sites in the gRPC handlers. Thread the request ctx into logFailure and the service ctx into the notifier. Done when neither package calls a non-Context logger method.
sam added the chorelow labels 2026-11-12 16:57:21 +00:00
sam added a new dependency 2026-11-13 02:51:01 +00:00
Author
Owner

Fixed in 7ab209fa: logFailure/logErr/orgErr take the request ctx; sdnotify Send, Ready, Heartbeat and the watchdog Beat take a ctx and use the Context logger methods. task check passes.

Fixed in 7ab209fa: logFailure/logErr/orgErr take the request ctx; sdnotify Send, Ready, Heartbeat and the watchdog Beat take a ctx and use the Context logger methods. task check passes.
sam closed this issue 2026-11-13 16:57:21 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1936