Log with context in sdnotify and staterpc logFailure #1936
Notifications
Due Date
No due date set.
Blocks
#1920 Effective Go: critical paths
sam/archie
Reference: sam/archie#1936
Reference in new issue
Block a user
After #1927, two places still log without a context, so their lines carry no trace id: sdnotify's Send and Heartbeat (their archied call sites have no ctx), and staterpc's logFailure, which has about 115 call sites in the gRPC handlers. Thread the request ctx into logFailure and the service ctx into the notifier.
Done when neither package calls a non-Context logger method.
Fixed in
7ab209fa: logFailure/logErr/orgErr take the request ctx; sdnotify Send, Ready, Heartbeat and the watchdog Beat take a ctx and use the Context logger methods. task check passes.