Log through the injected logger with context #1927

Closed
opened 2026-11-12 16:35:17 +00:00 by sam · 1 comment
Owner

archied update.go and prbench use the global slog; about 95 calls on injected loggers use the non-Context methods, so their lines carry no trace id. Convert them, threading ctx where a function lacks one.

Done when no global slog call or non-Context logger call remains outside cmd/.

archied update.go and prbench use the global slog; about 95 calls on injected loggers use the non-Context methods, so their lines carry no trace id. Convert them, threading ctx where a function lacks one. Done when no global slog call or non-Context logger call remains outside cmd/.
sam added the chorelow labels 2026-11-12 16:35:17 +00:00
Author
Owner

Done in f4c304cf for archied, prbench and the injected-logger sweep. natsrpc.RegisterAll and its wrappers now take the registering context (handlers use it without cancellation), which removed the contextcheck suppressions. Left: sdnotify (no ctx at its archied call sites) and staterpc logFailure (115 call sites), filed as a follow-up.

Done in f4c304cf for archied, prbench and the injected-logger sweep. natsrpc.RegisterAll and its wrappers now take the registering context (handlers use it without cancellation), which removed the contextcheck suppressions. Left: sdnotify (no ctx at its archied call sites) and staterpc logFailure (115 call sites), filed as a follow-up.
sam closed this issue 2026-11-12 16:57:21 +00:00
sam added a new dependency 2026-11-13 02:50:51 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1927