fix(chat): anchor the More popover outside the tooltip chain (#1862) #1914

Merged
sam merged 2 commits from fix/1862-more-menu into main 2026-11-12 13:42:32 +00:00
Owner

The composer More button opened its popover in state only: with TooltipTrigger as-child wrapping PopoverTrigger as-child, the popper anchor ref resolved to a component object instead of the button, so Reka never positioned the content and it stayed parked off-screen at translate(0, -200%). Wrapping the tooltip in an explicit PopoverAnchor makes the anchor the real button, so the menu renders beside it. Tooltip (accessible name More), menu items, and the rename/branch dialog are unchanged.

Reproduced in headless Chrome against the vite dev server (API mocked in-page): before the fix the popover rect was (0, -526), outside the viewport; after, (623, 305), fully visible, items work (Retry sends /retry over the chat stream, Rename opens the session-title dialog, Escape closes the menu but not the conversation). Verified on desktop, phone width, and a pinned dock.

Adds ui/test/chat-more-menu.test.ts, a browser behaviour check that fails on the old nesting and passes on the fix (skips when no Chrome binary is present).

Ran: pnpm test (103 pass), pnpm run typecheck, pnpm run build, task check.

The composer More button opened its popover in state only: with TooltipTrigger as-child wrapping PopoverTrigger as-child, the popper anchor ref resolved to a component object instead of the button, so Reka never positioned the content and it stayed parked off-screen at translate(0, -200%). Wrapping the tooltip in an explicit PopoverAnchor makes the anchor the real button, so the menu renders beside it. Tooltip (accessible name More), menu items, and the rename/branch dialog are unchanged. Reproduced in headless Chrome against the vite dev server (API mocked in-page): before the fix the popover rect was (0, -526), outside the viewport; after, (623, 305), fully visible, items work (Retry sends /retry over the chat stream, Rename opens the session-title dialog, Escape closes the menu but not the conversation). Verified on desktop, phone width, and a pinned dock. Adds ui/test/chat-more-menu.test.ts, a browser behaviour check that fails on the old nesting and passes on the fix (skips when no Chrome binary is present). Ran: pnpm test (103 pass), pnpm run typecheck, pnpm run build, task check.
sam added 1 commit 2026-11-12 13:41:04 +00:00
fix(chat): anchor the More popover outside the tooltip chain (#1862)
Quality / check (pull_request) Canceled after 0s
ci/woodpecker/pr/quality Pipeline was canceled
82ca9613c7
Nested inside TooltipTrigger as-child, PopoverTrigger's PopperAnchor ref
resolved to a component object instead of the button, so the popover never
became positioned and its content stayed parked off-screen at
translate(0, -200%): the menu opened in state only, invisible to the user.
Wrapping the tooltip in an explicit PopoverAnchor makes the anchor the real
button element, so the menu renders beside it. The tooltip (accessible name
More), the menu items, and the rename/branch dialog are unchanged.

Adds ui/test/chat-more-menu.test.ts, a browser behaviour check (vite dev
server + headless Chrome over CDP, API mocked in-page) that fails on the old
nesting with the menu at (0, -526) and passes with it in the viewport; it
skips when no Chrome binary is installed.
sam added 1 commit 2026-11-12 13:42:05 +00:00
Merge branch 'main' into fix/1862-more-menu
ci/woodpecker/pr/quality Pipeline was canceled
Quality / check (pull_request) Failing after 5m19s
5baef8805d
sam merged commit 782daf8bbb into main 2026-11-12 13:42:32 +00:00
sam deleted branch fix/1862-more-menu 2026-11-12 13:42:32 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1914