Chat composer: 'More' button does not work #1862

Closed
opened 2026-11-12 03:23:09 +00:00 by sam · 3 comments
Owner

Problem

The "More" button on the chat composer in the web UI does not work when clicked.

Acceptance Criteria

  • Investigate why the "More" button on the chat composer fails to open or respond.
  • Fix the underlying bug in the chat composer component so the button functions as intended (or remove it if it is an unimplemented stub).
  • Add/update tests covering the composer button behavior.

Filed from chat session 1a97dba1-3cf1-466e-8888-6e1532f3eaf3:d898c8c8-47f4-5d6c-945a-2e7dc98ca1c1.

## Problem The "More" button on the chat composer in the web UI does not work when clicked. ## Acceptance Criteria - Investigate why the "More" button on the chat composer fails to open or respond. - Fix the underlying bug in the chat composer component so the button functions as intended (or remove it if it is an unimplemented stub). - Add/update tests covering the composer button behavior. Filed from chat session `1a97dba1-3cf1-466e-8888-6e1532f3eaf3:d898c8c8-47f4-5d6c-945a-2e7dc98ca1c1`.
Author
Owner

Still reproduces after 5a98c313e (Tooltip/PopoverTrigger nesting swap). Not yet re-diagnosed in a browser.

Still reproduces after 5a98c313e (Tooltip/PopoverTrigger nesting swap). Not yet re-diagnosed in a browser.
sam self-assigned this 2026-11-12 13:40:47 +00:00
Author
Owner

Fixed in PR !1914 (branch fix/1862-more-menu, commit 82ca9613).

Root cause (reproduced in headless Chrome against the vite dev server on 5198, API mocked in-page): clicking More did set aria-expanded=true and mounted the popover, but its wrapper stayed at transform translate(0, -200%) with the content rect at (0, -526), outside the 1280x900 viewport, so the menu was invisible. Reka's PopperContent keeps that off-screen transform until floating-ui reports isPositioned, which never happened because with TooltipTrigger as-child wrapping PopoverTrigger as-child, the popper anchor ref resolved to a component object, not the button element. (The pre-5a98c313e order failed differently: the click handler never reached the DOM at all.) The pointer-events-none wrapper, startDrag, and useEscapeLayer were all ruled out in the browser: elementFromPoint hit the button, and Escape behaved correctly.

Fix: ui/src/chat/ChatSessionActions.vue wraps the Tooltip in an explicit PopoverAnchor as-child, so the anchor is the real button and the popover positions beside it (rect 623,305, in viewport). Tooltip with accessible name More, all menu items, and the rename/branch dialog are unchanged. No state.ts change was needed.

Evidence:

  • Before/after browser check (Playwright, dev server, mocked /api): before, popover rect (0,-526) out of viewport; after, in viewport at (623,305) with Retry/Undo/Rename/Branch/Preview compression/Copy as Markdown; Retry sends text "/retry" over POST /api/chat/stream and closes the menu; Rename opens the Session title dialog; Escape closes the menu but leaves the conversation open; toggle and keyboard Enter work; verified at desktop width, 390px phone width, and with the dock pinned right.
  • New ui/test/chat-more-menu.test.ts runs that behaviour check under pnpm test (vite dev server + headless Chrome over CDP, API mocked via fetch override; skips when no Chrome binary is installed). It fails on the old nesting ("the menu must render on screen, got {x:0,y:-526}") and passes on the fix.
  • pnpm test: 103 pass, 0 fail. pnpm run typecheck: clean. pnpm run build: ok. task check: passed on this exact tree.

Files changed: ui/src/chat/ChatSessionActions.vue, ui/test/chat-more-menu.test.ts. ChatBar.vue needed no change; the menu now works wherever ChatBar renders.

Fixed in PR !1914 (branch fix/1862-more-menu, commit 82ca9613). **Root cause (reproduced in headless Chrome against the vite dev server on 5198, API mocked in-page):** clicking More did set aria-expanded=true and mounted the popover, but its wrapper stayed at transform translate(0, -200%) with the content rect at (0, -526), outside the 1280x900 viewport, so the menu was invisible. Reka's PopperContent keeps that off-screen transform until floating-ui reports isPositioned, which never happened because with TooltipTrigger as-child wrapping PopoverTrigger as-child, the popper anchor ref resolved to a component object, not the button element. (The pre-5a98c313e order failed differently: the click handler never reached the DOM at all.) The pointer-events-none wrapper, startDrag, and useEscapeLayer were all ruled out in the browser: elementFromPoint hit the button, and Escape behaved correctly. **Fix:** ui/src/chat/ChatSessionActions.vue wraps the Tooltip in an explicit PopoverAnchor as-child, so the anchor is the real button and the popover positions beside it (rect 623,305, in viewport). Tooltip with accessible name More, all menu items, and the rename/branch dialog are unchanged. No state.ts change was needed. **Evidence:** - Before/after browser check (Playwright, dev server, mocked /api): before, popover rect (0,-526) out of viewport; after, in viewport at (623,305) with Retry/Undo/Rename/Branch/Preview compression/Copy as Markdown; Retry sends text "/retry" over POST /api/chat/stream and closes the menu; Rename opens the Session title dialog; Escape closes the menu but leaves the conversation open; toggle and keyboard Enter work; verified at desktop width, 390px phone width, and with the dock pinned right. - New ui/test/chat-more-menu.test.ts runs that behaviour check under pnpm test (vite dev server + headless Chrome over CDP, API mocked via fetch override; skips when no Chrome binary is installed). It fails on the old nesting ("the menu must render on screen, got {x:0,y:-526}") and passes on the fix. - pnpm test: 103 pass, 0 fail. pnpm run typecheck: clean. pnpm run build: ok. task check: passed on this exact tree. Files changed: ui/src/chat/ChatSessionActions.vue, ui/test/chat-more-menu.test.ts. ChatBar.vue needed no change; the menu now works wherever ChatBar renders.
sam closed this issue 2026-11-12 15:00:08 +00:00
sam added the bug label 2026-11-12 15:52:53 +00:00
Author
Owner

Closing: this task was declined in archie (actioned by d898c8c8-47f4-5d6c-945a-2e7dc98ca1c1 (user)). Reopen the issue to have archie pick it up again.

Closing: this task was declined in archie (actioned by d898c8c8-47f4-5d6c-945a-2e7dc98ca1c1 (user)). Reopen the issue to have archie pick it up again.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1862