Workflows page: move Restore shipped into the overflow menu with a confirm #1704

Closed
opened 2026-10-27 13:41:27 +00:00 by sam · 1 comment
Owner

Restore shipped overwrites workflows yet sits beside New workflow.

Acceptance criteria

Restore shipped is available from the overflow menu and requires confirmation before overwriting workflows.


Imported from beads archie-core-zsw0v · GitHub #1535 · type task · priority P2 · created 2026-10-09

Restore shipped overwrites workflows yet sits beside New workflow. ### Acceptance criteria Restore shipped is available from the overflow menu and requires confirmation before overwriting workflows. --- _Imported from beads `archie-core-zsw0v` · GitHub #1535 · type task · priority P2 · created 2026-10-09_
sam added the taskmedium labels 2026-10-27 13:41:27 +00:00
sam self-assigned this 2026-10-27 13:41:27 +00:00
Author
Owner

Triaged: no code change is needed for this. No code change: the issue's premise no longer holds in the tree, and its safety requirement is already met.

What the code shows

  • ui/src/workflows/WorkflowsPage.vue has no restore control at all. The page header contains exactly one control, the + button (create(), aria-label "New workflow"); there is no "Restore shipped" beside it.
  • ui/src/workflows/WorkflowEditor.vue:444-454 is the page's overflow menu (MoreMenu). It holds History, Performance, Runs, Open run, Version, Draft changes, "Restore" (restorePublished, which only drops an unsaved draft) and "Delete workflow". Nothing restores shipped definitions.
  • The only restore-shipped action is Settings → Task execution (/settings/task-execution, router/index.ts:145-151), in ui/src/settings/SystemTasksPage.vue:173-195: "Restore default" under "Workflows", which opens an AlertDialog ("Restore default workflows?" / "Edits to shipped workflows are discarded.") before calling restoreShippedDefinitions and saving. So "requires confirmation before overwriting workflows" is already satisfied.

Why the requested change should not be built anyway
ui/AGENTS.md states: "Actions live where their scope lives. Bulk or instance-wide actions (e.g., restoring defaults) belong on the settings page for that area, not in a working view's header menu." Putting Restore shipped into the Workflows page overflow menu is exactly what that settled rule forbids, so implementing the acceptance criterion as written would contradict the design the repo already committed to. The same file also fixes the vocabulary: "use 'Restore default' not 'Restore shipped workflows'".

The first acceptance criterion ("available from the overflow menu") is therefore stale rather than unmet: the action lives somewhere safer and is already confirmed. A test-first workflow has nothing to reproduce — there is no observable wrong behaviour, no path where a confirmation-less overwrite can happen from /workflows.

If the real goal is discoverability of the restore from the workflows page, that is a product-direction decision the maintainer owns and would require changing the ui/AGENTS.md rule first; it is not what this issue's text asks for. Recommended action: close #1704 as already resolved, noting the current location and confirm dialog.

Verified by reading the current files listed above (read-only session; no build or test run).

Triaged: no code change is needed for this. No code change: the issue's premise no longer holds in the tree, and its safety requirement is already met. What the code shows - ui/src/workflows/WorkflowsPage.vue has no restore control at all. The page header contains exactly one control, the `+` button (`create()`, aria-label "New workflow"); there is no "Restore shipped" beside it. - ui/src/workflows/WorkflowEditor.vue:444-454 is the page's overflow menu (MoreMenu). It holds History, Performance, Runs, Open run, Version, Draft changes, "Restore" (restorePublished, which only drops an unsaved draft) and "Delete workflow". Nothing restores shipped definitions. - The only restore-shipped action is Settings → Task execution (/settings/task-execution, router/index.ts:145-151), in ui/src/settings/SystemTasksPage.vue:173-195: "Restore default" under "Workflows", which opens an AlertDialog ("Restore default workflows?" / "Edits to shipped workflows are discarded.") before calling restoreShippedDefinitions and saving. So "requires confirmation before overwriting workflows" is already satisfied. Why the requested change should not be built anyway ui/AGENTS.md states: "Actions live where their scope lives. Bulk or instance-wide actions (e.g., restoring defaults) belong on the settings page for that area, not in a working view's header menu." Putting Restore shipped into the Workflows page overflow menu is exactly what that settled rule forbids, so implementing the acceptance criterion as written would contradict the design the repo already committed to. The same file also fixes the vocabulary: "use 'Restore default' not 'Restore shipped workflows'". The first acceptance criterion ("available from the overflow menu") is therefore stale rather than unmet: the action lives somewhere safer and is already confirmed. A test-first workflow has nothing to reproduce — there is no observable wrong behaviour, no path where a confirmation-less overwrite can happen from /workflows. If the real goal is discoverability of the restore from the workflows page, that is a product-direction decision the maintainer owns and would require changing the ui/AGENTS.md rule first; it is not what this issue's text asks for. Recommended action: close #1704 as already resolved, noting the current location and confirm dialog. Verified by reading the current files listed above (read-only session; no build or test run).
sam closed this issue 2026-11-06 22:20:12 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1704