intake = webhook plus [[identities]] silently downgrades to polling instead of failing closed #1673

Closed
opened 2026-10-27 13:41:20 +00:00 by sam · 0 comments
Owner

internal/app/archied/bootstrap.go:1332-1336 logs "forge webhook disabled: multi-identity deployments are not supported yet" and returns, so a deployment that asks for webhook intake and also configures identities quietly falls back to per-identity polling. Config validation does not catch the combination either: internal/infrastructure/configuration/validate.go:256-273 checks only the secret and address.

This contradicts the posture everywhere else in the daemon, where an unsatisfiable configuration fails closed and loudly - the control plane refuses to start on a stored value that will not validate. An operator who sets intake = "webhook" reasonably believes events arrive by webhook; the only evidence otherwise is a single log line.

Fix direction: refuse to start (or reject the config) when Forge.Intake is webhook and identities is non-empty, naming both settings and the supported alternative. Risk-routed: boot path. Found 2026-09-22 during the webhook evaluation.

Notes

Root cause identified 2026-09-22: this is a facet of archie-core-1786637497036-275-8838629e. Forge intake was never migrated onto the identity surface - the intake knobs sit on the shared Forge struct (config.go:204-219) which IdentityConfig reuses (:573), so per-identity intake parses but every read is the root block (validate.go:257-268, defaults.go:278-279, bootstrap.go:1330-1344). Fixing the migration makes this silent downgrade disappear; do not patch it separately with a startup error unless the migration is deferred.

Close reason

Shipped in 3ee259a9: Validate now rejects forge.intake=webhook/both alongside identities at config load, naming both settings and the poll alternative, instead of logging and silently downgrading to polling.


Imported from beads archie-core-yfcn · GitHub #1122 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-02

internal/app/archied/bootstrap.go:1332-1336 logs "forge webhook disabled: multi-identity deployments are not supported yet" and returns, so a deployment that asks for webhook intake and also configures [[identities]] quietly falls back to per-identity polling. Config validation does not catch the combination either: internal/infrastructure/configuration/validate.go:256-273 checks only the secret and address. This contradicts the posture everywhere else in the daemon, where an unsatisfiable configuration fails closed and loudly - the control plane refuses to start on a stored value that will not validate. An operator who sets intake = "webhook" reasonably believes events arrive by webhook; the only evidence otherwise is a single log line. Fix direction: refuse to start (or reject the config) when Forge.Intake is webhook and [[identities]] is non-empty, naming both settings and the supported alternative. Risk-routed: boot path. Found 2026-09-22 during the webhook evaluation. ### Notes Root cause identified 2026-09-22: this is a facet of archie-core-1786637497036-275-8838629e. Forge intake was never migrated onto the identity surface - the intake knobs sit on the shared Forge struct (config.go:204-219) which IdentityConfig reuses (:573), so per-identity intake parses but every read is the root block (validate.go:257-268, defaults.go:278-279, bootstrap.go:1330-1344). Fixing the migration makes this silent downgrade disappear; do not patch it separately with a startup error unless the migration is deferred. ### Close reason Shipped in 3ee259a9: Validate now rejects forge.intake=webhook/both alongside [[identities]] at config load, naming both settings and the poll alternative, instead of logging and silently downgrading to polling. --- _Imported from beads `archie-core-yfcn` · GitHub #1122 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-02_
sam added the mediumbug labels 2026-10-27 13:41:20 +00:00
sam self-assigned this 2026-10-27 13:41:20 +00:00
sam closed this issue 2026-10-27 13:41:20 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1673