A fresh-context review of docs/prds/plugin-settings-live.md (added by d4f63a85 for #1154, merged at 87aad939) returned REVISE / merge BLOCK. The doc must not be treated as the authority for the plugin live-reload work until these land. All cited HEAD facts were confirmed correct; the findings are about decisions the doc does not make.
F1 [proven P1] The descriptor ApplyMode is never specified and the doc's two claims cannot both hold. Triggers names only the watch list (runtimeResourceKinds, internal/app/archied/control_plane.go:265), which is a different artifact from operational_settings.go:49's ApplyMode. The UI is keyed on the descriptor: ui/src/settings/RestartPendingBanner.vue:12 and SettingsSaveBar.vue:31 filter on apply_mode === restart-required. Leave the descriptor restart-required and the stated outcome is false; flip it to live and the gateway's lag drops out of the restart banner. REQUIRED: state the new ApplyMode value, and what replaces the banner for the gateway's lag. (Version-lag rendering is ApplyMode-independent - ui/src/stores/control-plane.ts:89 derives pending-restart from applied_version < storedVersion - so the per-kind badge survives either way.)
F2 [proven P1] The skills_dir refusal has no home, contradicts #1143, and its claimed apply-status shape fits none of the sites #1143 reserves. operational_settings.go:56-58 records that the four directories are deliberately free-form, and validatePluginSettings is func([]byte) error with no view of the running config, so it cannot compare to the value in use. Landing the check there rejects the WRITE (registry.go:44-52 returns ErrValidation), so the store would not keep the version. REQUIRED: name the check site (a pre-layer comparison on the plugin-settings live path), confirm the daemon reports the refusal against the stored version, and state that #1143's validates-nothing still holds for values - this is a change-immutability rule, not a path rule.
F3 [proven P2] The live list is per-kind while layering is per-document: runtime_config.go:201 assigns all four dirs in one step, so joining plugin-settings layers skills_dir live - the very thing the doc excludes from the change. REQUIRED: one sentence recording the coupling and why it is acceptable.
F4 [suspected P1] The plugin replace path inverts the Authority doc's swap rule (docs/prds/runtime-control-plane.md:77-79: start and check the new one before switching, old keeps running on failure). The doc stops the old module first, leaving a window with neither running. REQUIRED: choose and justify (a module's start is its check, plus rollback) or switch to start-then-switch.
F5 [proven P2] A refusal the doc invents is missing from its own error taxonomy: the Rules bullet says replacing a depended-on module is refused, but the Apply status enumeration lists only three error outcomes. REQUIRED: add the fourth with its wording.
F6 [suspected P2] 'A file dropped into a directory loads on its own' is load-only for secret engines: provider_secrets.go:97-99 clears the provider reference when an engine was unresolvable at boot, and re-resolution happens only inside runtimeConfig. REQUIRED: say whether a reconcile tick re-runs layering/resolution, or state the load-only limit.
F7 [proven P2] No Verification section, which docs/prds/RULES.md requires and docs/prds/control-plane-apply-status.md models. REQUIRED: state how each drop/edit/delete/refuse outcome is proved.
F8 [proven P2] 'archie-gateway keeps boot-time loading' oversells what that process boots: loadPlugins (main.go:404) and loadModules (main.go:401, via loadWorkflows) are daemon-only, while the gateway does call loadRuntimeConfig (gateway.go:147) and so layers and reports plugin-settings without loading those directories. REQUIRED: say what the gateway actually boots.
Nits: N1 the deleted-file fact is restated verbatim in three bullets (RULES.md: state each fact once); N2 cite runtimeResourceKinds by symbol, not description; N3 the #1143 decision at operational_settings.go:56 was not consulted at all - the root of F2.
Plugin-engine rule (docs/architecture/plugins-and-extensions.md:26-63): the change adds no new engine and no method to plugin.Plugin, so invariants 1-5 are met; worth one clause noting that host.Register is currently allowed only before the first Start (internal/plugin/host.go:260-262) and whether that rule is relaxed.
Close reason
Closed
Imported from beads archie-core-7kmo · GitHub #1421 · type task · priority P1 · created 2026-09-30 · closed 2026-10-01
A fresh-context review of docs/prds/plugin-settings-live.md (added by d4f63a85 for #1154, merged at 87aad939) returned REVISE / merge BLOCK. The doc must not be treated as the authority for the plugin live-reload work until these land. All cited HEAD facts were confirmed correct; the findings are about decisions the doc does not make.
F1 [proven P1] The descriptor ApplyMode is never specified and the doc's two claims cannot both hold. Triggers names only the watch list (runtimeResourceKinds, internal/app/archied/control_plane.go:265), which is a different artifact from operational_settings.go:49's ApplyMode. The UI is keyed on the descriptor: ui/src/settings/RestartPendingBanner.vue:12 and SettingsSaveBar.vue:31 filter on apply_mode === restart-required. Leave the descriptor restart-required and the stated outcome is false; flip it to live and the gateway's lag drops out of the restart banner. REQUIRED: state the new ApplyMode value, and what replaces the banner for the gateway's lag. (Version-lag rendering is ApplyMode-independent - ui/src/stores/control-plane.ts:89 derives pending-restart from applied_version < storedVersion - so the per-kind badge survives either way.)
F2 [proven P1] The skills_dir refusal has no home, contradicts #1143, and its claimed apply-status shape fits none of the sites #1143 reserves. operational_settings.go:56-58 records that the four directories are deliberately free-form, and validatePluginSettings is func([]byte) error with no view of the running config, so it cannot compare to the value in use. Landing the check there rejects the WRITE (registry.go:44-52 returns ErrValidation), so the store would not keep the version. REQUIRED: name the check site (a pre-layer comparison on the plugin-settings live path), confirm the daemon reports the refusal against the stored version, and state that #1143's validates-nothing still holds for values - this is a change-immutability rule, not a path rule.
F3 [proven P2] The live list is per-kind while layering is per-document: runtime_config.go:201 assigns all four dirs in one step, so joining plugin-settings layers skills_dir live - the very thing the doc excludes from the change. REQUIRED: one sentence recording the coupling and why it is acceptable.
F4 [suspected P1] The plugin replace path inverts the Authority doc's swap rule (docs/prds/runtime-control-plane.md:77-79: start and check the new one before switching, old keeps running on failure). The doc stops the old module first, leaving a window with neither running. REQUIRED: choose and justify (a module's start is its check, plus rollback) or switch to start-then-switch.
F5 [proven P2] A refusal the doc invents is missing from its own error taxonomy: the Rules bullet says replacing a depended-on module is refused, but the Apply status enumeration lists only three error outcomes. REQUIRED: add the fourth with its wording.
F6 [suspected P2] 'A file dropped into a directory loads on its own' is load-only for secret engines: provider_secrets.go:97-99 clears the provider reference when an engine was unresolvable at boot, and re-resolution happens only inside runtimeConfig. REQUIRED: say whether a reconcile tick re-runs layering/resolution, or state the load-only limit.
F7 [proven P2] No Verification section, which docs/prds/RULES.md requires and docs/prds/control-plane-apply-status.md models. REQUIRED: state how each drop/edit/delete/refuse outcome is proved.
F8 [proven P2] 'archie-gateway keeps boot-time loading' oversells what that process boots: loadPlugins (main.go:404) and loadModules (main.go:401, via loadWorkflows) are daemon-only, while the gateway does call loadRuntimeConfig (gateway.go:147) and so layers and reports plugin-settings without loading those directories. REQUIRED: say what the gateway actually boots.
Nits: N1 the deleted-file fact is restated verbatim in three bullets (RULES.md: state each fact once); N2 cite runtimeResourceKinds by symbol, not description; N3 the #1143 decision at operational_settings.go:56 was not consulted at all - the root of F2.
Plugin-engine rule (docs/architecture/plugins-and-extensions.md:26-63): the change adds no new engine and no method to plugin.Plugin, so invariants 1-5 are met; worth one clause noting that host.Register is currently allowed only before the first Start (internal/plugin/host.go:260-262) and whether that rule is relaxed.
### Close reason
Closed
---
_Imported from beads `archie-core-7kmo` · GitHub #1421 · type task · priority P1 · created 2026-09-30 · closed 2026-10-01_
sam
added the hightask labels 2026-10-27 13:39:06 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
A fresh-context review of docs/prds/plugin-settings-live.md (added by
d4f63a85for #1154, merged at87aad939) returned REVISE / merge BLOCK. The doc must not be treated as the authority for the plugin live-reload work until these land. All cited HEAD facts were confirmed correct; the findings are about decisions the doc does not make.F1 [proven P1] The descriptor ApplyMode is never specified and the doc's two claims cannot both hold. Triggers names only the watch list (runtimeResourceKinds, internal/app/archied/control_plane.go:265), which is a different artifact from operational_settings.go:49's ApplyMode. The UI is keyed on the descriptor: ui/src/settings/RestartPendingBanner.vue:12 and SettingsSaveBar.vue:31 filter on apply_mode === restart-required. Leave the descriptor restart-required and the stated outcome is false; flip it to live and the gateway's lag drops out of the restart banner. REQUIRED: state the new ApplyMode value, and what replaces the banner for the gateway's lag. (Version-lag rendering is ApplyMode-independent - ui/src/stores/control-plane.ts:89 derives pending-restart from applied_version < storedVersion - so the per-kind badge survives either way.)
F2 [proven P1] The skills_dir refusal has no home, contradicts #1143, and its claimed apply-status shape fits none of the sites #1143 reserves. operational_settings.go:56-58 records that the four directories are deliberately free-form, and validatePluginSettings is func([]byte) error with no view of the running config, so it cannot compare to the value in use. Landing the check there rejects the WRITE (registry.go:44-52 returns ErrValidation), so the store would not keep the version. REQUIRED: name the check site (a pre-layer comparison on the plugin-settings live path), confirm the daemon reports the refusal against the stored version, and state that #1143's validates-nothing still holds for values - this is a change-immutability rule, not a path rule.
F3 [proven P2] The live list is per-kind while layering is per-document: runtime_config.go:201 assigns all four dirs in one step, so joining plugin-settings layers skills_dir live - the very thing the doc excludes from the change. REQUIRED: one sentence recording the coupling and why it is acceptable.
F4 [suspected P1] The plugin replace path inverts the Authority doc's swap rule (docs/prds/runtime-control-plane.md:77-79: start and check the new one before switching, old keeps running on failure). The doc stops the old module first, leaving a window with neither running. REQUIRED: choose and justify (a module's start is its check, plus rollback) or switch to start-then-switch.
F5 [proven P2] A refusal the doc invents is missing from its own error taxonomy: the Rules bullet says replacing a depended-on module is refused, but the Apply status enumeration lists only three error outcomes. REQUIRED: add the fourth with its wording.
F6 [suspected P2] 'A file dropped into a directory loads on its own' is load-only for secret engines: provider_secrets.go:97-99 clears the provider reference when an engine was unresolvable at boot, and re-resolution happens only inside runtimeConfig. REQUIRED: say whether a reconcile tick re-runs layering/resolution, or state the load-only limit.
F7 [proven P2] No Verification section, which docs/prds/RULES.md requires and docs/prds/control-plane-apply-status.md models. REQUIRED: state how each drop/edit/delete/refuse outcome is proved.
F8 [proven P2] 'archie-gateway keeps boot-time loading' oversells what that process boots: loadPlugins (main.go:404) and loadModules (main.go:401, via loadWorkflows) are daemon-only, while the gateway does call loadRuntimeConfig (gateway.go:147) and so layers and reports plugin-settings without loading those directories. REQUIRED: say what the gateway actually boots.
Nits: N1 the deleted-file fact is restated verbatim in three bullets (RULES.md: state each fact once); N2 cite runtimeResourceKinds by symbol, not description; N3 the #1143 decision at operational_settings.go:56 was not consulted at all - the root of F2.
Plugin-engine rule (docs/architecture/plugins-and-extensions.md:26-63): the change adds no new engine and no method to plugin.Plugin, so invariants 1-5 are met; worth one clause noting that host.Register is currently allowed only before the first Start (internal/plugin/host.go:260-262) and whether that rule is relaxed.
Close reason
Closed
Imported from beads
archie-core-7kmo· GitHub #1421 · type task · priority P1 · created 2026-09-30 · closed 2026-10-01