[bug] command.run ignores step retry and on_failure controls #1642

Closed
opened 2026-10-27 13:41:12 +00:00 by sam · 0 comments
Owner

command.run turns a failing command into a parked Outcome with a nil error (internal/domain/workflow/command_run.go). The shared step wrapper in step_flow.go only retries and only honours on_failure: continue when the step body returns an error, so a failing command is never retried and always parks, whatever the step's retry or on_failure say.

Design

Return the command failure detail as the step error from newCommandRunStage instead of setting tc.Outcome. wrapStep then applies retry and on_failure, and the engine parks with the same command output as the reason. level: warn stays advisory and returns nil.

Acceptance criteria

A compiled command.run step with retry.attempts 3 runs the command 3 times; on_failure: continue leaves the run going with the error surfaced; level: warn still returns no error.

Notes

Fixed in 4188cb31; verified in HEAD 5124bfd4. Closing as already shipped.

Close reason

Closed


Imported from beads archie-core-wbbi · GitHub #1520 · type bug · priority P1 · created 2026-10-08 · closed 2026-10-10

command.run turns a failing command into a parked Outcome with a nil error (internal/domain/workflow/command_run.go). The shared step wrapper in step_flow.go only retries and only honours on_failure: continue when the step body returns an error, so a failing command is never retried and always parks, whatever the step's retry or on_failure say. ### Design Return the command failure detail as the step error from newCommandRunStage instead of setting tc.Outcome. wrapStep then applies retry and on_failure, and the engine parks with the same command output as the reason. level: warn stays advisory and returns nil. ### Acceptance criteria A compiled command.run step with retry.attempts 3 runs the command 3 times; on_failure: continue leaves the run going with the error surfaced; level: warn still returns no error. ### Notes Fixed in 4188cb31; verified in HEAD 5124bfd4. Closing as already shipped. ### Close reason Closed --- _Imported from beads `archie-core-wbbi` · GitHub #1520 · type bug · priority P1 · created 2026-10-08 · closed 2026-10-10_
sam added the highbug labels 2026-10-27 13:41:12 +00:00
sam self-assigned this 2026-10-27 13:41:12 +00:00
sam closed this issue 2026-10-27 13:41:12 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1642