fix(webui): publish per-identity forges so multi-identity task rows keep their links #1520

Closed
opened 2026-10-27 13:40:44 +00:00 by sam · 0 comments
Owner

Task rows in a multi-identity deployment render no forge links. ConfigView
carries the default identity's forge alone, and resolveForge
(internal/webui/api_tasks.go) withholds links entirely when
view.MultiIdentity is set rather than pointing them at the wrong forge. So on
a deployment with identities, every task row loses its click-through to
the issue and the pull request.

Already the production behaviour since the UI process cutover
(archie-core-8cda.5.4): the dashboard runs in a process with no config.Holder,
so the per-identity resolution never ran there. archie-core-ml30 then removed
webui.forgeConfigForTask and TestTaskURLsUseOwningForgeRoutes, which resolved a
task's forge from config.Config -- correct logic that had no reachable caller
once the holder was gone, and which the ratified boundary keeps out of the
rendering package anyway. Recover it from
git show 57d9be5:internal/webui/api_tasks.go (the function plus its test);
the matching rules are exact-identity-name first, then repo ownership with an
ambiguous match falling back to the default forge.

Fix is a projection change, not a rendering one: publish the per-identity
forges. ConfigView needs enough to answer "which forge owns this task" --
identity name -> forge type/host, plus each identity's repo list -- and
resolveForge ports the recovered matching rules onto that instead of
config.Config. The daemon already rebuilds and republishes the projection on
boot and on every reload, so nothing new is needed on the publish side.

Sizing note: single-identity deployments are unaffected, which is every
deployment today. Worth doing when a second identity is configured, or
alongside other ConfigView projection work.

Close reason

Merged in PR #825 (0b7e3a8), GH #819 already closed; bd was stale


Imported from beads archie-core-pv6t · GitHub #819 · type bug · priority P3 · created 2026-09-11 · closed 2026-09-14

Task rows in a multi-identity deployment render no forge links. ConfigView carries the default identity's forge alone, and resolveForge (internal/webui/api_tasks.go) withholds links entirely when view.MultiIdentity is set rather than pointing them at the wrong forge. So on a deployment with [[identities]], every task row loses its click-through to the issue and the pull request. Already the production behaviour since the UI process cutover (archie-core-8cda.5.4): the dashboard runs in a process with no config.Holder, so the per-identity resolution never ran there. archie-core-ml30 then removed webui.forgeConfigForTask and TestTaskURLsUseOwningForgeRoutes, which resolved a task's forge from config.Config -- correct logic that had no reachable caller once the holder was gone, and which the ratified boundary keeps out of the rendering package anyway. Recover it from `git show 57d9be5:internal/webui/api_tasks.go` (the function plus its test); the matching rules are exact-identity-name first, then repo ownership with an ambiguous match falling back to the default forge. Fix is a projection change, not a rendering one: publish the per-identity forges. ConfigView needs enough to answer "which forge owns this task" -- identity name -> forge type/host, plus each identity's repo list -- and resolveForge ports the recovered matching rules onto that instead of config.Config. The daemon already rebuilds and republishes the projection on boot and on every reload, so nothing new is needed on the publish side. Sizing note: single-identity deployments are unaffected, which is every deployment today. Worth doing when a second identity is configured, or alongside other ConfigView projection work. ### Close reason Merged in PR #825 (0b7e3a8), GH #819 already closed; bd was stale --- _Imported from beads `archie-core-pv6t` · GitHub #819 · type bug · priority P3 · created 2026-09-11 · closed 2026-09-14_
sam added the lowbug labels 2026-10-27 13:40:44 +00:00
sam self-assigned this 2026-10-27 13:40:44 +00:00
sam closed this issue 2026-10-27 13:40:44 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1520