docs(prds): the step-type vocabulary PRD names a step type no deployment resolves
docs/prds/workflow-step-vocabulary.md decides the workflow step vocabulary and names its words, but it names the repository-rules step type as workflow.diff-rules while the registered word is gate.diff-rules (workflow.DiffRulesStepName). A definition written to the document's word is refused at save and at run, so the document describes a step type no deployment resolves.
The same document's sibling, docs/prds/runtime-control-plane.md ("Workflows"), still says "Plugins can add step types", which the closed-set decision in the vocabulary PRD contradicts: interpreted plugins contribute no step type, and a step type arrives as a provider in the compiled-in set.
Fix: correct the vocabulary PRD to the registered word, and state the closed-set rule in the runtime-control-plane PRD. Hold both to the code with a guard test in internal/infrastructure/workflowsteps that every step-type name the vocabulary PRD identifies resolves in the provider set.
Acceptance:
the vocabulary PRD names only step types that resolve in workflowsteps.Providers();
the runtime-control-plane PRD states the closed-set rule instead of "Plugins can add step types";
docs/data/generated/dev-docs.json is regenerated in the same commit;
the guard test fails on the pre-fix document and passes after.
Landed in 0aa0277e on crew/l30-gcoj. workflow-step-vocabulary.md now names gate.diff-rules (the registered word, workflow.DiffRulesStepName) in both places; runtime-control-plane.md states the closed-set rule (a step type arrives as a provider in the build's vocabulary; interpreted plugins contribute none) instead of 'Plugins can add step types'. Guard test TestDocumentedStepVocabularyResolvesInTheProviderSet in internal/infrastructure/workflowsteps fails on the pre-fix document naming workflow.diff-rules and passes after; docs/data/generated/dev-docs.json regenerated. Scoped proof on the committed tree: go test ./internal/infrastructure/workflowsteps/... ok; go vet clean; golangci-lint run 0 issues; task docs:artifact:check and task docs:prds pass.
Imported from beads archie-core-vwqc · GitHub #1490 · type task · priority P3 · created 2026-10-02 · closed 2026-10-02
docs(prds): the step-type vocabulary PRD names a step type no deployment resolves
docs/prds/workflow-step-vocabulary.md decides the workflow step vocabulary and names its words, but it names the repository-rules step type as `workflow.diff-rules` while the registered word is `gate.diff-rules` (workflow.DiffRulesStepName). A definition written to the document's word is refused at save and at run, so the document describes a step type no deployment resolves.
The same document's sibling, docs/prds/runtime-control-plane.md ("Workflows"), still says "Plugins can add step types", which the closed-set decision in the vocabulary PRD contradicts: interpreted plugins contribute no step type, and a step type arrives as a provider in the compiled-in set.
Fix: correct the vocabulary PRD to the registered word, and state the closed-set rule in the runtime-control-plane PRD. Hold both to the code with a guard test in internal/infrastructure/workflowsteps that every step-type name the vocabulary PRD identifies resolves in the provider set.
Acceptance:
- the vocabulary PRD names only step types that resolve in workflowsteps.Providers();
- the runtime-control-plane PRD states the closed-set rule instead of "Plugins can add step types";
- docs/data/generated/dev-docs.json is regenerated in the same commit;
- the guard test fails on the pre-fix document and passes after.
Evidence: `rg -n 'workflow.diff-rules' docs/prds/workflow-step-vocabulary.md`; `rg -n 'DiffRulesStepName =' internal/domain/workflow/diff_rules.go`.
### Close reason
Landed in 0aa0277e on crew/l30-gcoj. workflow-step-vocabulary.md now names gate.diff-rules (the registered word, workflow.DiffRulesStepName) in both places; runtime-control-plane.md states the closed-set rule (a step type arrives as a provider in the build's vocabulary; interpreted plugins contribute none) instead of 'Plugins can add step types'. Guard test TestDocumentedStepVocabularyResolvesInTheProviderSet in internal/infrastructure/workflowsteps fails on the pre-fix document naming workflow.diff-rules and passes after; docs/data/generated/dev-docs.json regenerated. Scoped proof on the committed tree: go test ./internal/infrastructure/workflowsteps/... ok; go vet clean; golangci-lint run 0 issues; task docs:artifact:check and task docs:prds pass.
---
_Imported from beads `archie-core-vwqc` · GitHub #1490 · type task · priority P3 · created 2026-10-02 · closed 2026-10-02_
sam
added the lowtask labels 2026-10-27 13:41:11 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
docs(prds): the step-type vocabulary PRD names a step type no deployment resolves
docs/prds/workflow-step-vocabulary.md decides the workflow step vocabulary and names its words, but it names the repository-rules step type as
workflow.diff-ruleswhile the registered word isgate.diff-rules(workflow.DiffRulesStepName). A definition written to the document's word is refused at save and at run, so the document describes a step type no deployment resolves.The same document's sibling, docs/prds/runtime-control-plane.md ("Workflows"), still says "Plugins can add step types", which the closed-set decision in the vocabulary PRD contradicts: interpreted plugins contribute no step type, and a step type arrives as a provider in the compiled-in set.
Fix: correct the vocabulary PRD to the registered word, and state the closed-set rule in the runtime-control-plane PRD. Hold both to the code with a guard test in internal/infrastructure/workflowsteps that every step-type name the vocabulary PRD identifies resolves in the provider set.
Acceptance:
Evidence:
rg -n 'workflow.diff-rules' docs/prds/workflow-step-vocabulary.md;rg -n 'DiffRulesStepName =' internal/domain/workflow/diff_rules.go.Close reason
Landed in
0aa0277eon crew/l30-gcoj. workflow-step-vocabulary.md now names gate.diff-rules (the registered word, workflow.DiffRulesStepName) in both places; runtime-control-plane.md states the closed-set rule (a step type arrives as a provider in the build's vocabulary; interpreted plugins contribute none) instead of 'Plugins can add step types'. Guard test TestDocumentedStepVocabularyResolvesInTheProviderSet in internal/infrastructure/workflowsteps fails on the pre-fix document naming workflow.diff-rules and passes after; docs/data/generated/dev-docs.json regenerated. Scoped proof on the committed tree: go test ./internal/infrastructure/workflowsteps/... ok; go vet clean; golangci-lint run 0 issues; task docs:artifact:check and task docs:prds pass.Imported from beads
archie-core-vwqc· GitHub #1490 · type task · priority P3 · created 2026-10-02 · closed 2026-10-02