webui: the dashboard narrates tool calls with no opt-out; show_tool_calls only gates Telegram #1490

Closed
opened 2026-10-27 13:40:36 +00:00 by sam · 0 comments
Owner

show_tool_calls gates only the Telegram adapter. The web dashboard's chatStreamSink forwards every ToolCallEvent unconditionally (api_chat.go:228) — no config key exists anywhere in webui — so an operator following the documented intent (show_tool_calls off means no tool narration) still gets full per-tool narration in the web dashboard with no way to disable it. The ToolCallEvent contract comment (stream.go:18-20) delegates 'whether to show it at all' to the channel adapter, but only the Telegram adapter exercises the knob.

Failure: an operator with the default show_tool_calls=false opens the web dashboard; every internal tool step of every web chat is narrated in full, exposing tool inventory and parameter shapes to anyone with dashboard access.

Design

Either add a webui-equivalent config key and gate the sink on it, or make show_tool_calls a cross-channel setting. Decide and document the intent, then wire the webui sink to honor it.

Acceptance criteria

With the setting off, the web dashboard does not emit tool frames; with it on, it does — controlled by one documented knob.

Close reason

Fixed: ShowToolCalls moved from TelegramConfig to ChatConfig (one cross-channel setting), webui's chatStreamSink gated on it (off by default, matching Telegram). Adversarial review clean aside from cosmetic/doc notes, both addressed. Breaking config-key move flagged explicitly in the commit body since it's a silent TOML drop, not an error. Committed f7590a6.


Imported from beads archie-core-og5r · GitHub #487 · type bug · priority P2 · created 2026-08-14 · closed 2026-08-14

show_tool_calls gates only the Telegram adapter. The web dashboard's chatStreamSink forwards every ToolCallEvent unconditionally (api_chat.go:228) — no config key exists anywhere in webui — so an operator following the documented intent (show_tool_calls off means no tool narration) still gets full per-tool narration in the web dashboard with no way to disable it. The ToolCallEvent contract comment (stream.go:18-20) delegates 'whether to show it at all' to the channel adapter, but only the Telegram adapter exercises the knob. Failure: an operator with the default show_tool_calls=false opens the web dashboard; every internal tool step of every web chat is narrated in full, exposing tool inventory and parameter shapes to anyone with dashboard access. ### Design Either add a webui-equivalent config key and gate the sink on it, or make show_tool_calls a cross-channel setting. Decide and document the intent, then wire the webui sink to honor it. ### Acceptance criteria With the setting off, the web dashboard does not emit tool frames; with it on, it does — controlled by one documented knob. ### Close reason Fixed: ShowToolCalls moved from TelegramConfig to ChatConfig (one cross-channel setting), webui's chatStreamSink gated on it (off by default, matching Telegram). Adversarial review clean aside from cosmetic/doc notes, both addressed. Breaking config-key move flagged explicitly in the commit body since it's a silent TOML drop, not an error. Committed f7590a6. --- _Imported from beads `archie-core-og5r` · GitHub #487 · type bug · priority P2 · created 2026-08-14 · closed 2026-08-14_
sam added the mediumbug labels 2026-10-27 13:40:36 +00:00
sam self-assigned this 2026-10-27 13:40:36 +00:00
sam closed this issue 2026-10-27 13:40:36 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1490