Remove Postgres-backed tests and the pgtest testcontainers harness #1610

Closed
opened 2026-10-27 13:41:05 +00:00 by sam · 0 comments
Owner

15 test files (internal/infrastructure/postgres/_test.go and internal/app/controlplane/_test.go) start a real postgres:18 container through internal/infrastructure/postgres/pgtest via TestMain. Tests must not open a real database: they break wherever Docker is absent (cloud sessions, deployments), and pgtest is a non-test package holding a test helper. Delete the harness and those tests; where a test guards a listed seam (State Store SQL semantics, grants), replace it with an interceptor or domain test using fakes, otherwise drop it. Done when rg 'pgtest|testcontainers' finds nothing and task check passes with Docker unavailable.

Close reason

Closed


Imported from beads archie-core-uion4 · GitHub #1610 · type bug · priority P1 · created 2026-10-11 · closed 2026-10-11

15 test files (internal/infrastructure/postgres/*_test.go and internal/app/controlplane/*_test.go) start a real postgres:18 container through internal/infrastructure/postgres/pgtest via TestMain. Tests must not open a real database: they break wherever Docker is absent (cloud sessions, deployments), and pgtest is a non-test package holding a test helper. Delete the harness and those tests; where a test guards a listed seam (State Store SQL semantics, grants), replace it with an interceptor or domain test using fakes, otherwise drop it. Done when rg 'pgtest|testcontainers' finds nothing and task check passes with Docker unavailable. ### Close reason Closed --- _Imported from beads `archie-core-uion4` · GitHub #1610 · type bug · priority P1 · created 2026-10-11 · closed 2026-10-11_
sam added the highbug labels 2026-10-27 13:41:05 +00:00
sam self-assigned this 2026-10-27 13:41:05 +00:00
sam closed this issue 2026-10-27 13:41:05 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1610