Dashboard-initiated updates get no phase-2 report, so they are never verified #1472

Closed
opened 2026-10-27 13:40:32 +00:00 by sam · 0 comments
Owner

internal/webui/api_chat.go:497 starts an install with releaseupdate.InstallMeta{Channel: "webui"} and leaves ReportPath empty. CommandInstaller passes that through as ARCHIE_UPDATE_REPORT_PATH, and scripts/archie-update-watchdog's write_report() returns early when it is empty.

Consequences: an operator who approves an update from the dashboard gets only the synchronous phase-1 result (build/install succeeded, restart queued) and never learns whether the daemon actually came back up, whether it was rolled back, or - since c25799e - whether the installed version is the one now running. Telegram gets all of that; the dashboard silently gets none of it.

The verification added in c25799e (releaseupdate.Report.Verify) is reached only from internal/channels/telegram/update.go, so this path is unverified regardless.

Fix needs two parts: give the webui install a ReportPath (updateReportPath in cmd/archied), and give the dashboard somewhere to relay a pending report on boot the way telegram's reportPendingUpdate does - today ReadPendingReport has exactly one caller, and a single report file shared by two relayers would race to clear it.

Acceptance criteria

A dashboard-approved update produces a phase-2 report; the dashboard surfaces its outcome including version verification; two relayers cannot double-report or lose a report.

Close reason

Fixed: dashboard installs now get a ReportPath, and Server.Run relays/verifies/clears the phase-2 report on boot via a new KindUpdateReport SSE event. Adversarial review clean.


Imported from beads archie-core-nln7 · GitHub #531 · type bug · priority P2 · created 2026-08-20 · closed 2026-08-23

internal/webui/api_chat.go:497 starts an install with releaseupdate.InstallMeta{Channel: "webui"} and leaves ReportPath empty. CommandInstaller passes that through as ARCHIE_UPDATE_REPORT_PATH, and scripts/archie-update-watchdog's write_report() returns early when it is empty. Consequences: an operator who approves an update from the dashboard gets only the synchronous phase-1 result (build/install succeeded, restart queued) and never learns whether the daemon actually came back up, whether it was rolled back, or - since c25799e - whether the installed version is the one now running. Telegram gets all of that; the dashboard silently gets none of it. The verification added in c25799e (releaseupdate.Report.Verify) is reached only from internal/channels/telegram/update.go, so this path is unverified regardless. Fix needs two parts: give the webui install a ReportPath (updateReportPath in cmd/archied), and give the dashboard somewhere to relay a pending report on boot the way telegram's reportPendingUpdate does - today ReadPendingReport has exactly one caller, and a single report file shared by two relayers would race to clear it. ### Acceptance criteria A dashboard-approved update produces a phase-2 report; the dashboard surfaces its outcome including version verification; two relayers cannot double-report or lose a report. ### Close reason Fixed: dashboard installs now get a ReportPath, and Server.Run relays/verifies/clears the phase-2 report on boot via a new KindUpdateReport SSE event. Adversarial review clean. --- _Imported from beads `archie-core-nln7` · GitHub #531 · type bug · priority P2 · created 2026-08-20 · closed 2026-08-23_
sam added the mediumbug labels 2026-10-27 13:40:32 +00:00
sam self-assigned this 2026-10-27 13:40:32 +00:00
sam closed this issue 2026-10-27 13:40:32 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1472