Route pr-review's external-PR credential through org-configured credential binding #124

Closed
opened 2026-10-27 13:35:03 +00:00 by sam · 0 comments
Owner

Superseded description: pr-review's external-PR credential problem is now
fully solved, permanently, not by an interim mechanism. Commit 2142e446
(archie-core-afbk.7): the daemon prefetches a pull request's metadata, diff
and head snapshot over its own credentialed forge client before a pr-review
task's container is acquired, and writes the result under
workDir/.archie-pr-review -- the same host directory Docker bind-mounts into
the container. The container-side pipeline (prsource.MountSource) only ever
reads that already-materialized data off local disk. No forge credential of
any kind enters the container, matching docs/development/agent.md's stated
rule exactly, with no exception. There is no env-var mechanism to replace --
that path was proposed, investigated, and correctly rejected before being
built.

What remains open, if anything: this bead can likely be closed as satisfied.
The one real residual question, if it's worth a follow-up at all, is whether
watched-repos' and the operator trigger's daemon-side prefetch call (a
synchronous forge fetch inside acquireTaskContainer, before the container
starts) adds meaningful latency for a large PR or a slow forge response,
serializing container acquisition behind it -- worth revisiting only if that
turns out to matter in practice, not a known problem today.

Close reason

Resolved by 2142e446: the daemon-side prefetch-before-container-start mechanism is the real, permanent design, not an interim one -- no credential-binding follow-up needed. See the updated description for the one minor residual (prefetch latency), which isn't a known problem today.


Imported from beads archie-core-afbk.13 · GitHub #1472 · type task · priority P2 · created 2026-09-28 · closed 2026-09-28

Superseded description: pr-review's external-PR credential problem is now fully solved, permanently, not by an interim mechanism. Commit 2142e446 (archie-core-afbk.7): the daemon prefetches a pull request's metadata, diff and head snapshot over its own credentialed forge client before a pr-review task's container is acquired, and writes the result under workDir/.archie-pr-review -- the same host directory Docker bind-mounts into the container. The container-side pipeline (prsource.MountSource) only ever reads that already-materialized data off local disk. No forge credential of any kind enters the container, matching docs/development/agent.md's stated rule exactly, with no exception. There is no env-var mechanism to replace -- that path was proposed, investigated, and correctly rejected before being built. What remains open, if anything: this bead can likely be closed as satisfied. The one real residual question, if it's worth a follow-up at all, is whether watched-repos' and the operator trigger's daemon-side prefetch call (a synchronous forge fetch inside acquireTaskContainer, before the container starts) adds meaningful latency for a large PR or a slow forge response, serializing container acquisition behind it -- worth revisiting only if that turns out to matter in practice, not a known problem today. ### Close reason Resolved by 2142e446: the daemon-side prefetch-before-container-start mechanism is the real, permanent design, not an interim one -- no credential-binding follow-up needed. See the updated description for the one minor residual (prefetch latency), which isn't a known problem today. --- _Imported from beads `archie-core-afbk.13` · GitHub #1472 · type task · priority P2 · created 2026-09-28 · closed 2026-09-28_
sam added the mediumtask labels 2026-10-27 13:35:03 +00:00
sam self-assigned this 2026-10-27 13:35:03 +00:00
sam closed this issue 2026-10-27 13:35:03 +00:00
sam added a new dependency 2026-11-14 14:45:17 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Blocks
Reference: sam/archie#124