.github/workflows contains only deploy.yml and docs.yml. Nothing compiles or tests Go on a
PR, so the only thing standing between a broken tree and main is a developer's local task check.
CONSEQUENCE, OBSERVED
origin/main did not compile: internal/infrastructure/configuration/apply_test.go built
config.Services with the old struct form after internal/config/services.go became
"type Services map[string]ServiceConnection". The two live in different files, so the merge
was clean and the breakage only surfaced when a later local gate happened to run:
vet: internal/infrastructure/configuration/apply_test.go:51:29: undefined: State
PR #878 merged the map while CI showed only a Greptile review plus the docs workflow -- whose
build job was ALSO failing for an unrelated reason (setup-python with cache: pip and no Python
manifest). So the checks that did run were not protecting the tree.
NOTE ON THE DOCS WORKFLOW. Its "build" job name is misleading: it runs mkdocs, not the Go
build. The pip-cache defect that made it fail on every docs-touching PR is fixed separately.
WHAT IS NEEDED
A workflow that runs the repository's own gate on pull_request -- at minimum go build ./...,
go vet ./..., and the unit tests, with the same toolchain the Taskfile pins -- so a
non-building or failing tree cannot merge. Decide whether to reuse task check (which also
formats and regenerates, and therefore needs care in CI) or a narrower build/vet/test subset.
Close reason
Resolved by .github/workflows/quality.yml, which now runs 'task check' (the definitive gate: fmt, vet, lint, build, unit tests, ui tests) on pull_request and on push to main. Verified present on origin/main and that it triggers on pull_request, so a non-compiling or failing tree can no longer merge. This was the exact gap that let a non-compiling main and the config overlay bug ship.
Imported from beads archie-core-ktpw · GitHub #937 · type task · priority P2 · created 2026-09-18 · closed 2026-09-19
.github/workflows contains only deploy.yml and docs.yml. Nothing compiles or tests Go on a
PR, so the only thing standing between a broken tree and main is a developer's local
`task check`.
CONSEQUENCE, OBSERVED
origin/main did not compile: internal/infrastructure/configuration/apply_test.go built
config.Services with the old struct form after internal/config/services.go became
"type Services map[string]ServiceConnection". The two live in different files, so the merge
was clean and the breakage only surfaced when a later local gate happened to run:
vet: internal/infrastructure/configuration/apply_test.go:51:29: undefined: State
PR #878 merged the map while CI showed only a Greptile review plus the docs workflow -- whose
build job was ALSO failing for an unrelated reason (setup-python with cache: pip and no Python
manifest). So the checks that did run were not protecting the tree.
NOTE ON THE DOCS WORKFLOW. Its "build" job name is misleading: it runs mkdocs, not the Go
build. The pip-cache defect that made it fail on every docs-touching PR is fixed separately.
WHAT IS NEEDED
A workflow that runs the repository's own gate on pull_request -- at minimum go build ./...,
go vet ./..., and the unit tests, with the same toolchain the Taskfile pins -- so a
non-building or failing tree cannot merge. Decide whether to reuse `task check` (which also
formats and regenerates, and therefore needs care in CI) or a narrower build/vet/test subset.
### Close reason
Resolved by .github/workflows/quality.yml, which now runs 'task check' (the definitive gate: fmt, vet, lint, build, unit tests, ui tests) on pull_request and on push to main. Verified present on origin/main and that it triggers on pull_request, so a non-compiling or failing tree can no longer merge. This was the exact gap that let a non-compiling main and the config overlay bug ship.
---
_Imported from beads `archie-core-ktpw` · GitHub #937 · type task · priority P2 · created 2026-09-18 · closed 2026-09-19_
sam
added the mediumtask labels 2026-10-27 13:40:21 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
.github/workflows contains only deploy.yml and docs.yml. Nothing compiles or tests Go on a
PR, so the only thing standing between a broken tree and main is a developer's local
task check.CONSEQUENCE, OBSERVED
origin/main did not compile: internal/infrastructure/configuration/apply_test.go built
config.Services with the old struct form after internal/config/services.go became
"type Services map[string]ServiceConnection". The two live in different files, so the merge
was clean and the breakage only surfaced when a later local gate happened to run:
vet: internal/infrastructure/configuration/apply_test.go:51:29: undefined: State
PR #878 merged the map while CI showed only a Greptile review plus the docs workflow -- whose
build job was ALSO failing for an unrelated reason (setup-python with cache: pip and no Python
manifest). So the checks that did run were not protecting the tree.
NOTE ON THE DOCS WORKFLOW. Its "build" job name is misleading: it runs mkdocs, not the Go
build. The pip-cache defect that made it fail on every docs-touching PR is fixed separately.
WHAT IS NEEDED
A workflow that runs the repository's own gate on pull_request -- at minimum go build ./...,
go vet ./..., and the unit tests, with the same toolchain the Taskfile pins -- so a
non-building or failing tree cannot merge. Decide whether to reuse
task check(which alsoformats and regenerates, and therefore needs care in CI) or a narrower build/vet/test subset.
Close reason
Resolved by .github/workflows/quality.yml, which now runs 'task check' (the definitive gate: fmt, vet, lint, build, unit tests, ui tests) on pull_request and on push to main. Verified present on origin/main and that it triggers on pull_request, so a non-compiling or failing tree can no longer merge. This was the exact gap that let a non-compiling main and the config overlay bug ship.
Imported from beads
archie-core-ktpw· GitHub #937 · type task · priority P2 · created 2026-09-18 · closed 2026-09-19