Extend EnqueueChatTask with generic inputs for the pr-review operator trigger #125
Notifications
Due Date
No due date set.
Blocks
#1218 PR review agent
sam/archie
Reference: sam/archie#125
Reference in new issue
Block a user
afbk.7's watched-repos and archie's-own-PRs triggers are done (commits
7fb1ccd2,5264d5d8). The operator/chat trigger (review_pr chat tool, currently self-omitting with a nil reviewer sinced73e0748deleted the old synchronous ChatPRReviewer path) still needs to enqueue an async pr-review task with a pr_number input, the same generic mechanism watched-repos now uses via Task.EffectivePRNumber().Real blocker: EnqueueChatTask is part of the State Store's protobuf-generated gRPC contract (proto/state/v1/state.proto's EnqueueChatTaskRequest, rpc EnqueueChatTask), not just a Go interface method -- CLAUDE.md's state-store-contract rule applies (never add a Go interface method without a matching RPC). Concrete plan for whoever picks this up:
Not a quick tool rewrite -- proto/sqlc/wire-contract change plus ~20 call sites. Parent epic: archie-core-afbk.
Close reason
Closed
Imported from beads
archie-core-afbk.14· GitHub #1427 · type task · priority P1 · created 2026-09-28 · closed 2026-09-28sam wrote (originally 2026-09-28):
Done in
772d782f. Steps 1-6 as planned, with one change: instead of adding a SetTaskInputs query, InsertChatTask gained the inputs column directly, so the insert is the inputs column's only writer and StampTaskBinding now stamps provenance alone. One statement, no window where a queued task lacks its inputs.Also deleted ChatPRReviewer, PRReviewResult/PRReviewFinding and the PRReviewer turn-runner field rather than leaving them unreferenced: review_pr now takes the TaskCreator that task_spawn already uses, so no bespoke interface survives.
Coverage: EffectivePRNumber round trip across both the store and a real gRPC connection (TestStateStoreConformance, local+grpc modes); review_pr tool semantics and CreateTask input forwarding in internal/gateway.
Not covered, filed separately: the dashboard half of the PRD's operator trigger (archie-core-06nq).