The identifier rule for a provider/step-type name is duplicated byte-for-byte across two packages that cannot import each other:
internal/domain/workflow/vocabulary.go:19 var stepTypeIdentifier = regexp.MustCompile(^[a-z][a-z0-9]*(?:[.-][a-z0-9]+)*$)
internal/plugin/host.go:21 var stableIdentifier = regexp.MustCompile(^[a-z][a-z0-9]*(?:[.-][a-z0-9]+)*$)
They cannot share it: internal/plugin drags the Yaegi interpreter in, so the domain package must not import it. Nothing on main ties the two copies, so one can drift from the other silently -- the "one rule, two owners, no test" class the shape lane's own review flagged.
The discarded cp/shape-superseded branch had exactly this guard and main has no equivalent:
TestStepTypeIdentifierTracksThePluginHostRule
ties this package's copy of the identifier rule to the plugin host's, which owns it.
The two packages cannot import each other (internal/plugin drags the Yaegi interpreter
in with it), so the copies are held together from the outside: the host accepts exactly
the identifiers this package's rule accepts, or this test fails.
It feeds a list of identifiers (accepts: probe, probe.gate, probe-gate, implement.prepare, a1.b2-c3; rejects: Probe.Gate, probe_gate, " probe", "probe ", probe..gate, probe., .probe, -probe, 1probe, "") to both plugin.Manifest validation and the domain rule, and fails on any disagreement.
Found while deciding whether to discard that branch (the branch was pruned 2026-09-21; its one non-duplicated artifact is this guard). Fix by porting it, or by making the domain package the single owner and having the plugin host delegate the check.
Close reason
Already satisfied in the tree: the duplicated regex is gone. internal/domain/stableid now owns the identifier grammar (Pattern + Valid), and internal/plugin/host.go:51,170, internal/domain/workflow/vocabulary.go:64,74, step_flow.go, step_refs.go and internal/domain/eda/playbook/playbook.go all call stableid.Valid. One owner, one rule, so there is nothing left to drift and no test to port.
Imported from beads archie-core-eg7s · GitHub #1139 · type task · priority P2 · created 2026-09-21 · closed 2026-10-26
The identifier rule for a provider/step-type name is duplicated byte-for-byte across two packages that cannot import each other:
internal/domain/workflow/vocabulary.go:19 var stepTypeIdentifier = regexp.MustCompile(`^[a-z][a-z0-9]*(?:[.-][a-z0-9]+)*$`)
internal/plugin/host.go:21 var stableIdentifier = regexp.MustCompile(`^[a-z][a-z0-9]*(?:[.-][a-z0-9]+)*$`)
They cannot share it: internal/plugin drags the Yaegi interpreter in, so the domain package must not import it. Nothing on main ties the two copies, so one can drift from the other silently -- the "one rule, two owners, no test" class the shape lane's own review flagged.
The discarded cp/shape-superseded branch had exactly this guard and main has no equivalent:
TestStepTypeIdentifierTracksThePluginHostRule
ties this package's copy of the identifier rule to the plugin host's, which owns it.
The two packages cannot import each other (internal/plugin drags the Yaegi interpreter
in with it), so the copies are held together from the outside: the host accepts exactly
the identifiers this package's rule accepts, or this test fails.
It feeds a list of identifiers (accepts: probe, probe.gate, probe-gate, implement.prepare, a1.b2-c3; rejects: Probe.Gate, probe_gate, " probe", "probe ", probe..gate, probe., .probe, -probe, 1probe, "") to both plugin.Manifest validation and the domain rule, and fails on any disagreement.
Found while deciding whether to discard that branch (the branch was pruned 2026-09-21; its one non-duplicated artifact is this guard). Fix by porting it, or by making the domain package the single owner and having the plugin host delegate the check.
### Close reason
Already satisfied in the tree: the duplicated regex is gone. internal/domain/stableid now owns the identifier grammar (Pattern + Valid), and internal/plugin/host.go:51,170, internal/domain/workflow/vocabulary.go:64,74, step_flow.go, step_refs.go and internal/domain/eda/playbook/playbook.go all call stableid.Valid. One owner, one rule, so there is nothing left to drift and no test to port.
---
_Imported from beads `archie-core-eg7s` · GitHub #1139 · type task · priority P2 · created 2026-09-21 · closed 2026-10-26_
sam
added the mediumtask labels 2026-10-27 13:39:49 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The identifier rule for a provider/step-type name is duplicated byte-for-byte across two packages that cannot import each other:
internal/domain/workflow/vocabulary.go:19 var stepTypeIdentifier = regexp.MustCompile(
^[a-z][a-z0-9]*(?:[.-][a-z0-9]+)*$)internal/plugin/host.go:21 var stableIdentifier = regexp.MustCompile(
^[a-z][a-z0-9]*(?:[.-][a-z0-9]+)*$)They cannot share it: internal/plugin drags the Yaegi interpreter in, so the domain package must not import it. Nothing on main ties the two copies, so one can drift from the other silently -- the "one rule, two owners, no test" class the shape lane's own review flagged.
The discarded cp/shape-superseded branch had exactly this guard and main has no equivalent:
TestStepTypeIdentifierTracksThePluginHostRule
ties this package's copy of the identifier rule to the plugin host's, which owns it.
The two packages cannot import each other (internal/plugin drags the Yaegi interpreter
in with it), so the copies are held together from the outside: the host accepts exactly
the identifiers this package's rule accepts, or this test fails.
It feeds a list of identifiers (accepts: probe, probe.gate, probe-gate, implement.prepare, a1.b2-c3; rejects: Probe.Gate, probe_gate, " probe", "probe ", probe..gate, probe., .probe, -probe, 1probe, "") to both plugin.Manifest validation and the domain rule, and fails on any disagreement.
Found while deciding whether to discard that branch (the branch was pruned 2026-09-21; its one non-duplicated artifact is this guard). Fix by porting it, or by making the domain package the single owner and having the plugin host delegate the check.
Close reason
Already satisfied in the tree: the duplicated regex is gone. internal/domain/stableid now owns the identifier grammar (Pattern + Valid), and internal/plugin/host.go:51,170, internal/domain/workflow/vocabulary.go:64,74, step_flow.go, step_refs.go and internal/domain/eda/playbook/playbook.go all call stableid.Valid. One owner, one rule, so there is nothing left to drift and no test to port.
Imported from beads
archie-core-eg7s· GitHub #1139 · type task · priority P2 · created 2026-09-21 · closed 2026-10-26